]> git.lizzy.rs Git - dragonfireclient.git/log
dragonfireclient.git
23 months agoProperly keep noclip state in Game and ClientMap
sfan5 [Sat, 21 May 2022 18:29:44 +0000 (20:29 +0200)]
Properly keep noclip state in Game and ClientMap

23 months agoRemove obsolete eye_height related workaround
sfan5 [Sat, 21 May 2022 17:27:35 +0000 (19:27 +0200)]
Remove obsolete eye_height related workaround

This was added a long time ago in 42bbd5c9ae06a8d8ffb7915599097ead6f848755
and meant to fix prevent the view becoming black when jumping into a
ceiling, this no longer happens today.

23 months agoAdd helper functions to make tool usable n times (#12047)
Wuzzy [Fri, 3 Jun 2022 19:47:04 +0000 (19:47 +0000)]
Add helper functions to make tool usable n times (#12047)

23 months agoRework main menu confirmation dialogs (#12356)
ROllerozxa [Fri, 3 Jun 2022 19:46:37 +0000 (21:46 +0200)]
Rework main menu confirmation dialogs (#12356)

23 months agoDocs: remove unimplemented `preserve` field in crafting recipes
Zughy [Fri, 3 Jun 2022 10:08:58 +0000 (12:08 +0200)]
Docs: remove unimplemented `preserve` field in crafting recipes

2 years agoFix use-after-free in node meta cleanup
sfan5 [Sun, 29 May 2022 14:00:44 +0000 (16:00 +0200)]
Fix use-after-free in node meta cleanup

bug introduced in 8908a9101608d3343023b470743ef63f1c44b0b7

2 years agoReject registering node with empty name
sfan5 [Thu, 26 May 2022 20:28:33 +0000 (22:28 +0200)]
Reject registering node with empty name

fixes #10769

2 years agoMinor code improvements around active block keeping
sfan5 [Thu, 26 May 2022 20:22:48 +0000 (22:22 +0200)]
Minor code improvements around active block keeping

2 years agoImmediately activate blocks when a player joins
sfan5 [Thu, 26 May 2022 20:14:22 +0000 (22:14 +0200)]
Immediately activate blocks when a player joins

issue: #10884
This makes it possible for objects to immediately be activated,
but doesn't guarantee it since blocks may still need be emerged.

2 years agoRemove debug.get/setmetatable from security whitelist
stefan [Wed, 25 May 2022 09:46:12 +0000 (11:46 +0200)]
Remove debug.get/setmetatable from security whitelist

fixes #12216

2 years agoDon't allow banning in singleplayer
sfan5 [Thu, 26 May 2022 19:36:58 +0000 (21:36 +0200)]
Don't allow banning in singleplayer

fixes #11819

2 years agoHandle lua entity HP changes correctly (like punches)
sfan5 [Thu, 26 May 2022 19:32:51 +0000 (21:32 +0200)]
Handle lua entity HP changes correctly (like punches)

fixes #11975

2 years agoMake sure real disconnect reason isn't overwritten
sfan5 [Thu, 26 May 2022 18:47:16 +0000 (20:47 +0200)]
Make sure real disconnect reason isn't overwritten

bug introduced in 2f32044273d107e82fb1c35d4a0f616fa480cdf0

2 years agoFix linking with Postgres libs on older cmake versions
sfan5 [Thu, 26 May 2022 16:01:37 +0000 (18:01 +0200)]
Fix linking with Postgres libs on older cmake versions

closes #12149

2 years agoRemove remains of video mode querying
sfan5 [Thu, 26 May 2022 15:41:23 +0000 (17:41 +0200)]
Remove remains of video mode querying

2 years agoGet rid of node metadata when it becomes empty
sfan5 [Thu, 26 May 2022 13:45:34 +0000 (15:45 +0200)]
Get rid of node metadata when it becomes empty

fixes #8943

2 years agoOptimize Server::sendMetadataChanged a bit
sfan5 [Thu, 26 May 2022 12:40:00 +0000 (14:40 +0200)]
Optimize Server::sendMetadataChanged a bit

The distance check also never worked as intended, now fixed.

2 years agoAdd API function to invoke player respawn
sfan5 [Wed, 25 May 2022 17:29:11 +0000 (19:29 +0200)]
Add API function to invoke player respawn

closes #12272

2 years agoProtect a few more settings from being set from mods
sfan5 [Wed, 25 May 2022 17:07:49 +0000 (19:07 +0200)]
Protect a few more settings from being set from mods

Of those settings main_menu_script has concrete security impact, the rest are added out of abundance of caution.

2 years agoMap opaque waving leaves to allfaces drawtype
sfan5 [Wed, 25 May 2022 17:00:34 +0000 (19:00 +0200)]
Map opaque waving leaves to allfaces drawtype

fixes #9842

2 years agoImprove a translation string
sfan5 [Wed, 25 May 2022 16:27:34 +0000 (18:27 +0200)]
Improve a translation string

fixes #11442

2 years agoDefault settings, presets and configuration for dynamic shadows (#12359)
x2048 [Sun, 29 May 2022 11:58:57 +0000 (13:58 +0200)]
Default settings, presets and configuration for dynamic shadows (#12359)

2 years agoLua workflow: Use Leafo's Luarocks action
Lars Müller [Sat, 28 May 2022 09:31:56 +0000 (11:31 +0200)]
Lua workflow: Use Leafo's Luarocks action

instead of installing outdated packages which lead to failing workflows

2 years agoBuiltin: Optimize misc helpers (#12377)
Lars Müller [Fri, 27 May 2022 19:40:38 +0000 (21:40 +0200)]
Builtin: Optimize misc helpers (#12377)

Also add formspec_escape unit test

2 years agoDevTest: Add nodes and items for testing overlays (#12304)
Wuzzy [Fri, 27 May 2022 19:39:36 +0000 (19:39 +0000)]
DevTest: Add nodes and items for testing overlays (#12304)

2 years agoForce-update shadows when the world is changed (#12364)
x2048 [Thu, 26 May 2022 20:28:34 +0000 (22:28 +0200)]
Force-update shadows when the world is changed (#12364)

2 years agoReduce size of ContentFeatures structure
sfan5 [Mon, 9 May 2022 18:59:28 +0000 (20:59 +0200)]
Reduce size of ContentFeatures structure

On my system this is a reduction from 4664 to 3704 bytes.
This is not for the sake of saving RAM but ensuring
commonly used structures fit into caches better.

2 years agoGet rid of global buffer that would ruin concurrent MapBlock serialization
sfan5 [Mon, 9 May 2022 18:00:22 +0000 (20:00 +0200)]
Get rid of global buffer that would ruin concurrent MapBlock serialization

2 years agoImprove code in mapblock_mesh.cpp a bit
sfan5 [Mon, 9 May 2022 17:28:27 +0000 (19:28 +0200)]
Improve code in mapblock_mesh.cpp a bit

2 years agoQuantize light frustum calculations (#12357)
x2048 [Mon, 23 May 2022 21:45:18 +0000 (23:45 +0200)]
Quantize light frustum calculations (#12357)

* Quantize light frustum calculations

Reduces shadow flicker

* Fix function name to match conventions

2 years agoFormally drop support for building with upstream Irrlicht
sfan5 [Sat, 21 May 2022 22:52:11 +0000 (00:52 +0200)]
Formally drop support for building with upstream Irrlicht

It stopped working with (at least) the last commit.

2 years agoFix hash implementation for SerializedBlockCache
sfan5 [Sat, 21 May 2022 22:37:58 +0000 (00:37 +0200)]
Fix hash implementation for SerializedBlockCache

2 years agoUse unordered_map instead of map for MapSectors
Richard Try [Mon, 23 May 2022 20:50:49 +0000 (23:50 +0300)]
Use unordered_map instead of map for MapSectors

2 years agoAdd missing concurrency protection in logger (#12325)
paradust7 [Mon, 23 May 2022 20:50:25 +0000 (13:50 -0700)]
Add missing concurrency protection in logger (#12325)

2 years agoFix no_texture.png for unknown nodes with ID < 125 (#12329)
Wuzzy [Mon, 23 May 2022 20:50:10 +0000 (20:50 +0000)]
Fix no_texture.png for unknown nodes with ID < 125 (#12329)

2 years agoDocs: clarify spawn_by for decorations
Zughy [Mon, 23 May 2022 20:49:48 +0000 (22:49 +0200)]
Docs: clarify spawn_by for decorations

2 years agoAdd missing comma in example in lua_api.txt (#12339)
Wuzzy [Sun, 22 May 2022 19:23:04 +0000 (19:23 +0000)]
Add missing comma in example in lua_api.txt (#12339)

2 years agoAdd relative numbers for commands by prepending ~ (#9588)
Wuzzy [Sun, 22 May 2022 14:28:24 +0000 (14:28 +0000)]
Add relative numbers for commands by prepending ~ (#9588)

* Add relative numbers for commands by prepending ~

* Some builtin code cleanup

* Disallow nan and inf in minetest.string_to_area

* Remove unused local variable teleportee (makes Luacheck happy)

* Clean up core.string_to_pos

* Make area parsing less permissive

* Rewrite tests as busted tests

* /time: Fix negative minutes not working

Co-authored-by: Lars Mueller <appgurulars@gmx.de>
2 years agoReplace all uses of core::list with std::list (#12313)
paradust7 [Sat, 21 May 2022 22:11:59 +0000 (15:11 -0700)]
Replace all uses of core::list with std::list (#12313)

2 years agoFixes needed to use irrArray backed by std::vector (#12263)
paradust7 [Sat, 21 May 2022 22:11:49 +0000 (15:11 -0700)]
Fixes needed to use irrArray backed by std::vector (#12263)

2 years agoBump IrrlichtMt version in CI
sfan5 [Sat, 21 May 2022 22:11:22 +0000 (00:11 +0200)]
Bump IrrlichtMt version in CI

2 years agoDon't ignore server disconnects in client code
sfan5 [Fri, 6 May 2022 18:13:45 +0000 (20:13 +0200)]
Don't ignore server disconnects in client code

If the server stops talking to us without saying bye we
should actually end the in-game session with an error message.

2 years agoFixes to Android build + option to turn LuaJIT on/off for testing purposes (#12334)
paradust7 [Sat, 21 May 2022 15:48:40 +0000 (08:48 -0700)]
Fixes to Android build + option to turn LuaJIT on/off for testing purposes (#12334)

2 years agoMake no_screenshot image more clear (#12346)
Zughy [Sat, 21 May 2022 15:48:28 +0000 (17:48 +0200)]
Make no_screenshot image more clear (#12346)

2 years agoPatch built-in Lua to fix miscompile on Android (#12347)
paradust7 [Sat, 21 May 2022 15:46:50 +0000 (08:46 -0700)]
Patch built-in Lua to fix miscompile on Android (#12347)

2 years agoOptimize JSON string (de)serialization routines
sfan5 [Sun, 1 May 2022 11:44:42 +0000 (13:44 +0200)]
Optimize JSON string (de)serialization routines

stringstreams were shown to be slow when reading/writing single characters
and there is lots of potential by having functions perform on existing
buffers whenever possible.

2 years agoImprove testSerializeJsonString unit tests
sfan5 [Sun, 1 May 2022 11:43:29 +0000 (13:43 +0200)]
Improve testSerializeJsonString unit tests

this also removes the requirement that / is escaped, there is
no reason for doing so.

2 years agoDeprecate game.conf name, use title instead (#12030)
rubenwardy [Sat, 21 May 2022 15:23:30 +0000 (16:23 +0100)]
Deprecate game.conf name, use title instead (#12030)

2 years agoImprove shadow filters (#12195)
x2048 [Sat, 21 May 2022 14:49:30 +0000 (16:49 +0200)]
Improve shadow filters (#12195)

* Rewrite shadow filtering for the new distortion
* Calculate penumbra radius using a single sample
* Avoid peter-panning effect due to filtering of short shadows
* Add adaptive filter quality for soft shadows
* Avoid sharp shadows on surfaces without normals (e.g. plants)
* Increase default and maximum soft shadow radius
* Make line numbers in shader errors match the code

2 years agoFix lighting of upright_sprite entities (#12336)
x2048 [Fri, 20 May 2022 20:35:03 +0000 (22:35 +0200)]
Fix lighting of upright_sprite entities (#12336)

Use MeshNode materials to set the light since ReadOnlyMaterials is now false

2 years agoFix lighting of the wield mesh (#12341)
x2048 [Fri, 20 May 2022 20:33:52 +0000 (22:33 +0200)]
Fix lighting of the wield mesh (#12341)

* Assign node light to player before final color blend.
  Fixes day/night lightbank ratio for wield meshes
* Update wield mesh light when changing mesh

2 years agoUse std::map instead of core::map (#12301)
paradust7 [Wed, 18 May 2022 10:31:49 +0000 (03:31 -0700)]
Use std::map instead of core::map (#12301)

2 years agoRemove confusing message in keybindings menu
savilli [Tue, 17 May 2022 18:11:08 +0000 (21:11 +0300)]
Remove confusing message in keybindings menu

2 years agoAdd vcs-browser and contribute URLs to Appdata
JakobDev [Tue, 17 May 2022 18:08:32 +0000 (20:08 +0200)]
Add vcs-browser and contribute URLs to Appdata

2 years agoDevTest: Fix broken PNG textures
Wuzzy [Tue, 17 May 2022 18:06:15 +0000 (18:06 +0000)]
DevTest: Fix broken PNG textures

2 years agoInitialize wield mesh color when wield_image is set
Dmitry Kostenko [Sun, 15 May 2022 19:44:55 +0000 (21:44 +0200)]
Initialize wield mesh color when wield_image is set

#12245

2 years agoUse native packer to transfer globals into async env(s)
sfan5 [Mon, 9 May 2022 16:20:10 +0000 (18:20 +0200)]
Use native packer to transfer globals into async env(s)

2 years agoSupport packing arbitrary graphs (#12289)
Jude Melton-Houghton [Tue, 10 May 2022 20:37:33 +0000 (16:37 -0400)]
Support packing arbitrary graphs (#12289)

2 years agoFix cooking and fuel crafts with aliases
Jude Melton-Houghton [Mon, 9 May 2022 22:21:08 +0000 (18:21 -0400)]
Fix cooking and fuel crafts with aliases

2 years agoAdd doc to list breaking changes for the next major release
Zughy [Tue, 10 May 2022 20:36:50 +0000 (22:36 +0200)]
Add doc to list breaking changes for the next major release

2 years agoFix possible unreliable behavior due to uninitialized variables
Octavian [Tue, 10 May 2022 10:34:59 +0000 (13:34 +0300)]
Fix possible unreliable behavior due to uninitialized variables

2 years agoAdd more Prometheus metrics (#12274)
sfan5 [Mon, 9 May 2022 19:20:58 +0000 (21:20 +0200)]
Add more Prometheus metrics (#12274)

2 years agoHUD: Update selection mesh every frame (#12270)
Lars Müller [Mon, 9 May 2022 18:43:47 +0000 (20:43 +0200)]
HUD: Update selection mesh every frame (#12270)

Fixes outdated selection boxes after entity property changes.

2 years agoFix Minetest blaming the wrong mod for errors (#12241)
Lars Müller [Mon, 9 May 2022 18:42:43 +0000 (20:42 +0200)]
Fix Minetest blaming the wrong mod for errors (#12241)

Covers the case where mods insert their callbacks manually into "minetest.registered_<callbacks>" (often to achieve a particular order of execution).

2 years agoDocs: Recommend `self.name` (#12239)
Lars Müller [Mon, 9 May 2022 18:41:47 +0000 (20:41 +0200)]
Docs: Recommend `self.name` (#12239)

2 years agoConsolidate some data structures in MapBlockMesh
sfan5 [Fri, 6 May 2022 07:54:04 +0000 (09:54 +0200)]
Consolidate some data structures in MapBlockMesh

2 years agoCache serialized mapblocks during sending
sfan5 [Thu, 5 May 2022 20:03:49 +0000 (22:03 +0200)]
Cache serialized mapblocks during sending

This reduces the
(absolute) time spent in Server::SendBlocks() from 700ms to 300ms
(relative) share of MapBlock::serialize() from 80% to 60%
in a test setup with 10 players and many block changes

2 years agoitem_entity: Cache collisionbox for use in on_step
sfan5 [Thu, 5 May 2022 18:49:57 +0000 (20:49 +0200)]
item_entity: Cache collisionbox for use in on_step

I don't have absolute numbers but if calls to get_properties() take up
30%+ of on_step() execution time that's bound to matter.

2 years agoFix mapblock geometry optimisation not working
ROllerozxa [Sat, 7 May 2022 17:41:11 +0000 (19:41 +0200)]
Fix mapblock geometry optimisation not working

Caused by the depth sorting PR marking not only transparent nodes to be ignored but also opaque ones with the TILE_MATERIAL_BASIC material type

2 years agoRemove unused variable WARN_INIT
Zughy [Sun, 8 May 2022 17:11:15 +0000 (19:11 +0200)]
Remove unused variable WARN_INIT

2 years agoEnable dependencies when enabling modpacks (#12202)
Jude Melton-Houghton [Sun, 8 May 2022 15:21:59 +0000 (11:21 -0400)]
Enable dependencies when enabling modpacks (#12202)

2 years agoFix enabling of dependencies with identical names (#12253)
Jude Melton-Houghton [Sun, 8 May 2022 13:14:14 +0000 (09:14 -0400)]
Fix enabling of dependencies with identical names (#12253)

2 years agoFix mods not being recursively enabled
rubenwardy [Sun, 8 May 2022 13:01:32 +0000 (14:01 +0100)]
Fix mods not being recursively enabled

Fixes #12290

2 years agoFix texture packs showing as "Nil (enabled)" in Content tab
rubenwardy [Sat, 7 May 2022 22:05:24 +0000 (23:05 +0100)]
Fix texture packs showing as "Nil (enabled)" in Content tab

Fixes #12285

2 years agoAdd benchmarks for json string serialize/deserialize (#12258)
paradust7 [Fri, 6 May 2022 20:17:16 +0000 (13:17 -0700)]
Add benchmarks for json string serialize/deserialize (#12258)

Co-authored-by: sfan5 <sfan5@live.de>
2 years agoEnable chat clickable weblinks by default (#12115)
Froggo [Fri, 6 May 2022 20:15:16 +0000 (15:15 -0500)]
Enable chat clickable weblinks by default (#12115)

Co-authored-by: rubenwardy <rw@rubenwardy.com>
2 years agoBump IrrlichtMt to 1.9.0mt5 in CI
sfan5 [Fri, 6 May 2022 12:45:59 +0000 (14:45 +0200)]
Bump IrrlichtMt to 1.9.0mt5 in CI

2 years agoDeclare all bundled libs as static
sfan5 [Fri, 6 May 2022 12:42:56 +0000 (14:42 +0200)]
Declare all bundled libs as static

Otherwise it can happen that these are built as shared depending on the
options passed to CMake, which obviously isn't intended.

2 years agoSort out some issues with our CI setup
sfan5 [Sun, 1 May 2022 12:44:48 +0000 (14:44 +0200)]
Sort out some issues with our CI setup

* add missing apt-get update where needed
* move some jobs to run on ubuntu-20.04
* update actions plugins to latest
* speed up the job that runs multiplayer tests

2 years agoFix Windows Visual Studio actions (#11176)
LoneWolfHT [Wed, 4 May 2022 21:55:02 +0000 (14:55 -0700)]
Fix Windows Visual Studio actions (#11176)

Co-authored-by: rubenwardy <rw@rubenwardy.com>
2 years agoAvoid rendering invisible faces of simple nodeboxes (#12262)
x2048 [Wed, 4 May 2022 21:44:55 +0000 (23:44 +0200)]
Avoid rendering invisible faces of simple nodeboxes (#12262)

* Skip rendering faces adjacent to opaque nodes
* Cancel out opposite faces of adjacent nodebox nodes of the same type

Fixes #6409

2 years agohud_get: Return precision field for waypoints (#12215)
Lars Müller [Wed, 4 May 2022 18:55:20 +0000 (20:55 +0200)]
hud_get: Return precision field for waypoints (#12215)

2 years agoguiScalingFilter: Fix most memory leaks (#12256)
SmallJoker [Wed, 4 May 2022 18:55:13 +0000 (20:55 +0200)]
guiScalingFilter: Fix most memory leaks (#12256)

Calls to the cache function ended up creating a new texture regardless whether
the texture is already cached.

2 years agoMake logging cost free when there is no output target (#12247)
paradust7 [Wed, 4 May 2022 18:55:01 +0000 (11:55 -0700)]
Make logging cost free when there is no output target (#12247)

The logging streams now do almost no work when there is no output target for them.

For example, if LL_VERBOSE has no output targets, then `verbosestream << x` will return a StreamProxy with a null target. Any further `<<` operations applied to it will do nothing.

2 years agoAdd vector.combine (#11920)
Lars Müller [Wed, 4 May 2022 11:44:14 +0000 (13:44 +0200)]
Add vector.combine (#11920)

2 years agoContentDB: Fix ungraceful crash on aliases when list download fails
rubenwardy [Mon, 25 Apr 2022 19:43:09 +0000 (20:43 +0100)]
ContentDB: Fix ungraceful crash on aliases when list download fails

Fixes #12267 and fixes #12154

2 years agoFix broken FPS/dtime counters in debug info
sfan5 [Tue, 3 May 2022 18:14:34 +0000 (20:14 +0200)]
Fix broken FPS/dtime counters in debug info

was broken by a89afe1229e327da3c397a3912b2d43d2196ea2b

2 years agoAsync environment for mods to do concurrent tasks (#11131)
sfan5 [Mon, 2 May 2022 18:55:04 +0000 (20:55 +0200)]
Async environment for mods to do concurrent tasks (#11131)

2 years agoFix synchronization issue at thread start
sfan5 [Sat, 30 Apr 2022 14:04:19 +0000 (16:04 +0200)]
Fix synchronization issue at thread start

If a newly started thread immediately exits then m_running would
immediately be set to false again and the caller would be stuck
waiting for m_running to become true forever.
Since a mutex for synchronizing startup already exists we can
simply move the while loop into it.

see also: #5134 which introduced m_start_finished_mutex

2 years agoRefactor some Lua API functions in preparation for async env
sfan5 [Sat, 9 Apr 2022 12:47:59 +0000 (14:47 +0200)]
Refactor some Lua API functions in preparation for async env

2 years agoReorganize some builtin functions in preparation for async env
sfan5 [Sat, 9 Apr 2022 11:53:32 +0000 (13:53 +0200)]
Reorganize some builtin functions in preparation for async env

2 years agoRemove some unused variable from Lua class wrappers
sfan5 [Fri, 8 Apr 2022 13:52:22 +0000 (15:52 +0200)]
Remove some unused variable from Lua class wrappers

2 years agoAdd German translation to AppData file (#12161)
JakobDev [Mon, 2 May 2022 16:22:23 +0000 (18:22 +0200)]
Add German translation to AppData file (#12161)

2 years agoInitialize wield mesh colors when changing item. (#12254)
x2048 [Sun, 1 May 2022 15:21:00 +0000 (17:21 +0200)]
Initialize wield mesh colors when changing item. (#12254)

Fixes #12245

2 years agoDeal with compiler warnings
sfan5 [Thu, 28 Apr 2022 18:53:15 +0000 (20:53 +0200)]
Deal with compiler warnings

2 years agoEnable additional warning flags
sfan5 [Thu, 28 Apr 2022 18:26:54 +0000 (20:26 +0200)]
Enable additional warning flags

also make them work with the RelWithDebInfo build type

2 years agoRun automated tests when lua files change (#12184)
x2048 [Sat, 30 Apr 2022 13:54:07 +0000 (15:54 +0200)]
Run automated tests when lua files change (#12184)

* Run automated tests when lua files change

* skip busted on devtest

* use newer build env

* Add .luacheckrc for games/devetest

Co-authored-by: sfan5 <sfan5@live.de>
2 years agoUpdate mods_here.txt to mention installing mods via CDB (#11876)
qwerty123a2 [Fri, 29 Apr 2022 16:15:19 +0000 (02:15 +1000)]
Update mods_here.txt to mention installing mods via CDB (#11876)

Co-authored-by: rubenwardy <rw@rubenwardy.com>
2 years agoClean up some auth packet handling related code
sfan5 [Wed, 27 Apr 2022 17:55:13 +0000 (19:55 +0200)]
Clean up some auth packet handling related code

2 years agoFix password changing getting stuck if wrong password is entered once
sfan5 [Wed, 27 Apr 2022 17:32:51 +0000 (19:32 +0200)]
Fix password changing getting stuck if wrong password is entered once