Fix infinite loop in `find_closest_node`

If `ref->node == NULL` and `ref->desktop->root != NULL` (the reference
desktop contains hidden nodes or/and receptacles), then the ending
condition `n != ref->node` will never be true.

Fixes #977.

diff --git a/src/tree.c b/src/tree.c
index c57d034919fcc52da793f20b121e3fd4d09e99b0..6b522d143207cc627b643f4a5861b5895383dd3b 100644 (file)
--- a/src/tree.c
+++ b/src/tree.c
@@ -1626,6 +1626,9 @@ bool find_closest_node(coordinates_t *ref, coordinates_t *dst, cycle_dir_t dir,
                }
                n = (dir == CYCLE_PREV ? prev_leaf(n, d->root) : next_leaf(n, d->root));
                HANDLE_BOUNDARIES(m, d, n);
+               if (ref->node == NULL && d == ref->desktop) {
+                       break;
+               }
        }
 #undef HANDLE_BOUNDARIES
        return false;