srp: fix some low-hanging clippy warnings

diff --git a/srp/src/client.rs b/srp/src/client.rs
index 8d10b84b1009bfa35b0e21f78f86b76547546fed..57c29c8f3c6b43a72282f527af21247c79cb535c 100644 (file)
--- a/srp/src/client.rs
+++ b/srp/src/client.rs
@@ -133,7 +133,7 @@ impl<'a, D: Digest> SrpClient<'a, D> {
         let k = self.params.compute_k::<D>();
         let interm = (k * self.params.powm(x)) % n;
         // Because we do operation in modulo N we can get: (kv + g^b) < kv
-        let v = if b_pub > &interm {
+        let v = if *b_pub > interm {
             (b_pub - &interm) % n
         } else {
             (n + b_pub - &interm) % n
@@ -186,9 +186,9 @@ impl<'a, D: Digest> SrpClient<'a, D> {
         };
 
         Ok(SrpClientVerifier {
-            proof: proof,
-            server_proof: server_proof,
-            key: key,
+            proof,
+            server_proof,
+            key,
         })
     }
 

diff --git a/srp/src/tools.rs b/srp/src/tools.rs
index 8cb69109df3ecd7525e1454807352592b998d5a5..4fc5db9f19fdb74d5bd11aa662aa581fe46a0139 100644 (file)
--- a/srp/src/tools.rs
+++ b/srp/src/tools.rs
@@ -12,7 +12,7 @@ pub fn powm(base: &BigUint, exp: &BigUint, modulus: &BigUint) -> BigUint {
         if &exp % &two == one {
             result = (result * &base) % modulus;
         }
-        exp = exp >> 1;
+        exp >>= 1;
         base = (&base * &base) % modulus;
     }
     result