From f5e2e02aa9864f5c929ff36f99cde5fd4be2544e Mon Sep 17 00:00:00 2001 From: veetaha Date: Sun, 10 May 2020 21:06:12 +0300 Subject: [PATCH] Converted TODO about MacroItems to FIXME as per edwin0cheng --- crates/ra_syntax/src/ast/generated/nodes.rs | 8 ++------ xtask/src/ast_src.rs | 11 +++-------- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/crates/ra_syntax/src/ast/generated/nodes.rs b/crates/ra_syntax/src/ast/generated/nodes.rs index 29345dc05c8..72977a3c639 100644 --- a/crates/ra_syntax/src/ast/generated/nodes.rs +++ b/crates/ra_syntax/src/ast/generated/nodes.rs @@ -2461,12 +2461,8 @@ pub fn literal(&self) -> Option { support::child(&self.syntax) } pub fn eq_token(&self) -> Option { support::token(&self.syntax, T![=]) } pub fn block_expr(&self) -> Option { support::child(&self.syntax) } } -/// Macro items is a node that holds all the items created by expanding a macro. -/// -/// ``` -/// foo!(); // expands into some items -v -/// // ❰ struct Foo; impl Bar for Foo; ❱ -/// ``` +/// FIXME: (@edwin0cheng) Remove it to use ItemList instead +/// https://github.com/rust-analyzer/rust-analyzer/pull/4083#discussion_r422666243 /// /// [Reference](https://doc.rust-lang.org/reference/macros.html) #[derive(Debug, Clone, PartialEq, Eq, Hash)] diff --git a/xtask/src/ast_src.rs b/xtask/src/ast_src.rs index 8999efc75e1..821b133781f 100644 --- a/xtask/src/ast_src.rs +++ b/xtask/src/ast_src.rs @@ -1990,14 +1990,9 @@ struct LifetimeArg { T![lifetime] } /// [RFC](https://github.com/rust-lang/rfcs/blob/master/text/2000-const-generics.md#declaring-a-const-parameter) struct ConstArg { Literal, T![=], BlockExpr } - // TODO: Idk what I am writing here, please don't believe these words. - // TODO: clarify @matklad @edwin0cheng - /// Macro items is a node that holds all the items created by expanding a macro. - /// - /// ``` - /// foo!(); // expands into some items -v - /// // ❰ struct Foo; impl Bar for Foo; ❱ - /// ``` + + /// FIXME: (@edwin0cheng) Remove it to use ItemList instead + /// https://github.com/rust-analyzer/rust-analyzer/pull/4083#discussion_r422666243 /// /// [Reference](https://doc.rust-lang.org/reference/macros.html) struct MacroItems: ModuleItemOwner { } -- 2.44.0