From ea12f909c3774fdd53b136079ddf31caf51dd59f Mon Sep 17 00:00:00 2001 From: Brian Warner Date: Thu, 6 Dec 2018 11:56:51 -0800 Subject: [PATCH] srp: fix some low-hanging clippy warnings --- srp/src/client.rs | 8 ++++---- srp/src/tools.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/srp/src/client.rs b/srp/src/client.rs index 8d10b84..57c29c8 100644 --- a/srp/src/client.rs +++ b/srp/src/client.rs @@ -133,7 +133,7 @@ impl<'a, D: Digest> SrpClient<'a, D> { let k = self.params.compute_k::(); let interm = (k * self.params.powm(x)) % n; // Because we do operation in modulo N we can get: (kv + g^b) < kv - let v = if b_pub > &interm { + let v = if *b_pub > interm { (b_pub - &interm) % n } else { (n + b_pub - &interm) % n @@ -186,9 +186,9 @@ impl<'a, D: Digest> SrpClient<'a, D> { }; Ok(SrpClientVerifier { - proof: proof, - server_proof: server_proof, - key: key, + proof, + server_proof, + key, }) } diff --git a/srp/src/tools.rs b/srp/src/tools.rs index 8cb6910..4fc5db9 100644 --- a/srp/src/tools.rs +++ b/srp/src/tools.rs @@ -12,7 +12,7 @@ pub fn powm(base: &BigUint, exp: &BigUint, modulus: &BigUint) -> BigUint { if &exp % &two == one { result = (result * &base) % modulus; } - exp = exp >> 1; + exp >>= 1; base = (&base * &base) % modulus; } result -- 2.44.0