From e723fe07783cd9b797c9f1456d359879bba44907 Mon Sep 17 00:00:00 2001 From: Simonas Kazlauskas Date: Sun, 4 Jan 2015 14:58:08 +0200 Subject: [PATCH] Do not use entropy during gen_weighted_bool(1) 1 in 1 chance to return true always results in true. --- src/librand/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/librand/lib.rs b/src/librand/lib.rs index 0f8dbc78cde..18f508e816f 100644 --- a/src/librand/lib.rs +++ b/src/librand/lib.rs @@ -243,7 +243,7 @@ fn gen_range(&mut self, low: T, high: T) -> T { /// println!("{}", rng.gen_weighted_bool(3)); /// ``` fn gen_weighted_bool(&mut self, n: uint) -> bool { - n == 0 || self.gen_range(0, n) == 0 + n <= 1 || self.gen_range(0, n) == 0 } /// Return an iterator of random characters from the set A-Z,a-z,0-9. -- 2.44.0