From d5ea294114014f080e11b23abdc09c7d645547ad Mon Sep 17 00:00:00 2001 From: LeSeulArtichaut Date: Sun, 14 Mar 2021 22:25:42 +0100 Subject: [PATCH] Test `-Zthir-unsafeck` for unused unsafe blocks --- ...ue-48131.stderr => issue-48131.mir.stderr} | 6 +++--- src/test/ui/issues/issue-48131.rs | 3 +++ src/test/ui/issues/issue-48131.thir.stderr | 20 +++++++++++++++++++ ...ound-compiler-generated-unsafe.mir.stderr} | 4 ++-- ...unsafe-around-compiler-generated-unsafe.rs | 3 +++ ...ound-compiler-generated-unsafe.thir.stderr | 14 +++++++++++++ 6 files changed, 45 insertions(+), 5 deletions(-) rename src/test/ui/issues/{issue-48131.stderr => issue-48131.mir.stderr} (81%) create mode 100644 src/test/ui/issues/issue-48131.thir.stderr rename src/test/ui/unsafe/{unsafe-around-compiler-generated-unsafe.stderr => unsafe-around-compiler-generated-unsafe.mir.stderr} (69%) create mode 100644 src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.thir.stderr diff --git a/src/test/ui/issues/issue-48131.stderr b/src/test/ui/issues/issue-48131.mir.stderr similarity index 81% rename from src/test/ui/issues/issue-48131.stderr rename to src/test/ui/issues/issue-48131.mir.stderr index 5acc4f16e9f..6817e8830c5 100644 --- a/src/test/ui/issues/issue-48131.stderr +++ b/src/test/ui/issues/issue-48131.mir.stderr @@ -1,17 +1,17 @@ error: unnecessary `unsafe` block - --> $DIR/issue-48131.rs:9:9 + --> $DIR/issue-48131.rs:12:9 | LL | unsafe { /* unnecessary */ } | ^^^^^^ unnecessary `unsafe` block | note: the lint level is defined here - --> $DIR/issue-48131.rs:3:9 + --> $DIR/issue-48131.rs:6:9 | LL | #![deny(unused_unsafe)] | ^^^^^^^^^^^^^ error: unnecessary `unsafe` block - --> $DIR/issue-48131.rs:20:13 + --> $DIR/issue-48131.rs:23:13 | LL | unsafe { /* unnecessary */ } | ^^^^^^ unnecessary `unsafe` block diff --git a/src/test/ui/issues/issue-48131.rs b/src/test/ui/issues/issue-48131.rs index 85664e62ead..df98547084d 100644 --- a/src/test/ui/issues/issue-48131.rs +++ b/src/test/ui/issues/issue-48131.rs @@ -1,3 +1,6 @@ +// revisions: mir thir +// [thir]compile-flags: -Z thir-unsafeck + // This note is annotated because the purpose of the test // is to ensure that certain other notes are not generated. #![deny(unused_unsafe)] //~ NOTE diff --git a/src/test/ui/issues/issue-48131.thir.stderr b/src/test/ui/issues/issue-48131.thir.stderr new file mode 100644 index 00000000000..6817e8830c5 --- /dev/null +++ b/src/test/ui/issues/issue-48131.thir.stderr @@ -0,0 +1,20 @@ +error: unnecessary `unsafe` block + --> $DIR/issue-48131.rs:12:9 + | +LL | unsafe { /* unnecessary */ } + | ^^^^^^ unnecessary `unsafe` block + | +note: the lint level is defined here + --> $DIR/issue-48131.rs:6:9 + | +LL | #![deny(unused_unsafe)] + | ^^^^^^^^^^^^^ + +error: unnecessary `unsafe` block + --> $DIR/issue-48131.rs:23:13 + | +LL | unsafe { /* unnecessary */ } + | ^^^^^^ unnecessary `unsafe` block + +error: aborting due to 2 previous errors + diff --git a/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.stderr b/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.mir.stderr similarity index 69% rename from src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.stderr rename to src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.mir.stderr index 0dba8496efd..68101326861 100644 --- a/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.stderr +++ b/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.mir.stderr @@ -1,11 +1,11 @@ error: unnecessary `unsafe` block - --> $DIR/unsafe-around-compiler-generated-unsafe.rs:6:5 + --> $DIR/unsafe-around-compiler-generated-unsafe.rs:9:5 | LL | unsafe { println!("foo"); } | ^^^^^^ unnecessary `unsafe` block | note: the lint level is defined here - --> $DIR/unsafe-around-compiler-generated-unsafe.rs:3:9 + --> $DIR/unsafe-around-compiler-generated-unsafe.rs:6:9 | LL | #![deny(unused_unsafe)] | ^^^^^^^^^^^^^ diff --git a/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.rs b/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.rs index 817939e0757..08801f9ef59 100644 --- a/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.rs +++ b/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.rs @@ -1,5 +1,8 @@ // issue #12418 +// revisions: mir thir +// [thir]compile-flags: -Z thir-unsafeck + #![deny(unused_unsafe)] fn main() { diff --git a/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.thir.stderr b/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.thir.stderr new file mode 100644 index 00000000000..68101326861 --- /dev/null +++ b/src/test/ui/unsafe/unsafe-around-compiler-generated-unsafe.thir.stderr @@ -0,0 +1,14 @@ +error: unnecessary `unsafe` block + --> $DIR/unsafe-around-compiler-generated-unsafe.rs:9:5 + | +LL | unsafe { println!("foo"); } + | ^^^^^^ unnecessary `unsafe` block + | +note: the lint level is defined here + --> $DIR/unsafe-around-compiler-generated-unsafe.rs:6:9 + | +LL | #![deny(unused_unsafe)] + | ^^^^^^^^^^^^^ + +error: aborting due to previous error + -- 2.44.0