From cfbee8d3a35f81e710b17e48b8018cd6076a8133 Mon Sep 17 00:00:00 2001
From: Igor Aleksanov <popzxc@yandex.ru>
Date: Sun, 4 Oct 2020 07:42:06 +0300
Subject: [PATCH] Remove previously added parameter names from the function
 data

---
 crates/hir_def/src/data.rs            |  2 --
 crates/hir_def/src/item_tree.rs       |  2 --
 crates/hir_def/src/item_tree/lower.rs | 14 --------------
 3 files changed, 18 deletions(-)

diff --git a/crates/hir_def/src/data.rs b/crates/hir_def/src/data.rs
index 733db2eaca6..ff1ef0df64e 100644
--- a/crates/hir_def/src/data.rs
+++ b/crates/hir_def/src/data.rs
@@ -19,7 +19,6 @@
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct FunctionData {
     pub name: Name,
-    pub param_names: Vec<Option<Name>>,
     pub params: Vec<TypeRef>,
     pub ret_type: TypeRef,
     pub attrs: Attrs,
@@ -40,7 +39,6 @@ pub(crate) fn fn_data_query(db: &dyn DefDatabase, func: FunctionId) -> Arc<Funct
 
         Arc::new(FunctionData {
             name: func.name.clone(),
-            param_names: func.param_names.to_vec(),
             params: func.params.to_vec(),
             ret_type: func.ret_type.clone(),
             attrs: item_tree.attrs(ModItem::from(loc.id.value).into()).clone(),
diff --git a/crates/hir_def/src/item_tree.rs b/crates/hir_def/src/item_tree.rs
index ca502ce2ba1..8a1121bbdfb 100644
--- a/crates/hir_def/src/item_tree.rs
+++ b/crates/hir_def/src/item_tree.rs
@@ -507,8 +507,6 @@ pub struct Function {
     pub has_self_param: bool,
     pub has_body: bool,
     pub is_unsafe: bool,
-    /// List of function parameters names. Does not include `self`.
-    pub param_names: Box<[Option<Name>]>,
     pub params: Box<[TypeRef]>,
     pub is_varargs: bool,
     pub ret_type: TypeRef,
diff --git a/crates/hir_def/src/item_tree/lower.rs b/crates/hir_def/src/item_tree/lower.rs
index 2ffa46ac0ee..3328639cfe3 100644
--- a/crates/hir_def/src/item_tree/lower.rs
+++ b/crates/hir_def/src/item_tree/lower.rs
@@ -283,7 +283,6 @@ fn lower_function(&mut self, func: &ast::Fn) -> Option<FileItemTreeId<Function>>
         let name = func.name()?.as_name();
 
         let mut params = Vec::new();
-        let mut param_names = Vec::new();
         let mut has_self_param = false;
         if let Some(param_list) = func.param_list() {
             if let Some(self_param) = param_list.self_param() {
@@ -306,18 +305,6 @@ fn lower_function(&mut self, func: &ast::Fn) -> Option<FileItemTreeId<Function>>
                 has_self_param = true;
             }
             for param in param_list.params() {
-                let param_name = param
-                    .pat()
-                    .map(|name| {
-                        if let ast::Pat::IdentPat(ident) = name {
-                            Some(ident.name()?.as_name())
-                        } else {
-                            None
-                        }
-                    })
-                    .flatten();
-                param_names.push(param_name);
-
                 let type_ref = TypeRef::from_ast_opt(&self.body_ctx, param.ty());
                 params.push(type_ref);
             }
@@ -354,7 +341,6 @@ fn lower_function(&mut self, func: &ast::Fn) -> Option<FileItemTreeId<Function>>
             has_body,
             is_unsafe: func.unsafe_token().is_some(),
             params: params.into_boxed_slice(),
-            param_names: param_names.into_boxed_slice(),
             is_varargs,
             ret_type,
             ast_id,
-- 
2.44.0