From cb4439a3150308490a00773aa4f2a5ef23586a42 Mon Sep 17 00:00:00 2001 From: Cameron Steffen Date: Sun, 25 Jul 2021 18:28:08 -0500 Subject: [PATCH] Temporary fix rustfmt for let-else --- src/tools/rustfmt/src/items.rs | 9 +++++---- src/tools/rustfmt/tests/source/let_else.rs | 3 +++ src/tools/rustfmt/tests/target/let_else.rs | 3 +++ 3 files changed, 11 insertions(+), 4 deletions(-) create mode 100644 src/tools/rustfmt/tests/source/let_else.rs create mode 100644 src/tools/rustfmt/tests/target/let_else.rs diff --git a/src/tools/rustfmt/src/items.rs b/src/tools/rustfmt/src/items.rs index 0542358c6e7..2483d0570d9 100644 --- a/src/tools/rustfmt/src/items.rs +++ b/src/tools/rustfmt/src/items.rs @@ -48,7 +48,7 @@ fn rewrite(&self, context: &RewriteContext<'_>, shape: Shape) -> Option skip_out_of_file_lines_range!(context, self.span); - if contains_skip(&self.attrs) { + if contains_skip(&self.attrs) || matches!(self.kind, ast::LocalKind::InitElse(..)) { return None; } @@ -97,7 +97,7 @@ fn rewrite(&self, context: &RewriteContext<'_>, shape: Shape) -> Option infix.push_str(&rewrite); } - if self.init.is_some() { + if self.kind.init().is_some() { infix.push_str(" ="); } @@ -106,11 +106,12 @@ fn rewrite(&self, context: &RewriteContext<'_>, shape: Shape) -> Option result.push_str(&infix); - if let Some(ref ex) = self.init { + if let Some((init, _els)) = self.kind.init_else_opt() { // 1 = trailing semicolon; let nested_shape = shape.sub_width(1)?; - result = rewrite_assign_rhs(context, result, &**ex, nested_shape)?; + result = rewrite_assign_rhs(context, result, init, nested_shape)?; + // todo else } result.push(';'); diff --git a/src/tools/rustfmt/tests/source/let_else.rs b/src/tools/rustfmt/tests/source/let_else.rs new file mode 100644 index 00000000000..a6e816fb524 --- /dev/null +++ b/src/tools/rustfmt/tests/source/let_else.rs @@ -0,0 +1,3 @@ +fn main() { + let Some(1) = Some(1) else { return }; +} diff --git a/src/tools/rustfmt/tests/target/let_else.rs b/src/tools/rustfmt/tests/target/let_else.rs new file mode 100644 index 00000000000..a6e816fb524 --- /dev/null +++ b/src/tools/rustfmt/tests/target/let_else.rs @@ -0,0 +1,3 @@ +fn main() { + let Some(1) = Some(1) else { return }; +} -- 2.44.0