From 799ec79f18e627f8d14d3520f2e1abff265c1abe Mon Sep 17 00:00:00 2001 From: mahdi-frms Date: Mon, 5 Jul 2021 19:46:09 +0430 Subject: [PATCH] make the logs line buffered --- crates/rust-analyzer/src/bin/logger.rs | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/crates/rust-analyzer/src/bin/logger.rs b/crates/rust-analyzer/src/bin/logger.rs index 14887c5ccfe..35b3a9d696c 100644 --- a/crates/rust-analyzer/src/bin/logger.rs +++ b/crates/rust-analyzer/src/bin/logger.rs @@ -48,7 +48,7 @@ fn log(&self, record: &Record) { return; } - let should_flush = match &self.file { + match &self.file { Some(w) => { let _ = writeln!( w.lock(), @@ -57,22 +57,21 @@ fn log(&self, record: &Record) { record.module_path().unwrap_or_default(), record.args(), ); - self.no_buffering + + if self.no_buffering { + self.flush(); + } } None => { - eprintln!( - "[{} {}] {}", + let message = format!( + "[{} {}] {}\n", record.level(), record.module_path().unwrap_or_default(), record.args(), ); - true // flush stderr unconditionally + eprint!("{}", message); } }; - - if should_flush { - self.flush(); - } } fn flush(&self) { -- 2.44.0