From 7548d952af07e7df18bb894b3f470d321f4d6c04 Mon Sep 17 00:00:00 2001 From: Jhonny Bill Mena Date: Sat, 10 Sep 2022 13:24:46 -0400 Subject: [PATCH] UPDATE - resolve fixme and emit errors via Handler --- compiler/rustc_codegen_ssa/src/back/write.rs | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/compiler/rustc_codegen_ssa/src/back/write.rs b/compiler/rustc_codegen_ssa/src/back/write.rs index 125b231b274..1f577e9f352 100644 --- a/compiler/rustc_codegen_ssa/src/back/write.rs +++ b/compiler/rustc_codegen_ssa/src/back/write.rs @@ -872,19 +872,12 @@ fn execute_copy_from_cache_work_item( ); match link_or_copy(&source_file, &output_path) { Ok(_) => Some(output_path), - Err(_) => { - // FIXME: - // Should we add Translations support in Handler, or should we pass a session here ? - // - // As Luis Cardoso mentioned here https://github.com/rust-lang/rust/pull/100753#discussion_r952975345, - // Translations support in Handler is tricky because SessionDiagnostic is not a trait, - // and we can't implement it in Handler because rustc_errors cannot depend on rustc_session. - // - // As for passing a session here, my understanding is that all these errors should be reported via - // the Shared Handler, which leads us to probably having to support Translations in another way. - - // let diag_handler = cgcx.create_diag_handler(); - // diag_handler.emit_err(errors::CopyPathBuf { source_file, output_path, error }); + Err(error) => { + cgcx.create_diag_handler().emit_err(errors::CopyPathBuf { + source_file, + output_path, + error, + }); None } } -- 2.44.0