From 6ad77b09388224c38b65f5c54125b669b886c7f3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Esteban=20K=C3=BCber?= Date: Mon, 25 Mar 2019 21:38:23 -0700 Subject: [PATCH] review comments --- src/libsyntax/parse/parser.rs | 2 +- src/test/ui/parser/issue-59418.rs | 6 +++++- src/test/ui/parser/issue-59418.stderr | 10 ++++++++-- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index efeace4f05e..38647bec982 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -3208,7 +3208,7 @@ fn parse_dot_or_call_expr_with_(&mut self, e0: P, lo: Span) -> PResult<'a, if let Some(suffix) = suffix { let mut err = self.diagnostic().struct_span_err( span, - "tuple index with a suffix is invalid", + "suffixes on tuple indexes are invalid", ); err.span_label(span, format!("invalid suffix `{}`", suffix)); err.emit(); diff --git a/src/test/ui/parser/issue-59418.rs b/src/test/ui/parser/issue-59418.rs index 33ad11bb0b0..cab37e0d809 100644 --- a/src/test/ui/parser/issue-59418.rs +++ b/src/test/ui/parser/issue-59418.rs @@ -3,7 +3,11 @@ fn main() { let a = X(1, 2, 3); let b = a.1suffix; - //~^ ERROR tuple index with a suffix is invalid + //~^ ERROR suffixes on tuple indexes are invalid println!("{}", b); + let c = (1, 2, 3); + let d = c.1suffix; + //~^ ERROR suffixes on tuple indexes are invalid + println!("{}", d); } diff --git a/src/test/ui/parser/issue-59418.stderr b/src/test/ui/parser/issue-59418.stderr index c06b950f601..e50780de4f9 100644 --- a/src/test/ui/parser/issue-59418.stderr +++ b/src/test/ui/parser/issue-59418.stderr @@ -1,8 +1,14 @@ -error: tuple index with a suffix is invalid +error: suffixes on tuple indexes are invalid --> $DIR/issue-59418.rs:5:15 | LL | let b = a.1suffix; | ^^^^^^^ invalid suffix `suffix` -error: aborting due to previous error +error: suffixes on tuple indexes are invalid + --> $DIR/issue-59418.rs:9:15 + | +LL | let d = c.1suffix; + | ^^^^^^^ invalid suffix `suffix` + +error: aborting due to 2 previous errors -- 2.44.0