From 62b5f2adee1f9f5d96ecb6e0f7fa1dd9410c6321 Mon Sep 17 00:00:00 2001 From: Elias Fleckenstein Date: Tue, 29 Sep 2020 17:37:12 +0200 Subject: [PATCH] Fix critical security patch --- ranks.lua | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ranks.lua b/ranks.lua index c065b71..7798353 100755 --- a/ranks.lua +++ b/ranks.lua @@ -55,7 +55,8 @@ end elidragon.savedata.ranks = elidragon.savedata.ranks or elidragon.load_legacy_ranks() or {} function elidragon.get_rank(player) - local rank = elidragon.savedata.ranks[player:get_player_name()] or "player" + local rank = elidragon.savedata.ranks[player:get_player_name()] + if not rank or rank == "" then rank = "player" end return elidragon.get_rank_by_name(rank) end @@ -80,7 +81,9 @@ function elidragon.get_player_name(player, color, brackets) end function elidragon.update_nametag(player) - player:set_nametag_attributes({color = elidragon.get_rank(player).color}) + if player then + player:set_nametag_attributes({color = elidragon.get_rank(player).color}) + end end minetest.register_on_joinplayer(function(player) @@ -143,7 +146,7 @@ minetest.register_chatcommand("rank", { minetest.register_on_joinplayer(function(player) local name = player:get_player_name() local rank = player:get_meta():get_string("elidragon:rank") - if rank then + if rank and rank ~= "" then elidragon.savedata.ranks[name] = rank player:get_meta():set_string("elidragon:rank", "") end -- 2.44.0