From 5beddf93e75ab1d001fc2382830cea560b1473fd Mon Sep 17 00:00:00 2001 From: Jeroen Vannevel Date: Tue, 4 Jan 2022 02:12:53 +0000 Subject: [PATCH] additional test without further usages --- .../src/handlers/extract_function.rs | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/crates/ide_assists/src/handlers/extract_function.rs b/crates/ide_assists/src/handlers/extract_function.rs index 8c7fb03f7af..2821f6cde98 100644 --- a/crates/ide_assists/src/handlers/extract_function.rs +++ b/crates/ide_assists/src/handlers/extract_function.rs @@ -4337,7 +4337,7 @@ fn $0fun_name(a: _) -> _ { } #[test] - fn test_jeroen() { + fn reference_mutable_param_with_further_usages() { check_assist( extract_function, r#" @@ -4365,6 +4365,37 @@ pub fn testfn(arg: &mut Foo) { println!("{}", arg.field); // read access } +fn $0fun_name(arg: &mut Foo) { + arg.field = 8; + println!("{}", arg.field); +} +"#, + ); + } + + #[test] + fn reference_mutable_param_without_further_usages() { + check_assist( + extract_function, + r#" +pub struct Foo { + field: u32, +} + +pub fn testfn(arg: &mut Foo) { + $0arg.field = 8; // write access + println!("{}", arg.field); // read access$0 +} +"#, + r#" +pub struct Foo { + field: u32, +} + +pub fn testfn(arg: &mut Foo) { + fun_name(arg); // read access +} + fn $0fun_name(arg: &mut Foo) { arg.field = 8; println!("{}", arg.field); -- 2.44.0