From 41453d2f744e6ae6bf95867e29387f098c988265 Mon Sep 17 00:00:00 2001 From: Mazdak Farrokhzad Date: Tue, 7 Jan 2020 14:38:27 +0100 Subject: [PATCH] collector: clarify dependencies --- src/librustc/hir/map/collector.rs | 20 +++++++++++--------- src/librustc/hir/map/definitions.rs | 5 +++-- src/librustc/hir/map/mod.rs | 2 +- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/src/librustc/hir/map/collector.rs b/src/librustc/hir/map/collector.rs index edb2e69b79c..7dca5451a30 100644 --- a/src/librustc/hir/map/collector.rs +++ b/src/librustc/hir/map/collector.rs @@ -1,22 +1,24 @@ -use super::*; -use crate::dep_graph::{DepGraph, DepKind, DepNodeIndex}; -use crate::hir::intravisit::{NestedVisitorMap, Visitor}; -use crate::hir::map::HirEntryMap; -use crate::ich::Fingerprint; +use crate::dep_graph::{DepGraph, DepKind, DepNode, DepNodeIndex}; +use crate::hir::intravisit::{self, NestedVisitorMap, Visitor}; +use crate::hir::map::definitions::{self, DefPathHash}; +use crate::hir::map::{Entry, HirEntryMap}; +use crate::ich::StableHashingContext; use crate::middle::cstore::CrateStore; +use rustc_data_structures::fingerprint::Fingerprint; use rustc_data_structures::fx::FxHashMap; +use rustc_data_structures::stable_hasher::{HashStable, StableHasher}; use rustc_data_structures::svh::Svh; use rustc_hir as hir; +use rustc_hir::def_id::CRATE_DEF_INDEX; use rustc_hir::def_id::{CrateNum, DefIndex, LOCAL_CRATE}; +use rustc_hir::*; use rustc_index::vec::IndexVec; use rustc_session::{CrateDisambiguator, Session}; use rustc_span::source_map::SourceMap; -use rustc_span::{Span, Symbol}; -use std::iter::repeat; +use rustc_span::{Span, Symbol, DUMMY_SP}; use syntax::ast::NodeId; -use crate::ich::StableHashingContext; -use rustc_data_structures::stable_hasher::{HashStable, StableHasher}; +use std::iter::repeat; /// A visitor that walks over the HIR and collects `Node`s into a HIR map. pub(super) struct NodeCollector<'a, 'hir> { diff --git a/src/librustc/hir/map/definitions.rs b/src/librustc/hir/map/definitions.rs index 67d29b38db2..ac2d7a9a8dc 100644 --- a/src/librustc/hir/map/definitions.rs +++ b/src/librustc/hir/map/definitions.rs @@ -4,7 +4,7 @@ //! There are also some rather random cases (like const initializer //! expressions) that are mostly just leftovers. -use crate::ich::Fingerprint; +use rustc_data_structures::fingerprint::Fingerprint; use rustc_data_structures::fx::FxHashMap; use rustc_data_structures::stable_hasher::StableHasher; use rustc_hir as hir; @@ -15,10 +15,11 @@ use rustc_span::hygiene::ExpnId; use rustc_span::symbol::{sym, Symbol}; use rustc_span::Span; +use syntax::ast; + use std::borrow::Borrow; use std::fmt::Write; use std::hash::Hash; -use syntax::ast; /// The `DefPathTable` maps `DefIndex`es to `DefKey`s and vice versa. /// Internally the `DefPathTable` holds a tree of `DefKey`s, where each `DefKey` diff --git a/src/librustc/hir/map/mod.rs b/src/librustc/hir/map/mod.rs index 0a165accb7d..8fedcac9e23 100644 --- a/src/librustc/hir/map/mod.rs +++ b/src/librustc/hir/map/mod.rs @@ -18,7 +18,7 @@ use rustc_span::hygiene::MacroKind; use rustc_span::source_map::Spanned; use rustc_span::symbol::kw; -use rustc_span::{Span, DUMMY_SP}; +use rustc_span::Span; use rustc_target::spec::abi::Abi; use syntax::ast::{self, Name, NodeId}; -- 2.44.0