From 2e7806146c008742919124bf6ac9a37c3ece51bb Mon Sep 17 00:00:00 2001 From: Mazdak Farrokhzad Date: Tue, 31 Dec 2019 04:30:55 +0100 Subject: [PATCH] parser: bug -> span_bug --- src/librustc_parse/parser/diagnostics.rs | 4 ---- src/librustc_parse/parser/expr.rs | 2 +- src/librustc_parse/parser/mod.rs | 3 ++- src/librustc_parse/parser/ty.rs | 4 +++- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/librustc_parse/parser/diagnostics.rs b/src/librustc_parse/parser/diagnostics.rs index 778f24fad6d..05754357bc8 100644 --- a/src/librustc_parse/parser/diagnostics.rs +++ b/src/librustc_parse/parser/diagnostics.rs @@ -165,10 +165,6 @@ pub(super) fn span_fatal_err>( err.span_err(sp, self.diagnostic()) } - pub(super) fn bug(&self, m: &str) -> ! { - self.sess.span_diagnostic.span_bug(self.token.span, m) - } - pub fn struct_span_err>(&self, sp: S, m: &str) -> DiagnosticBuilder<'a> { self.sess.span_diagnostic.struct_span_err(sp, m) } diff --git a/src/librustc_parse/parser/expr.rs b/src/librustc_parse/parser/expr.rs index 9a4bef37768..ab7c156e370 100644 --- a/src/librustc_parse/parser/expr.rs +++ b/src/librustc_parse/parser/expr.rs @@ -283,7 +283,7 @@ pub(super) fn parse_assoc_expr_with( self.mk_expr(span, aopexpr, AttrVec::new()) } AssocOp::As | AssocOp::Colon | AssocOp::DotDot | AssocOp::DotDotEq => { - self.bug("AssocOp should have been handled by special case") + self.span_bug(span, "AssocOp should have been handled by special case") } }; diff --git a/src/librustc_parse/parser/mod.rs b/src/librustc_parse/parser/mod.rs index 322c8dda647..ec6468f4f0a 100644 --- a/src/librustc_parse/parser/mod.rs +++ b/src/librustc_parse/parser/mod.rs @@ -884,7 +884,8 @@ fn parse_paren_comma_seq( pub fn bump(&mut self) { if self.prev_token_kind == PrevTokenKind::Eof { // Bumping after EOF is a bad sign, usually an infinite loop. - self.bug("attempted to bump the parser past EOF (may be stuck in a loop)"); + let msg = "attempted to bump the parser past EOF (may be stuck in a loop)"; + self.span_bug(self.token.span, msg); } self.prev_span = self.meta_var_span.take().unwrap_or(self.token.span); diff --git a/src/librustc_parse/parser/ty.rs b/src/librustc_parse/parser/ty.rs index 049c077c3ce..4f7bcf01e1b 100644 --- a/src/librustc_parse/parser/ty.rs +++ b/src/librustc_parse/parser/ty.rs @@ -175,7 +175,9 @@ fn parse_ty_tuple_or_parens(&mut self, lo: Span, allow_plus: bool) -> PResult<'a { let path = match bounds.remove(0) { GenericBound::Trait(pt, ..) => pt.trait_ref.path, - GenericBound::Outlives(..) => self.bug("unexpected lifetime bound"), + GenericBound::Outlives(..) => { + self.span_bug(ty.span, "unexpected lifetime bound") + } }; self.parse_remaining_bounds(Vec::new(), path, lo, true) } -- 2.44.0