From 14730ed44536b5d50aa8b73fbb1023fffe6eba3d Mon Sep 17 00:00:00 2001
From: Dylan MacKenzie <ecstaticmorse@gmail.com>
Date: Sun, 5 Jan 2020 16:33:26 -0800
Subject: [PATCH] Make `bound_context` more like neighboring functions

---
 src/librustc_passes/ast_validation.rs | 39 +++++++++++++--------------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/src/librustc_passes/ast_validation.rs b/src/librustc_passes/ast_validation.rs
index cb035e586c1..724d717304c 100644
--- a/src/librustc_passes/ast_validation.rs
+++ b/src/librustc_passes/ast_validation.rs
@@ -24,6 +24,7 @@
 
 use rustc_error_codes::*;
 
+/// A syntactic context that disallows certain kinds of bounds (e.g., `?Trait` or `?const Trait`).
 #[derive(Clone, Copy)]
 enum BoundContext {
     ImplTrait,
@@ -50,10 +51,11 @@ struct AstValidator<'a> {
     /// e.g., `impl Iterator<Item = impl Debug>`.
     outer_impl_trait: Option<Span>,
 
-    /// Tracks the context in which a bound can appear.
+    /// Keeps track of the `BoundContext` as we recurse.
     ///
-    /// This is used to forbid `?const Trait` bounds in certain contexts.
-    bound_context_stack: Vec<Option<BoundContext>>,
+    /// This is used to forbid `?const Trait` bounds in, e.g.,
+    /// `impl Iterator<Item = Box<dyn ?const Trait>`.
+    bound_context: Option<BoundContext>,
 
     /// Used to ban `impl Trait` in path projections like `<impl Iterator>::Item`
     /// or `Foo::Bar<impl Trait>`
@@ -80,21 +82,19 @@ fn with_banned_assoc_ty_bound(&mut self, f: impl FnOnce(&mut Self)) {
     }
 
     fn with_impl_trait(&mut self, outer: Option<Span>, f: impl FnOnce(&mut Self)) {
-        self.bound_context_stack.push(outer.map(|_| BoundContext::ImplTrait));
         let old = mem::replace(&mut self.outer_impl_trait, outer);
-        f(self);
+        if outer.is_some() {
+            self.with_bound_context(BoundContext::ImplTrait, |this| f(this));
+        } else {
+            f(self)
+        }
         self.outer_impl_trait = old;
-        self.bound_context_stack.pop();
     }
 
-    fn with_bound_context(&mut self, ctx: Option<BoundContext>, f: impl FnOnce(&mut Self)) {
-        self.bound_context_stack.push(ctx);
+    fn with_bound_context(&mut self, ctx: BoundContext, f: impl FnOnce(&mut Self)) {
+        let old = self.bound_context.replace(ctx);
         f(self);
-        self.bound_context_stack.pop();
-    }
-
-    fn innermost_bound_context(&mut self) -> Option<BoundContext> {
-        self.bound_context_stack.iter().rev().find(|x| x.is_some()).copied().flatten()
+        self.bound_context = old;
     }
 
     fn visit_assoc_ty_constraint_from_generic_args(&mut self, constraint: &'a AssocTyConstraint) {
@@ -119,9 +119,7 @@ fn walk_ty(&mut self, t: &'a Ty) {
                 self.with_impl_trait(Some(t.span), |this| visit::walk_ty(this, t))
             }
             TyKind::TraitObject(..) => {
-                self.with_bound_context(Some(BoundContext::TraitObject), |this| {
-                    visit::walk_ty(this, t)
-                });
+                self.with_bound_context(BoundContext::TraitObject, |this| visit::walk_ty(this, t));
             }
             TyKind::Path(ref qself, ref path) => {
                 // We allow these:
@@ -231,8 +229,7 @@ fn check_trait_fn_not_const(&self, constness: Spanned<Constness>) {
         }
     }
 
-    // FIXME(ecstaticmorse): Instead, use the `bound_context_stack` to check this in
-    // `visit_param_bound`.
+    // FIXME(ecstaticmorse): Instead, use `bound_context` to check this in `visit_param_bound`.
     fn no_questions_in_bounds(&self, bounds: &GenericBounds, where_: &str, is_trait: bool) {
         for bound in bounds {
             if let GenericBound::Trait(ref poly, TraitBoundModifier::Maybe) = *bound {
@@ -744,7 +741,7 @@ fn visit_item(&mut self, item: &'a Item) {
                 self.visit_vis(&item.vis);
                 self.visit_ident(item.ident);
                 self.visit_generics(generics);
-                self.with_bound_context(Some(BoundContext::TraitBounds), |this| {
+                self.with_bound_context(BoundContext::TraitBounds, |this| {
                     walk_list!(this, visit_param_bound, bounds);
                 });
                 walk_list!(self, visit_trait_item, trait_items);
@@ -903,7 +900,7 @@ fn visit_param_bound(&mut self, bound: &'a GenericBound) {
                             .span_err(bound.span(), "`?const` and `?` are mutually exclusive");
                     }
 
-                    if let Some(ctx) = self.innermost_bound_context() {
+                    if let Some(ctx) = self.bound_context {
                         let msg = format!("`?const` is not permitted in {}", ctx.description());
                         self.err_handler().span_err(bound.span(), &msg);
                     }
@@ -1025,7 +1022,7 @@ pub fn check_crate(session: &Session, krate: &Crate, lints: &mut lint::LintBuffe
         session,
         has_proc_macro_decls: false,
         outer_impl_trait: None,
-        bound_context_stack: Vec::new(),
+        bound_context: None,
         is_impl_trait_banned: false,
         is_assoc_ty_bound_banned: false,
         lint_buffer: lints,
-- 
2.44.0