From 12aec073a8cd293bede167a7ef062044eb07299e Mon Sep 17 00:00:00 2001 From: Anton Blanchard Date: Wed, 13 Jan 2016 00:55:51 +0000 Subject: [PATCH] Simplify some uses of cfg in test cases While adding PowerPC64 support it was noticed that some testcases should just use target_pointer_width, and others should select between x86 and !x86. --- src/test/auxiliary/extern_calling_convention.rs | 3 +-- src/test/run-pass/bitwise.rs | 5 ++--- src/test/run-pass/intrinsic-alignment.rs | 4 +--- src/test/run-pass/issue-2895.rs | 5 ++--- src/test/run-pass/rec-align-u32.rs | 9 --------- src/test/run-pass/rec-align-u64.rs | 4 +--- src/test/run-pass/struct-return.rs | 5 ++--- 7 files changed, 9 insertions(+), 26 deletions(-) diff --git a/src/test/auxiliary/extern_calling_convention.rs b/src/test/auxiliary/extern_calling_convention.rs index c11c054317d..55a4226c663 100644 --- a/src/test/auxiliary/extern_calling_convention.rs +++ b/src/test/auxiliary/extern_calling_convention.rs @@ -24,8 +24,7 @@ pub extern "win64" fn foo(a: isize, b: isize, c: isize, d: isize) { } #[inline(never)] -#[cfg(any(target_arch = "x86", target_arch = "arm", target_arch = "aarch64", - target_arch = "powerpc64", target_arch = "powerpc64le"))] +#[cfg(not(target_arch = "x86_64"))] pub extern fn foo(a: isize, b: isize, c: isize, d: isize) { assert_eq!(a, 1); assert_eq!(b, 2); diff --git a/src/test/run-pass/bitwise.rs b/src/test/run-pass/bitwise.rs index 6cb99edf370..bb4b9cfecf7 100644 --- a/src/test/run-pass/bitwise.rs +++ b/src/test/run-pass/bitwise.rs @@ -8,13 +8,12 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -#[cfg(any(target_arch = "x86", target_arch = "arm"))] +#[cfg(any(target_pointer_width = "32"))] fn target() { assert_eq!(-1000isize as usize >> 3_usize, 536870787_usize); } -#[cfg(any(target_arch = "x86_64", target_arch = "aarch64", - target_arch = "powerpc64", target_arch = "powerpc64le"))] +#[cfg(any(target_pointer_width = "64"))] fn target() { assert_eq!(-1000isize as usize >> 3_usize, 2305843009213693827_usize); } diff --git a/src/test/run-pass/intrinsic-alignment.rs b/src/test/run-pass/intrinsic-alignment.rs index 2f105ec84f1..a4720d48213 100644 --- a/src/test/run-pass/intrinsic-alignment.rs +++ b/src/test/run-pass/intrinsic-alignment.rs @@ -35,9 +35,7 @@ pub fn main() { } #[main] - #[cfg(any(target_arch = "x86_64", target_arch = "arm", - target_arch = "aarch64", target_arch = "powerpc64", - target_arch = "powerpc64le"))] + #[cfg(not(target_arch = "x86"))] pub fn main() { unsafe { assert_eq!(::rusti::pref_align_of::(), 8); diff --git a/src/test/run-pass/issue-2895.rs b/src/test/run-pass/issue-2895.rs index ae62109fe23..5587f68bd18 100644 --- a/src/test/run-pass/issue-2895.rs +++ b/src/test/run-pass/issue-2895.rs @@ -23,14 +23,13 @@ impl Drop for Kitty { fn drop(&mut self) {} } -#[cfg(any(target_arch = "x86_64", target_arch="aarch64", - target_arch="powerpc64", target_arch="powerpc64le"))] +#[cfg(target_pointer_width = "64")] pub fn main() { assert_eq!(mem::size_of::(), 8 as usize); assert_eq!(mem::size_of::(), 16 as usize); } -#[cfg(any(target_arch = "x86", target_arch = "arm"))] +#[cfg(target_pointer_width = "32")] pub fn main() { assert_eq!(mem::size_of::(), 4 as usize); assert_eq!(mem::size_of::(), 8 as usize); diff --git a/src/test/run-pass/rec-align-u32.rs b/src/test/run-pass/rec-align-u32.rs index 7e3a05bbf84..4a115c737da 100644 --- a/src/test/run-pass/rec-align-u32.rs +++ b/src/test/run-pass/rec-align-u32.rs @@ -35,15 +35,6 @@ struct Outer { t: Inner } - -#[cfg(any(target_arch = "x86", target_arch = "arm", target_arch = "aarch64", - target_arch = "powerpc64", target_arch = "powerpc64le"))] -mod m { - pub fn align() -> usize { 4 } - pub fn size() -> usize { 8 } -} - -#[cfg(target_arch = "x86_64")] mod m { pub fn align() -> usize { 4 } pub fn size() -> usize { 8 } diff --git a/src/test/run-pass/rec-align-u64.rs b/src/test/run-pass/rec-align-u64.rs index e12d04adabf..25cd77845ea 100644 --- a/src/test/run-pass/rec-align-u64.rs +++ b/src/test/run-pass/rec-align-u64.rs @@ -49,9 +49,7 @@ pub fn align() -> usize { 4 } pub fn size() -> usize { 12 } } - #[cfg(any(target_arch = "x86_64", target_arch = "arm", - target_arch = "aarch64", target_arch = "powerpc64", - target_arch = "powerpc64le"))] + #[cfg(not(target_arch = "x86"))] pub mod m { pub fn align() -> usize { 8 } pub fn size() -> usize { 16 } diff --git a/src/test/run-pass/struct-return.rs b/src/test/run-pass/struct-return.rs index 55474a69cb7..6f23263790c 100644 --- a/src/test/run-pass/struct-return.rs +++ b/src/test/run-pass/struct-return.rs @@ -43,8 +43,7 @@ fn test1() { } } -#[cfg(any(target_arch = "x86_64", target_arch = "aarch64", - target_arch = "powerpc64", target_arch = "powerpc64le"))] +#[cfg(target_pointer_width = "64")] fn test2() { unsafe { let f = Floats { a: 1.234567890e-15_f64, @@ -60,7 +59,7 @@ fn test2() { } } -#[cfg(any(target_arch = "x86", target_arch = "arm"))] +#[cfg(target_pointer_width = "32")] fn test2() { } -- 2.44.0