]> git.lizzy.rs Git - rust.git/log
rust.git
2 years agoMove def_id logic into render_call_locations
Will Crichton [Fri, 22 Oct 2021 20:14:46 +0000 (13:14 -0700)]
Move def_id logic into render_call_locations

2 years agoRevert def_id addition from clean::Function, add test for
Will Crichton [Fri, 22 Oct 2021 19:46:45 +0000 (12:46 -0700)]
Revert def_id addition from clean::Function, add test for
scrape-examples options

2 years agoSmall scrape-example fixes
Will Crichton [Wed, 20 Oct 2021 03:08:30 +0000 (20:08 -0700)]
Small scrape-example fixes

2 years agoFix local crate not being scraped
Will Crichton [Wed, 13 Oct 2021 01:26:39 +0000 (18:26 -0700)]
Fix local crate not being scraped

2 years agoAdd test for ordering of examples, simplify with single scrape.mk file
Will Crichton [Sat, 9 Oct 2021 03:49:05 +0000 (20:49 -0700)]
Add test for ordering of examples, simplify with single scrape.mk file

2 years agoAdd test for prev/back arrows + examples across multiple files
Will Crichton [Sat, 9 Oct 2021 00:56:42 +0000 (17:56 -0700)]
Add test for prev/back arrows + examples across multiple files

2 years agoChange handling of spans in scrape examples, add test for highlight decorations
Will Crichton [Fri, 8 Oct 2021 22:32:22 +0000 (15:32 -0700)]
Change handling of spans in scrape examples, add test for highlight decorations

2 years agoMove more scrape-examples logic from JS to rust
Will Crichton [Thu, 7 Oct 2021 17:27:09 +0000 (10:27 -0700)]
Move more scrape-examples logic from JS to rust

Fix failing test

Add missing backslash

Fix padding issue with horizontal scrollbar

2 years agoMove some expansion logic into generation-time, fix section header links, remove...
Will Crichton [Thu, 7 Oct 2021 16:46:18 +0000 (09:46 -0700)]
Move some expansion logic into generation-time, fix section header links, remove ID from line numbers, fix horizontal scrolling on non-expanded elements

2 years agoUpdate to latest rustc and rustdoc styles
Will Crichton [Thu, 7 Oct 2021 04:43:40 +0000 (21:43 -0700)]
Update to latest rustc and rustdoc styles

2 years agoUnversioned -> InvocationSpecific
Will Crichton [Fri, 1 Oct 2021 21:12:26 +0000 (14:12 -0700)]
Unversioned -> InvocationSpecific

2 years agoFix lint error, change scrape-examples.js minify call
Will Crichton [Fri, 1 Oct 2021 20:57:57 +0000 (13:57 -0700)]
Fix lint error, change scrape-examples.js minify call

2 years agoMove JS into a standalone file
Will Crichton [Fri, 1 Oct 2021 20:05:35 +0000 (13:05 -0700)]
Move JS into a standalone file

2 years agoChange serialized format to use DefPathHash instead of custom String
Will Crichton [Tue, 21 Sep 2021 22:49:36 +0000 (15:49 -0700)]
Change serialized format to use DefPathHash instead of custom String

Move test to rustdoc-ui

Fix test writing to wrong directory

Formatting

Fix test

Add FIXME

Remove raw multiline strings

2 years agoAdd target crates as inputs to reduce size of intermediates
Will Crichton [Mon, 20 Sep 2021 21:08:33 +0000 (14:08 -0700)]
Add target crates as inputs to reduce size of intermediates

Add tests for module-path remapping and scrape example options

Find all crates with a given name

2 years agoIncorporate jyn's feedback
Will Crichton [Fri, 17 Sep 2021 01:12:45 +0000 (18:12 -0700)]
Incorporate jyn's feedback
* Move call location logic from function constructor to rendering
* Fix issue with macro spans in scraping examples
* Clean up example loading logic

Documentation / newtype for DecorationInfo

Fix line number display

Serialize edition of call site, other small cleanup

2 years agoAdd styles for non-white themes
Will Crichton [Tue, 14 Sep 2021 16:50:47 +0000 (09:50 -0700)]
Add styles for non-white themes

Tweak colors

Tabs

New link heading style

2 years agoReduce blur size, fix example width bug, add better error handling for I/O issues
Will Crichton [Tue, 14 Sep 2021 01:08:14 +0000 (18:08 -0700)]
Reduce blur size, fix example width bug, add better error handling for I/O issues

Remove repository url

Fix formatting

Fix file_span in print_src

Formatting

2 years agoMove highlighting logic from JS to Rust
Will Crichton [Thu, 26 Aug 2021 21:43:12 +0000 (14:43 -0700)]
Move highlighting logic from JS to Rust

Continue migrating JS functionality

Cleanup

Fix compile error

Clean up the diff

Set toggle font to sans-serif

2 years agoSort examples by size
Will Crichton [Thu, 26 Aug 2021 03:15:46 +0000 (20:15 -0700)]
Sort examples by size

Improve styling

Start to clean up code, add comments

2 years agoGenerate example source files with corresponding links
Will Crichton [Thu, 3 Jun 2021 00:21:48 +0000 (17:21 -0700)]
Generate example source files with corresponding links

Add display name

Fix remaining merge conflicts

Only embed code for items containing examples

2 years agoFactor scraping and rendering into separate calls to rustdoc
Will Crichton [Tue, 1 Jun 2021 21:02:09 +0000 (14:02 -0700)]
Factor scraping and rendering into separate calls to rustdoc

Simplify toggle UI logic, add workspace root for URLs

2 years agoFix check issue
Will Crichton [Sun, 30 May 2021 17:00:44 +0000 (10:00 -0700)]
Fix check issue

Clean up tidy checks

2 years agoAdd updated support for example-analyzer
Will Crichton [Sun, 9 May 2021 23:22:22 +0000 (16:22 -0700)]
Add updated support for example-analyzer

Move rendering of examples into

Finalize design

Cleanup, rename found -> scraped

Softer yellow

Clean up dead code

Document scrape_examples

More simplification and documentation

Remove extra css

Test

2 years agoAuto merge of #89608 - Manishearth:rollup-m7kd76f, r=Manishearth
bors [Wed, 6 Oct 2021 20:17:28 +0000 (20:17 +0000)]
Auto merge of #89608 - Manishearth:rollup-m7kd76f, r=Manishearth

Rollup of 12 pull requests

Successful merges:

 - #87601 (Add functions to add unsigned and signed integers)
 - #88523 (Expand documentation for `FpCategory`.)
 - #89050 (refactor: VecDeques Drain fields to private)
 - #89245 (refactor: make VecDeque's IterMut fields module-private, not just crate-private)
 - #89324 (Rename `std::thread::available_conccurrency` to `std::thread::available_parallelism`)
 - #89329 (print-type-sizes: skip field printing for primitives)
 - #89501 (Note specific regions involved in 'borrowed data escapes' error)
 - #89506 (librustdoc: Use correct heading levels.)
 - #89528 (Fix suggestion to borrow when casting from pointer to reference)
 - #89531 (library std, libc dependency update)
 - #89588 (Add a test for generic_const_exprs)
 - #89591 (fix: alloc-optimisation is only for rust llvm)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #89591 - infinity0:master, r=Amanieu
Manish Goregaokar [Wed, 6 Oct 2021 19:33:24 +0000 (12:33 -0700)]
Rollup merge of #89591 - infinity0:master, r=Amanieu

fix: alloc-optimisation is only for rust llvm

As discussed at the bottom of #83485.

On a separate note I'll take this chance ask, is it worth pulling in that patch (to recognise `__rust_dealloc`) into Debian's system LLVM? The main factors for us to consider would be (1) is the optimisation significant and (2) is there not any significant negative impact to non-rust packages that use LLVM.

2 years agoRollup merge of #89588 - BoxyUwU:add_a_test_uwu, r=lcnr
Manish Goregaokar [Wed, 6 Oct 2021 19:33:23 +0000 (12:33 -0700)]
Rollup merge of #89588 - BoxyUwU:add_a_test_uwu, r=lcnr

Add a test for generic_const_exprs

Test that const_eval_resolve evaluates consts with unused inference vars in substs

r? ``@lcnr``

2 years agoRollup merge of #89531 - devnexen:stack_overflow_bsd_libc_upd, r=dtolnay
Manish Goregaokar [Wed, 6 Oct 2021 19:33:22 +0000 (12:33 -0700)]
Rollup merge of #89531 - devnexen:stack_overflow_bsd_libc_upd, r=dtolnay

library std, libc dependency update

to solve #87528 build.

2 years agoRollup merge of #89528 - FabianWolff:issue-89497, r=jackh726
Manish Goregaokar [Wed, 6 Oct 2021 19:33:21 +0000 (12:33 -0700)]
Rollup merge of #89528 - FabianWolff:issue-89497, r=jackh726

Fix suggestion to borrow when casting from pointer to reference

Fixes #89497.

2 years agoRollup merge of #89506 - yaymukund:docblock-headings, r=GuillaumeGomez
Manish Goregaokar [Wed, 6 Oct 2021 19:33:20 +0000 (12:33 -0700)]
Rollup merge of #89506 - yaymukund:docblock-headings, r=GuillaumeGomez

librustdoc: Use correct heading levels.

Closes #89309

This fixes the `<h#>` header tags throughout the docs to reflect a semantic hierarchy.

- I ran a script to manually check that we don't have any files with multiple `<h1>` tags.
- Also checked that we never incorrectly nest e.g. a `<h2>` under an `<h3>`.
- I also spot-checked a bunch of pages (`trait.Read`, `enum.Ordering`, `primitive.isize`, `trait.Iterator`).

2 years agoRollup merge of #89501 - Aaron1011:escaping-name-regions, r=davidtwco
Manish Goregaokar [Wed, 6 Oct 2021 19:33:19 +0000 (12:33 -0700)]
Rollup merge of #89501 - Aaron1011:escaping-name-regions, r=davidtwco

Note specific regions involved in 'borrowed data escapes' error

Fixes #67007

Currently, a 'borrowed data escapes' error does not mention
the specific lifetime involved (except indirectly through a suggestion
about adding a lifetime bound). We now explain the specific lifetime
relationship that failed to hold, which improves otherwise vague
error messages.

2 years agoRollup merge of #89329 - tmiasko:print-type-sizes-no-fields, r=jackh726
Manish Goregaokar [Wed, 6 Oct 2021 19:33:18 +0000 (12:33 -0700)]
Rollup merge of #89329 - tmiasko:print-type-sizes-no-fields, r=jackh726

print-type-sizes: skip field printing for primitives

Fixes #86528.

2 years agoRollup merge of #89324 - yoshuawuyts:hardware-parallelism, r=m-ou-se
Manish Goregaokar [Wed, 6 Oct 2021 19:33:17 +0000 (12:33 -0700)]
Rollup merge of #89324 - yoshuawuyts:hardware-parallelism, r=m-ou-se

Rename `std::thread::available_conccurrency` to `std::thread::available_parallelism`

_Tracking issue: https://github.com/rust-lang/rust/issues/74479_

This PR renames  `std::thread::available_conccurrency` to `std::thread::available_parallelism`.

## Rationale

The API was initially named `std::thread::hardware_concurrency`, mirroring the [C++ API of the same name](https://en.cppreference.com/w/cpp/thread/thread/hardware_concurrency). We eventually decided to omit any reference to the word "hardware" after [this comment](https://github.com/rust-lang/rust/pull/74480#issuecomment-662045841). And so we ended up with `available_concurrency` instead.

---

For a talk I was preparing this week I was reading through ["Understanding and expressing scalable concurrency" (A. Turon, 2013)](http://aturon.github.io/academic/turon-thesis.pdf), and the following passage stood out to me (emphasis mine):

> __Concurrency is a system-structuring mechanism.__ An interactive system that deals with disparate asynchronous events is naturally structured by division into concurrent threads with disparate responsibilities. Doing so creates a better fit between problem and solution, and can also decrease the average latency of the system by preventing long-running computations from obstructing quicker ones.

> __Parallelism is a resource.__ A given machine provides a certain capacity for parallelism, i.e., a bound on the number of computations it can perform simultaneously. The goal is to maximize throughput by intelligently using this resource. For interactive systems, parallelism can decrease latency as well.

_Chapter 2.1: Concurrency is not Parallelism. Page 30._

---

_"Concurrency is a system-structuring mechanism. Parallelism is a resource."_ — It feels like this accurately captures the way we should be thinking about these APIs. What this API returns is not "the amount of concurrency available to the program" which is a property of the program, and thus even with just a single thread is effectively unbounded. But instead it returns "the amount of _parallelism_ available to the program", which is a resource hard-constrained by the machine's capacity (and can be further restricted by e.g. operating systems).

That's why I'd like to propose we rename this API from `available_concurrency` to `available_parallelism`. This still meets the criteria we previously established of not attempting to define what exactly we mean by "hardware", "threads", and other such words. Instead we only talk about "concurrency" as an abstract resource available to our program.

r? `@joshtriplett`

2 years agoRollup merge of #89245 - DeveloperC286:iter_mut_fields_to_private, r=joshtriplett
Manish Goregaokar [Wed, 6 Oct 2021 19:33:16 +0000 (12:33 -0700)]
Rollup merge of #89245 - DeveloperC286:iter_mut_fields_to_private, r=joshtriplett

refactor: make VecDeque's IterMut fields module-private, not just crate-private

Made the fields of VecDeque's IterMut private by creating a IterMut::new(...) function to create a new instance of IterMut and migrating usage to use IterMut::new(...).

2 years agoRollup merge of #89050 - DeveloperC286:drain_fields_to_private, r=joshtriplett
Manish Goregaokar [Wed, 6 Oct 2021 19:33:15 +0000 (12:33 -0700)]
Rollup merge of #89050 - DeveloperC286:drain_fields_to_private, r=joshtriplett

refactor: VecDeques Drain fields to private

Made the fields of VecDeque's Drain private by creating a Drain::new(...) function to create a new instance of Drain and migrating usage to use Drain::new(...).

2 years agoRollup merge of #88523 - kpreid:category, r=yaahc
Manish Goregaokar [Wed, 6 Oct 2021 19:33:14 +0000 (12:33 -0700)]
Rollup merge of #88523 - kpreid:category, r=yaahc

Expand documentation for `FpCategory`.

I intend these changes to be helpful to readers who are not yet familiar with the quirks of floating-point numbers. Additionally, I felt it was misleading to describe `Nan` as being the result of division by zero, since most divisions by zero (except for 0/0) produce `Infinite` floats, so I moved that remark to the `Infinite` variant with adjustment.

The first sentence of the `Nan` documentation is copied from `f32`; I followed the example of the `f64` documentation by referring to `f32` for general concepts, rather than duplicating the text.

----

I considered making similar changes to the documentation of the `is_*` methods of floats, but decided that that was a much larger and trickier problem; here, each of the variants' descriptions can be expected to be read in context of being mutually exclusive with the others.

2 years agoRollup merge of #87601 - a1phyr:feature_uint_add_signed, r=kennytm
Manish Goregaokar [Wed, 6 Oct 2021 19:33:13 +0000 (12:33 -0700)]
Rollup merge of #87601 - a1phyr:feature_uint_add_signed, r=kennytm

Add functions to add unsigned and signed integers

This PR adds methods to unsigned integers to add signed integers with good overflow semantics under `#![feature(mixed_integer_ops)]`.

The added API is:

```rust
// `uX` is `u8`, `u16`, `u32`, `u64`,`u128`, `usize`
impl uX {
    pub const fn checked_add_signed(self, iX) -> Option<Self>;
    pub const fn overflowing_add_signed(self, iX) -> (Self, bool);
    pub const fn saturating_add_signed(self, iX) -> Self;
    pub const fn wrapping_add_signed(self, iX) -> Self;
}

impl iX {
    pub const fn checked_add_unsigned(self, uX) -> Option<Self>;
    pub const fn overflowing_add_unsigned(self, uX) -> (Self, bool);
    pub const fn saturating_add_unsigned(self, uX) -> Self;
    pub const fn wrapping_add_unsigned(self, uX) -> Self;

    pub const fn checked_sub_unsigned(self, uX) -> Option<Self>;
    pub const fn overflowing_sub_unsigned(self, uX) -> (Self, bool);
    pub const fn saturating_sub_unsigned(self, uX) -> Self;
    pub const fn wrapping_sub_unsigned(self, uX) -> Self;
}
```

Maybe it would be interesting to also have `add_signed` that panics in debug and wraps in release ?

2 years agoAuto merge of #89599 - rusticstuff:ci-fix, r=Mark-Simulacrum
bors [Wed, 6 Oct 2021 17:06:29 +0000 (17:06 +0000)]
Auto merge of #89599 - rusticstuff:ci-fix, r=Mark-Simulacrum

Switch to our own mirror of libisl plus `ct-ng oldconfig` fixes

Switching to mirror the ISL libs (#89594) unearthed a (possibly long-standing?) issue with `ct-ng oldconfig`. It always overwrites the mirror config values. This PR adds the ISL mirror, gets rid of `ct-ng oldconfig` and adds crosstools-ng config files which can be used directly. (Edited)

Fixes #89593.

r? `@pietroalbini`

2 years agoGet rid of broken `ct-ng oldconfig` everywhere and directly provide a suitable .confi...
Hans Kratz [Wed, 6 Oct 2021 14:57:25 +0000 (16:57 +0200)]
Get rid of broken `ct-ng oldconfig` everywhere and directly provide a suitable .config file.

2 years agoSwitch to our own mirror of libisl
Mark Rousskov [Wed, 6 Oct 2021 12:40:45 +0000 (08:40 -0400)]
Switch to our own mirror of libisl

2 years agoRevert the rustc_error_codes changes.
Mukund Lakshman [Wed, 6 Oct 2021 11:58:41 +0000 (07:58 -0400)]
Revert the rustc_error_codes changes.

2 years agoRestore h1 styles, which got accidentally removed.
Mukund Lakshman [Wed, 6 Oct 2021 11:27:13 +0000 (07:27 -0400)]
Restore h1 styles, which got accidentally removed.

2 years agofix: alloc-optimisation is only for rust llvm
Ximin Luo [Wed, 6 Oct 2021 09:22:03 +0000 (10:22 +0100)]
fix: alloc-optimisation is only for rust llvm

2 years agoAuto merge of #89323 - estebank:derive-binop, r=petrochenkov
bors [Wed, 6 Oct 2021 06:20:25 +0000 (06:20 +0000)]
Auto merge of #89323 - estebank:derive-binop, r=petrochenkov

Consider unfulfilled obligations in binop errors

When encountering a binop where the types would have been accepted, if
all the predicates had been fulfilled, include information about the
predicates and suggest appropriate `#[derive]`s if possible.

Fix #84515.

2 years agotest
Ellen [Wed, 6 Oct 2021 03:37:07 +0000 (04:37 +0100)]
test

2 years agoConsider unfulfilled obligations in binop errors
Esteban Kuber [Tue, 28 Sep 2021 14:48:54 +0000 (14:48 +0000)]
Consider unfulfilled obligations in binop errors

When encountering a binop where the types would have been accepted, if
all the predicates had been fulfilled, include information about the
predicates and suggest appropriate `#[derive]`s if possible.

Point at trait(s) that needs to be `impl`emented.

2 years agoAuto merge of #89572 - Manishearth:rollup-obz5ycp, r=Manishearth
bors [Tue, 5 Oct 2021 22:28:40 +0000 (22:28 +0000)]
Auto merge of #89572 - Manishearth:rollup-obz5ycp, r=Manishearth

Rollup of 10 pull requests

Successful merges:

 - #88706 (Normalize associated type projections when checking return type of main)
 - #88828 (Use `libc::sigaction()` instead of `sys::signal()` to prevent a deadlock)
 - #88871 (Fix suggestion for nested struct patterns)
 - #89317 (Move generic error message to separate branches)
 - #89351 (for signed wrapping remainder, do not compare lhs with MIN)
 - #89442 (Add check for duplicated doc aliases)
 - #89502 (Fix Lower/UpperExp formatting for integers and precision zero)
 - #89523 (Make `proc_macro_derive_resolution_fallback` a future-breakage lint)
 - #89532 (Document behavior of  `MaybeLiveLocals` regarding enums and field-senstivity)
 - #89546 (Make an initial guess for metadata size to reduce buffer resizes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #89546 - joshtriplett:grow-metadata-faster, r=petrochenkov
Manish Goregaokar [Tue, 5 Oct 2021 19:52:49 +0000 (12:52 -0700)]
Rollup merge of #89546 - joshtriplett:grow-metadata-faster, r=petrochenkov

Make an initial guess for metadata size to reduce buffer resizes

When reading metadata, the compiler starts with a `Vec::new()`, which will need to grow repeatedly as the metadata gets decompressed into it. Reduce the number of resizes by starting out at the size of the compressed data.

2 years agoRollup merge of #89532 - ecstatic-morse:maybe-live-locals-enum, r=oli-obk,tmiasko
Manish Goregaokar [Tue, 5 Oct 2021 19:52:48 +0000 (12:52 -0700)]
Rollup merge of #89532 - ecstatic-morse:maybe-live-locals-enum, r=oli-obk,tmiasko

Document behavior of  `MaybeLiveLocals` regarding enums and field-senstivity

This arose from a [discussion on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/189540-t-compiler.2Fwg-mir-opt/topic/MaybeLiveLocals.20and.20Discriminants) where a new contributor attempted to implement a dead-store elimination pass using this analysis. They ran into a nasty hack around `SetDiscriminant` the effect of which is to lets handle assignments of literals to enum-typed locals (e.g. `x = Some(4)`) correctly. This took me a while to figure out.

Document this oddity, so the next person will have an easier time, and add a test to enshrine the current behavior.

r? ``@tmiasko``

2 years agoRollup merge of #89523 - Aaron1011:derive-future-compat, r=wesleywiser
Manish Goregaokar [Tue, 5 Oct 2021 19:52:47 +0000 (12:52 -0700)]
Rollup merge of #89523 - Aaron1011:derive-future-compat, r=wesleywiser

Make `proc_macro_derive_resolution_fallback` a future-breakage lint

When `cargo report future-incompatibilities` is stabilized
(see #71249), this will cause dependencies that trigger
this lint to be included in the report.

2 years agoRollup merge of #89502 - FabianWolff:issue-89493, r=joshtriplett
Manish Goregaokar [Tue, 5 Oct 2021 19:52:46 +0000 (12:52 -0700)]
Rollup merge of #89502 - FabianWolff:issue-89493, r=joshtriplett

Fix Lower/UpperExp formatting for integers and precision zero

Fixes the integer part of #89493 (I daren't touch the floating-point formatting code). The issue is that the "subtracted" precision essentially behaves like extra trailing zeros, but this is not currently reflected in the code properly.

2 years agoRollup merge of #89442 - GuillaumeGomez:duplicated-doc-alias, r=estebank
Manish Goregaokar [Tue, 5 Oct 2021 19:52:45 +0000 (12:52 -0700)]
Rollup merge of #89442 - GuillaumeGomez:duplicated-doc-alias, r=estebank

Add check for duplicated doc aliases

r? ``@estebank``

2 years agoRollup merge of #89351 - tspiteri:wrapping_rem, r=dtolnay
Manish Goregaokar [Tue, 5 Oct 2021 19:52:45 +0000 (12:52 -0700)]
Rollup merge of #89351 - tspiteri:wrapping_rem, r=dtolnay

for signed wrapping remainder, do not compare lhs with MIN

Since the wrapped remainder is going to be 0 for all cases when the rhs is -1, there is no need to compare the lhs with MIN.

2 years agoRollup merge of #89317 - JulianKnodt:precise_errors, r=BoxyUwU
Manish Goregaokar [Tue, 5 Oct 2021 19:52:44 +0000 (12:52 -0700)]
Rollup merge of #89317 - JulianKnodt:precise_errors, r=BoxyUwU

Move generic error message to separate branches

This decomposes an error message in generic constants into more specific branches, for better
readability.

r? ``@lcnr``

2 years agoRollup merge of #88871 - FabianWolff:issue-88403, r=jackh726
Manish Goregaokar [Tue, 5 Oct 2021 19:52:43 +0000 (12:52 -0700)]
Rollup merge of #88871 - FabianWolff:issue-88403, r=jackh726

Fix suggestion for nested struct patterns

Fixes #88403, and also a similar problem where the unused binding is in a function parameter pattern.

2 years agoRollup merge of #88828 - FabianWolff:issue-88585, r=dtolnay
Manish Goregaokar [Tue, 5 Oct 2021 19:52:42 +0000 (12:52 -0700)]
Rollup merge of #88828 - FabianWolff:issue-88585, r=dtolnay

Use `libc::sigaction()` instead of `sys::signal()` to prevent a deadlock

Fixes #88585. POSIX [specifies](https://man7.org/linux/man-pages/man3/fork.3p.html) that after forking,
> to avoid errors, the child process may only execute async-signal-safe operations until such time as one of the exec functions is called.

Rust's standard library does not currently adhere to this, as evidenced by #88585. The child process calls [`sys::signal()`](https://github.com/rust-lang/rust/blob/7bf0736e130e2203c58654f7353dbf9575e49d5c/library/std/src/sys/unix/android.rs#L76), which on Android calls [`libc::dlsym()`](https://github.com/rust-lang/rust/blob/7bf0736e130e2203c58654f7353dbf9575e49d5c/library/std/src/sys/unix/weak.rs#L101), which is [**not**](https://man7.org/linux/man-pages/man7/signal-safety.7.html) async-signal-safe, and in fact causes a deadlock in the example in #88585.

I think the easiest solution here would be to just call `libc::sigaction()` instead, which [is](https://man7.org/linux/man-pages/man7/signal-safety.7.html) async-signal-safe, provides the functionality we need, and is apparently available on all Android versions because it is also used e.g. [here](https://github.com/rust-lang/rust/blob/7bf0736e130e2203c58654f7353dbf9575e49d5c/library/std/src/sys/unix/stack_overflow.rs#L112-L114).

2 years agoRollup merge of #88706 - ThePuzzlemaker:issue-88609, r=jackh726
Manish Goregaokar [Tue, 5 Oct 2021 19:52:41 +0000 (12:52 -0700)]
Rollup merge of #88706 - ThePuzzlemaker:issue-88609, r=jackh726

Normalize associated type projections when checking return type of main

This fixes #88609.

Previously, the return type of `fn main()` would not have any associated type projections within normalized before checking if it implements the standard library trait `std::process::Termination`. This commit appears to fix it.

This feels vaguely symptomatic of a problem in the underlying trait solving engine, but I am not sure how I would solve that. I am unsure why the example in #88609 with `assert_impl_termination` and `fn foo()` work, but simply `fn main()` doesn't. The way that I solved this is also probably not the best way to do this, so please let me know if there is a better way to do this.

I have added a build-pass regression test for this issue.

2 years agoNote specific regions involved in 'borrowed data escapes' error
Aaron Hill [Sun, 3 Oct 2021 20:25:26 +0000 (15:25 -0500)]
Note specific regions involved in 'borrowed data escapes' error

Fixes #67007

Currently, a 'borrowed data escapes' error does not mention
the specific lifetime involved (except indirectly through a suggestion
about adding a lifetime bound). We now explain the specific lifetime
relationship that failed to hold, which improves otherwise vague
error messages.

2 years agorefactor: VecDeques IterMut fields to private
DeveloperC [Sat, 25 Sep 2021 12:55:45 +0000 (13:55 +0100)]
refactor: VecDeques IterMut fields to private

Made the fields of VecDeque's IterMut private by creating a IterMut::new(...) function to create a new instance of IterMut and migrating usage to use IterMut::new(...).

2 years agorefactor: VecDeques Drain fields to private
DeveloperC286 [Fri, 17 Sep 2021 17:25:21 +0000 (18:25 +0100)]
refactor: VecDeques Drain fields to private

2 years agofor signed overflowing remainder, delay comparing lhs with MIN
Trevor Spiteri [Tue, 5 Oct 2021 13:15:24 +0000 (15:15 +0200)]
for signed overflowing remainder, delay comparing lhs with MIN

Since the wrapped remainder is going to be 0 for all cases when the rhs is -1,
there is no need to divide in this case. Comparing the lhs with MIN is only done
for the overflow bool. In particular, this results in better code generation for
wrapping remainder, which discards the overflow bool completely.

2 years agoAuto merge of #89363 - oli-obk:in_tracing_we_trust, r=Mark-Simulacrum
bors [Tue, 5 Oct 2021 12:52:43 +0000 (12:52 +0000)]
Auto merge of #89363 - oli-obk:in_tracing_we_trust, r=Mark-Simulacrum

Fix performance regression with #[instrument]

linked tracing PR: https://github.com/tokio-rs/tracing/pull/1600

regression introduced by #89048

2 years agoAuto merge of #89266 - cjgillot:session-ich, r=michaelwoerister
bors [Tue, 5 Oct 2021 09:45:11 +0000 (09:45 +0000)]
Auto merge of #89266 - cjgillot:session-ich, r=michaelwoerister

Move ICH to rustc_query_system

Based on https://github.com/rust-lang/rust/pull/89183

The StableHashingContext does not need to be in rustc_middle.

This PR moves it to rustc_query_system. This will avoid a dependency between rustc_ast_lowering and rustc_middle in https://github.com/rust-lang/rust/pull/89124.

2 years agoAuto merge of #89549 - Manishearth:rollup-mhkyc16, r=Manishearth
bors [Tue, 5 Oct 2021 06:56:57 +0000 (06:56 +0000)]
Auto merge of #89549 - Manishearth:rollup-mhkyc16, r=Manishearth

Rollup of 12 pull requests

Successful merges:

 - #87631 (os current_exe using same approach as linux to get always the full ab…)
 - #88234 (rustdoc-json: Don't ignore impls for primitive types)
 - #88651 (Use the 64b inner:monotonize() implementation not the 128b one for aarch64)
 - #88816 (Rustdoc migrate to table so the gui can handle >2k constants)
 - #89244 (refactor: VecDeques PairSlices fields to private)
 - #89364 (rustdoc-json: Encode json files with UTF-8)
 - #89423 (Fix ICE caused by non_exaustive_omitted_patterns struct lint)
 - #89426 (bootstrap: add config option for nix patching)
 - #89462 (haiku thread affinity build fix)
 - #89482 (Follow the diagnostic output style guide)
 - #89504 (Don't suggest replacing region with 'static in NLL)
 - #89535 (fix busted JavaScript in error index generator)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #89535 - notriddle:notriddle/error-index-generator-js, r=Mark-Simulacrum
Manish Goregaokar [Tue, 5 Oct 2021 06:56:25 +0000 (23:56 -0700)]
Rollup merge of #89535 - notriddle:notriddle/error-index-generator-js, r=Mark-Simulacrum

fix busted JavaScript in error index generator

The old JavaScript didn't work. It filled the browser console with "e.previousElementSibling not defined" errors, because it didn't account for the example-wrap div that a newer version of rustdoc added.

Additionally, it had copied versions of utility functions that had been optimized in rustdoc main.js. This version updates those.

2 years agoRollup merge of #89504 - Aaron1011:rpit-nll-static, r=nikomatsakis
Manish Goregaokar [Tue, 5 Oct 2021 06:56:24 +0000 (23:56 -0700)]
Rollup merge of #89504 - Aaron1011:rpit-nll-static, r=nikomatsakis

Don't suggest replacing region with 'static in NLL

Fixes #73159

This is similar to #69350 - if the user didn't initially
write out a 'static lifetime, adding 'static in response to
a lifetime error is usually the wrong thing to do.

2 years agoRollup merge of #89482 - hkmatsumoto:patch-diagnostics, r=joshtriplett
Manish Goregaokar [Tue, 5 Oct 2021 06:56:23 +0000 (23:56 -0700)]
Rollup merge of #89482 - hkmatsumoto:patch-diagnostics, r=joshtriplett

Follow the diagnostic output style guide

Detected by #89455.

2 years agoRollup merge of #89462 - devnexen:haiku_thread_aff_build_fix, r=nagisa
Manish Goregaokar [Tue, 5 Oct 2021 06:56:22 +0000 (23:56 -0700)]
Rollup merge of #89462 - devnexen:haiku_thread_aff_build_fix, r=nagisa

haiku thread affinity build fix

2 years agoRollup merge of #89426 - davidtwco:bootstrap-nix-toolchain-env-var, r=Mark-Simulacrum
Manish Goregaokar [Tue, 5 Oct 2021 06:56:21 +0000 (23:56 -0700)]
Rollup merge of #89426 - davidtwco:bootstrap-nix-toolchain-env-var, r=Mark-Simulacrum

bootstrap: add config option for nix patching

On NixOS systems, bootstrap will patch rustc used in bootstrapping after checking `/etc/os-release` (to confirm the current distribution is NixOS). However, when using Nix on a non-NixOS system, it can be desirable for bootstrap to patch rustc. In this commit, a `patch-binaries-for-nix` option is added to `config.toml`, which allows for user opt-in to bootstrap's Nix patching.

r? ``@Mark-Simulacrum``

2 years agoRollup merge of #89423 - DevinR528:reachable-fields, r=Nadrieril
Manish Goregaokar [Tue, 5 Oct 2021 06:56:20 +0000 (23:56 -0700)]
Rollup merge of #89423 - DevinR528:reachable-fields, r=Nadrieril

Fix ICE caused by non_exaustive_omitted_patterns struct lint

fixes #89382

Add check that a list of `Pat`s is non empty to prevent ICE in `FnCtxt::lint_non_exhaustive_omitted_patterns`.

Is related to #89374 and #89105

2 years agoRollup merge of #89364 - hkmatsumoto:encode-json-with-utf-8, r=Mark-Simulacrum
Manish Goregaokar [Tue, 5 Oct 2021 06:56:19 +0000 (23:56 -0700)]
Rollup merge of #89364 - hkmatsumoto:encode-json-with-utf-8, r=Mark-Simulacrum

rustdoc-json: Encode json files with UTF-8

Currently, `check_missing_items.py` malfunctions when the index contains some letters like emojis.

Related to #89360.

2 years agoRollup merge of #89244 - DeveloperC286:pair_slices_fields_to_private, r=joshtriplett
Manish Goregaokar [Tue, 5 Oct 2021 06:56:18 +0000 (23:56 -0700)]
Rollup merge of #89244 - DeveloperC286:pair_slices_fields_to_private, r=joshtriplett

refactor: VecDeques PairSlices fields to private

Reducing VecDeque's PairSlices fields to private, a `from(...)` method is already used to create PairSlices.

2 years agoRollup merge of #88816 - dns2utf8:rustdoc_test_gui_2k_constants, r=GuillaumeGomez
Manish Goregaokar [Tue, 5 Oct 2021 06:56:17 +0000 (23:56 -0700)]
Rollup merge of #88816 - dns2utf8:rustdoc_test_gui_2k_constants, r=GuillaumeGomez

Rustdoc migrate to table so the gui can handle >2k constants

Closes #88545.

This PR adds a test for overlapping entries in the `item-table` https://github.com/rust-lang/rust/issues/88545
It currently includes the commit with the workaround from https://github.com/rust-lang/rust/pull/88776

2 years agoRollup merge of #88651 - AGSaidi:monotonize-inner-64b-aarch64, r=dtolnay
Manish Goregaokar [Tue, 5 Oct 2021 06:56:17 +0000 (23:56 -0700)]
Rollup merge of #88651 - AGSaidi:monotonize-inner-64b-aarch64, r=dtolnay

Use the 64b inner:monotonize() implementation not the 128b one for aarch64

aarch64 prior to v8.4 (FEAT_LSE2) doesn't have an instruction that guarantees
untorn 128b reads except for completing a 128b load/store exclusive pair
(ldxp/stxp) or compare-and-swap (casp) successfully. The requirement to
complete a 128b read+write atomic is actually more expensive and more unfair
than the previous implementation of monotonize() which used a Mutex on aarch64,
especially at large core counts.  For aarch64 switch to the 64b atomic
implementation which is about 13x faster for a benchmark that involves many
calls to Instant::now().

2 years agoRollup merge of #88234 - hkmatsumoto:rustdoc-impls-for-primitive, r=jyn514
Manish Goregaokar [Tue, 5 Oct 2021 06:56:16 +0000 (23:56 -0700)]
Rollup merge of #88234 - hkmatsumoto:rustdoc-impls-for-primitive, r=jyn514

rustdoc-json: Don't ignore impls for primitive types

Fix the issue discussed at [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.E2.9C.94.20Json.20output.20lacks.20some.20item.20which.20are.20supposed.20to.20be.20there)

r? ``@jyn514``

2 years agoRollup merge of #87631 - :solarish_upd_fs, r=joshtriplett
Manish Goregaokar [Tue, 5 Oct 2021 06:56:15 +0000 (23:56 -0700)]
Rollup merge of #87631 - :solarish_upd_fs, r=joshtriplett

os current_exe using same approach as linux to get always the full ab…

…solute path

2 years agolibrary std, libc dependency update
David Carlier [Mon, 4 Oct 2021 21:11:53 +0000 (22:11 +0100)]
library std, libc dependency update

to solve #87528 build.

2 years agoAuto merge of #89545 - workingjubilee:rollup-ooxf3p2, r=workingjubilee
bors [Tue, 5 Oct 2021 04:13:35 +0000 (04:13 +0000)]
Auto merge of #89545 - workingjubilee:rollup-ooxf3p2, r=workingjubilee

Rollup of 15 pull requests

Successful merges:

 - #87993 (Stabilize try_reserve)
 - #88090 (Perform type inference in range pattern)
 - #88780 (Added abs_diff for integer types.)
 - #89270 (path.push() should work as expected on windows verbatim paths)
 - #89413 (Correctly handle supertraits for min_specialization)
 - #89456 (Update to the final LLVM 13.0.0 release)
 - #89466 (Fix bug with query modifier parsing)
 - #89473 (Fix extra `non_snake_case` warning for shorthand field bindings)
 - #89474 (rustdoc: Improve doctest pass's name and module's name)
 - #89478 (Fixed numerus of error message)
 - #89480 (Add test for issue 89118.)
 - #89487 (Try to recover from a `=>` -> `=` or `->` typo in a match arm)
 - #89494 (Deny `where` clauses on `auto` traits)
 - #89511 (:arrow_up: rust-analyzer)
 - #89536 (update Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoRollup merge of #89536 - RalfJung:miri, r=RalfJung
Jubilee [Tue, 5 Oct 2021 04:12:44 +0000 (21:12 -0700)]
Rollup merge of #89536 - RalfJung:miri, r=RalfJung

update Miri

Let's get the recent fixes and improvements shipped.
r? ````@ghost````

2 years agoRollup merge of #89511 - lnicola:rust-analyzer-2021-10-04, r=lnicola
Jubilee [Tue, 5 Oct 2021 04:12:43 +0000 (21:12 -0700)]
Rollup merge of #89511 - lnicola:rust-analyzer-2021-10-04, r=lnicola

:arrow_up: rust-analyzer

2 years agoRollup merge of #89494 - FabianWolff:issue-84075, r=davidtwco
Jubilee [Tue, 5 Oct 2021 04:12:43 +0000 (21:12 -0700)]
Rollup merge of #89494 - FabianWolff:issue-84075, r=davidtwco

Deny `where` clauses on `auto` traits

Fixes #84075.

2 years agoRollup merge of #89487 - FabianWolff:issue-89396, r=petrochenkov
Jubilee [Tue, 5 Oct 2021 04:12:42 +0000 (21:12 -0700)]
Rollup merge of #89487 - FabianWolff:issue-89396, r=petrochenkov

Try to recover from a `=>` -> `=` or `->` typo in a match arm

Fixes #89396.

2 years agoRollup merge of #89480 - hameerabbasi:issue-89118-test, r=jackh726
Jubilee [Tue, 5 Oct 2021 04:12:41 +0000 (21:12 -0700)]
Rollup merge of #89480 - hameerabbasi:issue-89118-test, r=jackh726

Add test for issue 89118.

This PR adds a test for issue 89118.

Closes #89118.

2 years agoRollup merge of #89478 - zvavybir:master, r=jyn514
Jubilee [Tue, 5 Oct 2021 04:12:40 +0000 (21:12 -0700)]
Rollup merge of #89478 - zvavybir:master, r=jyn514

Fixed numerus of error message

When there are redundant trait requirements and these are hidden, a message is generated by the following code snippet:
`format!("{} redundant requirements hidden", count)`
But if there is only a single hidden requirement, it will still print this message in plural instead of singular.

2 years agoRollup merge of #89474 - camelid:better-pass-name, r=jyn514
Jubilee [Tue, 5 Oct 2021 04:12:39 +0000 (21:12 -0700)]
Rollup merge of #89474 - camelid:better-pass-name, r=jyn514

rustdoc: Improve doctest pass's name and module's name

As the docs at the top of the file say, it is an overloaded pass and
actually runs two lints.

2 years agoRollup merge of #89473 - FabianWolff:issue-89469, r=joshtriplett
Jubilee [Tue, 5 Oct 2021 04:12:38 +0000 (21:12 -0700)]
Rollup merge of #89473 - FabianWolff:issue-89469, r=joshtriplett

Fix extra `non_snake_case` warning for shorthand field bindings

Fixes #89469. The problem is the innermost `if` condition here:
https://github.com/rust-lang/rust/blob/d14731cb3ced8318d7fc83cbe838f0e7f2fb3b40/compiler/rustc_lint/src/nonstandard_style.rs#L435-L452

This code runs for every `PatKind::Binding`, so if a struct has multiple fields, say A and B, and both are bound in a pattern using shorthands, the call to `self.check_snake_case()` will indeed be skipped in the `check_pat()` call for `A`; but when `check_pat()` is called for `B`, the loop will still iterate over `A`, and `field.ident (= A) != ident (= B)` will be true. I have fixed this by only looking at non-shorthand bindings, and only the binding that `check_pat()` was actually called for.

2 years agoRollup merge of #89466 - Mark-Simulacrum:query-macros, r=oli-obk
Jubilee [Tue, 5 Oct 2021 04:12:37 +0000 (21:12 -0700)]
Rollup merge of #89466 - Mark-Simulacrum:query-macros, r=oli-obk

Fix bug with query modifier parsing

The previous macro_rules! parsers failed when an additional modifier was added
with ambiguity errors. The error is pretty unclear as to what exactly the cause
here is, but this change simplifies the argument parsing code such that the
error is avoided.

Extracted from other work, and somewhat duplicates 0358edeb5 from #85830, but
this approach seems a little simpler to me. Not technically currently necessary but seems
like a good cleanup.

2 years agoRollup merge of #89456 - cuviper:llvm-13, r=nikic
Jubilee [Tue, 5 Oct 2021 04:12:36 +0000 (21:12 -0700)]
Rollup merge of #89456 - cuviper:llvm-13, r=nikic

Update to the final LLVM 13.0.0 release

2 years agoRollup merge of #89413 - matthewjasper:spec-marker-fix, r=nikomatsakis
Jubilee [Tue, 5 Oct 2021 04:12:35 +0000 (21:12 -0700)]
Rollup merge of #89413 - matthewjasper:spec-marker-fix, r=nikomatsakis

Correctly handle supertraits for min_specialization

Supertraits of specialization markers could circumvent checks for
min_specialization. Elaborating predicates prevents this.

r? ````@nikomatsakis````

2 years agoRollup merge of #89270 - seanyoung:join_fold, r=m-ou-se
Jubilee [Tue, 5 Oct 2021 04:12:35 +0000 (21:12 -0700)]
Rollup merge of #89270 - seanyoung:join_fold, r=m-ou-se

path.push() should work as expected on windows verbatim paths

On Windows, std::fs::canonicalize() returns an so-called UNC path.  UNC paths differ with regular paths because:

- This type of path can much longer than a non-UNC path (32k vs 260 characters).
- The prefix for a UNC path is ``Component::Prefix(Prefix::DiskVerbatim(..)))``
- No `/` is allowed
- No `.` is allowed
- No `..` is allowed

Rust has poor handling of such paths. If you join a UNC path with a path with any of the above, then this will not work.

I've implemented a new method `fn join_fold()` which joins paths and also removes any `.` and `..` from it, and replaces `/` with `\` on Windows. Using this function it is possible to use UNC paths without issue. In addition, this function is useful on Linux too; paths can be appended without having to call `canonicalize()` to remove the `.` and `..`.

This PR needs test cases, which can I add. I hope this will a start of a discussion.

2 years agoRollup merge of #88780 - orlp:int-abs-diff, r=m-ou-se
Jubilee [Tue, 5 Oct 2021 04:12:34 +0000 (21:12 -0700)]
Rollup merge of #88780 - orlp:int-abs-diff, r=m-ou-se

Added abs_diff for integer types.

Closes https://github.com/rust-lang/rust/issues/62111.

2 years agoRollup merge of #88090 - nbdd0121:inference, r=nikomatsakis
Jubilee [Tue, 5 Oct 2021 04:12:33 +0000 (21:12 -0700)]
Rollup merge of #88090 - nbdd0121:inference, r=nikomatsakis

Perform type inference in range pattern

Fix #88074

2 years agoRollup merge of #87993 - kornelski:try_reserve_stable, r=joshtriplett
Jubilee [Tue, 5 Oct 2021 04:12:33 +0000 (21:12 -0700)]
Rollup merge of #87993 - kornelski:try_reserve_stable, r=joshtriplett

Stabilize try_reserve

Stabilization PR for the [`try_reserve` feature](https://github.com/rust-lang/rust/issues/48043#issuecomment-898040475).

2 years agoAdd tests for ensuring docblock headings.
Mukund Lakshman [Tue, 5 Oct 2021 01:54:48 +0000 (21:54 -0400)]
Add tests for ensuring docblock headings.

2 years agoheading_level: u32 -> heading_offset: HeadingOffset
Mukund Lakshman [Tue, 5 Oct 2021 01:54:00 +0000 (21:54 -0400)]
heading_level: u32 -> heading_offset: HeadingOffset

2 years agoNo need to default offset since we always override it.
Mukund Lakshman [Tue, 5 Oct 2021 01:28:26 +0000 (21:28 -0400)]
No need to default offset since we always override it.

2 years agoChange `Markdown(...)` to `Markdown { ... }`
Mukund Lakshman [Tue, 5 Oct 2021 01:08:58 +0000 (21:08 -0400)]
Change `Markdown(...)` to `Markdown { ... }`

2 years agoMake an initial guess for metadata size to reduce buffer resizes
Josh Triplett [Tue, 5 Oct 2021 02:23:13 +0000 (19:23 -0700)]
Make an initial guess for metadata size to reduce buffer resizes

2 years agoFix heading for methods on trait impls.
Mukund Lakshman [Tue, 5 Oct 2021 00:49:07 +0000 (20:49 -0400)]
Fix heading for methods on trait impls.

2 years agoupdate Miri
Ralf Jung [Mon, 4 Oct 2021 22:13:00 +0000 (18:13 -0400)]
update Miri