]>
git.lizzy.rs Git - rust.git/log
Alex Butler [Thu, 1 Mar 2018 15:15:41 +0000 (15:15 +0000)]
Fix #2494 add suggestion for unreadable_literal
Add `rustc --explain E0308` line to relevant tests
bootandy [Wed, 28 Feb 2018 15:24:10 +0000 (10:24 -0500)]
Lint passing Cow by reference
Add lint for reference to Cow to the same place in the code where
lint for reference to String lives.
https://github.com/rust-lang-nursery/rust-clippy/issues/2405
Manish Goregaokar [Mon, 26 Feb 2018 20:33:45 +0000 (12:33 -0800)]
Merge pull request #2486 from ordovicia/fix
Fix for rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Manish Goregaokar [Mon, 26 Feb 2018 20:32:18 +0000 (12:32 -0800)]
Bump to 0.0.187
Manish Goregaokar [Mon, 26 Feb 2018 20:31:29 +0000 (12:31 -0800)]
oops
Manish Goregaokar [Mon, 26 Feb 2018 20:26:35 +0000 (12:26 -0800)]
Merge pull request #2489 from rust-lang-nursery/rustup
Rustup to rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Manish Goregaokar [Mon, 26 Feb 2018 19:57:14 +0000 (11:57 -0800)]
Rustup to rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Hidehito Yabuuchi [Mon, 26 Feb 2018 09:01:10 +0000 (18:01 +0900)]
Fix for rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Oliver Schneider [Sat, 24 Feb 2018 21:06:25 +0000 (22:06 +0100)]
Merge pull request #2479 from gnieto/fix/authorLint
Fix author lint
Guillem Nieto [Sat, 24 Feb 2018 18:34:51 +0000 (19:34 +0100)]
Remove explicit visit_qpath method
Instead of replacing the default behaviour of the visit_qpath method,
I've moved the printing code to private method of PrintVisitor
(print_qpath).
Guillem Nieto [Sat, 24 Feb 2018 01:02:48 +0000 (02:02 +0100)]
Fix author lint
The author lint was generating invalid code as shown on issue:
https://github.com/rust-lang-nursery/rust-clippy/issues/2442
I've changed the generated code to properly track cast
expressions.
Unfortunatelly, I've had to rewrite the `visit_decl` method, to
avoid that last if of the chain will be added. After looking at the code,
this last line was being added because of the `let x: char` part, but not
because of the `0x45df as char` expression.
It seems that let statements should not generate code on the author
lint, but I'm not sure that this is true or if I'm breaking
something on other code generation parts.
Finally, I've added a test for the author lint, but I'm not sure that
this needs to be added to the testsuite.
Manish Goregaokar [Fri, 23 Feb 2018 17:03:18 +0000 (09:03 -0800)]
Merge branch 'rustup'
Manish Goregaokar [Fri, 23 Feb 2018 16:59:42 +0000 (08:59 -0800)]
Update Rust to
063deba92e
Oliver Schneider [Fri, 23 Feb 2018 07:31:57 +0000 (08:31 +0100)]
Merge pull request #2471 from bootandy/fix_span2
Fix: point to correct problem part of code, update test
bootandy [Thu, 22 Feb 2018 15:11:20 +0000 (10:11 -0500)]
Do not pass Span by reference
Oliver Schneider [Wed, 21 Feb 2018 20:44:04 +0000 (21:44 +0100)]
Merge pull request #2473 from phansch/handle_multiline_attributes
Lint multiline attributes properly
Philipp Hansch [Wed, 21 Feb 2018 20:11:38 +0000 (21:11 +0100)]
Lint multiline attributes properly
This makes it so that the `empty_line_after_outer_attribute` lint only
checks for newlines between the end of the attribute and the beginning
of the following item.
We need to check for the empty line count being bigger than 2 because
now the snippet of valid code contains only `\n` and splitting it
produces `["", ""]`
Invalid code will contain more than 2 empty strings.
bootandy [Wed, 21 Feb 2018 16:25:18 +0000 (11:25 -0500)]
Stop unwanted newlines being applied on unwrap_or
bootandy [Tue, 20 Feb 2018 17:38:20 +0000 (12:38 -0500)]
Simplify creation of span_replace_word
Part of unwrap_or test
bootandy [Tue, 20 Feb 2018 17:37:30 +0000 (12:37 -0500)]
Add newlines in unwrap_or ui test
Oliver Schneider [Tue, 20 Feb 2018 07:33:47 +0000 (08:33 +0100)]
Merge pull request #2459 from phansch/mention_how_to_run_single_test
Explain how to execute a single UI test
Oliver Schneider [Tue, 20 Feb 2018 07:32:01 +0000 (08:32 +0100)]
Merge pull request #2458 from flip1995/suspicious_impl
Lint for suspicious implementations of arithmetic std::ops traits
Oliver Schneider [Tue, 20 Feb 2018 07:26:22 +0000 (08:26 +0100)]
Merge pull request #2470 from flip1995/doc_conf
Fix name of configuration parameters in documentation
bootandy [Thu, 15 Feb 2018 14:56:12 +0000 (09:56 -0500)]
Fix: point to correct problem part of code
Fix span so it no longer contains the whole train-wreck of code and only
points to the problem function (for the unwrap_or lint).
https://github.com/rust-lang-nursery/rust-clippy/issues/2422
Update ui test methods - it had several cases where the error message
span is now shorter
flip1995 [Mon, 19 Feb 2018 15:30:19 +0000 (16:30 +0100)]
Fix name of configuration parameters in documentation
Philipp Krones [Mon, 19 Feb 2018 12:04:14 +0000 (13:04 +0100)]
Merge branch 'master' into suspicious_impl
Oliver Schneider [Mon, 19 Feb 2018 08:56:55 +0000 (09:56 +0100)]
Merge pull request #2451 from TomasKralCZ/rdn-fields
Implement redundant field names lint #2244
Philipp Hansch [Tue, 13 Feb 2018 21:33:42 +0000 (22:33 +0100)]
Explain how to execute a single UI test
flip1995 [Tue, 13 Feb 2018 14:40:17 +0000 (15:40 +0100)]
Lint for suspicious implementations of arithmetic std::ops traits
TomasKralCZ [Sun, 11 Feb 2018 09:50:19 +0000 (10:50 +0100)]
Suggestion fixed, simplified lint logic.
TomasKralCZ [Sat, 10 Feb 2018 20:13:17 +0000 (21:13 +0100)]
Implement redundant field names lint #2244
Oliver Schneider [Fri, 9 Feb 2018 17:32:23 +0000 (18:32 +0100)]
Merge pull request #2448 from rust-lang-nursery/fixes
Fixes
Oliver Schneider [Fri, 9 Feb 2018 14:23:51 +0000 (15:23 +0100)]
Fixes #2426 (if_same_then_else false positive)
Oliver Schneider [Fri, 9 Feb 2018 13:22:50 +0000 (14:22 +0100)]
Fix #2427
Oliver Schneider [Fri, 9 Feb 2018 13:22:41 +0000 (14:22 +0100)]
Remove rarely used `type_size` helper function
Oliver Schneider [Fri, 9 Feb 2018 11:41:08 +0000 (12:41 +0100)]
Merge pull request #2446 from goodmanjonathan/fix-copies-test
Make several tests actually test the correct lints
Oliver Schneider [Fri, 9 Feb 2018 07:06:51 +0000 (08:06 +0100)]
Merge pull request #2445 from guido4000/patch-1
Simplify recommended command
Jonathan Goodman [Thu, 8 Feb 2018 19:26:50 +0000 (13:26 -0600)]
make the copies.rs test actually test the correct lints
Guido [Thu, 8 Feb 2018 11:37:56 +0000 (12:37 +0100)]
Change command to run clippy without installation
Guido [Wed, 7 Feb 2018 18:24:38 +0000 (19:24 +0100)]
Simplify recommended command
Oliver Schneider [Wed, 7 Feb 2018 08:07:46 +0000 (09:07 +0100)]
Merge pull request #2444 from phansch/fix_incorrect_useless_attribute_suggestion
Partly fix incorrect useless_attribute suggestion
Philipp Hansch [Tue, 6 Feb 2018 21:14:23 +0000 (22:14 +0100)]
Partly fix incorrect useless_attribute suggestion
This fixes an incorrect suggestion from the `useless_attribute` lint
when using `cfg_attr`.
Additionally, it will not show a suggestion anymore, if the attribute
begins on a previous line, because it is much harder to construct the
span of multi-line `cfg_attr` attributes as they don't appear in the AST.
To fix it completely, one would have to parse upwards into the file,
and find the beginning of the `cfg_attr` attribute.
Oliver Schneider [Tue, 6 Feb 2018 18:35:26 +0000 (19:35 +0100)]
Merge pull request #2443 from goodmanjonathan/fix-2438
Don't suggest eliding 'static on associated consts
Jonathan Goodman [Tue, 6 Feb 2018 18:22:34 +0000 (12:22 -0600)]
don't suggest eliding 'static on associated consts
Oliver Schneider [Tue, 6 Feb 2018 12:47:28 +0000 (13:47 +0100)]
Merge pull request #2441 from flip1995/literal_rep
Make decimal_literal_representation a restriction lint
flip1995 [Tue, 6 Feb 2018 12:05:20 +0000 (13:05 +0100)]
Make decimal_literal_representation a restriction lint
Oliver Schneider [Tue, 6 Feb 2018 08:19:51 +0000 (09:19 +0100)]
Merge pull request #2439 from gnieto/fix/cterror
Fix ICE comparing `ExprRange` equality
Guillem Nieto [Mon, 5 Feb 2018 23:31:06 +0000 (00:31 +0100)]
Fix ICE comparing `ExprRange`
`eq_expr` on hir::utils was throwing an ICE due to an invalid
LateContext being used. Due to this missusage, it was generating an ICE
with the code on the following issue:
https://github.com/rust-lang-nursery/rust-clippy/issues/2423
Oliver Schneider [Mon, 5 Feb 2018 10:28:09 +0000 (11:28 +0100)]
Cleanup calls to `layout_of`
Oliver Schneider [Mon, 5 Feb 2018 07:48:40 +0000 (08:48 +0100)]
Version Bump
Oliver Schneider [Mon, 5 Feb 2018 07:21:21 +0000 (08:21 +0100)]
Merge pull request #2433 from kimsnj/matches_sugg
Fix suggestions for ref matches
Oliver Schneider [Mon, 5 Feb 2018 07:19:11 +0000 (08:19 +0100)]
Merge pull request #2415 from HMPerson1/fix-2356
Fix `ImplItem`s being ignored
Oliver Schneider [Mon, 5 Feb 2018 07:18:20 +0000 (08:18 +0100)]
Merge pull request #2428 from phansch/fix_lint_list_issues
Allow empty lines in lint doc examples
Oliver Schneider [Mon, 5 Feb 2018 07:17:29 +0000 (08:17 +0100)]
Merge pull request #2419 from phansch/fix_doc_comment_false_positive
Fix false positive in empty_line_after_outer_attr
Oliver Schneider [Mon, 5 Feb 2018 07:08:15 +0000 (08:08 +0100)]
Merge pull request #2436 from messense/rustup
Rustup to rustc 1.25.0-nightly (
0c6091fbd 2018-02-04)
messense [Mon, 5 Feb 2018 04:16:17 +0000 (12:16 +0800)]
Rustup to rustc 1.25.0-nightly (
0c6091fbd 2018-02-04)
Karim Snj [Sun, 4 Feb 2018 12:55:37 +0000 (13:55 +0100)]
Removing extra newline
Karim Snj [Sun, 4 Feb 2018 12:41:54 +0000 (13:41 +0100)]
Fix suggestions for ref matches
Manish Goregaokar [Fri, 2 Feb 2018 07:53:32 +0000 (13:23 +0530)]
Bump to 0.0.185
HMPerson1 [Fri, 2 Feb 2018 07:03:21 +0000 (02:03 -0500)]
Fix `const_static_lifetime`
Manish Goregaokar [Fri, 2 Feb 2018 07:00:46 +0000 (12:30 +0530)]
Merge pull request #2430 from Frederick888/fix-2429
set CodeSuggestion approximate to false. fixes #2429
HMPerson1 [Fri, 2 Feb 2018 06:49:47 +0000 (01:49 -0500)]
Fix `non_expressive_names`
HMPerson1 [Tue, 30 Jan 2018 19:52:45 +0000 (14:52 -0500)]
Fix `get_enclosing_block`
Frederick Zhang [Fri, 2 Feb 2018 05:24:32 +0000 (16:24 +1100)]
set CodeSuggestion approximate to false. fixes #2429
Philipp Hansch [Thu, 1 Feb 2018 22:04:59 +0000 (23:04 +0100)]
Allow empty lines in lint doc examples
This makes sure that empty lines in lint examples are preserved.
It also fixes the documentation for the invalid_ref lint, which was not
shown because of an extra newline before the lint declaration.
Oliver Schneider [Thu, 1 Feb 2018 13:35:56 +0000 (14:35 +0100)]
Give travis a guaranteed existing directory for ui test output
Oliver Schneider [Thu, 1 Feb 2018 07:09:25 +0000 (08:09 +0100)]
Merge pull request #2417 from mathstuf/gitignore-support-symlinks
gitignore: support ignoring target as symlinks
Philipp Hansch [Thu, 1 Feb 2018 06:43:03 +0000 (07:43 +0100)]
Fix false positive in empty_line_after_outer_attr
Doc comments are syntactic sugar for #[doc] attributes, so this lint was
catching them, too.
This commit makes it so that doc comments are ignored in this lint.
I think, for normal attributes it makes sense to warn about following empty
lines, for doc comments, less. This way the user has some freedom over
the formatting.
Ben Boeckel [Wed, 31 Jan 2018 19:51:40 +0000 (14:51 -0500)]
gitignore: support ignoring target as symlinks
Oliver Schneider [Wed, 31 Jan 2018 07:27:53 +0000 (08:27 +0100)]
Merge pull request #2410 from gnieto/task/questionMarkIso
Question mark lint
Guillem Nieto [Tue, 30 Jan 2018 23:09:16 +0000 (00:09 +0100)]
Update UI tests
Guillem Nieto [Sun, 28 Jan 2018 00:04:22 +0000 (01:04 +0100)]
Add question mark operator
Oliver Schneider [Tue, 30 Jan 2018 18:17:38 +0000 (19:17 +0100)]
Merge pull request #2413 from flip1995/assign_ops
Improved suggestion on misrefactored_assign_op lint
flip1995 [Tue, 30 Jan 2018 16:45:35 +0000 (17:45 +0100)]
Additionally suggest the semantic equal variant
Oliver Schneider [Tue, 30 Jan 2018 14:02:47 +0000 (15:02 +0100)]
Version bump
flip1995 [Tue, 30 Jan 2018 13:58:38 +0000 (14:58 +0100)]
Improved suggestion on misrefactored_assign_op lint. Fixes #1239
Oliver Schneider [Tue, 30 Jan 2018 12:09:23 +0000 (13:09 +0100)]
Merge pull request #2340 from phansch/newline_after_attributes
Warn on empty lines after outer attributes
Oliver Schneider [Tue, 30 Jan 2018 08:31:56 +0000 (09:31 +0100)]
Merge pull request #2412 from topecongiro/double-comparison
Add double comparison lint
Seiichi Uchida [Tue, 30 Jan 2018 01:35:35 +0000 (10:35 +0900)]
Add double comparions lint
Seiichi Uchida [Tue, 30 Jan 2018 01:35:22 +0000 (10:35 +0900)]
Rustup to rustc 1.25.0-nightly (
90eb44a58 2018-01-29)
Oliver Schneider [Mon, 29 Jan 2018 18:21:00 +0000 (19:21 +0100)]
Merge pull request #2409 from montrivo/while_let_on_iterator
#1121: already fixed, adding a test
Tim Nielens [Mon, 29 Jan 2018 15:52:22 +0000 (16:52 +0100)]
#1121: already fixed, adding a test
Philipp Hansch [Fri, 26 Jan 2018 06:51:27 +0000 (07:51 +0100)]
Add workaround for hidden outer attribute
If the snippet is empty, it's an attribute that was inserted during macro
expansion and we want to ignore those, because they could come from external
sources that the user has no control over.
For some reason these attributes don't have any expansion info on them, so
we have to check it this way until there is a better way.
Philipp Hansch [Tue, 23 Jan 2018 20:32:06 +0000 (21:32 +0100)]
Make lint work on all members of ast::Item_
Philipp Hansch [Fri, 19 Jan 2018 07:18:29 +0000 (08:18 +0100)]
Add test case for comments between item and attr
Philipp Hansch [Mon, 8 Jan 2018 23:22:42 +0000 (00:22 +0100)]
Warn on empty lines after outer attributes
Manish Goregaokar [Mon, 29 Jan 2018 05:50:29 +0000 (11:20 +0530)]
Bump to 0.0.183
Manish Goregaokar [Mon, 29 Jan 2018 05:50:17 +0000 (11:20 +0530)]
Bump compiletest version
Manish Goregaokar [Mon, 29 Jan 2018 05:47:50 +0000 (11:17 +0530)]
Merge pull request #2408 from rust-lang-nursery/rustup
Rustup to rustc 1.25.0-nightly (
21882aad7 2018-01-28)
Manish Goregaokar [Mon, 29 Jan 2018 04:18:11 +0000 (09:48 +0530)]
Update spans
Manish Goregaokar [Mon, 29 Jan 2018 04:18:06 +0000 (09:48 +0530)]
mut_mut_macro is missing plugin(clippy)
Seiichi Uchida [Sun, 28 Jan 2018 20:37:47 +0000 (05:37 +0900)]
Remove an unused binary file
Seiichi Uchida [Sun, 28 Jan 2018 07:28:48 +0000 (16:28 +0900)]
Rustup to rustc 1.25.0-nightly (
7d6e5b9da 2018-01-27)
Manish Goregaokar [Sat, 27 Jan 2018 13:37:53 +0000 (19:07 +0530)]
Merge pull request #2403 from mikerite/fix_compile_2
Fix compilation
Michael Wright [Sat, 27 Jan 2018 12:57:31 +0000 (14:57 +0200)]
Fix compilation
Fix the compilation broken by these two changes:
+ https://github.com/rust-lang/rust/commit/
2d56abfbebdc905dafc9cf9edc0a6f58e4de7cbd #diff-7fceb7ede15b205bf5ad812c31d75384L1459
+ https://github.com/rust-lang/rust/commit/
ccf0d8399e1ef3ed6bf7005650ce42aa646b5cc7 #diff-64b696b0ef6ad44140e973801ed82b25L2771
Manish Goregaokar [Thu, 25 Jan 2018 09:13:09 +0000 (14:43 +0530)]
Merge pull request #2400 from devonhollowood/misaligned-transmute
Add misaligned_transmute lint
Devon Hollowood [Thu, 25 Jan 2018 08:33:41 +0000 (00:33 -0800)]
Add misaligned_transmute lint
Oliver Schneider [Thu, 25 Jan 2018 08:02:05 +0000 (09:02 +0100)]
Merge pull request #2399 from rust-lang-nursery/rustup
Rustup to rustc 1.25.0-nightly (
a0dcecff9 2018-01-24)
Oliver Schneider [Thu, 25 Jan 2018 07:58:47 +0000 (08:58 +0100)]
Version Bump
Manish Goregaokar [Thu, 25 Jan 2018 07:44:04 +0000 (13:14 +0530)]
Rustup to rustc 1.25.0-nightly (
a0dcecff9 2018-01-24)