]>
git.lizzy.rs Git - rust.git/log
kai.giebeler [Sun, 17 Jan 2021 21:25:56 +0000 (22:25 +0100)]
Merge remote-tracking branch 'upstream/master' into doc-markdown
bors [Sun, 17 Jan 2021 17:14:13 +0000 (17:14 +0000)]
Auto merge of #6585 - Daniel-B-Smith:false-positive-issue, r=flip1995
Explicitly document false positives
Adds documentation for known false positives for the `await_holding*` lints.
Issues:
https://github.com/rust-lang/rust-clippy/issues/6353
https://github.com/rust-lang/rust-clippy/issues/6446
changelog: document FPs for the ``await_holding_*`` lints
bors [Sun, 17 Jan 2021 16:26:28 +0000 (16:26 +0000)]
Auto merge of #6528 - Jarcho:redundant_slicing, r=flip1995
New lint: redundant_slicing
changelog: Added lint: `redundant_slicing`
fixes #6519
This will trigger on any type which implements `Index<RangeFull>` that returns the input type. This would be a false positive if the implementation does something other than return itself, but I'm not sure why you would ever want to do that.
bors [Sun, 17 Jan 2021 15:38:50 +0000 (15:38 +0000)]
Auto merge of #6582 - rail-rain:ice_6539, r=flip1995
Fix the ICE 6539
Fixes #6539
It happened because `zero_sized_map_values` used `layout_of` with types from type aliases, which is essentially the same as the ICE 4968.
---
changelog: Fix an ICE in `zero_sized_map_values`
bors [Sun, 17 Jan 2021 10:29:10 +0000 (10:29 +0000)]
Auto merge of #6549 - ThibsG:FixClosureNeedlessReturn, r=phansch
Fix FP with empty return for `needless_return` lint
This fixes a false positive in `needless_return` lint, when triggered in a closure using `return` statement without value.
Fixes: #6501
changelog: none
Jason Newcomb [Thu, 14 Jan 2021 21:38:57 +0000 (21:38 +0000)]
Update clippy_lints/src/redundant_slicing.rs
Co-authored-by: Philipp Krones <hello@philkrones.com>
Jason Newcomb [Thu, 31 Dec 2020 19:40:07 +0000 (14:40 -0500)]
fix copy-paste error
Jason Newcomb [Thu, 31 Dec 2020 17:07:24 +0000 (12:07 -0500)]
don't lint external macro expansions
Jason Newcomb [Thu, 31 Dec 2020 16:42:12 +0000 (11:42 -0500)]
fix new lint error
Jason Newcomb [Thu, 31 Dec 2020 16:10:13 +0000 (11:10 -0500)]
Initial implementation of redundant_slicing lint
bors [Fri, 15 Jan 2021 19:49:39 +0000 (19:49 +0000)]
Auto merge of #6500 - Javier-varez:case_sensitive_file_extensions, r=llogiq
Case sensitive file extensions
Closes #6425
Looks for ends_with methods calls with case sensitive extension comparisons.
changelog: Add new lint that warns about case-sensitive file extension comparisons.
ThibsG [Fri, 15 Jan 2021 17:58:48 +0000 (18:58 +0100)]
Fix test due to recent Rustup merge
ThibsG [Mon, 4 Jan 2021 20:20:44 +0000 (21:20 +0100)]
Fix FP with empty return for `needless_return` lint
bors [Fri, 15 Jan 2021 16:25:03 +0000 (16:25 +0000)]
Auto merge of #6574 - Jarcho:single_match_eq, r=Manishearth
single_match: suggest `if` over `if let` when possible
fixes: #173
changelog: single_match: suggest `if` over `if let` when possible
bors [Fri, 15 Jan 2021 10:40:35 +0000 (10:40 +0000)]
Auto merge of #6589 - giraffate:add_notes_of_prioritization_labels_to_doc, r=flip1995
Add notes of prioritization labels to doc
Refer to https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/New.20prioritization.20labels.
changelog: none
Philipp Krones [Fri, 15 Jan 2021 10:30:58 +0000 (11:30 +0100)]
Fix formulations in label descriptions
bors [Fri, 15 Jan 2021 10:27:47 +0000 (10:27 +0000)]
Auto merge of #6555 - stanislav-tkach:patch-1, r=flip1995
Remove duplication in the manual_ok_or lint example
changelog: none
bors [Fri, 15 Jan 2021 09:48:15 +0000 (09:48 +0000)]
Auto merge of #6586 - flip1995:rustup, r=flip1995
Rustup
r? `@ghost`
changelog: FP fix: [`needless_return`] no longer triggers inside macros.
flip1995 [Fri, 15 Jan 2021 09:41:29 +0000 (10:41 +0100)]
Don't trigger needless_return lint in macros
flip1995 [Fri, 15 Jan 2021 09:40:17 +0000 (10:40 +0100)]
Bump nightly version to 2021-01-15
flip1995 [Fri, 15 Jan 2021 09:02:28 +0000 (10:02 +0100)]
Merge remote-tracking branch 'upstream/master' into rustup
Jason Newcomb [Fri, 15 Jan 2021 03:02:04 +0000 (22:02 -0500)]
Rename function
Takayuki Nakata [Fri, 15 Jan 2021 00:11:31 +0000 (09:11 +0900)]
Add notes of prioritization labels to doc
Jason Newcomb [Thu, 14 Jan 2021 19:26:26 +0000 (14:26 -0500)]
Address review comments
Add: attempt to remove address of expressions from the scrutinee expression before adding references to the pattern
bors [Thu, 14 Jan 2021 14:41:58 +0000 (14:41 +0000)]
Auto merge of #79328 - c410-f3r:hir-if, r=matthewjasper
Reintroduce hir::ExprKind::If
Basically copied and paste #59288/https://github.com/rust-lang/rust-clippy/pull/4080 with some modifications.
The vast majority of tests were fixed and now there are only a few remaining. Since I am still unable to figure out the missing pieces, any help with the following list is welcome.
- [ ] **Unnecessary `typeck` exception**: [Cheated on this one to make CI green.](https://github.com/rust-lang/rust/pull/79328/files#diff-
3faee9ba23fc54a12b7c43364ba81f8c5660045c7e1d7989a02a0cee1c5b2051 )
- [x] **Incorrect span**: [Span should reference `then` and `else` separately.](https://github.com/rust-lang/rust/pull/79328/files#diff-
cf2c46e82222ee4b1037a68fff8a1af3c4f1de7a6b3fd798aacbf3c0475abe3d )
- [x] **New note regarding `assert!`**: [Modified but not "wrong". Maybe can be a good thing?](https://github.com/rust-lang/rust/pull/79328/files#diff-
9e0d7c89ed0224e2b62060c957177c27db43c30dfe3c2974cb6b5091cda9cfb5 )
- [x] **Inverted report location**: [Modified but not "wrong". Locations were inverted.](https://github.com/rust-lang/rust/pull/79328/files#diff-
f637ce7c1f68d523a165aa9651765df05e36c4d7d279194b1a6b28b48a323691 )
- [x] **`src/test/ui/point-to-type-err-cause-on-impl-trait-return.rs` has weird errors**: [Not sure why this is happening.](https://github.com/rust-lang/rust/pull/79328/files#diff-
c823c09660f5b112f95e97e8ff71f1797b6c7f37dbb3d16f8e98bbaea8072e95 )
- [x] **Missing diagnostic**: [???](https://github.com/rust-lang/rust/pull/79328/files#diff-
6b8ab09360d725ba4513933827f9796b42ff9522b0690f80b76de067143af2fc )
Daniel Smith [Wed, 13 Jan 2021 21:08:15 +0000 (16:08 -0500)]
Explicitly document false positives
bors [Wed, 13 Jan 2021 20:35:58 +0000 (20:35 +0000)]
Auto merge of #77524 - Patryk27:fixes/66228, r=estebank
Rework diagnostics for wrong number of generic args (fixes #66228 and #71924)
This PR reworks the `wrong number of {} arguments` message, so that it provides more details and contextual hints.
bors [Wed, 13 Jan 2021 08:16:43 +0000 (08:16 +0000)]
Auto merge of #6584 - giraffate:make_references_to_issues_links, r=llogiq
Make a reference a link in doc
I think it's incovenient that references in doc are just a text.
changelog: none
Joshua Nelson [Sun, 22 Nov 2020 22:46:21 +0000 (17:46 -0500)]
Separate out a `hir::Impl` struct
This makes it possible to pass the `Impl` directly to functions, instead
of having to pass each of the many fields one at a time. It also
simplifies matches in many cases.
Takayuki Nakata [Wed, 13 Jan 2021 00:21:26 +0000 (09:21 +0900)]
Make a reference a link in doc
rail [Tue, 12 Jan 2021 22:08:12 +0000 (11:08 +1300)]
Fix the ICE 6539
It happened because `zero_sized_map_values` used `layout_of` with types
from type aliases, which is essentially the same as the ICE 4968.
bors [Tue, 12 Jan 2021 16:33:47 +0000 (16:33 +0000)]
Auto merge of #6462 - flip1995:roadmap, r=flip1995,llogiq,killercup,Manishearth,oli-obk,matthiaskrgr,phansch,mikerite,mcarton,yaahc,ebroto
Roadmap for 2021
[Rendered](https://github.com/flip1995/rust-clippy/blob/roadmap/doc/roadmap-2021.md)
This is the first time Clippy gets its own roadmap. The reason for this roadmap is, that with the Rust language growing, also Clippy is growing. With this keeping track of and implementing bigger projects gets quite hard. This roadmap should help in exactly this regard.
After having the approval of this roadmap by the Clippy team, we want to know from the community:
- What do you think in general about this roadmap?
- Are there any pain points in Clippy, that should be included here?
- What of the points listed here has the highest priority for you?
We're looking forward to getting your feedback!
changelog: Add roadmap for Clippy 2021
r? `@rust-lang/clippy`
bors [Mon, 11 Jan 2021 22:03:46 +0000 (22:03 +0000)]
Auto merge of #6557 - rail-rain:extending_cast_ptr_alignment, r=phansch
Catch `pointer::cast` too in `cast_ptr_alignment`
Fixes #4708
Although there were some discussion in the issue, this PR implements the original feature. I think `cast_ptr_alignment` should exist as it is, separated from `ptr_as_ptr`.
---
changelog: Extend `cast_ptr_alignment` lint for the `pointer::cast` method
rail [Mon, 11 Jan 2021 21:06:41 +0000 (10:06 +1300)]
Simplify `cast_ptr_alignment` `pointer::casr` case
bors [Mon, 11 Jan 2021 16:49:32 +0000 (16:49 +0000)]
Auto merge of #6575 - flip1995:stop_linting_deps, r=Manishearth
Change env var used for testing Clippy
This changes the variable used for testing Clippy in the internal test
suite:
```
CLIPPY_TESTS -> __CLIPPY_INTERNAL_TESTS
```
`CLIPPY_TESTS` is understandably used in environments of Clippy users,
so we shouldn't use it in our test suite.
changelog: Fix oversight which caused Clippy to lint deps in some environments.
Once again fixes https://github.com/rust-lang/rust-clippy/issues/3874
Jason Newcomb [Mon, 11 Jan 2021 04:32:23 +0000 (23:32 -0500)]
Add: single_match will suggest using if .. == .. instead of if let when applicable
Patryk Wychowaniec [Sat, 2 Jan 2021 18:45:11 +0000 (19:45 +0100)]
Rework diagnostics for wrong number of generic args
Vadim Petrochenkov [Sat, 19 Dec 2020 20:38:22 +0000 (23:38 +0300)]
ast: Remove some indirection layers from values in key-value attributes
bors [Sat, 9 Jan 2021 15:28:10 +0000 (15:28 +0000)]
Auto merge of #6565 - giraffate:small_fixes_of_doc_in_needless_question_mark, r=phansch
Small fixes of doc in `needless_question_mark`
changelog: none
bors [Sat, 9 Jan 2021 13:42:28 +0000 (13:42 +0000)]
Auto merge of #6571 - ThibsG:BoxedLocalTrait, r=phansch
Fix FP for `boxed_local` lint in default trait fn impl
Fix FP on default trait function implementation on `boxed_local` lint.
Maybe I checked too much when looking if `self` is carrying `Self` in its bound type.
I can't find a good test case for this, so it could be too much conservative.
Let me know if you think only detecting `self` parameter is enough.
Fixes: #4804
changelog: none
ThibsG [Sat, 9 Jan 2021 11:26:24 +0000 (12:26 +0100)]
Fix FP for `boxed_local` lint in default trait fn impl
bors [Fri, 8 Jan 2021 23:25:57 +0000 (23:25 +0000)]
Auto merge of #6569 - camsteffen:symbol-comparison, r=Manishearth
Internal lint symbol comparisons
changelog: none
* Added awareness of `rustc_span::symbol::kw::*` symbols.
* Compare with const symbols: `symbol.as_str() == "self"` => `symbol == kw::SelfLower`
* Don't compare symbols by string: `a.as_str() == b.as_str()` => `a == b`
* Lint comparing with `to_ident_string` or `to_string` instead of `Symbol::as_str`.
Cameron Steffen [Tue, 29 Dec 2020 22:04:31 +0000 (16:04 -0600)]
Fix symbol string comparison dogfood
Cameron Steffen [Wed, 30 Dec 2020 21:52:15 +0000 (15:52 -0600)]
Add unnecessary symbol string lint
Cameron Steffen [Tue, 29 Dec 2020 21:43:18 +0000 (15:43 -0600)]
Fix unnecessary keyword intern dogfood
Cameron Steffen [Tue, 29 Dec 2020 21:40:55 +0000 (15:40 -0600)]
Add keywords to interning defined symbol lint
Cameron Steffen [Wed, 30 Dec 2020 21:38:21 +0000 (15:38 -0600)]
Use DefId in interning defined symbol lint
bors [Fri, 8 Jan 2021 01:49:26 +0000 (01:49 +0000)]
Auto merge of #6566 - giraffate:reduce_the_span_in_from_over_into, r=Manishearth
Reduce the span in `from_over_into` to impl header
A follow up of https://github.com/rust-lang/rust-clippy/pull/6476#discussion_r546271382
> That item might be quite large. We may want to reduce the span to the `impl` header.
changelog: none
rail [Fri, 8 Jan 2021 01:15:12 +0000 (14:15 +1300)]
Move `is_hir_ty_cfg_dependant` to `util`,
add stuff on pointer::cast` to the document for `cast_ptr_alignment`
and fix line numbers in the test.
Takayuki Nakata [Thu, 7 Jan 2021 23:37:57 +0000 (08:37 +0900)]
Reduce the span in `from_over_into` to impl header
Takayuki Nakata [Thu, 7 Jan 2021 23:45:15 +0000 (08:45 +0900)]
Small fixes of doc in `needless_question_mark`
Caio [Fri, 1 Jan 2021 18:38:11 +0000 (15:38 -0300)]
Reintroduce hir::ExprKind::If
bors [Thu, 7 Jan 2021 13:38:32 +0000 (13:38 +0000)]
Auto merge of #6558 - stanislav-tkach:patch-2, r=flip1995
Fix typo: `irrevelent` -> `irrelevant`
changelog: none
Stanislav Tkach [Thu, 7 Jan 2021 11:59:55 +0000 (13:59 +0200)]
Fix typo: `irrevelent` -> `irrelevant`
flip1995 [Thu, 7 Jan 2021 11:38:10 +0000 (12:38 +0100)]
Change env var used for testing Clippy
This changes the variable used for testing Clippy in the internal test
suite:
```
CLIPPY_TESTS -> __CLIPPY_INTERNAL_TESTS
```
`CLIPPY_TESTS` is understandably used in environments of Clippy users,
so we shouldn't use it in our test suite.
rail [Thu, 7 Jan 2021 03:41:15 +0000 (16:41 +1300)]
Catch `pointer::cast` too in `cast_ptr_alignment`
bors [Wed, 6 Jan 2021 11:57:56 +0000 (11:57 +0000)]
Auto merge of #6554 - sozysozbot:master, r=flip1995
Fix typo: `which which can be` -> `which can be`
Fixed a typo in the explanation of https://rust-lang.github.io/rust-clippy/master/index.html#large_types_passed_by_value : `which which can be` -> `which can be`
changelog: none
Stanislav Tkach [Wed, 6 Jan 2021 11:26:35 +0000 (13:26 +0200)]
Remove duplication in the manual_ok_or lint example
jekto_vatimeliju [Wed, 6 Jan 2021 11:02:50 +0000 (20:02 +0900)]
Fix typo: `which which can be` -> `which can be`
bors [Wed, 6 Jan 2021 08:22:47 +0000 (08:22 +0000)]
Auto merge of #6553 - phansch:field-reassign-with-default-macros, r=flip1995
Fix derive and macro related false positives in `field_reassign_with_default`
Closes #6545
changelog: Fix derive and macro related false positives in [`field_reassign_with_default`]
Philipp Hansch [Tue, 5 Jan 2021 19:11:37 +0000 (20:11 +0100)]
Fix macro issues with field_reassign_with_default
Philipp Hansch [Tue, 5 Jan 2021 15:31:08 +0000 (16:31 +0100)]
Use existing 'is_automatically_derived' helper
bors [Tue, 5 Jan 2021 15:22:57 +0000 (15:22 +0000)]
Auto merge of #6551 - phansch:tiny-symbol-cleanup, r=flip1995
Tiny Symbol cleanup
* Renames `sym.rs` to `sym_helper.rs` so that the `sym as rustc_sym` is no longer needed.
* Removes one needless `symbol` from a path
changelog: none
Philipp Hansch [Tue, 5 Jan 2021 15:03:39 +0000 (16:03 +0100)]
Tiny Symbol cleanup
* Renames `sym.rs` to `sym_helper.rs` so that the `sym as rustc_sym` is no longer needed.
* Removes one needless `symbol` from a path
Javier Alvarez [Wed, 23 Dec 2020 15:59:17 +0000 (16:59 +0100)]
Remove default lint description
This was left as default and caused a CI failure for the
case_sensitive_file_extension_comparison lint.
Javier Alvarez [Wed, 23 Dec 2020 15:31:04 +0000 (16:31 +0100)]
Fix case-sensitive extension check
Javier Alvarez [Wed, 23 Dec 2020 11:37:37 +0000 (12:37 +0100)]
Add case_sensitive_file_extensions lint
Closes #6425
Looks for ends_with methods calls with case sensitive extensions.
bors [Tue, 5 Jan 2021 09:54:34 +0000 (09:54 +0000)]
Auto merge of #6542 - rail-rain:ptr_as_ptr, r=flip1995
Add a new lint `ptr_as_ptr`
This PR adds a new lint `ptr_as_ptr` which checks for `as` casts between raw pointers without changing its mutability and suggest replacing it with `pointer::cast`. Closes #5890.
Open question: should this lint be `pedantic` or `style`? I set it `pedantic` for now because the original post suggests using it, but I think the lint also fits well to `style`.
---
changelog: New lint `ptr_as_ptr`
bors [Tue, 5 Jan 2021 09:37:19 +0000 (09:37 +0000)]
Auto merge of #6513 - nahuakang:fix/empty_enum_lint_never_type, r=flip1995
Fix: Empty enum never type suggested only if the feature is enabled
This PR addresses [Issue 6422](https://github.com/rust-lang/rust-clippy/issues/6422). Instead of always recommending `never type` for empty enums, Clippy would only recommend [the lint](https://rust-lang.github.io/rust-clippy/master/index.html#empty_enum) if [LatePass.TyCtxt](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/context/struct.TyCtxt.html) has `features().never_type` enabled.
- \[ ] Followed [lint naming conventions][lint_naming]
- \[x] Added passing UI tests (including committed `.stderr` file)
- \[x] `cargo test` passes locally
- \[x] Executed `cargo dev update_lints`
- \[x] Added lint documentation
- \[x] Run `cargo dev fmt`
---
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: Only trigger [`empty_enum`] lint if `never_type` feature is enabled.
bors [Tue, 5 Jan 2021 08:00:50 +0000 (08:00 +0000)]
Auto merge of #6547 - camsteffen:curse-outdated, r=phansch
Curse outdated test output
changelog: internal
Change `cargo dev bless` to only include test output that was generated since the last build of clippy. This is especially useful when running tests with `TESTNAME=...`. The feature may be disabled by `cargo dev bless --ignore-timestamp`.
rail [Mon, 4 Jan 2021 21:17:31 +0000 (10:17 +1300)]
Fix the MSRV and add the tests for MSRV
rail [Sun, 3 Jan 2021 21:34:11 +0000 (10:34 +1300)]
Add a new lint `ptr_as_ptr`,
which checks for `as` casts between raw pointers
without changing its mutability
and suggest replacing it with `pointer::cast`.
bors [Mon, 4 Jan 2021 20:42:18 +0000 (20:42 +0000)]
Auto merge of #6538 - Jarcho:vec_init_then_push, r=llogiq
New lint: vec_init_then_push
fixes: #1483
This will trigger on `new`, `default`, and `with_capacity` when the given capacity is less than or equal to the number of push calls. Is there anything else this should trigger on?
changelog: Added lint: `vec_init_then_push`
nahuakang [Mon, 4 Jan 2021 17:41:42 +0000 (18:41 +0100)]
Run cargo dev fmt
nahuakang [Mon, 4 Jan 2021 16:47:59 +0000 (17:47 +0100)]
Address flip1995's review comments
bors [Mon, 4 Jan 2021 15:17:58 +0000 (15:17 +0000)]
Auto merge of #6548 - camsteffen:bless-internal, r=flip1995
Add ui-internal to cargo dev bless
changelog: internal
Cameron Steffen [Thu, 31 Dec 2020 16:50:00 +0000 (10:50 -0600)]
Bless only updated since clippy build
Cameron Steffen [Thu, 31 Dec 2020 15:50:23 +0000 (09:50 -0600)]
Add ui-internal to cargo dev bless
bors [Mon, 4 Jan 2021 14:17:24 +0000 (14:17 +0000)]
Auto merge of #6507 - bengsparks:lint/issue6410, r=flip1995
Needless Question Mark Lint
Fixes #6410, i.e the needless question mark lint
changelog: [`needless_question_mark`] New lint
Benjamin Sparks [Sat, 26 Dec 2020 17:02:46 +0000 (18:02 +0100)]
Implemented needless question mark lint
bors [Mon, 4 Jan 2021 12:45:51 +0000 (12:45 +0000)]
Auto merge of #6544 - matthiaskrgr:else_if, r=flip1995
collapsible_if: split collapsible_else_if into its own lint so we can enable/disable it particularly
This splits up clippy::collapsible_if into collapsible_if for
if x {
if y { }
}
=>
if x && y { }
and collapsible_else_if for
if x {
} else {
if y { }
}
=>
if x {
} else if y {
}
so that we can lint for only the latter but not the first if we desire.
changelog: collapsible_if: split up linting for if x {} else { if y {} } into collapsible_else_if lint
Matthias Krüger [Mon, 4 Jan 2021 07:25:38 +0000 (08:25 +0100)]
collapsible_if: split collapsible_else_if into its own lint so we can enable/disable it particularly
This splits up clippy::collapsible_if into collapsible_if for
if x {
if y { }
}
=>
if x && y { }
and collapsible_else_if for
if x {
} else {
if y { }
}
=>
if x {
} else if y {
}
so that we can lint for only the latter but not the first if we desire.
changelog: collapsible_if: split up linting for if x {} else { if y {} } into collapsible_else_if lint
flip1995 [Mon, 4 Jan 2021 10:37:48 +0000 (11:37 +0100)]
Add prioritization chapter and remove unresolved questions
bors [Mon, 4 Jan 2021 09:23:01 +0000 (09:23 +0000)]
Auto merge of #6525 - phansch:fix-bless-in-subdirs, r=flip1995
Fix blessing of test output in subdirectories
The core issue was the usage of `reference_file_path.file_name()`, which
provided a non-existent path if the file to be updated was in a
subdirectory.
Instead we have to provide the whole path after 'tests/ui/' as the
'filename'. This part of the path is called `test_name` in the code now.
changelog: none
Jason Newcomb [Sun, 3 Jan 2021 19:04:05 +0000 (14:04 -0500)]
Fix docs: use type inference
bors [Sat, 2 Jan 2021 23:51:49 +0000 (23:51 +0000)]
Auto merge of #6518 - ThibsG:CopyException, r=ebroto
Ensure `Copy` exception in trait definition for `wrong_self_conventio…
Add a test case to ensure `Copy` exception is preserved also in trait definition, when passing `self` by value.
Follow up of #6316
changelog: none
bors [Sat, 2 Jan 2021 23:38:23 +0000 (23:38 +0000)]
Auto merge of #6531 - matthiaskrgr:6522, r=ebroto
field_reassign_with_default: don't expand macros in suggestion
fixes #6522
changelog: field_reassign_with_default: don't expand macros in lint suggestion (#6522)
Jason Newcomb [Sat, 2 Jan 2021 19:31:21 +0000 (14:31 -0500)]
Fix lint errors
Jason Newcomb [Sat, 2 Jan 2021 16:18:04 +0000 (11:18 -0500)]
Fix clone_on_copy test
flip1995 [Sat, 2 Jan 2021 17:01:42 +0000 (18:01 +0100)]
Use bootstrap rustc for versioncheck in Clippy
bors [Sat, 2 Jan 2021 16:13:24 +0000 (16:13 +0000)]
Auto merge of #6520 - phansch:update-changelog, r=flip1995
Update CHANGELOG for Rust 1.50
changelog: none
r? `@flip1995`
Jason Newcomb [Sat, 2 Jan 2021 16:08:56 +0000 (11:08 -0500)]
Add lint
flip1995 [Sat, 2 Jan 2021 15:29:43 +0000 (16:29 +0100)]
bors [Sat, 2 Jan 2021 15:28:08 +0000 (15:28 +0000)]
Auto merge of #6536 - flip1995:rustup, r=flip1995
Rustup
r? `@ghost`
changelog: none
flip1995 [Sat, 2 Jan 2021 15:26:10 +0000 (16:26 +0100)]
Bump Clippy version to 0.1.51
flip1995 [Sat, 2 Jan 2021 15:20:43 +0000 (16:20 +0100)]
Use rustc --version in versioncheck
flip1995 [Sat, 2 Jan 2021 15:05:54 +0000 (16:05 +0100)]
Bump nightly version to 2021-01-02
flip1995 [Sat, 2 Jan 2021 15:03:26 +0000 (16:03 +0100)]
Merge remote-tracking branch 'upstream/master' into rustup
bors [Sat, 2 Jan 2021 13:12:15 +0000 (13:12 +0000)]
Auto merge of #6530 - m-ou-se:2021, r=phansch
Initial support for Rust 2021.
Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021.
changelog: Added support for Rust 2021.
Matthias Krüger [Fri, 1 Jan 2021 15:59:59 +0000 (16:59 +0100)]
field_reassign_with_default: don't expand macros in suggestion
fixes #6522
changelog: field_reassign_with_default: don't expand macros in lint suggestion (#6522)