]> git.lizzy.rs Git - rust.git/log
rust.git
3 years agoAuto merge of #76929 - ssomers:btree_cleanup_2, r=Mark-Simulacrum
bors [Sat, 19 Sep 2020 19:15:06 +0000 (19:15 +0000)]
Auto merge of #76929 - ssomers:btree_cleanup_2, r=Mark-Simulacrum

BTreeMap: wrap node's raw parent pointer in NonNull

Now that the other `*const` (root) is gone, seemed like a small step forward.

r? `@Mark-Simulacrum`

3 years agoBTreeMap: wrap node's raw parent pointer in NonNull
Stein Somers [Sat, 19 Sep 2020 14:47:03 +0000 (16:47 +0200)]
BTreeMap: wrap node's raw parent pointer in NonNull

3 years agoAuto merge of #76327 - lzutao:split-core-num, r=SimonSapin
bors [Sat, 19 Sep 2020 16:13:26 +0000 (16:13 +0000)]
Auto merge of #76327 - lzutao:split-core-num, r=SimonSapin

Split `core/num/mod.rs` to smaller mods

Note for reviewer:
* I split to multiple commits for easier reviewing, but I could git squash them all to one if requested.
* Recommend pulling this change locally and using advanced git diff viewer or this command:
  ```
  git show --reverse --color-moved=dimmed-zebra master..
  ```

---

I split `core/num/mod.rs` to these modules:

* `error`: For error structs like `ParseIntError`.
* blanket `shells` dir: For dummy number type modules: std::i32, std::f32, and the likes. Why? See below.
* `int_macros` and `uint_macros`: Real implementation of all integer types via `int_impl` and `uint_impl`
* `nonzero`: For `NonZero*` types and their implementations.
* `wrapping`: For `Wrapping<T>` types.

3 years agoRemove outdated ignored tidy comment
Lzu Tao [Fri, 4 Sep 2020 15:31:23 +0000 (15:31 +0000)]
Remove outdated ignored tidy comment

3 years agoMove (u)int_impl macros to their own files
Lzu Tao [Fri, 4 Sep 2020 14:20:01 +0000 (14:20 +0000)]
Move (u)int_impl macros to their own files

3 years agoMove dummy integer modules (like core::u32) to shells dir
Lzu Tao [Fri, 4 Sep 2020 14:00:38 +0000 (14:00 +0000)]
Move dummy integer modules (like core::u32) to shells dir

3 years agoMove error structs to new mod
Lzu Tao [Fri, 4 Sep 2020 13:37:15 +0000 (13:37 +0000)]
Move error structs to new mod

3 years agoMove Wrapping<T> definition to wrapping mod
Lzu Tao [Fri, 4 Sep 2020 13:14:39 +0000 (13:14 +0000)]
Move Wrapping<T> definition to wrapping mod

3 years agoMove NonZero* to its file
Lzu Tao [Fri, 4 Sep 2020 13:07:03 +0000 (13:07 +0000)]
Move NonZero* to its file

3 years agoAuto merge of #76880 - shepmaster:cc-rs, r=Mark-Simulacrum
bors [Sat, 19 Sep 2020 13:31:23 +0000 (13:31 +0000)]
Auto merge of #76880 - shepmaster:cc-rs, r=Mark-Simulacrum

Update cc crate to 1.0.60 to understand aarch64-apple-darwin with clang

r? `@Mark-Simulacrum`

/cc `@alexcrichton`

3 years agoAuto merge of #76912 - RalfJung:rollup-q9ur56h, r=RalfJung
bors [Sat, 19 Sep 2020 11:29:00 +0000 (11:29 +0000)]
Auto merge of #76912 - RalfJung:rollup-q9ur56h, r=RalfJung

Rollup of 14 pull requests

Successful merges:

 - #73963 (deny(unsafe_op_in_unsafe_fn) in libstd/path.rs)
 - #75099 (lint/ty: move fns to avoid abstraction violation)
 - #75502 (Use implicit (not explicit) rules for promotability by default in `const fn`)
 - #75580 (Add test for checking duplicated branch or-patterns)
 - #76310 (Add `[T; N]: TryFrom<Vec<T>>` (insta-stable))
 - #76400 (Clean up vec benches bench_in_place style)
 - #76434 (do not inline black_box when building for Miri)
 - #76492 (Add associated constant `BITS` to all integer types)
 - #76525 (Add as_str() to string::Drain.)
 - #76636 (assert ScalarMaybeUninit size)
 - #76749 (give *even better* suggestion when matching a const range)
 - #76757 (don't convert types to the same type with try_into (clippy::useless_conversion))
 - #76796 (Give a better error message when x.py uses the wrong stage for CI)
 - #76798 (Build fixes for RISC-V 32-bit Linux support)

Failed merges:

r? `@ghost`

3 years agoRollup merge of #76798 - alistair23:alistair/rv32-linux, r=jyn514
Ralf Jung [Sat, 19 Sep 2020 09:47:56 +0000 (11:47 +0200)]
Rollup merge of #76798 - alistair23:alistair/rv32-linux, r=jyn514

Build fixes for RISC-V 32-bit Linux support

This fixes build issues with the 32-bit RISC-V port.

3 years agoRollup merge of #76796 - jyn514:wrong-stage, r=shepmaster
Ralf Jung [Sat, 19 Sep 2020 09:47:54 +0000 (11:47 +0200)]
Rollup merge of #76796 - jyn514:wrong-stage, r=shepmaster

Give a better error message when x.py uses the wrong stage for CI

r? @shepmaster

3 years agoRollup merge of #76757 - matthiaskrgr:clippy_try_into, r=lcnr
Ralf Jung [Sat, 19 Sep 2020 09:47:52 +0000 (11:47 +0200)]
Rollup merge of #76757 - matthiaskrgr:clippy_try_into, r=lcnr

don't convert types to the same type with try_into (clippy::useless_conversion)

3 years agoRollup merge of #76749 - guswynn:hir_ranges, r=estebank
Ralf Jung [Sat, 19 Sep 2020 09:47:50 +0000 (11:47 +0200)]
Rollup merge of #76749 - guswynn:hir_ranges, r=estebank

give *even better* suggestion when matching a const range

notice that the err already has "constant defined here"
so this is now *exceedingly clear*

extension to #76222

r? @estebank

3 years agoRollup merge of #76636 - RalfJung:miri-size-assert, r=oli-obk
Ralf Jung [Sat, 19 Sep 2020 09:47:49 +0000 (11:47 +0200)]
Rollup merge of #76636 - RalfJung:miri-size-assert, r=oli-obk

assert ScalarMaybeUninit size

I noticed most low-level Miri types have such an assert but `ScalarMaybeUninit` does not, so let's add that. Good t see that the `Option`-like optimization kicks in and this is no bigger than `Scalar`. :)

r? @oli-obk

3 years agoRollup merge of #76525 - fusion-engineering-forks:string-drain, r=dtolnay
Ralf Jung [Sat, 19 Sep 2020 09:47:47 +0000 (11:47 +0200)]
Rollup merge of #76525 - fusion-engineering-forks:string-drain, r=dtolnay

Add as_str() to string::Drain.

Vec's Drain recently [had its `.as_slice()` stabilized](https://github.com/rust-lang/rust/pull/72584), but String's Drain was still missing the analogous `.as_str()`. This adds that.

Also improves the Debug implementation, which now shows the remaining data instead of just `"Drain { .. }"`.

3 years agoRollup merge of #76492 - fusion-engineering-forks:int-bits, r=dtolnay
Ralf Jung [Sat, 19 Sep 2020 09:47:45 +0000 (11:47 +0200)]
Rollup merge of #76492 - fusion-engineering-forks:int-bits, r=dtolnay

Add associated constant `BITS` to all integer types

Recently I've regularly come across this snippet (in a few different crates, including `core` and `std`):
```rust
std::mem::size_of<usize>() * 8
```

I think it's time for a `usize::BITS`.

3 years agoRollup merge of #76434 - RalfJung:black-box, r=Mark-Simulacrum
Ralf Jung [Sat, 19 Sep 2020 09:47:43 +0000 (11:47 +0200)]
Rollup merge of #76434 - RalfJung:black-box, r=Mark-Simulacrum

do not inline black_box when building for Miri

We cannot do the assembly trick in Miri, but let's at least make sure MIR inlining does not circumvent the black_box.

Also use black_box instead of local optimization barriers in a few const tests.

3 years agoRollup merge of #76400 - pickfire:patch-5, r=dtolnay
Ralf Jung [Sat, 19 Sep 2020 09:47:41 +0000 (11:47 +0200)]
Rollup merge of #76400 - pickfire:patch-5, r=dtolnay

Clean up vec benches bench_in_place style

3 years agoRollup merge of #76310 - scottmcm:array-try_from-vec, r=dtolnay
Ralf Jung [Sat, 19 Sep 2020 09:47:39 +0000 (11:47 +0200)]
Rollup merge of #76310 - scottmcm:array-try_from-vec, r=dtolnay

Add `[T; N]: TryFrom<Vec<T>>` (insta-stable)

This is very similar to the [existing](https://doc.rust-lang.org/nightly/std/convert/trait.TryFrom.html#impl-TryFrom%3CBox%3C%5BT%5D%3E%3E) `Box<[T; N]>: TryFrom<Box<[T]>>`, but allows avoiding the `shrink_to_fit` if you have a vector and not a boxed slice.

Like the slice equivalents of this, it fails if the length of the vector is not exactly `N`.
This uses `Vec<T>` as the `Error` type to return the input, like how the `Rc<[T]> -> Rc<[T; N]>` (and Arc) ones also reflect the input directly in the error type.

```rust
#[stable(feature = "array_try_from_vec", since = "1.47.0")]
impl<T, const N: usize> TryFrom<Vec<T>> for [T; N] {
    type Error = Vec<T>;
    fn try_from(mut vec: Vec<T>) -> Result<[T; N], Vec<T>>;
}
```

Inspired by this zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/APIs.20for.20getting.20stuff.20from.20a.20Vec.20by.20owned/near/209048103

3 years agoRollup merge of #75580 - JulianKnodt:or_pattern, r=wesleywiser
Ralf Jung [Sat, 19 Sep 2020 09:47:37 +0000 (11:47 +0200)]
Rollup merge of #75580 - JulianKnodt:or_pattern, r=wesleywiser

Add test for checking duplicated branch or-patterns

This adds a regression test for checking `or-patterns` in MIR as shown in #75439.
This doesn't introduce a fix as I'm not sure where it would go(I suspect maybe here: src/librustc_mir_build/build/matches/mod.rs), and I'm not particularly able to fix it.

cc: @lzutao

3 years agoRollup merge of #75502 - ecstatic-morse:implicit-promotion-in-const-fn, r=RalfJung
Ralf Jung [Sat, 19 Sep 2020 09:47:35 +0000 (11:47 +0200)]
Rollup merge of #75502 - ecstatic-morse:implicit-promotion-in-const-fn, r=RalfJung

Use implicit (not explicit) rules for promotability by default in `const fn`

For crater run. See https://github.com/rust-lang/const-eval/pull/54#discussion_r469995552.

cc #75586

3 years agoRollup merge of #75099 - davidtwco:is-zst-abstraction-violation, r=eddyb
Ralf Jung [Sat, 19 Sep 2020 09:47:34 +0000 (11:47 +0200)]
Rollup merge of #75099 - davidtwco:is-zst-abstraction-violation, r=eddyb

lint/ty: move fns to avoid abstraction violation

This PR moves `transparent_newtype_field` and `is_zst` to `LateContext` where they are used, rather than being on the `VariantDef` and `TyS` types, hopefully addressing @eddyb's concern [from this comment](https://github.com/rust-lang/rust/pull/74340#discussion_r456534910).

3 years agoRollup merge of #73963 - hellow554:unsafe_path, r=Mark-Simulacrum
Ralf Jung [Sat, 19 Sep 2020 09:47:31 +0000 (11:47 +0200)]
Rollup merge of #73963 - hellow554:unsafe_path, r=Mark-Simulacrum

deny(unsafe_op_in_unsafe_fn) in libstd/path.rs

The libstd/path.rs part of #73904 . Wraps the two calls to an unsafe fn Initializer::nop() in an unsafe block.

3 years agoAuto merge of #76886 - Aaron1011:fix/ensure-stack-predicate, r=Mark-Simulacrum
bors [Sat, 19 Sep 2020 09:21:22 +0000 (09:21 +0000)]
Auto merge of #76886 - Aaron1011:fix/ensure-stack-predicate, r=Mark-Simulacrum

Wrap recursive predicate evaluation with `ensure_sufficient_stack`

I haven't been able to come up with a minimized test case for #76770,
but this fixes a stack overflow in rustc as well.

3 years agoAuto merge of #76879 - shepmaster:zlib-sys, r=Mark-Simulacrum
bors [Sat, 19 Sep 2020 06:28:37 +0000 (06:28 +0000)]
Auto merge of #76879 - shepmaster:zlib-sys, r=Mark-Simulacrum

Upgrade libz-sys to 1.1.2

The current version has warnings that become errors on new versions of clang shipped in XCode:

```
warning: src/zlib/gzlib.c:214:15: error: implicitly declaring library function 'snprintf' with type 'int (char *, unsigned long, const char *, ...)' [-Werror,-Wimplicit-function-declaration]
warning:         (void)snprintf(state->path, len + 1, "%s", (const char *)path);
warning:               ^
warning: src/zlib/gzlib.c:214:15: note: include the header <stdio.h> or explicitly provide a declaration for 'snprintf'
warning: 1 error generated.

warning: src/zlib/gzwrite.c:428:11: error: implicitly declaring library function 'vsnprintf' with type 'int (char *, unsigned long, const char *, __builtin_va_list)' [-Werror,-Wimplicit-function-declaration
warning:     len = vsnprintf(next, state->size, format, va);
warning:           ^
warning: src/zlib/gzwrite.c:428:11: note: include the header <stdio.h> or explicitly provide a declaration for 'vsnprintf'
warning: 1 error generated.
```

r? `@Mark-Simulacrum`

/cc `@joshtriplett`

3 years agoAdd tracking issue number for string_drain_as_str.
Mara Bos [Sat, 19 Sep 2020 06:23:23 +0000 (08:23 +0200)]
Add tracking issue number for string_drain_as_str.

3 years agoAdd tracking issue number for int_bits_const.
Mara Bos [Sat, 19 Sep 2020 06:14:41 +0000 (08:14 +0200)]
Add tracking issue number for int_bits_const.

3 years agoUse `T::BITS` instead of `size_of::<T> * 8`.
Mara Bos [Tue, 8 Sep 2020 19:39:13 +0000 (21:39 +0200)]
Use `T::BITS` instead of `size_of::<T> * 8`.

3 years agoAdd example/test to <int types>::BITS.
Mara Bos [Tue, 8 Sep 2020 18:24:55 +0000 (20:24 +0200)]
Add example/test to <int types>::BITS.

3 years agoAdd `BITS` associated constant to all integer types.
Mara Bos [Tue, 8 Sep 2020 18:17:23 +0000 (20:17 +0200)]
Add `BITS` associated constant to all integer types.

3 years agoAuto merge of #76856 - jonas-schievink:dist-rustc-src, r=Mark-Simulacrum
bors [Sat, 19 Sep 2020 04:21:11 +0000 (04:21 +0000)]
Auto merge of #76856 - jonas-schievink:dist-rustc-src, r=Mark-Simulacrum

Distribute rustc sources as part of `rustc-dev`

They can be used to provide IDE features when working on rustc plugins/backends/etc without having to locate a separate Rust checkout.

r? `@Mark-Simulacrum`

3 years agoAuto merge of #76838 - est31:dogfood_uninit_features, r=oli-obk
bors [Sat, 19 Sep 2020 02:21:19 +0000 (02:21 +0000)]
Auto merge of #76838 - est31:dogfood_uninit_features, r=oli-obk

Dogfood new_uninit and maybe_uninit_slice in rustc_arena

Dogfoods a few cool `MaybeUninit` related features in the compiler's rustc_arena crate.

Split off from #76821

r? `@oli-obk`

3 years agoAuto merge of #76787 - lzutao:slice_iters_new, r=lcnr
bors [Fri, 18 Sep 2020 23:38:17 +0000 (23:38 +0000)]
Auto merge of #76787 - lzutao:slice_iters_new, r=lcnr

Using <Iter>::new instead of exposing internal fields

As requested in https://github.com/rust-lang/rust/pull/76311#discussion_r487685126

3 years agoAuto merge of #76782 - lzutao:rd-cap, r=jyn514
bors [Fri, 18 Sep 2020 21:31:08 +0000 (21:31 +0000)]
Auto merge of #76782 - lzutao:rd-cap, r=jyn514

Specialize merge_attrs in good case

Just a non-important micro-optimization.
r? `@jyn514`

3 years agoAuto merge of #76884 - Mark-Simulacrum:fix-macos-ci, r=pietroalbini
bors [Fri, 18 Sep 2020 19:13:02 +0000 (19:13 +0000)]
Auto merge of #76884 - Mark-Simulacrum:fix-macos-ci, r=pietroalbini

Add host triples to target lists

This PR is primarily intended to fix https://github.com/rust-lang/rustup/issues/2494, which is the second commit. That bug was introduced by #76415, and incompletely fixed by #76639. (#76639 added host triples, which gave us compilers, but missed that we also need documentation and other target-only things). However, it also removes duplicate macOS CI builders.

r? `@pietroalbini`

3 years agoAuto merge of #76575 - lcnr:abstract-const, r=oli-obk
bors [Fri, 18 Sep 2020 16:59:50 +0000 (16:59 +0000)]
Auto merge of #76575 - lcnr:abstract-const, r=oli-obk

compare generic constants using `AbstractConst`s

This is a MVP of rust-lang/compiler-team#340. The changes in this PR should only be relevant if `feature(const_evaluatable_checked)` is enabled.

~~currently based on top of #76559, so blocked on that.~~

r? `@oli-obk` cc `@varkor` `@eddyb`

3 years agoWrap recursive predicate evaluation with `ensure_sufficient_stack`
Aaron Hill [Fri, 18 Sep 2020 15:09:00 +0000 (11:09 -0400)]
Wrap recursive predicate evaluation with `ensure_sufficient_stack`

I haven't been able to come up with a minimized test case for #76770,
but this fixes a stack overflow in rustc as well.

3 years agoMake sure we build target-only things (e.g., docs) for host platforms too
Mark Rousskov [Fri, 18 Sep 2020 15:56:41 +0000 (11:56 -0400)]
Make sure we build target-only things (e.g., docs) for host platforms too

3 years agoRemove duplicate macOS builders
Mark Rousskov [Fri, 18 Sep 2020 15:54:00 +0000 (11:54 -0400)]
Remove duplicate macOS builders

3 years agoadd `const-evaluatable_checked` check back in
Bastian Kauschke [Fri, 18 Sep 2020 15:36:11 +0000 (17:36 +0200)]
add `const-evaluatable_checked` check back in

3 years agoreview, small cleanup
Bastian Kauschke [Fri, 18 Sep 2020 15:11:17 +0000 (17:11 +0200)]
review, small cleanup

3 years agodocument `const_evaluatable`
Bastian Kauschke [Fri, 11 Sep 2020 19:50:17 +0000 (21:50 +0200)]
document `const_evaluatable`

3 years agoremove allow(warnings)
Bastian Kauschke [Fri, 11 Sep 2020 19:19:15 +0000 (21:19 +0200)]
remove allow(warnings)

3 years agosupport const_evaluatable_checked across crate boundaries
Bastian Kauschke [Fri, 11 Sep 2020 19:16:16 +0000 (21:16 +0200)]
support const_evaluatable_checked across crate boundaries

3 years agoadd test for let-bindings
Bastian Kauschke [Fri, 11 Sep 2020 08:46:35 +0000 (10:46 +0200)]
add test for let-bindings

3 years agoadd function calls
Bastian Kauschke [Fri, 11 Sep 2020 08:35:28 +0000 (10:35 +0200)]
add function calls

3 years agoallow unary operations and ignore StorageLive/Dead stmts
Bastian Kauschke [Fri, 11 Sep 2020 08:00:06 +0000 (10:00 +0200)]
allow unary operations and ignore StorageLive/Dead stmts

3 years agouse newtype_index for abstract_const::NodeId
Bastian Kauschke [Fri, 11 Sep 2020 07:18:54 +0000 (09:18 +0200)]
use newtype_index for abstract_const::NodeId

3 years agorefactor AbstractConstBuilder
Bastian Kauschke [Fri, 11 Sep 2020 07:00:21 +0000 (09:00 +0200)]
refactor AbstractConstBuilder

3 years agouse abstract consts when unifying ConstKind::Unevaluated
Bastian Kauschke [Thu, 10 Sep 2020 16:48:18 +0000 (18:48 +0200)]
use abstract consts when unifying ConstKind::Unevaluated

3 years agoinitial working state
Bastian Kauschke [Thu, 10 Sep 2020 07:06:30 +0000 (09:06 +0200)]
initial working state

3 years agoAuto merge of #72412 - VFLashM:issue-72408-nested-closures-exponential, r=tmandry
bors [Fri, 18 Sep 2020 14:08:39 +0000 (14:08 +0000)]
Auto merge of #72412 - VFLashM:issue-72408-nested-closures-exponential, r=tmandry

Issue 72408 nested closures exponential

This fixes #72408.

Nested closures were resulting in exponential compilation time.

This PR is enhancing asymptotic complexity, but also increasing the constant, so I would love to see perf run results.

3 years agoUpdate cc crate to understand aarch64-apple-darwin with clang
Jake Goulding [Wed, 16 Sep 2020 17:09:25 +0000 (13:09 -0400)]
Update cc crate to understand aarch64-apple-darwin with clang

3 years agoUpgrade libz-sys to 1.1.2
Jake Goulding [Fri, 18 Sep 2020 00:14:09 +0000 (20:14 -0400)]
Upgrade libz-sys to 1.1.2

3 years agoAuto merge of #76837 - wesleywiser:disable_consideredequal, r=oli-obk
bors [Fri, 18 Sep 2020 10:54:14 +0000 (10:54 +0000)]
Auto merge of #76837 - wesleywiser:disable_consideredequal, r=oli-obk

[mir-opt] Disable the `ConsideredEqual` logic in SimplifyBranchSame opt

The logic is currently broken and we need to disable it to fix a beta
regression (see #76803)

r? `@oli-obk`

3 years agoRemove redundancy in cache key
Tyler Mandry [Fri, 18 Sep 2020 06:07:19 +0000 (06:07 +0000)]
Remove redundancy in cache key

3 years agoinline inner function of inlining methods
Lzu Tao [Thu, 17 Sep 2020 09:23:14 +0000 (09:23 +0000)]
inline inner function of inlining methods

3 years agoMove unsafe code of slice `new` function of their Iterator structs
Lzu Tao [Thu, 17 Sep 2020 09:14:28 +0000 (09:14 +0000)]
Move unsafe code of slice `new` function of their Iterator structs

Init false state in Split* constructors

3 years agoAuto merge of #76854 - aDotInTheVoid:mir-opt-32-64-diff-name, r=oli-obk
bors [Fri, 18 Sep 2020 08:28:03 +0000 (08:28 +0000)]
Auto merge of #76854 - aDotInTheVoid:mir-opt-32-64-diff-name, r=oli-obk

Rename mir-opt diff tests with 32/64 bit

Now syntax highlighting should work.

I've tested that `--bless` works localy, but I'm not sure it's possible on CI

Fixes #75746

r? `@oli-obk`

3 years agoAuto merge of #76790 - ssomers:btree_slice_slasher_returns, r=Mark-Simulacrum
bors [Fri, 18 Sep 2020 05:47:00 +0000 (05:47 +0000)]
Auto merge of #76790 - ssomers:btree_slice_slasher_returns, r=Mark-Simulacrum

BTreeMap: avoid slices even more

Epilogue to #73971: it seems the compiler is unable to realize that creating a slice and `get_unchecked`-ing one element is a simple fetch. So try to spell it out for the only remaining but often invoked case.

Also, the previous code doesn't seem fair game to me, using `get_unchecked` to reach beyond the end of a slice. Although the local function `slice_insert` also does that.

r? `@Mark-Simulacrum`

3 years agoAdd bench_typed_arena_clear_100 bench
est31 [Fri, 18 Sep 2020 03:52:45 +0000 (05:52 +0200)]
Add bench_typed_arena_clear_100 bench

3 years agoReplace loop with drop_in_place call
est31 [Thu, 17 Sep 2020 15:20:22 +0000 (17:20 +0200)]
Replace loop with drop_in_place call

3 years agoDogfood new_uninit and maybe_uninit_slice in rustc_arena
est31 [Thu, 17 Sep 2020 14:40:02 +0000 (16:40 +0200)]
Dogfood new_uninit and maybe_uninit_slice in rustc_arena

3 years agoCalculate more correct capacity in merge_attrs
Lzu Tao [Fri, 18 Sep 2020 01:55:40 +0000 (01:55 +0000)]
Calculate more correct capacity in merge_attrs

Co-authored-by: jyn514 <joshua@yottadb.com>
3 years agoIntorduced MiniMap - a tiny small storage optimized map implementation
Valerii Lashmanov [Fri, 18 Sep 2020 01:43:29 +0000 (20:43 -0500)]
Intorduced MiniMap - a tiny small storage optimized map implementation

This makes everything about 1% faster in rustc-perf,
mostly negating performance hit of previous commit.

3 years agoBetter handling for exponential-sized types in misc places
Valerii Lashmanov [Tue, 15 Sep 2020 23:22:24 +0000 (18:22 -0500)]
Better handling for exponential-sized types in misc places

Mostly to fix ui/issues/issue-37311-type-length-limit/issue-37311.rs.

Most parts of the compiler can handle deeply nested types with a lot
of duplicates just fine, but some parts still attempt to naively
traverse type tree.

Before such problems were caught by type length limit check,
but now these places will have to be changed to handle
duplicated types gracefully.

3 years agoOnly visit types once when walking the type tree
Valerii Lashmanov [Tue, 15 Sep 2020 14:37:19 +0000 (09:37 -0500)]
Only visit types once when walking the type tree

This fixes #72408.

Nested closures were resulting in exponential compilation time.

As a performance optimization this change introduces MiniSet,
which is a simple small storage optimized set.

3 years agoFix --bless for mir-opt 32/64 bit file
Nixon Enraght-Moony [Thu, 17 Sep 2020 21:25:33 +0000 (22:25 +0100)]
Fix --bless for mir-opt 32/64 bit file

3 years agoDistribute rustc sources as part of `rustc-dev`
Jonas Schievink [Thu, 17 Sep 2020 22:18:19 +0000 (00:18 +0200)]
Distribute rustc sources as part of `rustc-dev`

3 years agoRename 32 bit mir files to be more tool friendly
Nixon Enraght-Moony [Thu, 17 Sep 2020 20:49:21 +0000 (21:49 +0100)]
Rename 32 bit mir files to be more tool friendly

See #75746

3 years agoRename 64 bit mir files to be more tool friendly
Nixon Enraght-Moony [Thu, 17 Sep 2020 20:35:21 +0000 (21:35 +0100)]
Rename 64 bit mir files to be more tool friendly

See #75746

3 years agoPut bit qualifier before mir/diff
Nixon Enraght-Moony [Thu, 17 Sep 2020 20:32:02 +0000 (21:32 +0100)]
Put bit qualifier before mir/diff

3 years agoAuto merge of #76645 - fusion-engineering-forks:windows-lock, r=kennytm
bors [Thu, 17 Sep 2020 19:23:58 +0000 (19:23 +0000)]
Auto merge of #76645 - fusion-engineering-forks:windows-lock, r=kennytm

 Small cleanups in Windows Mutex.

 - Move `held` into the boxed part, since the SRW lock implementation does not use this. This makes the Mutex 50% smaller.
 - Use `Cell` instead of `UnsafeCell` for `held`, such that `.replace()` can be used.
 - Add some comments.
 - Avoid creating multiple `&mut`s to the critical section object in `ReentrantMutex`.

3 years agoDefault to implicit (not explicit) rules for promotability in `const fn`
Dylan MacKenzie [Tue, 1 Sep 2020 19:28:55 +0000 (12:28 -0700)]
Default to implicit (not explicit) rules for promotability in `const fn`

3 years agolibrary/unwind: Add missing )
Alistair Francis [Thu, 17 Sep 2020 14:10:10 +0000 (07:10 -0700)]
library/unwind: Add missing )

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
3 years ago[mir-opt] Disable the `ConsideredEqual` logic in SimplifyBranchSame opt
Wesley Wiser [Thu, 17 Sep 2020 13:29:39 +0000 (09:29 -0400)]
[mir-opt] Disable the `ConsideredEqual` logic in SimplifyBranchSame opt

The logic is currently broken and we need to disable it to fix a beta
regression (see #76803)

3 years agoAuto merge of #76634 - RalfJung:miri-guaranteed-eq-ne, r=oli-obk
bors [Thu, 17 Sep 2020 12:15:57 +0000 (12:15 +0000)]
Auto merge of #76634 - RalfJung:miri-guaranteed-eq-ne, r=oli-obk

move guaranteed{ne,eq} implementation to compile-time machine

Currently, Miri needs a special hack to avoid using the core engine implementation of these intrinsics. That seems silly, so let's move them to the CTFE machine, which is the only machine that wants to use them.

I also added a reference to https://github.com/rust-lang/rust/issues/73722 as a warning to anyone who wants to adjust `guaranteed_eq`.

3 years agoUsing <Iter>::new instead of exposing internal fields
Lzu Tao [Wed, 16 Sep 2020 09:42:05 +0000 (09:42 +0000)]
Using <Iter>::new instead of exposing internal fields

3 years agoAuto merge of #76028 - aticu:improve_e0118, r=estebank,jyn514,GuillaumeGomez
bors [Thu, 17 Sep 2020 03:56:38 +0000 (03:56 +0000)]
Auto merge of #76028 - aticu:improve_e0118, r=estebank,jyn514,GuillaumeGomez

Improve E0118

- Changes the "base type" terminology to "nominal type" (according to the [reference](https://doc.rust-lang.org/stable/reference/items/implementations.html#inherent-implementations)).
- Suggests removing a reference, if one is present on the type.
- Clarify what is meant by a "nominal type".

closes #69392

This is my first not-entirely-trivial PR, so please let me know if I missed anything or if something could be improved. Though I probably won't be able to fix anything in the upcoming week.

3 years agodon't lazily evaulate some trivial values for Option::None replacements (clippy:...
Matthias Krüger [Tue, 15 Sep 2020 21:10:24 +0000 (23:10 +0200)]
don't lazily evaulate some trivial values for Option::None replacements (clippy::unnecessary_lazy_evaluations)

3 years agolibrary/unwind: Consolidate RV32 and RV64
Alistair Francis [Wed, 16 Sep 2020 22:19:13 +0000 (15:19 -0700)]
library/unwind: Consolidate RV32 and RV64

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
3 years agolibrary/panic_unwind: Consolidate RV32 and RV64
Alistair Francis [Wed, 16 Sep 2020 21:31:42 +0000 (14:31 -0700)]
library/panic_unwind: Consolidate RV32 and RV64

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
3 years agoAuto merge of #76804 - tmandry:rollup-nwntt3q, r=tmandry
bors [Wed, 16 Sep 2020 20:18:19 +0000 (20:18 +0000)]
Auto merge of #76804 - tmandry:rollup-nwntt3q, r=tmandry

Rollup of 16 pull requests

Successful merges:

 - #75026 (Add array_windows fn)
 - #76642 (Do not lint ignored private doc tests)
 - #76719 (Change error message for ty param in const)
 - #76721 (Use intra-doc links in `core::mem`)
 - #76728 (Add a comment why `extern crate` is necessary for rustdoc)
 - #76735 (Remove unnecessary `clone()`s in bootstrap)
 - #76741 (Avoid printing dry run timings)
 - #76747 (Add missing code examples in libcore)
 - #76756 (fix a couple of stylistic clippy warnings)
 - #76758 ([fuchsia] Propagate the userspace UTC clock)
 - #76759 (Fix stabilization marker for future_readiness_fns)
 - #76760 (don't lazily evaluate some trivial values for Option::None replacements (clippy::unnecessary_lazy_evaluations))
 - #76764 (Update books)
 - #76775 (Strip a single leading tab when rendering dataflow diffs)
 - #76778 (Simplify iter fuse struct doc)
 - #76794 (Make graphviz font configurable)

Failed merges:

r? `@ghost`

3 years agocomments and factor to own method
Gus Wynn [Wed, 16 Sep 2020 19:32:10 +0000 (12:32 -0700)]
comments and factor to own method

3 years agoRollup merge of #76794 - richkadel:graphviz-font, r=ecstatic-morse
Tyler Mandry [Wed, 16 Sep 2020 19:24:30 +0000 (12:24 -0700)]
Rollup merge of #76794 - richkadel:graphviz-font, r=ecstatic-morse

Make graphviz font configurable

Alternative to PR #76776.

To change the graphviz output to use an alternative `fontname` value,
add a command line option like: `rustc --graphviz-font=monospace`.

r? @ecstatic-morse

3 years agoRollup merge of #76778 - pickfire:patch-7, r=jonas-schievink
Tyler Mandry [Wed, 16 Sep 2020 19:24:28 +0000 (12:24 -0700)]
Rollup merge of #76778 - pickfire:patch-7, r=jonas-schievink

Simplify iter fuse struct doc

3 years agoRollup merge of #76775 - ecstatic-morse:dataflow-extra-tab-diff, r=Mark-Simulacrum
Tyler Mandry [Wed, 16 Sep 2020 19:24:27 +0000 (12:24 -0700)]
Rollup merge of #76775 - ecstatic-morse:dataflow-extra-tab-diff, r=Mark-Simulacrum

Strip a single leading tab when rendering dataflow diffs

The `fmt_diff_with` formatter uses a tab to separate additions from subtractions. Strip it when rendering those diffs on separate lines.

r? @Mark-Simulacrum (since you're speedy)

3 years agoRollup merge of #76764 - ehuss:update-books, r=ehuss
Tyler Mandry [Wed, 16 Sep 2020 19:24:25 +0000 (12:24 -0700)]
Rollup merge of #76764 - ehuss:update-books, r=ehuss

Update books

## nomicon

1 commits in 25854752549d44d76fbd7650e17cb4f167a0b8fb..6e57e64501f61873ab80cb78a07180a22751a5d6
2020-08-19 16:41:48 -0400 to 2020-09-14 11:40:23 -0400
- Fix API change to alloc::Global::grow. (rust-lang-nursery/nomicon#236)

## reference

3 commits in 25391dba46262f882fa846beefaff54a966a8fa5..56a13c082ee90736c08d6abdcd90462517b703d3
2020-09-02 07:22:55 -0700 to 2020-09-14 23:20:16 -0700
- Update the description of staticlib (rust-lang-nursery/reference#884)
- Rust 1.46 now allows more features in const fn (rust-lang-nursery/reference#883)
- Document the enum changes in RFC 2195 (rust-lang-nursery/reference#879)

## book

1 commits in e5ed97128302d5fa45dbac0e64426bc7649a558c..cb28dee95e5e50b793e6ba9291c5d1568d3ad72e
2020-08-31 12:53:40 -0500 to 2020-09-09 10:06:00 -0500
- Fixed the error message of invalid array element access in ch03.2 (rust-lang/book#2446)

3 years agoRollup merge of #76760 - matthiaskrgr:clippy_lazy_eval, r=varkor
Tyler Mandry [Wed, 16 Sep 2020 19:24:23 +0000 (12:24 -0700)]
Rollup merge of #76760 - matthiaskrgr:clippy_lazy_eval, r=varkor

don't lazily evaluate some trivial values for Option::None replacements (clippy::unnecessary_lazy_evaluations)

3 years agoRollup merge of #76759 - yoshuawuyts:fix-future-pending-ready-stabilization-label...
Tyler Mandry [Wed, 16 Sep 2020 19:24:21 +0000 (12:24 -0700)]
Rollup merge of #76759 - yoshuawuyts:fix-future-pending-ready-stabilization-label, r=Dylan-DPC

Fix stabilization marker for future_readiness_fns

Updated the rustc version in which this will be stabilized from `1.47.0 -> 1.48.0`. Fixes https://github.com/rust-lang/rust/pull/74328#issuecomment-692133125. Ref #70921.

r? @Dylan-DPC

3 years agoRollup merge of #76758 - adamlesinski:clone_clock, r=tmandry
Tyler Mandry [Wed, 16 Sep 2020 19:24:19 +0000 (12:24 -0700)]
Rollup merge of #76758 - adamlesinski:clone_clock, r=tmandry

[fuchsia] Propagate the userspace UTC clock

On Fuchsia, spawning a subprocess does not automatically
clone all of the parent process' capabilities. UTC time on
Fuchsia is managed by a top-level userspace clock capability
that is cloned and passed to subprocesses.

This change ensures that any Rust subprocess gets access to the
UTC clock, if the parent had access to it. This is critical for
tests, which on Fuchsia, use panic=abort and spawn subprocesses
per test.

3 years agoRollup merge of #76756 - matthiaskrgr:cl123ppy, r=Dylan-DPC
Tyler Mandry [Wed, 16 Sep 2020 19:24:17 +0000 (12:24 -0700)]
Rollup merge of #76756 - matthiaskrgr:cl123ppy, r=Dylan-DPC

fix a couple of stylistic clippy warnings

namely:

clippy::redundant_pattern_matching
clippy::redundant_pattern
clippy::search_is_some
clippy::filter_next
clippy::into_iter_on_ref
clippy::clone_on_copy
clippy::needless_return

3 years agoRollup merge of #76747 - GuillaumeGomez:more-missing-libcore-code-examples, r=Mark...
Tyler Mandry [Wed, 16 Sep 2020 19:24:16 +0000 (12:24 -0700)]
Rollup merge of #76747 - GuillaumeGomez:more-missing-libcore-code-examples, r=Mark-Simulacrum

Add missing code examples in libcore

3 years agoRollup merge of #76741 - Mark-Simulacrum:no-dry-run-timing, r=alexcrichton
Tyler Mandry [Wed, 16 Sep 2020 19:24:14 +0000 (12:24 -0700)]
Rollup merge of #76741 - Mark-Simulacrum:no-dry-run-timing, r=alexcrichton

Avoid printing dry run timings

This avoids a wall of text on CI with 0.000 as the likely time.

r? @alexcrichton

3 years agoRollup merge of #76735 - jyn514:no-clone, r=Mark-Simulacrum
Tyler Mandry [Wed, 16 Sep 2020 19:24:12 +0000 (12:24 -0700)]
Rollup merge of #76735 - jyn514:no-clone, r=Mark-Simulacrum

Remove unnecessary `clone()`s in bootstrap

The performance difference is negligible, but it makes me feel better.

r? @Mark-Simulacrum

3 years agoRollup merge of #76728 - jyn514:rustdoc-extern-crate, r=ehuss
Tyler Mandry [Wed, 16 Sep 2020 19:24:10 +0000 (12:24 -0700)]
Rollup merge of #76728 - jyn514:rustdoc-extern-crate, r=ehuss

Add a comment why `extern crate` is necessary for rustdoc

r? @ehuss

From https://github.com/rust-lang/rust/pull/74293#discussion_r488335500.

3 years agoRollup merge of #76721 - camelid:intra-doc-links-for-core-mem, r=jyn514
Tyler Mandry [Wed, 16 Sep 2020 19:24:08 +0000 (12:24 -0700)]
Rollup merge of #76721 - camelid:intra-doc-links-for-core-mem, r=jyn514

Use intra-doc links in `core::mem`

Part of #75080.

Last one for now!

---

@rustbot modify labels: A-intra-doc-links T-doc

3 years agoRollup merge of #76719 - hameerabbasi:min-const-generics-ty, r=lcnr
Tyler Mandry [Wed, 16 Sep 2020 19:24:06 +0000 (12:24 -0700)]
Rollup merge of #76719 - hameerabbasi:min-const-generics-ty, r=lcnr

Change error message for ty param in const

This PR introduces the following changes:

* Change error message for type param in a const expression when using
`min_const_generics`
* Change `ParamInNonTrivialAnonConst` to contain an extra `bool` used for
distinguishing whether the passed-in symbol is a type or a value.

Fixes #76701