]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Mon, 1 Mar 2021 14:50:58 +0000 (14:50 +0000)]
Merge #7778
7778: Fix lowering trailing self paths in UseTrees r=Veykril a=Veykril
Noticed that hovering over `self` in a use tree like `use foo::bar::{self}` showing documentation and such for the current module instead of `bar`.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Mon, 1 Mar 2021 13:29:54 +0000 (13:29 +0000)]
Merge #7826
7826: Introduce Ty::Alias r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 1 Mar 2021 13:24:00 +0000 (14:24 +0100)]
Introduce Ty::Alias
bors[bot] [Mon, 1 Mar 2021 12:57:26 +0000 (12:57 +0000)]
Merge #7823
7823: Being Ty::InferenceVar closer to chalk equivalent r=flodiebold a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 1 Mar 2021 12:54:17 +0000 (13:54 +0100)]
Assert index relationship between type_variable_table and var_unification_table
Lukas Wirth [Mon, 1 Mar 2021 11:35:11 +0000 (12:35 +0100)]
Being Ty::InferenceVar closes to chalk equivalent
bors[bot] [Mon, 1 Mar 2021 11:29:47 +0000 (11:29 +0000)]
Merge #7822
7822: Paperover a bug in cargo-workspace for publish RA r=lnicola a=edwin0cheng
r? @lnicola
See also https://github.com/pksunkara/cargo-workspaces/issues/39
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Edwin Cheng [Mon, 1 Mar 2021 11:23:45 +0000 (19:23 +0800)]
Paperover a bug in cargo-workspace for publish RA
bors[bot] [Mon, 1 Mar 2021 11:15:19 +0000 (11:15 +0000)]
Merge #7819 #7820
7819: Speedup heavy tests r=matklad a=matklad
bors r+
🤖
7820: Update vscode README with a small features list r=matklad a=Veykril
Nothing grande but I figured this is a bit better than showing almost nothing
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 1 Mar 2021 10:07:15 +0000 (11:07 +0100)]
Update vscode README with a small features list
Aleksey Kladov [Mon, 1 Mar 2021 09:14:16 +0000 (12:14 +0300)]
Speedup heavy tests
We used to skip sysroot, but this logic got bitrotted, reinstalling.
bors[bot] [Mon, 1 Mar 2021 08:55:03 +0000 (08:55 +0000)]
Merge #7818
7818: Clean up warnings r=matklad a=bugadani
Co-authored-by: Dániel Buga <bugadani@gmail.com>
Dániel Buga [Mon, 1 Mar 2021 08:12:42 +0000 (09:12 +0100)]
Clean up unused field warning
Dániel Buga [Mon, 1 Mar 2021 08:05:14 +0000 (09:05 +0100)]
Remove redundant semicolon
bors[bot] [Sun, 28 Feb 2021 22:54:07 +0000 (22:54 +0000)]
Merge #7816
7816: Lift Ty::Fn into a struct r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 28 Feb 2021 21:12:07 +0000 (22:12 +0100)]
Lift FnPointer into a struct
Lukas Wirth [Wed, 24 Feb 2021 22:37:08 +0000 (23:37 +0100)]
Fix lowering trailing self paths in UseTrees
bors[bot] [Sun, 28 Feb 2021 22:24:21 +0000 (22:24 +0000)]
Merge #7815
7815: hir_ty: use default type generic for box expressions r=cynecx a=cynecx
r? @flodiebold
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/6837 according to https://github.com/rust-analyzer/rust-analyzer/issues/6837#issuecomment-
787456488 .
Co-authored-by: cynecx <me@cynecx.net>
cynecx [Sun, 28 Feb 2021 20:15:26 +0000 (21:15 +0100)]
hir_ty: use default type generic for box expressions
bors[bot] [Sun, 28 Feb 2021 19:56:16 +0000 (19:56 +0000)]
Merge #7814
7814: Turn Ty::Tuple variant into a tuple-variant r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 28 Feb 2021 19:44:09 +0000 (20:44 +0100)]
Remove Substs from Ty::ForeignType
Lukas Wirth [Sun, 28 Feb 2021 19:39:43 +0000 (20:39 +0100)]
Turn Ty::Tuple variant into a tuple-variant
bors[bot] [Sun, 28 Feb 2021 19:16:51 +0000 (19:16 +0000)]
Merge #7813
7813: Inline TypeCtor into Ty r=flodiebold a=Veykril
This removes the `ApplicationTy` variant from `Ty` bringing the representation a lot closer to chalk's `TyKind`.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 28 Feb 2021 18:46:59 +0000 (19:46 +0100)]
Fix code_model::Type::walk not walking all types
bors[bot] [Sun, 28 Feb 2021 18:14:53 +0000 (18:14 +0000)]
Merge #7812
7812: Use consistent naming for assist r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 28 Feb 2021 18:11:41 +0000 (21:11 +0300)]
Use consistent naming for assist
Lukas Wirth [Sun, 28 Feb 2021 18:13:37 +0000 (19:13 +0100)]
Inline TypeCtor into Ty
Aleksey Kladov [Sun, 28 Feb 2021 18:08:51 +0000 (21:08 +0300)]
Don't spam loop-rewriting assist
The more focused the assist, the better!
bors[bot] [Sun, 28 Feb 2021 15:15:58 +0000 (15:15 +0000)]
Merge #7809
7809: Delete old issues from GitHub's bug report template r=lnicola a=saruman9
Co-authored-by: saruman9 <rum.274.4@gmail.com>
saruman9 [Sun, 28 Feb 2021 15:12:43 +0000 (18:12 +0300)]
Delete old issues from GitHub's bug report template
bors[bot] [Sun, 28 Feb 2021 13:36:44 +0000 (13:36 +0000)]
Merge #7804
7804: Introduce TypeCtor::Scalar r=lnicola a=Veykril
`TypeCtor::Int(..) | TypeCtor::Float(..) | TypeCtor::Char | TypeCtor::Bool` => `TypeCtor::Scalar(..)`, in this case we can actually just straight up use `chalk_ir::Scalar` already since its just a POD without any IDs or anything.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Sun, 28 Feb 2021 12:53:21 +0000 (12:53 +0000)]
Merge #7808
7808: Fix assert split exprs on comma r=edwin0cheng a=edwin0cheng
bors r+
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Edwin Cheng [Sun, 28 Feb 2021 12:46:24 +0000 (20:46 +0800)]
Fix assert split exprs on comma
bors[bot] [Sun, 28 Feb 2021 12:40:28 +0000 (12:40 +0000)]
Merge #7807
7807: Directly link changelog from quick-links section in 'README.md' file r=matklad a=regexident
Co-authored-by: Vincent Esche <regexident@gmail.com>
Vincent Esche [Sun, 28 Feb 2021 12:19:32 +0000 (13:19 +0100)]
Directly link changelog from quick-links section in 'README.md' file
bors[bot] [Sun, 28 Feb 2021 12:00:14 +0000 (12:00 +0000)]
Merge #7806
7806: Fixed remaining references to `AnalysisChange` (now: `Change`) r=matklad a=regexident
(The type was renamed/moved in
8716c4cec3a05ba891b20b5f28df69d925b913ad )
Co-authored-by: Vincent Esche <regexident@gmail.com>
Vincent Esche [Sun, 28 Feb 2021 11:57:41 +0000 (12:57 +0100)]
Fixed remaining references to `AnalysisChange` (now: `Change`)
(The type was renamed/moved in
8716c4cec3a05ba891b20b5f28df69d925b913ad )
bors[bot] [Sun, 28 Feb 2021 11:29:44 +0000 (11:29 +0000)]
Merge #7805
7805: For unresolved macros, hightlight only the last segment r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 28 Feb 2021 11:12:11 +0000 (14:12 +0300)]
For unresolved macros, hightlight only the last segment
Lukas Wirth [Sun, 28 Feb 2021 09:58:34 +0000 (10:58 +0100)]
Use chalk_ir::Scalar directly
bors[bot] [Sun, 28 Feb 2021 05:55:06 +0000 (05:55 +0000)]
Merge #7803
7803: Fix non-latin characters doc comment in mbe expansion r=edwin0cheng a=edwin0cheng
Fixes #7781
![Peek 2021-02-28 13-47](https://user-images.githubusercontent.com/
11014119 /
109409237 -
f58e5580 -79cb-11eb-92ed-
a6700bbe39b5 .gif)
Off-topic: This is a [beautiful poem](http://chinesepoetryinenglishverse.blogspot.com/2013/12/blog-post_4784.html) from by Li Shangyin.
bors r+
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Edwin Cheng [Sun, 28 Feb 2021 05:49:08 +0000 (13:49 +0800)]
Fix non-latin characters doc comment for mbe
bors[bot] [Sun, 28 Feb 2021 05:07:09 +0000 (05:07 +0000)]
Merge #7802
7802: Fix builtin macros split exprs on comma r=edwin0cheng a=edwin0cheng
Fixes #7640
bors r+
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Edwin Cheng [Sun, 28 Feb 2021 05:06:17 +0000 (13:06 +0800)]
Fix builtin macros split exprs on comma
bors[bot] [Sun, 28 Feb 2021 03:49:40 +0000 (03:49 +0000)]
Merge #7801
7801: Restrict visibilities to the containing DefMap r=jonas-schievink a=jonas-schievink
Visibilities must always point into the DefMap where they are used, but in a block expression `self` resolves to the *containing* non-block module, which is in a different DefMap. Restrict visibilities accordingly, turning them into basically `pub(block)`, which Rust has no syntax for.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Sun, 28 Feb 2021 03:39:38 +0000 (04:39 +0100)]
Restrict visibilities to the containing DefMap
Lukas Wirth [Sun, 28 Feb 2021 00:20:04 +0000 (01:20 +0100)]
Introduce TypeCtor::Scalar
bors[bot] [Sat, 27 Feb 2021 14:56:24 +0000 (14:56 +0000)]
Merge #7797
7797: Format generated lints and features manually r=matklad a=lnicola
As `quote` and `rustfmt` leave them on a single line, which makes running `grep` in the repository quite annoying.
Also removes a dead `gen_features.rs` file (`gen_lint_completions.rs` does the same thing).
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Sat, 27 Feb 2021 14:39:22 +0000 (14:39 +0000)]
Merge #7566
7566: Add benchmark tests for mbe r=matklad a=edwin0cheng
This PR add more real world tests dumped from `rust-analyzer analysis-stats .` to benchmark its performance.
cc #7513
r? @matklad
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
bors[bot] [Sat, 27 Feb 2021 14:29:10 +0000 (14:29 +0000)]
Merge #7677
7677: More enum matching r=yoshuawuyts a=jDomantas
* Renamed existing `generate_enum_match_method` to `generate_enum_is_variant`
* Added two similar assists to generate `into_` and `as_` methods.
* Made all of them general enough to work on record and tuple variants too.
For `as_` method generation there's room to improve:
* Right now it always returns `Option<&Field>`, even though `Option<Field>` would be nicer when `Field: Copy`. I don't know how to check if the field type implements `Copy`. If given suggestions I could try to fix this in a follow-up pr.
* `&String` could be replaced with `&str`, `&Box<_>` with `&_`, and probably some more. I don't know what would be a good way to do that.
Closes #7604
Co-authored-by: Domantas Jadenkus <djadenkus@gmail.com>
Laurențiu Nicola [Sat, 27 Feb 2021 14:26:02 +0000 (16:26 +0200)]
Remove dead gen_features code
Laurențiu Nicola [Sat, 27 Feb 2021 14:25:06 +0000 (16:25 +0200)]
Format generated features manually instead of relying on rustfmt
Domantas Jadenkus [Tue, 16 Feb 2021 21:43:21 +0000 (23:43 +0200)]
generate try_into instead of into
Domantas Jadenkus [Mon, 15 Feb 2021 21:28:57 +0000 (23:28 +0200)]
rename generate_enum_match_method file to match assist name
Domantas Jadenkus [Mon, 15 Feb 2021 21:25:33 +0000 (23:25 +0200)]
move into_ and as_ generation to a separate file
Domantas Jadenkus [Sun, 14 Feb 2021 17:28:22 +0000 (19:28 +0200)]
cargo fmt
Domantas Jadenkus [Sun, 14 Feb 2021 17:26:37 +0000 (19:26 +0200)]
add generate_enum_as_method assist
Domantas Jadenkus [Sun, 14 Feb 2021 10:15:20 +0000 (12:15 +0200)]
deduplicate some
Domantas Jadenkus [Sun, 14 Feb 2021 10:06:42 +0000 (12:06 +0200)]
add generate_enum_into_method assist
Domantas Jadenkus [Sun, 14 Feb 2021 09:33:46 +0000 (11:33 +0200)]
make generate_enum_is_method work on any variants
Domantas Jadenkus [Sun, 14 Feb 2021 09:09:56 +0000 (11:09 +0200)]
rename existing assist to generate_enum_is_method
bors[bot] [Fri, 26 Feb 2021 18:10:07 +0000 (18:10 +0000)]
Merge #7794
7794: Disable "Flip comma" assist inside a macro call r=Veykril a=greenhat
Fix #7693
Disables "Flip comma" assist if called inside a macro call.
Co-authored-by: Denys Zadorozhnyi <denys@zadorozhnyi.com>
Denys Zadorozhnyi [Fri, 26 Feb 2021 17:12:53 +0000 (19:12 +0200)]
Disable "Flip comma" assist inside a macro call
bors[bot] [Fri, 26 Feb 2021 07:29:05 +0000 (07:29 +0000)]
Merge #7792
7792: docs(ide_assists): Change remaining occurrences of importMergeBehaviour to importMergeBehavior r=lnicola a=SanchithHegde
Co-authored-by: Sanchith Hegde <sanchith.hegde01@gmail.com>
Sanchith Hegde [Fri, 26 Feb 2021 07:08:12 +0000 (12:38 +0530)]
docs(ide_assists): Change importMergeBehaviour to importMergeBehavior
bors[bot] [Thu, 25 Feb 2021 15:35:37 +0000 (15:35 +0000)]
Merge #7786
7786: bump crates r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Thu, 25 Feb 2021 15:34:48 +0000 (10:34 -0500)]
bump crates
bors[bot] [Thu, 25 Feb 2021 14:56:29 +0000 (14:56 +0000)]
Merge #7785
7785: :arrow_up: crates r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Thu, 25 Feb 2021 14:55:50 +0000 (17:55 +0300)]
:arrow_up: crates
Edwin Cheng [Fri, 5 Feb 2021 11:57:32 +0000 (19:57 +0800)]
Add benchmark test for mbe
bors[bot] [Wed, 24 Feb 2021 19:24:22 +0000 (19:24 +0000)]
Merge #7741
7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall
Implements one direction of #7681
I wonder if this tries to guess too much at the right thing here. A common pattern is:
```rust
let col = vec![1, 2, 3];
for v in &mut col {
*v *= 2;
}
// equivalent to:
col.iter_mut().for_each(|v| *v *= 2);
```
I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind:
1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types)
2. Try to check if iter/iter_mut exists and they return the right iterator type
3. Don't try to do this and just add `.into_iter()` to whatever is after `in`
Co-authored-by: Matt Hall <matthew@quickbeam.me.uk>
Matt Hall [Wed, 24 Feb 2021 19:23:12 +0000 (19:23 +0000)]
Address further review comments
* Use known names for iter/iter_mut method (simplifies checking if the
method exists
* Extract code to check assist with fixtures to function
bors[bot] [Wed, 24 Feb 2021 12:19:22 +0000 (12:19 +0000)]
Merge #7719
7719: De Morgan's Law assist now correctly parenthesizes binary expressions. r=Veykril a=lbrande
Closes #7694 by parenthesizing binary expressions that are negated.
Co-authored-by: lbrande <lovbra00@gmail.com>
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Wed, 24 Feb 2021 11:03:39 +0000 (11:03 +0000)]
Merge #7775
7775: Fix typo. r=Veykril a=boxdot
Co-authored-by: boxdot <d@zerovolt.org>
Lukas Wirth [Wed, 24 Feb 2021 10:42:32 +0000 (11:42 +0100)]
Add tests for apply_demorgan
lbrande [Mon, 22 Feb 2021 15:23:42 +0000 (16:23 +0100)]
De Morgan's Law assist now correctly inverts <, <=, >, >=.
lbrande [Fri, 19 Feb 2021 13:48:07 +0000 (14:48 +0100)]
De Morgan's Law assist now correctly parenthesizes binary expressions.
boxdot [Wed, 24 Feb 2021 10:56:48 +0000 (11:56 +0100)]
Fix typo.
bors[bot] [Tue, 23 Feb 2021 22:32:47 +0000 (22:32 +0000)]
Merge #7772
7772: Pickup ConstReference patterns in FindUsages r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 23 Feb 2021 22:31:07 +0000 (23:31 +0100)]
Pickup ConstReference patterns in FindUsages
Matt Hall [Tue, 23 Feb 2021 19:19:48 +0000 (19:19 +0000)]
Address review comments
* Move code to build replacement into closure
* Look for iter/iter_mut methods on types behind reference
Matt Hall [Sun, 21 Feb 2021 17:36:37 +0000 (17:36 +0000)]
Add convert_for_to_iter_for_each assist
bors[bot] [Tue, 23 Feb 2021 18:02:40 +0000 (18:02 +0000)]
Merge #7770
7770: reliable memory usage during benchmarking r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Tue, 23 Feb 2021 18:02:17 +0000 (21:02 +0300)]
reliable memory usage during benchmarking
bors[bot] [Tue, 23 Feb 2021 17:18:58 +0000 (17:18 +0000)]
Merge #7769
7769: Update mio r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Tue, 23 Feb 2021 17:16:56 +0000 (12:16 -0500)]
Update mio
bors[bot] [Tue, 23 Feb 2021 17:06:57 +0000 (17:06 +0000)]
Merge #7768
7768: Fix visibility computation when inside a block expression r=jonas-schievink a=jonas-schievink
fixes https://github.com/rust-analyzer/rust-analyzer/issues/7728
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
bors[bot] [Tue, 23 Feb 2021 16:56:21 +0000 (16:56 +0000)]
Merge #7766
7766: Update our vscode npm packages r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
Jonas Schievink [Tue, 23 Feb 2021 16:56:16 +0000 (17:56 +0100)]
is_visible_from_def_map: handle block expressions
kjeremy [Tue, 23 Feb 2021 16:39:19 +0000 (11:39 -0500)]
Update our vscode npm packages
Jonas Schievink [Tue, 23 Feb 2021 13:54:01 +0000 (14:54 +0100)]
Add test
bors[bot] [Mon, 22 Feb 2021 20:28:17 +0000 (20:28 +0000)]
Merge #7759
7759: 7526: Rename ide related crates r=Veykril a=chetankhilosiya
renamed assists -> ide_assists and ssr -> ide_ssr.
the completion crate is already renamed.
Co-authored-by: Chetan Khilosiya <chetan.khilosiya@gmail.com>
Chetan Khilosiya [Mon, 22 Feb 2021 19:14:58 +0000 (00:44 +0530)]
7526: Renamed create ssr to ide_ssr.
Chetan Khilosiya [Mon, 22 Feb 2021 18:47:48 +0000 (00:17 +0530)]
7526: Rename crate assists to ide_assists.
bors[bot] [Mon, 22 Feb 2021 18:23:33 +0000 (18:23 +0000)]
Merge #7756
7756: update tracing-tree r=kjeremy a=kjeremy
Removes some dependencies
Co-authored-by: kjeremy <kjeremy@gmail.com>
kjeremy [Mon, 22 Feb 2021 17:25:02 +0000 (12:25 -0500)]
update tidy
kjeremy [Mon, 22 Feb 2021 17:03:34 +0000 (12:03 -0500)]
update tracing-tree
bors[bot] [Mon, 22 Feb 2021 13:54:53 +0000 (13:54 +0000)]
Merge #7753
7753: Add isize to the list of suffixed integers in typed_integer r=kjeremy a=jonasbb
The missing `isize` in `typed_integers` seems to just be an oversight.
Might fix: #7751
Co-authored-by: Jonas Bushart <jonas@bushart.org>
Jonas Bushart [Mon, 22 Feb 2021 13:33:42 +0000 (14:33 +0100)]
Add isize to the list of suffixed integers in typed_integer
The missing `isize` in `typed_integers` seems to just be an oversight.
Might fix: #7751
bors[bot] [Mon, 22 Feb 2021 13:32:40 +0000 (13:32 +0000)]
Merge #7752
7752: up once_cell r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>