]>
git.lizzy.rs Git - rust.git/log
Michael Wright [Sat, 29 Sep 2018 12:12:40 +0000 (14:12 +0200)]
Move unnecessary_filter_map to a submodule
Michael Wright [Sat, 29 Sep 2018 11:57:04 +0000 (13:57 +0200)]
Move tests into separate file
Michael Wright [Thu, 27 Sep 2018 04:29:48 +0000 (06:29 +0200)]
Fix warnings in clippy_lints
Michael Wright [Thu, 27 Sep 2018 04:12:01 +0000 (06:12 +0200)]
Merge branch 'master' into unnecessary_filter_map
Philipp Hansch [Wed, 26 Sep 2018 16:48:43 +0000 (17:48 +0100)]
Merge pull request #3226 from matthiaskrgr/rustup_smallvec
rustup
Philipp Hansch [Wed, 26 Sep 2018 16:47:51 +0000 (17:47 +0100)]
Merge pull request #3225 from matthiaskrgr/dogfood
tests: dogfood: extend to run with --all-features and clippy::internal enabled.
Matthias Krüger [Wed, 26 Sep 2018 13:57:38 +0000 (15:57 +0200)]
rustup
fix breakage by https://github.com/rust-lang/rust/pull/53824
use smallvec crate instead of rustcs type alias.
Matthias Krüger [Wed, 26 Sep 2018 10:32:20 +0000 (12:32 +0200)]
tests: dogfood: extend to run with --all-features and clippy::internal enabled.
Run it on rustc_tools_util and clippy_dev as well.
Michael Wright [Wed, 26 Sep 2018 04:52:36 +0000 (06:52 +0200)]
Implement unnecesary_filter_map lint
Manish Goregaokar [Tue, 25 Sep 2018 14:05:32 +0000 (07:05 -0700)]
Merge pull request #3218 from Hanaasagi/fix-travis-yaml-demo
fix invalid travis-yaml in README
Hanaasagi [Tue, 25 Sep 2018 13:40:17 +0000 (22:40 +0900)]
fix invalid travis-yaml in README
Philipp Krones [Tue, 25 Sep 2018 10:54:48 +0000 (12:54 +0200)]
Merge pull request #3203 from yaahallo/master
Lint for chaining flatten after map
Philipp Hansch [Tue, 25 Sep 2018 06:27:12 +0000 (07:27 +0100)]
Merge pull request #3212 from matthiaskrgr/clippy_dev_ed2018
clippy_dev: port to edition 2018
Jane Lusby [Fri, 21 Sep 2018 07:26:38 +0000 (00:26 -0700)]
Lint for chaining flatten after map
This change adds a lint to check for instances of `map(..).flatten()`
that can be trivially shortened to `flat_map(..)`
Closes #3196
mikerite [Mon, 24 Sep 2018 07:11:32 +0000 (09:11 +0200)]
Merge pull request #3213 from mikerite/fix-3204
Fix single_char_pattern crash (#3204)
Michael Wright [Sun, 23 Sep 2018 13:25:10 +0000 (15:25 +0200)]
Fix single_char_pattern crash (#3204)
This commit fixes the crash by removing constant checking from the lint.
Closes #3204.
Philipp Krones [Sun, 23 Sep 2018 16:24:27 +0000 (18:24 +0200)]
Merge pull request #3207 from mikerite/fix-3206
Fix double_parens false positive
Philipp Krones [Sun, 23 Sep 2018 13:45:55 +0000 (15:45 +0200)]
Merge pull request #3191 from vi/suggest_with_applicability
Use span_suggestion_with_applicability instead of span_suggestion
Matthias Krüger [Sun, 23 Sep 2018 12:44:06 +0000 (14:44 +0200)]
clippy_dev: port to edition 2018
Philipp Krones [Sun, 23 Sep 2018 08:23:48 +0000 (10:23 +0200)]
Merge pull request #3195 from JayKickliter/jsk/mem_replace_opt_w_none
Add lint for `mem::replace(.., None)`.
Manish Goregaokar [Sat, 22 Sep 2018 21:35:11 +0000 (14:35 -0700)]
Mention `rustup self update` (fixes #3211)
Michael Wright [Sat, 22 Sep 2018 15:20:34 +0000 (17:20 +0200)]
Fix double_parens false positive
Closes #3206
flip1995 [Thu, 20 Sep 2018 12:38:13 +0000 (14:38 +0200)]
Another Applicability adjustment
Vitaly _Vi Shukela [Tue, 18 Sep 2018 19:43:52 +0000 (22:43 +0300)]
Applicability adjustment per additional comments
Vitaly _Vi Shukela [Tue, 18 Sep 2018 17:01:17 +0000 (20:01 +0300)]
Fill in Applicability from review comments by @flip1995
Vitaly _Vi Shukela [Tue, 18 Sep 2018 15:07:54 +0000 (18:07 +0300)]
Fix indents
Vitaly _Vi Shukela [Sun, 16 Sep 2018 19:01:26 +0000 (22:01 +0300)]
Apply subset of "cargo fmt".
Vitaly _Vi Shukela [Sat, 15 Sep 2018 16:32:35 +0000 (19:32 +0300)]
Add forgotten function: span_suggestion*s* to the previous refactoting
Vitaly _Vi Shukela [Sat, 15 Sep 2018 16:28:51 +0000 (19:28 +0300)]
Supplement DiagnosticBuilderExt with Applicability
Vitaly _Vi Shukela [Sat, 15 Sep 2018 16:14:08 +0000 (19:14 +0300)]
Use span_suggestion_with_applicability instead of span_suggestion
Philipp Hansch [Thu, 20 Sep 2018 08:37:39 +0000 (09:37 +0100)]
Merge pull request #3201 from phansch/rust_master_in_contributing_docs
Mention how to install master Rust in CONTRIBUTING
Philipp Hansch [Thu, 20 Sep 2018 05:10:23 +0000 (07:10 +0200)]
Mention rustup component history
Philipp Hansch [Thu, 20 Sep 2018 04:58:07 +0000 (06:58 +0200)]
s/rustc/Rust/
Philipp Hansch [Thu, 20 Sep 2018 04:56:13 +0000 (06:56 +0200)]
s/rust/Rust, repeat 'Clippy' less
Jay Kickliter [Wed, 19 Sep 2018 21:54:38 +0000 (14:54 -0700)]
mem_replace: fix grammar.
Jay Kickliter [Tue, 18 Sep 2018 23:54:01 +0000 (16:54 -0700)]
mem_replace: match on path.
Jay Kickliter [Tue, 18 Sep 2018 17:28:58 +0000 (10:28 -0700)]
mem_replace: apply update_lints tool.
Jay Kickliter [Tue, 18 Sep 2018 17:21:49 +0000 (10:21 -0700)]
mem_replace: make examples compilable.
Jay Kickliter [Sun, 16 Sep 2018 23:25:33 +0000 (16:25 -0700)]
Add lint for `mem::replace(.., None)`.
Suggest `Option::take()` as an alternative.
Philipp Hansch [Wed, 19 Sep 2018 19:12:51 +0000 (21:12 +0200)]
Mention how to install master Rust in CONTRIBUTING
Philipp Hansch [Wed, 19 Sep 2018 18:44:23 +0000 (19:44 +0100)]
Merge pull request #3197 from mikerite/travis_lint_list
Make travis check lint list
Philipp Hansch [Wed, 19 Sep 2018 18:43:48 +0000 (19:43 +0100)]
Merge pull request #3187 from flip1995/internal_fn
New internal lint: compiler_lint_functions
Michael Wright [Wed, 19 Sep 2018 05:39:50 +0000 (07:39 +0200)]
Update lint list
Michael Wright [Wed, 19 Sep 2018 05:04:38 +0000 (07:04 +0200)]
Make travis check lint list
Philipp Krones [Mon, 17 Sep 2018 09:44:06 +0000 (11:44 +0200)]
Merge pull request #3194 from flip1995/c_void
Fix c_void path
flip1995 [Mon, 17 Sep 2018 09:20:27 +0000 (11:20 +0200)]
Fix c_void path
This got changed in rust-lang/rust#53910
Philipp Krones [Sun, 16 Sep 2018 11:46:12 +0000 (13:46 +0200)]
Merge pull request #3192 from mikerite/refactor_20180916
Remove unneeded check for method call
Michael Wright [Sun, 16 Sep 2018 11:07:40 +0000 (13:07 +0200)]
Remove unneeded check for method call
The check can be removed because the call to `method_chains_args`
already performs this check.
Eduard-Mihai Burtescu [Sat, 15 Sep 2018 11:05:10 +0000 (14:05 +0300)]
Merge pull request #3190 from eddyb/rextern-2
Reintroduce `extern crate` for non-Cargo dependencies, in tests.
Eduard-Mihai Burtescu [Sat, 15 Sep 2018 10:37:21 +0000 (13:37 +0300)]
Reintroduce `extern crate` for non-Cargo dependencies, in tests.
Philipp Krones [Sat, 15 Sep 2018 09:56:11 +0000 (11:56 +0200)]
Merge pull request #3068 from matthiaskrgr/string
convert "".to_string() and "".to_owned() to String::new()
flip1995 [Sat, 15 Sep 2018 09:25:40 +0000 (11:25 +0200)]
Replace another occurrence of "".to_owned()
Matthias Krüger [Tue, 21 Aug 2018 10:46:18 +0000 (12:46 +0200)]
convert "".to_string() and "".to_owned() to String::new()
flip1995 [Fri, 14 Sep 2018 10:39:15 +0000 (12:39 +0200)]
Formatting
flip1995 [Fri, 14 Sep 2018 10:38:57 +0000 (12:38 +0200)]
Fix warnings of compiler_lint_functions
flip1995 [Fri, 14 Sep 2018 10:38:09 +0000 (12:38 +0200)]
Add internal lint compiler_lint_functions
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 15 Sep 2018 08:34:09 +0000 (10:34 +0200)]
Merge pull request #3189 from eddyb/rextern
Reintroduce `extern crate` for non-Cargo dependencies.
Eduard-Mihai Burtescu [Sat, 15 Sep 2018 08:10:21 +0000 (11:10 +0300)]
Revert "the cargo feature: edition 2018 is stabilized in current nightly"
This reverts commit
404a09d61cf7bc8e5d4e92ae9052a4e10d2ff07d.
Eduard-Mihai Burtescu [Sat, 15 Sep 2018 07:56:03 +0000 (10:56 +0300)]
Fix `useless_attribute` to also whitelist `unused_extern_crates`.
Eduard-Mihai Burtescu [Sat, 15 Sep 2018 07:21:58 +0000 (10:21 +0300)]
Reintroduce `extern crate` for non-Cargo dependencies.
Philipp Hansch [Fri, 14 Sep 2018 18:47:50 +0000 (19:47 +0100)]
Merge pull request #3186 from flip1995/pedantic_filter_map
Fix pedantic filter_map warnings
flip1995 [Fri, 14 Sep 2018 11:39:23 +0000 (13:39 +0200)]
Reapply: "the cargo feature: edition 2018 is stabilized in current nightly"
This reapplies commit
404a09d.
Cargo got bumped in rust-lang/rust#54210
flip1995 [Fri, 14 Sep 2018 10:56:25 +0000 (12:56 +0200)]
Fix pedantic filter_map warnings
Philipp Hansch [Fri, 14 Sep 2018 09:54:37 +0000 (10:54 +0100)]
Merge pull request #3185 from matthiaskrgr/readme_travis
readme: show how to make the travis job fail when using clippy
Matthias Krüger [Fri, 14 Sep 2018 09:21:27 +0000 (11:21 +0200)]
readme: show how to make the travis job fail when using clippy
Philipp Hansch [Fri, 14 Sep 2018 08:12:25 +0000 (09:12 +0100)]
Merge pull request #3182 from phansch/explain_travis
Explain Travis CI usage
Philipp Hansch [Fri, 14 Sep 2018 07:41:58 +0000 (08:41 +0100)]
Merge pull request #3184 from rust-lang-nursery/rustup
Add match on StructCtor
Manish Goregaokar [Fri, 14 Sep 2018 07:11:20 +0000 (12:41 +0530)]
Add match on StructCtor
Philipp Hansch [Fri, 14 Sep 2018 06:21:14 +0000 (08:21 +0200)]
Explain Travis CI usage
Closes #2432
Philipp Hansch [Thu, 13 Sep 2018 19:37:13 +0000 (20:37 +0100)]
Merge pull request #3140 from matthiaskrgr/redundant_casts
fix warnings about trivial casts, mostly {i,u}128 -> {i,u}128, such as "i128::min_value() as i128"
Philipp Krones [Thu, 13 Sep 2018 19:19:16 +0000 (21:19 +0200)]
Merge pull request #3174 from matthiaskrgr/RTU_clippy_cleanup
rustc_tools_util: clean up pedantic clippy warnings
Philipp Hansch [Thu, 13 Sep 2018 18:09:45 +0000 (19:09 +0100)]
Merge pull request #3173 from phansch/update_issue_template
Update ISSUE_TEMPLATE
Philipp Hansch [Thu, 13 Sep 2018 18:06:26 +0000 (19:06 +0100)]
Merge pull request #3165 from phansch/cleanup_readme_for_clippy_preview_on_stable
Cleanup README for clippy-preview on stable
Matthias Krüger [Thu, 13 Sep 2018 17:06:04 +0000 (19:06 +0200)]
rustc_tools_util: clean up pedantic clippy warnings
Philipp Hansch [Thu, 13 Sep 2018 16:31:39 +0000 (18:31 +0200)]
Update ISSUE_TEMPLATE
Philipp Hansch [Tue, 11 Sep 2018 18:35:41 +0000 (20:35 +0200)]
Remove rust-update script
We no longer need this as clippy is installed through rustup now.
Philipp Hansch [Tue, 11 Sep 2018 18:29:00 +0000 (20:29 +0200)]
Cleanup README for clippy-preview on stable
With the 1.29 release, the `clippy-preview` component will be available
on stable which means we don't need nightly/beta anymore.
Philipp Hansch [Thu, 13 Sep 2018 16:22:48 +0000 (17:22 +0100)]
Merge pull request #3166 from flip1995/travis_internal
Run internal lints on the Clippy code base
Manish Goregaokar [Thu, 13 Sep 2018 09:36:54 +0000 (15:06 +0530)]
Merge pull request #3171 from rust-lang-nursery/README-tool-lints
README: More detailed explanation of tool_lints
Philipp Krones [Thu, 13 Sep 2018 09:27:01 +0000 (11:27 +0200)]
README: More detailed explanation of tool_lints
cc #3164
Matthias Krüger [Thu, 6 Sep 2018 13:57:32 +0000 (15:57 +0200)]
fix warnings about trivial casts, mostly {i,u}128 -> {i,u}128, such as "i128::min_value() as i128"
Philipp Hansch [Thu, 13 Sep 2018 05:33:26 +0000 (06:33 +0100)]
Merge pull request #3085 from mikerite/revert-98dbce
Revert "Fix E0502 warnings"
mikerite [Thu, 13 Sep 2018 05:24:41 +0000 (07:24 +0200)]
Merge pull request #3169 from yangby-cryptape/fix-typo-in-examples
Fix typo in examples.
Boyu Yang [Thu, 13 Sep 2018 05:01:23 +0000 (13:01 +0800)]
Remove a wrong suggestion.
Boyu Yang [Thu, 13 Sep 2018 03:51:58 +0000 (11:51 +0800)]
Fix typo in examples.
flip1995 [Tue, 11 Sep 2018 23:34:52 +0000 (01:34 +0200)]
Change Hash{Map, Set} to FxHash{Map, Set}
flip1995 [Tue, 11 Sep 2018 23:34:04 +0000 (01:34 +0200)]
Fix lint_without_lint_pass lint
flip1995 [Tue, 11 Sep 2018 23:33:28 +0000 (01:33 +0200)]
Also run internal lints on the code base
Oliver Schneider [Mon, 10 Sep 2018 14:02:17 +0000 (16:02 +0200)]
Revert "the cargo feature: edition 2018 is stabilized in current nightly"
This reverts commit
404a09d61cf7bc8e5d4e92ae9052a4e10d2ff07d.
Oliver Schneider [Mon, 10 Sep 2018 13:44:41 +0000 (15:44 +0200)]
Don't use the old feature gate
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 10 Sep 2018 11:57:55 +0000 (13:57 +0200)]
Merge pull request #3160 from matthiaskrgr/ed_2018
the cargo feature: edition 2018 is stabilized in current nightly
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 10 Sep 2018 11:44:47 +0000 (13:44 +0200)]
Merge pull request #3152 from PSeitz/master
fixes #3151 by skipping the lint instead of crashing
Pascal Seitz [Mon, 10 Sep 2018 07:03:33 +0000 (09:03 +0200)]
add spaces
Philipp Hansch [Mon, 10 Sep 2018 05:46:49 +0000 (06:46 +0100)]
Merge pull request #3157 from matthiaskrgr/Vinfo_impl_debug
impl std::fmt::Debug for VersionInfo
Matthias Krüger [Mon, 10 Sep 2018 01:01:51 +0000 (03:01 +0200)]
the cargo feature: edition 2018 is stabilized in current nightly
Philipp Krones [Sun, 9 Sep 2018 21:49:03 +0000 (23:49 +0200)]
Merge pull request #3135 from JoshMcguigan/explicit_counter_loop-1219
Closes #1219 false positive for explicit_counter_loop
Matthias Krüger [Sun, 9 Sep 2018 21:40:26 +0000 (23:40 +0200)]
impl std::fmt::Debug for VersionInfo
For clippy, this would print:
VersionInfo { crate_name: "clippy", major: 0, minor: 0, patch: 212, commit_hash: "
084be7ba", commit_date: "2018-09-09" }
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sun, 9 Sep 2018 11:17:13 +0000 (13:17 +0200)]
Merge pull request #3148 from matthiaskrgr/rustc_tools_util_tests
rustc_tools_util: add tests
mikerite [Sun, 9 Sep 2018 05:15:39 +0000 (07:15 +0200)]
Merge pull request #3149 from matthiaskrgr/test_3075
add tests for #3057.
Pascal Seitz [Sat, 8 Sep 2018 13:30:50 +0000 (15:30 +0200)]
fixes #3151 by skipping the lint instead of crashing