]>
git.lizzy.rs Git - rust.git/log
Oliver Schneider [Tue, 30 Jan 2018 18:17:38 +0000 (19:17 +0100)]
Merge pull request #2413 from flip1995/assign_ops
Improved suggestion on misrefactored_assign_op lint
flip1995 [Tue, 30 Jan 2018 16:45:35 +0000 (17:45 +0100)]
Additionally suggest the semantic equal variant
Oliver Schneider [Tue, 30 Jan 2018 14:02:47 +0000 (15:02 +0100)]
Version bump
flip1995 [Tue, 30 Jan 2018 13:58:38 +0000 (14:58 +0100)]
Improved suggestion on misrefactored_assign_op lint. Fixes #1239
Oliver Schneider [Tue, 30 Jan 2018 12:09:23 +0000 (13:09 +0100)]
Merge pull request #2340 from phansch/newline_after_attributes
Warn on empty lines after outer attributes
Oliver Schneider [Tue, 30 Jan 2018 08:31:56 +0000 (09:31 +0100)]
Merge pull request #2412 from topecongiro/double-comparison
Add double comparison lint
Seiichi Uchida [Tue, 30 Jan 2018 01:35:35 +0000 (10:35 +0900)]
Add double comparions lint
Seiichi Uchida [Tue, 30 Jan 2018 01:35:22 +0000 (10:35 +0900)]
Rustup to rustc 1.25.0-nightly (
90eb44a58 2018-01-29)
Oliver Schneider [Mon, 29 Jan 2018 18:21:00 +0000 (19:21 +0100)]
Merge pull request #2409 from montrivo/while_let_on_iterator
#1121: already fixed, adding a test
Tim Nielens [Mon, 29 Jan 2018 15:52:22 +0000 (16:52 +0100)]
#1121: already fixed, adding a test
Philipp Hansch [Fri, 26 Jan 2018 06:51:27 +0000 (07:51 +0100)]
Add workaround for hidden outer attribute
If the snippet is empty, it's an attribute that was inserted during macro
expansion and we want to ignore those, because they could come from external
sources that the user has no control over.
For some reason these attributes don't have any expansion info on them, so
we have to check it this way until there is a better way.
Philipp Hansch [Tue, 23 Jan 2018 20:32:06 +0000 (21:32 +0100)]
Make lint work on all members of ast::Item_
Philipp Hansch [Fri, 19 Jan 2018 07:18:29 +0000 (08:18 +0100)]
Add test case for comments between item and attr
Philipp Hansch [Mon, 8 Jan 2018 23:22:42 +0000 (00:22 +0100)]
Warn on empty lines after outer attributes
Manish Goregaokar [Mon, 29 Jan 2018 05:50:29 +0000 (11:20 +0530)]
Bump to 0.0.183
Manish Goregaokar [Mon, 29 Jan 2018 05:50:17 +0000 (11:20 +0530)]
Bump compiletest version
Manish Goregaokar [Mon, 29 Jan 2018 05:47:50 +0000 (11:17 +0530)]
Merge pull request #2408 from rust-lang-nursery/rustup
Rustup to rustc 1.25.0-nightly (
21882aad7 2018-01-28)
Manish Goregaokar [Mon, 29 Jan 2018 04:18:11 +0000 (09:48 +0530)]
Update spans
Manish Goregaokar [Mon, 29 Jan 2018 04:18:06 +0000 (09:48 +0530)]
mut_mut_macro is missing plugin(clippy)
Seiichi Uchida [Sun, 28 Jan 2018 20:37:47 +0000 (05:37 +0900)]
Remove an unused binary file
Seiichi Uchida [Sun, 28 Jan 2018 07:28:48 +0000 (16:28 +0900)]
Rustup to rustc 1.25.0-nightly (
7d6e5b9da 2018-01-27)
Manish Goregaokar [Sat, 27 Jan 2018 13:37:53 +0000 (19:07 +0530)]
Merge pull request #2403 from mikerite/fix_compile_2
Fix compilation
Michael Wright [Sat, 27 Jan 2018 12:57:31 +0000 (14:57 +0200)]
Fix compilation
Fix the compilation broken by these two changes:
+ https://github.com/rust-lang/rust/commit/
2d56abfbebdc905dafc9cf9edc0a6f58e4de7cbd #diff-7fceb7ede15b205bf5ad812c31d75384L1459
+ https://github.com/rust-lang/rust/commit/
ccf0d8399e1ef3ed6bf7005650ce42aa646b5cc7 #diff-64b696b0ef6ad44140e973801ed82b25L2771
Manish Goregaokar [Thu, 25 Jan 2018 09:13:09 +0000 (14:43 +0530)]
Merge pull request #2400 from devonhollowood/misaligned-transmute
Add misaligned_transmute lint
Devon Hollowood [Thu, 25 Jan 2018 08:33:41 +0000 (00:33 -0800)]
Add misaligned_transmute lint
Oliver Schneider [Thu, 25 Jan 2018 08:02:05 +0000 (09:02 +0100)]
Merge pull request #2399 from rust-lang-nursery/rustup
Rustup to rustc 1.25.0-nightly (
a0dcecff9 2018-01-24)
Oliver Schneider [Thu, 25 Jan 2018 07:58:47 +0000 (08:58 +0100)]
Version Bump
Manish Goregaokar [Thu, 25 Jan 2018 07:44:04 +0000 (13:14 +0530)]
Rustup to rustc 1.25.0-nightly (
a0dcecff9 2018-01-24)
Manish Goregaokar [Thu, 25 Jan 2018 07:25:58 +0000 (12:55 +0530)]
Add known false positive for enum_glob_use
Oliver Schneider [Wed, 24 Jan 2018 12:51:29 +0000 (13:51 +0100)]
Merge pull request #2396 from rust-lang-nursery/author
Enable more patterns in the author lint
Oliver Schneider [Wed, 24 Jan 2018 12:04:06 +0000 (13:04 +0100)]
Enable more patterns in the author lint
Oliver Schneider [Tue, 23 Jan 2018 17:12:54 +0000 (18:12 +0100)]
Merge pull request #2393 from flip1995/regex
Let invalid_regex point to the right place for raw strings
flip1995 [Tue, 23 Jan 2018 15:52:14 +0000 (16:52 +0100)]
let invalid_regex point to the right place for raw strings
Oliver Schneider [Tue, 23 Jan 2018 14:54:35 +0000 (15:54 +0100)]
Merge pull request #2362 from flip1995/master
Lint for numeric literals that have a better representation
flip1995 [Tue, 23 Jan 2018 14:29:31 +0000 (15:29 +0100)]
Apply requested changes
flip1995 [Tue, 23 Jan 2018 11:52:20 +0000 (12:52 +0100)]
Adapt to updated ui tests
flip1995 [Tue, 23 Jan 2018 11:34:40 +0000 (12:34 +0100)]
Add configurable threshold, default: 4096
Oliver Schneider [Mon, 22 Jan 2018 07:14:52 +0000 (08:14 +0100)]
Merge pull request #2392 from theotherphil/bugfix
Fix unnecessary_fold bug
Phil Ellison [Mon, 22 Jan 2018 05:46:32 +0000 (05:46 +0000)]
Use existing match_var function
Phil Ellison [Mon, 22 Jan 2018 05:34:42 +0000 (05:34 +0000)]
Fix unnecessary_fold bug
Manish Goregaokar [Mon, 22 Jan 2018 05:05:01 +0000 (10:35 +0530)]
Rustup to rustc 1.25.0-nightly (
97520ccb1 2018-01-21)
Manish Goregaokar [Mon, 22 Jan 2018 05:01:44 +0000 (10:31 +0530)]
Merge pull request #2390 from topecongiro/rustup
Rustup to rustc 1.25.0-nightly (
97520ccb1 2018-01-21)
Seiichi Uchida [Mon, 22 Jan 2018 04:23:57 +0000 (13:23 +0900)]
Rustup to rustc 1.25.0-nightly (
97520ccb1 2018-01-21)
Martin Carton [Sat, 20 Jan 2018 23:07:13 +0000 (00:07 +0100)]
Merge pull request #2385 from rust-lang-nursery/small-doc-fix
Small documentation formatting fix
mcarton [Sat, 20 Jan 2018 22:32:02 +0000 (23:32 +0100)]
Small documentation formatting fix
Oliver Schneider [Fri, 19 Jan 2018 12:31:00 +0000 (13:31 +0100)]
Merge pull request #2350 from theotherphil/fold_any
Lint for using hand-writing a fold with the same behaviour as any
Oliver Schneider [Fri, 19 Jan 2018 12:25:17 +0000 (13:25 +0100)]
Merge pull request #2363 from rust-lang-nursery/appveyor
Fix appveyor
Oliver Schneider [Fri, 19 Jan 2018 12:18:44 +0000 (13:18 +0100)]
Update error count
Oliver Schneider [Fri, 19 Jan 2018 12:12:57 +0000 (13:12 +0100)]
Don't run cargo clippy on appveyor
Oliver Schneider [Wed, 17 Jan 2018 07:53:13 +0000 (08:53 +0100)]
Don't run 32 bit checks on windows
Oliver Schneider [Wed, 17 Jan 2018 07:52:41 +0000 (08:52 +0100)]
Readd the .exe extension on windows
Oliver Schneider [Tue, 16 Jan 2018 15:36:58 +0000 (16:36 +0100)]
Disable gnu builds on appveyor, rustc plugins are broken there
Oliver Schneider [Tue, 16 Jan 2018 14:26:32 +0000 (15:26 +0100)]
Don't run dogfood on windows or in the rustc test suite
Oliver Schneider [Fri, 19 Jan 2018 11:10:24 +0000 (12:10 +0100)]
Merge branch 'master' of github.com:Manishearth/rust-clippy into fold_any
Oliver Schneider [Fri, 19 Jan 2018 11:07:00 +0000 (12:07 +0100)]
Merge pull request #2364 from flip1995/precedence
Add macro check to precedence lint
Oliver Schneider [Fri, 19 Jan 2018 08:43:25 +0000 (09:43 +0100)]
Merge pull request #2382 from rust-lang-nursery/oli-obk-patch-1
Disable osx builder on travis
Oliver Schneider [Fri, 19 Jan 2018 08:16:33 +0000 (09:16 +0100)]
Disable osx builder on travis
Oliver Schneider [Fri, 19 Jan 2018 08:14:46 +0000 (09:14 +0100)]
Merge pull request #2367 from etaoins/inline-fn-without-body-lint
Lint for trait methods without bodies
Oliver Schneider [Fri, 19 Jan 2018 08:14:04 +0000 (09:14 +0100)]
Merge pull request #2381 from HMPerson1/remove_is_unit_expr
Replace `is_unit_expr`
Oliver Schneider [Fri, 19 Jan 2018 07:25:17 +0000 (08:25 +0100)]
Merge pull request #2299 from mikerite/option_option_pr
Implemented option_option lint
Michael Wright [Fri, 19 Jan 2018 06:10:09 +0000 (08:10 +0200)]
Added further tests
Michael Wright [Fri, 19 Jan 2018 05:56:46 +0000 (07:56 +0200)]
Merge branch 'master' into option_option_pr
HMPerson1 [Thu, 18 Jan 2018 22:33:09 +0000 (17:33 -0500)]
Use `unit_expr`
HMPerson1 [Thu, 18 Jan 2018 22:29:14 +0000 (17:29 -0500)]
Add `is_unit_expr` to deprecated lints list
Oliver Schneider [Thu, 18 Jan 2018 22:05:29 +0000 (23:05 +0100)]
Update compiletest
HMPerson1 [Thu, 18 Jan 2018 22:02:18 +0000 (17:02 -0500)]
Replace `is_unit_expr`
Oliver Schneider [Thu, 18 Jan 2018 21:02:58 +0000 (22:02 +0100)]
Don't run dogfood tests in the rustc test suite
Oliver Schneider [Thu, 18 Jan 2018 13:46:36 +0000 (14:46 +0100)]
Merge pull request #2375 from rust-lang-nursery/needless-range
Various needless_pass_by_value false positive fixes
Oliver Schneider [Thu, 18 Jan 2018 13:27:47 +0000 (14:27 +0100)]
Only suggest implementing Copy if it can actually be done
Ryan Cumming [Wed, 17 Jan 2018 19:08:03 +0000 (06:08 +1100)]
Suggest removing inline attributes
This adds a `suggest_remove_item` helper that will remove an item and
all trailing whitespace. This should handle both attributes on the same
line as the function and on a separate line; the function takes the
position of the original attribute.
Ryan Cumming [Wed, 17 Jan 2018 09:41:24 +0000 (20:41 +1100)]
Lint for trait methods without bodies
As discussed in rust-lang/rust#47475 the #[inline] attribute is
currently allowed on trait methods without bodies (i.e. without a
default implementation). This is misleading as it could be interpreted
as affecting the implementations of the trait method. Add a lint for any
use of #[inline] on a trait method without a body.
Fixes rust-lang/rust#47475
Manish Goregaokar [Thu, 18 Jan 2018 08:49:19 +0000 (14:19 +0530)]
needless_pass_by_value: Whitelist RangeArgument (fixes #2357)
Manish Goregaokar [Thu, 18 Jan 2018 08:45:41 +0000 (14:15 +0530)]
needless_pass_by_value: Add suggestion for implementing Copy (fixes #2222)
Manish Goregaokar [Thu, 18 Jan 2018 08:30:52 +0000 (14:00 +0530)]
needless_pass_by_value: Ignore for extern funcs (fixes #1844)
Oliver Schneider [Thu, 18 Jan 2018 08:10:39 +0000 (09:10 +0100)]
Merge pull request #2370 from Vlad-Shcherbina/patch-1
Document map_clone known problems #498
Michael Wright [Thu, 18 Jan 2018 05:52:24 +0000 (07:52 +0200)]
Rename variable
Rename `vec` to `ty` in `match_type_parameter`. This variable is a type
and not a vector. Previously it would only refer to `Vec<_>` so the name used
to make sense.
Michael Wright [Thu, 18 Jan 2018 05:48:03 +0000 (07:48 +0200)]
Fixed tests
Michael Wright [Thu, 18 Jan 2018 05:21:48 +0000 (07:21 +0200)]
Merge branch 'master' into option_option_pr
Phil Ellison [Wed, 17 Jan 2018 21:54:09 +0000 (21:54 +0000)]
Fix typos
Phil Ellison [Wed, 17 Jan 2018 21:06:16 +0000 (21:06 +0000)]
Add some reviewer comments
Phil Ellison [Wed, 17 Jan 2018 20:21:29 +0000 (20:21 +0000)]
Rename lint, improve documentation
Phil Ellison [Wed, 17 Jan 2018 20:11:40 +0000 (20:11 +0000)]
Fix bug. Don't expect lint when acc is on rhs
Phil Ellison [Wed, 17 Jan 2018 19:12:44 +0000 (19:12 +0000)]
Lint on folds implementing .all, .sum and .product
Vlad-Shcherbina [Wed, 17 Jan 2018 18:40:47 +0000 (21:40 +0300)]
Document map_clone known problems #498
Oliver Schneider [Wed, 17 Jan 2018 14:38:22 +0000 (15:38 +0100)]
Merge pull request #2309 from rust-lang-nursery/rustc-monitor
Use rustc_driver::run
Oliver Schneider [Tue, 16 Jan 2018 16:06:27 +0000 (17:06 +0100)]
Update changed ui tests
Manish Goregaokar [Thu, 28 Dec 2017 12:04:11 +0000 (17:34 +0530)]
Use rustc_driver::run (fixes #2303)
This internally uses monitor() which catches panics and stuff
Oliver Schneider [Wed, 17 Jan 2018 08:35:58 +0000 (09:35 +0100)]
Merge pull request #2298 from goodmanjonathan/else_if_without_else
add new lint else_if_without_else
Michael Wright [Wed, 17 Jan 2018 05:24:33 +0000 (07:24 +0200)]
Made requested changes
Michael Wright [Wed, 17 Jan 2018 04:52:00 +0000 (06:52 +0200)]
Merge branch 'master' into option_option_pr
Phil Ellison [Tue, 16 Jan 2018 21:20:55 +0000 (21:20 +0000)]
Fix error span to play nicely with rustfix
Oliver Schneider [Tue, 16 Jan 2018 15:41:12 +0000 (16:41 +0100)]
Merge pull request #2366 from rust-lang-nursery/const-static-fix
Show wider and more accurate suggestion for const_static_lifetime
Manish Goregaokar [Tue, 16 Jan 2018 15:16:43 +0000 (20:46 +0530)]
Show wider and more accurate suggestion for const_static_lifetime
fixes #2365
flip1995 [Tue, 16 Jan 2018 14:52:16 +0000 (15:52 +0100)]
Add macro check to precedence lint
flip1995 [Tue, 16 Jan 2018 13:01:07 +0000 (14:01 +0100)]
Lint for numeric literals that have a better representation in another format
Oliver Schneider [Tue, 16 Jan 2018 09:40:12 +0000 (10:40 +0100)]
Merge pull request #2355 from alusch/clone_on_ref_ptr_restriction
Fix #2048: Move `clone_on_ref_ptr` to the restriction lints
Oliver Schneider [Tue, 16 Jan 2018 07:52:14 +0000 (08:52 +0100)]
Update changed test output from rustc
Oliver Schneider [Mon, 15 Jan 2018 11:07:38 +0000 (12:07 +0100)]
Rustup
Jonathan Goodman [Sat, 16 Dec 2017 20:37:44 +0000 (14:37 -0600)]
add new lint else_if_without_else
Adam Lusch [Mon, 15 Jan 2018 04:19:55 +0000 (20:19 -0800)]
Adds the missing turbofish