]>
git.lizzy.rs Git - rust.git/log
Lukas Wirth [Mon, 22 Nov 2021 17:27:03 +0000 (18:27 +0100)]
fix: Omit generic defaults for types in hover messages
bors[bot] [Mon, 22 Nov 2021 17:01:40 +0000 (17:01 +0000)]
Merge #10839
10839: fix: Fix mbe::Shift::new not accounting for non-ident token ids r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/9371
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 22 Nov 2021 17:00:32 +0000 (18:00 +0100)]
Fix mbe::Shift::new not accounting for non-ident token ids
Lukas Wirth [Mon, 22 Nov 2021 16:58:36 +0000 (17:58 +0100)]
Document token up/down mapping
bors[bot] [Mon, 22 Nov 2021 15:59:52 +0000 (15:59 +0000)]
Merge #10838
10838: internal: Add the ability to emit token map ids in macro expansion tests r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 22 Nov 2021 14:59:41 +0000 (15:59 +0100)]
Add to macro testing infra to emit token map ids
bors[bot] [Mon, 22 Nov 2021 14:29:24 +0000 (14:29 +0000)]
Merge #10809
10809: fix: don't discard formatting of `use` lines r=Veykril a=iDawer
Use mutable syntax trees in `merge_imports`, `split_imports`. This tries to resolve #9013. But I haven't much managed to simplify code of merging.
Also resolve #9361. It reuses a use tree under the cursor so that comments+indentation are preserved. Merged trees are just appended to the end.
This touches bunch of tests. I removed the sorting of use trees as it needs a proper implementation that takes into account comments and line wrapping. I think it is rustfmt's job or at least until we get a close implementation.
Co-authored-by: iDawer <ilnur.iskhakov.oss@outlook.com>
bors[bot] [Mon, 22 Nov 2021 13:47:25 +0000 (13:47 +0000)]
Merge #10835
10835: internal: pull website before generating new changelog r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10829
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Mon, 22 Nov 2021 13:45:47 +0000 (14:45 +0100)]
Pull website before generating new changelog
bors[bot] [Mon, 22 Nov 2021 12:42:03 +0000 (12:42 +0000)]
Merge #10833
10833: internal: set upstream branch when promoting r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10830
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Mon, 22 Nov 2021 12:39:07 +0000 (13:39 +0100)]
Set upstream branch when promoting
bors[bot] [Mon, 22 Nov 2021 12:23:58 +0000 (12:23 +0000)]
Merge #10832
10832: internal: Split parts of `ide_db::call_info` off into `ide` r=Veykril a=Veykril
`call_info` itself is just an ide feature and thus should not reside in `ide_db` itself.
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 22 Nov 2021 12:19:46 +0000 (13:19 +0100)]
Split parts of `ide_db::call_info` off into `ide`
bors[bot] [Mon, 22 Nov 2021 12:05:57 +0000 (12:05 +0000)]
Merge #10831
10831: minor: Unnest `ide::display::navigation_target` module r=Veykril a=Veykril
This module contained multiple submodules before, but those were removed some time ago so there is no point in having this one module two layers deep anymore.
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 22 Nov 2021 12:04:28 +0000 (13:04 +0100)]
Unnest ide::display::navigation_target module
bors[bot] [Mon, 22 Nov 2021 10:07:23 +0000 (10:07 +0000)]
Merge #10828
10828: doc: document absence of stability guarantees r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 22 Nov 2021 10:06:37 +0000 (13:06 +0300)]
doc: document absence of stability guarantees
bors[bot] [Sun, 21 Nov 2021 20:01:07 +0000 (20:01 +0000)]
Merge #10823
10823: fix: better `Fn` traits formatting r=jonas-schievink a=veber-alex
This makes it so formatting `Fn` traits properly handles:
1. An `Fn` trait with only a single argument -> removes the trailing comma.
2. An `Fn` trait which returns nothing (an empty tuple) -> don't show `-> ()` as the return type.
before:
![before](https://user-images.githubusercontent.com/
29788806 /
142745038 -
44ac68ce -de42-4396-a809-
ffdb883be699 .png)
after:
![after](https://user-images.githubusercontent.com/
29788806 /
142745040 -
485feaa2 -cc21-4a05-9576-
5410ea355029 .png)
Co-authored-by: Alex Veber <alexveber@gmail.com>
Alex Veber [Sun, 21 Nov 2021 00:39:22 +0000 (02:39 +0200)]
fix: better `Fn` traits formatting
bors[bot] [Sat, 20 Nov 2021 20:24:31 +0000 (20:24 +0000)]
Merge #10810
10810: feat: Add toggle to disable cache priming r=jonas-schievink a=lnicola
Even if it doesn't prevent the rest of the features from working, cache priming tends to be quite CPU-intensive and can make people think that the load times are worse than they actually are.
It's also less useful in Code and `rust-tools` because the inlay hints and semantic highlighting trigger quite a bit of computation assuming you have a file open in the editor.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
bors[bot] [Sat, 20 Nov 2021 17:25:17 +0000 (17:25 +0000)]
Merge #10821
10821: fix: wrap `inline_call` and `inline_into_callers` if it inlines into the left side of a binary expression r=Veykril a=rainy-me
close #10359
Co-authored-by: rainy-me <github@yue.coffee>
rainy-me [Sat, 20 Nov 2021 16:48:04 +0000 (01:48 +0900)]
fix: check inline left of binary_expression
bors[bot] [Sat, 20 Nov 2021 16:26:50 +0000 (16:26 +0000)]
Merge #10820
10820: minor: Move incorrect case diagnostic things into their module r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sat, 20 Nov 2021 16:19:19 +0000 (17:19 +0100)]
Move incorrect case diagnostic things into their module
bors[bot] [Sat, 20 Nov 2021 15:40:56 +0000 (15:40 +0000)]
Merge #10819
10819: internal: Replace some `Vec` occurences with `Box` r=Veykril a=Veykril
Shaves off ~15mb from self analysis
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sat, 20 Nov 2021 15:37:41 +0000 (16:37 +0100)]
Replace Vec with Box in Path.generic_args field
Lukas Wirth [Sat, 20 Nov 2021 15:17:16 +0000 (16:17 +0100)]
internal: Replace Vec with Box in hir Pat
Lukas Wirth [Sat, 20 Nov 2021 15:00:45 +0000 (16:00 +0100)]
internal: Replace Vec with Box in hir Expr
bors[bot] [Sat, 20 Nov 2021 12:01:22 +0000 (12:01 +0000)]
Merge #10817
10817: ide: hover omits unnamed where preds r=Veykril a=jhgg
fixes #10800
Co-authored-by: Jake Heinz <jh@discordapp.com>
Jake Heinz [Sat, 20 Nov 2021 11:30:53 +0000 (11:30 +0000)]
ide: hover omits unnamed where preds
bors[bot] [Fri, 19 Nov 2021 20:02:26 +0000 (20:02 +0000)]
Merge #10812
10812: feat: Format `Fn` traits using parentheses r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8157
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Fri, 19 Nov 2021 18:58:00 +0000 (19:58 +0100)]
Format `Fn` traits using parentheses
Laurențiu Nicola [Fri, 19 Nov 2021 15:56:46 +0000 (17:56 +0200)]
Add toggle to disable cache priming
bors[bot] [Fri, 19 Nov 2021 15:35:09 +0000 (15:35 +0000)]
Merge #10808
10808: fix: show custom check-command r=Veykril a=Florian-Schoenherr
just realized this is a lot cleaner and actually shows something on a custom command,
also debugged it this time.
Co-authored-by: Florian-Schoenherr <65456722+Florian-Schoenherr@users.noreply.github.com>
Florian-Schoenherr [Fri, 19 Nov 2021 15:22:39 +0000 (16:22 +0100)]
fix: show custom check-command
iDawer [Fri, 19 Nov 2021 09:06:36 +0000 (14:06 +0500)]
Use mutable syntax trees in `merge_imports`, `split_imports`
bors[bot] [Fri, 19 Nov 2021 12:20:13 +0000 (12:20 +0000)]
Merge #10807
10807: fix: Diagnose invalid derive attribute input r=Veykril a=Veykril
Doesn't yet diagnose incorrect syntax between the `(`, `)` braces as we discard those problems currently.
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 19 Nov 2021 12:17:35 +0000 (13:17 +0100)]
fix: Diagnose invalid derive attribute input
bors[bot] [Fri, 19 Nov 2021 11:46:49 +0000 (11:46 +0000)]
Merge #10806
10806: fix: inlay param hint hiding heurstic is case unsensitive r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 19 Nov 2021 11:46:03 +0000 (12:46 +0100)]
fix: inlay param hint hiding heurstic is case unsensitive
bors[bot] [Fri, 19 Nov 2021 11:34:22 +0000 (11:34 +0000)]
Merge #10804
10804: fix: Diagnose using `derive` on non-adt items r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 18 Nov 2021 21:17:22 +0000 (22:17 +0100)]
fix: Diagnose using `derive` on non-adt items
bors[bot] [Fri, 19 Nov 2021 10:59:49 +0000 (10:59 +0000)]
Merge #10805
10805: ide: dedupe or merge hover actions r=Veykril a=jhgg
fixes #10780
Co-authored-by: Jake Heinz <jh@discordapp.com>
Jake Heinz [Thu, 18 Nov 2021 11:34:33 +0000 (11:34 +0000)]
ide: dedupe or merge hover actions
bors[bot] [Thu, 18 Nov 2021 20:45:20 +0000 (20:45 +0000)]
Merge #10803
10803: minor: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 18 Nov 2021 20:43:54 +0000 (21:43 +0100)]
minor: Simplify
bors[bot] [Thu, 18 Nov 2021 09:56:44 +0000 (09:56 +0000)]
Merge #10798
10798: ide: show go to for function hover return type r=Veykril a=jhgg
I've found myself wanting this... adds to the hover quick go-to for a function's return type:
![image](https://user-images.githubusercontent.com/
5489149 /
142375722 -
4a385216 -494b-45a4-be1c-
59664213b8d6 .png)
This is particularly useful when you are hovering over a function in a long chain, like:
```rust
foo.bar().b$0az().some_trait_fn();
```
where `baz`'s return type is not immediately obvious, but the chain is not long enough to trigger chain inlay hints...
i guess I could just select `foo.bar().baz()` too to get the types too...
Co-authored-by: Jake Heinz <jh@discordapp.com>
bors[bot] [Thu, 18 Nov 2021 09:48:10 +0000 (09:48 +0000)]
Merge #10796
10796: ide: display static values in hover r=Veykril a=jhgg
Continuation from #10785 - does the same thing, but for `static`'s as well.
Co-authored-by: Jake Heinz <jh@discordapp.com>
bors[bot] [Thu, 18 Nov 2021 09:40:59 +0000 (09:40 +0000)]
Merge #10795
10795: Remove unwrap in doc path resolution r=Veykril a=udoprog
I keep hitting this constantly in my project, and I haven't dug very deep into the root cause. But seeing as the project otherwise compiles it appears to be something unsupported is being incorrectly parsed in rust-analyzer which for other cases is handled by returning `None`.
Co-authored-by: John-John Tedro <udoprog@tedro.se>
bors[bot] [Thu, 18 Nov 2021 09:33:47 +0000 (09:33 +0000)]
Merge #10794
10794: fix: parse the range pat inside the tuple pat r=lnicola a=XFFXFF
fixes #10784
Co-authored-by: zhoufan <1247714429@qq.com>
bors[bot] [Thu, 18 Nov 2021 08:38:07 +0000 (08:38 +0000)]
Merge #10799
10799: fix: Fix proc macro ABI version checks r=lnicola a=lnicola
If I'm reading this right, we used to pick `Abi1_55` for `1.54` and `Abi_1_58` for `1.57`.
CC `@alexjg` (just in case I'm misinterpreting the code), CC #10772.
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Thu, 18 Nov 2021 08:12:29 +0000 (10:12 +0200)]
Fix proc macro ABI version checks
Jake Heinz [Thu, 18 Nov 2021 08:00:22 +0000 (08:00 +0000)]
ide: show go to for function hover return type
Jake Heinz [Thu, 18 Nov 2021 04:47:07 +0000 (04:47 +0000)]
ide: display static values in hover
John-John Tedro [Thu, 18 Nov 2021 04:19:58 +0000 (05:19 +0100)]
Remove unwrap in doc path resolution
bors[bot] [Thu, 18 Nov 2021 04:17:16 +0000 (04:17 +0000)]
Merge #10785
10785: ide: show const value in hover r=jhgg a=jhgg
fixes #10783
I think my original attempt was incorrect, because it looks like `HirDisplay` is used in more places than just the hover.
So, I've attempted it again in
312eafe , this time specifically just rendering the value in `hover::render`
pictoral:
![image](https://user-images.githubusercontent.com/
5489149 /
142163890 -
b6aa2ab4 -7bd0-4dd3-b35d-
5eaa83fffb7f .png)
Co-authored-by: Jake Heinz <jh@discordapp.com>
Co-authored-by: Jake <jh@discordapp.com>
Jake Heinz [Thu, 18 Nov 2021 04:14:11 +0000 (04:14 +0000)]
more complicated const test
zhoufan [Thu, 18 Nov 2021 03:11:37 +0000 (11:11 +0800)]
fix: parse the range pat inside the tuple pat
bors[bot] [Wed, 17 Nov 2021 20:11:21 +0000 (20:11 +0000)]
Merge #10789
10789: internal: Check for derive attributes by item path, not `derive` identifier r=Veykril a=Veykril
Prior we only checked if an attribute is the exact `derive` identifier and nothing else to collect derive attributes. That means when we encounter the following:
```rs
#[::core::macros::builtin::derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
pub struct ModPath {
pub kind: PathKind,
segments: Vec<Name>,
}
```
We won't actually expand the derive attributes, but instead we just expand the `derive` attribute with our dummy identity expander.
The changes here make it so we actually lookup the attribute path, check if it is the derive attribute and then collect the derives.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 17 Nov 2021 19:51:15 +0000 (20:51 +0100)]
Simplify
Lukas Wirth [Wed, 17 Nov 2021 18:46:32 +0000 (19:46 +0100)]
Check for derive attributes by item path, not `derive` identifier
Jake [Wed, 17 Nov 2021 17:53:24 +0000 (09:53 -0800)]
Apply suggestions from code review
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Wed, 17 Nov 2021 14:55:18 +0000 (14:55 +0000)]
Merge #10787
10787: minor: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 17 Nov 2021 14:30:12 +0000 (15:30 +0100)]
Simplify
bors[bot] [Wed, 17 Nov 2021 10:39:19 +0000 (10:39 +0000)]
Merge #10786
10786: minor: remove duplicate calls r=Veykril a=XFFXFF
`scopes.set_scope(*expr, scope)` is duplicate, because we always call it in `compute_expr_scopes` https://github.com/rust-analyzer/rust-analyzer/blob/
add6cccd4c923fbb5c83cc27b06aa84b2cbc9557 /crates/hir_def/src/body/scope.rs#L175-L180
Co-authored-by: zhoufan <1247714429@qq.com>
zhoufan [Wed, 17 Nov 2021 10:16:25 +0000 (18:16 +0800)]
minor: remove duplicate calls
Jake Heinz [Wed, 17 Nov 2021 07:00:24 +0000 (07:00 +0000)]
maybe this is better??
Jake Heinz [Wed, 17 Nov 2021 05:49:27 +0000 (05:49 +0000)]
hir: show const value in hover
bors[bot] [Tue, 16 Nov 2021 20:51:09 +0000 (20:51 +0000)]
Merge #10781
10781: internal: Do not use reference search in `runnables::related_tests` r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Tue, 16 Nov 2021 20:33:58 +0000 (20:33 +0000)]
Merge #10778
10778: internal: Skip test/bench attr expansion in resolution instead of collection r=Veykril a=Veykril
This way we skip any path resolving to the test and bench attributes instead of just the lone identifiers(which could very well point to non-builtin attributes).
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 16 Nov 2021 20:32:02 +0000 (21:32 +0100)]
Do not use reference search in runnables::related_tests
Lukas Wirth [Tue, 16 Nov 2021 20:26:34 +0000 (21:26 +0100)]
Simplify
Lukas Wirth [Tue, 16 Nov 2021 19:23:56 +0000 (20:23 +0100)]
Skip test/bench attr expansion in resolution instead of collection
bors[bot] [Tue, 16 Nov 2021 18:52:26 +0000 (18:52 +0000)]
Merge #10775
10775: minor: Simplify r=lnicola a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Tue, 16 Nov 2021 18:44:04 +0000 (18:44 +0000)]
Merge #10777
10777: internal: Allow disabling perf access via `RA_DISABLE_PERF` r=lnicola a=jonas-schievink
https://github.com/rr-debugger/rr does not support the perf-specific ioctls, so add a way to avoid them.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Tue, 16 Nov 2021 18:32:38 +0000 (19:32 +0100)]
Allow disabling perf access via `RA_DISABLE_PERF`
Lukas Wirth [Tue, 16 Nov 2021 12:25:23 +0000 (13:25 +0100)]
minor: Simplify
bors[bot] [Tue, 16 Nov 2021 18:18:47 +0000 (18:18 +0000)]
Merge #10776
10776: fix: Remove validation of `super` in use paths r=Veykril a=lnicola
Fixes #10770
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Tue, 16 Nov 2021 17:59:36 +0000 (19:59 +0200)]
Remove validation of `super` in use paths
bors[bot] [Tue, 16 Nov 2021 16:40:51 +0000 (16:40 +0000)]
Merge #10769
10769: Add proc macro ABI for rustc 1.58 r=lnicola a=alexjg
This fixes #10766.
I do have some concerns here. The proc macro server API has added three methods to `TokenStream` which I don't really know how to implement in `RustcServer`. Namely `expand_expr`, `before`, and `after`. You'll see that these are currently `unimplemented!` in `crates/proc_macro_server/src/abis/abi_1_58/rustc_server.rs`. I don't have the expertise to fill in the blanks here, it may be necessary to pull in someone who knows a bit more about the proc macro crate.
I think this will only be a problem when actually attempting to expand a macro, so this is probably strictly better than not including the updated ABI at all.
Co-authored-by: Alex Good <alex@memoryandthought.me>
Alex Good [Mon, 15 Nov 2021 13:47:33 +0000 (13:47 +0000)]
Add proc macro ABI for rustc 1.58
bors[bot] [Tue, 16 Nov 2021 11:27:11 +0000 (11:27 +0000)]
Merge #10734
10734: fix: add generic parameters in convert to manual impl assist r=Veykril a=TheDoctor314
Fixes #10041.
Co-authored-by: TheDoctor314 <64731940+TheDoctor314@users.noreply.github.com>
bors[bot] [Tue, 16 Nov 2021 11:16:50 +0000 (11:16 +0000)]
Merge #10774
10774: minor: Lift out FxIndex{Map/Set} types into ide_db r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 16 Nov 2021 11:15:47 +0000 (12:15 +0100)]
minor: Lift out FxIndex{Map/Set} types into ide_db
bors[bot] [Tue, 16 Nov 2021 10:52:31 +0000 (10:52 +0000)]
Merge #10773
10773: fix: Remove faulty logic for ascending test attributes for runnables r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10768
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 16 Nov 2021 10:36:41 +0000 (11:36 +0100)]
fix: Reimplement mapping out of test/bench attributes for runnables
TheDoctor314 [Mon, 15 Nov 2021 15:21:48 +0000 (20:51 +0530)]
Fix `impl_def_from_trait`
Revert "Fix `impl_trait` function to emit correct ast"
This reverts commit
55a4813151a8f36dcdb520c45a461fe5dfbed499 .
Fix `impl_def_from_trait`
It now generates the correct `ast::Impl` using
`generate_trait_impl_text` and parses it to form the right node (copied
from the private fn 'make::ast_from_text').
bors[bot] [Sun, 14 Nov 2021 15:26:58 +0000 (15:26 +0000)]
Merge #10767
10767: minor: Rename intern_macro -> intern_macro_call r=Veykril a=Veykril
We potentially want to intern macro definitions so the names would probably collide
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sun, 14 Nov 2021 15:25:40 +0000 (16:25 +0100)]
Rename intern_macro -> intern_macro_call
bors[bot] [Sun, 14 Nov 2021 12:05:17 +0000 (12:05 +0000)]
Merge #10759
10759: make `add_missing_match_arms` applicable at the end of the match r=Veykril a=rainy-me
close #10740
Co-authored-by: rainy-me <github@yue.coffee>
rainy-me [Sun, 14 Nov 2021 11:56:28 +0000 (20:56 +0900)]
adjust test case and stop deleting newline
bors[bot] [Sun, 14 Nov 2021 09:20:59 +0000 (09:20 +0000)]
Merge #10762
10762: Fix: trigger flyimport on enum variants r=lnicola a=XFFXFF
fixes #10749
Co-authored-by: zhoufan <1247714429@qq.com>
zhoufan [Sun, 14 Nov 2021 04:16:21 +0000 (12:16 +0800)]
fix: flyimport triggers on enum variant declarations
bors[bot] [Sat, 13 Nov 2021 23:42:16 +0000 (23:42 +0000)]
Merge #10761
10761: inlay hints: add the option to always show constructor inlay hints r=Veykril a=jhgg
This PR adds a config to *disable* the functionality in #10441 - _and makes that functionality disabled by default._
I actually *really* like inlay hints always showing up, and it helps a lot as a teaching tool too, and also it's quite reassuring to know that r-a indeed understands the code I've written. This PR adds the option `rust-analyzer.inlayHints.hideNamedConstructorHints` (i can also invert this to be `rust-analyzer.inlayHints.showNamedConstructorHints`, just let me know.)
Co-authored-by: Jake Heinz <jh@discordapp.com>
Jake Heinz [Sat, 13 Nov 2021 23:39:34 +0000 (23:39 +0000)]
flip the default
Jake Heinz [Sat, 13 Nov 2021 23:12:29 +0000 (23:12 +0000)]
inlay hints: add the option to always show constructor inlay hints
rainy-me [Sat, 13 Nov 2021 17:32:10 +0000 (02:32 +0900)]
add missing match arms end of last arm
bors[bot] [Sat, 13 Nov 2021 15:56:25 +0000 (15:56 +0000)]
Merge #10758
10758: Update docs: include Gentoo source build r=lnicola a=mjkalyan
Mention the dev-util/rust-analyzer package for building from source.
Co-authored-by: mjkalyan <34904034+mjkalyan@users.noreply.github.com>
mjkalyan [Sat, 13 Nov 2021 01:26:21 +0000 (18:26 -0700)]
Update docs: include Gentoo source build
Mention the dev-util/rust-analyzer package for building from source.
bors[bot] [Fri, 12 Nov 2021 21:05:54 +0000 (21:05 +0000)]
Merge #10756
10756: Allow the check command to terminate without output r=Veykril a=Wilfred
Cargo will always output something on success:
```
$ cargo check --message-format=json
{"reason":"compiler-artifact", ... snipped ... }
{"reason":"build-finished","success":true}
```
However, rustc does not output anything on success:
```
$ rustc --error-format=json main.rs
$ echo $?
0
```
Restore the behaviour prior to #10517, where an exit code of 0 is
considered good even if nothing is written to stdout.
This enables custom overrideCommand values that use rustc rather than
cargo.
Co-authored-by: Wilfred Hughes <me@wilfred.me.uk>