]> git.lizzy.rs Git - rust.git/log
rust.git
2 years agoSort candidate libraries by source path in error
Noah Lev [Wed, 6 Oct 2021 17:16:02 +0000 (10:16 -0700)]
Sort candidate libraries by source path in error

This makes the error output deterministic and thus testable.

2 years agoMake `rust.overflow-checks-std`option default to `rust.overflow-checks`.
Hans Kratz [Tue, 12 Oct 2021 19:28:49 +0000 (21:28 +0200)]
Make `rust.overflow-checks-std`option default to `rust.overflow-checks`.

2 years agoAdd --enable-debug-assertions-std option to configure script.
Hans Kratz [Tue, 12 Oct 2021 19:32:47 +0000 (21:32 +0200)]
Add --enable-debug-assertions-std option to configure script.

2 years agoAdd --enable-overflow-checks-std option to configure script.
Hans Kratz [Mon, 11 Oct 2021 21:05:26 +0000 (23:05 +0200)]
Add --enable-overflow-checks-std option to configure script.

2 years agoAdd missing entries for overflow-checks to config.toml.example.
Hans Kratz [Mon, 11 Oct 2021 17:54:27 +0000 (19:54 +0200)]
Add missing entries for overflow-checks to config.toml.example.

2 years agoAuto merge of #89813 - the8472:rollup-f1f99mb, r=the8472
bors [Tue, 12 Oct 2021 17:57:34 +0000 (17:57 +0000)]
Auto merge of #89813 - the8472:rollup-f1f99mb, r=the8472

Rollup of 7 pull requests

Successful merges:

 - #89778 (Add #[must_use] to as_type conversions)
 - #89784 (Remove built-in query cache_hit tracking)
 - #89796 (Add #[must_use] to non-mutating verb methods)
 - #89797 (Add #[must_use] to is_condition tests)
 - #89799 (fix minor spelling error in Poll::ready docs)
 - #89800 (Update books)
 - #89809 (Remap ssa RealPredicate to llvm RealPredicate)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoSwitch order of terms to prevent overflow
jackh726 [Tue, 12 Oct 2021 15:14:31 +0000 (11:14 -0400)]
Switch order of terms to prevent overflow

2 years agoUpdate winapi shared features.
Eric Huss [Tue, 12 Oct 2021 14:14:32 +0000 (07:14 -0700)]
Update winapi shared features.

Needed due to os_info.

2 years agoAdd #[inline] to int log10 functions.
Mara Bos [Tue, 12 Oct 2021 13:21:14 +0000 (15:21 +0200)]
Add #[inline] to int log10 functions.

2 years agoFix invalid rules in .gitignore
Canop [Tue, 12 Oct 2021 13:09:28 +0000 (15:09 +0200)]
Fix invalid rules in .gitignore

`**node_modules` in a .gitignore is the same than
`*node_modules` or `*****node_modules`.

It matches every file whose name ends with `node_modules`,
including `not_node_modules`.

The intent here was obviously to have `**/node_modules`
which is the same than just `node_modules`.

2 years agoAdd test for associated constants in the sidebar
Guillaume Gomez [Tue, 12 Oct 2021 13:07:11 +0000 (15:07 +0200)]
Add test for associated constants in the sidebar

2 years agoList associated constants in the sidebar
Guillaume Gomez [Tue, 12 Oct 2021 13:06:52 +0000 (15:06 +0200)]
List associated constants in the sidebar

2 years agoRemove potentially unsound note on reconstructing a leaked Vec.
Mara Bos [Tue, 12 Oct 2021 13:02:52 +0000 (15:02 +0200)]
Remove potentially unsound note on reconstructing a leaked Vec.

2 years agoFix uppercase/lowercase error
John Kugelman [Tue, 12 Oct 2021 12:53:54 +0000 (08:53 -0400)]
Fix uppercase/lowercase error

2 years agoRollup merge of #89809 - tmiasko:remap-real-predicate, r=michaelwoerister
the8472 [Tue, 12 Oct 2021 12:53:13 +0000 (14:53 +0200)]
Rollup merge of #89809 - tmiasko:remap-real-predicate, r=michaelwoerister

Remap ssa RealPredicate to llvm RealPredicate

to avoid relying on the discriminant of the former for FFI purposes

2 years agoRollup merge of #89800 - ehuss:update-books, r=ehuss
the8472 [Tue, 12 Oct 2021 12:53:12 +0000 (14:53 +0200)]
Rollup merge of #89800 - ehuss:update-books, r=ehuss

Update books

## nomicon

5 commits in 2747c4bb2cbc0639b733793ddb0bf4e9daa2634e..2d66852a27c5d0ec50ae021820d1de22caa2b1bd
2021-09-19 17:33:32 +0900 to 2021-10-07 19:00:37 +0900
- Fix typo/minor grammar error in subtyping.md (rust-lang/nomicon#317)
- doc: clarify `thread::scoped::JoinGuard` chapter (rust-lang/nomicon#313)
- Clarify niche optimization on enums with reprs (rust-lang/nomicon#315)
- Update rc decrement snipped (rust-lang/nomicon#316)
- Remove useless `unsafe`, `mut` and ptr casts in example in `send-and-sync.md` (rust-lang/nomicon#308)

## reference

2 commits in 13747275bd14c2d2b453100498532f9ae5504769..b5c68b02984f74e99d1f1b332029e05f607e2660
2021-09-24 17:44:04 +0900 to 2021-10-02 08:11:35 -0700
- Use subtrait/supertrait, not sub-trait, super-trait. (rust-lang/reference#1095)
- Fixed link typo in Generics.md (rust-lang/reference#1094)

## rust-by-example

3 commits in 28aca4a36962c709bce301c03114b5589381dfb8..9a60624fcad0140826c44389571dc622917cd632
2021-09-25 08:19:51 -0300 to 2021-10-04 08:13:53 -0300
- Change 1..n + 1 to 1..=n (rust-lang/rust-by-example#1467)
- Close rust-lang/rust-by-example#1464 (rust-lang/rust-by-example#1465)
- Fix incorrect formatted print hint; closes rust-lang/rust-by-example#1459. (rust-lang/rust-by-example#1466)

## rustc-dev-guide

11 commits in d1f03cbaa39d9164f5fe4b9b93762668142e0dad..fba15a46ca8efa97e8a955794724ac7ce27805b8
2021-09-24 12:00:29 +0900 to 2021-10-12 08:52:21 +0900
- Update some docs from 2021-10 date triage (rust-lang/rustc-dev-guide#1230)
- Recommend `rustfmt --edition=2021`
- Update sanitizer documentation
- Mention needs-sanitizer-hwaddress directive
- Address review comments
- Document tracing awesomeness
- Move log/tracing instructions to its own file
- Update src/closure.md
- Fix accidental HTML tag
- Update links to `rustc_mir` in Two Phase Borrows (rust-lang/rustc-dev-guide#1226)
- Update some docs from 2021-10 date triage (rust-lang/rustc-dev-guide#1224)

## edition-guide

1 commits in 2d9b1b9da706de24650fdc5c3b0182f55c82115d..7c0088ca744d293a5f4b1e2ac378e7c23d30fe55
2021-08-31 10:44:09 +0200 to 2021-10-05 13:28:05 +0200
- Clarify cargo resolver behavior in a workspace. (rust-lang/edition-guide#267)

## embedded-book

2 commits in 4c76da9ddb4650203c129fceffdea95a3466c205..270fccd339e5972d9c900e788f197e81a0bcd956
2021-09-12 12:43:03 +0000 to 2021-10-06 16:28:48 +0000
- Update section 1.4 to mention that some additional packages required  (rust-embedded/book#304)
- Change `-file-headers` to `--file-headers`  (rust-embedded/book#303)

2 years agoRollup merge of #89799 - ast-ral:ready-method-spellck, r=joshtriplett
the8472 [Tue, 12 Oct 2021 12:53:11 +0000 (14:53 +0200)]
Rollup merge of #89799 - ast-ral:ready-method-spellck, r=joshtriplett

fix minor spelling error in Poll::ready docs

Fixes minor spelling error in the proposed `Poll::ready` docs. Not that my opinion matters, but +1 on the original PR (#89651), it reads much nicer to me than the `ready!` macro.

2 years agoRollup merge of #89797 - jkugelman:must-use-is_condition-tests, r=joshtriplett
the8472 [Tue, 12 Oct 2021 12:53:11 +0000 (14:53 +0200)]
Rollup merge of #89797 - jkugelman:must-use-is_condition-tests, r=joshtriplett

Add #[must_use] to is_condition tests

I threw in `std::path::Path::has_root` for funsies.

A continuation of #89718.

Parent issue: #89692

r? ```@joshtriplett```

2 years agoRollup merge of #89796 - jkugelman:must-use-non-mutating-verb-methods, r=joshtriplett
the8472 [Tue, 12 Oct 2021 12:53:10 +0000 (14:53 +0200)]
Rollup merge of #89796 - jkugelman:must-use-non-mutating-verb-methods, r=joshtriplett

Add #[must_use] to non-mutating verb methods

These are methods that could be misconstrued to mutate their input, similar to #89694. I gave each one a different custom message.

I wrote that `upgrade` and `downgrade` don't modify the input pointers. Logically they don't, but technically they do...

Parent issue: #89692

r? ```@joshtriplett```

2 years agoRollup merge of #89784 - Mark-Simulacrum:delete-cache-hit-tracking, r=petrochenkov
the8472 [Tue, 12 Oct 2021 12:53:09 +0000 (14:53 +0200)]
Rollup merge of #89784 - Mark-Simulacrum:delete-cache-hit-tracking, r=petrochenkov

Remove built-in query cache_hit tracking

This was already only enabled in debug_assertions builds. Generally, it seems
like most use cases that would use this could also use the -Zself-profile flag
which also tracks cache hits (in all builds), and so the extra cfg's and such
are not really necessary.

This is largely just a small cleanup though, which primarily is intended to make
other changes easier by avoiding the need to deal with this field.

2 years agoRollup merge of #89778 - jkugelman:must-use-as_type-conversions, r=joshtriplett
the8472 [Tue, 12 Oct 2021 12:53:08 +0000 (14:53 +0200)]
Rollup merge of #89778 - jkugelman:must-use-as_type-conversions, r=joshtriplett

Add #[must_use] to as_type conversions

Clippy missed these:

```rust
alloc::string::String   fn as_mut_str(&mut self) -> &mut str;
core::mem::NonNull<T>   unsafe fn as_uninit_mut<'a>(&mut self) -> &'a MaybeUninit<T>;
str                     unsafe fn as_bytes_mut(&mut self) -> &mut [u8];
str                     fn as_mut_ptr(&mut self) -> *mut u8;
```

Parent issue: #89692

r? ````@joshtriplett````

2 years agoMention Rust version in Vec::leak docs.
Mara Bos [Tue, 12 Oct 2021 12:50:46 +0000 (14:50 +0200)]
Mention Rust version in Vec::leak docs.

2 years agoUse Option::map_or instead of open coding it
LingMan [Tue, 12 Oct 2021 12:47:31 +0000 (14:47 +0200)]
Use Option::map_or instead of open coding it

2 years agoFilter unstable and doc hidden variants in usefulness checking
Devin Ragotzy [Sat, 18 Sep 2021 20:52:43 +0000 (16:52 -0400)]
Filter unstable and doc hidden variants in usefulness checking

Add test cases for unstable variants
Add test cases for doc hidden variants
Move is_doc_hidden to method on TyCtxt
Add unstable variants test to reachable-patterns ui test
Rename reachable-patterns -> omitted-patterns

2 years agoRemap ssa RealPredicate to llvm RealPredicate
Tomasz Miąsko [Tue, 12 Oct 2021 00:00:00 +0000 (00:00 +0000)]
Remap ssa RealPredicate to llvm RealPredicate

to avoid relying on the discriminant of the former for FFI purposes

2 years agoAuto merge of #89770 - jkugelman:must-use-from-and-into, r=joshtriplett
bors [Tue, 12 Oct 2021 09:43:37 +0000 (09:43 +0000)]
Auto merge of #89770 - jkugelman:must-use-from-and-into, r=joshtriplett

Add #[must_use] to From::from and Into::into

Risk of churn: **High**
Magic 8-Ball says: **Outlook not so good**

I figured I'd put this out there. If we don't do it now maybe we save it for a rainy day.

Parent issue: #89692

r? `@joshtriplett`

2 years agoAuto merge of #89769 - jkugelman:must-use-maybe-uninit-new, r=joshtriplett
bors [Tue, 12 Oct 2021 07:02:53 +0000 (07:02 +0000)]
Auto merge of #89769 - jkugelman:must-use-maybe-uninit-new, r=joshtriplett

Add #[must_use] to MaybeUninit::new

As discussed in https://github.com/rust-lang/rust/pull/89729#issuecomment-939775659.

Parent issue: #89692

r? `@joshtriplett`

2 years agoadd some more testcases
Marcel Hellwig [Mon, 11 Oct 2021 14:03:57 +0000 (16:03 +0200)]
add some more testcases

2 years agoAdd const_eval_select intrinsic
Deadbeef [Tue, 12 Oct 2021 05:06:37 +0000 (05:06 +0000)]
Add const_eval_select intrinsic

2 years agoUpdate cargo
Eric Huss [Tue, 12 Oct 2021 04:48:27 +0000 (21:48 -0700)]
Update cargo

2 years agoUpdate books
Eric Huss [Tue, 12 Oct 2021 04:10:05 +0000 (21:10 -0700)]
Update books

2 years agofix minor spelling error in Poll::ready docs
ast-ral [Tue, 12 Oct 2021 04:00:02 +0000 (21:00 -0700)]
fix minor spelling error in Poll::ready docs

2 years agoAuto merge of #88788 - falk-hueffner:speedup-int-log10-branchless, r=joshtriplett
bors [Tue, 12 Oct 2021 03:18:54 +0000 (03:18 +0000)]
Auto merge of #88788 - falk-hueffner:speedup-int-log10-branchless, r=joshtriplett

Speedup int log10 branchless

This is achieved with a branchless bit-twiddling implementation of the case x < 100_000, and using this as building block.

Benchmark on an Intel i7-8700K (Coffee Lake):

```
name                                   old ns/iter  new ns/iter  diff ns/iter   diff %  speedup
num::int_log::u8_log10_predictable     165          169                     4    2.42%   x 0.98
num::int_log::u8_log10_random          438          423                   -15   -3.42%   x 1.04
num::int_log::u8_log10_random_small    438          423                   -15   -3.42%   x 1.04
num::int_log::u16_log10_predictable    633          417                  -216  -34.12%   x 1.52
num::int_log::u16_log10_random         908          471                  -437  -48.13%   x 1.93
num::int_log::u16_log10_random_small   945          471                  -474  -50.16%   x 2.01
num::int_log::u32_log10_predictable    1,496        1,340                -156  -10.43%   x 1.12
num::int_log::u32_log10_random         1,076        873                  -203  -18.87%   x 1.23
num::int_log::u32_log10_random_small   1,145        874                  -271  -23.67%   x 1.31
num::int_log::u64_log10_predictable    4,005        3,171                -834  -20.82%   x 1.26
num::int_log::u64_log10_random         1,247        1,021                -226  -18.12%   x 1.22
num::int_log::u64_log10_random_small   1,265        921                  -344  -27.19%   x 1.37
num::int_log::u128_log10_predictable   39,667       39,579                -88   -0.22%   x 1.00
num::int_log::u128_log10_random        6,456        6,696                 240    3.72%   x 0.96
num::int_log::u128_log10_random_small  4,108        3,903                -205   -4.99%   x 1.05
```

Benchmark on an M1 Mac Mini:

```
name                                   old ns/iter  new ns/iter  diff ns/iter   diff %  speedup
num::int_log::u8_log10_predictable     143          130                   -13   -9.09%   x 1.10
num::int_log::u8_log10_random          375          325                   -50  -13.33%   x 1.15
num::int_log::u8_log10_random_small    376          325                   -51  -13.56%   x 1.16
num::int_log::u16_log10_predictable    500          322                  -178  -35.60%   x 1.55
num::int_log::u16_log10_random         794          405                  -389  -48.99%   x 1.96
num::int_log::u16_log10_random_small   1,035        405                  -630  -60.87%   x 2.56
num::int_log::u32_log10_predictable    1,144        894                  -250  -21.85%   x 1.28
num::int_log::u32_log10_random         832          786                   -46   -5.53%   x 1.06
num::int_log::u32_log10_random_small   832          787                   -45   -5.41%   x 1.06
num::int_log::u64_log10_predictable    2,681        2,057                -624  -23.27%   x 1.30
num::int_log::u64_log10_random         1,015        806                  -209  -20.59%   x 1.26
num::int_log::u64_log10_random_small   1,004        795                  -209  -20.82%   x 1.26
num::int_log::u128_log10_predictable   56,825       56,526               -299   -0.53%   x 1.01
num::int_log::u128_log10_random        9,056        8,861                -195   -2.15%   x 1.02
num::int_log::u128_log10_random_small  1,528        1,527                  -1   -0.07%   x 1.00
```

The 128 bit case remains ridiculously slow because llvm fails to optimize division by a constant 128-bit value to multiplications. This could be worked around but it seems preferable to fix this in llvm.

From u32 up, table lookup (like suggested [here](https://github.com/rust-lang/rust/issues/70887#issuecomment-881099813)) is still faster, but requires a hardware `leading_zeros` to be viable, and might clog up the cache.

2 years agoAdd #[must_use] to non-mutating verb methods
John Kugelman [Tue, 12 Oct 2021 00:40:03 +0000 (20:40 -0400)]
Add #[must_use] to non-mutating verb methods

2 years agoAdd #[must_use] to is_condition tests
John Kugelman [Tue, 12 Oct 2021 01:15:57 +0000 (21:15 -0400)]
Add #[must_use] to is_condition tests

A continuation of #89718.

2 years agoAuto merge of #89791 - matthiaskrgr:rollup-1lhxh5b, r=matthiaskrgr
bors [Tue, 12 Oct 2021 00:20:34 +0000 (00:20 +0000)]
Auto merge of #89791 - matthiaskrgr:rollup-1lhxh5b, r=matthiaskrgr

Rollup of 9 pull requests

Successful merges:

 - #89471 (Use Ancestory to check default fn in const impl instead of comparing idents)
 - #89643 (Fix inherent impl overlap check.)
 - #89651 (Add `Poll::ready` and revert stabilization of `task::ready!`)
 - #89675 (Re-use TypeChecker instead of passing around some of its fields )
 - #89710 (Add long explanation for error E0482)
 - #89756 (Greatly reduce amount of debuginfo compiled for bootstrap itself)
 - #89760 (Remove hack ignoring unused attributes for stage 0 std)
 - #89772 (Fix function-names test for GDB 10.1)
 - #89785 (Fix ICE when compiling nightly std/rustc on beta compiler)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoAdd #[must_use] to to_value conversions
John Kugelman [Mon, 11 Oct 2021 23:04:24 +0000 (19:04 -0400)]
Add #[must_use] to to_value conversions

2 years agoAdd #[must_use] to From::from and Into::into
John Kugelman [Mon, 11 Oct 2021 14:13:50 +0000 (10:13 -0400)]
Add #[must_use] to From::from and Into::into

2 years agoRollup merge of #89785 - nbdd0121:master, r=Mark-Simulacrum
Matthias Krüger [Mon, 11 Oct 2021 21:45:53 +0000 (23:45 +0200)]
Rollup merge of #89785 - nbdd0121:master, r=Mark-Simulacrum

Fix ICE when compiling nightly std/rustc on beta compiler

Fix #89775

#89479 renames a lot of diagnostic items, but it happens that the beta compiler assumes that there must be DefId with `rustc_diagnostic_item = "send_trait"`, causing an ICE when compiling stage 0 std or stage 1 compiler. So gate it with `cfg(bootstrap)`.

The unwrap is also removed, so that existence of the diagnostic item is not required. I ripgreped the code base and this seems the only place where `unwrap` is called on the return value of `get_diagnostic_item`.

2 years agoRollup merge of #89772 - michaelwoerister:fix-function-names-test-gdb, r=Mark-Simulacrum
Matthias Krüger [Mon, 11 Oct 2021 21:45:52 +0000 (23:45 +0200)]
Rollup merge of #89772 - michaelwoerister:fix-function-names-test-gdb, r=Mark-Simulacrum

Fix function-names test for GDB 10.1

This PR updates the test output in `src/test/debuginfo/function-names.rs` for GDB 10.1.

This should fix issue https://github.com/rust-lang/rust/issues/89750 -- but not the underlying problem of CI ignoring tests if not viable debugger happens to be present.

2 years agoRollup merge of #89760 - jyn514:remove-incremental-hack, r=Mark-Simulacrum
Matthias Krüger [Mon, 11 Oct 2021 21:45:51 +0000 (23:45 +0200)]
Rollup merge of #89760 - jyn514:remove-incremental-hack, r=Mark-Simulacrum

Remove hack ignoring unused attributes for stage 0 std

This seems to no longer be giving spurious errors when incremental is
enabled.

Closes https://github.com/rust-lang/rust/issues/58633.

2 years agoRollup merge of #89756 - jyn514:bootstrap-times, r=Mark-Simulacrum
Matthias Krüger [Mon, 11 Oct 2021 21:45:51 +0000 (23:45 +0200)]
Rollup merge of #89756 - jyn514:bootstrap-times, r=Mark-Simulacrum

Greatly reduce amount of debuginfo compiled for bootstrap itself

Rather than compiling rustbuild and all its dependencies with
`debuginfo=2`, this compiles dependencies without debuginfo and
rustbuild with `debuginfo=1`. On my laptop, this brings compile times
down from ~1:20 to ~1:05.

See also https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/async.20in.20bootstrap.3F/near/254847594.

r? ``@Mark-Simulacrum``

2 years agoRollup merge of #89710 - sireliah:e0482, r=GuillaumeGomez
Matthias Krüger [Mon, 11 Oct 2021 21:45:50 +0000 (23:45 +0200)]
Rollup merge of #89710 - sireliah:e0482, r=GuillaumeGomez

Add long explanation for error E0482

This is longer explanation for error E0482 in the #61137.

Please take a look and leave some feedback!

2 years agoRollup merge of #89675 - oli-obk:type_checker, r=davidtwco
Matthias Krüger [Mon, 11 Oct 2021 21:45:49 +0000 (23:45 +0200)]
Rollup merge of #89675 - oli-obk:type_checker, r=davidtwco

Re-use TypeChecker instead of passing around some of its fields

In the future (for lazy TAIT) we will need more of its fields, but even ignoring that, this change seems reasonable on its own to me.

2 years agoRollup merge of #89651 - ibraheemdev:poll-ready, r=dtolnay
Matthias Krüger [Mon, 11 Oct 2021 21:45:48 +0000 (23:45 +0200)]
Rollup merge of #89651 - ibraheemdev:poll-ready, r=dtolnay

Add `Poll::ready` and revert stabilization of `task::ready!`

This PR adds an inherent `ready` method to `Poll` that can be used with the `?` operator as an alternative to the `task::ready!` macro:
```rust
let val = ready!(fut.poll(cx));
let val = fut.poll(cx).ready()?;
```

I think this form is a nice, non-breaking middle ground between changing the `impl Try for Poll`, and adding a separate macro. It looks better than `ready!` in my opinion, and it composes well:

```rust
let elem = ready!(fut.poll(cx)).pop().unwrap();
let elem = fut.poll(cx).ready()?.pop().unwrap();
```

The planned stabilization of `ready!` in 1.56 has been reverted because I think this alternate approach is worth considering.

r? rust-lang/libs

2 years agoRollup merge of #89643 - cjgillot:overlap, r=matthewjasper
Matthias Krüger [Mon, 11 Oct 2021 21:45:46 +0000 (23:45 +0200)]
Rollup merge of #89643 - cjgillot:overlap, r=matthewjasper

Fix inherent impl overlap check.

The current implementation of the overlap check was slightly buggy, and unified the wrong connected component in the `ids.len() <= 1` case. This became visible in another PR which changed the iteration order of items.

r? ``@matthewjasper`` since you reviewed the other PR.

2 years agoRollup merge of #89471 - nbdd0121:const3, r=fee1-dead
Matthias Krüger [Mon, 11 Oct 2021 21:45:46 +0000 (23:45 +0200)]
Rollup merge of #89471 - nbdd0121:const3, r=fee1-dead

Use Ancestory to check default fn in const impl instead of comparing idents

Fixes https://rust-lang.zulipchat.com/#narrow/stream/146212-t-compiler.2Fconst-eval/topic/Const.20trait.20impl.20inside.20macro

2 years agoAuto merge of #89648 - nbdd0121:issue-89606, r=nikomatsakis
bors [Mon, 11 Oct 2021 21:39:11 +0000 (21:39 +0000)]
Auto merge of #89648 - nbdd0121:issue-89606, r=nikomatsakis

Ignore type of projections for upvar capturing

Fix #89606

Ignore type of projections for upvar capturing. Originally HashMap is used, and the hash/eq implementation of Place takes the type of projections into account. These types may differ by lifetime which causes #89606 to ICE.

I originally considered erasing regions but `place.ty()` is used when creating upvar tuple type, more than just serving as a key type, so I switched to a linear comparison with custom eq (`compare_place_ignore_ty`) instead.

r? `@wesleywiser`

`@rustbot` label +T-compiler

2 years agouse fold instead of try_fold now that .by_ref().next() has been inlined
The8472 [Mon, 11 Oct 2021 21:36:04 +0000 (23:36 +0200)]
use fold instead of try_fold now that .by_ref().next() has been inlined

2 years agoRemove built-in cache_hit tracking
Mark Rousskov [Mon, 11 Oct 2021 19:49:40 +0000 (15:49 -0400)]
Remove built-in cache_hit tracking

This was already only enabled in debug_assertions builds. Generally, it seems
like most use cases that would use this could also use the -Zself-profile flag
which also tracks cache hits (in all builds), and so the extra cfg's and such
are not really necessary.

This is largely just a small cleanup though, which primarily is intended to make
other changes easier by avoiding the need to deal with this field.

2 years agoadd slice::swap tests
Ibraheem Ahmed [Mon, 11 Oct 2021 20:13:17 +0000 (16:13 -0400)]
add slice::swap tests

2 years agoimprove slice::swap panic message
Ibraheem Ahmed [Mon, 11 Oct 2021 20:12:43 +0000 (16:12 -0400)]
improve slice::swap panic message

2 years agouse `swap_unchecked` in `slice::reverse`
ibraheemdev [Wed, 1 Sep 2021 01:00:30 +0000 (21:00 -0400)]
use `swap_unchecked` in `slice::reverse`

2 years agoenable `slice_swap_unchecked` feature in doc test
ibraheemdev [Tue, 31 Aug 2021 17:25:09 +0000 (13:25 -0400)]
enable `slice_swap_unchecked` feature in doc test

2 years agoadd `slice::swap_unchecked`
ibraheemdev [Tue, 31 Aug 2021 16:59:44 +0000 (12:59 -0400)]
add `slice::swap_unchecked`

2 years agoFix ICE 89775
Gary Guo [Mon, 11 Oct 2021 19:52:36 +0000 (20:52 +0100)]
Fix ICE 89775

2 years agoClarify the error descriptions
sireliah [Sun, 10 Oct 2021 12:58:12 +0000 (14:58 +0200)]
Clarify the error descriptions

2 years agorustdoc: update noto sans kr
Shinwoo Park [Mon, 11 Oct 2021 19:47:34 +0000 (04:47 +0900)]
rustdoc: update noto sans kr

2 years agoAdd missing words in `Infallible` docs
Wilfred Hughes [Mon, 11 Oct 2021 19:26:27 +0000 (12:26 -0700)]
Add missing words in `Infallible` docs

This sentence was previously incomplete.

2 years agoAdd library tracking issue for poll_ready feature
David Tolnay [Mon, 11 Oct 2021 19:17:41 +0000 (12:17 -0700)]
Add library tracking issue for poll_ready feature

2 years agoRemove task::ready! from 1.56.0 release notes
David Tolnay [Mon, 11 Oct 2021 19:06:32 +0000 (12:06 -0700)]
Remove task::ready! from 1.56.0 release notes

2 years agoUpdate library/core/src/mem/maybe_uninit.rs
John Kugelman [Mon, 11 Oct 2021 18:46:08 +0000 (14:46 -0400)]
Update library/core/src/mem/maybe_uninit.rs

Co-authored-by: Josh Triplett <josh@joshtriplett.org>
2 years agoAdd #[must_use] to as_type conversions
John Kugelman [Mon, 11 Oct 2021 17:57:38 +0000 (13:57 -0400)]
Add #[must_use] to as_type conversions

2 years agoEdit explanation of test for nested type ascriptions
pierwill [Mon, 11 Oct 2021 17:56:55 +0000 (12:56 -0500)]
Edit explanation of test for nested type ascriptions

Closes #88233

2 years agoSplit impl-with-default-fn test into a pass test and a fail test
Gary Guo [Mon, 11 Oct 2021 17:20:20 +0000 (18:20 +0100)]
Split impl-with-default-fn test into a pass test and a fail test

2 years agoUse Ancestory to check default fn in const impl instead of comparing idents
Gary Guo [Sat, 2 Oct 2021 18:02:22 +0000 (19:02 +0100)]
Use Ancestory to check default fn in const impl instead of comparing idents

2 years agoAuto merge of #83908 - Flying-Toast:master, r=davidtwco
bors [Mon, 11 Oct 2021 17:12:14 +0000 (17:12 +0000)]
Auto merge of #83908 - Flying-Toast:master, r=davidtwco

Add enum_intrinsics_non_enums lint

There is a clippy lint to prevent calling [`mem::discriminant`](https://doc.rust-lang.org/std/mem/fn.discriminant.html) with a non-enum type. I think the lint is worthy of being included in rustc, given that `discriminant::<T>()` where `T` is a non-enum has an unspecified return value, and there are no valid use cases where you'd actually want this.

I've also made the lint check [variant_count](https://doc.rust-lang.org/core/mem/fn.variant_count.html) (#73662).

closes #83899

2 years agoinline next() on &mut Iterator impl
The8472 [Mon, 11 Oct 2021 15:50:03 +0000 (17:50 +0200)]
inline next() on &mut Iterator impl

2 years agoFix function-names test for GDB 10.1
Michael Woerister [Mon, 11 Oct 2021 15:20:45 +0000 (17:20 +0200)]
Fix function-names test for GDB 10.1

2 years agoAuto merge of #89767 - GuillaumeGomez:rollup-sczixhk, r=GuillaumeGomez
bors [Mon, 11 Oct 2021 14:16:15 +0000 (14:16 +0000)]
Auto merge of #89767 - GuillaumeGomez:rollup-sczixhk, r=GuillaumeGomez

Rollup of 7 pull requests

Successful merges:

 - #89655 (bootstrap: don't use `--merges` to look for commit hashes for downloading artifacts)
 - #89726 (Add #[must_use] to alloc constructors)
 - #89729 (Add #[must_use] to core and std constructors)
 - #89743 (Fix RUSTC_LOG handling)
 - #89753 (Add #[must_use] to from_value conversions)
 - #89754 (Cleanup .item-table CSS)
 - #89761 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoAdd #[must_use] to MaybeUninit::new
John Kugelman [Mon, 11 Oct 2021 14:03:55 +0000 (10:03 -0400)]
Add #[must_use] to MaybeUninit::new

2 years agoRollup merge of #89761 - lnicola:rust-analyzer-2021-10-11, r=lnicola
Guillaume Gomez [Mon, 11 Oct 2021 12:11:46 +0000 (14:11 +0200)]
Rollup merge of #89761 - lnicola:rust-analyzer-2021-10-11, r=lnicola

:arrow_up: rust-analyzer

r? ``@ghost``

2 years agoRollup merge of #89754 - dns2utf8:rustdoc_cleanup_css, r=GuillaumeGomez
Guillaume Gomez [Mon, 11 Oct 2021 12:11:46 +0000 (14:11 +0200)]
Rollup merge of #89754 - dns2utf8:rustdoc_cleanup_css, r=GuillaumeGomez

Cleanup .item-table CSS

The main table-like element must be `display: table;`

r? `@GuillaumeGomez`

2 years agoRollup merge of #89753 - jkugelman:must-use-from_value-conversions, r=joshtriplett
Guillaume Gomez [Mon, 11 Oct 2021 12:11:45 +0000 (14:11 +0200)]
Rollup merge of #89753 - jkugelman:must-use-from_value-conversions, r=joshtriplett

Add #[must_use] to from_value conversions

I added two methods to the list myself. Clippy did not flag them because they take `mut` args, but neither modifies their argument.

```rust
core::str           const unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str;
std::ffi::CString   unsafe fn from_raw(ptr: *mut c_char) -> CString;
```

I put a custom note on `from_raw`:

```rust
#[must_use = "call `drop(from_raw(ptr))` if you intend to drop the `CString`"]
pub unsafe fn from_raw(ptr: *mut c_char) -> CString {
```

Parent issue: #89692

r? ``@joshtriplett``

2 years agoRollup merge of #89743 - matthewjasper:env-log-fix, r=jyn514
Guillaume Gomez [Mon, 11 Oct 2021 12:11:44 +0000 (14:11 +0200)]
Rollup merge of #89743 - matthewjasper:env-log-fix, r=jyn514

Fix RUSTC_LOG handling

Rustc was incorrectly reading the value of `RUSTC_LOG` as the environment vairable with the logging configuration, rather than the logging configuration itself.

2 years agoRollup merge of #89729 - jkugelman:must-use-core-std-constructors, r=joshtriplett
Guillaume Gomez [Mon, 11 Oct 2021 12:11:43 +0000 (14:11 +0200)]
Rollup merge of #89729 - jkugelman:must-use-core-std-constructors, r=joshtriplett

Add #[must_use] to core and std constructors

Parent issue: #89692

r? ``@joshtriplett``

2 years agoRollup merge of #89726 - jkugelman:must-use-alloc-constructors, r=joshtriplett
Guillaume Gomez [Mon, 11 Oct 2021 12:11:42 +0000 (14:11 +0200)]
Rollup merge of #89726 - jkugelman:must-use-alloc-constructors, r=joshtriplett

Add #[must_use] to alloc constructors

Added `#[must_use]`. to the various forms of `new`, `pin`, and `with_capacity` in the `alloc` crate. No extra explanations given as I couldn't think of anything useful to add.

I figure this deserves extra scrutiny compared to the other PRs I've done so far. In particular:

* The 4 `pin`/`pin_in` methods I touched. Are there legitimate use cases for pinning and not using the result? Pinning's a difficult concept I'm not very comfortable with.
* `Box`'s constructors. Do people ever create boxes just for the side effects... allocating or zeroing out memory?

Parent issue: #89692

r? ``@joshtriplett``

2 years agoRollup merge of #89655 - tlyu:find-non-merge-commits, r=jyn514
Guillaume Gomez [Mon, 11 Oct 2021 12:11:41 +0000 (14:11 +0200)]
Rollup merge of #89655 - tlyu:find-non-merge-commits, r=jyn514

bootstrap: don't use `--merges` to look for commit hashes for downloading artifacts

Shallow clones (and possibly worktrees, though I can't seem to reproduce the problem there) can cause `git rev-list --merges` to falsely return no results, even if a merge commit is present. Stop using the `--merges` option when looking for commit hashes that have build artifacts. `--first-parent` and `--author=bors@rust-lang.org` should be sufficient.

Also exit with an error if the configuration asks for artifacts to be downloaded and we can't determine an appropriate commit hash to use to download artifacts.

Fixes #87890.

r? ``@jyn514``
``@rustbot`` label +A-rustbuild +A-contributor-roadblock

2 years agoAuto merge of #89709 - clemenswasser:apply_clippy_suggestions_2, r=petrochenkov
bors [Mon, 11 Oct 2021 11:14:47 +0000 (11:14 +0000)]
Auto merge of #89709 - clemenswasser:apply_clippy_suggestions_2, r=petrochenkov

Apply clippy suggestions for rustc and core

2 years agoCleanup .item-table CSS
Stefan Schindler [Sun, 10 Oct 2021 22:38:56 +0000 (00:38 +0200)]
Cleanup .item-table CSS

2 years agoDeprecate mem_discriminant_non_enum
flip1995 [Mon, 11 Oct 2021 08:10:16 +0000 (10:10 +0200)]
Deprecate mem_discriminant_non_enum

This lint has been uplifted and is now included in
enum_intrinsics_non_enums.

2 years agoAdd enum_intrinsics_non_enums lint
Flying-Toast [Sat, 31 Jul 2021 16:14:30 +0000 (12:14 -0400)]
Add enum_intrinsics_non_enums lint

2 years agoAuto merge of #89755 - jkugelman:must-use-conversions-that-move-self, r=joshtriplett
bors [Mon, 11 Oct 2021 07:27:44 +0000 (07:27 +0000)]
Auto merge of #89755 - jkugelman:must-use-conversions-that-move-self, r=joshtriplett

Add #[must_use] to conversions that move self

Everything here got the same message. Is the wording okay?

```rust
#[must_use = "`self` will be dropped if the result is not used"]
```

I want to draw attention to these methods in particular:

```rust
alloc::sync::Arc<MaybeUninit<T>>     unsafe fn assume_init(self) -> Arc<T>;
alloc::sync::Arc<[MaybeUninit<T>]>   unsafe fn assume_init(self) -> Arc<[T]>;
core::pin::Pin<&'a mut T>            const fn into_ref(self) -> Pin<&'a T>;
core::pin::Pin<&'a mut T>            const fn get_mut(self) -> &'a mut T;
core::pin::Pin<&'a mut T>            const unsafe fn get_unchecked_mut(self) -> &'a mut T;
core::pin::Pin<&'a mut T>            unsafe fn map_unchecked_mut(self, func: F) -> Pin<&'a mut U>;
core::pin::Pin<&'a mut Pin<P>>       fn as_deref_mut(self) -> Pin<&'a mut P::Target>;
```

Parent issue: #89692

r? `@joshtriplett`

2 years ago:arrow_up: rust-analyzer
Laurențiu Nicola [Mon, 11 Oct 2021 07:01:39 +0000 (10:01 +0300)]
:arrow_up: rust-analyzer

2 years agoRemove unnecessary variable
Clemens Wasser [Mon, 11 Oct 2021 06:11:30 +0000 (08:11 +0200)]
Remove unnecessary variable

2 years agoRemove hack ignoring unused attributes for stage 0 std
Joshua Nelson [Mon, 11 Oct 2021 04:50:12 +0000 (04:50 +0000)]
Remove hack ignoring unused attributes for stage 0 std

This seems to no longer be giving spurious errors when incremental is
enabled.

2 years agoAuto merge of #89597 - michaelwoerister:improve-vtable-debuginfo, r=wesleywiser
bors [Mon, 11 Oct 2021 04:31:47 +0000 (04:31 +0000)]
Auto merge of #89597 - michaelwoerister:improve-vtable-debuginfo, r=wesleywiser

Create more accurate debuginfo for vtables.

Before this PR all vtables would have the same name (`"vtable"`) in debuginfo. Now they get an unambiguous name that identifies the implementing type and the trait that is being implemented.

This is only one of several possible improvements:
- This PR describes vtables as arrays of `*const u8` pointers. It would nice to describe them as structs where function pointer is represented by a field with a name indicative of the method it maps to. However, this requires coming up with a naming scheme that avoids clashes between methods with the same name (which is possible if the vtable contains multiple traits).
- The PR does not update the debuginfo we generate for the vtable-pointer field in a fat `dyn` pointer. Right now there does not seem to be an easy way of getting ahold of a vtable-layout without also knowing the concrete self-type of a trait object.

r? `@wesleywiser`

2 years agoUse shallow clones for submodules
Joshua Nelson [Mon, 11 Oct 2021 03:34:10 +0000 (22:34 -0500)]
Use shallow clones for submodules

This reduces the amount of git history downloaded from ~67M to ~11M.

2 years agoGreatly reduce amount of debuginfo compiled for bootstrap itself
Joshua Nelson [Mon, 11 Oct 2021 02:16:01 +0000 (21:16 -0500)]
Greatly reduce amount of debuginfo compiled for bootstrap itself

Rather than compiling rustbuild and all its dependencies with
`debuginfo=2`, this compiles dependencies without debuginfo and
rustbuild with `debuginfo=1`. On my laptop, this brings compile times
down from ~1:20 to ~1:05.

2 years agoAuto merge of #89752 - matthiaskrgr:rollup-v4fgmwg, r=matthiaskrgr
bors [Mon, 11 Oct 2021 01:06:26 +0000 (01:06 +0000)]
Auto merge of #89752 - matthiaskrgr:rollup-v4fgmwg, r=matthiaskrgr

Rollup of 6 pull requests

Successful merges:

 - #89579 (Add regression test for issue 80108)
 - #89632 (Fix docblock code display on mobile)
 - #89691 (Move `DebuggerCommands` and `check_debugger_output` to a separate module)
 - #89707 (Apply clippy suggestions for std)
 - #89722 (Fix spelling: Cannonical -> Canonical)
 - #89736 (Remove unused CSS rule)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

2 years agoAdd #[must_use] to conversions that move self
John Kugelman [Sun, 10 Oct 2021 23:50:52 +0000 (19:50 -0400)]
Add #[must_use] to conversions that move self

2 years agoAdd #[must_use] to from_value conversions
John Kugelman [Sun, 10 Oct 2021 22:22:40 +0000 (18:22 -0400)]
Add #[must_use] to from_value conversions

2 years agoRollup merge of #89736 - GuillaumeGomez:rm-unused-css-rule, r=dns2utf8
Matthias Krüger [Sun, 10 Oct 2021 22:34:41 +0000 (00:34 +0200)]
Rollup merge of #89736 - GuillaumeGomez:rm-unused-css-rule, r=dns2utf8

Remove unused CSS rule

As you can see in the firefox devtools:

![Screenshot from 2021-10-10 14-28-08](https://user-images.githubusercontent.com/3050060/136695689-16c77ceb-b1ab-40df-963a-048f2258e217.png)

It needs the display to be `grid` or `inline-grid`, which isn't the case.

r? `@dns2utf8`

2 years agoRollup merge of #89722 - jkugelman:cannonical-typo, r=joshtriplett
Matthias Krüger [Sun, 10 Oct 2021 22:34:40 +0000 (00:34 +0200)]
Rollup merge of #89722 - jkugelman:cannonical-typo, r=joshtriplett

Fix spelling: Cannonical -> Canonical

2 years agoRollup merge of #89707 - clemenswasser:apply_clippy_suggestions, r=Mark-Simulacrum
Matthias Krüger [Sun, 10 Oct 2021 22:34:39 +0000 (00:34 +0200)]
Rollup merge of #89707 - clemenswasser:apply_clippy_suggestions, r=Mark-Simulacrum

Apply clippy suggestions for std

2 years agoRollup merge of #89691 - Nicholas-Baron:debugger_commands, r=Mark-Simulacrum
Matthias Krüger [Sun, 10 Oct 2021 22:34:38 +0000 (00:34 +0200)]
Rollup merge of #89691 - Nicholas-Baron:debugger_commands, r=Mark-Simulacrum

Move `DebuggerCommands` and `check_debugger_output` to a separate module

Work towards #89475.

As part of this move, the public functions were changed to return `Result`. This is so that the error handling that initially took `&self: TestCx` can still use that `TestCx`.

2 years agoRollup merge of #89632 - GuillaumeGomez:fix-docblock-code, r=jsha
Matthias Krüger [Sun, 10 Oct 2021 22:34:37 +0000 (00:34 +0200)]
Rollup merge of #89632 - GuillaumeGomez:fix-docblock-code, r=jsha

Fix docblock code display on mobile

Fixes https://github.com/rust-lang/rust/issues/89618.

Before:

![Screenshot from 2021-10-07 12-01-37](https://user-images.githubusercontent.com/3050060/136363624-72bedddd-b45e-48a0-89b4-6563612f8677.png)

After:

![Screenshot from 2021-10-07 20-17-21](https://user-images.githubusercontent.com/3050060/136440704-fa9ffa68-8e94-46a7-b556-c41aa5153750.png)

r? `@jsha`

2 years agoRollup merge of #89579 - workingjubilee:regression-test-80108, r=Mark-Simulacrum
Matthias Krüger [Sun, 10 Oct 2021 22:34:37 +0000 (00:34 +0200)]
Rollup merge of #89579 - workingjubilee:regression-test-80108, r=Mark-Simulacrum

Add regression test for issue 80108

Closes #80108

2 years agoAuto merge of #89541 - workingjubilee:abbrev-shufvec-t, r=Mark-Simulacrum
bors [Sun, 10 Oct 2021 22:25:49 +0000 (22:25 +0000)]
Auto merge of #89541 - workingjubilee:abbrev-shufvec-t, r=Mark-Simulacrum

Cleanup src/test/ui/{simd,simd-intrinsic}

Initial motivation was to simplify a huge macro expansion using a tuple, since we can just use an array in `#[repr(simd)]` now for the same result. But also, several tests were going unnoticed during development of SIMD intrinsics because people kept looking in the wrong directory, and many are basically run-pass vs. build-fail versions of the same tests, so let's keep them close together and simplify their names, so they're easier to sift through.

2 years agoAdd regression test for issue 80108
Jubilee Young [Tue, 5 Oct 2021 22:46:19 +0000 (15:46 -0700)]
Add regression test for issue 80108