]>
git.lizzy.rs Git - rust.git/log
bors[bot] [Mon, 29 Oct 2018 10:44:16 +0000 (10:44 +0000)]
Merge #3379
3379: dependencies: bump compiletest-rs from git to 0.3.16 r=phansch a=matthiaskrgr
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
Matthias Krüger [Mon, 29 Oct 2018 08:52:49 +0000 (09:52 +0100)]
dependencies: bump compiletest-rs from git to 0.3.16
bors[bot] [Sun, 28 Oct 2018 22:52:21 +0000 (22:52 +0000)]
Merge #3373
3373: UI test cleanup: Extract unnecessary_operation tests r=matthiaskrgr a=phansch
cc #2038
Co-authored-by: Philipp Hansch <dev@phansch.net>
bors[bot] [Sun, 28 Oct 2018 22:19:11 +0000 (22:19 +0000)]
Merge #3372
3372: UI test cleanup: Extract explicit_counter_loop tests r=matthiaskrgr a=phansch
cc #2038
Co-authored-by: Philipp Hansch <dev@phansch.net>
Philipp Hansch [Sat, 27 Oct 2018 17:16:43 +0000 (19:16 +0200)]
UI test cleanup: Extract explicit_counter_loop tests
Philipp Hansch [Sat, 27 Oct 2018 17:31:47 +0000 (19:31 +0200)]
UI test cleanup: Extract unnecessary_operation tests
bors[bot] [Sun, 28 Oct 2018 17:13:34 +0000 (17:13 +0000)]
Merge #3217 #3366
3217: Fix string_lit_as_bytes lint for macros r=phansch a=yaahallo
Prior to this change, string_lit_as_bytes would trigger for constructs
like `include_str!("filename").as_bytes()` and would recommend fixing it
by rewriting as `binclude_str!("filename")`.
This change updates the lint to act as an EarlyLintPass lint. It then
differentiates between string literals and macros that have bytes
yielding alternatives.
Closes #3205
3366: Don't expand macros in some suggestions r=oli-obk a=phansch
Fixes #1148
Fixes #1628
Fixes #2455
Fixes #3023
Fixes #3333
Fixes #3360
Co-authored-by: Jane Lusby <jlusby42@gmail.com>
Co-authored-by: Philipp Hansch <dev@phansch.net>
bors[bot] [Sun, 28 Oct 2018 16:54:09 +0000 (16:54 +0000)]
Merge #3364
3364: simplify ci scripts r=phansch a=matthiaskrgr
This makes it easier to flip the switch on pedantic lints on the clippy codebase.
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
Philipp Hansch [Sun, 28 Oct 2018 16:51:09 +0000 (17:51 +0100)]
Merge pull request #3371 from matthiaskrgr/temp_breakage_fix
merge various PRs to make CI green again
Matthias Krüger [Sun, 28 Oct 2018 16:14:39 +0000 (17:14 +0100)]
appveyor: use rustc nightly instead of master
Matthias Krüger [Sun, 28 Oct 2018 15:56:57 +0000 (16:56 +0100)]
Merge branch 'compiletest' into temp_breakage_fix
Matthias Krüger [Sun, 28 Oct 2018 15:52:38 +0000 (16:52 +0100)]
pin compiletest dependency to git version (
12c980f47971b5ba6beb7cb2ffebf8b32f6766ea ) while we are waiting for a new release
Matthias Krüger [Sun, 28 Oct 2018 15:55:33 +0000 (16:55 +0100)]
Merge remote-tracking branch 'phansch/disable_master_build' into temp_breakage_fix
Matthias Krüger [Sun, 28 Oct 2018 11:50:32 +0000 (12:50 +0100)]
rustup: fix build with rustc 1.31.0-nightly (
cae6efc37 2018-10-27)
Philipp Hansch [Sun, 28 Oct 2018 07:11:18 +0000 (08:11 +0100)]
Disable rust master toolchain build temporarily
Philipp Hansch [Sat, 27 Oct 2018 13:37:56 +0000 (15:37 +0200)]
Don't expand macro in or_fun_call suggestion
Philipp Hansch [Sat, 27 Oct 2018 12:45:02 +0000 (14:45 +0200)]
Don't expand macro in single_match suggestion
Philipp Hansch [Sat, 27 Oct 2018 09:01:27 +0000 (11:01 +0200)]
Don't expand macro in identity_conversion suggestion
Matthias Krüger [Fri, 26 Oct 2018 18:00:49 +0000 (20:00 +0200)]
slightly simplify integration tests
Matthias Krüger [Fri, 26 Oct 2018 17:58:50 +0000 (19:58 +0200)]
simplify ci base-tests
Jane Lusby [Fri, 26 Oct 2018 16:10:20 +0000 (09:10 -0700)]
fix: correctly reconstruct raw strings
Jane Lusby [Wed, 24 Oct 2018 15:49:39 +0000 (11:49 -0400)]
fix: extra semicolon, only create callsite once
Jane Lusby [Fri, 5 Oct 2018 16:06:05 +0000 (09:06 -0700)]
Fix string_lit_as_bytes lint for macros
Prior to this change, string_lit_as_bytes would trigger for constructs
like `include_str!("filename").as_bytes()` and would recommend fixing it
by rewriting as `binclude_str!("filename")`.
This change updates the lint to act as an EarlyLintPass lint. It then
differentiates between string literals and macros that have bytes
yielding alternatives.
Closes #3205
bors[bot] [Fri, 26 Oct 2018 10:36:43 +0000 (10:36 +0000)]
Merge #3355
3355: Lint to remove redundant `clone()`s r=oli-obk a=sinkuu
This PR adds lint `redundant_clone`. It suggests to remove redundant `clone()` that clones a owned value that will be dropped without any usage after that.
Real-world example: https://github.com/rust-lang/rust/compare/
7b0735a ..sinkuu:redundant_clone2
Co-authored-by: Shotaro Yamada <sinkuu@sinkuu.xyz>
bors[bot] [Fri, 26 Oct 2018 09:37:22 +0000 (09:37 +0000)]
Merge #3359
3359: ci: allow all branches except trying.tmp and staging.tmp to be built r=phansch a=matthiaskrgr
r? @flip1995
The problem was that with the current configuration, if I made a branch `feature1` and pushed it to travis to have it checked before making a PR, travis would skip it because it only built the 3 branches that were specified when setting up bors.
The change allows all branch names to be build by default again, except for travis.tmp.
The gh-pages branch is skipped as per travis-ci defaults: https://docs.travis-ci.com/user/customizing-the-build/#safelisting-or-blocklisting-branches
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
bors[bot] [Fri, 26 Oct 2018 08:48:12 +0000 (08:48 +0000)]
Merge #3357
3357: Check existential types in `use_self` r=oli-obk a=HMPerson1
Fixes #3231
Co-authored-by: HMPerson1 <hmperson1@gmail.com>
bors[bot] [Fri, 26 Oct 2018 08:01:48 +0000 (08:01 +0000)]
Merge #3362
3362: travis: work around temporary test failure due to rustc crashing on hyper r=phansch a=matthiaskrgr
Upstream ticket: https://github.com/rust-lang/rust/issues/55376
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
Matthias Krüger [Fri, 26 Oct 2018 07:57:20 +0000 (09:57 +0200)]
travis: work around temporary test failure due to rustc crashing on hyper.
Upstream ticket: https://github.com/rust-lang/rust/issues/55376
Matthias Krüger [Thu, 25 Oct 2018 18:14:39 +0000 (20:14 +0200)]
ci: allow all branches except trying.tmp and staging.tmp to be built
Shotaro Yamada [Thu, 25 Oct 2018 18:07:29 +0000 (03:07 +0900)]
Move in_macro check
Shotaro Yamada [Thu, 25 Oct 2018 16:27:28 +0000 (01:27 +0900)]
Use BasicBlockData::terminator
Shotaro Yamada [Thu, 25 Oct 2018 13:02:46 +0000 (22:02 +0900)]
Refactor
Shotaro Yamada [Thu, 25 Oct 2018 12:08:32 +0000 (21:08 +0900)]
Use lint_root
Shotaro Yamada [Thu, 25 Oct 2018 11:33:40 +0000 (20:33 +0900)]
Implement visit_basic_block_data
Shotaro Yamada [Thu, 25 Oct 2018 05:59:14 +0000 (14:59 +0900)]
update_references indexing_slicing
Shotaro Yamada [Wed, 24 Oct 2018 13:57:31 +0000 (22:57 +0900)]
Run update_lints
Shotaro Yamada [Tue, 23 Oct 2018 07:01:45 +0000 (16:01 +0900)]
Add redundant_clone lint
bors[bot] [Thu, 25 Oct 2018 11:43:09 +0000 (11:43 +0000)]
Merge #3358
3358: Revert "new_ret_no_self: add sample from #3313 to Known Problems section." r=oli-obk a=matthiaskrgr
This reverts commit
fd2f6dd3824b32af031d19830b6ccdc732dd3dfc .
Issue #3313 has been fixed.
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
Matthias Krüger [Thu, 25 Oct 2018 11:37:50 +0000 (13:37 +0200)]
Revert "new_ret_no_self: add sample from #3313 to Known Problems section."
This reverts commit
fd2f6dd3824b32af031d19830b6ccdc732dd3dfc .
Issue #3313 has been fixed.
bors[bot] [Thu, 25 Oct 2018 09:38:00 +0000 (09:38 +0000)]
Merge #3331
3331: Disable arithmetic lints in constant items r=oli-obk a=pengowen123
Currently this will not catch cases in associated constants. I'm not sure whether checking spans is the best way to solve this issue, but I don't think it will cause any problems.
Fixes #1858
Co-authored-by: Owen Sanchez <pengowen816@gmail.com>
bors[bot] [Thu, 25 Oct 2018 06:43:32 +0000 (06:43 +0000)]
Merge #3346
3346: Add lint for calling `mem::discriminant` on a non-enum type r=flip1995 a=HMPerson1
Also, if the type is a reference to an enum, we suggest removing `&`s and/or dereferencing.
Fixes #3342
Co-authored-by: HMPerson1 <hmperson1@gmail.com>
Co-authored-by: Philipp Krones <hello@philkrones.com>
HMPerson1 [Thu, 25 Oct 2018 02:27:47 +0000 (22:27 -0400)]
Add tests for more than one level of reference
HMPerson1 [Sun, 21 Oct 2018 19:23:51 +0000 (15:23 -0400)]
Add test case for `mem::discriminant` inside a macro
Philipp Krones [Sun, 21 Oct 2018 19:27:01 +0000 (15:27 -0400)]
Add `Applicability`
HMPerson1 [Sun, 21 Oct 2018 03:46:13 +0000 (23:46 -0400)]
Add lint for calling `mem::discriminant` on a non-enum type
HMPerson1 [Thu, 25 Oct 2018 03:28:54 +0000 (23:28 -0400)]
Check existential types in `use_self`
Owen Sanchez [Thu, 18 Oct 2018 04:20:36 +0000 (21:20 -0700)]
Disable arithmetic lints in constant items
bors[bot] [Wed, 24 Oct 2018 21:17:43 +0000 (21:17 +0000)]
Merge #3312
3312: OUT_OF_BOUNDS_INDEXING false negative r=phansch a=JoshMcguigan
fixes #3102
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>
bors[bot] [Wed, 24 Oct 2018 15:25:12 +0000 (15:25 +0000)]
Merge #3356
3356: Fix warnings introduced by #3349 r=flip1995 a=flip1995
I missed these warnings during review, should have checked the Travis log first.
Co-authored-by: flip1995 <hello@philkrones.com>
bors[bot] [Wed, 24 Oct 2018 14:42:40 +0000 (14:42 +0000)]
Merge #3338
3338: new_ret_no_self false positives r=flip1995 a=JoshMcguigan
~~WORK IN PROGRESS~~
I plan to fix all of the false positives in #3313 in this PR, but I wanted to open it now to start gathering feedback.
In this first commit, I've updated the lint to allow tuple return types as long as `Self` shows up at least once, in any position of the tuple. I believe this is the broadest possible interpretation of what should be allowed for tuple return types, but I would certainly be okay making the lint more strict.
fixes #3313
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com>
flip1995 [Wed, 24 Oct 2018 14:18:01 +0000 (16:18 +0200)]
Fix warnings introduced by #3349
Josh Mcguigan [Wed, 24 Oct 2018 13:43:21 +0000 (06:43 -0700)]
new_ret_no_self added test cases
bors[bot] [Wed, 24 Oct 2018 12:21:19 +0000 (12:21 +0000)]
Merge #3349
3349: Fixes #3347: Lint for wildcard dependencies in Cargo.toml r=ordovicia a=ordovicia
Add a lint for wildcard dependencies in Cargo.toml.
How should I write a test for this lint?
Fixes #3347
Co-authored-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
Hidehito Yabuuchi [Wed, 24 Oct 2018 12:15:27 +0000 (21:15 +0900)]
Replace remaining `krate.span` with `DUMMY_SP`
Hidehito Yabuuchi [Wed, 24 Oct 2018 11:22:38 +0000 (20:22 +0900)]
Use DUMMY_SP in multiple_crate_versions
Hidehito Yabuuchi [Wed, 24 Oct 2018 11:18:19 +0000 (20:18 +0900)]
Some fixes for wildcard_dependencies
bors[bot] [Wed, 24 Oct 2018 07:59:06 +0000 (07:59 +0000)]
Merge #3350
3350: Don't emit `new_without_default_derive` if an impl of Default exists regardless of generics r=oli-obk a=pengowen123
Fixes #2226
Co-authored-by: Owen Sanchez <pengowen816@gmail.com>
Hidehito Yabuuchi [Wed, 24 Oct 2018 05:59:19 +0000 (14:59 +0900)]
Run util/update_lints.py
Hidehito Yabuuchi [Wed, 24 Oct 2018 02:34:36 +0000 (11:34 +0900)]
Minor changes on clippy_lints/src/wildcard_dependencies.rs
Hidehito Yabuuchi [Mon, 22 Oct 2018 13:39:51 +0000 (22:39 +0900)]
Lint for wildcard dependencies in Cargo.toml
bors[bot] [Wed, 24 Oct 2018 05:45:02 +0000 (05:45 +0000)]
Merge #3339
3339: Check for known array length in `needless_range_loop` r=phansch a=HMPerson1
In `VarVisitor`, we now keep track of the type of the thing that was directly indexed and, if it's an array, check if the range's end is (or is past) the array's length.
Fixes #3033
Co-authored-by: HMPerson1 <hmperson1@gmail.com>
bors[bot] [Wed, 24 Oct 2018 05:16:43 +0000 (05:16 +0000)]
Merge #3348
3348: Setup bors for Clippy r=phansch a=flip1995
Since [bors-ng](https://app.bors.tech/repositories/3993) is already installed for this repo for a while (https://github.com/rust-lang-nursery/rust-clippy/pull/3279#issuecomment-
427645938 ), the only thing missing, before we can use it, is the `bors.toml`. (bors-ng [docs](https://bors.tech/documentation/getting-started/))
If we want to move forward with this and this gets merged, the only thing left to do is to create the branches `staging` and `trying`.
@phansch @oli-obk
Co-authored-by: flip1995 <hello@philkrones.com>
Co-authored-by: Philipp Krones <hello@philkrones.com>
Philipp Hansch [Wed, 24 Oct 2018 05:02:20 +0000 (07:02 +0200)]
Merge pull request #3352 from gnieto/fix/doc-inspector
Fix inspector pass documentation
Owen Sanchez [Mon, 22 Oct 2018 04:59:45 +0000 (21:59 -0700)]
Don't emit `new_without_default_derive` if an impl of Default exists
Guillem Nieto [Tue, 23 Oct 2018 21:03:23 +0000 (23:03 +0200)]
Fix inspector pass documentation
When using `#[clippy_dump]`, the compiler complains about an unknown
attribute. The correct one seems to be `#[clippy::dump]`.
Philipp Krones [Mon, 22 Oct 2018 15:30:01 +0000 (17:30 +0200)]
Add branch configuration to appveyor.yml
flip1995 [Mon, 22 Oct 2018 11:09:48 +0000 (13:09 +0200)]
Setup bors
Josh Mcguigan [Sat, 20 Oct 2018 13:29:17 +0000 (06:29 -0700)]
new_ret_no_self added test cases
Josh Mcguigan [Sat, 20 Oct 2018 00:54:25 +0000 (17:54 -0700)]
new_ret_no_self walk return type to check for self
HMPerson1 [Fri, 19 Oct 2018 21:17:13 +0000 (17:17 -0400)]
Update `ui/for_loop` test output
HMPerson1 [Fri, 19 Oct 2018 20:34:16 +0000 (16:34 -0400)]
Check for known array length in `needless_range_loop`
Josh Mcguigan [Fri, 19 Oct 2018 12:20:33 +0000 (05:20 -0700)]
new_ret_no_self correct false positive on raw pointer return types
Josh Mcguigan [Fri, 19 Oct 2018 11:55:06 +0000 (04:55 -0700)]
new_ret_no_self correct linting of tuple return types
Philipp Krones [Thu, 18 Oct 2018 23:32:57 +0000 (01:32 +0200)]
Merge pull request #3334 from matthiaskrgr/new-ret-no-self__doc
new_ret_no_self: add sample from #3313 to Known Problems section.
Matthias Krüger [Thu, 18 Oct 2018 21:31:11 +0000 (23:31 +0200)]
new_ret_no_self: add sample from #3313 to Known Problems section.
fix trivial typo on the way
Philipp Hansch [Thu, 18 Oct 2018 20:26:33 +0000 (22:26 +0200)]
Merge pull request #3303 from shssoichiro/3069-unnecessary-fold-pattern-guard
Note known false positives in unnecessary_fold lint
Philipp Krones [Thu, 18 Oct 2018 18:12:28 +0000 (20:12 +0200)]
Merge pull request #3332 from lukasstevens/fix798
Check for comments in collapsible ifs
Lukas Stevens [Thu, 18 Oct 2018 16:57:16 +0000 (18:57 +0200)]
Support multiline comments and hopefully fix panic
Lukas Stevens [Tue, 16 Oct 2018 20:20:27 +0000 (22:20 +0200)]
Check for comments in collapsible ifs
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 18 Oct 2018 07:44:24 +0000 (09:44 +0200)]
Merge pull request #3323 from pengowen123/fix_manual_memcpy
Simplify manual_memcpy suggestion in some cases
Philipp Hansch [Wed, 17 Oct 2018 19:01:15 +0000 (21:01 +0200)]
Merge pull request #3330 from shssoichiro/3309-goblin-ice
Resolve ICE in needless range loop lint
Joshua Holmer [Wed, 17 Oct 2018 14:43:32 +0000 (10:43 -0400)]
Resolve ICE in needless range loop lint
An ICE would occur if the needless range loop was triggered
within a procedural macro, because Clippy would try to produce
a code suggestion which was invalid, and caused the compiler
to crash.
This commit takes the same approach which Clippy currently takes
to work around this type of crash in the needless pass by value lint,
which is to skip the lint if Clippy is inside of a macro.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 17 Oct 2018 07:47:02 +0000 (09:47 +0200)]
Merge pull request #3327 from phansch/update_changelog_riir
RIIR update_lints: Update changelog links
Philipp Hansch [Wed, 17 Oct 2018 06:18:05 +0000 (08:18 +0200)]
RIIR update_lints: Update changelog links
This now also updates the link list at the bottom of the changelog.
Philipp Hansch [Wed, 17 Oct 2018 05:31:09 +0000 (07:31 +0200)]
Merge pull request #3281 from CYBAI/redundant-match
Add lint for redundant pattern matching for explicit return boolean
Philipp Hansch [Wed, 17 Oct 2018 05:27:10 +0000 (07:27 +0200)]
Merge pull request #3326 from mrbuzz/master
Reword help message for len_zero
CYBAI [Wed, 10 Oct 2018 15:13:53 +0000 (23:13 +0800)]
Rename if_let_redundant_pattern_matching to redundant_pattern_matching
Also, making the old one deprecated
CYBAI [Sun, 7 Oct 2018 13:36:42 +0000 (21:36 +0800)]
Add lint for redundant pattern matching for explicit return boolean
Giorgio Gambino [Tue, 16 Oct 2018 21:23:31 +0000 (23:23 +0200)]
Fix issue #3322: reword help message for len_zero
Owen Sanchez [Tue, 16 Oct 2018 04:12:59 +0000 (21:12 -0700)]
Simplify manual_memcpy suggestion in some cases
Philipp Hansch [Tue, 16 Oct 2018 19:35:25 +0000 (21:35 +0200)]
Merge pull request #3325 from phansch/riir_update_lints_first_replace_region
RIIR update_lints: Replace lint count in README.md
Philipp Hansch [Tue, 16 Oct 2018 18:58:00 +0000 (20:58 +0200)]
Fix dogfood
`expect_fun_call` causes a false-positive, so I disabled it for now.
Joshua Holmer [Tue, 16 Oct 2018 13:04:02 +0000 (09:04 -0400)]
Update known problems for unnecessary_fold
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 16 Oct 2018 08:45:55 +0000 (10:45 +0200)]
Merge pull request #3321 from 0ndorio/fix/1123_false_positive_on_boxed_local
Avoid linting `boxed_local` on trait implementations.
Philipp Hansch [Tue, 16 Oct 2018 06:00:31 +0000 (08:00 +0200)]
RIIR update_lints: Replace lint count in README.md
This allows the usage of `util/dev update_lints` which will write the
new lint_count to the `README.md`.
Philipp Hansch [Tue, 16 Oct 2018 05:24:32 +0000 (07:24 +0200)]
Rename `active_lints` to `usable_lints`
Because now `usable_lints` will also exclude internal lints.
Philipp Hansch [Tue, 16 Oct 2018 05:13:45 +0000 (07:13 +0200)]
Merge pull request #3320 from phansch/riir_update_lints_use_walkdir
RIIR update_lints: use WalkDir instead of read_dir
Philipp Hansch [Tue, 16 Oct 2018 05:13:03 +0000 (07:13 +0200)]
Merge pull request #3319 from majecty/webpage_link_category
Website: Make lint categories linkable
Philipp Hansch [Mon, 15 Oct 2018 19:10:22 +0000 (21:10 +0200)]
Add comment on WalkDir vs. fs::read_dir
Philipp Hansch [Mon, 15 Oct 2018 19:02:38 +0000 (21:02 +0200)]
sort_by -> sort_by_key