]>
git.lizzy.rs Git - rust.git/log
Philipp Hansch [Tue, 16 Oct 2018 19:35:25 +0000 (21:35 +0200)]
Merge pull request #3325 from phansch/riir_update_lints_first_replace_region
RIIR update_lints: Replace lint count in README.md
Philipp Hansch [Tue, 16 Oct 2018 18:58:00 +0000 (20:58 +0200)]
Fix dogfood
`expect_fun_call` causes a false-positive, so I disabled it for now.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 16 Oct 2018 08:45:55 +0000 (10:45 +0200)]
Merge pull request #3321 from 0ndorio/fix/1123_false_positive_on_boxed_local
Avoid linting `boxed_local` on trait implementations.
Philipp Hansch [Tue, 16 Oct 2018 06:00:31 +0000 (08:00 +0200)]
RIIR update_lints: Replace lint count in README.md
This allows the usage of `util/dev update_lints` which will write the
new lint_count to the `README.md`.
Philipp Hansch [Tue, 16 Oct 2018 05:24:32 +0000 (07:24 +0200)]
Rename `active_lints` to `usable_lints`
Because now `usable_lints` will also exclude internal lints.
Philipp Hansch [Tue, 16 Oct 2018 05:13:45 +0000 (07:13 +0200)]
Merge pull request #3320 from phansch/riir_update_lints_use_walkdir
RIIR update_lints: use WalkDir instead of read_dir
Philipp Hansch [Tue, 16 Oct 2018 05:13:03 +0000 (07:13 +0200)]
Merge pull request #3319 from majecty/webpage_link_category
Website: Make lint categories linkable
Philipp Hansch [Mon, 15 Oct 2018 19:10:22 +0000 (21:10 +0200)]
Add comment on WalkDir vs. fs::read_dir
Philipp Hansch [Mon, 15 Oct 2018 19:02:38 +0000 (21:02 +0200)]
sort_by -> sort_by_key
Philipp Hansch [Mon, 15 Oct 2018 18:47:19 +0000 (20:47 +0200)]
Some more documentation for clippy_dev
Philipp Hansch [Tue, 9 Oct 2018 06:08:50 +0000 (08:08 +0200)]
Use `WalkDir` to also gather from subdirectories
`fs::read_dir` does not recurse into subdirectories.
Bruno Kirschner [Mon, 15 Oct 2018 18:20:50 +0000 (20:20 +0200)]
Avoid linting `boxed_local` on trait implementations.
Park Juhyung [Mon, 15 Oct 2018 13:32:49 +0000 (22:32 +0900)]
Website: Make lint categories linkable
Fixes #2973
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 15 Oct 2018 07:33:21 +0000 (09:33 +0200)]
Merge pull request #3316 from pengowen123/fix_needless_range_loop
Swap order of methods in `needless_range_loop` suggestion for efficiency in some cases
Manish Goregaokar [Mon, 15 Oct 2018 06:41:35 +0000 (23:41 -0700)]
Restore clippy_dummy's placeholder name
Fixes #3317
Owen Sanchez [Mon, 15 Oct 2018 03:07:21 +0000 (20:07 -0700)]
Swap order of methods in `needless_range_loop` suggestion in some cases
Manish Goregaokar [Sun, 14 Oct 2018 22:57:23 +0000 (15:57 -0700)]
Merge pull request #3315 from rust-lang-nursery/oli-obk-patch-1
fix for rustc master
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sun, 14 Oct 2018 20:55:26 +0000 (22:55 +0200)]
fix for rustc master
Martin Carton [Sun, 14 Oct 2018 12:15:31 +0000 (14:15 +0200)]
Merge pull request #3314 from matthiaskrgr/mem_forget_sample
mem_forget: fix syntax error in code sample
Matthias Krüger [Sun, 14 Oct 2018 08:30:04 +0000 (10:30 +0200)]
mem_forget: fix syntax error in code sample
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 18:11:50 +0000 (20:11 +0200)]
Merge pull request #3310 from JoshMcguigan/explicit_counter_loop-3308
explicit_counter_loop fix #3308 false positive
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 18:10:51 +0000 (20:10 +0200)]
Merge pull request #3253 from JoshMcguigan/new_ret_no_self-3220
new_ret_no_self
Josh Mcguigan [Sat, 13 Oct 2018 13:57:52 +0000 (06:57 -0700)]
explicit_counter_loop fix #3308 false positive
Josh Mcguigan [Sat, 13 Oct 2018 13:33:46 +0000 (06:33 -0700)]
new_ret_no_self test remove tool lints cfg flag
Josh Mcguigan [Tue, 9 Oct 2018 02:35:37 +0000 (19:35 -0700)]
Added new_ret_no_self exception to clippy to pass dogfood tests
Josh Mcguigan [Fri, 5 Oct 2018 04:37:28 +0000 (21:37 -0700)]
Removed new_ret_no_self tests from method.rs
Josh Mcguigan [Fri, 5 Oct 2018 02:01:04 +0000 (19:01 -0700)]
new_ret_no_self correctly lint impl return
Josh Mcguigan [Wed, 3 Oct 2018 12:00:43 +0000 (05:00 -0700)]
Removed unused variables
Josh Mcguigan [Wed, 3 Oct 2018 11:59:14 +0000 (04:59 -0700)]
new_ret_no_self fix false positive for impl trait return with associated type self
Josh Mcguigan [Wed, 3 Oct 2018 10:55:31 +0000 (03:55 -0700)]
new_ret_no_self corrected panic and added test stderr
Josh Mcguigan [Wed, 3 Oct 2018 03:11:56 +0000 (20:11 -0700)]
new_ret_no_self added positive test cases
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 07:30:19 +0000 (09:30 +0200)]
Merge pull request #3233 from rust-lang-nursery/unused-unit
new lint: unused_unit
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Sat, 13 Oct 2018 07:24:55 +0000 (09:24 +0200)]
Merge pull request #3298 from devonhollowood/pedantic-dogfood-naming
Pedantic dogfood: naming and docs
Devon Hollowood [Sat, 13 Oct 2018 00:07:48 +0000 (17:07 -0700)]
Fix some more `stutter` warnings
Andre Bogus [Thu, 27 Sep 2018 17:10:20 +0000 (19:10 +0200)]
unused unit lint
Philipp Hansch [Fri, 12 Oct 2018 20:49:23 +0000 (22:49 +0200)]
Merge pull request #3304 from phansch/travis_windows_part2
Install Windows SDK 10.0 on travis
Philipp Hansch [Fri, 12 Oct 2018 20:04:58 +0000 (22:04 +0200)]
Install Windows SDK 10.0 on travis
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Fri, 12 Oct 2018 13:07:12 +0000 (15:07 +0200)]
Merge pull request #3291 from JoshMcguigan/cmp_owned-3289
cmp_owned wording and false positive
Josh Mcguigan [Fri, 12 Oct 2018 11:48:54 +0000 (04:48 -0700)]
cmp_owned refactor
Josh Mcguigan [Fri, 12 Oct 2018 11:34:41 +0000 (04:34 -0700)]
cmp_owned correct error message if rhs is deref
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Fri, 12 Oct 2018 11:16:34 +0000 (13:16 +0200)]
Merge pull request #3301 from sigustin/patch-1
Specify which categories are enabled by default
sigustin [Fri, 12 Oct 2018 10:32:48 +0000 (12:32 +0200)]
Add a comment reminding to update README if the default changes
sigustin [Fri, 12 Oct 2018 10:15:20 +0000 (12:15 +0200)]
Specify which categories are enabled by default
Closes #3293
Philipp Hansch [Fri, 12 Oct 2018 07:27:32 +0000 (09:27 +0200)]
Merge pull request #3300 from phansch/travis_windows
Add Travis windows build
Philipp Hansch [Fri, 12 Oct 2018 05:59:08 +0000 (07:59 +0200)]
Only run markdown linter on linux
Because:
* There's no need to run it on more than one platform
* It doesn't work on windows
Philipp Hansch [Fri, 12 Oct 2018 05:41:25 +0000 (07:41 +0200)]
Move Travis Windows build to allowed failures
Until the remaining issues are fixed. This also enabled `fast_finish`.
It will finish even if the windows build is still running.
Philipp Hansch [Fri, 12 Oct 2018 05:19:34 +0000 (07:19 +0200)]
Add Travis windows build
See https://blog.travis-ci.com/2018-10-11-windows-early-release
Devon Hollowood [Thu, 11 Oct 2018 22:43:13 +0000 (15:43 -0700)]
Fix `doc_markdown` lints
Devon Hollowood [Thu, 11 Oct 2018 22:36:40 +0000 (15:36 -0700)]
Fix `stutter` lints
Devon Hollowood [Thu, 11 Oct 2018 22:18:58 +0000 (15:18 -0700)]
Fix `similar_names` warnings
Most of these are just `#![allow]`ed, because they are things like using
l vs r to differentiate left vs right. These would be made less clear by
taking the advice of `similar_names`
Josh Mcguigan [Thu, 11 Oct 2018 12:03:02 +0000 (05:03 -0700)]
cmp_owned current suggestion for multiple deref
Oliver Scherer [Thu, 11 Oct 2018 10:18:27 +0000 (12:18 +0200)]
Remove now-useless `allow(unknown_lints)`
Oliver Scherer [Thu, 11 Oct 2018 10:16:22 +0000 (12:16 +0200)]
Stabilize tool lints
Philipp Hansch [Thu, 11 Oct 2018 08:53:05 +0000 (10:53 +0200)]
Merge pull request #3294 from mikerite/fix-3276
Fix fn_to_numeric_cast_with_truncation suppression
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 11 Oct 2018 07:20:20 +0000 (09:20 +0200)]
Merge pull request #3295 from phansch/refactor_clippy_dev
Use `impl Iterator` in arg position in clippy_dev
Philipp Hansch [Thu, 11 Oct 2018 06:34:51 +0000 (08:34 +0200)]
Use `impl Iterator` in arg position in clippy_dev
Small refactoring pulled out of work on #3266.
This should make the methods a bit more flexible.
Philipp Hansch [Thu, 11 Oct 2018 06:07:51 +0000 (08:07 +0200)]
Merge pull request #3288 from devonhollowood/pedantic-dogfood-casts
Pedantic dogfood: casts
Michael Wright [Thu, 11 Oct 2018 05:45:26 +0000 (07:45 +0200)]
Fix fn_to_numeric_cast_with_truncation suppression
Fixes #3276
mikerite [Thu, 11 Oct 2018 04:22:02 +0000 (06:22 +0200)]
Merge pull request #3127 from mikerite/fix-2937
Fix 2937
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 10 Oct 2018 20:35:02 +0000 (22:35 +0200)]
Merge pull request #3292 from kimsnj/commutative_assign_op
Limit commutative assign op lint to primitive types
Karim SENHAJI [Wed, 10 Oct 2018 15:05:16 +0000 (17:05 +0200)]
Limit commutative assign op lint to primitive types
Josh Mcguigan [Wed, 10 Oct 2018 11:51:06 +0000 (04:51 -0700)]
cmp_owned add test for multiple dereference
Devon Hollowood [Wed, 10 Oct 2018 06:35:10 +0000 (23:35 -0700)]
Clarify code
Take advantage of the fact that very large regexes are unlikely
Michael Wright [Wed, 10 Oct 2018 05:52:58 +0000 (07:52 +0200)]
Fix #2937
Josh Mcguigan [Wed, 10 Oct 2018 03:01:12 +0000 (20:01 -0700)]
Corrected single-character string constant used as pattern found in dogfood test
Josh Mcguigan [Wed, 10 Oct 2018 02:25:03 +0000 (19:25 -0700)]
Fixes 3289, cmp_owned wording and false positive
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 9 Oct 2018 08:01:31 +0000 (10:01 +0200)]
Merge pull request #3287 from JoshMcguigan/cmp_owned-2925
cmp_owned false positive
Devon Hollowood [Tue, 9 Oct 2018 05:34:10 +0000 (22:34 -0700)]
Fix cast_possible_wrap and cast_sign_loss warnings
Devon Hollowood [Tue, 9 Oct 2018 04:40:21 +0000 (21:40 -0700)]
Fix cast_possible_truncation warnings
Josh Mcguigan [Tue, 9 Oct 2018 02:04:29 +0000 (19:04 -0700)]
Fixes #2925 cmp_owned false positive
Philipp Hansch [Mon, 8 Oct 2018 19:54:08 +0000 (21:54 +0200)]
Merge pull request #3278 from d-dorazio/fix-contributing-manual-test-command
contributing.md: fix command to manually test an example
Philipp Hansch [Mon, 8 Oct 2018 19:31:04 +0000 (21:31 +0200)]
Merge pull request #3234 from matthiaskrgr/fix_3064_crash
if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash.
Matthias Krüger [Fri, 28 Sep 2018 19:09:57 +0000 (21:09 +0200)]
if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash.
Fixes #3064
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 11:52:19 +0000 (13:52 +0200)]
Merge pull request #3286 from vmalloc/lifetime_elision_msg
Improve diagnostics in case of lifetime elision (closes #3284)
Rotem Yaari [Mon, 8 Oct 2018 08:43:13 +0000 (11:43 +0300)]
Improve diagnostics in case of lifetime elision (closes #3284)
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 06:24:13 +0000 (08:24 +0200)]
Merge pull request #3282 from JoshMcguigan/excessive_precision-2840
Fix excessive_precision false positive
Philipp Hansch [Mon, 8 Oct 2018 06:22:09 +0000 (07:22 +0100)]
Merge pull request #3265 from mikerite/fix-export
Fix util/export.py to include lints from methods
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 06:21:59 +0000 (08:21 +0200)]
Merge pull request #3283 from etaoins/dont-suggest-cloned-for-map-box-deref
Don't suggest cloned() for map Box deref
Philipp Hansch [Mon, 8 Oct 2018 05:59:55 +0000 (06:59 +0100)]
Merge pull request #3285 from devonhollowood/pedantic-dogfood-items-after-statements
Pedantic dogfood: `items_after_statements`
Devon Hollowood [Mon, 8 Oct 2018 00:08:20 +0000 (17:08 -0700)]
Fix items_after_statements for `const`s
Devon Hollowood [Mon, 8 Oct 2018 00:07:10 +0000 (17:07 -0700)]
Fix items_after_statements for sub-functions
Devon Hollowood [Mon, 8 Oct 2018 00:05:28 +0000 (17:05 -0700)]
Fix items_after_statements for `use` statements
Ryan Cumming [Sun, 7 Oct 2018 19:20:32 +0000 (06:20 +1100)]
Don't suggest cloned() for map Box deref
Boxes are a bit magic in that they need to use `*` to get an owned value
out of the box. They implement `Deref` but that only returns a
reference. This means an easy way to convert an `Option<Box<T>>` to an
`<Option<T>` is:
```
box_option.map(|b| *b)
```
However, since
b36bb0a6 the `map_clone` lint is detecting this as an
attempt to copy the box. Fix by excluding boxes completely from the
deref part of this lint.
Fixes #3274
Josh Mcguigan [Sun, 7 Oct 2018 18:38:20 +0000 (11:38 -0700)]
Fix excessive_precision false positive
Philipp Hansch [Sun, 7 Oct 2018 12:09:37 +0000 (13:09 +0100)]
Merge pull request #3280 from d-dorazio/fix-new_without_default-should-not-fire-unsafe-new
new_without_default should not warn about unsafe new
Manish Goregaokar [Sun, 7 Oct 2018 11:27:51 +0000 (04:27 -0700)]
Merge pull request #3279 from phansch/fix_fp_in_fn_to_numeric_cast_with_truncation
Fix FP in `fn_to_numeric_cast_with_truncation`
Philipp Hansch [Sun, 7 Oct 2018 10:18:40 +0000 (12:18 +0200)]
Fix FP in `fn_to_numeric_cast_with_truncation`
We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts
[here][rust_check].
[rust_check]: https://github.com/rust-lang/rust/blob/
5472b0718f286266ab89acdf234c3552de7e973c /src/librustc_typeck/check/cast.rs#L430-L433
Daniele D'Orazio [Sun, 7 Oct 2018 10:39:54 +0000 (12:39 +0200)]
new_without_default should not warn about unsafe new
Daniele D'Orazio [Sat, 6 Oct 2018 18:07:41 +0000 (20:07 +0200)]
fix command to manually test an example
Philipp Hansch [Sun, 7 Oct 2018 09:02:46 +0000 (10:02 +0100)]
Merge pull request #3273 from maccoda/master
Adding more detail to filter_map lint documentation.
Manish Goregaokar [Sun, 7 Oct 2018 02:29:01 +0000 (19:29 -0700)]
Add license to README
Dylan Maccora [Sun, 7 Oct 2018 00:24:09 +0000 (11:24 +1100)]
Adding more detail to filter_map lint documentation.
Manish Goregaokar [Sat, 6 Oct 2018 17:21:57 +0000 (10:21 -0700)]
Merge pull request #3269 from rust-lang-nursery/relicense
Relicense clippy to the Rust license
Manish Goregaokar [Sat, 6 Oct 2018 17:20:48 +0000 (10:20 -0700)]
additional people
Manish Goregaokar [Sat, 6 Oct 2018 16:23:54 +0000 (09:23 -0700)]
Add license header to other files
Manish Goregaokar [Sat, 6 Oct 2018 16:18:06 +0000 (09:18 -0700)]
Add license header to Rust files
Manish Goregaokar [Fri, 5 Oct 2018 19:37:50 +0000 (12:37 -0700)]
Relicense clippy
Documentation on relicensing in previous commit
Fixes #2885
Also fixes #3093, fixes #3094, fixes 3095, fixes #3096, fixes #3097, fixes #3098,
fixes #3099, fixes #3100, fixes #3230
Manish Goregaokar [Fri, 5 Oct 2018 19:34:15 +0000 (12:34 -0700)]
Document relicensing process
Manish Goregaokar [Sat, 6 Oct 2018 05:35:04 +0000 (22:35 -0700)]
Merge pull request #3270 from rust-lang-nursery/rustup
Rustup for https://github.com/rust-lang/rust/pull/54741
Manish Goregaokar [Fri, 5 Oct 2018 20:41:40 +0000 (13:41 -0700)]
Rustup for https://github.com/rust-lang/rust/pull/54741