]>
git.lizzy.rs Git - rust.git/log
flip1995 [Sat, 16 Mar 2019 10:17:36 +0000 (11:17 +0100)]
AbsolutePathBuffer -> AbsolutePathPrinter
flip1995 [Fri, 15 Mar 2019 22:44:42 +0000 (23:44 +0100)]
Remove ty::TyKind from eta_reduction and replace it with ty::Ty
flip1995 [Fri, 15 Mar 2019 22:44:04 +0000 (23:44 +0100)]
parent_def_id -> parent
flip1995 [Fri, 15 Mar 2019 22:43:42 +0000 (23:43 +0100)]
item_path_str -> def_path_str
flip1995 [Fri, 15 Mar 2019 22:41:30 +0000 (23:41 +0100)]
Reimplement AbsolutePathBuffer
bors [Fri, 15 Mar 2019 09:43:29 +0000 (09:43 +0000)]
Auto merge of #3886 - phansch:rustfix_useless_asref, r=flip1995
Enable rustfix for `useless_asref` lint tests
cc #3630
Philipp Hansch [Fri, 15 Mar 2019 06:29:12 +0000 (07:29 +0100)]
Enable rustfix for `useless_asref` lint tests
bors [Fri, 15 Mar 2019 06:18:28 +0000 (06:18 +0000)]
Auto merge of #3883 - daxpedda:missing_docs_in_private_items, r=phansch
Add `doc(include = ...)` detection to `missing_docs_in_private_items`
The whole `missing documentation in crate` part doesn't have any tests. If I should add test cases tell me.
daxpedda [Thu, 14 Mar 2019 18:38:41 +0000 (19:38 +0100)]
Another test for missing crate documentation.
daxpedda [Thu, 14 Mar 2019 18:33:06 +0000 (19:33 +0100)]
Add a test for `doc(include)`
Tiny code improvement.
daxpedda [Thu, 14 Mar 2019 17:32:39 +0000 (18:32 +0100)]
Add `doc(include = ...)` detection to `missing_docs_in_private_items`
bors [Thu, 14 Mar 2019 17:29:19 +0000 (17:29 +0000)]
Auto merge of #3879 - phansch:rustfix_string_lit_as_bytes, r=flip1995
Run rustfix for string_lit_as_bytes tests
This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.
cc #3603, #2038
bors [Thu, 14 Mar 2019 16:32:15 +0000 (16:32 +0000)]
Auto merge of #3877 - rink1969:3842, r=flip1995
casting integer literal to float is unnecessary
fix issue https://github.com/rust-lang/rust-clippy/issues/3842
rink1969 [Tue, 12 Mar 2019 07:49:26 +0000 (15:49 +0800)]
casting integer literal to float is unnecessary
bors [Thu, 14 Mar 2019 07:52:00 +0000 (07:52 +0000)]
Auto merge of #3880 - phansch:uicleanup9001, r=oli-obk
UI test cleanup: Extract manual_memcpy tests
cc #2038
Philipp Hansch [Thu, 14 Mar 2019 06:26:47 +0000 (07:26 +0100)]
UI test cleanup: Extract manual_memcpy tests
Philipp Hansch [Thu, 14 Mar 2019 05:59:30 +0000 (06:59 +0100)]
Run rustfix for string_lit_as_bytes tests
This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.
bors [Wed, 13 Mar 2019 08:45:23 +0000 (08:45 +0000)]
Auto merge of #3873 - phansch:hiridification, r=flip1995
Some more HirId-ification
*
8a59f81 : Rename span_lint_node* functions to span_lint_hir*
*
a457258 : Use `HirId` instead of `NodeId` for lookup
Philipp Hansch [Wed, 13 Mar 2019 05:51:57 +0000 (06:51 +0100)]
cargo fmt
bors [Tue, 12 Mar 2019 12:09:56 +0000 (12:09 +0000)]
Auto merge of #3869 - taiki-e:use_self, r=flip1995
Fix `use_self` false positive on nested functions
Related to https://github.com/rust-lang/rust-clippy/pull/3640
The current `use_self` warns the following code.
```rust
#![warn(clippy::use_self)]
struct Foo {}
impl Foo {
fn bar() {
fn baz() -> Foo { //^ warning: unnecessary structure name repetition
Foo {} //^ warning: unnecessary structure name repetition
}
}
}
```
bors [Tue, 12 Mar 2019 09:34:04 +0000 (09:34 +0000)]
Auto merge of #3872 - phansch:some_feature_cleanup, r=oli-obk
Remove some unused features and `error-pattern`s
None
bors [Tue, 12 Mar 2019 07:43:14 +0000 (07:43 +0000)]
Auto merge of #3794 - mikerite:fix-3739, r=phansch
Fix `boxed_local` suggestion
Don't warn about an argument that is moved into a closure.
ExprUseVisitor doesn't walk into nested bodies so use a new
visitor that collects the variables that are moved into closures.
Fixes #3739
Philipp Hansch [Tue, 12 Mar 2019 07:11:57 +0000 (08:11 +0100)]
Use `HirId` instead of `NodeId` for lookup
Philipp Hansch [Tue, 12 Mar 2019 06:32:02 +0000 (07:32 +0100)]
Remove some unused features and `error-pattern`s
bors [Tue, 12 Mar 2019 07:04:44 +0000 (07:04 +0000)]
Auto merge of #3871 - taiki-e:needless_continue, r=phansch
Fix `needless_continue` false positive
If the `continue` has a label, check it matches the label of the loop.
Fixes https://github.com/rust-lang/rust-clippy/issues/2329
Philipp Hansch [Tue, 12 Mar 2019 07:01:21 +0000 (08:01 +0100)]
Rename span_lint_node* functions to span_lint_hir*
Because they now take a `hir_id` instead of a `node_id` argument.
bors [Tue, 12 Mar 2019 06:22:00 +0000 (06:22 +0000)]
Auto merge of #3865 - phansch:run_more_doc_tests, r=flip1995
Run more doc tests
This executes some more doc tests that were ignored before.
Michael Wright [Tue, 12 Mar 2019 06:13:44 +0000 (08:13 +0200)]
Merge branch 'master' into fix-3739
bors [Tue, 12 Mar 2019 06:01:00 +0000 (06:01 +0000)]
Auto merge of #3868 - taiki-e:needless_pass_by_value, r=phansch
Filter out proc_macro and proc_macro_attribute
Related to https://github.com/rust-lang/rust-clippy/pull/1617
Fixes https://github.com/rust-lang/rust-clippy/issues/3067 (this issue has already been closed, but in fact the false positive in `#[proc_macro]` and `#[proc_macro_attribute]` has not been fixed yet)
Philipp Hansch [Sat, 9 Mar 2019 07:51:23 +0000 (08:51 +0100)]
Run more doc tests
This executes some more doc tests that were ignored before.
Taiki Endo [Mon, 11 Mar 2019 18:40:30 +0000 (03:40 +0900)]
Fix `needless_continue` false positive
Taiki Endo [Mon, 11 Mar 2019 14:24:49 +0000 (23:24 +0900)]
Fix `use_self` false positive on nested functions
Taiki Endo [Mon, 11 Mar 2019 11:45:57 +0000 (20:45 +0900)]
Filter out proc_macro and proc_macro_attribute
bors [Sun, 10 Mar 2019 23:21:48 +0000 (23:21 +0000)]
Auto merge of #3767 - alexreg:cosmetic-2, r=flip1995
Various cosmetic improvements
Related to the larger effort of https://github.com/rust-lang/rust/pull/58036.
flip1995 [Sun, 10 Mar 2019 22:01:56 +0000 (23:01 +0100)]
Fix/Ignore doc tests
flip1995 [Sun, 10 Mar 2019 21:12:26 +0000 (22:12 +0100)]
Run rustfmt
flip1995 [Sun, 10 Mar 2019 21:07:10 +0000 (22:07 +0100)]
Update tests
Alexander Regueiro [Sun, 10 Mar 2019 17:19:38 +0000 (17:19 +0000)]
Reblessed test outputs.
Alexander Regueiro [Sun, 10 Mar 2019 17:19:47 +0000 (17:19 +0000)]
Addressed points raised in review.
Alexander Regueiro [Thu, 31 Jan 2019 01:15:29 +0000 (01:15 +0000)]
Various cosmetic improvements.
bors [Sun, 10 Mar 2019 14:26:31 +0000 (14:26 +0000)]
Auto merge of #3733 - Zoxc:rustc-interface, r=oli-obk
Use the new rustc interface
Shows the changes required to compile with https://github.com/rust-lang/rust/pull/56732
John Kåre Alsaker [Sun, 10 Mar 2019 11:00:17 +0000 (12:00 +0100)]
rustfmt
John Kåre Alsaker [Fri, 1 Feb 2019 22:28:14 +0000 (23:28 +0100)]
Use the new rustc interface
bors [Sun, 10 Mar 2019 08:52:24 +0000 (08:52 +0000)]
Auto merge of #3863 - rust-lang:get_unwrap, r=oli-obk
Move get_unwrap to restriction
fixes #3862
r? @oli-obk
Manish Goregaokar [Sat, 9 Mar 2019 18:12:22 +0000 (10:12 -0800)]
Move get_unwrap to restriction
fixes #3862
bors [Sat, 9 Mar 2019 15:05:38 +0000 (15:05 +0000)]
Auto merge of #3824 - phansch:adding_lints, r=phansch
Add lint writing documentation
[Rendered](https://github.com/phansch/rust-clippy/blob/adding_lints/doc/adding_lints.md)
This adds a new documentation page that explains how to write Clippy
lints. It guides the reader through creating a `foo` function lint.
I plan to iterate a bit more on the prose of some sections, but I think the
general structure is fine now, so I'm looking forward to feedback =)
One thing I'm not sure about: I felt like this is too big for CONTRIBUTING.md
so I put it into a new `doc/` directory. I can imagine having more
documentation in the future, so we might even want to create a book using
mdbook instead? Or should everything go into CONTRIBUTING.md?
Further things left to do:
- [x] Link from CONTRIBUTING.md
- [x] Remove things covered in this guide from CONTRIBUTING.md
- [x] Section about `clippy::author` attribute
- [x] Run `remark-lint` on CI over the `doc` directory and fix things
bors [Sat, 9 Mar 2019 12:05:41 +0000 (12:05 +0000)]
Auto merge of #3860 - phansch:refactor_out_opt_def_id, r=flip1995
Refactor: Remove utils::opt_def_id
This removes some indirection. Probably this method was uplifted to
rustc at some point?
bors [Sat, 9 Mar 2019 11:41:26 +0000 (11:41 +0000)]
Auto merge of #3861 - flip1995:rollup, r=flip1995
Rollup of 3 pull requests
Successful merges:
- #3851 (Refactor: Extract `trait_ref_of_method` function)
- #3852 (Refactor: Cleanup one part of assign_ops lint)
- #3857 (Document match_path, improve match_qpath docs)
Failed merges:
r? @ghost
Philipp Krones [Sat, 9 Mar 2019 11:24:44 +0000 (12:24 +0100)]
Rollup merge of #3857 - phansch:document_path_qpath, r=flip1995
Document match_path, improve match_qpath docs
Inching towards enabling `#[deny(missing_docs)]` in utils :scroll:
Philipp Krones [Sat, 9 Mar 2019 11:24:43 +0000 (12:24 +0100)]
Rollup merge of #3852 - phansch:refactor_assign_ops, r=flip1995
Refactor: Cleanup one part of assign_ops lint
Removes a lot of indentation and separates lint emission from lint
logic. Only touches the `hir::ExprKind::AssignOp` part of the lint.
Philipp Krones [Sat, 9 Mar 2019 11:24:42 +0000 (12:24 +0100)]
Rollup merge of #3851 - phansch:refactor_trait_stuff, r=flip1995
Refactor: Extract `trait_ref_of_method` function
This pattern was used in three places after #3844, so I think it's worth moving it into `utils/mod.rs` and documenting it.
bors [Fri, 8 Mar 2019 17:10:52 +0000 (17:10 +0000)]
Auto merge of #3854 - ljedrz:rustc_58992, r=phansch
Align with rust-lang/rust/#58992
Some adjustments needed after the most recent round of HirIdification.
Philipp Hansch [Fri, 8 Mar 2019 13:14:41 +0000 (14:14 +0100)]
Refactor: Remove utils::opt_def_id
This removes some indirection. Probably this method was uplifted to
rustc at some point?
Philipp Hansch [Fri, 8 Mar 2019 08:50:20 +0000 (09:50 +0100)]
Document match_path, improve match_qpath docs
Philipp Hansch [Fri, 8 Mar 2019 08:44:22 +0000 (09:44 +0100)]
cargo fmt
Philipp Hansch [Fri, 8 Mar 2019 08:42:09 +0000 (09:42 +0100)]
fmt
Philipp Krones [Fri, 8 Mar 2019 08:40:12 +0000 (09:40 +0100)]
Update clippy_lints/src/utils/mod.rs
Co-Authored-By: phansch <dev@phansch.net>
Philipp Hansch [Fri, 8 Mar 2019 08:10:41 +0000 (09:10 +0100)]
Fix doctest
Philipp Hansch [Thu, 7 Mar 2019 07:14:26 +0000 (08:14 +0100)]
Refactor: Cleanup one part of assign_ops lint
Removes a lot of indentation and separates lint emission from lint
logic. Only touches the `hir::ExprKind::AssignOp` part of the lint.
Philipp Hansch [Fri, 8 Mar 2019 07:50:13 +0000 (08:50 +0100)]
Update comment location
bors [Fri, 8 Mar 2019 07:36:32 +0000 (07:36 +0000)]
Auto merge of #3856 - mikerite:clippy-dev-enchancement-1, r=phansch
Improve Clippy dev help
+ Print help if no subcommand is supplied
+ Make a short version of `update_lints` help for the subcommand listing
bors [Fri, 8 Mar 2019 07:16:28 +0000 (07:16 +0000)]
Auto merge of #3855 - rchaser53:issue-3849, r=flip1995
Remove an unused binary file
related https://github.com/rust-lang/rust-clippy/pull/3853
I'm sorry.
Michael Wright [Fri, 8 Mar 2019 05:45:31 +0000 (07:45 +0200)]
Improve Clippy dev help
+ Print help if no subcommand is supplied
+ Make a short version of `update_lints` help for the subcommand listing
rChaser53 [Thu, 7 Mar 2019 23:14:29 +0000 (08:14 +0900)]
Remove an unused binary file
ljedrz [Thu, 7 Mar 2019 20:51:05 +0000 (21:51 +0100)]
align with rust-lang/rust/#58992
bors [Thu, 7 Mar 2019 15:02:53 +0000 (15:02 +0000)]
Auto merge of #3853 - rchaser53:issue-3849, r=flip1995
fix missing a semicolon
related: https://github.com/rust-lang/rust-clippy/issues/3849
rchaser53 [Thu, 7 Mar 2019 13:07:01 +0000 (22:07 +0900)]
fix missing a semicolon
Philipp Hansch [Thu, 7 Mar 2019 06:42:38 +0000 (07:42 +0100)]
Refactor: Extract `trait_ref_of_method` function
bors [Thu, 7 Mar 2019 07:05:35 +0000 (07:05 +0000)]
Auto merge of #3850 - mikerite:rustfmt-tests, r=phansch
More test improvements
Michael Wright [Thu, 7 Mar 2019 06:21:41 +0000 (08:21 +0200)]
Enable rustfix on `unused_unit` tests
Michael Wright [Thu, 7 Mar 2019 06:13:59 +0000 (08:13 +0200)]
Add `[rustfmt::skip]` to `unused_unit` test
Michael Wright [Thu, 7 Mar 2019 06:03:15 +0000 (08:03 +0200)]
Add `[rustfmt::skip]` to `doc_markdown` tests
bors [Wed, 6 Mar 2019 13:41:31 +0000 (13:41 +0000)]
Auto merge of #3803 - felix91gr:master, r=oli-obk
Cognitive Complexity (step 1 out of 3+): name changes
Following up on #3793
**Overall checklist:**
1. **Name changes**
2. MVP of functionality
3. Tests
After this PR, we will start working on the implementation itself.
Félix Fischer [Sat, 23 Feb 2019 01:19:50 +0000 (22:19 -0300)]
Renamed: Cyclomatic Complexity -> Cognitive Complexity
* Ran automatic naming update
* Formalized rename of `cyclomatic_complexity` to `cognitive_complexity`
** Added the rename to `lib.rs`
** Added rename test
* Added warning for deprecated key `cyclomatic_complexity_threshold` and tests for it
* Added deprecation status for Clippy's builtin attribute
* Updated tests for new builtin attribute renaming
bors [Wed, 6 Mar 2019 06:48:26 +0000 (06:48 +0000)]
Auto merge of #3845 - euclio:unused-comments, r=phansch
move lint documentation into macro invocations
This PR moves lint documentation inside `declare_clippy_lint!` macro invocations, to avoid triggering the `unused_doc_comments` lint once it's modified in rust-lang/rust#57882. This PR is necessary to unblock that work, since the large number of warnings generated in `clippy_lints` causes Travis to hit the log length limit.
This PR also updates the documentation and website generation script.
It would be nice to get a clippy update in the Rust repo once this is merged.
cc @phansch
bors [Wed, 6 Mar 2019 05:54:48 +0000 (05:54 +0000)]
Auto merge of #3846 - mikerite:fix-3839, r=phansch
Ensure `expect_fun_call` bad suggestion is fixed
Closes #3839
Michael Wright [Wed, 6 Mar 2019 05:00:05 +0000 (07:00 +0200)]
Ensure `expect_fun_call` bad suggestion is fixed
Closes #3839
Andy Russell [Tue, 5 Mar 2019 22:23:50 +0000 (17:23 -0500)]
fix or ignore failing doc tests
Andy Russell [Tue, 5 Mar 2019 16:50:33 +0000 (11:50 -0500)]
move lint documentation into macro invocations
bors [Tue, 5 Mar 2019 10:12:53 +0000 (10:12 +0000)]
Auto merge of #3844 - phansch:const_fn_external_macro, r=oli-obk
Fix two missing_const_for_fn false positives
Fixes #3841
* Fixes false positive in external macros
* Fixes false positive when implement trait methods
Philipp Hansch [Tue, 5 Mar 2019 07:11:55 +0000 (08:11 +0100)]
Fix missing_const_for_fn for impl trait methods
Philipp Hansch [Mon, 4 Mar 2019 21:56:33 +0000 (22:56 +0100)]
Don't trigger missing_const_for_fn in external macros
As reported in #3841. Only fixes the part where it triggers on the
`derive`.
Philipp Hansch [Mon, 4 Mar 2019 19:43:11 +0000 (20:43 +0100)]
Add rustc nightly docs to cheatsheet
Philipp Hansch [Mon, 4 Mar 2019 19:39:28 +0000 (20:39 +0100)]
s/you/we; One more checklist item
bors [Sun, 3 Mar 2019 15:09:00 +0000 (15:09 +0000)]
Auto merge of #3838 - mati865:rustup, r=phansch
Upgrade compiletest_rs to 0.3.19
Mateusz Mikuła [Sun, 3 Mar 2019 15:02:59 +0000 (16:02 +0100)]
Upgrade compiletest_rs to 0.3.19
Philipp Hansch [Sun, 3 Mar 2019 09:00:05 +0000 (10:00 +0100)]
Add the rustc guide to the cheatsheet
Philipp Hansch [Sun, 3 Mar 2019 08:50:56 +0000 (09:50 +0100)]
More text fixes after Test section was moved to top
Philipp Hansch [Sun, 3 Mar 2019 08:48:42 +0000 (09:48 +0100)]
Reword 'Setup' a bit
Philipp Hansch [Sat, 2 Mar 2019 15:29:11 +0000 (16:29 +0100)]
Note that stderr files don't have to be created manually
Philipp Hansch [Sat, 2 Mar 2019 15:25:05 +0000 (16:25 +0100)]
Author lint usage via playground
Philipp Hansch [Fri, 1 Mar 2019 06:32:51 +0000 (07:32 +0100)]
Run remark in `doc` directory, too.
Philipp Hansch [Fri, 1 Mar 2019 06:32:10 +0000 (07:32 +0100)]
Cleanup 'Writing code' in CONTRIBUTING.md
This is now all included in `doc/adding_lints.md`
Philipp Hansch [Fri, 1 Mar 2019 06:30:58 +0000 (07:30 +0100)]
Copy from CONTRIBUTING.md: author lint, rustfix tests, rustfmt
And adapt the wording a bit so that it fits in the overall guide.
Philipp Hansch [Thu, 28 Feb 2019 06:10:59 +0000 (07:10 +0100)]
Mention Clippy utils
Philipp Hansch [Thu, 28 Feb 2019 06:06:10 +0000 (07:06 +0100)]
Remind to run update-all-references.sh at the end
Philipp Hansch [Thu, 28 Feb 2019 06:00:22 +0000 (07:00 +0100)]
Use positive if condition for readability
Philipp Hansch [Wed, 27 Feb 2019 21:34:16 +0000 (22:34 +0100)]
Expand on lint implementation section, wrap lines
Wilco Kusee [Wed, 27 Feb 2019 21:15:33 +0000 (22:15 +0100)]
Implicit return
Co-Authored-By: phansch <dev@phansch.net>
Wilco Kusee [Wed, 27 Feb 2019 21:15:19 +0000 (22:15 +0100)]
Implicit return
Co-Authored-By: phansch <dev@phansch.net>