]> git.lizzy.rs Git - rust.git/log
rust.git
8 years agorustup 2015-09-24
Manish Goregaokar [Fri, 25 Sep 2015 13:22:36 +0000 (18:52 +0530)]
rustup 2015-09-24

8 years agoMerge branch 'pr-347'
Manish Goregaokar [Thu, 24 Sep 2015 06:31:18 +0000 (12:01 +0530)]
Merge branch 'pr-347'

8 years agoUpgrade Rust to rustc 1.5.0-nightly (b2f379cdc 2015-09-23)
Pietro Monteiro [Thu, 24 Sep 2015 00:30:39 +0000 (17:30 -0700)]
Upgrade Rust to rustc 1.5.0-nightly (b2f379cdc 2015-09-23)
Ident was removed in many HIR structures in favor of Name.

8 years agoMerge pull request #344 from Manishearth/reflet
llogiq [Tue, 22 Sep 2015 07:18:45 +0000 (09:18 +0200)]
Merge pull request #344 from Manishearth/reflet

Handle let ref in toplevel_ref_arg as well

8 years agoHandle let ref in toplevel_ref_arg as well
Manish Goregaokar [Tue, 22 Sep 2015 07:08:42 +0000 (12:38 +0530)]
Handle let ref in toplevel_ref_arg as well

8 years agoupdate lints
llogiq [Mon, 21 Sep 2015 04:24:46 +0000 (06:24 +0200)]
update lints

8 years agoMerge pull request #341 from Manishearth/issue340
llogiq [Sun, 20 Sep 2015 13:37:35 +0000 (15:37 +0200)]
Merge pull request #341 from Manishearth/issue340

generalize let_and_return for any block (closes #340)

8 years agogeneralize let_and_return for any block (closes #340)
Georg Brandl [Sun, 20 Sep 2015 11:57:27 +0000 (13:57 +0200)]
generalize let_and_return for any block (closes #340)

8 years agoUpdate README.md
Manish Goregaokar [Sat, 19 Sep 2015 13:46:59 +0000 (19:16 +0530)]
Update README.md

8 years agoFix stray backquote.
Georg Brandl [Sat, 19 Sep 2015 06:49:01 +0000 (08:49 +0200)]
Fix stray backquote.

8 years agofix dogfood
Manish Goregaokar [Sat, 19 Sep 2015 03:02:56 +0000 (08:32 +0530)]
fix dogfood

8 years agoUpgrade Rust to rustc 1.5.0-nightly (cff041170 2015-09-17)
Manish Goregaokar [Sat, 19 Sep 2015 02:53:04 +0000 (08:23 +0530)]
Upgrade Rust to rustc 1.5.0-nightly (cff041170 2015-09-17)

LintPass was split and ExprParen was removed from the HIR

Fixes #338

8 years agoMerge pull request #337 from Manishearth/indentfix
llogiq [Thu, 17 Sep 2015 05:44:39 +0000 (07:44 +0200)]
Merge pull request #337 from Manishearth/indentfix

fix indentation

8 years agoMerge pull request #336 from Manishearth/issue335
llogiq [Thu, 17 Sep 2015 05:43:26 +0000 (07:43 +0200)]
Merge pull request #336 from Manishearth/issue335

ref matches: false positive with only wildcard pattern match

8 years agofix indentation
Georg Brandl [Thu, 17 Sep 2015 05:27:18 +0000 (07:27 +0200)]
fix indentation

8 years agoref matches: false positive with only wildcard pattern match (fixes #335)
Georg Brandl [Thu, 17 Sep 2015 05:24:11 +0000 (07:24 +0200)]
ref matches: false positive with only wildcard pattern match (fixes #335)

8 years agoRustup to rustc 1.5.0-nightly (fc4d566b4 2015-09-16)
Manish Goregaokar [Thu, 17 Sep 2015 00:01:41 +0000 (05:31 +0530)]
Rustup to rustc 1.5.0-nightly (fc4d566b4 2015-09-16)

fixes #334

8 years agoMerge pull request #314 from nweston/loop-counter
Manish Goregaokar [Tue, 15 Sep 2015 16:07:37 +0000 (21:37 +0530)]
Merge pull request #314 from nweston/loop-counter

Lint for loops with explicit counter variable (#159)

8 years agoCheck for mutable borrow of counter variable
Nathan Weston [Thu, 10 Sep 2015 12:33:29 +0000 (08:33 -0400)]
Check for mutable borrow of counter variable

8 years agoImprove lint message
Nathan Weston [Thu, 10 Sep 2015 12:26:31 +0000 (08:26 -0400)]
Improve lint message

Remove trailing period and include snippet of loop argument.

8 years agoAdd is_integer_literal utility function
Nathan Weston [Fri, 4 Sep 2015 13:26:58 +0000 (09:26 -0400)]
Add is_integer_literal utility function

Replaces is_lit_zero and is_lit_one which were used in a couple of
places.

8 years agoNew lint: loop with explicit counter variable (fixes #159)
Nathan Weston [Sun, 23 Aug 2015 17:25:45 +0000 (13:25 -0400)]
New lint: loop with explicit counter variable (fixes #159)

Avoiding false positives here turns out to be fairly complicated.

8 years agoMerge pull request #332 from Manishearth/step_by
llogiq [Tue, 15 Sep 2015 07:16:49 +0000 (09:16 +0200)]
Merge pull request #332 from Manishearth/step_by

added fp test against negative .step_by(_)

8 years agoadded fp test against negative .step_by(_)
llogiq [Tue, 15 Sep 2015 07:12:58 +0000 (09:12 +0200)]
added fp test against negative .step_by(_)

8 years agoMerge pull request #331 from swgillespie/empty-range
Manish Goregaokar [Tue, 15 Sep 2015 05:36:30 +0000 (11:06 +0530)]
Merge pull request #331 from swgillespie/empty-range

implement iterating over an empty range lint as described in #330

8 years agouse the constant folder to generalize the lint a little bit and clean up the code...
swgillespie [Tue, 15 Sep 2015 05:20:56 +0000 (22:20 -0700)]
use the constant folder to generalize the lint a little bit and clean up the code. Add additional tests for things that should not be linted

8 years agoimplement empty range lint as described in #330
swgillespie [Tue, 15 Sep 2015 00:19:05 +0000 (17:19 -0700)]
implement empty range lint as described in #330

8 years agoMerge pull request #328 from Manishearth/falsepositives
Manish Goregaokar [Fri, 11 Sep 2015 14:01:36 +0000 (19:31 +0530)]
Merge pull request #328 from Manishearth/falsepositives

less false positives for approx_const and float_cmp

8 years agoremoved expensive crate check from approx_const
llogiq [Fri, 11 Sep 2015 13:59:19 +0000 (15:59 +0200)]
removed expensive crate check from approx_const

8 years agoless false positives for approx_const and float_cmp
llogiq [Fri, 11 Sep 2015 13:30:08 +0000 (15:30 +0200)]
less false positives for approx_const and float_cmp

8 years agoMerge pull request #326 from Manishearth/fix-323
llogiq [Thu, 10 Sep 2015 06:55:14 +0000 (08:55 +0200)]
Merge pull request #326 from Manishearth/fix-323

additional macro check + more tests

8 years agoadditional macro check + more tests
llogiq [Thu, 10 Sep 2015 06:51:14 +0000 (08:51 +0200)]
additional macro check + more tests

8 years agoMerge pull request #325 from durka/patch-1
llogiq [Thu, 10 Sep 2015 06:44:45 +0000 (08:44 +0200)]
Merge pull request #325 from durka/patch-1

add warning about different rustc versions

8 years agolink to wiki
Alex Burka [Thu, 10 Sep 2015 06:26:15 +0000 (02:26 -0400)]
link to wiki

8 years agoadd warning about different rustc versions
Alex Burka [Thu, 10 Sep 2015 06:06:52 +0000 (02:06 -0400)]
add warning about different rustc versions

Ref #322.

8 years agoadd cargo clippy link
Manish Goregaokar [Thu, 10 Sep 2015 01:31:28 +0000 (07:01 +0530)]
add cargo clippy link

8 years agoMerge pull request #321 from Manishearth/fix-319
llogiq [Tue, 8 Sep 2015 11:33:24 +0000 (13:33 +0200)]
Merge pull request #321 from Manishearth/fix-319

made shadow_unrelated allow, added previous binding span note,

8 years agomade shadow_unrelated allow, added previous binding span note, fixed #319
llogiq [Tue, 8 Sep 2015 09:50:04 +0000 (11:50 +0200)]
made shadow_unrelated allow, added previous binding span note, fixed #319

8 years agoMerge pull request #316 from Manishearth/mutmut
llogiq [Mon, 7 Sep 2015 21:22:30 +0000 (23:22 +0200)]
Merge pull request #316 from Manishearth/mutmut

Fix mut_mut false positive, make Allow (fixes #309)

8 years agoFix mut_mut false positive, make Allow (fixes #309)
Manish Goregaokar [Mon, 7 Sep 2015 20:58:15 +0000 (02:28 +0530)]
Fix mut_mut false positive, make Allow (fixes #309)

8 years agoMerge pull request #312 from Manishearth/pub_convention
llogiq [Mon, 7 Sep 2015 09:54:47 +0000 (11:54 +0200)]
Merge pull request #312 from Manishearth/pub_convention

split wrong_self_convention in pub/default visibility part

8 years agodamn autocorrect
llogiq [Mon, 7 Sep 2015 09:49:35 +0000 (11:49 +0200)]
damn autocorrect

8 years agoreplace if let by equality check
llogiq [Mon, 7 Sep 2015 09:46:04 +0000 (11:46 +0200)]
replace if let by equality check

8 years agosplit wrong_self_convention in pub/default visibility part
llogiq [Mon, 7 Sep 2015 07:17:45 +0000 (09:17 +0200)]
split wrong_self_convention in pub/default visibility part

8 years agoMerge pull request #310 from Manishearth/len_zero
Manish Goregaokar [Sun, 6 Sep 2015 19:09:24 +0000 (00:39 +0530)]
Merge pull request #310 from Manishearth/len_zero

fix false positive len_zero in is_empty()

8 years agode-closured the item name getter
Andre Bogus [Sun, 6 Sep 2015 19:03:09 +0000 (21:03 +0200)]
de-closured the item name getter

8 years agofix false positive len_zero in is_empty()
Andre Bogus [Sun, 6 Sep 2015 18:57:06 +0000 (20:57 +0200)]
fix false positive len_zero in is_empty()

8 years agoMerge pull request #308 from Manishearth/unit_cmp
llogiq [Sun, 6 Sep 2015 17:46:21 +0000 (19:46 +0200)]
Merge pull request #308 from Manishearth/unit_cmp

macro check for unit_cmp

8 years agofixed build
Andre Bogus [Sun, 6 Sep 2015 17:44:54 +0000 (19:44 +0200)]
fixed build

8 years agomacro check for unit_cmp
Andre Bogus [Sun, 6 Sep 2015 17:41:09 +0000 (19:41 +0200)]
macro check for unit_cmp

8 years agoMerge pull request #304 from Manishearth/bit_mask
Manish Goregaokar [Sun, 6 Sep 2015 14:34:43 +0000 (20:04 +0530)]
Merge pull request #304 from Manishearth/bit_mask

fixed bad_bit_mask false positive

8 years agofixed bad_bit_mask false positive
Andre Bogus [Sun, 6 Sep 2015 14:09:35 +0000 (16:09 +0200)]
fixed bad_bit_mask false positive

8 years agoMerge pull request #303 from inrustwetrust/master
llogiq [Sun, 6 Sep 2015 11:49:04 +0000 (13:49 +0200)]
Merge pull request #303 from inrustwetrust/master

Don't show the explicit_iter_loop lint for arrays with more than 32 elements

8 years agoDon't show the explicit_iter_loop lint for arrays with more than 32 elements
inrustwetrust [Sun, 6 Sep 2015 11:36:21 +0000 (13:36 +0200)]
Don't show the explicit_iter_loop lint for arrays with more than 32 elements

The IntoIterator trait is currently not implemented for arrays with more than
32 elements, so for longer arrays, the iter() or iter_mut() methods must be
used.

8 years agoMerge pull request #302 from Manishearth/macro
llogiq [Sun, 6 Sep 2015 10:55:15 +0000 (12:55 +0200)]
Merge pull request #302 from Manishearth/macro

More strict macro check

8 years agodogfooding a newly caught problem
Andre Bogus [Sun, 6 Sep 2015 08:59:06 +0000 (10:59 +0200)]
dogfooding a newly caught problem

8 years agoMore strict macro check
Andre Bogus [Sun, 6 Sep 2015 08:53:55 +0000 (10:53 +0200)]
More strict macro check

8 years agobump
Manish Goregaokar [Sun, 6 Sep 2015 00:17:51 +0000 (05:47 +0530)]
bump

8 years agoMerge pull request #300 from Manishearth/minmax
llogiq [Sat, 5 Sep 2015 14:27:09 +0000 (16:27 +0200)]
Merge pull request #300 from Manishearth/minmax

new lint: min_max

8 years agoadded test against const lookup
llogiq [Sat, 5 Sep 2015 14:24:41 +0000 (16:24 +0200)]
added test against const lookup

8 years agoupdate_lints
llogiq [Sat, 5 Sep 2015 12:22:33 +0000 (14:22 +0200)]
update_lints

8 years agoMade min_max `Warn` by default
llogiq [Sat, 5 Sep 2015 12:20:35 +0000 (14:20 +0200)]
Made min_max `Warn` by default

8 years agohir naming, removed lookup, match full path
llogiq [Sat, 5 Sep 2015 11:15:18 +0000 (13:15 +0200)]
hir naming, removed lookup, match full path

8 years agonew lint: min_max
llogiq [Sat, 5 Sep 2015 10:46:34 +0000 (12:46 +0200)]
new lint: min_max

8 years agoMerge pull request #299 from Manishearth/unicode_str
llogiq [Fri, 4 Sep 2015 12:27:26 +0000 (14:27 +0200)]
Merge pull request #299 from Manishearth/unicode_str

Unicode lints, second attempt: Lint whole strings, help with replacement

This fixes #85

8 years agofixed dogfood by using snippet instead of the (escaped) literal string
llogiq [Fri, 4 Sep 2015 12:24:49 +0000 (14:24 +0200)]
fixed dogfood by using snippet instead of the (escaped) literal string

8 years agoAdd false positive checks to unicode test
Manish Goregaokar [Fri, 4 Sep 2015 10:57:53 +0000 (16:27 +0530)]
Add false positive checks to unicode test

8 years agoUnicode lints, second attempt: Lint whole strings, help with replacement
llogiq [Fri, 4 Sep 2015 07:08:07 +0000 (09:08 +0200)]
Unicode lints, second attempt: Lint whole strings, help with replacement

8 years agoMerge pull request #298 from birkenfeld/as_mut
Manish Goregaokar [Fri, 4 Sep 2015 10:46:58 +0000 (16:16 +0530)]
Merge pull request #298 from birkenfeld/as_mut

methods: allow &mut self for as_ methods

8 years agoMerge pull request #295 from Manishearth/hir3
Manish Goregaokar [Fri, 4 Sep 2015 10:44:21 +0000 (16:14 +0530)]
Merge pull request #295 from Manishearth/hir3

Update rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb

8 years agomethods: allow &mut self for as_ methods
Georg Brandl [Fri, 4 Sep 2015 05:56:52 +0000 (07:56 +0200)]
methods: allow &mut self for as_ methods

8 years agoUpdate rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb (HIR+lints, Thu Sep 3 18...
Manish Goregaokar [Thu, 3 Sep 2015 14:42:17 +0000 (20:12 +0530)]
Update rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb (HIR+lints, Thu Sep 3 18:59:56 2015 +0530)

fixes #294

8 years agoMerge pull request #290 from Manishearth/float-cmp
Manish Goregaokar [Thu, 3 Sep 2015 10:19:54 +0000 (15:49 +0530)]
Merge pull request #290 from Manishearth/float-cmp

also ignore `ne` functions

8 years agoalso ignore functions
llogiq [Thu, 3 Sep 2015 08:57:11 +0000 (10:57 +0200)]
also ignore  functions

8 years agoMerge pull request #286 from Manishearth/fix-ice
Manish Goregaokar [Wed, 2 Sep 2015 20:47:39 +0000 (02:17 +0530)]
Merge pull request #286 from Manishearth/fix-ice

Fix ICE

8 years agoFix ICE
Manish Goregaokar [Wed, 2 Sep 2015 20:44:05 +0000 (02:14 +0530)]
Fix ICE

8 years agoMerge pull request #285 from Manishearth/contains_self
Georg Brandl [Wed, 2 Sep 2015 16:29:52 +0000 (18:29 +0200)]
Merge pull request #285 from Manishearth/contains_self

shadow: complete coverage of "contains_self" checker

8 years agoshadow: complete coverage of "contains_self" checker
Georg Brandl [Wed, 2 Sep 2015 16:17:38 +0000 (18:17 +0200)]
shadow: complete coverage of "contains_self" checker

8 years agoMerge pull request #284 from birkenfeld/is_methods
llogiq [Wed, 2 Sep 2015 15:21:42 +0000 (17:21 +0200)]
Merge pull request #284 from birkenfeld/is_methods

methods: allow multiple self kinds for "is_" methods

8 years agomethods: allow multiple self kinds for "is_" methods
Georg Brandl [Wed, 2 Sep 2015 15:14:23 +0000 (17:14 +0200)]
methods: allow multiple self kinds for "is_" methods

These can be static method predicates.  (Found one in rust-copperline,
called Term::is_unsupported_term().)

8 years agoMerge pull request #283 from birkenfeld/wording
Georg Brandl [Wed, 2 Sep 2015 15:13:08 +0000 (17:13 +0200)]
Merge pull request #283 from birkenfeld/wording

don't say "did you mean to" - use the standard "consider..."

8 years agodon't say "did you mean to" - use the standard "consider..."
Georg Brandl [Wed, 2 Sep 2015 14:46:12 +0000 (16:46 +0200)]
don't say "did you mean to" - use the standard "consider..."

"Did you mean to ..." sounds a bit condescending to me, since
if I meant to write "if let" I probably wouldn't have written "match" :)

8 years agoMerge pull request #280 from Manishearth/fx-279
llogiq [Wed, 2 Sep 2015 10:44:21 +0000 (12:44 +0200)]
Merge pull request #280 from Manishearth/fx-279

Only handle ranges starting with 0 for needless_range_loop (fixes #279)

8 years agoOnly handle ranges starting with 0 for needless_range_loop (fixes #279)
Manish Goregaokar [Wed, 2 Sep 2015 10:41:51 +0000 (16:11 +0530)]
Only handle ranges starting with 0 for needless_range_loop (fixes #279)

8 years agoMerge pull request #276 from Manishearth/float_cmp
Manish Goregaokar [Wed, 2 Sep 2015 10:17:41 +0000 (15:47 +0530)]
Merge pull request #276 from Manishearth/float_cmp

check item name for eq, fixes #268

8 years agocheck item name for eq, fixes #268
llogiq [Wed, 2 Sep 2015 08:30:11 +0000 (10:30 +0200)]
check item name for eq, fixes #268

8 years agoMerge pull request #275 from Manishearth/shadow
llogiq [Wed, 2 Sep 2015 06:56:12 +0000 (08:56 +0200)]
Merge pull request #275 from Manishearth/shadow

extended pattern matching

8 years agoreporting improvements
llogiq [Wed, 2 Sep 2015 06:19:47 +0000 (08:19 +0200)]
reporting improvements

8 years agomatch region patterns
llogiq [Wed, 2 Sep 2015 05:56:13 +0000 (07:56 +0200)]
match region patterns

8 years agoMerge branch 'shadow' of https://github.com/Manishearth/rust-clippy into shadow
llogiq [Wed, 2 Sep 2015 05:55:30 +0000 (07:55 +0200)]
Merge branch 'shadow' of https://github.com/Manishearth/rust-clippy into shadow

8 years agoextended pattern matching
llogiq [Tue, 1 Sep 2015 23:36:37 +0000 (01:36 +0200)]
extended pattern matching

8 years agoextended pattern matching
llogiq [Tue, 1 Sep 2015 23:36:37 +0000 (01:36 +0200)]
extended pattern matching

8 years agoextended pattern matching
llogiq [Tue, 1 Sep 2015 23:36:37 +0000 (01:36 +0200)]
extended pattern matching

8 years agoMerge pull request #274 from birkenfeld/copy_fix
Manish Goregaokar [Tue, 1 Sep 2015 19:54:42 +0000 (01:24 +0530)]
Merge pull request #274 from birkenfeld/copy_fix

methods: try to allow value self when type is Copy (fixes #273)

8 years agomethods: try to allow value self when type is Copy (fixes #273)
Georg Brandl [Tue, 1 Sep 2015 19:08:49 +0000 (21:08 +0200)]
methods: try to allow value self when type is Copy (fixes #273)

8 years agoMerge pull request #272 from birkenfeld/conventions
Manish Goregaokar [Tue, 1 Sep 2015 16:55:19 +0000 (22:25 +0530)]
Merge pull request #272 from birkenfeld/conventions

new lint: self conventions for certain method names (fixes #267)

8 years agonew lint: self conventions for certain method names (fixes #267)
Georg Brandl [Tue, 1 Sep 2015 16:52:48 +0000 (18:52 +0200)]
new lint: self conventions for certain method names (fixes #267)

8 years agoMerge pull request #271 from birkenfeld/lint_groups
llogiq [Tue, 1 Sep 2015 16:24:33 +0000 (18:24 +0200)]
Merge pull request #271 from birkenfeld/lint_groups

lib: add clippy_pedantic group with all Allow by default lints (fixes #265)

8 years agolib: add clippy_pedantic group with all Allow by default lints (fixes #265)
Georg Brandl [Tue, 1 Sep 2015 15:53:56 +0000 (17:53 +0200)]
lib: add clippy_pedantic group with all Allow by default lints (fixes #265)

8 years agoMerge pull request #270 from jedisct1/nightly
llogiq [Tue, 1 Sep 2015 12:54:21 +0000 (14:54 +0200)]
Merge pull request #270 from jedisct1/nightly

Yet another fix for rust-nightly