]>
git.lizzy.rs Git - rust.git/log
Josh Mcguigan [Fri, 12 Oct 2018 11:34:41 +0000 (04:34 -0700)]
cmp_owned correct error message if rhs is deref
Josh Mcguigan [Thu, 11 Oct 2018 12:03:02 +0000 (05:03 -0700)]
cmp_owned current suggestion for multiple deref
Josh Mcguigan [Wed, 10 Oct 2018 11:51:06 +0000 (04:51 -0700)]
cmp_owned add test for multiple dereference
Josh Mcguigan [Wed, 10 Oct 2018 03:01:12 +0000 (20:01 -0700)]
Corrected single-character string constant used as pattern found in dogfood test
Josh Mcguigan [Wed, 10 Oct 2018 02:25:03 +0000 (19:25 -0700)]
Fixes 3289, cmp_owned wording and false positive
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 9 Oct 2018 08:01:31 +0000 (10:01 +0200)]
Merge pull request #3287 from JoshMcguigan/cmp_owned-2925
cmp_owned false positive
Josh Mcguigan [Tue, 9 Oct 2018 02:04:29 +0000 (19:04 -0700)]
Fixes #2925 cmp_owned false positive
Philipp Hansch [Mon, 8 Oct 2018 19:54:08 +0000 (21:54 +0200)]
Merge pull request #3278 from d-dorazio/fix-contributing-manual-test-command
contributing.md: fix command to manually test an example
Philipp Hansch [Mon, 8 Oct 2018 19:31:04 +0000 (21:31 +0200)]
Merge pull request #3234 from matthiaskrgr/fix_3064_crash
if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash.
Matthias Krüger [Fri, 28 Sep 2018 19:09:57 +0000 (21:09 +0200)]
if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash.
Fixes #3064
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 11:52:19 +0000 (13:52 +0200)]
Merge pull request #3286 from vmalloc/lifetime_elision_msg
Improve diagnostics in case of lifetime elision (closes #3284)
Rotem Yaari [Mon, 8 Oct 2018 08:43:13 +0000 (11:43 +0300)]
Improve diagnostics in case of lifetime elision (closes #3284)
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 06:24:13 +0000 (08:24 +0200)]
Merge pull request #3282 from JoshMcguigan/excessive_precision-2840
Fix excessive_precision false positive
Philipp Hansch [Mon, 8 Oct 2018 06:22:09 +0000 (07:22 +0100)]
Merge pull request #3265 from mikerite/fix-export
Fix util/export.py to include lints from methods
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Mon, 8 Oct 2018 06:21:59 +0000 (08:21 +0200)]
Merge pull request #3283 from etaoins/dont-suggest-cloned-for-map-box-deref
Don't suggest cloned() for map Box deref
Philipp Hansch [Mon, 8 Oct 2018 05:59:55 +0000 (06:59 +0100)]
Merge pull request #3285 from devonhollowood/pedantic-dogfood-items-after-statements
Pedantic dogfood: `items_after_statements`
Devon Hollowood [Mon, 8 Oct 2018 00:08:20 +0000 (17:08 -0700)]
Fix items_after_statements for `const`s
Devon Hollowood [Mon, 8 Oct 2018 00:07:10 +0000 (17:07 -0700)]
Fix items_after_statements for sub-functions
Devon Hollowood [Mon, 8 Oct 2018 00:05:28 +0000 (17:05 -0700)]
Fix items_after_statements for `use` statements
Ryan Cumming [Sun, 7 Oct 2018 19:20:32 +0000 (06:20 +1100)]
Don't suggest cloned() for map Box deref
Boxes are a bit magic in that they need to use `*` to get an owned value
out of the box. They implement `Deref` but that only returns a
reference. This means an easy way to convert an `Option<Box<T>>` to an
`<Option<T>` is:
```
box_option.map(|b| *b)
```
However, since
b36bb0a6 the `map_clone` lint is detecting this as an
attempt to copy the box. Fix by excluding boxes completely from the
deref part of this lint.
Fixes #3274
Josh Mcguigan [Sun, 7 Oct 2018 18:38:20 +0000 (11:38 -0700)]
Fix excessive_precision false positive
Philipp Hansch [Sun, 7 Oct 2018 12:09:37 +0000 (13:09 +0100)]
Merge pull request #3280 from d-dorazio/fix-new_without_default-should-not-fire-unsafe-new
new_without_default should not warn about unsafe new
Manish Goregaokar [Sun, 7 Oct 2018 11:27:51 +0000 (04:27 -0700)]
Merge pull request #3279 from phansch/fix_fp_in_fn_to_numeric_cast_with_truncation
Fix FP in `fn_to_numeric_cast_with_truncation`
Philipp Hansch [Sun, 7 Oct 2018 10:18:40 +0000 (12:18 +0200)]
Fix FP in `fn_to_numeric_cast_with_truncation`
We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts
[here][rust_check].
[rust_check]: https://github.com/rust-lang/rust/blob/
5472b0718f286266ab89acdf234c3552de7e973c /src/librustc_typeck/check/cast.rs#L430-L433
Daniele D'Orazio [Sun, 7 Oct 2018 10:39:54 +0000 (12:39 +0200)]
new_without_default should not warn about unsafe new
Daniele D'Orazio [Sat, 6 Oct 2018 18:07:41 +0000 (20:07 +0200)]
fix command to manually test an example
Philipp Hansch [Sun, 7 Oct 2018 09:02:46 +0000 (10:02 +0100)]
Merge pull request #3273 from maccoda/master
Adding more detail to filter_map lint documentation.
Manish Goregaokar [Sun, 7 Oct 2018 02:29:01 +0000 (19:29 -0700)]
Add license to README
Dylan Maccora [Sun, 7 Oct 2018 00:24:09 +0000 (11:24 +1100)]
Adding more detail to filter_map lint documentation.
Manish Goregaokar [Sat, 6 Oct 2018 17:21:57 +0000 (10:21 -0700)]
Merge pull request #3269 from rust-lang-nursery/relicense
Relicense clippy to the Rust license
Manish Goregaokar [Sat, 6 Oct 2018 17:20:48 +0000 (10:20 -0700)]
additional people
Manish Goregaokar [Sat, 6 Oct 2018 16:23:54 +0000 (09:23 -0700)]
Add license header to other files
Manish Goregaokar [Sat, 6 Oct 2018 16:18:06 +0000 (09:18 -0700)]
Add license header to Rust files
Manish Goregaokar [Fri, 5 Oct 2018 19:37:50 +0000 (12:37 -0700)]
Relicense clippy
Documentation on relicensing in previous commit
Fixes #2885
Also fixes #3093, fixes #3094, fixes 3095, fixes #3096, fixes #3097, fixes #3098,
fixes #3099, fixes #3100, fixes #3230
Manish Goregaokar [Fri, 5 Oct 2018 19:34:15 +0000 (12:34 -0700)]
Document relicensing process
Manish Goregaokar [Sat, 6 Oct 2018 05:35:04 +0000 (22:35 -0700)]
Merge pull request #3270 from rust-lang-nursery/rustup
Rustup for https://github.com/rust-lang/rust/pull/54741
Manish Goregaokar [Fri, 5 Oct 2018 20:41:40 +0000 (13:41 -0700)]
Rustup for https://github.com/rust-lang/rust/pull/54741
Manish Goregaokar [Fri, 5 Oct 2018 20:26:39 +0000 (13:26 -0700)]
Remove unused utils
Manish Goregaokar [Fri, 5 Oct 2018 18:14:55 +0000 (20:14 +0200)]
Merge pull request #3251 from rust-lang-nursery/relicense-rewrite
[do not merge] Relicensing rewrite
Philipp Krones [Fri, 5 Oct 2018 16:10:48 +0000 (18:10 +0200)]
Merge pull request #3268 from matthiaskrgr/rustup_macros_20
mini-macro: fix tests with latest rustc (rename feature: proc_macro_non_items -> proc_macro_hygiene).
Matthias Krüger [Fri, 5 Oct 2018 13:52:51 +0000 (15:52 +0200)]
mini-macro: fix tests with latest rustc (rename feature: proc_macro_non_items -> proc_macro_hygiene).
Philipp Krones [Fri, 5 Oct 2018 12:25:30 +0000 (14:25 +0200)]
Merge pull request #3267 from matthiaskrgr/travis_osx
travis: reenable osx
Matthias Krüger [Fri, 5 Oct 2018 10:01:52 +0000 (12:01 +0200)]
travis: reenable osx
Philipp Hansch [Fri, 5 Oct 2018 06:04:19 +0000 (07:04 +0100)]
Merge pull request #3264 from joelgallant/extern-type-complexity
Fixes #3222 by checking the BareFnTy Abi type
Michael Wright [Fri, 5 Oct 2018 06:02:44 +0000 (08:02 +0200)]
Fix util/export.py to include lints from methods
Philipp Hansch [Fri, 5 Oct 2018 05:49:08 +0000 (07:49 +0200)]
Fix fn_to_numeric_cast UI tests
This collapses both lint tests into one file.
Somehow allowing the other lint in the respective files did not work
correctly. Maybe that's fixed as part of fixing #3198.
Philipp Hansch [Fri, 5 Oct 2018 05:18:24 +0000 (07:18 +0200)]
Merge remote-tracking branch 'origin/master' into relicense-rewrite
Joel Gallant [Thu, 4 Oct 2018 23:30:45 +0000 (17:30 -0600)]
Solves #3222 by checking the BareFnTy Abi type
Philipp Hansch [Thu, 4 Oct 2018 20:26:54 +0000 (22:26 +0200)]
Only run tests if pointer width is 64bit
If the pointer width of the architechture is 32bit or something else,
then the tests will most likely produce different results.
Philipp Hansch [Thu, 4 Oct 2018 19:59:30 +0000 (21:59 +0200)]
Add hidden lifetime parameters to fix warning
Philipp Hansch [Thu, 4 Oct 2018 19:45:53 +0000 (20:45 +0100)]
Merge pull request #3259 from matthiaskrgr/build_warnings
resolve build warnings in clippy_lints/src/format.rs
Philipp Hansch [Thu, 4 Oct 2018 19:44:16 +0000 (21:44 +0200)]
Reimplement the `fn_to_numeric_cast_with_truncation` lint
Philipp Hansch [Thu, 4 Oct 2018 16:09:09 +0000 (18:09 +0200)]
Improve docs of fn_to_numeric_cast
Closes #2980
Philipp Krones [Thu, 4 Oct 2018 16:02:22 +0000 (18:02 +0200)]
Merge pull request #3261 from matthiaskrgr/travis_failure
make sure travis fails when clippy does not build.
Matthias Krüger [Thu, 4 Oct 2018 14:58:51 +0000 (16:58 +0200)]
make sure travis fails when clippy does not build.
Fixes #3260
Matthias Krüger [Thu, 4 Oct 2018 14:34:41 +0000 (16:34 +0200)]
resolve build warnings in clippy_lints/src/format.rs
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 4 Oct 2018 06:51:23 +0000 (08:51 +0200)]
Merge pull request #3255 from o01eg/env_logger
Allow to debug rustc_driver via logs.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 4 Oct 2018 06:51:00 +0000 (08:51 +0200)]
Merge pull request #3256 from rust-lang-nursery/fix-2796
Fix 2796 and 3020
mcarton [Wed, 3 Oct 2018 18:59:59 +0000 (20:59 +0200)]
Don't suggest `to_string().to_string` in USELESS_FORMAT
O01eg [Wed, 3 Oct 2018 18:41:02 +0000 (21:41 +0300)]
Allow to debug rustc_driver via logs.
Philipp Hansch [Wed, 3 Oct 2018 10:02:06 +0000 (12:02 +0200)]
Reimplement the `fn_to_numeric_cast` lint
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 3 Oct 2018 09:48:31 +0000 (11:48 +0200)]
Merge pull request #3252 from rust-lang-nursery/rustup
Fix push_item_path call (rustup to
4cf11765dc98536c6eedf33f2df7f72f6e161263 )
Manish Goregaokar [Wed, 3 Oct 2018 09:02:50 +0000 (02:02 -0700)]
mcarton [Tue, 2 Oct 2018 21:55:25 +0000 (23:55 +0200)]
Ignore `format!` with precision in `USELESS_FORMAT`
mcarton [Tue, 2 Oct 2018 21:54:50 +0000 (23:54 +0200)]
Add test for variable width in `USELESS_FORMAT`
Oliver Schneider [Tue, 2 Oct 2018 13:18:56 +0000 (15:18 +0200)]
Trailing newline
Oliver Schneider [Tue, 2 Oct 2018 13:17:56 +0000 (15:17 +0200)]
FIx dogfood
Oliver Schneider [Tue, 2 Oct 2018 13:13:43 +0000 (15:13 +0200)]
Reimplement the `map_clone` lint from scratch
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 2 Oct 2018 12:54:36 +0000 (14:54 +0200)]
Merge pull request #3245 from JoshMcguigan/wrong_self_convention-1530
Correct false positive in wrong_self_convention lint for to_mut
Josh Mcguigan [Mon, 1 Oct 2018 11:47:06 +0000 (04:47 -0700)]
Correct false positive in wrong_self_convention lint for to_mut
Manish Goregaokar [Tue, 2 Oct 2018 10:51:38 +0000 (12:51 +0200)]
relicensing: Remove map_clone
This removes the code added in https://github.com/rust-lang-nursery/rust-clippy/pull/427
Manish Goregaokar [Tue, 2 Oct 2018 10:41:40 +0000 (12:41 +0200)]
relicensing: Remove fn_to_numeric_cast, fn_to_numeric_cast_with_truncation
This removes the code added in https://github.com/rust-lang-nursery/rust-clippy/pull/2814
Manish Goregaokar [Tue, 2 Oct 2018 10:20:14 +0000 (12:20 +0200)]
Merge pull request #3243 from flip1995/appveyor_disable_dogfood
Disable dogfood under windows until rust-lang-nursery/rustup.rs#1499 is merged
Manish Goregaokar [Tue, 2 Oct 2018 09:10:40 +0000 (11:10 +0200)]
Merge pull request #3249 from rust-lang-nursery/rustup
ScalarMaybeUndef -> Scalar (Rustup to
e812ca472a2a5284e9f15cd9af32285d7ff3fd39 )
Manish Goregaokar [Tue, 2 Oct 2018 09:03:39 +0000 (11:03 +0200)]
Merge pull request #3250 from rust-lang-nursery/levels-readme
Mention -A and -W in readme
Manish Goregaokar [Tue, 2 Oct 2018 08:39:51 +0000 (10:39 +0200)]
Mention -A and -W in readme
Manish Goregaokar [Tue, 2 Oct 2018 08:35:26 +0000 (10:35 +0200)]
Manish Goregaokar [Tue, 2 Oct 2018 08:03:03 +0000 (10:03 +0200)]
Merge pull request #3247 from rust-lang-nursery/dummy
Add dummy clippy crate for publishing
Manish Goregaokar [Tue, 2 Oct 2018 07:58:02 +0000 (09:58 +0200)]
publish = false
Manish Goregaokar [Mon, 1 Oct 2018 20:03:07 +0000 (22:03 +0200)]
Add dummy clippy crate for publishing
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 2 Oct 2018 07:18:09 +0000 (09:18 +0200)]
Merge pull request #3248 from phansch/fix_ice_2831
Fix 'impossible case reached' ICE
Philipp Hansch [Mon, 1 Oct 2018 20:33:20 +0000 (22:33 +0200)]
Fix 'impossible case reached' ICE
flip1995 [Sun, 30 Sep 2018 10:59:15 +0000 (12:59 +0200)]
Disable dogfood until rust-lang-nursery/rustup.rs#1499 is merged
Philipp Krones [Sun, 30 Sep 2018 10:27:44 +0000 (12:27 +0200)]
Merge pull request #3242 from matthiaskrgr/rm_cargo_ed_feat
remove cargo edition 2018 feature gate.
Philipp Hansch [Sun, 30 Sep 2018 10:12:49 +0000 (11:12 +0100)]
Merge pull request #3241 from phansch/remove_clippy_service
Remove clippy-service update from CI
Philipp Hansch [Sun, 30 Sep 2018 09:28:35 +0000 (11:28 +0200)]
Remove clippy-service token
Matthias Krüger [Sun, 30 Sep 2018 09:12:24 +0000 (11:12 +0200)]
remove cargo edition 2018 feature gate.
Rust and the cargo used to bootstrap was updated in https://github.com/rust-lang/rust/pull/54601 which now has the 2018 edition stabilized.
Philipp Hansch [Sun, 30 Sep 2018 08:57:16 +0000 (09:57 +0100)]
Merge pull request #3240 from matthiaskrgr/travis_3239
travis: sleep after putting out logs (try to fix truncated logs)
Philipp Hansch [Sun, 2 Sep 2018 11:20:30 +0000 (13:20 +0200)]
Remove clippy-service update from CI
clippy-service hasn't been working for a long time now.
Matthias Krüger [Sun, 30 Sep 2018 08:30:51 +0000 (10:30 +0200)]
travis: sleep after putting out logs (try to fix truncated logs)
Philipp Hansch [Sun, 30 Sep 2018 07:16:33 +0000 (08:16 +0100)]
Merge pull request #3223 from mikerite/unnecessary_filter_map
Implement unnecesary_filter_map lint
Michael Wright [Sun, 30 Sep 2018 04:39:56 +0000 (06:39 +0200)]
Merge branch 'master' into unnecessary_filter_map
Michael Wright [Sun, 30 Sep 2018 04:25:23 +0000 (06:25 +0200)]
Fix update_lints.py for dir modules
Philipp Hansch [Sat, 29 Sep 2018 18:33:21 +0000 (19:33 +0100)]
Merge pull request #3235 from matthiaskrgr/rustc_tools__beta_fix
rustc_tools_util: don't require test feature.
Matthias Krüger [Sat, 29 Sep 2018 17:33:30 +0000 (19:33 +0200)]
rustc_tools_util: remove test and tool_lints features, both are actually unused.
Fixes build with beta.
Philipp Krones [Sat, 29 Sep 2018 15:46:15 +0000 (17:46 +0200)]
Merge pull request #3238 from JoshMcguigan/excessive_precision-3180
Fixes #3180, suppress excessive_precision lint for floats with no decimal part
Josh Mcguigan [Sat, 29 Sep 2018 14:39:30 +0000 (07:39 -0700)]
Fixes #3180, suppress excessive_precision lint for floats with no decimal part
Michael Wright [Sat, 29 Sep 2018 13:27:47 +0000 (15:27 +0200)]
Merge branch 'master' into unnecessary_filter_map
Michael Wright [Sat, 29 Sep 2018 12:18:50 +0000 (14:18 +0200)]
rustfmt
Michael Wright [Sat, 29 Sep 2018 12:12:40 +0000 (14:12 +0200)]
Move unnecessary_filter_map to a submodule