]>
git.lizzy.rs Git - rust.git/log
Takayuki Maeda [Sat, 6 Mar 2021 13:26:29 +0000 (22:26 +0900)]
move expect_fun_call to its own module
Takayuki Maeda [Sat, 6 Mar 2021 10:40:34 +0000 (19:40 +0900)]
move or_fun_call to its own module
Takayuki Maeda [Sat, 6 Mar 2021 10:31:46 +0000 (19:31 +0900)]
move map_unwrap_or to its own module
Takayuki Maeda [Sat, 6 Mar 2021 10:11:52 +0000 (19:11 +0900)]
move option_map_or_none to its own module
Takayuki Maeda [Sat, 6 Mar 2021 10:05:51 +0000 (19:05 +0900)]
unnecessary_fold to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:59:35 +0000 (18:59 +0900)]
move useless_asref to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:53:31 +0000 (18:53 +0900)]
move clone_on_copy to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:45:25 +0000 (18:45 +0900)]
move iter_skip_next to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:41:43 +0000 (18:41 +0900)]
move map_flatten and search_is_some to their own modules
Takayuki Maeda [Sat, 6 Mar 2021 09:30:40 +0000 (18:30 +0900)]
move flat_map_identity to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:22:15 +0000 (18:22 +0900)]
move filter_map_flat_map to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:19:18 +0000 (18:19 +0900)]
move filter_flat_map to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:11:42 +0000 (18:11 +0900)]
move filter_map_next to its own module
Takayuki Maeda [Sat, 6 Mar 2021 09:05:15 +0000 (18:05 +0900)]
move filter_map_map to its own module
Takayuki Maeda [Sat, 6 Mar 2021 08:55:29 +0000 (17:55 +0900)]
move filter_map to its own module
Takayuki Maeda [Sat, 6 Mar 2021 08:46:50 +0000 (17:46 +0900)]
move from_iter_insteam_of_collect to its own module
Takayuki Maeda [Sat, 6 Mar 2021 08:28:14 +0000 (17:28 +0900)]
move into_iter_on_ref and single_char_pattern to their own modules
Takayuki Maeda [Sat, 6 Mar 2021 06:39:28 +0000 (15:39 +0900)]
move single_char_push_string to its own module
Takayuki Maeda [Sat, 6 Mar 2021 06:29:02 +0000 (15:29 +0900)]
move single_char_insert_string to its own module
Takayuki Maeda [Thu, 4 Mar 2021 15:16:43 +0000 (00:16 +0900)]
move string_extend_chars and clone_on_ref_ptr to their own module
Takayuki Maeda [Thu, 4 Mar 2021 14:47:30 +0000 (23:47 +0900)]
move wrong_self_convention to its own module
Takayuki Maeda [Thu, 4 Mar 2021 14:06:05 +0000 (23:06 +0900)]
move iter_nth, iter_nth_zero and iterator_step_by_zero to their own module
Takayuki Maeda [Thu, 4 Mar 2021 13:50:53 +0000 (22:50 +0900)]
move iter_next_slice to its own module
Takayuki Maeda [Thu, 4 Mar 2021 10:47:06 +0000 (19:47 +0900)]
move map_collect_result_unit to its own module
Takayuki Maeda [Thu, 4 Mar 2021 10:46:44 +0000 (19:46 +0900)]
move zst_offset to its own module
Takayuki Maeda [Tue, 2 Mar 2021 16:16:16 +0000 (01:16 +0900)]
replace `lints` and `lint` with `check`
Takayuki Maeda [Tue, 2 Mar 2021 16:09:33 +0000 (01:09 +0900)]
move iter_cloned_collect to its own module
Takayuki Maeda [Tue, 2 Mar 2021 16:03:47 +0000 (01:03 +0900)]
move uninit_assumed_init to its own module
Takayuki Maeda [Tue, 2 Mar 2021 15:55:19 +0000 (00:55 +0900)]
move filetype_is_file to its own module
Takayuki Maeda [Tue, 2 Mar 2021 15:48:21 +0000 (00:48 +0900)]
move suspicious_map to its own module
Takayuki Maeda [Tue, 2 Mar 2021 15:43:27 +0000 (00:43 +0900)]
move option_as_ref_deref to its own module
Takayuki Maeda [Tue, 2 Mar 2021 15:31:15 +0000 (00:31 +0900)]
move skip_while_next to its own module
Takayuki Maeda [Tue, 2 Mar 2021 15:14:38 +0000 (00:14 +0900)]
move expect_used, filter_next, get_unwrap, ok_expect and unwrap_used to their own modules
bors [Thu, 11 Mar 2021 10:08:29 +0000 (10:08 +0000)]
Auto merge of #6881 - flip1995:rustup, r=flip1995
Rustup
changelog: none
flip1995 [Thu, 11 Mar 2021 09:57:49 +0000 (10:57 +0100)]
Fix remaining dogfood errors (internal lints)
flip1995 [Thu, 11 Mar 2021 09:38:49 +0000 (10:38 +0100)]
Bump nightly version => 2021-03-11
flip1995 [Thu, 11 Mar 2021 09:37:58 +0000 (10:37 +0100)]
Merge remote-tracking branch 'upstream/master' into rustup
bors [Wed, 10 Mar 2021 16:40:33 +0000 (16:40 +0000)]
Auto merge of #6814 - hyd-dev:issue-6486, r=flip1995
Fix false positives on procedural macros of `missing_inline_in_public_items` lint
Fixes #6486.
changelog: Fix false positives on procedural macros of `missing_inline_in_public_items` lint.
bors [Wed, 10 Mar 2021 16:27:18 +0000 (16:27 +0000)]
Auto merge of #6794 - camsteffen:needless-borrowed-ref, r=flip1995
Improve needless_borrowed_ref docs
changelog: none
I think "borrowed ref" is a confusing description for this lint. Destructuring a reference is the opposite of borrowing. So I updated the wording throughout the docs. Unfortunately this nit applies to the name of the lint itself, but I won't bother changing that. One motivation for these changes is to clarify the difference between this lint and `needless_borrow` (they are actually quite different). Let me know if I need to clarify anything or if you disagree with any changes.
bors [Wed, 10 Mar 2021 08:40:51 +0000 (08:40 +0000)]
Auto merge of #79519 - cjgillot:noattr, r=wesleywiser
Store HIR attributes in a side table
Same idea as #72015 but for attributes.
The objective is to reduce incr-comp invalidations due to modified attributes.
Notably, those due to modified doc comments.
Implementation:
- collect attributes during AST->HIR lowering, in `LocalDefId -> ItemLocalId -> &[Attributes]` nested tables;
- access the attributes through a `hir_owner_attrs` query;
- local refactorings to use this access;
- remove `attrs` from HIR data structures one-by-one.
Change in behaviour:
- the HIR visitor traverses all attributes at once instead of parent-by-parent;
- attribute arrays are sometimes duplicated: for statements and variant constructors;
- as a consequence, attributes are marked as used after unused-attribute lint emission to avoid duplicate lints.
~~Current bug: the lint level is not correctly applied in `std::backtrace_rs`, triggering an unused attribute warning on `#![no_std]`. I welcome suggestions.~~
bors [Tue, 9 Mar 2021 18:42:09 +0000 (18:42 +0000)]
Auto merge of #6878 - flip1995:authors, r=Manishearth
Set Clippy authors to "The Rust Clippy Developers"
Clippy has grown enough, that putting specific people in the "authors"
field isn't warranted anymore.
As a heads-up: `@Manishearth` `@llogiq` `@birkenfeld` `@mcarton` `@oli-obk` `@phansch` `@matthiaskrgr` your names will be removed from one or more of the `Cargo.toml` files of Clippy. This of course does not mean that we value your previous work on Clippy any less :heart:
As per our discussion in today's meeting: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Meeting.202021-03-09/near/
229502514
changelog: none
Camille GILLOT [Fri, 27 Nov 2020 16:41:05 +0000 (17:41 +0100)]
Remove hir::Expr::attrs.
Camille GILLOT [Sun, 24 Jan 2021 12:17:54 +0000 (13:17 +0100)]
Remove hir::Item::attrs.
Camille GILLOT [Fri, 27 Nov 2020 08:55:10 +0000 (09:55 +0100)]
Remove hir::ImplItem::attrs.
Camille GILLOT [Fri, 27 Nov 2020 08:41:53 +0000 (09:41 +0100)]
Remove hir::TraitItem::attrs.
Camille GILLOT [Thu, 26 Nov 2020 23:27:34 +0000 (00:27 +0100)]
Remove hir::StructField::attrs.
Camille GILLOT [Thu, 26 Nov 2020 23:07:36 +0000 (00:07 +0100)]
Remove hir::Variant::attrs.
Camille GILLOT [Thu, 26 Nov 2020 22:46:48 +0000 (23:46 +0100)]
Remove hir::Arm::attrs.
Camille GILLOT [Thu, 26 Nov 2020 22:38:53 +0000 (23:38 +0100)]
Remove hir::Crate::attrs.
Camille GILLOT [Wed, 25 Nov 2020 21:45:24 +0000 (22:45 +0100)]
Remove hir::Local::attrs.
Camille GILLOT [Wed, 25 Nov 2020 21:07:09 +0000 (22:07 +0100)]
Remove hir::StmtKind::attrs.
Camille GILLOT [Fri, 27 Nov 2020 08:24:42 +0000 (09:24 +0100)]
Do not store attrs in FnKind.
Camille GILLOT [Sun, 6 Dec 2020 21:00:24 +0000 (22:00 +0100)]
Simplify clippy author.
kadmin [Sat, 23 Jan 2021 08:57:04 +0000 (08:57 +0000)]
Switch to changing cp_non_overlap in tform
It was suggested to lower this in MIR instead of ssa, so do that instead.
kadmin [Tue, 29 Dec 2020 02:00:04 +0000 (02:00 +0000)]
Update cranelift
kadmin [Mon, 5 Oct 2020 22:53:00 +0000 (22:53 +0000)]
Update match branches
This updates all places where match branches check on StatementKind or UseContext.
This doesn't properly implement them, but adds TODOs where they are, and also adds some best
guesses to what they should be in some cases.
flip1995 [Tue, 9 Mar 2021 16:50:04 +0000 (17:50 +0100)]
Set Clippy authors to "The Rust Clippy Developers"
Clippy has grown enough, that putting specific people in the "authors"
field is warranted anymore.
bors [Tue, 9 Mar 2021 15:18:16 +0000 (15:18 +0000)]
Auto merge of #6876 - giraffate:improve_doc_on_map_flatten, r=flip1995
Improve doc on `map_flatten`
Fix https://github.com/rust-lang/rust-clippy/issues/6870. It's because this doc lacks the description that this lint is also used for `Option`.
changelog: none
Takayuki Nakata [Tue, 9 Mar 2021 15:02:24 +0000 (00:02 +0900)]
Improve doc on `map_flatten`
bors [Tue, 9 Mar 2021 14:58:24 +0000 (14:58 +0000)]
Auto merge of #6866 - anall:ice6840, r=flip1995
Fix ICE 6840 - make is_normalizable more strict
fixes #6840
make `is_normalizable` more strict, which should catch this ICE and related cases
changelog: Fix ICE in [`zero_sized_map_values`]
Andrea Nall [Tue, 9 Mar 2021 14:30:33 +0000 (08:30 -0600)]
add comment for when can be removed
bors [Tue, 9 Mar 2021 14:28:49 +0000 (14:28 +0000)]
Auto merge of #6868 - Jarcho:lang_item, r=flip1995
Don't assume lang items will exist.
~~Should fix lintcheck warnings caused by #6823~~
See below
changelog: None
bors [Tue, 9 Mar 2021 12:43:20 +0000 (12:43 +0000)]
Auto merge of #6873 - Y-Nak:refactor-casts-lint, r=flip1995
Refactor casts lint
Ref: #6724
Changes:
1. Separate the `casts` group from the `types` group.
2. Reorganize the lints of the `casts` group into their own modules.
Notes:
1. I didn't `fix` #6874 in order to maintain this PR as small as possible.
---
changelog: none
Yoshitomo Nakanishi [Tue, 9 Mar 2021 11:04:19 +0000 (20:04 +0900)]
Move ptr_as_ptr to its own module
Mara Bos [Tue, 9 Mar 2021 09:05:20 +0000 (09:05 +0000)]
Rollup merge of #82048 - mark-i-m:or-pat-type-ascription, r=petrochenkov
or-patterns: disallow in `let` bindings
~~Blocked on https://github.com/rust-lang/rust/pull/81869~~
Disallows top-level or-patterns before type ascription. We want to reserve this syntactic space for possible future generalized type ascription.
r? ``@petrochenkov``
Yoshitomo Nakanishi [Tue, 9 Mar 2021 08:28:56 +0000 (17:28 +0900)]
Move char_lit_as_u8 to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 08:22:21 +0000 (17:22 +0900)]
Move cast_ref_to_mut to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 08:15:18 +0000 (17:15 +0900)]
Move cast_ptr_alignment to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 08:06:25 +0000 (17:06 +0900)]
Move fn_to_numeric_cast_with_truncation to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 08:03:07 +0000 (17:03 +0900)]
Move fn_to_numeric_cast to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 07:47:46 +0000 (16:47 +0900)]
Remove 'lint_numeric_casts'
Yoshitomo Nakanishi [Tue, 9 Mar 2021 07:43:10 +0000 (16:43 +0900)]
Move unnecessary_cast to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 07:11:46 +0000 (16:11 +0900)]
Move cast_possible_wrap to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 03:37:46 +0000 (12:37 +0900)]
Move cast_sign_loss to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 03:10:59 +0000 (12:10 +0900)]
Move cast_possible_truncation to its own module
bors [Tue, 9 Mar 2021 06:46:55 +0000 (06:46 +0000)]
Auto merge of #6869 - DJMcNab:rust-analyzer-private, r=phansch
Opt-in to rustc_private for `rust-analyzer`
rust-analyzer/rust-analyzer#7891
changelog: none
This will also help priroda and any other package which depends on the `miri` library crate.
Andrea Nall [Tue, 9 Mar 2021 05:08:52 +0000 (23:08 -0600)]
use `.all` instead of negative use of `.any`
Andrea Nall [Tue, 9 Mar 2021 05:03:45 +0000 (23:03 -0600)]
use TyS::walk
Yoshitomo Nakanishi [Tue, 9 Mar 2021 02:44:52 +0000 (11:44 +0900)]
Move cast_lossless to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 02:22:17 +0000 (11:22 +0900)]
Move cast_precision_loss to its own module
Yoshitomo Nakanishi [Tue, 9 Mar 2021 02:08:26 +0000 (11:08 +0900)]
Move 'is_isize_or_usize' to clippy_utils
Yoshitomo Nakanishi [Tue, 9 Mar 2021 01:57:25 +0000 (10:57 +0900)]
Separate lints of casts group from types group
bors [Mon, 8 Mar 2021 21:32:21 +0000 (21:32 +0000)]
Auto merge of #6871 - camsteffen:redundant-closure-macro, r=Manishearth
Fix redundant closure with macros
changelog: Fix redundant_closure FPs with macros
Fixes #6732
Fixes #6850
Fixes #4354 (addresses the error message confusion)
Cameron Steffen [Mon, 8 Mar 2021 19:05:13 +0000 (13:05 -0600)]
Improve the redundant_closure message
mark [Mon, 8 Mar 2021 18:41:28 +0000 (12:41 -0600)]
clippy: fix or-pattern in let binding
Cameron Steffen [Mon, 8 Mar 2021 18:59:58 +0000 (12:59 -0600)]
Fix redundant closure with macros
Daniel McNab [Mon, 8 Mar 2021 17:39:51 +0000 (17:39 +0000)]
Opt-in to rustc_private for `rust-analyzer`
rust-analyzer/rust-analyzer#7891
Jason Newcomb [Mon, 8 Mar 2021 16:08:52 +0000 (11:08 -0500)]
Don't assume lang items will exist.
bors [Mon, 8 Mar 2021 16:03:20 +0000 (16:03 +0000)]
Auto merge of #6725 - Y-Nak:refactor-types-lints, r=flip1995
Refactor types lints
Ref #6724.
As described in #6724, `types.rs` contains many groups inside it.
In this PR, I reorganize the lints of the `types` group into their own modules.
changelog: none
Yoshitomo Nakanishi [Thu, 25 Feb 2021 16:06:15 +0000 (01:06 +0900)]
Fix some lints in types that fail dogfood
Yoshitomo Nakanishi [Tue, 16 Feb 2021 13:18:53 +0000 (22:18 +0900)]
Import declared lints at the top of the file
Yoshitomo Nakanishi [Fri, 12 Feb 2021 06:26:36 +0000 (15:26 +0900)]
Remove unused is_local from borrowed_box
Yoshitomo Nakanishi [Fri, 12 Feb 2021 06:22:07 +0000 (15:22 +0900)]
Move borrowed_box to its own module
Yoshitomo Nakanishi [Fri, 12 Feb 2021 05:28:17 +0000 (14:28 +0900)]
Move linked_list to its own module
Yoshitomo Nakanishi [Fri, 12 Feb 2021 05:24:02 +0000 (14:24 +0900)]
Move option_option to its own module
Yoshitomo Nakanishi [Fri, 12 Feb 2021 05:11:04 +0000 (14:11 +0900)]
Add flags to detect lints are triggered
Yoshitomo Nakanishi [Fri, 12 Feb 2021 05:00:17 +0000 (14:00 +0900)]
Move vec_box to its own module
Yoshitomo Nakanishi [Fri, 12 Feb 2021 03:09:36 +0000 (12:09 +0900)]
Move rc_buffer to its own module
Yoshitomo Nakanishi [Thu, 11 Feb 2021 08:41:14 +0000 (17:41 +0900)]
Move redundant_allocation to its own module
Yoshitomo Nakanishi [Thu, 11 Feb 2021 08:32:46 +0000 (17:32 +0900)]
Move box_vec to its own module