]> git.lizzy.rs Git - rust.git/log
rust.git
17 months agoRollup merge of #105655 - RedDocMD:bug-105645, r=oli-obk
fee1-dead [Mon, 9 Jan 2023 15:35:27 +0000 (23:35 +0800)]
Rollup merge of #105655 - RedDocMD:bug-105645, r=oli-obk

Remove invalid case for mutable borrow suggestion

If we have a call such as `foo(&mut buf)` and after reference
collapsing the type is inferred as `&T` where-as the required type is
`&mut T`, don't suggest `foo(&mut mut buf)`. This is wrong syntactically
and the issue lies elsewhere, not in the borrow.

Fixes #105645

17 months agoRollup merge of #105292 - JulianKnodt:no_eager_commit, r=BoxyUwU
fee1-dead [Mon, 9 Jan 2023 15:35:26 +0000 (23:35 +0800)]
Rollup merge of #105292 - JulianKnodt:no_eager_commit, r=BoxyUwU

Change a commit_if_ok call to probe

Removes an over-eager `commit_if_ok` which makes inference worse.

I'm not entirely sure whether it's ok to remove the check that types are the same, because casting seems to cause equality checks with incorrect types?

Fixes #105037

r? ```@BoxyUwU```

17 months agoAuto merge of #106340 - saethlin:propagate-operands, r=oli-obk
bors [Mon, 9 Jan 2023 11:59:51 +0000 (11:59 +0000)]
Auto merge of #106340 - saethlin:propagate-operands, r=oli-obk

Always permit ConstProp to exploit arithmetic identities

Fixes https://github.com/rust-lang/rust/issues/72751

Initially, I thought I would need to enable operand propagation then do something else, but actually https://github.com/rust-lang/rust/pull/74491 already has the fix for the issue in question! It looks like this optimization was put under MIR opt level 3 due to possible soundness/stability implications, then demoted further to MIR opt level 4 when MIR opt level 2 became associated with `--release`.

Perhaps in the past we were doing CTFE on optimized MIR? We aren't anymore, so this optimization has no stability implications.

r? `@oli-obk`

17 months agoClean up
kadmin [Wed, 21 Dec 2022 21:53:52 +0000 (21:53 +0000)]
Clean up

Simplify match statement

Add multiple tests
- 1 test for checking `N + 1 + 1` does not unify with `N+1`
- 2 tests for checking that a function that uses two parameters only returns the parameter that
  is actually used.
- Check exact repeat predicates

17 months agoCheck for duplicates
kadmin [Tue, 20 Dec 2022 21:11:19 +0000 (21:11 +0000)]
Check for duplicates

17 months agoSet !const_evaluatable if ambig. and not inferred
kadmin [Tue, 20 Dec 2022 03:36:32 +0000 (03:36 +0000)]
Set !const_evaluatable if ambig. and not inferred

This prevents an ICE due to a value not actually being evaluatable later.

17 months agoChange based on comments
kadmin [Tue, 13 Dec 2022 09:51:13 +0000 (09:51 +0000)]
Change based on comments

Instead of just switching to a probe, check for different matches, and see how many there are.
If one, unify it, otherwise return true and let it be unified later.

17 months agoChange commit_if_ok to probe
kadmin [Sun, 4 Dec 2022 19:58:03 +0000 (19:58 +0000)]
Change commit_if_ok to probe

17 months agoAuto merge of #106582 - compiler-errors:better-spans-on-bad-tys, r=lcnr
bors [Mon, 9 Jan 2023 08:40:08 +0000 (08:40 +0000)]
Auto merge of #106582 - compiler-errors:better-spans-on-bad-tys, r=lcnr

Improve spans of non-WF implied bound types

Fixes #60980

17 months agoAuto merge of #106616 - compiler-errors:rollup-emcj0o3, r=compiler-errors
bors [Mon, 9 Jan 2023 05:09:45 +0000 (05:09 +0000)]
Auto merge of #106616 - compiler-errors:rollup-emcj0o3, r=compiler-errors

Rollup of 8 pull requests

Successful merges:

 - #104163 (Don't derive Debug for `OnceWith` & `RepeatWith`)
 - #106131 (Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible)
 - #106363 (Structured suggestion for `&mut dyn Iterator` when possible)
 - #106497 (Suggest using clone when we have &T and T implemented Clone)
 - #106584 (Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator.)
 - #106600 (Suppress type errors that come from private fields)
 - #106602 (Add goml scripts to tidy checks)
 - #106606 (Do not emit structured suggestion for turbofish with wrong span)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

17 months agoRollup merge of #106606 - estebank:bad-nested-turbofish, r=compiler-errors
Michael Goulet [Mon, 9 Jan 2023 03:57:56 +0000 (19:57 -0800)]
Rollup merge of #106606 - estebank:bad-nested-turbofish, r=compiler-errors

Do not emit structured suggestion for turbofish with wrong span

Fix #79161.

17 months agoRollup merge of #106602 - GuillaumeGomez:tidy-goml-scripts, r=Mark-Simulacrum
Michael Goulet [Mon, 9 Jan 2023 03:57:56 +0000 (19:57 -0800)]
Rollup merge of #106602 - GuillaumeGomez:tidy-goml-scripts, r=Mark-Simulacrum

Add goml scripts to tidy checks

r? ``@notriddle``

17 months agoRollup merge of #106600 - compiler-errors:no-private-field-ty-err, r=estebank
Michael Goulet [Mon, 9 Jan 2023 03:57:55 +0000 (19:57 -0800)]
Rollup merge of #106600 - compiler-errors:no-private-field-ty-err, r=estebank

Suppress type errors that come from private fields

Fixes #57320

There was some discussion here (https://github.com/rust-lang/rust/issues/57320#issuecomment-451308420), but I honestly think the second error is worth suppressing regardless.

I would be open to feedback though -- perhaps we can suppress the `.len()` suggestion if there's type error (since we have access to [`Expectation`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_typeck/enum.Expectation.html), we can determine that).

r? ``@estebank``

17 months agoRollup merge of #106584 - kpreid:vec-allocator, r=JohnTitor
Michael Goulet [Mon, 9 Jan 2023 03:57:54 +0000 (19:57 -0800)]
Rollup merge of #106584 - kpreid:vec-allocator, r=JohnTitor

Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator.

Currently, the documentation of `Vec::from_raw_parts` and `Vec::from_raw_parts_in` says nothing about what allocator the pointer must come from. This PR adds that missing information explicitly.

17 months agoRollup merge of #106497 - chenyukang:yukang/fix-106443-sugg-clone, r=estebank
Michael Goulet [Mon, 9 Jan 2023 03:57:54 +0000 (19:57 -0800)]
Rollup merge of #106497 - chenyukang:yukang/fix-106443-sugg-clone, r=estebank

Suggest using clone when we have &T and T implemented Clone

Fixes #106443

17 months agoRollup merge of #106363 - estebank:mutability-mismatch-arg, r=Nilstrieb
Michael Goulet [Mon, 9 Jan 2023 03:57:53 +0000 (19:57 -0800)]
Rollup merge of #106363 - estebank:mutability-mismatch-arg, r=Nilstrieb

Structured suggestion for `&mut dyn Iterator` when possible

Fix #37914.

17 months agoRollup merge of #106131 - compiler-errors:not-ptrs, r=davidtwco
Michael Goulet [Mon, 9 Jan 2023 03:57:53 +0000 (19:57 -0800)]
Rollup merge of #106131 - compiler-errors:not-ptrs, r=davidtwco

Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible

Fixes #80929
Fixes #67296

17 months agoRollup merge of #104163 - H4x5:once-repeat-with-debug, r=dtolnay
Michael Goulet [Mon, 9 Jan 2023 03:57:52 +0000 (19:57 -0800)]
Rollup merge of #104163 - H4x5:once-repeat-with-debug, r=dtolnay

Don't derive Debug for `OnceWith` & `RepeatWith`

Closures don't impl Debug, so the derived impl is kinda useless. The behavior of not debug-printing closures is consistent with the rest of the iterator adapters/sources.

17 months agoAuto merge of #90291 - geeklint:loosen_weak_debug_bound, r=dtolnay
bors [Sun, 8 Jan 2023 22:40:38 +0000 (22:40 +0000)]
Auto merge of #90291 - geeklint:loosen_weak_debug_bound, r=dtolnay

Loosen the bound on the Debug implementation of Weak.

Both `rc::Weak<T>` and `sync::Weak<T>` currently require `T: Debug` in their own `Debug` implementations, but they don't currently use it;  they only ever print a fixed string.

A general implementation of Debug for Weak that actually attempts to upgrade and rely on the contents is unlikely in the future because it may have unbounded recursion in the presence of reference cycles, which Weak is commonly used in.  (This was the justification for why the current implementation [was implemented the way it is](https://github.com/rust-lang/rust/pull/19388/commits/f0976e2cf3f6b0027f118b791e0888b29fbb41a7)).

When I brought it up [on the forum](https://internals.rust-lang.org/t/could-the-bound-on-weak-debug-be-relaxed/15504), it was suggested that, even if an implementation is specialized in the future that relies on the data stored within the Weak, it would likely rely on specialization anyway, and could therefore easily specialize on the Debug bound as well.

17 months agoDo not emit structured suggestion for turbofish with wrong span
Esteban Küber [Sun, 8 Jan 2023 22:27:13 +0000 (22:27 +0000)]
Do not emit structured suggestion for turbofish with wrong span

Fix #79161.

17 months agoFix tidy issues in goml scripts
Guillaume Gomez [Sun, 8 Jan 2023 20:29:57 +0000 (21:29 +0100)]
Fix tidy issues in goml scripts

17 months agoAdd goml scripts to tidy checks
Guillaume Gomez [Sun, 8 Jan 2023 20:29:45 +0000 (21:29 +0100)]
Add goml scripts to tidy checks

17 months agoSuppress type errors that come from private fields
Michael Goulet [Sun, 8 Jan 2023 19:45:23 +0000 (19:45 +0000)]
Suppress type errors that come from private fields

17 months agoDon't store spans in assumed_wf_types actually
Michael Goulet [Sun, 8 Jan 2023 19:02:58 +0000 (19:02 +0000)]
Don't store spans in assumed_wf_types actually

17 months agoNormalize assumed_wf_types after wfchecking is complete, for better spans
Michael Goulet [Sun, 8 Jan 2023 03:14:27 +0000 (03:14 +0000)]
Normalize assumed_wf_types after wfchecking is complete, for better spans

17 months agoImprove spans of non-WF implied bound types
Michael Goulet [Sun, 8 Jan 2023 02:40:59 +0000 (02:40 +0000)]
Improve spans of non-WF implied bound types

17 months agoAuto merge of #106449 - GuillaumeGomez:rustdoc-gui-retry-mechanism, r=Mark-Simulacrum
bors [Sun, 8 Jan 2023 17:49:31 +0000 (17:49 +0000)]
Auto merge of #106449 - GuillaumeGomez:rustdoc-gui-retry-mechanism, r=Mark-Simulacrum

Add retry mechanism for rustdoc GUI tests to reduce flakyness

Part of #93784.

I added 3 retries for failing GUI tests. An important note: if more than half of total tests fail, I don't retry because it's very likely not flakyness anymore at this point but a missing update after changes.

17 months agoRemove extra space
Yukang [Sun, 8 Jan 2023 14:51:42 +0000 (22:51 +0800)]
Remove extra space

17 months agoAuto merge of #106235 - compiler-errors:rework-bounds-collection, r=davidtwco
bors [Sun, 8 Jan 2023 14:40:52 +0000 (14:40 +0000)]
Auto merge of #106235 - compiler-errors:rework-bounds-collection, r=davidtwco

Rework `Bounds` collection

I think it's weird for the `Bounds` struct in astconv to store its predicates *almost* converted into real predicates... so we do this eagerly, instead of lazily.

17 months agoAuto merge of #105733 - compiler-errors:ty-ct-late-flags, r=cjgillot
bors [Sun, 8 Jan 2023 11:51:41 +0000 (11:51 +0000)]
Auto merge of #105733 - compiler-errors:ty-ct-late-flags, r=cjgillot

Add type flags support for `Ty` and `Const` late-bound variables

I've been working on `for<T>` binders, and these will eventually be useful.

17 months agoAuto merge of #106588 - JohnTitor:rollup-4z80tjx, r=JohnTitor
bors [Sun, 8 Jan 2023 09:00:31 +0000 (09:00 +0000)]
Auto merge of #106588 - JohnTitor:rollup-4z80tjx, r=JohnTitor

Rollup of 8 pull requests

Successful merges:

 - #103104 (Stabilize `main_separator_str`)
 - #106410 (Suggest `mut self: &mut Self` for `?Sized` impls)
 - #106457 (Adjust comments about pre-push.sh hook)
 - #106546 (jsondoclint: Check local items in `paths` are also in `index`.)
 - #106557 (Add some UI tests and reword error-code docs)
 - #106562 (Clarify examples for `VecDeque::get/get_mut`)
 - #106580 (remove unreachable error code `E0313`)
 - #106581 (Do not emit wrong E0308 suggestion for closure mismatch)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

17 months agoRollup merge of #106581 - estebank:bad-suggestion, r=compiler-errors
Yuki Okushi [Sun, 8 Jan 2023 08:01:49 +0000 (17:01 +0900)]
Rollup merge of #106581 - estebank:bad-suggestion, r=compiler-errors

Do not emit wrong E0308 suggestion for closure mismatch

Found in #76353.

17 months agoRollup merge of #106580 - Ezrashaw:remove-e0313, r=compiler-errors
Yuki Okushi [Sun, 8 Jan 2023 08:01:49 +0000 (17:01 +0900)]
Rollup merge of #106580 - Ezrashaw:remove-e0313, r=compiler-errors

remove unreachable error code `E0313`

Fixes #103742
Makes #103433 redundant

Implements removal of `E0313`. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing?

Also removed a redundant `// ignore-tidy-filelength` that I found while reading code.

cc ``@GuillaumeGomez`` #61137

17 months agoRollup merge of #106562 - clubby789:vec-deque-example, r=Mark-Simulacrum
Yuki Okushi [Sun, 8 Jan 2023 08:01:48 +0000 (17:01 +0900)]
Rollup merge of #106562 - clubby789:vec-deque-example, r=Mark-Simulacrum

Clarify examples for `VecDeque::get/get_mut`

Closes #106114

``@rustbot`` label +A-docs

17 months agoRollup merge of #106557 - Ezrashaw:ui-test-fixups-1, r=GuillaumeGomez
Yuki Okushi [Sun, 8 Jan 2023 08:01:48 +0000 (17:01 +0900)]
Rollup merge of #106557 - Ezrashaw:ui-test-fixups-1, r=GuillaumeGomez

Add some UI tests and reword error-code docs

Added UI tests for `E0013` and `E0015`. Error code docs for `E0015` were a bit unclear (they referred to all non-const errors in const context, when only non-const functions applied), so I touched them up a bit.

I also fixed up some issues in the new `error_codes.rs` tidy check (linked #106341), that I overlooked previously.

r? ``@GuillaumeGomez``

17 months agoRollup merge of #106546 - aDotInTheVoid:jsondoclint-path-local-item, r=notriddle
Yuki Okushi [Sun, 8 Jan 2023 08:01:47 +0000 (17:01 +0900)]
Rollup merge of #106546 - aDotInTheVoid:jsondoclint-path-local-item, r=notriddle

jsondoclint: Check local items in `paths` are also in `index`.

Would have caught #104064 (if core.json was linted in CI).

Closes #106433.

r? rustdoc

17 months agoRollup merge of #106457 - kadiwa4:no-bless, r=Mark-Simulacrum
Yuki Okushi [Sun, 8 Jan 2023 08:01:47 +0000 (17:01 +0900)]
Rollup merge of #106457 - kadiwa4:no-bless, r=Mark-Simulacrum

Adjust comments about pre-push.sh hook

Follow-up to #101175.

17 months agoRollup merge of #106410 - clubby789:borrow-mut-self-mut-self-diag, r=compiler-errors
Yuki Okushi [Sun, 8 Jan 2023 08:01:46 +0000 (17:01 +0900)]
Rollup merge of #106410 - clubby789:borrow-mut-self-mut-self-diag, r=compiler-errors

Suggest `mut self: &mut Self` for `?Sized` impls

Closes #106325
Closes #93078

The suggestion is _probably_ not what the user wants (hence `MaybeIncorrect`) but at least makes the problem in the above issues clearer. It might be better to add a note explaining why this is the case, but I'm not sure how best to word that so this is a start.

``@rustbot`` label +A-diagnostics

17 months agoRollup merge of #103104 - SUPERCILEX:sep-ref, r=dtolnay
Yuki Okushi [Sun, 8 Jan 2023 08:01:46 +0000 (17:01 +0900)]
Rollup merge of #103104 - SUPERCILEX:sep-ref, r=dtolnay

Stabilize `main_separator_str`

See reasoning here: https://github.com/rust-lang/rust/issues/94071#issuecomment-1279872605. Closes #94071.

17 months agoMention signature rather than fn pointers when comparing impl/trait methods
Michael Goulet [Sat, 24 Dec 2022 23:17:25 +0000 (23:17 +0000)]
Mention signature rather than fn pointers when comparing impl/trait methods

17 months agoAdd type flags support for Ty and Const late-bound regions
Michael Goulet [Thu, 15 Dec 2022 02:38:39 +0000 (02:38 +0000)]
Add type flags support for Ty and Const late-bound regions

17 months agoDo not emit wrong E0308 suggestion for closure mismatch
Esteban Küber [Sun, 8 Jan 2023 01:53:39 +0000 (01:53 +0000)]
Do not emit wrong E0308 suggestion for closure mismatch

17 months agoAdd test
Esteban Küber [Sun, 8 Jan 2023 01:53:08 +0000 (01:53 +0000)]
Add test

17 months agoremove unreachable error code `E0313`
Ezra Shaw [Sun, 8 Jan 2023 01:46:01 +0000 (14:46 +1300)]
remove unreachable error code `E0313`

17 months agoAuto merge of #104658 - thomcc:rand-update-and-usable-no_std, r=Mark-Simulacrum
bors [Sun, 8 Jan 2023 01:34:05 +0000 (01:34 +0000)]
Auto merge of #104658 - thomcc:rand-update-and-usable-no_std, r=Mark-Simulacrum

Update `rand` in the stdlib tests, and remove the `getrandom` feature from it.

The main goal is actually removing `getrandom`, so that eventually we can allow running the stdlib test suite on tier3 targets which don't have `getrandom` support. Currently those targets can only run the subset of stdlib tests that exist in uitests, and (generally speaking), we prefer not to test libstd functionality in uitests, which came up recently in https://github.com/rust-lang/rust/pull/104095 and https://github.com/rust-lang/rust/pull/104185. Additionally, the fact that we can't update `rand`/`getrandom` means we're stuck with the old set of tier3 targets, so can't test new ones.

~~Anyway, I haven't checked that this actually does allow use on tier3 targets (I think it does not, as some work is needed in stdlib submodules) but it moves us slightly closer to this, and seems to allow at least finally updating our `rand` dep, which definitely improves the status quo.~~ Checked and works now.

For the most part, our tests and benchmarks are fine using hard-coded seeds. A couple tests seem to fail with this (stuff manipulating the environment expecting no collisions, for example), or become pointless (all inputs to a function become equivalent). In these cases I've done a (gross) dance (ab)using `RandomState` and `Location::caller()` for some extra "entropy".

Trying to share that code seems *way* more painful than it's worth given that the duplication is a 7-line function, even if the lines are quite gross. (Keeping in mind that sharing it would require adding `rand` as a non-dev dep to std, and exposing a type from it publicly, all of which sounds truly awful, even if done behind a perma-unstable feature).

See also some previous attempts:
- https://github.com/rust-lang/rust/pull/86963 (in particular https://github.com/rust-lang/rust/pull/86963#issuecomment-885438936 which explains why this is non-trivial)
- https://github.com/rust-lang/rust/pull/89131
- https://github.com/rust-lang/rust/pull/96626#issuecomment-1114562857 (I tried in that PR at the same time, but settled for just removing the usage of `thread_rng()` from the benchmarks, since that was the main goal).
- https://github.com/rust-lang/rust/pull/104185
- Probably more. It's very tempting of a thing to "just update".

r? `@Mark-Simulacrum`

17 months agodoc/test: add UI test and reword docs for `E0013` and `E0015`
Ezra Shaw [Sat, 7 Jan 2023 05:37:40 +0000 (18:37 +1300)]
doc/test: add UI test and reword docs for `E0013` and `E0015`

17 months agoDocument that `Vec::from_raw_parts[_in]` must be given a pointer from the correct...
Kevin Reid [Sat, 7 Jan 2023 23:56:36 +0000 (15:56 -0800)]
Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator.

17 months agoAuto merge of #106573 - matthiaskrgr:rollup-zkgfsta, r=matthiaskrgr
bors [Sat, 7 Jan 2023 22:42:39 +0000 (22:42 +0000)]
Auto merge of #106573 - matthiaskrgr:rollup-zkgfsta, r=matthiaskrgr

Rollup of 10 pull requests

Successful merges:

 - #101936 (Migrating rustc_infer to session diagnostics (part 3))
 - #104081 (PhantomData layout guarantees)
 - #104543 (Migrate `codegen_ssa` to diagnostics structs - [Part 3])
 - #105128 (Add O(1) `Vec -> VecDeque` conversion guarantee)
 - #105517 (Fix process-panic-after-fork.rs to pass on newer versions of Android.)
 - #105859 (Point out span where we could introduce higher-ranked lifetime)
 - #106509 (Detect closures assigned to binding in block)
 - #106553 (docs: make `HashSet::retain` doctest more clear)
 - #106556 (rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`)
 - #106564 (Change to immutable borrow when cloning element of RepeatN)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

17 months agoRollup merge of #106564 - Folyd:feat-repeatn, r=scottmcm
Matthias Krüger [Sat, 7 Jan 2023 19:43:23 +0000 (20:43 +0100)]
Rollup merge of #106564 - Folyd:feat-repeatn, r=scottmcm

Change to immutable borrow when cloning element of RepeatN

17 months agoRollup merge of #106556 - notriddle:notriddle/margin-left-content-mobile, r=Guillaume...
Matthias Krüger [Sat, 7 Jan 2023 19:43:23 +0000 (20:43 +0100)]
Rollup merge of #106556 - notriddle:notriddle/margin-left-content-mobile, r=GuillaumeGomez

rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`

This rule was added to override non-zero left margin on `.content`, which was removed in 135281ed1525db15edd8ebd092aa10aa40df2386 and the margin-left was put on the docblock.

17 months agoRollup merge of #106553 - Ezrashaw:fix-hashset-doctest, r=JohnTitor
Matthias Krüger [Sat, 7 Jan 2023 19:43:22 +0000 (20:43 +0100)]
Rollup merge of #106553 - Ezrashaw:fix-hashset-doctest, r=JohnTitor

docs: make `HashSet::retain` doctest more clear

Fixes #106535

Extremely simple fix suggested by ``@compiler-errors`` in the linked issue.

17 months agoRollup merge of #106509 - estebank:closure-in-block, r=davidtwco
Matthias Krüger [Sat, 7 Jan 2023 19:43:22 +0000 (20:43 +0100)]
Rollup merge of #106509 - estebank:closure-in-block, r=davidtwco

Detect closures assigned to binding in block

Fix #58497.

17 months agoRollup merge of #105859 - compiler-errors:hr-lifetime-add, r=davidtwco
Matthias Krüger [Sat, 7 Jan 2023 19:43:21 +0000 (20:43 +0100)]
Rollup merge of #105859 - compiler-errors:hr-lifetime-add, r=davidtwco

Point out span where we could introduce higher-ranked lifetime

Somewhat addresses #105422, but not really. We don't have that much useful information here since we're still in resolution :^(

Maybe this suggestion isn't worth it. If the reviewer has an idea how we can get a more succinct binder information for a structured suggestion, it would be appreciated.

17 months agoRollup merge of #105517 - pcc:process-panic-after-fork, r=davidtwco
Matthias Krüger [Sat, 7 Jan 2023 19:43:20 +0000 (20:43 +0100)]
Rollup merge of #105517 - pcc:process-panic-after-fork, r=davidtwco

Fix process-panic-after-fork.rs to pass on newer versions of Android.

The test process-panic-after-fork.rs was checking that abort() resulted in SIGSEGV on Android. This non-standard behavior was fixed back in 2013, so let's fix the test to also accept the standard behavior on Android.

17 months agoRollup merge of #105128 - Sp00ph:vec_vec_deque_conversion, r=dtolnay
Matthias Krüger [Sat, 7 Jan 2023 19:43:20 +0000 (20:43 +0100)]
Rollup merge of #105128 - Sp00ph:vec_vec_deque_conversion, r=dtolnay

Add O(1) `Vec -> VecDeque` conversion guarantee

(See #105072)

17 months agoRollup merge of #104543 - JhonnyBillM:migrate-codegen-ssa-to-diagnostics-structs...
Matthias Krüger [Sat, 7 Jan 2023 19:43:19 +0000 (20:43 +0100)]
Rollup merge of #104543 - JhonnyBillM:migrate-codegen-ssa-to-diagnostics-structs-pt3, r=davidtwco

Migrate `codegen_ssa` to diagnostics structs - [Part 3]

Completes migrating `codegen_ssa` module except 2 outstanding errors that depend on other crates:
1. [`rustc_middle::mir::interpret::InterpError`](https://github.com/rust-lang/rust/blob/b6097f2e1b2ca62e188ba53cf43bd66b06b36915/compiler/rustc_middle/src/mir/interpret/error.rs#L475): I saw `rustc_middle` is unassigned, I am open to take this work.

2.  `codegen_llvm`'s use of `fn span_invalid_monomorphization_error`, which I started to replace in the [last commit](https://github.com/rust-lang/rust/commit/9a31b3cdda78a2c0891828254fe9886e0a1cfd16) of this PR, but would like to know the team's preference on how we should keep replacing the other macros:
2.1. Update macros to expect a `Diagnostic`
2.2. Remove macros and expand the code on each use.
See [some examples of the different options in this experimental commit](https://github.com/JhonnyBillM/rust/commit/64aee83e80857dcfa450f0c6e31d5f29c6d577e6)

_Part 2 - https://github.com/rust-lang/rust/pull/103792_

r? ``@davidtwco``
Cc ``@compiler-errors``

17 months agoRollup merge of #104081 - joshlf:patch-6, r=dtolnay
Matthias Krüger [Sat, 7 Jan 2023 19:43:19 +0000 (20:43 +0100)]
Rollup merge of #104081 - joshlf:patch-6, r=dtolnay

PhantomData layout guarantees

17 months agoRollup merge of #101936 - IntQuant:issue-100717-infer-4, r=compiler-errors
Matthias Krüger [Sat, 7 Jan 2023 19:43:18 +0000 (20:43 +0100)]
Rollup merge of #101936 - IntQuant:issue-100717-infer-4, r=compiler-errors

Migrating rustc_infer to session diagnostics (part 3)

``@rustbot`` label +A-translation
r? rust-lang/diagnostics
cc https://github.com/rust-lang/rust/issues/100717

Seems like a part of static_impl_trait.rs emits suggestions in a loop, and note.rs needs to have two instances of the same subdiagnostic, so these will need to wait until we have eager translation/list support.
Other than that, there is only error_reporting/mod.rs left to migrate.

17 months agoDon't derive Debug for `OnceWith` & `RepeatWith`
Sky [Sat, 7 Jan 2023 19:16:59 +0000 (14:16 -0500)]
Don't derive Debug for `OnceWith` & `RepeatWith`

17 months agoAuto merge of #106036 - JohnTitor:issue-86106, r=nikic
bors [Sat, 7 Jan 2023 19:26:25 +0000 (19:26 +0000)]
Auto merge of #106036 - JohnTitor:issue-86106, r=nikic

Add regression test for #86106

Closes #86106
r? `@nikic`

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
17 months agoAuto merge of #105323 - cjgillot:simplify-const-prop, r=davidtwco
bors [Sat, 7 Jan 2023 16:13:18 +0000 (16:13 +0000)]
Auto merge of #105323 - cjgillot:simplify-const-prop, r=davidtwco

Perform SimplifyLocals before ConstProp.

MIR before `ConstProp` may have a lot of dead writes, this makes `ConstProp` do unnecessary work.

r? `@ghost`

17 months agoChange to immutable borrow when cloning element of RepeatN
Folyd [Sat, 7 Jan 2023 15:50:07 +0000 (23:50 +0800)]
Change to immutable borrow when cloning element of RepeatN

17 months agoClarify examples for `VecDeque::get/get_mut`
clubby789 [Sat, 7 Jan 2023 14:38:21 +0000 (14:38 +0000)]
Clarify examples for `VecDeque::get/get_mut`

17 months agoAuto merge of #106519 - estebank:tail-unit, r=cjgillot
bors [Sat, 7 Jan 2023 13:24:12 +0000 (13:24 +0000)]
Auto merge of #106519 - estebank:tail-unit, r=cjgillot

Detect bindings assigned blocks without tail expressions

Fix #44173.

17 months agoAuto merge of #106283 - JulianKnodt:enum_err, r=cjgillot
bors [Sat, 7 Jan 2023 10:04:39 +0000 (10:04 +0000)]
Auto merge of #106283 - JulianKnodt:enum_err, r=cjgillot

Add help diag. for `const = Enum` missing braces around `Enum`

Previously it was not clear why this errored or if it was even supported, as there was no diagnostic that suggested wrapping it in braces.

Thus, add a simple diagnostic that suggests wrapping enum variants in braces.

Fixes #105927

17 months agoApply `merge-functions=disabled`
Yuki Okushi [Sat, 7 Jan 2023 10:03:07 +0000 (19:03 +0900)]
Apply `merge-functions=disabled`

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
17 months agoApply review suggestions
Yuki Okushi [Thu, 22 Dec 2022 11:45:36 +0000 (20:45 +0900)]
Apply review suggestions

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
17 months agoAdd regression test for #86106
Yuki Okushi [Thu, 22 Dec 2022 11:18:30 +0000 (20:18 +0900)]
Add regression test for #86106

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
17 months agoAuto merge of #106558 - compiler-errors:rollup-lkii3j3, r=compiler-errors
bors [Sat, 7 Jan 2023 06:54:47 +0000 (06:54 +0000)]
Auto merge of #106558 - compiler-errors:rollup-lkii3j3, r=compiler-errors

Rollup of 4 pull requests

Successful merges:

 - #106525 (Report WF error for chalk *and* new solver)
 - #106533 (Use smaller spans for missing lifetime/generic args)
 - #106543 (rustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`)
 - #106554 (Fix a typo in the explanation of E0588)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

17 months agoRollup merge of #106554 - LingMan:explanation_typo, r=compiler-errors
Michael Goulet [Sat, 7 Jan 2023 05:54:01 +0000 (21:54 -0800)]
Rollup merge of #106554 - LingMan:explanation_typo, r=compiler-errors

Fix a typo in the explanation of E0588

17 months agoRollup merge of #106543 - notriddle:notriddle/source-sidebar-width-zero, r=GuillaumeGomez
Michael Goulet [Sat, 7 Jan 2023 05:54:00 +0000 (21:54 -0800)]
Rollup merge of #106543 - notriddle:notriddle/source-sidebar-width-zero, r=GuillaumeGomez

rustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`

This CSS was added in dc2c9723343c985740be09919236a6e96c4e4433, before 6a5f8b1aef1417d7dc85b5d0a229d2db1930eb7c when the sidebars were merged.

Now that they are merged, the source sidebar is being pushed off-screen anyway, so giving it zero width doesn't do much.

17 months agoRollup merge of #106533 - TaKO8Ki:use-smaller-span-for-missing-lifetime/generic-args...
Michael Goulet [Sat, 7 Jan 2023 05:54:00 +0000 (21:54 -0800)]
Rollup merge of #106533 - TaKO8Ki:use-smaller-span-for-missing-lifetime/generic-args, r=compiler-errors

Use smaller spans for missing lifetime/generic args

We can remove ident from suggestions.

17 months agoRollup merge of #106525 - compiler-errors:new-solver-wf, r=jackh726
Michael Goulet [Sat, 7 Jan 2023 05:53:59 +0000 (21:53 -0800)]
Rollup merge of #106525 - compiler-errors:new-solver-wf, r=jackh726

Report WF error for chalk *and* new solver

addressing this nit https://github.com/rust-lang/rust/pull/106385#discussion_r1062571070

No test yet because new solver is currently unusable, lol

r? `@lcnr`

17 months agominor fixes for `error_codes.rs` tidy check
Ezra Shaw [Sat, 7 Jan 2023 05:36:32 +0000 (18:36 +1300)]
minor fixes for `error_codes.rs` tidy check

17 months agorustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`
Michael Howell [Sat, 7 Jan 2023 05:21:54 +0000 (22:21 -0700)]
rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`

This rule was added to override non-zero left margin on `.content`,
which was removed in 135281ed1525db15edd8ebd092aa10aa40df2386 and
the margin-left was put on the docblock.

17 months agoFix a typo in the explanation of E0588
LingMan [Sat, 7 Jan 2023 04:10:53 +0000 (05:10 +0100)]
Fix a typo in the explanation of E0588

17 months agodocs: make `HashSet::retain` doctest more clear
Ezra Shaw [Sat, 7 Jan 2023 04:08:04 +0000 (17:08 +1300)]
docs: make `HashSet::retain` doctest more clear

17 months agoAuto merge of #106538 - aDotInTheVoid:strip-use-doc-hidden, r=notriddle
bors [Sat, 7 Jan 2023 04:00:24 +0000 (04:00 +0000)]
Auto merge of #106538 - aDotInTheVoid:strip-use-doc-hidden, r=notriddle

rustdoc: Strip imports of items which are `#[doc(hidden)]`

Closes #106379

17 months agouse type_implements_trait to check Param clone
yukang [Fri, 6 Jan 2023 23:16:48 +0000 (07:16 +0800)]
use type_implements_trait to check Param clone

17 months agoAuto merge of #106544 - matthiaskrgr:rollup-e9prjed, r=matthiaskrgr
bors [Sat, 7 Jan 2023 00:53:19 +0000 (00:53 +0000)]
Auto merge of #106544 - matthiaskrgr:rollup-e9prjed, r=matthiaskrgr

Rollup of 7 pull requests

Successful merges:

 - #106287 (Add some docs to `bug`, `span_bug` and `delay_span_bug`)
 - #106341 (refactor: clean up `errors.rs` and `error_codes_check.rs`)
 - #106453 (Improve include macro documentation)
 - #106466 (Fix rustdoc source code rendering for `#[path = "../path/to/mod.rs"]` links)
 - #106528 (Tiny formatting fix)
 - #106534 (rustdoc-gui: Use new block syntax for define-function in goml scripts)
 - #106542 (Add default and latest stable edition to --edition in rustc (attempt 2))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup

17 months agojsondoclint: Check local items in `paths` are also in `index`.
Nixon Enraght-Moony [Fri, 6 Jan 2023 23:10:14 +0000 (23:10 +0000)]
jsondoclint: Check local items in `paths` are also in `index`.

17 months agoAuto merge of #106415 - Nilstrieb:where-is-my-master-branch, r=jyn514
bors [Fri, 6 Jan 2023 21:51:44 +0000 (21:51 +0000)]
Auto merge of #106415 - Nilstrieb:where-is-my-master-branch, r=jyn514

Handle non-existent upstream master branches in `x fmt`

People who do have a remote for `rust-lang/rust` but don't have the master branch checked out there used to get this error when running `x fmt`:
> fatal: ambiguous argument 'rust/master': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> rust/master

Which is not exactly helpful.

Now, we fall back to `origin/master` (hoping that at least that remote exists) for that case. If there is still some error, we just fall back to `x fmt .` and print a warning.

r? `@jyn514`

17 months agofix rebase
Esteban Küber [Fri, 6 Jan 2023 21:08:56 +0000 (21:08 +0000)]
fix rebase

17 months agoTurn `IllegalSizedBound` into struct variant
Esteban Küber [Thu, 5 Jan 2023 07:12:04 +0000 (07:12 +0000)]
Turn `IllegalSizedBound` into struct variant

17 months agoChange wording to avoid being misleading
Esteban Küber [Mon, 2 Jan 2023 17:55:13 +0000 (09:55 -0800)]
Change wording to avoid being misleading

17 months agoStructured suggestion for `&mut dyn Iterator` when possible
Esteban Küber [Mon, 2 Jan 2023 05:28:03 +0000 (21:28 -0800)]
Structured suggestion for `&mut dyn Iterator` when possible

Fix #37914.

17 months agocomments feedback
yukang [Thu, 5 Jan 2023 23:44:10 +0000 (07:44 +0800)]
comments feedback

17 months agoApply suggestions from code review
Yukang [Fri, 6 Jan 2023 07:03:05 +0000 (15:03 +0800)]
Apply suggestions from code review

Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
17 months agoSuggest possible clone when we have &T
yukang [Tue, 3 Jan 2023 05:27:49 +0000 (13:27 +0800)]
Suggest possible clone when we have &T

17 months agoRollup merge of #106542 - sigaloid:master, r=bjorn3
Matthias Krüger [Fri, 6 Jan 2023 20:26:12 +0000 (21:26 +0100)]
Rollup merge of #106542 - sigaloid:master, r=bjorn3

Add default and latest stable edition to --edition in rustc (attempt 2)

Fixes #106041

No longer leaks string like my first attempt PR, #106094 - uses LazyLock to construct a `&'static str`

It will now output the default edition and latest stable edition in the help message for the `--edition` flag.

Going to request the same reviewer as the first attempt for continuity - r? `@Nilstrieb`

17 months agoRollup merge of #106534 - GuillaumeGomez:block-syntax, r=notriddle
Matthias Krüger [Fri, 6 Jan 2023 20:26:12 +0000 (21:26 +0100)]
Rollup merge of #106534 - GuillaumeGomez:block-syntax, r=notriddle

rustdoc-gui: Use new block syntax for define-function in goml scripts

r? `@notriddle`

17 months agoRollup merge of #106528 - estebank:quick-fix, r=TaKO8Ki
Matthias Krüger [Fri, 6 Jan 2023 20:26:11 +0000 (21:26 +0100)]
Rollup merge of #106528 - estebank:quick-fix, r=TaKO8Ki

Tiny formatting fix

17 months agoRollup merge of #106466 - clubby789:relative-module-fix, r=notriddle
Matthias Krüger [Fri, 6 Jan 2023 20:26:11 +0000 (21:26 +0100)]
Rollup merge of #106466 - clubby789:relative-module-fix, r=notriddle

Fix rustdoc source code rendering for `#[path = "../path/to/mod.rs"]` links

Fixes #103517

While generating the location for modules source HTML to be saved at, a `..` path component appeared to be translated to `/up/`.
Additionally, while generating the navigation sidebar, `..` path components were ignored. This means that (as in the issue above), a *real* directory structure of:
```
sys/
  unix/
    mod.rs  <-- contains #![path = "../unix/mod.rs]
    cmath.rs
```
was rendered as:
```
sys/
  unix/
    mod.rs
    unix/
      cmath.rs  <-- links to sys/unix/unix/cmath.rs.html, 404
```
While the *files* were stored as
```
sys/
  unix/
    mod.rs.html
    up/
      unix/
        cmath.rs.html
```

17 months agoRollup merge of #106453 - coastalwhite:master, r=GuillaumeGomez
Matthias Krüger [Fri, 6 Jan 2023 20:26:10 +0000 (21:26 +0100)]
Rollup merge of #106453 - coastalwhite:master, r=GuillaumeGomez

Improve include macro documentation

As outlined in #106118, the `include!` macro is a SEO problem when it comes to the Rust documentation. Beginners may see it as a replacement to `include` syntax in other languages. I feel like this documentation should quite explicitly link to the modules' documentation.

The primary goal of this PR is to address that issue by adding a warning to the documentation. While I was here, I also added some other parts. This included a `Uses` section and some (intra doc) links to other relevant topics.

I hope this can help beginners to Rust more quickly understand some multi-file project intricacies.

# References
- Syntax for the warning: https://github.com/tokio-rs/tracing/blob/58accc6da3f04af3f6144fbe6d68af7225c70c02/tracing/src/lib.rs#L55

17 months agoRollup merge of #106341 - Ezrashaw:refactor-error-code-tidy-check, r=mejrs,klensy...
Matthias Krüger [Fri, 6 Jan 2023 20:26:10 +0000 (21:26 +0100)]
Rollup merge of #106341 - Ezrashaw:refactor-error-code-tidy-check, r=mejrs,klensy,GuillaumeGomez

refactor: clean up `errors.rs` and `error_codes_check.rs`

`errors.rs` is basically unused now, `error_codes_check.rs` is useful but not well commented, etc. It also doesn't check certain things which are certainly not correct. For example, `E0505` has a UI test in `src/test/ui/error-codes/` but that test actually outputs `E0504`?! Other issues like these exist. I've implemented these with "warnings" which are a bit rough around the edges but should be removed eventually.

r? `@GuillaumeGomez` (again not sure if you want to review but its relevant to you)

17 months agoRollup merge of #106287 - Nilstrieb:its-bugging-me-how-we-dont-have-docs, r=jyn514
Matthias Krüger [Fri, 6 Jan 2023 20:26:09 +0000 (21:26 +0100)]
Rollup merge of #106287 - Nilstrieb:its-bugging-me-how-we-dont-have-docs, r=jyn514

Add some docs to `bug`, `span_bug` and `delay_span_bug`

cc `@mejrs` as you wanted me to do this, does this look good and understandable?

17 months agorustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`
Michael Howell [Fri, 6 Jan 2023 19:20:03 +0000 (12:20 -0700)]
rustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`

This CSS was added in dc2c9723343c985740be09919236a6e96c4e4433,
before 6a5f8b1aef1417d7dc85b5d0a229d2db1930eb7c when the sidebars
were merged.

Now that they are merged, the source sidebar is being pushed
off-screen anyway, so giving it zero width doesn't do much.

17 months agoUpdate compiler/rustc_session/src/config.rs
Matthew E [Fri, 6 Jan 2023 19:36:52 +0000 (14:36 -0500)]
Update compiler/rustc_session/src/config.rs

Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
17 months agoHandle non-existant upstream master branches in `x fmt`
Nilstrieb [Tue, 3 Jan 2023 17:18:06 +0000 (18:18 +0100)]
Handle non-existant upstream master branches in `x fmt`

17 months agoAdd default and latest stable edition to --edition in rustc
Matthew Esposito [Fri, 6 Jan 2023 19:07:12 +0000 (14:07 -0500)]
Add default and latest stable edition to --edition in rustc