]> git.lizzy.rs Git - rust.git/log
rust.git
7 years agoFix order of publishing steps
Oliver Schneider [Mon, 27 Feb 2017 08:49:18 +0000 (09:49 +0100)]
Fix order of publishing steps

7 years agoRun rustfmt
Oliver Schneider [Mon, 27 Feb 2017 08:49:02 +0000 (09:49 +0100)]
Run rustfmt

7 years agoBump the version
Oliver Schneider [Mon, 27 Feb 2017 08:48:13 +0000 (09:48 +0100)]
Bump the version

7 years agorustup
Oliver Schneider [Mon, 27 Feb 2017 08:45:02 +0000 (09:45 +0100)]
rustup

7 years agoMerge pull request #1573 from sinkuu/len_zero_slice
llogiq [Sat, 25 Feb 2017 06:29:58 +0000 (07:29 +0100)]
Merge pull request #1573 from sinkuu/len_zero_slice

Enable `len_zero` for slices

7 years agoEnable `len_zero` for slices
sinkuu [Sat, 25 Feb 2017 03:26:33 +0000 (12:26 +0900)]
Enable `len_zero` for slices

7 years agoMerge pull request #1572 from steveklabnik/patch-1
Manish Goregaokar [Thu, 23 Feb 2017 01:38:09 +0000 (17:38 -0800)]
Merge pull request #1572 from steveklabnik/patch-1

update semver version

7 years agoupdate semver version
Steve Klabnik [Wed, 22 Feb 2017 20:52:57 +0000 (15:52 -0500)]
update semver version

7 years agoMerge pull request #1561 from Manishearth/zero_ptr
Oliver Schneider [Wed, 22 Feb 2017 12:34:28 +0000 (13:34 +0100)]
Merge pull request #1561 from Manishearth/zero_ptr

New zero_ptr lint.

7 years agoMerge pull request #1571 from sinkuu/assert_ne
Oliver Schneider [Wed, 22 Feb 2017 08:31:19 +0000 (09:31 +0100)]
Merge pull request #1571 from sinkuu/assert_ne

Suggest `assert_ne` for `assert!(x != y)`

7 years agoSuggest `assert_ne` for `assert!(x != y)`
sinkuu [Wed, 22 Feb 2017 07:47:18 +0000 (16:47 +0900)]
Suggest `assert_ne` for `assert!(x != y)`

7 years agofix German keyboard fail
Andre Bogus [Tue, 21 Feb 2017 16:28:17 +0000 (17:28 +0100)]
fix German keyboard fail

7 years agoMerge pull request #1564 from Manishearth/cleanup
Oliver Schneider [Tue, 21 Feb 2017 14:30:39 +0000 (15:30 +0100)]
Merge pull request #1564 from Manishearth/cleanup

Cleanup test suite

7 years agoMerge pull request #1491 from Manishearth/into_iter_on_ref
Oliver Schneider [Tue, 21 Feb 2017 13:55:52 +0000 (14:55 +0100)]
Merge pull request #1491 from Manishearth/into_iter_on_ref

fix explicit_into_iter_loop on references

7 years agoMerge pull request #1556 from sinkuu/take_by_value
Oliver Schneider [Tue, 21 Feb 2017 12:07:25 +0000 (13:07 +0100)]
Merge pull request #1556 from sinkuu/take_by_value

Lint needless take-by-value

7 years agoMerge system independent ui-tests back into tests/ui
Oliver Schneider [Tue, 21 Feb 2017 11:19:55 +0000 (12:19 +0100)]
Merge system independent ui-tests back into tests/ui

7 years agofix ui-posix test paths
Oliver Schneider [Tue, 21 Feb 2017 11:16:57 +0000 (12:16 +0100)]
fix ui-posix test paths

7 years agoUpdate ui test output
Oliver Schneider [Tue, 21 Feb 2017 11:13:44 +0000 (12:13 +0100)]
Update ui test output

7 years agoFix more wrong windows ui test paths
Oliver Schneider [Tue, 21 Feb 2017 11:12:45 +0000 (12:12 +0100)]
Fix more wrong windows ui test paths

7 years agoUi windows test paths are wrong
Oliver Schneider [Tue, 21 Feb 2017 11:12:08 +0000 (12:12 +0100)]
Ui windows test paths are wrong

7 years agoupdate help message to match the suggestion
Oliver Schneider [Wed, 1 Feb 2017 08:21:14 +0000 (09:21 +0100)]
update help message to match the suggestion

7 years agoadjust messages in tests
Oliver Schneider [Mon, 30 Jan 2017 13:25:25 +0000 (14:25 +0100)]
adjust messages in tests

7 years agorustfmt
Oliver Schneider [Mon, 30 Jan 2017 12:06:07 +0000 (13:06 +0100)]
rustfmt

7 years agocleanup and create another helper function that we should use more often
Oliver Schneider [Mon, 30 Jan 2017 11:43:27 +0000 (12:43 +0100)]
cleanup and create another helper function that we should use more often

7 years agofix explicit_into_iter_loop on references
Oliver Schneider [Mon, 9 Jan 2017 15:59:55 +0000 (16:59 +0100)]
fix explicit_into_iter_loop on references

fixes #1398

7 years agoEnsure deref_span is empty for Vec and String
sinkuu [Tue, 21 Feb 2017 10:45:45 +0000 (19:45 +0900)]
Ensure deref_span is empty for Vec and String

7 years agoSimplify calling `update-all-references.sh`
Oliver Schneider [Tue, 21 Feb 2017 10:18:05 +0000 (11:18 +0100)]
Simplify calling `update-all-references.sh`

7 years agoCleanup test suite
Oliver Schneider [Tue, 21 Feb 2017 10:11:33 +0000 (11:11 +0100)]
Cleanup test suite

7 years agoIntegrate suggestion spans
sinkuu [Tue, 21 Feb 2017 10:03:50 +0000 (19:03 +0900)]
Integrate suggestion spans

7 years agoUse `multispan_sugg`
sinkuu [Tue, 21 Feb 2017 09:44:31 +0000 (18:44 +0900)]
Use `multispan_sugg`

7 years agoMerge pull request #1543 from Manishearth/fix-windows-tests
Oliver Schneider [Tue, 21 Feb 2017 09:34:49 +0000 (10:34 +0100)]
Merge pull request #1543 from Manishearth/fix-windows-tests

fix windows tests

7 years agoDon't run cargo clippy on 64 bit
Oliver Schneider [Tue, 21 Feb 2017 08:38:33 +0000 (09:38 +0100)]
Don't run cargo clippy on 64 bit

7 years agoMerge pull request #1544 from bood/master
Oliver Schneider [Tue, 21 Feb 2017 08:16:07 +0000 (09:16 +0100)]
Merge pull request #1544 from bood/master

Add lint for unnecessary casts (cast to same type)

7 years agoMerge pull request #1559 from theotherphil/master
Oliver Schneider [Tue, 21 Feb 2017 08:13:11 +0000 (09:13 +0100)]
Merge pull request #1559 from theotherphil/master

Use span of impl/trait in len_without_is_empty error message, rather …

7 years agoMerge pull request #1538 from Manishearth/publish
Oliver Schneider [Tue, 21 Feb 2017 07:30:53 +0000 (08:30 +0100)]
Merge pull request #1538 from Manishearth/publish

only require rustfmt and update_lints for version bumps

7 years agoNew zero_ptr lint.
Andre Bogus [Tue, 21 Feb 2017 03:36:59 +0000 (04:36 +0100)]
New zero_ptr lint.

This fixes #1047. I did not bother to add a full suggestion,
because replacing with `std::ptr::null()` may still lead to
inference failures.

7 years agoFix suggestion for `let <pat>`
sinkuu [Mon, 20 Feb 2017 09:18:31 +0000 (18:18 +0900)]
Fix suggestion for `let <pat>`

7 years agoRun update_lints.py
sinkuu [Mon, 20 Feb 2017 07:55:52 +0000 (16:55 +0900)]
Run update_lints.py

7 years agoSupport non-moving usages at `match`
sinkuu [Mon, 20 Feb 2017 07:45:37 +0000 (16:45 +0900)]
Support non-moving usages at `match`

This `match` is not moving the `String`:

```rust
fn foo(x: Option<String>) -> i32 {
    match x {
        Some(_) => 1,
        None => 2,
    }
}
```

With this change, it will be linted and suggested to add `*` to deref it.

```rust
fn foo(x: &Option<String>) -> i32 {
    match *x {
        Some(_) => 1,
        None => 2,
    }
}
```

7 years agoRename lint to needless_take_by_value
sinkuu [Mon, 20 Feb 2017 03:50:31 +0000 (12:50 +0900)]
Rename lint to needless_take_by_value

And fixes false-positives for generics and `match`

7 years agoFix typo
Phil Ellison [Sun, 19 Feb 2017 15:39:40 +0000 (15:39 +0000)]
Fix typo

7 years agoAdd test that adding allow attribute on impl block containing len silences len_withou...
Phil Ellison [Sun, 19 Feb 2017 15:36:17 +0000 (15:36 +0000)]
Add test that adding allow attribute on impl block containing len silences len_without_is_empty. Add extra impl block to PubOne to check that this doesn't get flagged@

7 years agoUse span of impl/trait in len_without_is_empty error message, rather than the span...
Phil Ellison [Sun, 19 Feb 2017 15:14:30 +0000 (15:14 +0000)]
Use span of impl/trait in len_without_is_empty error message, rather than the span of the len method

7 years agoAdd explanation
sinkuu [Sun, 19 Feb 2017 09:06:14 +0000 (18:06 +0900)]
Add explanation

7 years agoLint needless take-by-value
sinkuu [Sat, 18 Feb 2017 08:00:36 +0000 (17:00 +0900)]
Lint needless take-by-value

7 years agoMerge pull request #1550 from sinkuu/should_assert_eq
Oliver Schneider [Sat, 18 Feb 2017 07:23:11 +0000 (08:23 +0100)]
Merge pull request #1550 from sinkuu/should_assert_eq

Lint `assert!(x == y)`

7 years agoUpdate README
Bood Qian [Sat, 18 Feb 2017 03:13:38 +0000 (11:13 +0800)]
Update README

7 years agoMerge branch 'master' of github.com:Manishearth/rust-clippy
Bood Qian [Sat, 18 Feb 2017 03:12:13 +0000 (11:12 +0800)]
Merge branch 'master' of github.com:Manishearth/rust-clippy

7 years agoFix language & if_let_chain usage
sinkuu [Fri, 17 Feb 2017 13:37:32 +0000 (22:37 +0900)]
Fix language & if_let_chain usage

7 years agoSupport generic type
sinkuu [Fri, 17 Feb 2017 10:59:52 +0000 (19:59 +0900)]
Support generic type

7 years agoRun update_lints.py
sinkuu [Fri, 17 Feb 2017 08:48:19 +0000 (17:48 +0900)]
Run update_lints.py

7 years agoAdd `should_assert_eq` lint (fixes #641)
sinkuu [Fri, 17 Feb 2017 08:32:51 +0000 (17:32 +0900)]
Add `should_assert_eq` lint (fixes #641)

7 years agorustfmt again
Oliver Schneider [Fri, 17 Feb 2017 12:41:59 +0000 (13:41 +0100)]
rustfmt again

7 years agoMerge pull request #1548 from mathstuf/missing-eol
Oliver Schneider [Fri, 17 Feb 2017 12:40:51 +0000 (13:40 +0100)]
Merge pull request #1548 from mathstuf/missing-eol

main: end error messages with a newline

7 years agoMerge pull request #1549 from Manishearth/never_loop
Oliver Schneider [Fri, 17 Feb 2017 12:40:05 +0000 (13:40 +0100)]
Merge pull request #1549 from Manishearth/never_loop

New never loop lint

7 years agoChoose a better commit message
Oliver Schneider [Fri, 17 Feb 2017 12:27:57 +0000 (13:27 +0100)]
Choose a better commit message

7 years agofix dogfood tests
Oliver Schneider [Fri, 17 Feb 2017 12:23:19 +0000 (13:23 +0100)]
fix dogfood tests

7 years agodeal with binary op short-circuit
Andre Bogus [Fri, 17 Feb 2017 07:49:34 +0000 (08:49 +0100)]
deal with binary op short-circuit

7 years agoNew never loop lint
Andre Bogus [Fri, 17 Feb 2017 03:53:14 +0000 (04:53 +0100)]
New never loop lint

This lint detects loops that unconditionally break or return.

Closes #257

7 years agoRust fmt
Bood Qian [Fri, 17 Feb 2017 00:39:58 +0000 (08:39 +0800)]
Rust fmt

7 years agoMerge pull request #1547 from mathstuf/comma-typos
llogiq [Thu, 16 Feb 2017 19:04:31 +0000 (20:04 +0100)]
Merge pull request #1547 from mathstuf/comma-typos

typos: coma -> comma

7 years agomain: end error messages with a newline
Ben Boeckel [Thu, 16 Feb 2017 18:18:00 +0000 (13:18 -0500)]
main: end error messages with a newline

7 years agotypos: coma -> comma
Ben Boeckel [Thu, 16 Feb 2017 16:23:28 +0000 (11:23 -0500)]
typos: coma -> comma

7 years agoSuppress lint for unsuffixed number casts
Bood Qian [Thu, 16 Feb 2017 14:55:41 +0000 (22:55 +0800)]
Suppress lint for unsuffixed number casts

7 years agocreate a commit with just changelog and Cargo.toml changes
Oliver Schneider [Thu, 16 Feb 2017 08:49:47 +0000 (09:49 +0100)]
create a commit with just changelog and Cargo.toml changes

7 years agoMerge branch 'fix-windows-tests' of https://github.com/Manishearth/rust-clippy into...
Andre Bogus [Thu, 16 Feb 2017 07:47:19 +0000 (08:47 +0100)]
Merge branch 'fix-windows-tests' of https://github.com/Manishearth/rust-clippy into fix-windows-tests

7 years agoadd RUST_BACKTRACE=1 to appveyor build
Andre Bogus [Thu, 16 Feb 2017 07:38:18 +0000 (08:38 +0100)]
add RUST_BACKTRACE=1 to appveyor build

7 years agoAdd lint for unnecessary casts (cast to same type)
Bood Qian [Wed, 15 Feb 2017 14:20:20 +0000 (22:20 +0800)]
Add lint for unnecessary casts (cast to same type)

7 years agosatisfy rustfmt
Oliver Schneider [Wed, 15 Feb 2017 07:36:44 +0000 (08:36 +0100)]
satisfy rustfmt

7 years agofix windows tests
Andre Bogus [Tue, 14 Feb 2017 16:30:55 +0000 (17:30 +0100)]
fix windows tests

Windows has a different error message than POSIX, so the ui tests fail for the clippy-config-fail tests.
This commit splits those tests up in target-os specific subdirectories and extends compile-test.rs to
run either of them based on the target os. Here's hope we'll get a green appveyor build.

7 years agoonly require rustfmt and update_lints for version bumps
Oliver Schneider [Tue, 14 Feb 2017 10:22:21 +0000 (11:22 +0100)]
only require rustfmt and update_lints for version bumps

7 years agoMerge pull request #1531 from F001/clonedCollect
Oliver Schneider [Mon, 13 Feb 2017 15:35:53 +0000 (16:35 +0100)]
Merge pull request #1531 from F001/clonedCollect

Add a lint for `slice.iter().cloned().collect()`

7 years agoupdate ui tests
Oliver Schneider [Mon, 13 Feb 2017 10:57:14 +0000 (11:57 +0100)]
update ui tests

7 years agorun util/update_lint
Oliver Schneider [Mon, 13 Feb 2017 10:40:27 +0000 (11:40 +0100)]
run util/update_lint

7 years agoMerge remote-tracking branch 'origin/master' into clonedCollect
Oliver Schneider [Mon, 13 Feb 2017 10:40:02 +0000 (11:40 +0100)]
Merge remote-tracking branch 'origin/master' into clonedCollect

7 years agoMerge pull request #1529 from bood/master
Oliver Schneider [Mon, 13 Feb 2017 10:38:46 +0000 (11:38 +0100)]
Merge pull request #1529 from bood/master

Lint on `Err(_)` arm of a match

7 years agorun rustfmt
Oliver Schneider [Mon, 13 Feb 2017 10:18:03 +0000 (11:18 +0100)]
run rustfmt

7 years agoupdate readme
Oliver Schneider [Mon, 13 Feb 2017 10:15:36 +0000 (11:15 +0100)]
update readme

7 years agoMerge remote-tracking branch 'origin/master'
Oliver Schneider [Mon, 13 Feb 2017 10:15:12 +0000 (11:15 +0100)]
Merge remote-tracking branch 'origin/master'

7 years agoMerge pull request #1528 from Manishearth/mut-from-ref
Martin Carton [Sun, 12 Feb 2017 15:01:15 +0000 (16:01 +0100)]
Merge pull request #1528 from Manishearth/mut-from-ref

New `mut_from_ref` lint

7 years agofixed multi-span test
Andre Bogus [Sun, 12 Feb 2017 14:10:25 +0000 (15:10 +0100)]
fixed multi-span test

7 years agorustfmt
Andre Bogus [Sun, 12 Feb 2017 13:11:18 +0000 (14:11 +0100)]
rustfmt

7 years agoadd notes for immutable inputs
Andre Bogus [Sun, 12 Feb 2017 12:53:30 +0000 (13:53 +0100)]
add notes for immutable inputs

7 years agoupdate via comments
f001 [Sun, 12 Feb 2017 12:40:38 +0000 (20:40 +0800)]
update via comments

7 years agoformat adjust
f001 [Sun, 12 Feb 2017 09:24:59 +0000 (17:24 +0800)]
format adjust

7 years agoAdd a lint for `slice.iter().cloned().collect()`
f001 [Sun, 12 Feb 2017 09:03:09 +0000 (17:03 +0800)]
Add a lint for `slice.iter().cloned().collect()`

If one uses `slice.iter().cloned().collect()` to create a new `Vec`,
it should be `slice.to_owned()`.

Fix #1292

7 years agoRemove unnecessary ref
Bood Qian [Sun, 12 Feb 2017 01:16:37 +0000 (09:16 +0800)]
Remove unnecessary ref

7 years agoMove more into if_let_chain
Bood Qian [Sat, 11 Feb 2017 14:11:19 +0000 (22:11 +0800)]
Move more into if_let_chain

7 years agoApply rustfmt
Bood Qian [Sat, 11 Feb 2017 13:47:26 +0000 (21:47 +0800)]
Apply rustfmt

7 years agoLint on `panic!` only
Bood Qian [Sat, 11 Feb 2017 13:42:42 +0000 (21:42 +0800)]
Lint on `panic!` only

7 years agoMerge pull request #1512 from pengowen123/patch-large_enum_variant
Oliver Schneider [Sat, 11 Feb 2017 09:10:54 +0000 (10:10 +0100)]
Merge pull request #1512 from pengowen123/patch-large_enum_variant

Change large_enum_variant to lint against difference in sizes between variants

7 years agoLint on `Err(_)` arm of a match
Bood Qian [Sat, 11 Feb 2017 06:57:50 +0000 (14:57 +0800)]
Lint on `Err(_)` arm of a match

7 years agorustfmt
Owen Sanchez [Sat, 11 Feb 2017 04:08:50 +0000 (21:08 -0700)]
rustfmt

7 years agoUpdate large_enum_variant test
Owen Sanchez [Sat, 11 Feb 2017 04:04:19 +0000 (21:04 -0700)]
Update large_enum_variant test

7 years agoSearch directly for the largest and smallest variants instead of sorting
Owen Sanchez [Mon, 6 Feb 2017 19:25:38 +0000 (12:25 -0700)]
Search directly for the largest and smallest variants instead of sorting

7 years agoRun update_lints.py
Owen Sanchez [Sun, 5 Feb 2017 03:26:08 +0000 (20:26 -0700)]
Run update_lints.py

7 years agoChange large_enum_variant to lint against size differences rather than size
Owen Sanchez [Sun, 5 Feb 2017 03:12:55 +0000 (20:12 -0700)]
Change large_enum_variant to lint against size differences rather than size

7 years agoAdd some writes to a log file for debugging
Owen Sanchez [Sun, 5 Feb 2017 00:42:35 +0000 (17:42 -0700)]
Add some writes to a log file for debugging

7 years agoRemove stabilized feature flag
Andre Bogus [Sat, 11 Feb 2017 00:42:14 +0000 (01:42 +0100)]
Remove stabilized feature flag

7 years agofix test
Andre Bogus [Sat, 11 Feb 2017 00:41:49 +0000 (01:41 +0100)]
fix test