]>
git.lizzy.rs Git - rust.git/log
flip1995 [Tue, 4 Feb 2020 16:33:50 +0000 (17:33 +0100)]
Add bors dummy jobs
flip1995 [Fri, 31 Jan 2020 13:44:55 +0000 (14:44 +0100)]
Use hash of Cargo.lock file in cache name
flip1995 [Fri, 31 Jan 2020 13:43:02 +0000 (14:43 +0100)]
Add two more error causes to integration test
flip1995 [Fri, 31 Jan 2020 13:42:44 +0000 (14:42 +0100)]
Build Clippy before running integration tests
flip1995 [Thu, 30 Jan 2020 16:03:45 +0000 (17:03 +0100)]
Allow non-ascii characters in changelog check
flip1995 [Sun, 26 Jan 2020 14:40:53 +0000 (15:40 +0100)]
Extract deployment
flip1995 [Sun, 26 Jan 2020 14:13:14 +0000 (15:13 +0100)]
Extract driver test
flip1995 [Fri, 24 Jan 2020 13:34:25 +0000 (14:34 +0100)]
Sort output of export.py script
flip1995 [Thu, 23 Jan 2020 14:47:11 +0000 (15:47 +0100)]
Limit parallel jobs on try/r+ runs
Rate limit of 60 applies org wide, let's not spam.
Thanks pietroalbini for the hint
flip1995 [Thu, 23 Jan 2020 13:40:37 +0000 (14:40 +0100)]
Cancle builds on new commits
flip1995 [Thu, 23 Jan 2020 09:22:02 +0000 (10:22 +0100)]
Add GHA badge to README.md
Add a FIXME to Cargo.toml
flip1995 [Thu, 23 Jan 2020 09:36:51 +0000 (10:36 +0100)]
Small change to comment in .gitignore
flip1995 [Wed, 22 Jan 2020 20:00:31 +0000 (21:00 +0100)]
Add deployment to GHA
flip1995 [Wed, 22 Jan 2020 19:00:41 +0000 (20:00 +0100)]
Move integration tests in clippy_bors.yml
Some call it the integration integration
flip1995 [Wed, 22 Jan 2020 16:06:13 +0000 (17:06 +0100)]
Add Clippy Test to GHA
flip1995 [Wed, 22 Jan 2020 13:56:08 +0000 (14:56 +0100)]
Get {RUSTUP,MULTIRUST}_{HOME,TOOLCHAIN} from runtime environment
Keep the fallback to compile-time environment
flip1995 [Tue, 21 Jan 2020 20:40:40 +0000 (21:40 +0100)]
Check if changelog exists
flip1995 [Tue, 21 Jan 2020 17:44:30 +0000 (18:44 +0100)]
Ignore fmt test in GHA CI
This is already checked by clippy_dev.yml GHA
flip1995 [Tue, 21 Jan 2020 17:43:57 +0000 (18:43 +0100)]
Add Clippy Test (bors) to GHA
flip1995 [Tue, 21 Jan 2020 15:39:58 +0000 (16:39 +0100)]
Fix markdown Files
Rendered:
[CHANGELOG.md](https://github.com/flip1995/rust-clippy/blob/gha/CHANGELOG.md)
[CODE_OF_CONDUCT.md](https://github.com/flip1995/rust-clippy/blob/gha/CODE_OF_CONDUCT.md)
[CONTRIBUTING.md](https://github.com/flip1995/rust-clippy/blob/gha/CONTRIBUTING.md)
[README.md](https://github.com/flip1995/rust-clippy/blob/gha/README.md)
[clippy_dummy/PUBLISH.md](https://github.com/flip1995/rust-clippy/blob/gha/clippy_dummy/PUBLISH.md)
[doc/adding_lints.md](https://github.com/flip1995/rust-clippy/blob/gha/doc/adding_lints.md)
[etc/relicense/RELICENSE_DOCUMENTATION.md](https://github.com/flip1995/rust-clippy/blob/gha/etc/relicense/RELICENSE_DOCUMENTATION.md)
flip1995 [Tue, 21 Jan 2020 15:32:25 +0000 (16:32 +0100)]
Rename .remarkrc.json -> .remarkrc and fix file
flip1995 [Tue, 21 Jan 2020 14:29:54 +0000 (15:29 +0100)]
Add remark check to GHA
flip1995 [Tue, 21 Jan 2020 12:46:53 +0000 (13:46 +0100)]
Add clippy_dev checks to GitHub Actions
flip1995 [Mon, 20 Jan 2020 15:03:26 +0000 (16:03 +0100)]
Add integration test GitHub action
bors [Tue, 11 Feb 2020 22:22:05 +0000 (22:22 +0000)]
Auto merge of #5158 - lzutao:callbackshook, r=flip1995
Impl DefaultCallbacks on our side
cc https://github.com/rust-lang/rust/pull/69059#discussion_r377643560
changelog: none
bors [Tue, 11 Feb 2020 20:54:49 +0000 (20:54 +0000)]
Auto merge of #5152 - flip1995:rustup, r=flip1995
Rustup to rust-lang/rust#68725
Preparation for rust-lang/rust#68725
changelog: none
Lzu Tao [Tue, 11 Feb 2020 15:52:00 +0000 (22:52 +0700)]
Impl DefaultCallbacks on our side
bors [Tue, 11 Feb 2020 14:25:21 +0000 (14:25 +0000)]
Auto merge of #5155 - krishna-veerareddy:remove-unused-imports, r=flip1995
Remove unnecessary `Lint{Array|Pass}` imports
changelog: none
Krishna Sai Veera Reddy [Tue, 11 Feb 2020 14:20:47 +0000 (06:20 -0800)]
Remove unnecessary imports from tests
Krishna Sai Veera Reddy [Tue, 11 Feb 2020 03:37:25 +0000 (19:37 -0800)]
Remove unnecessary imports from documentation
Krishna Sai Veera Reddy [Tue, 11 Feb 2020 03:24:01 +0000 (19:24 -0800)]
Remove unnecessary imports from `new_lint` tool
bors [Mon, 10 Feb 2020 16:02:30 +0000 (16:02 +0000)]
Auto merge of #5151 - flip1995:fix_run_pass_tests, r=flip1995
Fix run-pass tests when CARGO_TARGET_DIR is not set
r? @lzutao
I got
```
thread '[ui] ui/crashes/ice-1969.rs' panicked at 'failed to exec `"target/debug/test_build_base/crashes/ice-1969.stage-id"`: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/pkrones/.cargo/registry/src/github.com-
1ecc6299db9ec823 /compiletest_rs-0.4.0/src/runtest.rs:1350:25
```
on tests with `// run-pass` locally. The reason for this is, that I haven't set `CARGO_TARGET_DIR` and then `"target"` was used as the `CARGO_TARGET_DIR`. It seems, that `compiletest-rs` cannot deal with relative paths for `// run-pass` tests.
changelog: none
Philipp Krones [Mon, 10 Feb 2020 15:42:50 +0000 (16:42 +0100)]
Use current_dir instead of cargo_metadata
Co-Authored-By: lzutao <taolzu@gmail.com>
flip1995 [Mon, 10 Feb 2020 14:59:14 +0000 (15:59 +0100)]
Rustup to rust-lang/rust#68725
flip1995 [Mon, 10 Feb 2020 14:51:51 +0000 (15:51 +0100)]
Fix run-pass tests when CARGO_TARGET_DIR is not set
bors [Mon, 10 Feb 2020 08:08:53 +0000 (08:08 +0000)]
Auto merge of #5148 - krishna-veerareddy:issue-5147-option-env-unwrap, r=flip1995
Add `option-env-unwrap` lint
changelog: Add `option-env-unwrap` lint
Fixes #5147
Krishna Sai Veera Reddy [Sun, 9 Feb 2020 22:12:40 +0000 (14:12 -0800)]
Use `PATH` environment variable for testing
The tests were failing on windows because the `HOME` env variable
doesn't exist on it so using the `PATH` variable to test instead.
bors [Sun, 9 Feb 2020 22:59:08 +0000 (22:59 +0000)]
Auto merge of #5150 - krishna-veerareddy:rustup-69004, r=flip1995
Rustup to rust-lang/rust#68911
changelog: none
Krishna Sai Veera Reddy [Sun, 9 Feb 2020 22:44:17 +0000 (14:44 -0800)]
Rustup to rust-lang/rust#68911
Krishna Sai Veera Reddy [Sun, 9 Feb 2020 18:58:08 +0000 (10:58 -0800)]
Allow `option-env-unwrap` within external macros
Krishna Sai Veera Reddy [Sun, 9 Feb 2020 16:54:23 +0000 (08:54 -0800)]
Account for `expect` being used to unwrap `Option`
bors [Sun, 9 Feb 2020 12:44:23 +0000 (12:44 +0000)]
Auto merge of #5145 - lzutao:rmeta, r=flip1995
Fix error E0460 when compiled on Rustc repo
Sadly, this mostly reverts #5121. Now I use HashMap to only store one rlib
per crate. But that would not work when non-compatible version of the same crate show up.
changelog: none
Lzu Tao [Sun, 9 Feb 2020 05:00:49 +0000 (12:00 +0700)]
Fix error E0460 when compiled on Rustc repo
bors [Sun, 9 Feb 2020 11:08:43 +0000 (11:08 +0000)]
Auto merge of #5149 - lzutao:rustup-65232, r=flip1995
Rustup "index ReEmpty by universe"
cc https://github.com/rust-lang/rust/pull/65232
changelog: none
Lzu Tao [Sun, 9 Feb 2020 08:31:47 +0000 (15:31 +0700)]
Rustup "index ReEmpty by universe"
Krishna Sai Veera Reddy [Sun, 9 Feb 2020 00:44:35 +0000 (16:44 -0800)]
Add `option-env-unwrap` lint
bors [Fri, 7 Feb 2020 22:41:04 +0000 (22:41 +0000)]
Auto merge of #5140 - lzutao:cleanup-replace, r=flip1995
Minor edit to text region replacement
changelog: none
bors [Fri, 7 Feb 2020 08:28:41 +0000 (08:28 +0000)]
Auto merge of #5146 - lzutao:rustup, r=flip1995
Rustup https://github.com/rust-lang/rust/pull/67359
cc https://github.com/rust-lang/rust/pull/67359
changelog: none
Lzu Tao [Fri, 7 Feb 2020 03:34:11 +0000 (10:34 +0700)]
Update CARGO_TARGET_DIR
Lzu Tao [Fri, 7 Feb 2020 03:34:06 +0000 (04:34 +0100)]
Rustup https://github.com/rust-lang/rust/pull/67359
Lzu Tao [Fri, 7 Feb 2020 01:33:01 +0000 (08:33 +0700)]
dev: Move DOCS_LINK out of lazy_static and reuse it
Lzu Tao [Thu, 6 Feb 2020 14:28:50 +0000 (21:28 +0700)]
dev: Make UpdateMode a copy type
Lzu Tao [Thu, 6 Feb 2020 14:13:39 +0000 (21:13 +0700)]
dev: Prefer `fs::read*` and improvement to replace text region
bors [Thu, 6 Feb 2020 21:41:50 +0000 (21:41 +0000)]
Auto merge of #5134 - flip1995:snippet_block, r=phansch
Make it possible to correctly indent snippet_block snippets
This adds a `indent_relative_to` arg to the `{snippet,expr}_block` functions. This makes it possible to keep the correct indentation of block like suggestions.
In addition, this makes the `trim_multiline` function private and adds a `indent_of` function, to get the indentation of the first line of a span.
The suggestion of `needless_continue` cannot be made auto applicable, since it would be also necessary to remove code following the linted expression. (Well, maybe it is possible, but I don't know how to do it. Expanding the suggestion span to the last expression, that should be removed didn't work)
changelog: Improve suggestions, when blocks of code are involved
bors [Thu, 6 Feb 2020 20:53:17 +0000 (20:53 +0000)]
Auto merge of #5143 - flip1995:rustup, r=flip1995
Rustup to rust-lang/rust#68788
cc rust-lang/rust#68901
changelog: none
flip1995 [Thu, 6 Feb 2020 19:29:58 +0000 (20:29 +0100)]
Rustup to rust-lang/rust#68788
flip1995 [Wed, 5 Feb 2020 10:09:48 +0000 (11:09 +0100)]
Rename ctx->cx in needless_continue
flip1995 [Wed, 5 Feb 2020 09:42:33 +0000 (10:42 +0100)]
Improve help message in needless_continue
flip1995 [Wed, 5 Feb 2020 08:55:48 +0000 (09:55 +0100)]
Fix rebase fallout
flip1995 [Tue, 4 Feb 2020 16:02:46 +0000 (17:02 +0100)]
Document the indent_relative_to arg of snippet_block
flip1995 [Tue, 4 Feb 2020 15:13:06 +0000 (16:13 +0100)]
Update remaining test files
flip1995 [Tue, 4 Feb 2020 15:12:51 +0000 (16:12 +0100)]
Move tests to the end of the file in utils mod.rs
flip1995 [Tue, 4 Feb 2020 15:11:49 +0000 (16:11 +0100)]
Update needless_continue stderr
flip1995 [Tue, 4 Feb 2020 15:10:59 +0000 (16:10 +0100)]
Rewrite suggestion generation of needless_continue
flip1995 [Tue, 4 Feb 2020 15:08:39 +0000 (16:08 +0100)]
Update block_in_if_condition test files
flip1995 [Tue, 4 Feb 2020 15:08:15 +0000 (16:08 +0100)]
Make block_in_if_condition auto applicable
flip1995 [Tue, 4 Feb 2020 15:07:09 +0000 (16:07 +0100)]
Optionally indent snippet_block relative to an Expr
bors [Thu, 6 Feb 2020 15:31:01 +0000 (15:31 +0000)]
Auto merge of #5139 - lzutao:linecount, r=llogiq
dev: Use bytecount for faster line count
changelog: none
bors [Thu, 6 Feb 2020 14:47:14 +0000 (14:47 +0000)]
Auto merge of #5125 - Areredify:too_many_bools, r=flip1995
Port mitsuhiko's excessive bools lints
Closes #4 .
changelog: add `struct_excessive_bools` and `fn_params_excessive_bools` lints.
I moved is_trait_impl_item check because at first I implemented it as a late pass for some reason but then I realized it's actually an early lint. But it's a useful function to have, should I move it into a separate pr?
Lzu Tao [Thu, 6 Feb 2020 14:39:15 +0000 (21:39 +0700)]
dev: Use bytecount for faster line count
bors [Thu, 6 Feb 2020 14:17:35 +0000 (14:17 +0000)]
Auto merge of #5132 - JohnTitor:fix-fp-in-unwrap-lint, r=flip1995
Do not lint `unnecessary_unwrap` in external macros
Fixes #5131
I think we shouldn't lint `{panicking, unnecessary}_unwrap` in macros, not just `assert!`.
changelog: Fix false positive in `unnecessary_unwrap`
bors [Thu, 6 Feb 2020 09:19:29 +0000 (09:19 +0000)]
Auto merge of #5121 - lzutao:comptest, r=flip1995
Improve compile_test and dogfood tests
* Hopefully this finally resolves the "multiple matching crates" error, e.g. #4015
* This handle some convenient CARGO env like CARGO_TARGET_DIR and CARGO_BUILD_TARGET
changelog: none
Areredify [Sat, 1 Feb 2020 23:49:52 +0000 (02:49 +0300)]
add excessive bools lints
Lzu Tao [Wed, 5 Feb 2020 15:13:55 +0000 (16:13 +0100)]
Use lazy_static
Areredify [Thu, 30 Jan 2020 23:39:10 +0000 (02:39 +0300)]
move is_trait_impl_item check from functions.rs to utils
Lzu Tao [Wed, 5 Feb 2020 15:00:19 +0000 (22:00 +0700)]
Add `serde_derive` to the need-to-be-disambiguated-crates list
Lzu Tao [Sat, 1 Feb 2020 17:00:48 +0000 (00:00 +0700)]
Fix dogfood to use cargo mod too
Lzu Tao [Sat, 1 Feb 2020 10:04:04 +0000 (11:04 +0100)]
compile-test: Handle CARGO_TARGET_DIR and transitive deps
bors [Wed, 5 Feb 2020 14:16:17 +0000 (14:16 +0000)]
Auto merge of #5137 - lzutao:race, r=flip1995
Prevent failing to restart setup-toolchain
If `rustup-toolchain-install-master` fails to install master
toolchain (in case `rustup update` executes at the same remove the
tmp directory), `cargo search` (which use master toolchain after
`rustup override` command) will fail. This leads to setup-toolchain
fails too.
changelog: none
Lzu Tao [Wed, 5 Feb 2020 13:37:33 +0000 (20:37 +0700)]
Prevent failing to restart setup-toolchain
If `rustup-toolchain-install-master` fails to install master
toolchain (in case `rustup update` executes at the same remove the
tmp directory), `cargo search` (which use master toolchain after
`rustup override` command) will fail. This leads to setup-toolchain
fails too.
bors [Wed, 5 Feb 2020 09:58:15 +0000 (09:58 +0000)]
Auto merge of #5135 - lzutao:config, r=flip1995
Few improvement to `utils::conf` module
* Fix a few typos
* Handle Option<&Path> early
* Use `env::var_os` when possible
changelog: none
Lzu Tao [Wed, 5 Feb 2020 02:06:34 +0000 (09:06 +0700)]
Few improvement to `utils::conf` module
* Fix a few typos
* Handle Option<&Path> early
* Use `env::var_os` when possible
bors [Tue, 4 Feb 2020 22:16:13 +0000 (22:16 +0000)]
Auto merge of #5061 - ThibsG:UselessMatch3664, r=flip1995
Add new lint: match with a single binding statement
This lint catches `match` statements that binds to only one block and could be rewritten using a simple `let` statement.
Lint name: MATCH_SINGLE_BINDING
fixes: #3664
changelog: add lint for match with single binding statement
ThibsG [Tue, 4 Feb 2020 19:19:20 +0000 (20:19 +0100)]
Manage macros case + move to MaybeIncorrect when binding values
ThibsG [Tue, 4 Feb 2020 07:20:49 +0000 (08:20 +0100)]
Merge fixes
ThibsG [Sun, 26 Jan 2020 16:03:39 +0000 (17:03 +0100)]
Add wild and struct handling
ThibsG [Sun, 19 Jan 2020 10:07:13 +0000 (11:07 +0100)]
Use span_lint_and_sugg + move infaillible lint
- moving infaillible lint to prevent collisions
Yuki Okushi [Tue, 4 Feb 2020 20:38:26 +0000 (05:38 +0900)]
Re-cover use of unnecessary unwraps in macros
bors [Tue, 4 Feb 2020 13:22:19 +0000 (13:22 +0000)]
Auto merge of #5124 - flip1995:backport_back_merge, r=flip1995
Merge backport branch back into master
Merge back backport branch rust-1.42.0 into master.
Waiting on rust-lang/rust#68753
changelog: none
ThibsG [Wed, 15 Jan 2020 06:56:56 +0000 (07:56 +0100)]
Add new lint: match with a single binding statement
- Lint name: MATCH_SINGLE_BINDING
Yuki Okushi [Mon, 3 Feb 2020 19:01:42 +0000 (04:01 +0900)]
Do not lint `unnecessary_unwrap` in macros
bors [Mon, 3 Feb 2020 17:22:10 +0000 (17:22 +0000)]
Auto merge of #5130 - JohnTitor:split-up-index-slice, r=flip1995
Split up `indexing_slicing` ui test
Closes #2038
Now all the stderrs are less than 200 lines :tada:
changelog: none
bors [Mon, 3 Feb 2020 16:47:25 +0000 (16:47 +0000)]
Auto merge of #5129 - JohnTitor:use-checked-sub, r=flip1995
Use `checked_sub` to avoid index out of bounds
(Fixes) #4681 (possibly)
The issue likely occurs due to `lit_snip.len() < suffix.len() + 1`. You can see similar backtrace to change it to `lit_snip.len() - suffix.len() - 1000` or something then run `cargo test --release`.
But I couldn't come up with the test so I'd leave the issue open if we want.
changelog: Fix potential ICE in `misc_early`
Yuki Okushi [Mon, 3 Feb 2020 16:29:11 +0000 (01:29 +0900)]
Remove unnecessary comment
bors [Mon, 3 Feb 2020 16:16:44 +0000 (16:16 +0000)]
Auto merge of #5127 - Areredify:issue-5115, r=flip1995
improve 'iter_nth_zero' documentation
closes #5115
changelog: Improve the documentation of `iter_nth_zero`
Areredify [Sun, 2 Feb 2020 22:19:16 +0000 (01:19 +0300)]
improve 'iter_nth_zero' documentation
Yuki Okushi [Mon, 3 Feb 2020 01:42:21 +0000 (10:42 +0900)]
Use `checked_sub` to avoid index out of bounds
Yuki Okushi [Mon, 3 Feb 2020 06:11:02 +0000 (15:11 +0900)]
Decrease line length limit for stderrs
Yuki Okushi [Mon, 3 Feb 2020 06:09:17 +0000 (15:09 +0900)]
Split up `indexing_slicing` ui test
bors [Sun, 2 Feb 2020 18:16:33 +0000 (18:16 +0000)]
Auto merge of #5120 - JohnTitor:split-up-drop-forget-ref, r=flip1995
Split up `drop_forget_ref` ui test
Part of #2038
changelog: none