]>
git.lizzy.rs Git - rust.git/log
Matthias Krüger [Sat, 18 Jan 2020 22:40:35 +0000 (23:40 +0100)]
rustup https://github.com/rust-lang/rust/pull/67712
slice_patterns have been stabilized.
bors [Sat, 18 Jan 2020 10:23:46 +0000 (10:23 +0000)]
Auto merge of #5057 - rust-lang:pedantic_range_plus_one, r=flip1995
Downgrade range_plus_one to pedantic
This fixes #2217
changelog: Downgrade [`range_plus_one`] to `pedantic`
Andre Bogus [Fri, 17 Jan 2020 09:15:14 +0000 (10:15 +0100)]
Downgrade range_plus_one to pedantic
bors [Sat, 18 Jan 2020 08:10:56 +0000 (08:10 +0000)]
Auto merge of #5059 - JohnTitor:rustup-0118, r=llogiq
Rustup to rust-lang/rust#68204
changelog: none
Yuki Okushi [Sat, 18 Jan 2020 05:14:36 +0000 (14:14 +0900)]
Rustup to rust-lang/rust#68204
bors [Thu, 16 Jan 2020 19:43:22 +0000 (19:43 +0000)]
Auto merge of #5055 - krishna-veerareddy:fix-new-lint-generator-import, r=llogiq
Fix new lint generator import
Fix `rustc_lint` import path and add lifetimes to `LateLintPass` in `new_lint` command.
changelog: none
Krishna Sai Veera Reddy [Thu, 16 Jan 2020 18:05:29 +0000 (10:05 -0800)]
Add lifetimes to `LateLintPass`
Krishna Sai Veera Reddy [Thu, 16 Jan 2020 17:44:45 +0000 (09:44 -0800)]
Fix rustc lint import paths generated by `new_lint`
bors [Thu, 16 Jan 2020 16:24:41 +0000 (16:24 +0000)]
Auto merge of #4994 - bradsherman:new_lint_gen, r=flip1995
Autogenerate new lints
Add option in clippy_dev to automatically generate boilerplate code for adding new lints
example:
`./util/dev new_lint --name=iter_nth_zero --type=late`
Fixes #4942
changelog: none
bors [Thu, 16 Jan 2020 15:04:45 +0000 (15:04 +0000)]
Auto merge of #5054 - flip1995:rustup, r=flip1995
Update custom_ice_message.stderr
changelog: none
flip1995 [Thu, 16 Jan 2020 15:01:31 +0000 (16:01 +0100)]
Update custom_ice_message.stderr
Brad Sherman [Sat, 11 Jan 2020 20:08:27 +0000 (14:08 -0600)]
Add lint for default lint description
- Lint for any new lints that have the default lint description
from the automation
Brad Sherman [Sat, 11 Jan 2020 19:26:25 +0000 (13:26 -0600)]
Update documentation for adding new lints
- Add instructions for adding new lints with
the new automation
Brad Sherman [Wed, 1 Jan 2020 01:07:39 +0000 (18:07 -0700)]
Generate new lints easily
- Add option in clippy_dev to automatically generate boilerplate
code for adding new lints
bors [Wed, 15 Jan 2020 21:17:21 +0000 (21:17 +0000)]
Auto merge of #5034 - ThibsG:MatchWildErrArmImprove5024, r=flip1995
Match wild err arm improvements
This lint should trigger on other identifiers which have `_` prefix (such as `_e`) and only if they are unused in the panic block.
_Note_: the `is_unused` function is greatly inspired from `pat_is_wild` function in [loops lints](https://github.com/rust-lang/rust-clippy/blob/
43ac9416d935942d6c7d2b2e0c876c551652c4ec /clippy_lints/src/loops.rs#L1689).
I've been considering doing some refactoring, maybe in utils. Maybe this PR or a new one. What do you think ?
fixes #5024
changelog: none
bors [Wed, 15 Jan 2020 07:35:30 +0000 (07:35 +0000)]
Auto merge of #5048 - justjavac:patch-1, r=llogiq
update license year to 2020
Happy new year 2020
changelog: none
迷渡 [Wed, 15 Jan 2020 07:00:54 +0000 (15:00 +0800)]
update license year to 2020
bors [Tue, 14 Jan 2020 21:21:58 +0000 (21:21 +0000)]
Auto merge of #5023 - rust-lang:doc-main, r=phansch
Omit doc safety/errors header checking for main
This omits checking `main` methods, which are not usually documented in the way the others are.
changelog: none
Andre Bogus [Tue, 14 Jan 2020 17:20:56 +0000 (18:20 +0100)]
Omit doc safety/errors header checking for main
bors [Mon, 13 Jan 2020 22:09:39 +0000 (22:09 +0000)]
Auto merge of #4543 - xiongmao86:issue4503, r=flip1995
Fix issue4503
Fixes #4503.
changelog: Add a lint checking user are using FileType.is_file() method and suggest using !FileType.is_dir().
- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `./util/dev update_lints`
- [x] Added lint documentation
- [x] Run `./util/dev fmt`
bors [Mon, 13 Jan 2020 20:21:04 +0000 (20:21 +0000)]
Auto merge of #5033 - JohnTitor:split-use-self, r=flip1995
Split up `use_self` ui test
Part of #2038
changelog: none
ThibsG [Fri, 10 Jan 2020 16:14:17 +0000 (17:14 +0100)]
Extract visitor to utils
ThibsG [Fri, 10 Jan 2020 14:12:21 +0000 (15:12 +0100)]
Change note message
ThibsG [Fri, 10 Jan 2020 14:09:37 +0000 (15:09 +0100)]
Fix formatting
ThibsG [Fri, 10 Jan 2020 09:56:09 +0000 (10:56 +0100)]
Better binding name on Err for note
ThibsG [Fri, 10 Jan 2020 09:42:21 +0000 (10:42 +0100)]
Match underscore-prefixed variable also
bors [Mon, 13 Jan 2020 13:17:27 +0000 (13:17 +0000)]
Auto merge of #5042 - JohnTitor:rustup-0112, r=phansch
Rustup to rust-lang/rust#68045
This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`.
changelog: none
Yuki Okushi [Sun, 12 Jan 2020 06:08:41 +0000 (15:08 +0900)]
Rustup to rust-lang/rust#68045
xiongmao86 [Sat, 11 Jan 2020 03:57:49 +0000 (11:57 +0800)]
Pull master, rebase, and update_lints again.
xiongmao86 [Wed, 8 Jan 2020 08:56:28 +0000 (16:56 +0800)]
Update lints again.
xiongmao86 [Wed, 8 Jan 2020 08:50:37 +0000 (16:50 +0800)]
Fix grammar error.
Rui [Wed, 8 Jan 2020 08:40:34 +0000 (16:40 +0800)]
Update clippy_lints/src/methods/mod.rs
Co-Authored-By: Philipp Krones <hello@philkrones.com>
xiongmao86 [Tue, 7 Jan 2020 08:33:33 +0000 (16:33 +0800)]
Change lint message.
xiongmao86 [Tue, 7 Jan 2020 08:11:34 +0000 (16:11 +0800)]
./util/dev update_lints.
Rui [Sun, 5 Jan 2020 12:25:07 +0000 (20:25 +0800)]
Fix documents and messages.
Update clippy_lints/src/methods/mod.rs
xiongmao86 [Sat, 4 Jan 2020 03:27:24 +0000 (11:27 +0800)]
Extend spans to include !.
xiongmao86 [Sat, 4 Jan 2020 03:24:09 +0000 (11:24 +0800)]
Fix lint warning in compile-test.rs
xiongmao86 [Sat, 4 Jan 2020 02:18:58 +0000 (10:18 +0800)]
format codebase.
xiongmao86 [Fri, 3 Jan 2020 06:59:14 +0000 (14:59 +0800)]
Add lint logic.
xiongmao86 [Thu, 2 Jan 2020 05:12:23 +0000 (13:12 +0800)]
Declare lint.
xiongmao86 [Thu, 2 Jan 2020 03:37:32 +0000 (11:37 +0800)]
Add test.
Yuki Okushi [Thu, 9 Jan 2020 23:56:16 +0000 (08:56 +0900)]
Split up `use_self` ui test
bors [Sat, 11 Jan 2020 20:32:51 +0000 (20:32 +0000)]
Auto merge of #5040 - JohnTitor:rustup-0111, r=flip1995
Some rustups
changelog: none
Yuki Okushi [Sat, 11 Jan 2020 20:20:18 +0000 (05:20 +0900)]
Remove references
Yuki Okushi [Sat, 11 Jan 2020 18:41:54 +0000 (03:41 +0900)]
Rustup to rust-lang/rust#67000
Yuki Okushi [Sat, 11 Jan 2020 18:05:47 +0000 (03:05 +0900)]
Comment out half-open patterns' tests
Yuki Okushi [Sat, 11 Jan 2020 14:21:09 +0000 (23:21 +0900)]
Apply review comments
Yuki Okushi [Sat, 11 Jan 2020 11:37:08 +0000 (20:37 +0900)]
Rustup to rust-lang/rust#67806
Yuki Okushi [Sat, 11 Jan 2020 10:39:43 +0000 (19:39 +0900)]
Apply review comments
Yuki Okushi [Sat, 11 Jan 2020 00:06:09 +0000 (09:06 +0900)]
Rustup to rust-lang/rust#68101
Yuki Okushi [Sat, 11 Jan 2020 00:05:51 +0000 (09:05 +0900)]
Rustup to rust-lang/rust#67258
bors [Thu, 9 Jan 2020 21:24:34 +0000 (21:24 +0000)]
Auto merge of #5031 - JohnTitor:editorconfig, r=phansch
Prefer 2 spaces as indent size over 4 on yaml
We use 2 spaces as an indent on YAML like `.travis.yml` now but `.editorconfig` tells my editor that indent size is 4, not 2. It makes my editor confused.
changelog: none
bors [Thu, 9 Jan 2020 20:54:18 +0000 (20:54 +0000)]
Auto merge of #5030 - JohnTitor:split-missing-doc, r=phansch
Split up `missing-doc` ui test
Part of #2038
changelog: none
Yuki Okushi [Thu, 9 Jan 2020 00:04:53 +0000 (09:04 +0900)]
Split up `missing-doc` ui test
Yuki Okushi [Thu, 9 Jan 2020 08:49:24 +0000 (17:49 +0900)]
Prefer 2 spaces as indent size over 4 on yaml
bors [Thu, 9 Jan 2020 13:51:00 +0000 (13:51 +0000)]
Auto merge of #4960 - ThibsG:patterns_with_wildcard_#4640, r=flip1995
New lint: pats_with_wild_match_arm
Wildcard use with other pattern in same match arm.
The wildcard covers other(s) pattern(s) as it will match anyway.
changelog: add new lint when multiple patterns (including wildcard) are used in a match arm.
Fixes #4640.
bors [Thu, 9 Jan 2020 12:37:54 +0000 (12:37 +0000)]
Auto merge of #5025 - JohnTitor:rustup-0109, r=flip1995
Some rustups
changelog: none
Yuki Okushi [Thu, 9 Jan 2020 07:14:19 +0000 (16:14 +0900)]
Rustup to rust-lang/rust#68024
Yuki Okushi [Thu, 9 Jan 2020 07:13:22 +0000 (16:13 +0900)]
Rustup to rust-lang/rust#67979
Yuki Okushi [Thu, 9 Jan 2020 00:22:16 +0000 (09:22 +0900)]
Rustup to rust-lang/rust#67781
bors [Wed, 8 Jan 2020 20:28:19 +0000 (20:28 +0000)]
Auto merge of #5022 - flip1995:useless_attr, r=phansch
Fix useless_attribute suggestion
Fixes #5021
changelog: Fix [`useless_attribute`] suggestion, which tripped rustfix
flip1995 [Wed, 8 Jan 2020 16:31:27 +0000 (17:31 +0100)]
Add regression test for useless_attribute lint
flip1995 [Wed, 8 Jan 2020 16:31:06 +0000 (17:31 +0100)]
Fix useless attribute suggestion
bors [Wed, 8 Jan 2020 12:09:45 +0000 (12:09 +0000)]
Auto merge of #5017 - sinkuu:mir_no_opt_fallout, r=flip1995
Fix redundant_clone lint not working with PathBuf and OsString
https://github.com/rust-lang/rust-clippy/pull/4825 diabled MIR optimization in clippy, including `rustc_mir::transform::InstCombine` which reduces `&(*x)` to `x`. This PR tries to unwrap `&*` when looking into `mir::Rvalue`s.
Fixes #5014.
---
changelog: fixed `redundant_clone` lint not working with `PathBuf` and `OsString`
bors [Wed, 8 Jan 2020 08:42:46 +0000 (08:42 +0000)]
Auto merge of #5015 - krishna-veerareddy:change-float-to-int-transmute-category, r=flip1995
Move `transmute_float_to_int` lint to `complexity`
`transmute_float_to_int` lint was accidentally added to nursery so moving it to the complexity group.
changelog: Move `transmute_float_to_int` out of nursery
bors [Wed, 8 Jan 2020 08:14:31 +0000 (08:14 +0000)]
Auto merge of #5019 - JohnTitor:follow-up-normalize, r=phansch
Normalize lint messages in cast_precision_loss
Follow-up of #5000
changelog: none
Yuki Okushi [Tue, 7 Jan 2020 21:08:49 +0000 (06:08 +0900)]
Normalize lint messages in cast_precision_loss
bors [Wed, 8 Jan 2020 06:56:57 +0000 (06:56 +0000)]
Auto merge of #5018 - JohnTitor:rustup-0108, r=phansch
Rustup to rust-lang/rust#67970
changelog: none
Yuki Okushi [Wed, 8 Jan 2020 06:42:54 +0000 (15:42 +0900)]
Rustup to rust-lang/rust#67970
Shotaro Yamada [Wed, 8 Jan 2020 04:59:58 +0000 (13:59 +0900)]
Fix `redundant_clone`
Krishna Sai Veera Reddy [Tue, 7 Jan 2020 23:53:19 +0000 (15:53 -0800)]
Move `transmute_float_to_int` lint to `complexity`
`transmute_float_to_int` lint was accidentally added to nursery
so moving it to the complexity group.
ThibsG [Tue, 7 Jan 2020 17:13:31 +0000 (18:13 +0100)]
Span help without suggestion
ThibsG [Sun, 5 Jan 2020 14:05:16 +0000 (15:05 +0100)]
Change lint name to WILDCARD_IN_OR_PATTERNS
ThibsG [Thu, 2 Jan 2020 19:00:27 +0000 (20:00 +0100)]
Handle case for non-exhaustive enums
ThibsG [Fri, 27 Dec 2019 04:42:28 +0000 (05:42 +0100)]
Move to complexity and adapt test
- test wildcard_enum_match_arm has been impacted by this new lint
ThibsG [Fri, 27 Dec 2019 01:03:16 +0000 (02:03 +0100)]
Change group and use only func call
ThibsG [Fri, 27 Dec 2019 00:56:09 +0000 (01:56 +0100)]
Remove useless parameters in func call
ThibsG [Tue, 24 Dec 2019 15:42:09 +0000 (16:42 +0100)]
New lint: pats_with_wild_match_arm
- Wildcard use with other pattern in same match arm
bors [Tue, 7 Jan 2020 11:52:23 +0000 (11:52 +0000)]
Auto merge of #5000 - JohnTitor:backticks, r=flip1995
Normalize lint messages
On rustc diagnostics, we prefer to use backticks over `'`, `"`, or something else. I think we should follow their manner here.
In first commit, normalizes lint messages with backticks.
In second commit, updates all stderrs.
In third commit, updates descriptions on lintlist.
changelog: none
Yuki Okushi [Tue, 7 Jan 2020 10:56:21 +0000 (19:56 +0900)]
Bless 32bit test
Yuki Okushi [Mon, 6 Jan 2020 15:44:52 +0000 (00:44 +0900)]
Apply suggestion from code review
Yuki Okushi [Mon, 6 Jan 2020 07:41:15 +0000 (16:41 +0900)]
Update lintlist
Yuki Okushi [Mon, 6 Jan 2020 06:36:33 +0000 (15:36 +0900)]
Update stderrs
Yuki Okushi [Mon, 6 Jan 2020 06:30:43 +0000 (15:30 +0900)]
Normalize lint messages
bors [Tue, 7 Jan 2020 08:45:14 +0000 (08:45 +0000)]
Auto merge of #5011 - JohnTitor:split-collapsible-if, r=flip1995
Split up `collapsible_if` ui test
Part of #2038
changelog: none
bors [Tue, 7 Jan 2020 07:46:00 +0000 (07:46 +0000)]
Auto merge of #5010 - lzutao:recurse-remove_blocks, r=phansch
Make utils::remove_blocks non-recursive
changelog: none
bors [Tue, 7 Jan 2020 07:10:58 +0000 (07:10 +0000)]
Auto merge of #5002 - lzutao:fmt-fallout, r=flip1995
build: Use rustfmt from lastest nightly that contains it
changelog: none
bors [Tue, 7 Jan 2020 06:32:15 +0000 (06:32 +0000)]
Auto merge of #4999 - krishna-veerareddy:issue-4679-atomic-ordering, r=phansch
Add lint to detect usage of invalid atomic ordering
Detect usage of invalid atomic ordering modes such as `Ordering::{Release, AcqRel}` in atomic loads and `Ordering::{Acquire, AcqRel}` in atomic stores.
Fixes #4679
changelog: Add lint [`invalid_atomic_ordering`]
Yuki Okushi [Tue, 7 Jan 2020 06:06:23 +0000 (15:06 +0900)]
Split up `collapsible_if` ui test
bors [Tue, 7 Jan 2020 06:03:28 +0000 (06:03 +0000)]
Auto merge of #5009 - lzutao:travis-windows-msvc, r=phansch
Travis: Use windows-msvc target for Windows build
changelog: none
closes #5005
Lzu Tao [Tue, 7 Jan 2020 03:50:35 +0000 (10:50 +0700)]
Make utils::remove_blocks non-recursive
Lzu Tao [Tue, 7 Jan 2020 02:52:10 +0000 (09:52 +0700)]
Travis: Use windows-msvc target for Windows build
Krishna Sai Veera Reddy [Tue, 7 Jan 2020 01:33:28 +0000 (17:33 -0800)]
Prevent doc-tests from running and fix lint description
Krishna Sai Veera Reddy [Mon, 6 Jan 2020 00:52:15 +0000 (16:52 -0800)]
Split test cases into separate files
Krishna Sai Veera Reddy [Mon, 6 Jan 2020 00:16:27 +0000 (16:16 -0800)]
Add lint to detect usage of invalid atomic ordering
Detect usage of invalid atomic ordering modes such as
`Ordering::{Release, AcqRel}` in atomic loads and
`Ordering::{Acquire, AcqRel}` in atomic stores.
bors [Mon, 6 Jan 2020 22:48:22 +0000 (22:48 +0000)]
Auto merge of #5008 - JohnTitor:let-on-macros, r=flip1995
Do not trigger `let_and_return` lint on macros
Fixes #4997
changelog: Fix false positive in `let_and_return`
Yuki Okushi [Mon, 6 Jan 2020 20:26:20 +0000 (05:26 +0900)]
Do not trigger `let_and_return` lint on macros
Lzu Tao [Mon, 6 Jan 2020 12:33:27 +0000 (19:33 +0700)]
build: Use rustfmt from lastest nightly that contains it
bors [Mon, 6 Jan 2020 18:15:48 +0000 (18:15 +0000)]
Auto merge of #5003 - JohnTitor:rustup, r=flip1995
Rustup to rust-lang/rust#67886
changelog: none
Yuki Okushi [Mon, 6 Jan 2020 17:04:10 +0000 (02:04 +0900)]
Fix test again