]>
git.lizzy.rs Git - rust.git/log
Micha Ober [Sat, 5 Oct 2019 12:23:52 +0000 (14:23 +0200)]
Add real suggestion to option_map_unwrap_or
bors [Sat, 28 Dec 2019 18:41:38 +0000 (18:41 +0000)]
Auto merge of #4964 - JohnTitor:fix-potential-ice, r=flip1995
Possibly fix an ICE on test
Fix a potential ICE on test with debug assertion, caused on rust-lang/rust#67661.
r? @oli-obk
changelog: none
bors [Sat, 28 Dec 2019 18:26:15 +0000 (18:26 +0000)]
Auto merge of #4867 - mgr-inz-rafal:modulo_arithmetic, r=flip1995
Modulo arithmetic
changelog: Added modulo_arithmetic lint
mgr-inz-rafal [Sat, 28 Dec 2019 16:14:19 +0000 (17:14 +0100)]
Fixes for elided lifetimes
mgr-inz-rafal [Thu, 26 Dec 2019 12:34:55 +0000 (13:34 +0100)]
Add tests for new lint (modulo_arithmetic)
mgr-inz-rafal [Thu, 26 Dec 2019 12:34:18 +0000 (13:34 +0100)]
Add new lint (modulo_arithmetic)
Yuki Okushi [Sat, 28 Dec 2019 13:45:41 +0000 (22:45 +0900)]
code review
Yuki Okushi [Sat, 28 Dec 2019 12:13:21 +0000 (21:13 +0900)]
Possibly fix an ICE on test
bors [Fri, 27 Dec 2019 20:05:08 +0000 (20:05 +0000)]
Auto merge of #4963 - JohnTitor:unknown-clippy-lint, r=phansch
Suggest similar lint name on `unknown_clippy_lints`
Suggest a similar lint name with Levenshtein distance on `unknown_clippy_lints`.
And lowercase suggestion behavior is also changed.
changelog: Suggest similar lint name on `unknown_clippy_lints`
Yuki Okushi [Fri, 27 Dec 2019 11:41:26 +0000 (20:41 +0900)]
Improve tests
Yuki Okushi [Fri, 27 Dec 2019 11:41:11 +0000 (20:41 +0900)]
Suggest similar lint name on unknown_clippy_lints
bors [Fri, 27 Dec 2019 12:46:42 +0000 (12:46 +0000)]
Auto merge of #4962 - JohnTitor:rustup-1227, r=matthiaskrgr
Rustup to rust-lang/rust#66936
changelog: none
Yuki Okushi [Fri, 27 Dec 2019 07:12:26 +0000 (16:12 +0900)]
Rustup to rust-lang/rust#66936
bors [Wed, 25 Dec 2019 19:39:13 +0000 (19:39 +0000)]
Auto merge of #4956 - JohnTitor:decimal-lit-suffix, r=llogiq
Do not drop suffixes on `decimal_literal_representation`
Fixes #4763
changelog: Do not drop type suffixes on `decimal_literal_representation`
bors [Wed, 25 Dec 2019 16:27:18 +0000 (16:27 +0000)]
Auto merge of #4954 - JohnTitor:improve-len-zero-doc, r=llogiq
Correct documentation for `len_zero`
Fixes #4902
changelog: none
Yuki Okushi [Wed, 25 Dec 2019 16:22:36 +0000 (01:22 +0900)]
Do not drop suffixes on `decimal_literal_representation`
Yuki Okushi [Wed, 25 Dec 2019 12:06:55 +0000 (21:06 +0900)]
Correct documentation for `len_zero`
bors [Tue, 24 Dec 2019 15:03:54 +0000 (15:03 +0000)]
Auto merge of #4947 - rust-lang:doc-main-extern-crate, r=flip1995
Avoid needless_doctest_main on 'extern crate'
This fixes #4927.
r? @flip1995
changelog: none
bors [Tue, 24 Dec 2019 13:32:45 +0000 (13:32 +0000)]
Auto merge of #4885 - rust-lang:mut-key-types, r=flip1995
new lint: mutable_key_type
This fixes #732 - well, partly, it doesn't adress `Hash` impls, but the use of mutable types as map keys or set members
changelog: add `mutable_key_type` lint
r? @flip1995
Andre Bogus [Fri, 6 Dec 2019 18:45:33 +0000 (19:45 +0100)]
new lint: mutable_key_type
Andre Bogus [Mon, 23 Dec 2019 12:11:20 +0000 (13:11 +0100)]
Avoid needless_doctest_main on 'extern crate'
bors [Tue, 24 Dec 2019 08:07:58 +0000 (08:07 +0000)]
Auto merge of #4948 - lzutao:rustup-67538, r=phansch
rustup "Add span information to `ExprKind::Assign`"
cc https://github.com/rust-lang/rust/pull/67538
changelog: none
Lzu Tao [Tue, 24 Dec 2019 04:16:04 +0000 (11:16 +0700)]
rustup "Add span information to `ExprKind::Assign`"
bors [Mon, 23 Dec 2019 20:10:59 +0000 (20:10 +0000)]
Auto merge of #4946 - lzutao:take, r=flip1995
a few minor cleanups
changelog: none
Lzu Tao [Mon, 23 Dec 2019 20:06:52 +0000 (03:06 +0700)]
do minor cleanups
* ToString and AsRef are in prelude, no need to import them
bors [Mon, 23 Dec 2019 17:00:38 +0000 (17:00 +0000)]
Auto merge of #4934 - illicitonion:exhaustive_match, r=flip1995
Update wildcard enum match lint for non_exhaustive enums
changelog: wildcard_enum_match_arm gives better suggestions for non_exhaustive enums
bors [Mon, 23 Dec 2019 16:06:56 +0000 (16:06 +0000)]
Auto merge of #4911 - phansch:update_changelog, r=flip1995
Update changelog for Rust 1.39 and 1.40
[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog/CHANGELOG.md)
changelog: none
bors [Mon, 23 Dec 2019 06:34:32 +0000 (06:34 +0000)]
Auto merge of #4939 - matthiaskrgr:bump_git_dep, r=phansch
deps: bump git2 from 0.10 to 0.11
changelog: none
bors [Mon, 23 Dec 2019 06:16:37 +0000 (06:16 +0000)]
Auto merge of #4823 - Areredify:must_use_res, r=flip1995
Add `let_underscore_must_use` lint
changelog: closes #4812 , added a new `let_underscore_must_use` lint, moved `is_must_use_ty` to utils, added `is_must_use_fn` util function
Philipp Hansch [Mon, 23 Dec 2019 06:08:09 +0000 (07:08 +0100)]
Fix two commit hashes in changelog
bors [Mon, 23 Dec 2019 06:00:54 +0000 (06:00 +0000)]
Auto merge of #4941 - lzutao:utils-mod, r=phansch
a few small cleanups
changelog: none
bors [Mon, 23 Dec 2019 00:28:07 +0000 (00:28 +0000)]
Auto merge of #4944 - JohnTitor:rustup, r=oli-obk
Rustup to rust-lang/rust#66877
changelog: none
Yuki Okushi [Sun, 22 Dec 2019 23:39:33 +0000 (08:39 +0900)]
Rustup to rust-lang/rust#66877
Lzu Tao [Sun, 22 Dec 2019 22:46:17 +0000 (05:46 +0700)]
update term to 0.6
Lzu Tao [Sun, 22 Dec 2019 21:49:59 +0000 (04:49 +0700)]
a few small cleanups
Mikhail Babenko [Sat, 16 Nov 2019 14:55:00 +0000 (17:55 +0300)]
implemented `let_underscore` lint
actually add files
update lints
change to pedantic
Mikhail Babenko [Wed, 13 Nov 2019 23:42:00 +0000 (02:42 +0300)]
move is_must_use_ty to utils
Matthias Krüger [Sun, 22 Dec 2019 16:06:43 +0000 (17:06 +0100)]
deps: bump git2 from 0.10 to 0.11
bors [Sun, 22 Dec 2019 14:58:55 +0000 (14:58 +0000)]
Auto merge of #4938 - flip1995:rustup, r=flip1995
Rustup to rust-lang/rust#66931
changelog: none
flip1995 [Sun, 22 Dec 2019 14:56:34 +0000 (15:56 +0100)]
Rustup to rust-lang/rust#66931
flip1995 [Sun, 22 Dec 2019 14:42:41 +0000 (15:42 +0100)]
Add <'_> where necessary
Daniel Wagner-Hall [Sun, 22 Dec 2019 11:51:39 +0000 (11:51 +0000)]
Remove trailling .s
bors [Sun, 22 Dec 2019 09:55:50 +0000 (09:55 +0000)]
Auto merge of #4937 - mikerite:fix-4824, r=phansch
Fix `map_clone` false positive
Don't lint when the item type is not a reference. `copied` only applies to references.
changelog: Fix `map_clone` false positive
bors [Sun, 22 Dec 2019 09:39:32 +0000 (09:39 +0000)]
Auto merge of #4930 - flip1995:unused_label, r=phansch
Deprecate unused_label lint
This lint was uplifted/turned into warn-by-default in rustc
Fixes #4925
changelog: Deprecate [`unused_label`] lint
Michael Wright [Sun, 22 Dec 2019 09:26:51 +0000 (11:26 +0200)]
Fix `map_clone` false positive
Don't lint when the item type is not a reference. `copied` only applies
to references.
bors [Sun, 22 Dec 2019 09:22:09 +0000 (09:22 +0000)]
Auto merge of #4935 - krishna-veerareddy:issue-4241-cognitive-complexity-lint-span, r=phansch
Reduce cognitive complexity lint span
Currently the cognitive complexity lint spans the entire function body making it really difficult to read and refactor the code in editors. To fix this we reduce the lint span to the function name.
changelog: Reduce cognitive complexity lint span
Fixes #4241
Daniel Wagner-Hall [Sun, 22 Dec 2019 02:13:39 +0000 (02:13 +0000)]
Update wildcard enum match lint for non_exhaustive enums
Krishna Veera Reddy [Sun, 22 Dec 2019 02:07:53 +0000 (18:07 -0800)]
Reduce cognitive complexity lint span
Currently the cognitive complexity lint spans the entire function
body making it really difficult to read and refactor the code in
editors. To fix this we reduce the lint span to the function name.
bors [Sat, 21 Dec 2019 19:43:00 +0000 (19:43 +0000)]
Auto merge of #4932 - lzutao:rustup-67355, r=matthiaskrgr
rustup "Merge `ast::Mutability` and `mir::Mutability`"
cc https://github.com/rust-lang/rust/pull/67355
changelog: none
Lzu Tao [Sat, 21 Dec 2019 18:38:45 +0000 (18:38 +0000)]
rustup "Merge `ast::Mutability` and `mir::Mutability`"
flip1995 [Sat, 21 Dec 2019 15:20:30 +0000 (16:20 +0100)]
Deprecate unused_label lint
This lint was uplifted/turned into warn-by-default in rustc
bors [Sat, 21 Dec 2019 15:09:09 +0000 (15:09 +0000)]
Auto merge of #4922 - oli-cosmian:patch-1, r=flip1995
There are no per-file copyright headers anymore
changelog: none
bors [Sat, 21 Dec 2019 14:16:13 +0000 (14:16 +0000)]
Auto merge of #4929 - matthiaskrgr:rustup_25, r=matthiaskrgr
rustup https://github.com/rust-lang/rust/pull/67130
changelog: none
Matthias Krüger [Sat, 21 Dec 2019 14:13:22 +0000 (15:13 +0100)]
rustup https://github.com/rust-lang/rust/pull/67130
bors [Sat, 21 Dec 2019 01:10:52 +0000 (01:10 +0000)]
Auto merge of #4926 - matthiaskrgr:rurstup_24, r=matthiaskrgr
rustup https://github.com/rust-lang/rust/pull/67455
changelog: none
Matthias Krüger [Fri, 20 Dec 2019 20:19:46 +0000 (21:19 +0100)]
rustup https://github.com/rust-lang/rust/pull/67455
Oliver Scherer @ Cosmian [Fri, 20 Dec 2019 08:57:02 +0000 (09:57 +0100)]
There are no per-file copyright headers anymore
bors [Fri, 20 Dec 2019 07:27:24 +0000 (07:27 +0000)]
Auto merge of #4920 - lily-commure:fix-unnecessary-filter-map-docs, r=phansch
Fix documentation example for unnecessary_filter_map.
Fixes #4919.
changelog: none
bors [Fri, 20 Dec 2019 07:10:11 +0000 (07:10 +0000)]
Auto merge of #4913 - mikerite:step-by-zero-
20191218 , r=phansch
Move `iterator_step_by_zero` and correct the documentation
Move `iterator_step_by_zero` and correct the documentation.
changelog: Corrected `iterator_step_by_zero` documentation
Michael Wright [Fri, 20 Dec 2019 06:22:43 +0000 (08:22 +0200)]
Update lints for `iterator_step_by_zero` changes
bors [Fri, 20 Dec 2019 06:02:59 +0000 (06:02 +0000)]
Auto merge of #4921 - qoh:patch-1, r=phansch
Fix 'redudant' spelling in redundant_clone docs
The word 'redundant' is spelled incorrectly in the **What it does** section of the redundant_clone lint's documentation.
changelog: Fix spelling in redundant_clone lint documentation
Emma [Fri, 20 Dec 2019 00:07:42 +0000 (01:07 +0100)]
Fix 'redudant' spelling in redundant_clone docs
The word 'redundant' is spelled incorrectly in the **What it does** section of the redundant_clone documentation.
Lily Chung [Thu, 19 Dec 2019 23:48:17 +0000 (15:48 -0800)]
Fix documentation example for unnecessary_filter_map.
bors [Thu, 19 Dec 2019 09:44:14 +0000 (09:44 +0000)]
Auto merge of #4915 - mikerite:fix-4912-2, r=phansch
Fix `expect_fun_call` false negative on references
Closes #4912
changelog: Fix `expect_fun_call` false negative on references
Michael Wright [Wed, 18 Dec 2019 19:54:37 +0000 (21:54 +0200)]
Fix `expect_fun_call` false negative on references
Closes #4912
mikerite [Thu, 19 Dec 2019 04:51:26 +0000 (06:51 +0200)]
Fix `iterator_step_by_zero` description in declaration
Co-Authored-By: Phil Hansch <dev@phansch.net>
bors [Wed, 18 Dec 2019 20:35:09 +0000 (20:35 +0000)]
Auto merge of #4910 - krishna-veerareddy:issue-1205-cmp-nan-against-consts, r=phansch
Detect comparisons with NAN constants
Currently `cmp_nan` lint doesn't detect comparisons with NaN's if the operands are consts variables so to fix this we evaluate the const variables first before testing for NaN.
changelog: Detect comparisons with NaN constants in `cmp_nan` lint
Fixes #1205
Philipp Hansch [Wed, 18 Dec 2019 07:13:36 +0000 (08:13 +0100)]
Update changelog for Rust 1.39 and 1.40
Michael Wright [Wed, 18 Dec 2019 17:19:26 +0000 (19:19 +0200)]
Fix `iterator_step_by_zero` definition
Michael Wright [Wed, 18 Dec 2019 16:59:59 +0000 (18:59 +0200)]
Correct `iterator_step_by_zero` documentation
Michael Wright [Wed, 18 Dec 2019 16:59:43 +0000 (18:59 +0200)]
Update iterator_step_by_zero
Move `iterator_step_by_zero` into `methods` since it applies to all
iterators and not just ranges. Simplify the code while doing so.
Krishna Veera Reddy [Wed, 18 Dec 2019 03:18:42 +0000 (19:18 -0800)]
Prevent `cmp_nan` when inside constants
`std::{f32,f64}::is_nan` isn't a const fn so prevent `cmp_nan`
lint from running within constant comparisons.
Krishna Veera Reddy [Wed, 18 Dec 2019 02:51:30 +0000 (18:51 -0800)]
Detect comparisons with NAN constants
Currently `cmp_nan` lint doesn't detect comparisons with NaN's
if the operands are consts variables so to fix this we evaluate
the const variables first before testing for NaN.
bors [Tue, 17 Dec 2019 09:00:51 +0000 (09:00 +0000)]
Auto merge of #4907 - krishna-veerareddy:fix-clippy-build, r=phansch
Fix clippy build failure
Clippy build fails because the feature `result_map_or` has been stabilized in v1.41.0 but we still have an explicit feature attribute for it.
changelog: none
Krishna Veera Reddy [Tue, 17 Dec 2019 06:29:05 +0000 (22:29 -0800)]
Fix clippy build failure
Clippy build fails because the feature `result_map_or` has been
stabilized in v1.41.0 but we still have an explicit feature
attribute for it.
Manish Goregaokar [Sun, 15 Dec 2019 01:40:33 +0000 (17:40 -0800)]
Merge pull request #4900 from Mark-Simulacrum/niko-no-never
Update tests for revert of never type stabilization
Mark Rousskov [Sat, 14 Dec 2019 13:40:43 +0000 (08:40 -0500)]
Update tests for revert of never type stabilization
bors [Thu, 12 Dec 2019 00:34:59 +0000 (00:34 +0000)]
Auto merge of #4883 - krishna-veerareddy:issue-4818-cast-sign-loss-false-positive, r=flip1995
Fix false positive with cast_sign_loss lint
`cast_sign_loss` lint incorrectly suggests that the result of `checked_abs`, `rem_euclid` and `checked_rem_euclid` cannot be casted to an unsigned integer without loss.
Fixes #4818 #4764 #4743
changelog: Fix false positives in `cast_sign_loss` lint
bors [Wed, 11 Dec 2019 12:01:10 +0000 (12:01 +0000)]
Auto merge of #4886 - rust-lang:must-use-pub-only, r=phansch
Lint only exported must_use_candidates
As promised on #4779, here's the check for publicly visible items for `must_use_candidate`
changelog: none
bors [Sun, 8 Dec 2019 02:23:23 +0000 (02:23 +0000)]
Auto merge of #4889 - krishna-veerareddy:issue-3993-float-to-int-transmute, r=llogiq
Add lint to detect transmutes from float to integer
Add lint that detects transmutation from a float to an integer and suggests usage of `{f32, f64}.to_bits()` instead.
Fixes #3993
changelog: Add lint `transmute_float_to_int`
Krishna Veera Reddy [Sun, 8 Dec 2019 00:59:17 +0000 (16:59 -0800)]
Move `transmute_float_to_int` test cases into separate file
`transmute.stderr` file line count exceeded due to the new test
cases so moving the new test cases into a separate file.
Krishna Veera Reddy [Sun, 8 Dec 2019 00:33:49 +0000 (16:33 -0800)]
Add lint to detect transmutes from float to integer
Add lint that detects transmutation from a float to an integer
and suggests usage of `{f32, f64}.to_bits()` instead.
Andre Bogus [Fri, 6 Dec 2019 19:10:14 +0000 (20:10 +0100)]
Lint only exported must_use_candidates
bors [Fri, 6 Dec 2019 11:30:43 +0000 (11:30 +0000)]
Auto merge of #4884 - RobbieClarken:warn-missing-errors, r=llogiq
Add lint for pub fns returning a `Result` without documenting errors
The Rust Book recommends that functions that return a `Result` type have [a doc comment with an `# Errors` section](https://doc.rust-lang.org/book/ch14-02-publishing-to-crates-io.html#commonly-used-sections) describing the kind of errors that can be returned. This change adds a lint to enforce this. The lint is allow by default; it can be enabled with `#![warn(clippy::missing_errors_doc)]`.
Closes #4854.
changelog: adds lint for `missing_errors_doc`
RobbieClarken [Fri, 6 Dec 2019 00:00:23 +0000 (10:30 +1030)]
Add lint for pub fns returning a `Result` without documenting errors
The Rust Book recommends that functions that return a `Result` type have
a doc comment with an `# Errors` section describing the kind of errors
that can be returned
(https://doc.rust-lang.org/book/ch14-02-publishing-to-crates-io.html#commonly-used-sections).
This change adds a lint to enforce this. The lint is allow by default;
it can be enabled with `#![warn(clippy::missing_errors_doc)]`.
Closes #4854.
Krishna Veera Reddy [Fri, 6 Dec 2019 01:18:27 +0000 (17:18 -0800)]
Add widening tests for `cast_sign_loss` lint
Krishna Veera Reddy [Thu, 5 Dec 2019 23:47:15 +0000 (15:47 -0800)]
Fix false positive with cast_sign_loss lint
`cast_sign_loss` lint incorrectly suggests that the result of
`checked_abs`, `rem_euclid` and `checked_rem_euclid` cannot
be casted to an unsigned integer without loss.
bors [Thu, 5 Dec 2019 10:33:07 +0000 (10:33 +0000)]
Auto merge of #4880 - daxpedda:string-add, r=phansch
Fix false positive in `string_add`.
`clippy::string_add` was popping up in macros.
I'm not sure what clippy's general direction is in these matters, but I can change it to be external macros only too.
---
changelog: Fix false positives for `string_add` in macro expansions.
daxpedda [Thu, 5 Dec 2019 10:06:13 +0000 (11:06 +0100)]
Change to only detect in external macros.
daxpedda [Wed, 4 Dec 2019 20:50:28 +0000 (21:50 +0100)]
Fix false positive in `string_add`.
bors [Wed, 4 Dec 2019 00:35:36 +0000 (00:35 +0000)]
Auto merge of #4879 - matthiaskrgr:rustup_23, r=flip1995
Rustup to rust-lang/rust#66878
I need to sleep now, feel free to pick it up.
The output of the `lint_without_lint_pass` test seems to disappear, I'm not sure why.. :/
changelog: none
Matthias Krüger [Tue, 3 Dec 2019 23:16:03 +0000 (00:16 +0100)]
Rustup to rust-lang/rust#66878
bors [Tue, 3 Dec 2019 18:36:19 +0000 (18:36 +0000)]
Auto merge of #4877 - flip1995:manual_swap_4853, r=llogiq
Fix FP in manual_swap lint with slice-like types
Fixes #4853
changelog: Fix FP in [`manual_swap`] lint with slice-like types and make it auto applicable
bors [Tue, 3 Dec 2019 17:56:14 +0000 (17:56 +0000)]
Auto merge of #4878 - flip1995:rustup, r=flip1995
Rustup
Included rustups:
- rust-lang/rust#66935 (syntax: Unify macro and attribute arguments in AST)
- rust-lang/rust#66941 (Remove `ord` lang item)
Fixes? #2597
changelog: none
flip1995 [Tue, 3 Dec 2019 17:26:56 +0000 (18:26 +0100)]
Update op_ref.stderr
flip1995 [Tue, 3 Dec 2019 17:24:26 +0000 (18:24 +0100)]
Make OP_REF lint suggestion MaybeIncorrect
cc #2597
Christopher Durham [Tue, 3 Dec 2019 01:01:50 +0000 (20:01 -0500)]
Fire clippy::op_ref on PartialOrd but !Ord types
flip1995 [Tue, 3 Dec 2019 16:54:32 +0000 (17:54 +0100)]
Rustup to rust-lang/rust#66935
flip1995 [Tue, 3 Dec 2019 15:29:05 +0000 (16:29 +0100)]
Fix rustdoc examples
flip1995 [Tue, 3 Dec 2019 12:42:05 +0000 (13:42 +0100)]
Make manual_swap autofixable