Simplify

Merge #5301

5301: Don't spawn notify unnecessary r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Don't spawn notify unnecessary

Merge #5300

5300: Update deps r=matklad a=kjeremy

Bumps tracing to 0.1.16 which reduces monomorphization: https://github.com/rust-analyzer/rust-analyzer/issues/1987#issuecomment-654711560

Co-authored-by: kjeremy <kjeremy@gmail.com>

Update deps

Merge #5299

5299: Reload when new example/test/etc is added r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Optimize VFS processing

Sort cargo metadata

See https://github.com/rust-lang/cargo/issues/8477

We need this to prevent spurious workspace reloads

Add profiling calls

Also reload when adding new examples, tests, etc

Merge #5298

5298: Better caret placement when filling match arms r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Better caret placement when filling match arms

Merge #5297

5297: Better name r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Better name

Merge #5296

5296: Don't add braces after struct r=matklad a=matklad

Unit structs are a thing

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Don't add braces after struct

Unit structs are a thing

Better complete expression keywords

Merge #5295

5295: Complete params in nested fns r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Complete params in nested fns

Merge #5294

5294: Complete parameters more aggressively r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Complete parameters more aggressively

Refresh tests

Merge #5293

5293: Automatically reload project info on Cargo.toml changes r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Automatically reload project info on Cargo.toml changes

Merge #5292

5292: Goto type definition improvements r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Look through Arc for goto type definition

Simplify tests

Dont expose ID

Rename

Goto type definition works for self

Merge #5286

5286: Only take first 500 syntax errors r=jonas-schievink a=yihuang

Too many syntax errors make some editor/ide slow, fix #3434.

Co-authored-by: yihuang <yi.codeplayer@gmail.com>

Only take first 500 syntax errors

Too many syntax errors make some editor/ide slow, fix #3434.

Merge #5288

5288: Avoid accidently stumping over config values r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Avoid accidently stumping over config values

Merge #5285

5285: Don't mess with cursor position when adding hashes r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Don't mess with cursor position when adding hashes

Merge #5284

5284: Fold struct literals r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Fold struct literals

Merge #5283

5283: Arg count mismatch diagnostic: Handle tuple struct/variant ctors r=jonas-schievink a=jonas-schievink

I didn't know `callable_item_signature` was a thing, that makes this really easy.

bors r+

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>

arg count mismatch: handle tuple ctors

Merge #5270

5270: Add argument count mismatch diagnostic r=matklad a=jonas-schievink

Closes https://github.com/rust-analyzer/rust-analyzer/issues/4025.

This currently has one false positive on this line, where `max` is resolved to `Iterator::max` instead of `Ord::max`:

https://github.com/rust-analyzer/rust-analyzer/blob/8aa10c00a4c5b957d459fac5a103cd9688e8dcdd/crates/expect/src/lib.rs#L263

(I have no idea why it thinks that `usize` is an `Iterator`)

TODO:
* [x] Tests
* [x] Improve diagnostic text for method calls

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>

Address review comments

Merge #5282

5282: Move diagnostics tests to expect r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Always put config first

Move diagnostics tests to expect

Add tests

Fix diagnostic for method calls

Correctly pluralize message

Remove unnecessary DiagnosticSink handlers

Add fixmes

Simplify

Cleanup diagnostic conversion code

Merge #5281

5281: Remove insta from ra_ide r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Remove insta from ra_ide

Cleanup diagnostics tests

Reduce code duplication

Don't emit diagnostic if there are type errors

Add argument count mismatch diagnostic

Merge #5280

5280: Re-enable IDE features for incomplete impl blocs r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Re-enable IDE features for incomplete impl blocs

Merge #5279

5279: Simplify r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Simplify

Merge #5278

5278: expect should be a dev dep r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

expect should be a dev dep

Unify tests

Merge #5276

5276: Streamline r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

No blank indent

Prettier rendering

Streamline

Reduce API

Cleanup

Reduce API

Rename

Merge #5273

5273: Refactor hover tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Refactor hover tests

Simplify tests

better language

Add Markup type

Merge #5272

5272: :arrow_up: deps r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

:arrow_up: deps

Merge #5271

5271: Tidyup hover r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

simplify

Minimize API

Dead code

Reduce visibility

Merge #5266

5266: Remove relative_path dependency r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Remove relative_path dependency

Remove unwanted dependency

Document failed refactor

Merge #5263

5263: Fix some clippy perf warnings r=matklad a=kjeremy

Co-authored-by: kjeremy <kjeremy@gmail.com>

Clippy perf warnings

Merge #5262

5262: Workaround rollup messing up default imports r=matklad a=Veetaha

Tackles https://github.com/rust-analyzer/rust-analyzer/issues/5257#issuecomment-655435271
Related: https://github.com/rollup/plugins/issues/491

Co-authored-by: Veetaha <veetaha2@gmail.com>

Workaround rollup messing up default imports

Merge #5255

5255: Replace ad hocery with science r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Replace ad hocery with science

Merge #4972

4972: Gzip artifacts r=Veetaha a=Veetaha

[Here is the test release](https://github.com/Veetaha/rust-analyzer/releases/tag/2020-06-21)

Change in size:  `~ 25 MB -> ~ 8 MB (gzipped)`

The time to gzip during the dist build takes a somewhat considerable amount of time tho.
Having already compiled artifacts this takes in debug mode:
```
~/dev/rust-analyzer (feat/gzip-binaries) $ time cargo xtask dist
    Finished dev [unoptimized] target(s) in 0.06s
     Running `target/debug/xtask dist`
> cargo build --manifest-path ./crates/rust-analyzer/Cargo.toml --bin rust-analyzer --release
    Finished release [optimized] target(s) in 0.05s
> strip ./target/release/rust-analyzer

real    0m34.331s
user    0m34.245s
sys     0m0.078s
```
In release mode this is much faster:
```
~/dev/rust-analyzer (feat/gzip-binaries) $ time cargo run -p xtask --release -- dist
    Finished release [optimized] target(s) in 0.04s
     Running `target/release/xtask dist`
> cargo build --manifest-path ./crates/rust-analyzer/Cargo.toml --bin rust-analyzer --release
    Finished release [optimized] target(s) in 0.06s
> strip ./target/release/rust-analyzer

real    0m2.401s
```

**[UPD]** adding a profile override for `miniz_oxide` does the thing to ensure good performrance

We might need to notify all other ra plugins' maintainers about the change in our GH releases if we merge this PR, or we could leave uncompressed files along with gzipped for a while until everyone migrates.

Co-authored-by: Veetaha <veetaha2@gmail.com>

Gzip artifacts

Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
Override miniz_oxide to build it with optimizations

Building this crate with optimizations decreases the gzipping
part of `cargo xtask dist` from `30-40s` down to `3s`,
the overhead for `rustc` to apply optimizations is miserable on this background

Merge #5253

5253: Automate rust-analyzer promotion r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Automate rust-analyzer promotion

.