]>
git.lizzy.rs Git - rust.git/log
bors [Thu, 3 Sep 2020 05:12:26 +0000 (05:12 +0000)]
Auto merge of #6003 - mikerite:fix-tests-
20200903 , r=phansch
Update ui stderr with improved rustc output
Related rust pull request: rust-lang/rust#76160
changelog: none
Michael Wright [Thu, 3 Sep 2020 02:58:14 +0000 (04:58 +0200)]
Update ui stderr with improved rustc output
Related rust pull request: rust-lang/rust#76160
bors [Wed, 2 Sep 2020 12:24:31 +0000 (12:24 +0000)]
Auto merge of #5996 - Koxiaet:master, r=ebroto
Allow GraphQL in docs without backticks
changelog: Allow "GraphQL" in [`doc_markdown`] without backticks.
Koxiaet [Wed, 2 Sep 2020 11:51:44 +0000 (12:51 +0100)]
Add tests for allowed non-backticked identifiers in doc
bors [Wed, 2 Sep 2020 07:56:44 +0000 (07:56 +0000)]
Auto merge of #6000 - ebroto:sync-from-rust, r=ebroto
Sync from rust
r? @ghost
changelog: none
Eduardo Broto [Wed, 2 Sep 2020 06:57:00 +0000 (08:57 +0200)]
Run cargo dev fmt
Eduardo Broto [Wed, 2 Sep 2020 06:53:29 +0000 (08:53 +0200)]
Merge remote-tracking branch 'upstream/master' into sync-from-rust
bors [Tue, 1 Sep 2020 22:28:55 +0000 (22:28 +0000)]
Auto merge of #5999 - rail-rain:fix_fp_transmute_ptr_to_ptr_in_consts, r=ebroto
Fix a fp in `transmute_ptr_to_ptr`
fixes #5959
changelog: Fix a false positive in `transmute_ptr_to_ptr` that the lint fires when `transmute` is used to cast a reference in const contexts although dereferencing raw pointers in consts is unstable.
bors [Tue, 1 Sep 2020 15:05:16 +0000 (15:05 +0000)]
Auto merge of #5993 - taiki-e:default_trait_access, r=phansch
default_trait_access: Fix wrong suggestion
https://github.com/rust-lang/rust-clippy/issues/5975#issuecomment-
683751131
> I think the underlying problem is clippy suggests code with complete parameters, not clippy triggers this lint even for complex types. AFAIK, If code compiles with `Default::default`, it doesn't need to specify any parameters, as type inference is working. (So, in this case, `default_trait_access` should suggest `RefCell::default`.)
Fixes #5975 Fixes #5990
changelog: `default_trait_access`: fixed wrong suggestion
Koxiaet [Tue, 1 Sep 2020 13:05:19 +0000 (14:05 +0100)]
Allow GraphQL in doc without backticks
rail [Mon, 31 Aug 2020 23:21:48 +0000 (11:21 +1200)]
Fix a fp in `transmute_ptr_to_ptr`
Avoid firing the lint when `transmute` in const contexts
as dereferencing raw pointers in consts is unstable. cc #5959
bors [Mon, 31 Aug 2020 19:41:13 +0000 (19:41 +0000)]
Auto merge of #5992 - giraffate:fix_wrong_seggestion_in_collapsible_if, r=yaahc
Fix the wrong suggestion when using macro in `collapsible_if`
Fix #5962
changelog: Fix the wrong suggestion when using macro in `collapsible_if`
bors [Mon, 31 Aug 2020 19:20:30 +0000 (19:20 +0000)]
Auto merge of #5909 - khuey:async_yields_async, r=yaahc
Add a lint for an async block/closure that yields a type that is itself awaitable.
This catches bugs of the form
tokio::spawn(async move {
let f = some_async_thing();
f // Oh no I forgot to await f so that work will never complete.
});
See the two XXXkhuey comments and the unfixed `_l` structure for things that need more thought.
*Please keep the line below*
changelog: none
Taiki Endo [Mon, 31 Aug 2020 15:31:53 +0000 (00:31 +0900)]
default_trait_access: Fix wrong suggestion
Takayuki Nakata [Mon, 31 Aug 2020 15:05:53 +0000 (00:05 +0900)]
Fix the wrong suggestion when using macro in `collapsible_if`
bors [Mon, 31 Aug 2020 10:43:58 +0000 (10:43 +0000)]
Auto merge of #5984 - ebroto:5693_const_assoc_fn, r=flip1995
or_fn_call: ignore nullary associated const fns
The fix in #5889 was missing associated functions.
changelog: Ignore also `const fn` methods in [`or_fun_call`]
Fixes #5693
Aaron Hill [Sun, 30 Aug 2020 23:17:17 +0000 (19:17 -0400)]
Fix clippy
bors [Sun, 30 Aug 2020 20:21:00 +0000 (20:21 +0000)]
Auto merge of #5988 - camelid:patch-2, r=ebroto
Syntax-highlight `single_char_push_str` lint
It wasn't being syntax highlighted in the online lint index:
![image](https://user-images.githubusercontent.com/
37223377 /
91666682 -
8fc02000 -eab3-11ea-95fa-
6671472712c8 .png)
changelog: none
Camelid [Sun, 30 Aug 2020 18:24:15 +0000 (11:24 -0700)]
Syntax-highlight `single_char_push_str` lint
Kyle Huey [Sun, 23 Aug 2020 04:40:01 +0000 (21:40 -0700)]
Formatting changes requested by ThibsG.
Kyle Huey [Sun, 23 Aug 2020 04:36:39 +0000 (21:36 -0700)]
Add a test for an async function.
Kyle Huey [Sat, 15 Aug 2020 00:30:48 +0000 (17:30 -0700)]
Add a lint for an async block/closure that yields a type that is itself awaitable.
This catches bugs of the form
tokio::spawn(async move {
let f = some_async_thing();
f // Oh no I forgot to await f so that work will never complete.
});
Eduardo Broto [Fri, 28 Aug 2020 23:18:42 +0000 (01:18 +0200)]
or_fn_call: ignore nullary associated const fns
flip1995 [Fri, 28 Aug 2020 14:10:16 +0000 (16:10 +0200)]
bors [Fri, 28 Aug 2020 13:08:29 +0000 (13:08 +0000)]
Auto merge of #5970 - ebroto:changelog_beta_1_47, r=flip1995
Update changelog to beta 1.47
[Rendered](https://github.com/ebroto/rust-clippy/blob/changelog_beta_1_47/CHANGELOG.md)
changelog: none
bors [Fri, 28 Aug 2020 11:54:07 +0000 (11:54 +0000)]
Auto merge of #5774 - ThibsG:FixNewRetNoSelf, r=ebroto
Fix FP in `new_ret_no_self`: trigger in trait def instead of impl block
Lint in trait def instead of impl block.
Fixes: #5435
changelog: none
Thibaud [Fri, 28 Aug 2020 07:33:05 +0000 (09:33 +0200)]
Update clippy_lints/src/methods/mod.rs
Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
Thibaud [Fri, 28 Aug 2020 07:31:29 +0000 (09:31 +0200)]
Update clippy_lints/src/utils/mod.rs
Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
Thibaud [Fri, 28 Aug 2020 07:31:12 +0000 (09:31 +0200)]
Update clippy_lints/src/utils/mod.rs
Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
bors [Thu, 27 Aug 2020 23:26:52 +0000 (23:26 +0000)]
Auto merge of #5971 - giraffate:fix_fp_in_to_string_in_display, r=ebroto
Fix FP in `to_string_in_display`
Don't emit a lint when `.to_string()` on anything that is not `self`
Fix #5967
changelog: Fix FP in `to_string_in_display` when calling `.to_string()` on anything that is not `self`
ThibsG [Thu, 27 Aug 2020 16:24:59 +0000 (18:24 +0200)]
Merge logic of looking for `Self` type
ThibsG [Tue, 25 Aug 2020 07:16:08 +0000 (09:16 +0200)]
Remove expansion restriction + fix doc and tests naming
ThibsG [Tue, 7 Jul 2020 20:47:32 +0000 (22:47 +0200)]
Fix FP in `new_ret_no_self`: trigger in trait def instead of impl block
Takayuki Nakata [Thu, 27 Aug 2020 14:37:47 +0000 (23:37 +0900)]
Fix FP in `to_string_in_display`
Don't emit a lint when `.to_string()` on anything that is not `self`
Eduardo Broto [Thu, 27 Aug 2020 12:39:09 +0000 (14:39 +0200)]
Update changelog to beta 1.47
bors [Wed, 26 Aug 2020 23:38:34 +0000 (23:38 +0000)]
Auto merge of #5957 - xvschneider:AddUnwrapInsideResultLint, r=yaahc
Adding new lint to prevent usage of 'unwrap' inside functions that re…
### Change
Adding a new lint that will emit a warning when using "unwrap" or "expect" inside a function that returns result.
### Motivation
These functions promote recoverable errors to non-recoverable errors which may be undesirable in code bases which wish to avoid panics.
### Test plan
Running:
`TESTNAME=unwrap_in_result cargo uitest
`---
changelog: none
Jane Lusby [Wed, 26 Aug 2020 23:31:49 +0000 (16:31 -0700)]
Add new lint to prevent usage of unwrap in fns that return result
bors [Wed, 26 Aug 2020 22:52:47 +0000 (22:52 +0000)]
Auto merge of #5968 - rail-rain:fix_use_snippet_with_applicability, r=flip1995
Fix the wrong use of `snippet_with_applicability`
For the context, please see https://github.com/rust-lang/rust-clippy/issues/5822#issuecomment-
680749728 and https://github.com/rust-lang/rust-clippy/issues/5822#issuecomment-
680783381 .
---
changelog: none
rail [Wed, 26 Aug 2020 22:23:21 +0000 (10:23 +1200)]
Fix the wrong use of `snippet_with_applicability`
This includes a workaround of the issue #5822,
the cause of this little mistake.
bors [Wed, 26 Aug 2020 18:15:42 +0000 (18:15 +0000)]
Auto merge of #5966 - 1c3t3a:1c3t3a-dev-5819-fix, r=Manishearth
Corrects the float_equality_without_abs lint
Fixes an issue in the `float_equality_without_abs` lint. The lint suggestion was configured in a way that it lints the whole error and not just the subtraction part. In the current configuration the lint would suggest to change the expression in a wrong way, e.g.
```rust
let _ = (a - b) < f32::EPSILON; // before
let _ = (a - b).abs(); // after
```
This was dicovered by @flip1995. (See discussion of PR #5952).
Also the suggestion is now formatted via `utils::sugg`.
changelog: none
Bastian [Wed, 26 Aug 2020 14:39:30 +0000 (16:39 +0200)]
Changed the location of the suggestion as well as the way the suggestion is assembled
bors [Wed, 26 Aug 2020 12:01:32 +0000 (12:01 +0000)]
Auto merge of #5946 - mikerite:fix-5729, r=flip1995
Fix `let_and_return` bad suggestion
Add a cast to the suggestion when the return expression has adjustments.
These adjustments are lost when the suggestion is applied.
This is similar to the problem in issue #4437.
Closes #5729
changelog: Fix `let_and_return` bad suggestion
bors [Wed, 26 Aug 2020 11:06:37 +0000 (11:06 +0000)]
Auto merge of #5949 - rail-rain:fix_fp_borrow_interior_mutable_const, r=oli-obk
Fix fp in `borrow_interior_mutable_const`
fixes #5796
changelog: fix false positive in `borrow_interior_mutable_const` when referencing a field behind a pointer.
bors [Wed, 26 Aug 2020 07:53:07 +0000 (07:53 +0000)]
Auto merge of #5964 - matsujika:matsujika-patch-1, r=ebroto
Fix typo
changelog: none
Hirochika Matsumoto [Wed, 26 Aug 2020 07:03:35 +0000 (16:03 +0900)]
Fix typo
bors [Tue, 25 Aug 2020 21:48:19 +0000 (21:48 +0000)]
Auto merge of #5951 - ThibsG:FixMacroCloneOnRefPtr2076, r=ebroto
Fix incorrect suggestion when `clone_on_ref_ptr` is triggered in macros
In the lint `clone_on_ref_ptr`, if the `span` is in a macro, don't expand it for suggestion.
Fixes: #2076
changelog: none
r? @ebroto
Thibaud [Tue, 25 Aug 2020 20:20:35 +0000 (22:20 +0200)]
Update clippy_lints/src/methods/mod.rs
Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
bors [Tue, 25 Aug 2020 19:30:05 +0000 (19:30 +0000)]
Auto merge of #5961 - scottmcm:master, r=Manishearth
Re-enable len_zero for ranges now that `is_empty` is stable on them
Fixes #5956
Completed stabilization PR: https://github.com/rust-lang/rust/pull/75132
changelog: len_zero: re-enable linting ranges now that range_is_empty is stable
Scott McMurray [Tue, 25 Aug 2020 19:05:02 +0000 (12:05 -0700)]
Re-enable len_zero for ranges now that `is_empty` is stable on them
bors [Tue, 25 Aug 2020 17:15:51 +0000 (17:15 +0000)]
Auto merge of #5958 - mikerite:fix-fmt-
20200825 , r=flip1995
Various fmt test improvements
Various fmt test improvements.
changelog: none
bors [Tue, 25 Aug 2020 16:54:48 +0000 (16:54 +0000)]
Auto merge of #5952 - 1c3t3a:1c3t3a-dev-5819, r=Manishearth
Added a lint which corrects expressions like (a - b) < f32::EPSILON, according to #5819
Fixes #5819
changelog: none
bors [Tue, 25 Aug 2020 16:33:17 +0000 (16:33 +0000)]
Auto merge of #5947 - ebroto:rustup_doc_improvements, r=flip1995
Improve documentation related to the sync process
[Rendered](https://github.com/ebroto/rust-clippy/blob/rustup_doc_improvements/CONTRIBUTING.md)
r? @flip1995
changelog: none
bors [Tue, 25 Aug 2020 16:11:17 +0000 (16:11 +0000)]
Auto merge of #5960 - flip1995:rustup, r=flip1995
Rustup
r? @ghost
changelog: none
Philipp Krones [Tue, 25 Aug 2020 16:01:08 +0000 (18:01 +0200)]
Fix typo
Bastian [Tue, 25 Aug 2020 11:41:39 +0000 (13:41 +0200)]
Added F32::EPSILON and F64::EPSILON to paths.rs
Michael Wright [Tue, 25 Aug 2020 03:53:28 +0000 (05:53 +0200)]
Fix intermittent build error
The fmt test will cause clippy dev to be compiled and run. The clippy dev
dependencies are currently stored at `target/debug/deps` when this happens.
This location sometimes causes conflicts with ui tests which result in the
build error "thread 'compile_test' panicked at 'Found multiple rlibs for crate
`regex` ...".
This commit forces the clippy_dev dependencies to be stored under
`clippy_dev/target/` which seems to resolve this problem.
Michael Wright [Tue, 25 Aug 2020 03:53:28 +0000 (05:53 +0200)]
Simplify fmt test by using the clippy dev alias
Michael Wright [Tue, 25 Aug 2020 03:53:28 +0000 (05:53 +0200)]
Fix incorrect comment
bors [Tue, 25 Aug 2020 03:29:59 +0000 (03:29 +0000)]
Auto merge of #5920 - giraffate:fix_fp_for_redundant_closure_call, r=mikerite
Fix FP for `redundant_closure_call`
Fix #5916
changelog: Fix FP for `redundant_closure_call` when called in function body
Scott McMurray [Mon, 24 Aug 2020 21:28:01 +0000 (14:28 -0700)]
Unbreak the clippy test
bors [Mon, 24 Aug 2020 18:08:39 +0000 (18:08 +0000)]
Auto merge of #5935 - matthiaskrgr:unstable_sort_ty_name, r=flip1995
stable_sort_primitive: print the type that is being sorted in the lint message
changelog: stable_sort_primitive: print the type that is being sorted in the lint message
Matthias Krüger [Fri, 21 Aug 2020 00:03:57 +0000 (02:03 +0200)]
stable_sort_primitive: print the type that is being sorted in the lint message
Bastian [Mon, 24 Aug 2020 14:31:51 +0000 (16:31 +0200)]
Added a lint which corrects expressions like (a - b) < f32::EPSILON
ThibsG [Mon, 24 Aug 2020 12:01:27 +0000 (14:01 +0200)]
Fix incorrect suggestion when `clone_on_ref_ptr` is triggered in macros
rail-rain [Mon, 24 Aug 2020 07:08:38 +0000 (19:08 +1200)]
typo
Co-authored-by: Thibaud <ThibsG@users.noreply.github.com>
Takayuki Nakata [Mon, 24 Aug 2020 01:11:53 +0000 (10:11 +0900)]
Avoid period in lint message according to convention
Takayuki Nakata [Tue, 18 Aug 2020 14:00:21 +0000 (23:00 +0900)]
Fix FP for `redundant_closure_call`
Visit the nested things like function body when checking closure call.
Eduardo Broto [Sun, 23 Aug 2020 20:20:55 +0000 (22:20 +0200)]
Apply suggestions from PR review
bors [Sun, 23 Aug 2020 14:13:58 +0000 (14:13 +0000)]
Auto merge of #5948 - ebroto:5944_repeat_ice, r=Manishearth
Fix ICE in `repeat_once`
changelog: Fix ICE in [`repeat_once`]
Fixes #5944
bors [Sun, 23 Aug 2020 10:59:53 +0000 (10:59 +0000)]
Auto merge of #5930 - ebroto:dev_newlint_fix_lt, r=matthiaskrgr
Fix cargo dev new_lint for late lint passes
Since https://github.com/rust-lang/rust-clippy/commit/
30c046ede47ea45a772d2656b0365a4807263bca , `LateLintPass` has only one lifetime parameter.
I'm not sure how to easily test this, I think adding this kind of tests would be probably part of #5394
changelog: none
rail [Sun, 23 Aug 2020 10:16:24 +0000 (22:16 +1200)]
Fix fp in `borrow_interior_mutable_const`
Fix false positive when referencing a field behind a pointer.
Eduardo Broto [Sun, 23 Aug 2020 10:05:34 +0000 (12:05 +0200)]
Fix ICE in `repeat_once` lint
Eduardo Broto [Sun, 23 Aug 2020 09:29:06 +0000 (11:29 +0200)]
Improve documentation related to the sync process
Eduardo Broto [Thu, 20 Aug 2020 21:47:04 +0000 (23:47 +0200)]
Fix cargo dev new_lint for late lint passes
Michael Wright [Sun, 23 Aug 2020 05:50:59 +0000 (07:50 +0200)]
Fix `let_and_return` bad suggestion
Add a cast to the suggestion when the return expression has adjustments.
These adjustments are lost when the suggestion is applied.
This is similar to the problem in issue #4437.
Closes #5729
bors [Sat, 22 Aug 2020 18:30:39 +0000 (18:30 +0000)]
Auto merge of #5941 - ThibsG:InlineInCopyPassByRef, r=yaahc
Don't lint if it has always inline attribute
Don't trigger the lint `trivially_copy_pass_by_ref` if it has `#[inline(always)]` attribute.
Note: I am not particularly familiar with `inline` impacts, so I implemented this the way that if only `#[inline]` attribute is here (without `always`), the lint will still trigger. Also, it will still trigger if it has `#[inline(never)]`.
Just tell me if it sounds too much conservative.
Fixes: #5876
changelog: none
bors [Sat, 22 Aug 2020 12:50:22 +0000 (12:50 +0000)]
Auto merge of #5929 - stchris:issues/5917, r=ebroto
Widen understanding of prelude import
Prelude imports are exempt from wildcard import warnings. Until now only
imports of the form
```
use ...::prelude::*;
```
were considered. This change makes it so that the segment `prelude` can
show up anywhere, for instance:
```
use ...::prelude::v1::*;
```
Fixes #5917
changelog: Allow `prelude` to appear in any segment of the import path in [`wildcard_imports`]
Christian Stefanescu [Fri, 21 Aug 2020 12:03:42 +0000 (14:03 +0200)]
Use more elegant way to check for prelude string
Christian Stefanescu [Thu, 20 Aug 2020 20:54:46 +0000 (22:54 +0200)]
Run sh tests/ui/update-all-references.sh
Christian Stefanescu [Thu, 20 Aug 2020 20:49:39 +0000 (22:49 +0200)]
Widen understanding of prelude import
Prelude imports are exempt from wildcard import warnings. Until now only
imports of the form
```
use ...::prelude::*;
```
were considered. This change makes it so that the segment `prelude` can
show up anywhere, for instance:
```
use ...::prelude::v1::*;
```
Fixes #5917
ThibsG [Sat, 22 Aug 2020 08:35:18 +0000 (10:35 +0200)]
Don't lint if it has always inline attribute
bors [Sat, 22 Aug 2020 06:19:42 +0000 (06:19 +0000)]
Auto merge of #5934 - ThibsG:WrongSelfTestCase4037, r=ebroto
Add async test case for FP in `wrong_self_convention` lint
Closes: #4037
changelog: none
r? @ebroto
ThibsG [Fri, 21 Aug 2020 06:18:05 +0000 (08:18 +0200)]
Add async test case for `wrong_self_convention` lint
bors [Sat, 22 Aug 2020 04:51:38 +0000 (04:51 +0000)]
Auto merge of #5926 - giraffate:improve_lint_message_in_to_string_in_display, r=yaahc
Improve lint message in `to_string_in_display`
This is a follow-up of https://github.com/rust-lang/rust-clippy/pull/5831.
changelog: none
bors [Fri, 21 Aug 2020 23:43:20 +0000 (23:43 +0000)]
Auto merge of #5933 - mikerite:fix-5927, r=matthiaskrgr
Fix false negative in `option_as_ref_deref`
Closes #5927
changelog: Fix false negative in `option_as_ref_deref`
bors [Fri, 21 Aug 2020 23:10:59 +0000 (23:10 +0000)]
Auto merge of #5938 - ebroto:sync-from-rust, r=ebroto
Rustup
r? @ghost
changelog: none
Eduardo Broto [Fri, 21 Aug 2020 22:59:42 +0000 (00:59 +0200)]
run cargo dev fmt
Eduardo Broto [Fri, 21 Aug 2020 22:53:03 +0000 (00:53 +0200)]
Merge remote-tracking branch 'upstream/master' into sync-from-rust
Michael Wright [Fri, 21 Aug 2020 05:23:04 +0000 (07:23 +0200)]
Fix false negative in `option_as_ref_deref`
bors [Thu, 20 Aug 2020 22:09:27 +0000 (22:09 +0000)]
Auto merge of #5928 - mikerite:fix-5924, r=ebroto
Fix false positive in `PRECEDENCE` lint
Extend the lint to handle chains of methods combined with unary negation.
Closes #5924
changelog: Fix false negative in `PRECEDENCE` lint
bors [Thu, 20 Aug 2020 10:04:46 +0000 (10:04 +0000)]
Auto merge of #5919 - ebroto:5747_from_bits_in_const, r=matthiaskrgr
transmute: avoid suggesting from/to bits in const
changelog: Avoid suggesting from/to bits in const contexts in [`transmute_int_to_float`]
Fixes #5747
Aaron Hill [Mon, 27 Jul 2020 22:02:29 +0000 (18:02 -0400)]
Capture tokens for Pat used in macro_rules! argument
This extends PR #73293 to handle patterns (Pat). Unlike expressions,
patterns do not support custom attributes, so we only need to capture
tokens during macro_rules! argument parsing.
Michael Wright [Thu, 20 Aug 2020 04:34:48 +0000 (06:34 +0200)]
Fix false positive in `PRECEDENCE` lint
Extend the lint to handle chains of methods combined with unary negation.
Closes #5924
Takayuki Nakata [Wed, 19 Aug 2020 13:31:34 +0000 (22:31 +0900)]
Improve lint message in `to_string_in_display`
Eduardo Broto [Tue, 18 Aug 2020 20:19:30 +0000 (22:19 +0200)]
no from/to bits in const: add tests cases for f64
Eduardo Broto [Mon, 17 Aug 2020 23:00:11 +0000 (01:00 +0200)]
transmute: avoid suggesting from/to bits in const
bors [Tue, 18 Aug 2020 17:58:40 +0000 (17:58 +0000)]
Auto merge of #5922 - flip1995:rustup, r=flip1995
Rustup
r? @ghost
changelog: none
flip1995 [Tue, 18 Aug 2020 17:10:52 +0000 (19:10 +0200)]
Merge remote-tracking branch 'upstream/master' into rustup
bors [Mon, 17 Aug 2020 23:16:08 +0000 (23:16 +0000)]
Auto merge of #75120 - JulianKnodt:rm_reps, r=oli-obk
rust_ast::ast => rustc_ast
Rework of #71199 which is a rework #70621
Still working on this but just made the PR to track progress
r? @Dylan-DPC
Ujjwal Sharma [Mon, 27 Apr 2020 17:56:11 +0000 (23:26 +0530)]
rust_ast::ast => rustc_ast