]>
git.lizzy.rs Git - rust.git/log
xiongmao86 [Sat, 4 Jan 2020 02:18:58 +0000 (10:18 +0800)]
format codebase.
xiongmao86 [Fri, 3 Jan 2020 06:59:14 +0000 (14:59 +0800)]
Add lint logic.
xiongmao86 [Thu, 2 Jan 2020 05:12:23 +0000 (13:12 +0800)]
Declare lint.
xiongmao86 [Thu, 2 Jan 2020 03:37:32 +0000 (11:37 +0800)]
Add test.
bors [Sat, 11 Jan 2020 20:32:51 +0000 (20:32 +0000)]
Auto merge of #5040 - JohnTitor:rustup-0111, r=flip1995
Some rustups
changelog: none
Yuki Okushi [Sat, 11 Jan 2020 20:20:18 +0000 (05:20 +0900)]
Remove references
Yuki Okushi [Sat, 11 Jan 2020 18:41:54 +0000 (03:41 +0900)]
Rustup to rust-lang/rust#67000
Yuki Okushi [Sat, 11 Jan 2020 18:05:47 +0000 (03:05 +0900)]
Comment out half-open patterns' tests
Yuki Okushi [Sat, 11 Jan 2020 14:21:09 +0000 (23:21 +0900)]
Apply review comments
Yuki Okushi [Sat, 11 Jan 2020 11:37:08 +0000 (20:37 +0900)]
Rustup to rust-lang/rust#67806
Yuki Okushi [Sat, 11 Jan 2020 10:39:43 +0000 (19:39 +0900)]
Apply review comments
Yuki Okushi [Sat, 11 Jan 2020 00:06:09 +0000 (09:06 +0900)]
Rustup to rust-lang/rust#68101
Yuki Okushi [Sat, 11 Jan 2020 00:05:51 +0000 (09:05 +0900)]
Rustup to rust-lang/rust#67258
bors [Thu, 9 Jan 2020 21:24:34 +0000 (21:24 +0000)]
Auto merge of #5031 - JohnTitor:editorconfig, r=phansch
Prefer 2 spaces as indent size over 4 on yaml
We use 2 spaces as an indent on YAML like `.travis.yml` now but `.editorconfig` tells my editor that indent size is 4, not 2. It makes my editor confused.
changelog: none
bors [Thu, 9 Jan 2020 20:54:18 +0000 (20:54 +0000)]
Auto merge of #5030 - JohnTitor:split-missing-doc, r=phansch
Split up `missing-doc` ui test
Part of #2038
changelog: none
Yuki Okushi [Thu, 9 Jan 2020 00:04:53 +0000 (09:04 +0900)]
Split up `missing-doc` ui test
Yuki Okushi [Thu, 9 Jan 2020 08:49:24 +0000 (17:49 +0900)]
Prefer 2 spaces as indent size over 4 on yaml
bors [Thu, 9 Jan 2020 13:51:00 +0000 (13:51 +0000)]
Auto merge of #4960 - ThibsG:patterns_with_wildcard_#4640, r=flip1995
New lint: pats_with_wild_match_arm
Wildcard use with other pattern in same match arm.
The wildcard covers other(s) pattern(s) as it will match anyway.
changelog: add new lint when multiple patterns (including wildcard) are used in a match arm.
Fixes #4640.
bors [Thu, 9 Jan 2020 12:37:54 +0000 (12:37 +0000)]
Auto merge of #5025 - JohnTitor:rustup-0109, r=flip1995
Some rustups
changelog: none
Yuki Okushi [Thu, 9 Jan 2020 07:14:19 +0000 (16:14 +0900)]
Rustup to rust-lang/rust#68024
Yuki Okushi [Thu, 9 Jan 2020 07:13:22 +0000 (16:13 +0900)]
Rustup to rust-lang/rust#67979
Yuki Okushi [Thu, 9 Jan 2020 00:22:16 +0000 (09:22 +0900)]
Rustup to rust-lang/rust#67781
bors [Wed, 8 Jan 2020 20:28:19 +0000 (20:28 +0000)]
Auto merge of #5022 - flip1995:useless_attr, r=phansch
Fix useless_attribute suggestion
Fixes #5021
changelog: Fix [`useless_attribute`] suggestion, which tripped rustfix
flip1995 [Wed, 8 Jan 2020 16:31:27 +0000 (17:31 +0100)]
Add regression test for useless_attribute lint
flip1995 [Wed, 8 Jan 2020 16:31:06 +0000 (17:31 +0100)]
Fix useless attribute suggestion
bors [Wed, 8 Jan 2020 12:09:45 +0000 (12:09 +0000)]
Auto merge of #5017 - sinkuu:mir_no_opt_fallout, r=flip1995
Fix redundant_clone lint not working with PathBuf and OsString
https://github.com/rust-lang/rust-clippy/pull/4825 diabled MIR optimization in clippy, including `rustc_mir::transform::InstCombine` which reduces `&(*x)` to `x`. This PR tries to unwrap `&*` when looking into `mir::Rvalue`s.
Fixes #5014.
---
changelog: fixed `redundant_clone` lint not working with `PathBuf` and `OsString`
bors [Wed, 8 Jan 2020 08:42:46 +0000 (08:42 +0000)]
Auto merge of #5015 - krishna-veerareddy:change-float-to-int-transmute-category, r=flip1995
Move `transmute_float_to_int` lint to `complexity`
`transmute_float_to_int` lint was accidentally added to nursery so moving it to the complexity group.
changelog: Move `transmute_float_to_int` out of nursery
bors [Wed, 8 Jan 2020 08:14:31 +0000 (08:14 +0000)]
Auto merge of #5019 - JohnTitor:follow-up-normalize, r=phansch
Normalize lint messages in cast_precision_loss
Follow-up of #5000
changelog: none
Yuki Okushi [Tue, 7 Jan 2020 21:08:49 +0000 (06:08 +0900)]
Normalize lint messages in cast_precision_loss
bors [Wed, 8 Jan 2020 06:56:57 +0000 (06:56 +0000)]
Auto merge of #5018 - JohnTitor:rustup-0108, r=phansch
Rustup to rust-lang/rust#67970
changelog: none
Yuki Okushi [Wed, 8 Jan 2020 06:42:54 +0000 (15:42 +0900)]
Rustup to rust-lang/rust#67970
Shotaro Yamada [Wed, 8 Jan 2020 04:59:58 +0000 (13:59 +0900)]
Fix `redundant_clone`
Krishna Sai Veera Reddy [Tue, 7 Jan 2020 23:53:19 +0000 (15:53 -0800)]
Move `transmute_float_to_int` lint to `complexity`
`transmute_float_to_int` lint was accidentally added to nursery
so moving it to the complexity group.
ThibsG [Tue, 7 Jan 2020 17:13:31 +0000 (18:13 +0100)]
Span help without suggestion
ThibsG [Sun, 5 Jan 2020 14:05:16 +0000 (15:05 +0100)]
Change lint name to WILDCARD_IN_OR_PATTERNS
ThibsG [Thu, 2 Jan 2020 19:00:27 +0000 (20:00 +0100)]
Handle case for non-exhaustive enums
ThibsG [Fri, 27 Dec 2019 04:42:28 +0000 (05:42 +0100)]
Move to complexity and adapt test
- test wildcard_enum_match_arm has been impacted by this new lint
ThibsG [Fri, 27 Dec 2019 01:03:16 +0000 (02:03 +0100)]
Change group and use only func call
ThibsG [Fri, 27 Dec 2019 00:56:09 +0000 (01:56 +0100)]
Remove useless parameters in func call
ThibsG [Tue, 24 Dec 2019 15:42:09 +0000 (16:42 +0100)]
New lint: pats_with_wild_match_arm
- Wildcard use with other pattern in same match arm
bors [Tue, 7 Jan 2020 11:52:23 +0000 (11:52 +0000)]
Auto merge of #5000 - JohnTitor:backticks, r=flip1995
Normalize lint messages
On rustc diagnostics, we prefer to use backticks over `'`, `"`, or something else. I think we should follow their manner here.
In first commit, normalizes lint messages with backticks.
In second commit, updates all stderrs.
In third commit, updates descriptions on lintlist.
changelog: none
Yuki Okushi [Tue, 7 Jan 2020 10:56:21 +0000 (19:56 +0900)]
Bless 32bit test
Yuki Okushi [Mon, 6 Jan 2020 15:44:52 +0000 (00:44 +0900)]
Apply suggestion from code review
Yuki Okushi [Mon, 6 Jan 2020 07:41:15 +0000 (16:41 +0900)]
Update lintlist
Yuki Okushi [Mon, 6 Jan 2020 06:36:33 +0000 (15:36 +0900)]
Update stderrs
Yuki Okushi [Mon, 6 Jan 2020 06:30:43 +0000 (15:30 +0900)]
Normalize lint messages
bors [Tue, 7 Jan 2020 08:45:14 +0000 (08:45 +0000)]
Auto merge of #5011 - JohnTitor:split-collapsible-if, r=flip1995
Split up `collapsible_if` ui test
Part of #2038
changelog: none
bors [Tue, 7 Jan 2020 07:46:00 +0000 (07:46 +0000)]
Auto merge of #5010 - lzutao:recurse-remove_blocks, r=phansch
Make utils::remove_blocks non-recursive
changelog: none
bors [Tue, 7 Jan 2020 07:10:58 +0000 (07:10 +0000)]
Auto merge of #5002 - lzutao:fmt-fallout, r=flip1995
build: Use rustfmt from lastest nightly that contains it
changelog: none
bors [Tue, 7 Jan 2020 06:32:15 +0000 (06:32 +0000)]
Auto merge of #4999 - krishna-veerareddy:issue-4679-atomic-ordering, r=phansch
Add lint to detect usage of invalid atomic ordering
Detect usage of invalid atomic ordering modes such as `Ordering::{Release, AcqRel}` in atomic loads and `Ordering::{Acquire, AcqRel}` in atomic stores.
Fixes #4679
changelog: Add lint [`invalid_atomic_ordering`]
Yuki Okushi [Tue, 7 Jan 2020 06:06:23 +0000 (15:06 +0900)]
Split up `collapsible_if` ui test
bors [Tue, 7 Jan 2020 06:03:28 +0000 (06:03 +0000)]
Auto merge of #5009 - lzutao:travis-windows-msvc, r=phansch
Travis: Use windows-msvc target for Windows build
changelog: none
closes #5005
Lzu Tao [Tue, 7 Jan 2020 03:50:35 +0000 (10:50 +0700)]
Make utils::remove_blocks non-recursive
Lzu Tao [Tue, 7 Jan 2020 02:52:10 +0000 (09:52 +0700)]
Travis: Use windows-msvc target for Windows build
Krishna Sai Veera Reddy [Tue, 7 Jan 2020 01:33:28 +0000 (17:33 -0800)]
Prevent doc-tests from running and fix lint description
Krishna Sai Veera Reddy [Mon, 6 Jan 2020 00:52:15 +0000 (16:52 -0800)]
Split test cases into separate files
Krishna Sai Veera Reddy [Mon, 6 Jan 2020 00:16:27 +0000 (16:16 -0800)]
Add lint to detect usage of invalid atomic ordering
Detect usage of invalid atomic ordering modes such as
`Ordering::{Release, AcqRel}` in atomic loads and
`Ordering::{Acquire, AcqRel}` in atomic stores.
bors [Mon, 6 Jan 2020 22:48:22 +0000 (22:48 +0000)]
Auto merge of #5008 - JohnTitor:let-on-macros, r=flip1995
Do not trigger `let_and_return` lint on macros
Fixes #4997
changelog: Fix false positive in `let_and_return`
Yuki Okushi [Mon, 6 Jan 2020 20:26:20 +0000 (05:26 +0900)]
Do not trigger `let_and_return` lint on macros
Lzu Tao [Mon, 6 Jan 2020 12:33:27 +0000 (19:33 +0700)]
build: Use rustfmt from lastest nightly that contains it
bors [Mon, 6 Jan 2020 18:15:48 +0000 (18:15 +0000)]
Auto merge of #5003 - JohnTitor:rustup, r=flip1995
Rustup to rust-lang/rust#67886
changelog: none
Yuki Okushi [Mon, 6 Jan 2020 17:04:10 +0000 (02:04 +0900)]
Fix test again
Yuki Okushi [Mon, 6 Jan 2020 16:54:51 +0000 (01:54 +0900)]
Pick up lost property
Yuki Okushi [Mon, 6 Jan 2020 16:39:50 +0000 (01:39 +0900)]
Rustup to rust-lang/rust#67886
bors [Sun, 5 Jan 2020 19:32:20 +0000 (19:32 +0000)]
Auto merge of #4998 - JohnTitor:revive-rls, r=llogiq
Re-enable rls integration test
It seems rls integration test passes correctly: https://travis-ci.com/rust-lang/rust-clippy/builds/
143133541
changelog: none
Yuki Okushi [Sun, 5 Jan 2020 18:16:19 +0000 (03:16 +0900)]
Fix space size
Yuki Okushi [Sun, 5 Jan 2020 16:22:01 +0000 (01:22 +0900)]
Re-enable rls integration test
bors [Sun, 5 Jan 2020 08:41:37 +0000 (08:41 +0000)]
Auto merge of #4996 - JohnTitor:rustup, r=matthiaskrgr
Rustup to rust-lang/rust#67803 and rust-lang/rust#67137
changelog: none
Yuki Okushi [Sun, 5 Jan 2020 06:43:41 +0000 (15:43 +0900)]
Rustup to rust-lang/rust#67137
Yuki Okushi [Sun, 5 Jan 2020 06:39:03 +0000 (15:39 +0900)]
Rustup to rust-lang/rust#67803
bors [Sat, 4 Jan 2020 20:50:41 +0000 (20:50 +0000)]
Auto merge of #4993 - rust-lang:doc-unsafe-macro-check, r=flip1995
External macro check for missing_*_doc
This fixes #4949
changelog: none
Andre Bogus [Sat, 4 Jan 2020 19:19:14 +0000 (20:19 +0100)]
External macro check for missing_*_doc
bors [Sat, 4 Jan 2020 18:32:33 +0000 (18:32 +0000)]
Auto merge of #4966 - bradsherman:iter-nth-zero, r=flip1995
New Lint: Iter nth zero
Check for the use of `iter.nth(0)` and encourage `iter.next()` instead as it is more readable
changelog: add new lint when `iter.nth(0)` is used
Fixes #4957
Brad Sherman [Sat, 28 Dec 2019 22:37:23 +0000 (15:37 -0700)]
Add lint for iter.nth(0)
- Encourage iter.next() rather than iter.nth(0), which is less readable
Brad Sherman [Sat, 28 Dec 2019 22:31:41 +0000 (15:31 -0700)]
Fix existing iter-nth-zero violations
bors [Sat, 4 Jan 2020 12:26:02 +0000 (12:26 +0000)]
Auto merge of #4992 - phansch:rustup_foobar, r=matthiaskrgr
Rustup to https://github.com/rust-lang/rust/pull/67853
Specifically caused by https://github.com/rust-lang/rust/pull/67786
changelog: none
Philipp Hansch [Sat, 4 Jan 2020 10:00:00 +0000 (11:00 +0100)]
Rustup to https://github.com/rust-lang/rust/pull/67853
Specifically caused by https://github.com/rust-lang/rust/pull/67786
bors [Sat, 4 Jan 2020 08:09:43 +0000 (08:09 +0000)]
Auto merge of #4881 - krishna-veerareddy:issue-4871-use-mem-take, r=flip1995
Use `mem::take` instead of `mem::replace` when applicable
`std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`.
Fixes issue #4871
changelog: Added lint for [`mem_replace_with_default`]
bors [Sat, 4 Jan 2020 07:44:04 +0000 (07:44 +0000)]
Auto merge of #4990 - JohnTitor:remove-try, r=phansch
Remove use of `try!` from documentation
Makes documentation more modern and directer
changelog: none
Yuki Okushi [Sat, 4 Jan 2020 04:47:01 +0000 (13:47 +0900)]
Remove use of `try!` from documentation
bors [Fri, 3 Jan 2020 17:04:52 +0000 (17:04 +0000)]
Auto merge of #4989 - rust-lang:no-unmangled-must-use, r=flip1995
No #[no_mangle] must_use_candidate functions
This fixes #4984.
changelog: none
Andre Bogus [Fri, 3 Jan 2020 16:21:36 +0000 (17:21 +0100)]
No #[no_mangle] must_use_candidate functions
bors [Fri, 3 Jan 2020 08:48:05 +0000 (08:48 +0000)]
Auto merge of #4975 - JohnTitor:fix-4968, r=phansch
Fix ICE on `unsound_collection_transmute`
Fixes #4968
Check if `Ty`s are normalizable. It might show hidden false negative, I'm not sure.
Also, the regression tests are placed on two dirs, so move them to `/crashes`. I think it will be easier to find the right place.
changelog: Fix ICE on `unsound_collection_transmute`
Yuki Okushi [Fri, 3 Jan 2020 08:03:07 +0000 (17:03 +0900)]
Move `use_self_macro` into `crashes/auxiliary`
bors [Fri, 3 Jan 2020 05:59:19 +0000 (05:59 +0000)]
Auto merge of #4978 - mikerite:fix-4958, r=phansch
Fix bad `explicit_into_iter_loop` suggestion
Fixes #4958
changelog: Fix bad `explicit_into_iter_loop` suggestion
bors [Thu, 2 Jan 2020 11:37:19 +0000 (11:37 +0000)]
Auto merge of #4977 - krishna-veerareddy:issue-4969-replace-consts-fp, r=phansch
Prevent `replace_consts` lint within match patterns
Currently `replace_consts` lint applies within match patterns but the suggestion is incorrect as function calls are disallowed in them. To fix this we prevent the lint from firing within patterns.
Fixes #4969
changelog: Fix false positive in `replace_consts` lint
Krishna Veera Reddy [Thu, 2 Jan 2020 07:22:57 +0000 (23:22 -0800)]
Add `if let` test case
Yuki Okushi [Thu, 2 Jan 2020 02:48:06 +0000 (11:48 +0900)]
Move `is_normalizable` into utils
Yuki Okushi [Thu, 2 Jan 2020 00:32:55 +0000 (09:32 +0900)]
Add attribute
Michael Wright [Wed, 1 Jan 2020 05:09:09 +0000 (07:09 +0200)]
Fix bad `explicit_into_iter_loop` suggestion
Fixes #4958
Krishna Veera Reddy [Tue, 31 Dec 2019 18:33:15 +0000 (10:33 -0800)]
Prevent `replace_consts` lint within match patterns
Currently `replace_consts` lint applies within match patterns but
the suggestion is incorrect as function calls are disallowed in
them. To fix this we prevent the lint from firing within patterns.
Krishna Veera Reddy [Sun, 29 Dec 2019 05:52:08 +0000 (21:52 -0800)]
Indicate anonymous lifetimes for types
Krishna Veera Reddy [Tue, 24 Dec 2019 16:26:58 +0000 (08:26 -0800)]
Remove unnecessary import
Krishna Veera Reddy [Tue, 24 Dec 2019 15:59:35 +0000 (07:59 -0800)]
Lint within internal macros without a suggestion
Krishna Veera Reddy [Sun, 22 Dec 2019 19:05:19 +0000 (11:05 -0800)]
Destructure `mem:replace` arguments
Krishna Veera Reddy [Thu, 19 Dec 2019 06:15:55 +0000 (22:15 -0800)]
Move `mem_replace_with_default` out of nursery
Krishna Veera Reddy [Sun, 8 Dec 2019 19:46:21 +0000 (11:46 -0800)]
Prevent `mem_replace_with_default` lint within macros
Also added test cases for internal and external macros.
Krishna Veera Reddy [Sun, 8 Dec 2019 17:26:37 +0000 (09:26 -0800)]
Add test cases for replace with `Default::default()`
Krishna Veera Reddy [Sun, 8 Dec 2019 03:10:06 +0000 (19:10 -0800)]
Use `mem::take` instead of `mem::replace` when applicable
`std::mem::take` can be used to replace a value of type `T`
with `T::default()` instead of `std::mem::replace`.
bors [Tue, 31 Dec 2019 13:52:14 +0000 (13:52 +0000)]
Auto merge of #4976 - JohnTitor:integration, r=phansch
Update integration name
I noticed some `INTEGRATION` env vars point to previous org/repo names.
changelog: none