]>
git.lizzy.rs Git - rust.git/log
Matthias Krüger [Thu, 6 Sep 2018 10:55:04 +0000 (12:55 +0200)]
print_with_newline / write_with_newline: don't warn about string with several `\n`s in them.
Fixes #3126
Matthias Krüger [Thu, 6 Sep 2018 10:33:00 +0000 (12:33 +0200)]
rustfmt clippy_lints/src/write.rs
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 6 Sep 2018 07:26:11 +0000 (09:26 +0200)]
Merge pull request #3136 from mikerite/driver-rustc-arg-2
driver: Improve check for rustc arg
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 6 Sep 2018 07:24:26 +0000 (09:24 +0200)]
Merge pull request #2985 from phansch/riir_update_lints
update_lints rewrite: Add structure and --print-only
Philipp Hansch [Thu, 6 Sep 2018 06:19:09 +0000 (08:19 +0200)]
Pass by ref instead of value
Philipp Hansch [Wed, 5 Sep 2018 18:32:26 +0000 (20:32 +0200)]
More refactoring
Philipp Hansch [Thu, 6 Sep 2018 05:10:45 +0000 (07:10 +0200)]
Merge pull request #3133 from matthiaskrgr/link
remove "clippy::" lint prefix from lint name in doc url.
Michael Wright [Thu, 6 Sep 2018 05:01:56 +0000 (07:01 +0200)]
driver: Improve check for rustc arg
The rustc arg might not be exactly "rustc". It may be any path to a rustc
executable (especially if the RUSTC environment variable is set when
executing cargo). Rather check that it is a path with 'rustc' file stem.
Matthias Krüger [Wed, 5 Sep 2018 22:45:57 +0000 (00:45 +0200)]
remove "clippy::" lint prefix from lint name in doc url.
Fixes #3132
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 5 Sep 2018 14:22:03 +0000 (16:22 +0200)]
Merge pull request #3131 from JoshMcguigan/ptr_arg-2293
Fix #2293 - ptr_arg
Josh Mcguigan [Wed, 5 Sep 2018 12:59:07 +0000 (05:59 -0700)]
Added test case for ptr_arg
Philipp Hansch [Wed, 5 Sep 2018 11:35:57 +0000 (13:35 +0200)]
Remove duplicated .gitignore
Philipp Hansch [Wed, 5 Sep 2018 11:34:28 +0000 (13:34 +0200)]
Return impl Iterator instead of Vec<Lint>
This makes the API of `lib.rs` a bit more flexible.
Philipp Krones [Tue, 4 Sep 2018 19:13:30 +0000 (21:13 +0200)]
Merge pull request #3108 from daubaris/range-plus-one
range_plus_one suggestion should not remove braces fix
daubaris [Tue, 4 Sep 2018 15:56:48 +0000 (18:56 +0300)]
switched to ticks for chars
daubaris [Tue, 4 Sep 2018 15:52:18 +0000 (18:52 +0300)]
Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 4 Sep 2018 08:09:38 +0000 (10:09 +0200)]
Merge pull request #3125 from nrc/pub-conf
Make `Default` do what `default` used to do
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 4 Sep 2018 08:09:10 +0000 (10:09 +0200)]
Merge pull request #3124 from phansch/cleanup_old_min_version_stuff
Cleanup old min_version stuff
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 4 Sep 2018 08:07:11 +0000 (10:07 +0200)]
Merge pull request #3109 from shssoichiro/3034-needless-collect
Lint against needless uses of `collect()`
Josh Holmer [Sat, 1 Sep 2018 15:07:18 +0000 (11:07 -0400)]
Delete needless file
Josh Holmer [Tue, 4 Sep 2018 03:58:10 +0000 (23:58 -0400)]
More if_chain
Josh Holmer [Tue, 4 Sep 2018 03:50:24 +0000 (23:50 -0400)]
Rustup
Josh Holmer [Fri, 31 Aug 2018 22:26:04 +0000 (18:26 -0400)]
Apply applicability
Josh Holmer [Fri, 31 Aug 2018 22:14:33 +0000 (18:14 -0400)]
Majority of PR changes
Josh Holmer [Thu, 30 Aug 2018 03:01:24 +0000 (23:01 -0400)]
Lint against needless uses of `collect()`
Handles cases of `.collect().len()`, `.collect().is_empty()`, and
`.collect().contains()`. This lint is intended to be generic enough to
be added to at a later time with other similar patterns that could be
optimized.
Closes #3034
Nick Cameron [Mon, 3 Sep 2018 21:12:50 +0000 (09:12 +1200)]
Make `Default` do what `default` used to do
Philipp Hansch [Mon, 3 Sep 2018 20:27:35 +0000 (22:27 +0200)]
Cleanup old min_version stuff
This cleans up a few leftover things after
https://github.com/rust-lang-nursery/rust-clippy/pull/3018
Philipp Hansch [Sun, 2 Sep 2018 08:13:53 +0000 (10:13 +0200)]
Run clippy on clippy_dev, too
Philipp Hansch [Sun, 2 Sep 2018 07:45:13 +0000 (09:45 +0200)]
Refactor to use into_group_map from Itertools
Philipp Hansch [Thu, 30 Aug 2018 06:00:16 +0000 (08:00 +0200)]
s/direntry/dir_entry
Philipp Hansch [Thu, 30 Aug 2018 05:57:54 +0000 (07:57 +0200)]
Use insignificant whitespace mode for nice regex
Philipp Hansch [Thu, 30 Aug 2018 05:57:11 +0000 (07:57 +0200)]
cargo update in clippy_dev
Philipp Hansch [Tue, 17 Jul 2018 20:50:17 +0000 (22:50 +0200)]
update_lints rewrite: Add structure and --print-only
daubaris [Mon, 3 Sep 2018 20:01:28 +0000 (23:01 +0300)]
fixed known problems expression
daubaris [Mon, 3 Sep 2018 15:24:47 +0000 (18:24 +0300)]
Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one
daubaris [Mon, 3 Sep 2018 15:24:38 +0000 (18:24 +0300)]
backticks and testcase
Philipp Hansch [Mon, 3 Sep 2018 15:24:33 +0000 (17:24 +0200)]
Merge pull request #3092 from illicitonion/issue-2879
default_trait_access skips <F as Default>::default()
daubaris [Mon, 3 Sep 2018 14:21:13 +0000 (17:21 +0300)]
Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one
Manish Goregaokar [Mon, 3 Sep 2018 09:37:18 +0000 (09:37 +0000)]
Merge pull request #3120 from rust-lang-nursery/ci_integration
Update travis integration tests to tool_lints
Philipp Krones [Mon, 3 Sep 2018 08:55:43 +0000 (10:55 +0200)]
Merge pull request #3119 from joshtriplett/a-message-from-the-save-the-iters-foundation
iter conservation efforts: save the endangered .iter() and .into_iter()
Philipp Krones [Mon, 3 Sep 2018 08:52:42 +0000 (10:52 +0200)]
Update travis integration tests to tool_lints
`clippy_pedantic` -> `clippy::pedantic`
`clippy_nursery` -> `clippy::nursery`
Josh Triplett [Mon, 3 Sep 2018 07:19:59 +0000 (00:19 -0700)]
iter conservation efforts: save the endangered .iter() and .into_iter()
Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so
that people can turn them on if they want to enforce that style; avoid
presenting them as *the* idiomatic Rust style, rather than just *a* style.
Philipp Hansch [Mon, 3 Sep 2018 06:35:24 +0000 (07:35 +0100)]
Merge pull request #3116 from phansch/fix_warning
Fix clippy -> clippy::all warning in CI
Philipp Hansch [Mon, 3 Sep 2018 06:03:05 +0000 (08:03 +0200)]
Fix clippy -> clippy::all warning in CI
Manish Goregaokar [Mon, 3 Sep 2018 05:48:46 +0000 (05:48 +0000)]
Merge pull request #3115 from rust-lang-nursery/rm-token
Remove dependence of ci on github token
Manish Goregaokar [Mon, 3 Sep 2018 03:42:06 +0000 (09:12 +0530)]
Remove dependence of ci on github token
Manish Goregaokar [Mon, 3 Sep 2018 02:44:45 +0000 (08:14 +0530)]
Merge pull request #2941 from rust-lang-nursery/prs
Run travis on rustc-master instead of nightly
Manish Goregaokar [Mon, 3 Sep 2018 02:06:58 +0000 (07:36 +0530)]
Merge pull request #3114 from nrc/pub-conf
Make `Conf::default` available
Nick Cameron [Mon, 3 Sep 2018 01:57:50 +0000 (13:57 +1200)]
Make `Conf::default` available
Fixes RLS
Daniel Wagner-Hall [Sun, 2 Sep 2018 23:01:57 +0000 (00:01 +0100)]
Merge branch 'master' into issue-2879
Daniel Wagner-Hall [Sun, 2 Sep 2018 22:42:07 +0000 (23:42 +0100)]
Simplify
Daniel Wagner-Hall [Sun, 2 Sep 2018 22:37:28 +0000 (23:37 +0100)]
Use types rather than strings
Philipp Hansch [Sun, 2 Sep 2018 09:31:39 +0000 (11:31 +0200)]
Trigger rebuild for AppVeyor (and fix grammar)
Philipp Hansch [Sun, 2 Sep 2018 09:05:49 +0000 (11:05 +0200)]
Merge remote-tracking branch 'upstream/master' into prs
Manish Goregaokar [Sun, 2 Sep 2018 07:59:06 +0000 (13:29 +0530)]
Merge pull request #3113 from mikerite/fix-3112
Fix #3112
Michael Wright [Sun, 2 Sep 2018 07:38:25 +0000 (09:38 +0200)]
Fix #3112
daubaris [Sat, 1 Sep 2018 06:37:42 +0000 (09:37 +0300)]
resolved conflicts
Manish Goregaokar [Sat, 1 Sep 2018 05:52:23 +0000 (11:22 +0530)]
Merge pull request #2977 from flip1995/tool_lints
Implement tool_lints
Manish Goregaokar [Fri, 31 Aug 2018 07:38:27 +0000 (00:38 -0700)]
Fix ptr offset tests
Manish Goregaokar [Fri, 31 Aug 2018 07:34:48 +0000 (00:34 -0700)]
declare_lint -> declare_tool_lint
Oliver Schneider [Fri, 31 Aug 2018 07:05:39 +0000 (09:05 +0200)]
Merge pull request #3081 from mikerite/fix-3078
Fix #3078
Michael Wright [Fri, 31 Aug 2018 04:17:11 +0000 (06:17 +0200)]
Merge branch 'master' into fix-3078
Michael Wright [Fri, 31 Aug 2018 04:10:30 +0000 (06:10 +0200)]
Revert "fix-3078: verify test case"
This reverts commit
6256ad05bac1f708298f827fdfa7b54042961294 .
daubaris [Thu, 30 Aug 2018 17:06:13 +0000 (20:06 +0300)]
range_plus_one suggestion should not remove braces fix
Oliver Schneider [Thu, 30 Aug 2018 08:16:36 +0000 (10:16 +0200)]
Merge pull request #2962 from phansch/further_automate_pre_publish
Further automate pre_publish.sh
Philipp Hansch [Thu, 30 Aug 2018 05:33:53 +0000 (07:33 +0200)]
Remove git diffing part
Because we no bump versions
Philipp Hansch [Wed, 29 Aug 2018 19:09:38 +0000 (20:09 +0100)]
Merge pull request #3076 from mbrubeck/patch-1
Remove incorrect note from string_add_assign docs
Manish Goregaokar [Wed, 29 Aug 2018 18:24:00 +0000 (11:24 -0700)]
Merge pull request #3105 from frewsxcv/frewsxcv-private
Make clippy_lints::{utils,consts} modules private, remove unused items.
flip1995 [Tue, 28 Aug 2018 12:16:31 +0000 (14:16 +0200)]
Implement backwards compatibility changes introduced by rust-lang/rust#53762
flip1995 [Tue, 28 Aug 2018 09:27:17 +0000 (11:27 +0200)]
Fix some rebase fallout
flip1995 [Wed, 1 Aug 2018 20:48:41 +0000 (22:48 +0200)]
Adapt codebase to the tool_lints
flip1995 [Wed, 1 Aug 2018 20:38:04 +0000 (22:38 +0200)]
Adapt ui-toml-tests to the tool_lints
flip1995 [Mon, 30 Jul 2018 09:33:44 +0000 (11:33 +0200)]
Adapt run-pass tests to the tool_lints
flip1995 [Wed, 1 Aug 2018 14:30:44 +0000 (16:30 +0200)]
Adapt the *.stderr files of the ui-tests to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:34:52 +0000 (17:34 +0200)]
Adapt ui-tests to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:35:41 +0000 (17:35 +0200)]
Adapt scripts to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:35:24 +0000 (17:35 +0200)]
Adapt documentation to the tool_lints
flip1995 [Sun, 29 Jul 2018 09:04:40 +0000 (11:04 +0200)]
Switch to declare_tool_lint macro
flip1995 [Sat, 28 Jul 2018 15:34:24 +0000 (17:34 +0200)]
Switch to tool_lints
Oliver Schneider [Wed, 29 Aug 2018 14:32:11 +0000 (16:32 +0200)]
Merge pull request #3104 from frewsxcv/frewsxcv-ptr-offset-with-cast
New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.
Corey Farwell [Wed, 29 Aug 2018 13:59:38 +0000 (08:59 -0500)]
dont deref
Corey Farwell [Wed, 29 Aug 2018 13:27:32 +0000 (08:27 -0500)]
clippy suggestion
Corey Farwell [Wed, 29 Aug 2018 13:01:05 +0000 (08:01 -0500)]
derive copy/clone
Corey Farwell [Wed, 29 Aug 2018 12:46:03 +0000 (07:46 -0500)]
bring back sugg::range
Corey Farwell [Wed, 29 Aug 2018 12:43:40 +0000 (07:43 -0500)]
eof newline
Corey Farwell [Wed, 29 Aug 2018 12:42:43 +0000 (07:42 -0500)]
utilize carrier
Corey Farwell [Wed, 29 Aug 2018 12:40:00 +0000 (07:40 -0500)]
suggest wrapping_offset as well
Corey Farwell [Wed, 29 Aug 2018 12:12:22 +0000 (07:12 -0500)]
if no suggestion, dont add suggestion
Corey Farwell [Wed, 29 Aug 2018 12:08:59 +0000 (07:08 -0500)]
utilize .is_unsafe_ptr
Corey Farwell [Wed, 29 Aug 2018 12:07:23 +0000 (07:07 -0500)]
utilize cx.tcx.types.usize
Corey Farwell [Wed, 29 Aug 2018 12:03:50 +0000 (07:03 -0500)]
tweak comment
Corey Farwell [Wed, 29 Aug 2018 12:02:26 +0000 (07:02 -0500)]
switch lint from 'style' to 'complexity'
Corey Farwell [Mon, 27 Aug 2018 13:49:54 +0000 (09:49 -0400)]
New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.
First part of #3047.
Corey Farwell [Wed, 29 Aug 2018 02:32:20 +0000 (21:32 -0500)]
Make clippy_lints::{utils,consts} modules private, remove unused items.
Oliver Schneider [Tue, 28 Aug 2018 11:13:42 +0000 (13:13 +0200)]
Update imports and rustup
Philipp Hansch [Tue, 28 Aug 2018 05:42:36 +0000 (06:42 +0100)]
Merge pull request #3101 from pickfire/patch-1
Fix typo for panel cursor
Ivan Tham [Tue, 28 Aug 2018 02:24:21 +0000 (10:24 +0800)]
Fix typo for panel cursor
Daniel Wagner-Hall [Mon, 27 Aug 2018 22:22:07 +0000 (23:22 +0100)]
default_trait_access skips <F as Default>::default()
This includes the type name, so is clear, and may be necessary.
There doesn't seem to be an obviously cleaner way to pull out the
literal text of the named type here.
Fixes #2879
llogiq [Mon, 27 Aug 2018 19:00:53 +0000 (21:00 +0200)]
Merge pull request #3090 from matthiaskrgr/new_without_default_highlight
docs: make example in new_without_default lint syntax highlighted
Matthias Krüger [Mon, 27 Aug 2018 15:35:30 +0000 (17:35 +0200)]
docs: make example in new_without_default lint syntax highlighted