]> git.lizzy.rs Git - rust.git/log
rust.git
5 years agoprint_with_newline / write_with_newline: don't warn about string with several `\n...
Matthias Krüger [Thu, 6 Sep 2018 10:55:04 +0000 (12:55 +0200)]
print_with_newline / write_with_newline: don't warn about string with several `\n`s in them.

Fixes #3126

5 years agorustfmt clippy_lints/src/write.rs
Matthias Krüger [Thu, 6 Sep 2018 10:33:00 +0000 (12:33 +0200)]
rustfmt clippy_lints/src/write.rs

5 years agoMerge pull request #3136 from mikerite/driver-rustc-arg-2
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 6 Sep 2018 07:26:11 +0000 (09:26 +0200)]
Merge pull request #3136 from mikerite/driver-rustc-arg-2

driver: Improve check for rustc arg

5 years agoMerge pull request #2985 from phansch/riir_update_lints
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 6 Sep 2018 07:24:26 +0000 (09:24 +0200)]
Merge pull request #2985 from phansch/riir_update_lints

update_lints rewrite: Add structure and --print-only

5 years agoPass by ref instead of value
Philipp Hansch [Thu, 6 Sep 2018 06:19:09 +0000 (08:19 +0200)]
Pass by ref instead of value

5 years agoMore refactoring
Philipp Hansch [Wed, 5 Sep 2018 18:32:26 +0000 (20:32 +0200)]
More refactoring

5 years agoMerge pull request #3133 from matthiaskrgr/link
Philipp Hansch [Thu, 6 Sep 2018 05:10:45 +0000 (07:10 +0200)]
Merge pull request #3133 from matthiaskrgr/link

remove "clippy::" lint prefix from lint name in doc url.

5 years agodriver: Improve check for rustc arg
Michael Wright [Thu, 6 Sep 2018 05:01:56 +0000 (07:01 +0200)]
driver: Improve check for rustc arg

The rustc arg might not be exactly "rustc". It may be any path to a rustc
executable (especially if the RUSTC environment variable is set when
executing cargo). Rather check that it is a path with 'rustc' file stem.

5 years agoremove "clippy::" lint prefix from lint name in doc url.
Matthias Krüger [Wed, 5 Sep 2018 22:45:57 +0000 (00:45 +0200)]
remove "clippy::" lint prefix from lint name in doc url.

Fixes #3132

5 years agoMerge pull request #3131 from JoshMcguigan/ptr_arg-2293
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Wed, 5 Sep 2018 14:22:03 +0000 (16:22 +0200)]
Merge pull request #3131 from JoshMcguigan/ptr_arg-2293

Fix #2293 - ptr_arg

5 years agoAdded test case for ptr_arg
Josh Mcguigan [Wed, 5 Sep 2018 12:59:07 +0000 (05:59 -0700)]
Added test case for ptr_arg

5 years agoRemove duplicated .gitignore
Philipp Hansch [Wed, 5 Sep 2018 11:35:57 +0000 (13:35 +0200)]
Remove duplicated .gitignore

5 years agoReturn impl Iterator instead of Vec<Lint>
Philipp Hansch [Wed, 5 Sep 2018 11:34:28 +0000 (13:34 +0200)]
Return impl Iterator instead of Vec<Lint>

This makes the API of `lib.rs` a bit more flexible.

5 years agoMerge pull request #3108 from daubaris/range-plus-one
Philipp Krones [Tue, 4 Sep 2018 19:13:30 +0000 (21:13 +0200)]
Merge pull request #3108 from daubaris/range-plus-one

range_plus_one suggestion should not remove braces fix

5 years agoswitched to ticks for chars
daubaris [Tue, 4 Sep 2018 15:56:48 +0000 (18:56 +0300)]
switched to ticks for chars

5 years agoMerge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range...
daubaris [Tue, 4 Sep 2018 15:52:18 +0000 (18:52 +0300)]
Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one

5 years agoMerge pull request #3125 from nrc/pub-conf
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 4 Sep 2018 08:09:38 +0000 (10:09 +0200)]
Merge pull request #3125 from nrc/pub-conf

Make `Default` do what `default` used to do

5 years agoMerge pull request #3124 from phansch/cleanup_old_min_version_stuff
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 4 Sep 2018 08:09:10 +0000 (10:09 +0200)]
Merge pull request #3124 from phansch/cleanup_old_min_version_stuff

Cleanup old min_version stuff

5 years agoMerge pull request #3109 from shssoichiro/3034-needless-collect
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Tue, 4 Sep 2018 08:07:11 +0000 (10:07 +0200)]
Merge pull request #3109 from shssoichiro/3034-needless-collect

Lint against needless uses of `collect()`

5 years agoDelete needless file
Josh Holmer [Sat, 1 Sep 2018 15:07:18 +0000 (11:07 -0400)]
Delete needless file

5 years agoMore if_chain
Josh Holmer [Tue, 4 Sep 2018 03:58:10 +0000 (23:58 -0400)]
More if_chain

5 years agoRustup
Josh Holmer [Tue, 4 Sep 2018 03:50:24 +0000 (23:50 -0400)]
Rustup

5 years agoApply applicability
Josh Holmer [Fri, 31 Aug 2018 22:26:04 +0000 (18:26 -0400)]
Apply applicability

5 years agoMajority of PR changes
Josh Holmer [Fri, 31 Aug 2018 22:14:33 +0000 (18:14 -0400)]
Majority of PR changes

5 years agoLint against needless uses of `collect()`
Josh Holmer [Thu, 30 Aug 2018 03:01:24 +0000 (23:01 -0400)]
Lint against needless uses of `collect()`

Handles cases of `.collect().len()`, `.collect().is_empty()`, and
`.collect().contains()`. This lint is intended to be generic enough to
be added to at a later time with other similar patterns that could be
optimized.

Closes #3034

5 years agoMake `Default` do what `default` used to do
Nick Cameron [Mon, 3 Sep 2018 21:12:50 +0000 (09:12 +1200)]
Make `Default` do what `default` used to do

5 years agoCleanup old min_version stuff
Philipp Hansch [Mon, 3 Sep 2018 20:27:35 +0000 (22:27 +0200)]
Cleanup old min_version stuff

This cleans up a few leftover things after
https://github.com/rust-lang-nursery/rust-clippy/pull/3018

5 years agoRun clippy on clippy_dev, too
Philipp Hansch [Sun, 2 Sep 2018 08:13:53 +0000 (10:13 +0200)]
Run clippy on clippy_dev, too

5 years agoRefactor to use into_group_map from Itertools
Philipp Hansch [Sun, 2 Sep 2018 07:45:13 +0000 (09:45 +0200)]
Refactor to use into_group_map from Itertools

5 years agos/direntry/dir_entry
Philipp Hansch [Thu, 30 Aug 2018 06:00:16 +0000 (08:00 +0200)]
s/direntry/dir_entry

5 years agoUse insignificant whitespace mode for nice regex
Philipp Hansch [Thu, 30 Aug 2018 05:57:54 +0000 (07:57 +0200)]
Use insignificant whitespace mode for nice regex

5 years agocargo update in clippy_dev
Philipp Hansch [Thu, 30 Aug 2018 05:57:11 +0000 (07:57 +0200)]
cargo update in clippy_dev

5 years agoupdate_lints rewrite: Add structure and --print-only
Philipp Hansch [Tue, 17 Jul 2018 20:50:17 +0000 (22:50 +0200)]
update_lints rewrite: Add structure and --print-only

5 years agofixed known problems expression
daubaris [Mon, 3 Sep 2018 20:01:28 +0000 (23:01 +0300)]
fixed known problems expression

5 years agoMerge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range...
daubaris [Mon, 3 Sep 2018 15:24:47 +0000 (18:24 +0300)]
Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one

5 years agobackticks and testcase
daubaris [Mon, 3 Sep 2018 15:24:38 +0000 (18:24 +0300)]
backticks and testcase

5 years agoMerge pull request #3092 from illicitonion/issue-2879
Philipp Hansch [Mon, 3 Sep 2018 15:24:33 +0000 (17:24 +0200)]
Merge pull request #3092 from illicitonion/issue-2879

default_trait_access skips <F as Default>::default()

5 years agoMerge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range...
daubaris [Mon, 3 Sep 2018 14:21:13 +0000 (17:21 +0300)]
Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one

5 years agoMerge pull request #3120 from rust-lang-nursery/ci_integration
Manish Goregaokar [Mon, 3 Sep 2018 09:37:18 +0000 (09:37 +0000)]
Merge pull request #3120 from rust-lang-nursery/ci_integration

Update travis integration tests to tool_lints

5 years agoMerge pull request #3119 from joshtriplett/a-message-from-the-save-the-iters-foundation
Philipp Krones [Mon, 3 Sep 2018 08:55:43 +0000 (10:55 +0200)]
Merge pull request #3119 from joshtriplett/a-message-from-the-save-the-iters-foundation

iter conservation efforts: save the endangered .iter() and .into_iter()

5 years agoUpdate travis integration tests to tool_lints
Philipp Krones [Mon, 3 Sep 2018 08:52:42 +0000 (10:52 +0200)]
Update travis integration tests to tool_lints

`clippy_pedantic` -> `clippy::pedantic`
`clippy_nursery` -> `clippy::nursery`

5 years agoiter conservation efforts: save the endangered .iter() and .into_iter()
Josh Triplett [Mon, 3 Sep 2018 07:19:59 +0000 (00:19 -0700)]
iter conservation efforts: save the endangered .iter() and .into_iter()

Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so
that people can turn them on if they want to enforce that style; avoid
presenting them as *the* idiomatic Rust style, rather than just *a* style.

5 years agoMerge pull request #3116 from phansch/fix_warning
Philipp Hansch [Mon, 3 Sep 2018 06:35:24 +0000 (07:35 +0100)]
Merge pull request #3116 from phansch/fix_warning

Fix clippy -> clippy::all warning in CI

5 years agoFix clippy -> clippy::all warning in CI
Philipp Hansch [Mon, 3 Sep 2018 06:03:05 +0000 (08:03 +0200)]
Fix clippy -> clippy::all warning in CI

5 years agoMerge pull request #3115 from rust-lang-nursery/rm-token
Manish Goregaokar [Mon, 3 Sep 2018 05:48:46 +0000 (05:48 +0000)]
Merge pull request #3115 from rust-lang-nursery/rm-token

Remove dependence of ci on github token

5 years agoRemove dependence of ci on github token
Manish Goregaokar [Mon, 3 Sep 2018 03:42:06 +0000 (09:12 +0530)]
Remove dependence of ci on github token

5 years agoMerge pull request #2941 from rust-lang-nursery/prs
Manish Goregaokar [Mon, 3 Sep 2018 02:44:45 +0000 (08:14 +0530)]
Merge pull request #2941 from rust-lang-nursery/prs

Run travis on rustc-master instead of nightly

5 years agoMerge pull request #3114 from nrc/pub-conf
Manish Goregaokar [Mon, 3 Sep 2018 02:06:58 +0000 (07:36 +0530)]
Merge pull request #3114 from nrc/pub-conf

Make `Conf::default` available

5 years agoMake `Conf::default` available
Nick Cameron [Mon, 3 Sep 2018 01:57:50 +0000 (13:57 +1200)]
Make `Conf::default` available

Fixes RLS

5 years agoMerge branch 'master' into issue-2879
Daniel Wagner-Hall [Sun, 2 Sep 2018 23:01:57 +0000 (00:01 +0100)]
Merge branch 'master' into issue-2879

5 years agoSimplify
Daniel Wagner-Hall [Sun, 2 Sep 2018 22:42:07 +0000 (23:42 +0100)]
Simplify

5 years agoUse types rather than strings
Daniel Wagner-Hall [Sun, 2 Sep 2018 22:37:28 +0000 (23:37 +0100)]
Use types rather than strings

5 years agoTrigger rebuild for AppVeyor (and fix grammar)
Philipp Hansch [Sun, 2 Sep 2018 09:31:39 +0000 (11:31 +0200)]
Trigger rebuild for AppVeyor (and fix grammar)

5 years agoMerge remote-tracking branch 'upstream/master' into prs
Philipp Hansch [Sun, 2 Sep 2018 09:05:49 +0000 (11:05 +0200)]
Merge remote-tracking branch 'upstream/master' into prs

5 years agoMerge pull request #3113 from mikerite/fix-3112
Manish Goregaokar [Sun, 2 Sep 2018 07:59:06 +0000 (13:29 +0530)]
Merge pull request #3113 from mikerite/fix-3112

Fix #3112

5 years agoFix #3112
Michael Wright [Sun, 2 Sep 2018 07:38:25 +0000 (09:38 +0200)]
Fix #3112

5 years agoresolved conflicts
daubaris [Sat, 1 Sep 2018 06:37:42 +0000 (09:37 +0300)]
resolved conflicts

5 years agoMerge pull request #2977 from flip1995/tool_lints
Manish Goregaokar [Sat, 1 Sep 2018 05:52:23 +0000 (11:22 +0530)]
Merge pull request #2977 from flip1995/tool_lints

Implement tool_lints

5 years agoFix ptr offset tests
Manish Goregaokar [Fri, 31 Aug 2018 07:38:27 +0000 (00:38 -0700)]
Fix ptr offset tests

5 years agodeclare_lint -> declare_tool_lint
Manish Goregaokar [Fri, 31 Aug 2018 07:34:48 +0000 (00:34 -0700)]
declare_lint -> declare_tool_lint

5 years agoMerge pull request #3081 from mikerite/fix-3078
Oliver Schneider [Fri, 31 Aug 2018 07:05:39 +0000 (09:05 +0200)]
Merge pull request #3081 from mikerite/fix-3078

Fix #3078

5 years agoMerge branch 'master' into fix-3078
Michael Wright [Fri, 31 Aug 2018 04:17:11 +0000 (06:17 +0200)]
Merge branch 'master' into fix-3078

5 years agoRevert "fix-3078: verify test case"
Michael Wright [Fri, 31 Aug 2018 04:10:30 +0000 (06:10 +0200)]
Revert "fix-3078: verify test case"

This reverts commit 6256ad05bac1f708298f827fdfa7b54042961294.

5 years agorange_plus_one suggestion should not remove braces fix
daubaris [Thu, 30 Aug 2018 17:06:13 +0000 (20:06 +0300)]
range_plus_one suggestion should not remove braces fix

5 years agoMerge pull request #2962 from phansch/further_automate_pre_publish
Oliver Schneider [Thu, 30 Aug 2018 08:16:36 +0000 (10:16 +0200)]
Merge pull request #2962 from phansch/further_automate_pre_publish

Further automate pre_publish.sh

5 years agoRemove git diffing part
Philipp Hansch [Thu, 30 Aug 2018 05:33:53 +0000 (07:33 +0200)]
Remove git diffing part

Because we no bump versions

5 years agoMerge pull request #3076 from mbrubeck/patch-1
Philipp Hansch [Wed, 29 Aug 2018 19:09:38 +0000 (20:09 +0100)]
Merge pull request #3076 from mbrubeck/patch-1

Remove incorrect note from string_add_assign docs

5 years agoMerge pull request #3105 from frewsxcv/frewsxcv-private
Manish Goregaokar [Wed, 29 Aug 2018 18:24:00 +0000 (11:24 -0700)]
Merge pull request #3105 from frewsxcv/frewsxcv-private

Make clippy_lints::{utils,consts} modules private, remove unused items.

5 years agoImplement backwards compatibility changes introduced by rust-lang/rust#53762
flip1995 [Tue, 28 Aug 2018 12:16:31 +0000 (14:16 +0200)]
Implement backwards compatibility changes introduced by rust-lang/rust#53762

5 years agoFix some rebase fallout
flip1995 [Tue, 28 Aug 2018 09:27:17 +0000 (11:27 +0200)]
Fix some rebase fallout

5 years agoAdapt codebase to the tool_lints
flip1995 [Wed, 1 Aug 2018 20:48:41 +0000 (22:48 +0200)]
Adapt codebase to the tool_lints

5 years agoAdapt ui-toml-tests to the tool_lints
flip1995 [Wed, 1 Aug 2018 20:38:04 +0000 (22:38 +0200)]
Adapt ui-toml-tests to the tool_lints

5 years agoAdapt run-pass tests to the tool_lints
flip1995 [Mon, 30 Jul 2018 09:33:44 +0000 (11:33 +0200)]
Adapt run-pass tests to the tool_lints

5 years agoAdapt the *.stderr files of the ui-tests to the tool_lints
flip1995 [Wed, 1 Aug 2018 14:30:44 +0000 (16:30 +0200)]
Adapt the *.stderr files of the ui-tests to the tool_lints

5 years agoAdapt ui-tests to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:34:52 +0000 (17:34 +0200)]
Adapt ui-tests to the tool_lints

5 years agoAdapt scripts to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:35:41 +0000 (17:35 +0200)]
Adapt scripts to the tool_lints

5 years agoAdapt documentation to the tool_lints
flip1995 [Sat, 28 Jul 2018 15:35:24 +0000 (17:35 +0200)]
Adapt documentation to the tool_lints

5 years agoSwitch to declare_tool_lint macro
flip1995 [Sun, 29 Jul 2018 09:04:40 +0000 (11:04 +0200)]
Switch to declare_tool_lint macro

5 years agoSwitch to tool_lints
flip1995 [Sat, 28 Jul 2018 15:34:24 +0000 (17:34 +0200)]
Switch to tool_lints

5 years agoMerge pull request #3104 from frewsxcv/frewsxcv-ptr-offset-with-cast
Oliver Schneider [Wed, 29 Aug 2018 14:32:11 +0000 (16:32 +0200)]
Merge pull request #3104 from frewsxcv/frewsxcv-ptr-offset-with-cast

New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.

5 years agodont deref
Corey Farwell [Wed, 29 Aug 2018 13:59:38 +0000 (08:59 -0500)]
dont deref

5 years agoclippy suggestion
Corey Farwell [Wed, 29 Aug 2018 13:27:32 +0000 (08:27 -0500)]
clippy suggestion

5 years agoderive copy/clone
Corey Farwell [Wed, 29 Aug 2018 13:01:05 +0000 (08:01 -0500)]
derive copy/clone

5 years agobring back sugg::range
Corey Farwell [Wed, 29 Aug 2018 12:46:03 +0000 (07:46 -0500)]
bring back sugg::range

5 years agoeof newline
Corey Farwell [Wed, 29 Aug 2018 12:43:40 +0000 (07:43 -0500)]
eof newline

5 years agoutilize carrier
Corey Farwell [Wed, 29 Aug 2018 12:42:43 +0000 (07:42 -0500)]
utilize carrier

5 years agosuggest wrapping_offset as well
Corey Farwell [Wed, 29 Aug 2018 12:40:00 +0000 (07:40 -0500)]
suggest wrapping_offset as well

5 years agoif no suggestion, dont add suggestion
Corey Farwell [Wed, 29 Aug 2018 12:12:22 +0000 (07:12 -0500)]
if no suggestion, dont add suggestion

5 years agoutilize .is_unsafe_ptr
Corey Farwell [Wed, 29 Aug 2018 12:08:59 +0000 (07:08 -0500)]
utilize .is_unsafe_ptr

5 years agoutilize cx.tcx.types.usize
Corey Farwell [Wed, 29 Aug 2018 12:07:23 +0000 (07:07 -0500)]
utilize cx.tcx.types.usize

5 years agotweak comment
Corey Farwell [Wed, 29 Aug 2018 12:03:50 +0000 (07:03 -0500)]
tweak comment

5 years agoswitch lint from 'style' to 'complexity'
Corey Farwell [Wed, 29 Aug 2018 12:02:26 +0000 (07:02 -0500)]
switch lint from 'style' to 'complexity'

5 years agoNew lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.
Corey Farwell [Mon, 27 Aug 2018 13:49:54 +0000 (09:49 -0400)]
New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.

First part of #3047.

5 years agoMake clippy_lints::{utils,consts} modules private, remove unused items.
Corey Farwell [Wed, 29 Aug 2018 02:32:20 +0000 (21:32 -0500)]
Make clippy_lints::{utils,consts} modules private, remove unused items.

5 years agoUpdate imports and rustup
Oliver Schneider [Tue, 28 Aug 2018 11:13:42 +0000 (13:13 +0200)]
Update imports and rustup

5 years agoMerge pull request #3101 from pickfire/patch-1
Philipp Hansch [Tue, 28 Aug 2018 05:42:36 +0000 (06:42 +0100)]
Merge pull request #3101 from pickfire/patch-1

Fix typo for panel cursor

5 years agoFix typo for panel cursor
Ivan Tham [Tue, 28 Aug 2018 02:24:21 +0000 (10:24 +0800)]
Fix typo for panel cursor

5 years agodefault_trait_access skips <F as Default>::default()
Daniel Wagner-Hall [Mon, 27 Aug 2018 22:22:07 +0000 (23:22 +0100)]
default_trait_access skips <F as Default>::default()

This includes the type name, so is clear, and may be necessary.

There doesn't seem to be an obviously cleaner way to pull out the
literal text of the named type here.

Fixes #2879

5 years agoMerge pull request #3090 from matthiaskrgr/new_without_default_highlight
llogiq [Mon, 27 Aug 2018 19:00:53 +0000 (21:00 +0200)]
Merge pull request #3090 from matthiaskrgr/new_without_default_highlight

docs: make example in new_without_default lint syntax highlighted

5 years agodocs: make example in new_without_default lint syntax highlighted
Matthias Krüger [Mon, 27 Aug 2018 15:35:30 +0000 (17:35 +0200)]
docs: make example in new_without_default lint syntax highlighted