]>
git.lizzy.rs Git - rust.git/log
Kampfkarren [Thu, 13 Dec 2018 17:37:00 +0000 (09:37 -0800)]
Remove DUMMY_SP
Kampfkarren [Thu, 13 Dec 2018 17:34:16 +0000 (09:34 -0800)]
Add suggestion for replacement
Kampfkarren [Thu, 13 Dec 2018 17:14:01 +0000 (09:14 -0800)]
Update lint definitions
Kampfkarren [Thu, 13 Dec 2018 15:43:13 +0000 (07:43 -0800)]
Lint for Vec<Box<T: Sized>> - Closes #3530
bors [Wed, 12 Dec 2018 19:17:09 +0000 (19:17 +0000)]
Auto merge of #3535 - sinkuu:fixes, r=phansch
Fix some problems
Fixes #2892, #3199, #2841, #3476
bors [Wed, 12 Dec 2018 18:36:38 +0000 (18:36 +0000)]
Auto merge of #3510 - phansch:fix_doc_markdown_mixed_case, r=flip1995
Fix doc_markdown mixed case false positive
Fixes #2343
Philipp Hansch [Fri, 7 Dec 2018 21:38:45 +0000 (22:38 +0100)]
Fix doc_markdown mixed case false positive
bors [Wed, 12 Dec 2018 18:11:13 +0000 (18:11 +0000)]
Auto merge of #3450 - phansch:structured_sugg_for_explicit_write, r=flip1995
Add suggestion for explicit_write lint
Closes #2083
bors [Wed, 12 Dec 2018 17:45:55 +0000 (17:45 +0000)]
Auto merge of #3544 - flip1995:rollup, r=flip1995
Rollup of 3 pull requests
Successful merges:
- #3509 (Fix doc_markdown off by one issue)
- #3539 (Fix rvm/gpg bug in travis osx build)
- #3540 (rustup https://github.com/rust-lang/rust/pull/56092)
Failed merges:
r? @ghost
Philipp Krones [Wed, 12 Dec 2018 17:17:01 +0000 (18:17 +0100)]
Rollup merge of #3540 - matthiaskrgr:rustup, r=flip1995
rustup https://github.com/rust-lang/rust/pull/56092
fix ui test cast_alignment failure by adding #![feature(rustc_private)]
Philipp Krones [Wed, 12 Dec 2018 17:17:00 +0000 (18:17 +0100)]
Rollup merge of #3539 - flip1995:travis_osx_fix, r=oli-obk
Fix rvm/gpg bug in travis osx build
Apparently this workaround isn't needed anymore ([travis](https://travis-ci.org/flip1995/rust-clippy/jobs/
467027571 )) and fixes the latest osx failures: [travis](https://travis-ci.org/rust-lang/rust-clippy/jobs/
467013498 #L152)
Philipp Krones [Wed, 12 Dec 2018 17:16:59 +0000 (18:16 +0100)]
Rollup merge of #3509 - phansch:fix_doc_markdown_bugs, r=flip1995
Fix doc_markdown off by one issue
Fixes #2210
Matthias Krüger [Wed, 12 Dec 2018 16:17:01 +0000 (17:17 +0100)]
rustup https://github.com/rust-lang/rust/pull/56092
fix ui test cast_alignment failure by adding #![feature(rustc_private)]
flip1995 [Wed, 12 Dec 2018 14:37:31 +0000 (15:37 +0100)]
Fix rvm/gpg bug in travis osx build
bors [Wed, 12 Dec 2018 09:56:38 +0000 (09:56 +0000)]
Auto merge of #3537 - matthiaskrgr:fix_script_2, r=matthiaskrgr
base-tests: don't print all commands to stdout during the loop
Fixes thinko in #3529
Matthias Krüger [Wed, 12 Dec 2018 09:27:13 +0000 (10:27 +0100)]
base-tests: don't print all commands to stdout during the loop
Shotaro Yamada [Wed, 12 Dec 2018 08:46:52 +0000 (17:46 +0900)]
question_mark: Suggest Some(opt?) for if-else
Shotaro Yamada [Tue, 11 Dec 2018 14:33:23 +0000 (23:33 +0900)]
redundant_field_names: Do not trigger on path with type params
Fixes #3476
Shotaro Yamada [Tue, 11 Dec 2018 14:21:25 +0000 (23:21 +0900)]
question_mark: Lint only early returns
Shotaro Yamada [Tue, 11 Dec 2018 14:05:43 +0000 (23:05 +0900)]
question_mark: Fix applicability
bors [Wed, 12 Dec 2018 08:27:12 +0000 (08:27 +0000)]
Auto merge of #3536 - matthiaskrgr:fix_script, r=oli-obk
fix typo in script
Matthias Krüger [Wed, 12 Dec 2018 08:17:43 +0000 (09:17 +0100)]
fix typo in script
Philipp Hansch [Fri, 7 Dec 2018 10:48:06 +0000 (11:48 +0100)]
Fix doc_markdown off by one issue
Shotaro Yamada [Tue, 11 Dec 2018 08:31:22 +0000 (17:31 +0900)]
Remove obsolete comment
Shotaro Yamada [Tue, 11 Dec 2018 06:06:41 +0000 (15:06 +0900)]
new_without_default, partialeq_ne_impl: Use span_lint_node
Fixes #2892, fixes #3199
bors [Wed, 12 Dec 2018 06:46:21 +0000 (06:46 +0000)]
Auto merge of #3533 - phansch:add_to_doc_valid_idents, r=phansch
Add 'CamelCase' to doc_valid_idents
Fixes #2395
Philipp Hansch [Wed, 12 Dec 2018 06:33:23 +0000 (07:33 +0100)]
Update .stderr after rebase
Philipp Hansch [Fri, 30 Nov 2018 06:25:55 +0000 (07:25 +0100)]
cargo fmt and remove stabilized feature
Philipp Hansch [Thu, 29 Nov 2018 21:17:40 +0000 (22:17 +0100)]
Make suggestion Applicability::MachineApplicable
Philipp Hansch [Thu, 29 Nov 2018 07:15:44 +0000 (08:15 +0100)]
Address review feedback
* Fix typo
* Handle None value instead of using `unwrap()`
* `pop()` instead of `x.truncate(x.len() - 1)`
Philipp Hansch [Sat, 24 Nov 2018 11:17:43 +0000 (12:17 +0100)]
Extract method
Philipp Hansch [Fri, 23 Nov 2018 20:29:27 +0000 (21:29 +0100)]
Check array lengths to prevent OOB access
Philipp Hansch [Fri, 23 Nov 2018 07:18:23 +0000 (08:18 +0100)]
Add suggestion for explicit_write lint
bors [Wed, 12 Dec 2018 05:57:31 +0000 (05:57 +0000)]
Auto merge of #3529 - matthiaskrgr:rustfmt_tests, r=phansch
rustfmt tests
also fails CI if tests turn out to not be formatted properly.
Matthias Krüger [Tue, 11 Dec 2018 19:50:55 +0000 (20:50 +0100)]
test reformatting: revert more questionable changes done by rustfmt and add #[rustfmt::skip]
Philipp Hansch [Tue, 11 Dec 2018 18:37:43 +0000 (19:37 +0100)]
Add 'CamelCase' to doc_valid_idents
bors [Tue, 11 Dec 2018 11:55:59 +0000 (11:55 +0000)]
Auto merge of #3532 - maxencefrenette:fix-contributing-md, r=oli-obk
Remove dead link in CONTRIBUTING.md
I don't think there was an issue for this, but this is just removing a dead link in CONTRIBUTING.md. The _Linting Clippy with your local changes_ section seems to have been removed without updating the table of contents.
I'm not sure if I should have opened an issue, but it seemed like a trivial fix to me.
Maxence Frenette [Tue, 11 Dec 2018 10:10:41 +0000 (05:10 -0500)]
Remove dead link in CONTRIBUTING.md
bors [Tue, 11 Dec 2018 06:55:48 +0000 (06:55 +0000)]
Auto merge of #3527 - phansch:update_readme2, r=matthiaskrgr
readme: tool lints are stable now
None
Matthias Krüger [Tue, 11 Dec 2018 00:41:59 +0000 (01:41 +0100)]
Merge branch 'master' into rustfmt_tests
Matthias Krüger [Tue, 11 Dec 2018 00:31:04 +0000 (01:31 +0100)]
tests: fix more cases where rustfmt would have hurt the tests
Matthias Krüger [Mon, 10 Dec 2018 23:59:59 +0000 (00:59 +0100)]
tests: revert some changs and add further rustfmt::skip attributes.
Philipp Hansch [Mon, 10 Dec 2018 21:30:16 +0000 (22:30 +0100)]
s/clippy/Clippy in readme
Philipp Hansch [Mon, 10 Dec 2018 21:22:57 +0000 (22:22 +0100)]
Also add note about using -W clippy::lint_group
Philipp Hansch [Mon, 10 Dec 2018 21:04:27 +0000 (22:04 +0100)]
readme: tool lints are stable now
bors [Mon, 10 Dec 2018 19:21:25 +0000 (19:21 +0000)]
Auto merge of #3511 - phansch:remove_allow_doc_markdown, r=phansch
Remove allow(doc_markdown) in excessive_precision.rs
Closes #3299
bors [Mon, 10 Dec 2018 18:55:49 +0000 (18:55 +0000)]
Auto merge of #3518 - sinkuu:redundant_clone_tw, r=phansch
Lint redundant clone of fields
Makes `redundant_clone` warn on unnecessary `foo.field.clone()` sometimes (it can detect an unnecessary clone only if the base of projection, `foo` in this case, is not used at all after that). This is enough for cases like `returns_tuple().0.clone()`.
Matthias Krüger [Mon, 10 Dec 2018 14:46:01 +0000 (15:46 +0100)]
test formatting: don't format tests/ui/formatting.rs
Matthias Krüger [Mon, 10 Dec 2018 05:27:19 +0000 (06:27 +0100)]
update test stderr
bors [Mon, 10 Dec 2018 07:06:44 +0000 (07:06 +0000)]
Auto merge of #3524 - phansch:update_contributing, r=phansch
Small updates to CONTRIBUTING.md
None
Philipp Hansch [Mon, 10 Dec 2018 06:33:11 +0000 (07:33 +0100)]
Document bors/homu
Philipp Hansch [Fri, 7 Dec 2018 12:00:21 +0000 (13:00 +0100)]
Small updates to CONTRIBUTING.md
Shotaro Yamada [Mon, 10 Dec 2018 06:59:21 +0000 (15:59 +0900)]
Only check the assignment found at last
If there are more than one such assignment, the last one may be
the one supplied to `clone` method.
Makes `find_stmt_assigns_to` internally reverses the iterator to make
the intent to "iterate statements backward" clear.
Shotaro Yamada [Mon, 10 Dec 2018 06:48:34 +0000 (15:48 +0900)]
Add comment and rename
bors [Mon, 10 Dec 2018 06:01:16 +0000 (06:01 +0000)]
Auto merge of #3522 - matthiaskrgr:target_dir, r=phansch
travis: base-tests: share CARGO_TARGET_DIR between check runs of subcrates to avoid unnecessarily recompiling deps.
Shotaro Yamada [Sun, 9 Dec 2018 13:02:23 +0000 (22:02 +0900)]
Apply redundant_clone on clippy
Shotaro Yamada [Sun, 9 Dec 2018 11:19:21 +0000 (20:19 +0900)]
Lint redundant clone of projection
Matthias Krüger [Sun, 9 Dec 2018 22:26:16 +0000 (23:26 +0100)]
rustfmt tests
Matthias Krüger [Sun, 9 Dec 2018 21:47:22 +0000 (22:47 +0100)]
travis: base-tests: share CARGO_TARGET_DIR between check runs of subcrates to avoid unneccessarily recompiling deps.
Matthias Krüger [Sun, 9 Dec 2018 21:06:29 +0000 (22:06 +0100)]
base tests: assert that tests are properly formatted.
bors [Sun, 9 Dec 2018 18:03:53 +0000 (18:03 +0000)]
Auto merge of #3520 - matthiaskrgr:test_rustfmt_skip, r=phansch
add rustfmt::skip attributes to a couple of tests
part of rustfmt'ing test code
Matthias Krüger [Sun, 9 Dec 2018 16:17:58 +0000 (17:17 +0100)]
update line numbers of tests
Matthias Krüger [Sat, 8 Dec 2018 17:56:59 +0000 (18:56 +0100)]
add rustfmt::skip attributes to some tests
Philipp Hansch [Sun, 9 Dec 2018 15:13:37 +0000 (16:13 +0100)]
Merge pull request #3517 from phansch/add_fast_finish
Add `fast_finish` to travis matrix
Philipp Hansch [Sun, 9 Dec 2018 14:56:29 +0000 (15:56 +0100)]
Merge pull request #3516 from phansch/remove_run_rustfix_annotation
Remove a run-rustfix annotation (for now)
Shotaro Yamada [Sun, 9 Dec 2018 10:18:44 +0000 (19:18 +0900)]
Fix test
`if true` is recognized by MIR optimization.
Philipp Hansch [Sun, 9 Dec 2018 14:42:52 +0000 (15:42 +0100)]
Add `fast_finish` to travis matrix
This means we don't have to wait for `allowed_failures` builds to
complete. It should save us ~10 minutes until we remove the windows
build from `allowed_failures`.
Philipp Hansch [Sun, 9 Dec 2018 14:16:36 +0000 (15:16 +0100)]
Remove a run-rustfix annotation (for now)
Starting to work on #2376, this annotation got in the way. Going to
remove it for now.
Philipp Hansch [Sun, 9 Dec 2018 11:45:31 +0000 (12:45 +0100)]
Merge pull request #3515 from matthiaskrgr/fmt
run rustfmt
Matthias Krüger [Sun, 9 Dec 2018 11:03:10 +0000 (12:03 +0100)]
run rustfmt
Shotaro Yamada [Sun, 9 Dec 2018 10:18:35 +0000 (19:18 +0900)]
Cleanup
Philipp Hansch [Sat, 8 Dec 2018 12:42:01 +0000 (13:42 +0100)]
Merge pull request #3512 from matthiaskrgr/rustup
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )
Philipp Hansch [Sat, 8 Dec 2018 11:41:04 +0000 (12:41 +0100)]
s/rustfmt-preview/rustfmt/
Philipp Hansch [Sat, 8 Dec 2018 11:09:32 +0000 (12:09 +0100)]
Swap if branches
Philipp Hansch [Sat, 8 Dec 2018 10:57:25 +0000 (11:57 +0100)]
Fix c_void false positive caused by libc refactoring
The path of `libc::c_void` has changes in https://github.com/rust-lang/libc/commit/
5c1a6b8a6d558882927a0816d91c01b9c2a88018
The DefId path is now always platform specific like
`libc::windows::c_void`. This fixes our c_void detection to only check
the first and last elements.
Matthias Krüger [Sat, 8 Dec 2018 00:56:03 +0000 (01:56 +0100)]
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )
Philipp Hansch [Sat, 8 Dec 2018 08:59:02 +0000 (09:59 +0100)]
Merge pull request #3336 from HMPerson1/clone_on_copy_deref
Fix `clone_on_copy` not detecting derefs sometimes
Philipp Hansch [Fri, 7 Dec 2018 21:47:12 +0000 (22:47 +0100)]
Remove allow(doc_markdown) in excessive_precision.rs
Philipp Hansch [Fri, 7 Dec 2018 21:20:19 +0000 (22:20 +0100)]
Merge pull request #3507 from flying-sheep/patch-1
typo: emum → enum
Philipp A [Fri, 7 Dec 2018 11:24:59 +0000 (12:24 +0100)]
typo: emum → enum
Philipp Hansch [Thu, 6 Dec 2018 21:11:29 +0000 (22:11 +0100)]
Merge pull request #3257 from o01eg/remove-sysroot
Don't try to determine sysroot. rustc_driver will use default value.
Philipp Hansch [Thu, 6 Dec 2018 16:17:40 +0000 (17:17 +0100)]
Merge pull request #3501 from matthiaskrgr/rustup
rustup clippy build with latest rustc
Manish Goregaokar [Thu, 6 Dec 2018 16:17:18 +0000 (11:17 -0500)]
Merge pull request #3502 from rust-lang/nrc-patch-1
Remove -preview suffix from README
Nick Cameron [Thu, 6 Dec 2018 16:11:50 +0000 (11:11 -0500)]
Remove -preview suffix from README
Matthias Krüger [Thu, 6 Dec 2018 15:38:32 +0000 (16:38 +0100)]
rustup clippy build with latest rustc
(breakage due to https://github.com/rust-lang/rust/commit/
08f8faedd0e30f45762afbb8d4873f7041e7462c )
Fixes #3500
Philipp Hansch [Thu, 6 Dec 2018 13:13:20 +0000 (14:13 +0100)]
Merge pull request #3497 from daxpedda/master
Fix bug in `implicit_return`.
daxpedda [Thu, 6 Dec 2018 12:23:42 +0000 (13:23 +0100)]
Forgot to remove some debugging code ...
daxpedda [Thu, 6 Dec 2018 12:21:04 +0000 (13:21 +0100)]
Improved code noted by clippy.
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer [Thu, 6 Dec 2018 11:26:43 +0000 (12:26 +0100)]
Merge pull request #3496 from fkohlgrueber/macro-in-closure-in-if-cond
fix #3482 and add ui test for it
daxpedda [Thu, 6 Dec 2018 11:22:54 +0000 (12:22 +0100)]
Fix bug in `implicit_return`.
Bug was already covered by test, but test was not checked for.
O01eg [Thu, 6 Dec 2018 10:46:23 +0000 (13:46 +0300)]
Fix format.
O01eg [Thu, 6 Dec 2018 10:21:45 +0000 (13:21 +0300)]
Add sysroot gettinh code to dogfood tests.
Felix Kohlgrüber [Thu, 6 Dec 2018 10:07:10 +0000 (11:07 +0100)]
fix #3482 and add ui test for it
O01eg [Thu, 22 Nov 2018 12:40:29 +0000 (15:40 +0300)]
Add sysroot getting code to tests.
O01eg [Thu, 4 Oct 2018 07:58:09 +0000 (10:58 +0300)]
Don't try to determine sysroot. rustc_driver will use default value.
Philipp Hansch [Thu, 6 Dec 2018 06:12:01 +0000 (07:12 +0100)]
Merge pull request #3494 from daxpedda/master
Added `IMPLICIT_RETURN` lint.
Philipp Hansch [Thu, 6 Dec 2018 06:10:04 +0000 (07:10 +0100)]
Merge pull request #3444 from waynr/fix-dogfood-tests
Fix dogfood tests
Wayne Warren [Fri, 30 Nov 2018 18:54:47 +0000 (12:54 -0600)]
Don't change current working directory of cargo tests
Wayne Warren [Sat, 24 Nov 2018 21:24:13 +0000 (15:24 -0600)]
Use cargo's "PROFILE" envvar and set CLIPPY_DOGFOOD
Wayne Warren [Sat, 24 Nov 2018 21:22:23 +0000 (15:22 -0600)]
Use dogfood_runner for deterministic test ordering