]>
git.lizzy.rs Git - rust.git/log
Esteban Küber [Fri, 9 Dec 2022 01:14:56 +0000 (17:14 -0800)]
Suggest `ref` for some patterns as a fallback
Esteban Küber [Thu, 8 Dec 2022 17:31:57 +0000 (09:31 -0800)]
Do not suggest borrowing binding in pattern in let else
Fix #104838.
Esteban Küber [Thu, 8 Dec 2022 17:02:54 +0000 (09:02 -0800)]
Change pattern borrowing suggestions to be verbose
Synthesize a more accurate span and use verbose suggestion output to
make the message clearer.
Michael Howell [Tue, 13 Dec 2022 18:00:34 +0000 (11:00 -0700)]
rustdoc: simplify popover CSS
* Merge the color-changing block into the regular rules, which was
probably written that way because it used to be in the theme files,
but has no reason to be written this way now that it's in rustdoc.css
* Get rid of redundant `display: block`, since `position: absolute`
blockifies the layout anyway.
Michael Goulet [Tue, 13 Dec 2022 17:54:52 +0000 (17:54 +0000)]
Address a few more nits
Michael Goulet [Tue, 13 Dec 2022 17:50:52 +0000 (09:50 -0800)]
Address nits
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
Michael Goulet [Tue, 6 Dec 2022 03:35:47 +0000 (03:35 +0000)]
Remove chalk lowering for AliasTy
Michael Goulet [Tue, 6 Dec 2022 03:30:58 +0000 (03:30 +0000)]
nit: docs
Michael Goulet [Tue, 6 Dec 2022 02:49:06 +0000 (02:49 +0000)]
Combine OfOpaque and OfProjection
Michael Goulet [Sun, 27 Nov 2022 17:52:17 +0000 (17:52 +0000)]
Combine identical alias arms
Michael Goulet [Sat, 26 Nov 2022 21:51:55 +0000 (21:51 +0000)]
Combine projection and opaque into alias
Michael Howell [Tue, 13 Dec 2022 17:46:27 +0000 (10:46 -0700)]
rustdoc: apply `pre-wrap` CSS to code-wrapped links
This is common syntax used for intra-doc links, so fixing it should help
with doc formatting.
Michael Goulet [Sat, 26 Nov 2022 21:32:01 +0000 (21:32 +0000)]
squash OpaqueTy and ProjectionTy into AliasTy
Michael Goulet [Sat, 26 Nov 2022 21:21:20 +0000 (21:21 +0000)]
ProjectionTy.item_def_id -> ProjectionTy.def_id
Michael Goulet [Sat, 26 Nov 2022 21:09:39 +0000 (21:09 +0000)]
Use ty::OpaqueTy everywhere
Michael Goulet [Sat, 26 Nov 2022 20:43:31 +0000 (20:43 +0000)]
make Opaque have one field: OpaqueTy
Andrew Pollack [Tue, 13 Dec 2022 17:26:12 +0000 (09:26 -0800)]
Adjust log line in `fuchsia-test-runner.py`
* Adjusting log line in `fuchsia-test-runner.py` to refer to self
akida31 [Tue, 13 Dec 2022 17:24:18 +0000 (18:24 +0100)]
fix tests
bjorn3 [Tue, 13 Dec 2022 17:23:52 +0000 (18:23 +0100)]
Rustup to rustc 1.68.0-nightly (
37d7de337 2022-12-12)
bjorn3 [Tue, 13 Dec 2022 17:18:47 +0000 (18:18 +0100)]
bors [Tue, 13 Dec 2022 15:50:16 +0000 (15:50 +0000)]
Auto merge of #105646 - lqd:revert-thinlto, r=Mark-Simulacrum
Revert "enable ThinLTO for rustc on x86_64-apple-darwin dist builds"
Apparently ThinLTO on x64 mac can regress some of the ICEs' output. This reverts #103647 to allow for investigation, and helps with #105637 in the meantime.
akida31 [Sun, 27 Nov 2022 19:58:01 +0000 (20:58 +0100)]
tidy: ignore filelength
akida31 [Sun, 13 Nov 2022 21:40:54 +0000 (22:40 +0100)]
reduce to single suggestion for all arguments
akida31 [Tue, 11 Oct 2022 15:48:46 +0000 (17:48 +0200)]
remove manual `fn_decl` extraction
akida31 [Tue, 11 Oct 2022 15:02:56 +0000 (17:02 +0200)]
change error message
akida31 [Tue, 11 Oct 2022 14:20:52 +0000 (16:20 +0200)]
move changes to an extra function
akida31 [Sun, 9 Oct 2022 08:07:47 +0000 (10:07 +0200)]
Remove `hint` from help message
akida31 [Sat, 8 Oct 2022 13:50:35 +0000 (15:50 +0200)]
Fix stderr of tests which have improved diagnostics
akida31 [Sat, 8 Oct 2022 13:48:28 +0000 (15:48 +0200)]
Improve diagnostic when passing arg to closure and missing borrow.
This checks the number of references for the given and expected type and
shows hints to the user if the numbers don't match.
bors [Tue, 13 Dec 2022 13:09:40 +0000 (13:09 +0000)]
Auto merge of #105612 - oli-obk:bind_rustdoc, r=GuillaumeGomez
use ty::Binder in rustdoc instead of `skip_binder`
r? `@GuillaumeGomez`
this is a preliminary cleanup required to be able to normalize correctly/conveniently in rustdoc
Santiago Pastorino [Mon, 12 Dec 2022 19:46:18 +0000 (16:46 -0300)]
Clarify explicit_predicates_of is_assoc_item_ty comment
Santiago Pastorino [Mon, 12 Dec 2022 19:46:54 +0000 (16:46 -0300)]
Make InternalSubsts rust docs a bit clearer
Jakob Degen [Tue, 13 Dec 2022 12:22:47 +0000 (04:22 -0800)]
Don't require owned data in `MaybeStorageLive`
tronta [Tue, 13 Dec 2022 12:18:08 +0000 (13:18 +0100)]
Update RELEASES.md
this is not yet supported:
..X => https://github.com/rust-lang/rust/issues/37854 is still open
Oli Scherer [Mon, 12 Dec 2022 17:32:20 +0000 (17:32 +0000)]
bless fulldeps tests
Oli Scherer [Mon, 12 Dec 2022 15:57:31 +0000 (15:57 +0000)]
Use a label instead of a note for the drop site to create denser diagnostics
Oli Scherer [Mon, 12 Dec 2022 15:36:08 +0000 (15:36 +0000)]
Stop pointing to operators if their libcore method source is not available
Oli Scherer [Mon, 12 Dec 2022 15:25:04 +0000 (15:25 +0000)]
Avoid rendering empty annotations
Oli Scherer [Mon, 12 Dec 2022 12:26:16 +0000 (12:26 +0000)]
Don't emit empty notes
Oli Scherer [Mon, 12 Dec 2022 12:07:09 +0000 (12:07 +0000)]
Clarify what "this" means
Oli Scherer [Mon, 12 Dec 2022 11:55:46 +0000 (11:55 +0000)]
Inform the user which trait is meant in the diagnostic itself instead of relying on the span making it obvious
Oli Scherer [Fri, 9 Dec 2022 15:56:23 +0000 (15:56 +0000)]
Make some diagnostics not depend on the source of what they reference being available
Guillaume Gomez [Tue, 13 Dec 2022 09:20:37 +0000 (10:20 +0100)]
Improve rustdoc markdown variable naming
bors [Tue, 13 Dec 2022 07:10:53 +0000 (07:10 +0000)]
Auto merge of #105350 - compiler-errors:faster-binder-relate, r=oli-obk
Fast-path some binder relations
A simpler approach than #104598
Fixes #104583
r? types
Michael Goulet [Thu, 8 Dec 2022 03:53:35 +0000 (03:53 +0000)]
Move some codegen-y methods from rustc_hir_analysis::collect -> rustc_codegen_ssa
Cassaundra Smith [Fri, 2 Dec 2022 03:17:03 +0000 (19:17 -0800)]
Refine when invalid prefix case error arises
Fix cases where the "invalid base prefix for number literal" error arises with
suffixes that look erroneously capitalized but which are in fact invalid.
bors [Tue, 13 Dec 2022 03:28:57 +0000 (03:28 +0000)]
Auto merge of #105436 - nnethercote:inline-place_contents_drop_state_cannot_differ, r=spastorino
Inline and remove `place_contents_drop_state_cannot_differ`.
It has a single call site and is hot enough to be worth inlining. And make sure `is_terminal_path` is inlined, too.
r? `@ghost`
Michael Goulet [Tue, 6 Dec 2022 04:42:06 +0000 (04:42 +0000)]
Fast path some binder relations
Gary Guo [Tue, 13 Dec 2022 02:34:43 +0000 (02:34 +0000)]
Extract shared logic into a new function
Gary Guo [Thu, 1 Dec 2022 23:54:06 +0000 (23:54 +0000)]
Add tests (currently broken) for unsafe + inline const pat
Gary Guo [Thu, 1 Dec 2022 23:51:03 +0000 (23:51 +0000)]
Remove unnecessary recursive call to parent unsafeck
All bodies are unsafe checked anyway. Current MIR unsafeck also just
returns for closures.
Gary Guo [Thu, 1 Dec 2022 23:41:45 +0000 (23:41 +0000)]
Ensure valid local_data is set for custom mir building
MIR unsafety checking requires this to be valid
Gary Guo [Thu, 1 Dec 2022 19:13:18 +0000 (19:13 +0000)]
Add tests
Gary Guo [Thu, 1 Dec 2022 19:05:49 +0000 (19:05 +0000)]
Allow unsafe through inline const for THIR unsafety checker
The closure handling code is changed slightly to avoid allocation
when THIR building failed.
Gary Guo [Thu, 1 Dec 2022 18:34:59 +0000 (18:34 +0000)]
Allow unsafe through inline const
This is handled similar to closures
Rémy Rakic [Tue, 13 Dec 2022 01:11:54 +0000 (01:11 +0000)]
Revert "enable ThinLTO for rustc on x86_64-apple-darwin dist builds"
This reverts commit
3a085f769545e5f3327d29460060520d59766ba7 .
bors [Tue, 13 Dec 2022 00:29:28 +0000 (00:29 +0000)]
Auto merge of #105644 - matthiaskrgr:rollup-qc6hlzq, r=matthiaskrgr
Rollup of 8 pull requests
Successful merges:
- #104864 (Account for item-local in inner scope for E0425)
- #105332 (Point out the type of associated types in every method call of iterator chains)
- #105620 (Remove unnecessary uses of `clone`)
- #105625 (minor code cleanups)
- #105629 (rustdoc: stop treating everything in a trait item as a method)
- #105636 (Add check for local-storage value when changing "display line numbers" settings)
- #105639 (rustdoc: remove `type="text/css" from stylesheet links)
- #105640 (Adjust miri to still be optional)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
Matthias Krüger [Tue, 13 Dec 2022 00:17:12 +0000 (01:17 +0100)]
Rollup merge of #105640 - lukas-code:miri-beta, r=Mark-Simulacrum
Adjust miri to still be optional
r? `@pietroalbini`
Matthias Krüger [Tue, 13 Dec 2022 00:17:12 +0000 (01:17 +0100)]
Rollup merge of #105639 - notriddle:notriddle/text-css, r=GuillaumeGomez
rustdoc: remove `type="text/css" from stylesheet links
MDN directly recommends this in <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link>, since "CSS is the only stylesheet language used on the web."
Like
07a243b2a46384235d7e2c08688978b7cf018973 , but a few places that were missed the first time.
Matthias Krüger [Tue, 13 Dec 2022 00:17:11 +0000 (01:17 +0100)]
Rollup merge of #105636 - GuillaumeGomez:extend-gui-test, r=notriddle
Add check for local-storage value when changing "display line numbers" settings
r? `@notriddle`
Matthias Krüger [Tue, 13 Dec 2022 00:17:11 +0000 (01:17 +0100)]
Rollup merge of #105629 - notriddle:notriddle/method-toggle-trait, r=GuillaumeGomez
rustdoc: stop treating everything in a trait item as a method
This was added in
0b9b4b70683db6ef707755f520f139eb7b92a944 to fix the spacing on trait pages, but stopped being needed because
791f04e5a47ee78951552c7ed1545b2b01a44c74 stopped styling method-toggle. By only putting the method-toggle class on actual methods, the JS setting does the right thing.
Matthias Krüger [Tue, 13 Dec 2022 00:17:10 +0000 (01:17 +0100)]
Rollup merge of #105625 - matthiaskrgr:clippy_dec12, r=compiler-errors
minor code cleanups
r? `@compiler-errors`
Matthias Krüger [Tue, 13 Dec 2022 00:17:10 +0000 (01:17 +0100)]
Rollup merge of #105620 - TaKO8Ki:remove-unnecessary-uses-of-clone, r=compiler-errors
Remove unnecessary uses of `clone`
Matthias Krüger [Tue, 13 Dec 2022 00:17:09 +0000 (01:17 +0100)]
Rollup merge of #105332 - estebank:iterator-chains, r=oli-obk
Point out the type of associated types in every method call of iterator chains
Partially address #105184 by pointing out the type of associated types in every method call of iterator chains:
```
note: the expression is of type `Map<std::slice::Iter<'_, {integer}>, [closure@src/test/ui/iterators/invalid-iterator-chain.rs:12:18: 12:21]>`
--> src/test/ui/iterators/invalid-iterator-chain.rs:12:14
|
10 | vec![0, 1]
| ---------- this expression has type `Vec<{integer}>`
11 | .iter()
| ------ associated type `std::iter::Iterator::Item` is `&{integer}` here
12 | .map(|x| { x; })
| ^^^^^^^^^^^^^^^ associated type `std::iter::Iterator::Item` is `()` here
```
We also reduce the number of impls we mention when any of the candidates is an "exact match". This benefits the output of cases with numerics greatly.
Outstanding work would be to provide a structured suggestion for appropriate changes, like in this case detecting the spurious `;` in the closure.
Matthias Krüger [Tue, 13 Dec 2022 00:17:08 +0000 (01:17 +0100)]
Rollup merge of #104864 - chenyukang:yukang/fix-104700-binding, r=estebank
Account for item-local in inner scope for E0425
Fixes #104700
Keith T. Star [Mon, 12 Dec 2022 23:22:01 +0000 (16:22 -0700)]
Minor grammar nit.
Mark Rousskov [Tue, 1 Nov 2022 00:52:55 +0000 (20:52 -0400)]
Adjust miri to still be optional
We don't distribute a miri build for beta/stable so it needs to be kept
optional. In the future it likely makes sense to switch the miri
*artifacts* to always be built, but the rustup component to not be
included -- this will avoid some of this pain.
Michael Howell [Mon, 12 Dec 2022 22:17:49 +0000 (15:17 -0700)]
rustdoc: remove `type="text/css" from stylesheet links
MDN directly recommends this in <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link>,
since "CSS is the only stylesheet language used on the web."
Like
07a243b2a46384235d7e2c08688978b7cf018973 , but a few places that were
missed the first time.
Guillaume Gomez [Mon, 12 Dec 2022 21:49:19 +0000 (22:49 +0100)]
Add check for local-storage value when changing "display line numbers" settings
bors [Mon, 12 Dec 2022 21:34:28 +0000 (21:34 +0000)]
Auto merge of #105622 - matthiaskrgr:rollup-a6i81q7, r=matthiaskrgr
Rollup of 8 pull requests
Successful merges:
- #104405 (1.66.0 release notes)
- #105561 (Normalize receiver substs and erase the regions)
- #105593 (Fix typo in comment: length_limit)
- #105597 (Correct typos in `core::sync::Exclusive::get_{pin_mut, mut}`)
- #105614 (delete mentions of type ascription from lint descriptions)
- #105615 (Fixup method doc that mentions removed param)
- #105616 (Add a "the" to proc_macro documentation)
- #105619 (rustdoc: remove no-op CSS `.source pre { overflow: auto }`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
Michael Goulet [Mon, 12 Dec 2022 18:29:33 +0000 (18:29 +0000)]
🚨 fix unsoundness in bootstrap cache code
Ralf Jung [Mon, 12 Dec 2022 08:49:42 +0000 (09:49 +0100)]
explain mem::forget(env_lock) in fork/exec
Esteban Küber [Mon, 12 Dec 2022 19:53:39 +0000 (11:53 -0800)]
Do not `skip_binder`s
Michael Howell [Mon, 12 Dec 2022 19:46:11 +0000 (12:46 -0700)]
rustdoc: stop treating everything in a trait item as a method
This was added in
0b9b4b70683db6ef707755f520f139eb7b92a944 to fix the
spacing on trait pages, but stopped being needed because
791f04e5a47ee78951552c7ed1545b2b01a44c74 stopped styling method-toggle.
By only putting the method-toggle class on actual methods, the JS setting
does the right thing.
Santiago Pastorino [Mon, 12 Dec 2022 19:44:39 +0000 (16:44 -0300)]
Join match arms since they do the same thing
Santiago Pastorino [Mon, 12 Dec 2022 19:43:38 +0000 (16:43 -0300)]
Fix typo
Matthias Krüger [Mon, 12 Dec 2022 18:49:53 +0000 (19:49 +0100)]
minor code cleanups
Matthias Krüger [Mon, 12 Dec 2022 18:20:38 +0000 (19:20 +0100)]
Rollup merge of #105619 - notriddle:notriddle/source-pre-overflow, r=GuillaumeGomez
rustdoc: remove no-op CSS `.source pre { overflow: auto }`
Since source pages use the `example-wrap` wrapper, this rule became redundant because there is already an `overflow-x: auto` rule.
Matthias Krüger [Mon, 12 Dec 2022 18:20:37 +0000 (19:20 +0100)]
Rollup merge of #105616 - est31:add_the, r=Dylan-DPC
Add a "the" to proc_macro documentation
Matthias Krüger [Mon, 12 Dec 2022 18:20:36 +0000 (19:20 +0100)]
Rollup merge of #105615 - WaffleLapkin:remove_opt_scope_span_mention, r=compiler-errors
Fixup method doc that mentions removed param
The param was removed in https://github.com/rust-lang/rust/pull/61872 (
101a2f59b490650c12c5f9e4561a7390bfce78d3 )
Matthias Krüger [Mon, 12 Dec 2022 18:20:36 +0000 (19:20 +0100)]
Rollup merge of #105614 - lukas-code:ascription, r=Nilstrieb
delete mentions of type ascription from lint descriptions
Tracking Issue: https://github.com/rust-lang/rust/issues/101728
Matthias Krüger [Mon, 12 Dec 2022 18:20:35 +0000 (19:20 +0100)]
Rollup merge of #105597 - albertlarsan68:patch-1, r=Dylan-DPC
Correct typos in `core::sync::Exclusive::get_{pin_mut, mut}`
Matthias Krüger [Mon, 12 Dec 2022 18:20:35 +0000 (19:20 +0100)]
Rollup merge of #105593 - jruderman:patch-3, r=Dylan-DPC
Fix typo in comment: length_limit
Matthias Krüger [Mon, 12 Dec 2022 18:20:34 +0000 (19:20 +0100)]
Rollup merge of #105561 - TaKO8Ki:fix-105449, r=fee1-dead
Normalize receiver substs and erase the regions
Fixes #105449
Matthias Krüger [Mon, 12 Dec 2022 18:20:33 +0000 (19:20 +0100)]
Rollup merge of #104405 - Mark-Simulacrum:relnotes, r=pietroalbini
1.66.0 release notes
r? ``@tmandry`` ``@rust-lang/release``
Esteban Küber [Mon, 12 Dec 2022 17:13:27 +0000 (09:13 -0800)]
Move logic to their own methods
Takayuki Maeda [Mon, 12 Dec 2022 17:06:24 +0000 (02:06 +0900)]
remove unnecessary uses of `clone`
Michael Howell [Mon, 12 Dec 2022 16:56:15 +0000 (09:56 -0700)]
rustdoc: remove no-op CSS `.source pre { overflow: auto }`
Since source pages use the `example-wrap` wrapper, this rule became
redundant because there is already an `overflow-x: auto` rule.
Lukas Markeffsky [Mon, 12 Dec 2022 15:10:22 +0000 (16:10 +0100)]
delete mentions of type ascription from lint descriptions
Move it to the historical context section instead.
Maybe Waffle [Mon, 12 Dec 2022 15:43:04 +0000 (15:43 +0000)]
Fixup method doc that mentions removed param
est31 [Mon, 12 Dec 2022 15:18:44 +0000 (16:18 +0100)]
Add a "the" to proc_macro documentation
Boxy [Mon, 12 Dec 2022 14:41:34 +0000 (14:41 +0000)]
what is `unstable_features` lol
Oli Scherer [Mon, 12 Dec 2022 14:39:08 +0000 (14:39 +0000)]
Avoid trying to normalize unnormalizable types
Boxy [Mon, 12 Dec 2022 14:28:08 +0000 (14:28 +0000)]
fold instead of obliterating args
Oli Scherer [Mon, 12 Dec 2022 13:20:36 +0000 (13:20 +0000)]
Round 3: require binders for substs
Takayuki Maeda [Mon, 12 Dec 2022 13:11:33 +0000 (22:11 +0900)]
normalize receiver substs and erase the regions
use a smaller example
Mark Rousskov [Mon, 14 Nov 2022 14:55:10 +0000 (09:55 -0500)]
1.66.0 release notes
Oli Scherer [Mon, 12 Dec 2022 12:55:47 +0000 (12:55 +0000)]
Round 2: make clean_middle_ty take a binder
Oli Scherer [Mon, 12 Dec 2022 12:12:40 +0000 (12:12 +0000)]
Round 1: add some binders (fails due to losing bound vars and then rebinding them with `Binder::dummy`)
bors [Mon, 12 Dec 2022 10:38:31 +0000 (10:38 +0000)]
Auto merge of #105252 - bjorn3:codegen_less_pair_values, r=nagisa
Use struct types during codegen in less places
This makes it easier to use cg_ssa from a backend like Cranelift that doesn't have any struct types at all. After this PR struct types are still used for function arguments and return values. Removing those usages is harder but should still be doable.