]>
git.lizzy.rs Git - rust.git/log
Aleksey Kladov [Mon, 14 Jun 2021 16:15:53 +0000 (19:15 +0300)]
minor: less ambiguous name
Aleksey Kladov [Mon, 14 Jun 2021 16:14:34 +0000 (19:14 +0300)]
internal: flatten module hierarchy
It seems that any crate can be made better by flattening the modules
down to a single layer?
Aleksey Kladov [Mon, 14 Jun 2021 16:08:12 +0000 (19:08 +0300)]
internal: document rename challenges
Aleksey Kladov [Mon, 14 Jun 2021 15:46:27 +0000 (18:46 +0300)]
internal: adapt diagnostics to the new rename API
Aleksey Kladov [Mon, 14 Jun 2021 10:27:11 +0000 (13:27 +0300)]
internal: cut deps between assists and diagnostics
Aleksey Kladov [Mon, 14 Jun 2021 10:18:03 +0000 (13:18 +0300)]
internal: prepare to move assist definitions
Aleksey Kladov [Mon, 14 Jun 2021 10:15:05 +0000 (13:15 +0300)]
internal: move diagnostics to a new crate
Aleksey Kladov [Mon, 14 Jun 2021 09:24:58 +0000 (12:24 +0300)]
internal: start ide diagnostics crate
bors[bot] [Mon, 14 Jun 2021 14:30:59 +0000 (14:30 +0000)]
Merge #9265
9265: internal: prepare to move rename to base_db r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 14 Jun 2021 14:19:41 +0000 (17:19 +0300)]
internal: prepare to move rename to base_db
It's better to handle magical cases upper in the stack, because it
allows for better re-use of the general implementation below. So, we
pull the `self` case up here.
The end goal is to put `Definition::rename` to the `ide_db`, because
it's a generally re-usable functionality useful for different ide
features, alongside with the search which is already there.
bors[bot] [Mon, 14 Jun 2021 12:46:38 +0000 (12:46 +0000)]
Merge #9263
9263: fix: don't use display-related functionality where semantics matters r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 14 Jun 2021 12:43:59 +0000 (15:43 +0300)]
fix: don't use display-related functionality where semantics matters
NavigationTarget is strictly a UI-level thing -- it describes where the
cursor should be placed when the user presses goto definition. It
doesn't make any semantic guaratees about rage and focus range and, as
such, is not suitable for driving renames.
bors[bot] [Mon, 14 Jun 2021 11:57:20 +0000 (11:57 +0000)]
Merge #9262
9262: fix: Don't keep a trailing `self` token in import paths after `unmerge_use` r=Veykril a=Veykril
Fixes #9213
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 14 Jun 2021 11:56:33 +0000 (13:56 +0200)]
Don't keep a trailing self token in import paths after unmerge_use
bors[bot] [Mon, 14 Jun 2021 10:30:10 +0000 (10:30 +0000)]
Merge #8951
8951: internal: migrate to vscode.FileSystem API r=matklad a=wxb1ank
I encountered an error where `bootstrap()` attempts to create a directory with the path `C:\C:\...`. I couldn't find this reported anywhere else. Using the `vscode.FileSystem` API instead of the `fs` one works here. I assume the latter automatically prepends `C:\` to paths whereas the former does not. I don't know if this suggests `vscode.FileSystem` should be used in more places for consistency.
Co-authored-by: wxb1ank <wxblank@gmail.com>
bors[bot] [Mon, 14 Jun 2021 07:40:45 +0000 (07:40 +0000)]
Merge #9261
9261: minor: dev/architecture.md: Fix typo in env-var quoting r=lnicola a=lf-
Co-authored-by: Jade <software@lfcode.ca>
Jade [Mon, 14 Jun 2021 07:38:28 +0000 (00:38 -0700)]
Fix typo in env-var quoting
bors[bot] [Mon, 14 Jun 2021 07:16:48 +0000 (07:16 +0000)]
Merge #9260
9260: tree-wide: make rustdoc links spiky so they are clickable r=matklad a=lf-
Rustdoc was complaining about these while I was running with --document-private-items and I figure they should be fixed.
Co-authored-by: Jade <software@lfcode.ca>
Jade [Mon, 14 Jun 2021 04:57:10 +0000 (21:57 -0700)]
tree-wide: make rustdoc links spiky so they are clickable
bors[bot] [Sun, 13 Jun 2021 19:17:57 +0000 (19:17 +0000)]
Merge #9257
9257: internal: diagnostic code is mandatory r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 19:17:05 +0000 (22:17 +0300)]
internal: diagnostic code is mandatory
Aleksey Kladov [Sun, 13 Jun 2021 19:11:33 +0000 (22:11 +0300)]
minor: dead code
bors[bot] [Sun, 13 Jun 2021 19:06:18 +0000 (19:06 +0000)]
Merge #9256
9256: internal: kill diagnostic sink r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 19:05:47 +0000 (22:05 +0300)]
internal: kill diagnostic sink
Aleksey Kladov [Sun, 13 Jun 2021 18:55:51 +0000 (21:55 +0300)]
internal: use cov-mark rather than bailing out diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 18:44:31 +0000 (21:44 +0300)]
internal: refactor missing match arms diagnostics
bors[bot] [Sun, 13 Jun 2021 18:34:32 +0000 (18:34 +0000)]
Merge #9255
9255: internal: remove DiagnosticWithFix infra r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 18:33:54 +0000 (21:33 +0300)]
internal: remove DiagnosticWithFix infra
Aleksey Kladov [Sun, 13 Jun 2021 18:09:03 +0000 (21:09 +0300)]
internal: refactor incorrect case diagnostics
bors[bot] [Sun, 13 Jun 2021 17:35:03 +0000 (17:35 +0000)]
Merge #9253
9253: internal: refactor missing or or some diagnostic r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 17:33:59 +0000 (20:33 +0300)]
minor
Aleksey Kladov [Sun, 13 Jun 2021 17:32:54 +0000 (20:32 +0300)]
internal: refactor find_map diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 17:20:58 +0000 (20:20 +0300)]
minor
Aleksey Kladov [Sun, 13 Jun 2021 17:19:11 +0000 (20:19 +0300)]
internal: refactor missing or or some diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 17:13:15 +0000 (20:13 +0300)]
internal: refactor remove this semicolon diagnostics
bors[bot] [Sun, 13 Jun 2021 17:07:04 +0000 (17:07 +0000)]
Merge #9252
9252: internal: refactor mismatched args count diagnostic r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 17:06:25 +0000 (20:06 +0300)]
internal: refactor mismatched args count diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 17:00:27 +0000 (20:00 +0300)]
internal: refactor missing unsafe diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 16:51:19 +0000 (19:51 +0300)]
internal: refactor BreakOutsideOfLoop diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 16:45:16 +0000 (19:45 +0300)]
internal: refactor NoSuchField diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 16:35:30 +0000 (19:35 +0300)]
internal: refactor unimplemented builtin macro diagnostic
bors[bot] [Sun, 13 Jun 2021 16:33:03 +0000 (16:33 +0000)]
Merge #9251
9251: minor: simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 16:27:14 +0000 (19:27 +0300)]
minor: simplify
bors[bot] [Sun, 13 Jun 2021 16:24:35 +0000 (16:24 +0000)]
Merge #9250
9250: internal: check diagnostics in all files and not just the first one r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 16:23:37 +0000 (19:23 +0300)]
internal: check diagnostics in all files and not just the first one
bors[bot] [Sun, 13 Jun 2021 15:46:09 +0000 (15:46 +0000)]
Merge #9249
9249: internal: remove def-level diagnostics tests r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 15:45:38 +0000 (18:45 +0300)]
internal: remove def-level diagnostics tests
Aleksey Kladov [Sun, 13 Jun 2021 15:41:04 +0000 (18:41 +0300)]
internal: refactor macro error
Aleksey Kladov [Sun, 13 Jun 2021 14:51:44 +0000 (17:51 +0300)]
internal: refactor unresolved proc macro diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 14:29:25 +0000 (17:29 +0300)]
internal: refactor inactive code diagnostics
bors[bot] [Sun, 13 Jun 2021 14:09:41 +0000 (14:09 +0000)]
Merge #9248
9248: internal: refactor unresolved macro call diagnostic r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 14:06:36 +0000 (17:06 +0300)]
internal: refactor unresolved macro call diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 13:42:34 +0000 (16:42 +0300)]
internal: refactor unresolved import diagnostic
bors[bot] [Sun, 13 Jun 2021 13:06:27 +0000 (13:06 +0000)]
Merge #9247
9247: internal: refactor unresolved extern crate diagnostic r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 13:05:43 +0000 (16:05 +0300)]
internal: refactor unresolved extern crate diagnostic
bors[bot] [Sun, 13 Jun 2021 12:49:37 +0000 (12:49 +0000)]
Merge #9246
9246: internal: unified missing fields diagnostic r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 12:48:54 +0000 (15:48 +0300)]
internal: unified missing fields diagnostic
Aleksey Kladov [Sun, 13 Jun 2021 12:27:15 +0000 (15:27 +0300)]
internal: move missing_fields diagnostics
bors[bot] [Sun, 13 Jun 2021 11:56:15 +0000 (11:56 +0000)]
Merge #9245
9245: internal: start new diagnostics API r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 11:41:19 +0000 (14:41 +0300)]
internal: start new diagnostics API
At the moment, this moves only a single diagnostic, but the idea is
reafactor the rest to use the same pattern. We are going to have a
single file per diagnostic. This file will define diagnostics code,
rendering range and fixes, if any. It'll also have all of the tests.
This is similar to how we deal with assists.
After we refactor all diagnostics to follow this pattern, we'll probably
move them to a new `ide_diagnostics` crate.
Not that we intentionally want to test all diagnostics on this layer,
despite the fact that they are generally emitted in the guts on the
compiler. Diagnostics care to much about the end presentation
details/fixes to be worth-while "unit" testing. So, we'll unit-test only
the primary output of compilation process (types and name res tables),
and will use integrated UI tests for diagnostics.
bors[bot] [Sun, 13 Jun 2021 11:13:31 +0000 (11:13 +0000)]
Merge #9244
9244: feat: Make block-local trait impls work r=flodiebold a=flodiebold
As long as either the trait or the implementing type are defined in the same block.
CC #8961
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Florian Diebold [Sun, 13 Jun 2021 11:00:34 +0000 (13:00 +0200)]
Make block-local trait impls work
As long as either the trait or the implementing type are defined in the
same block.
bors[bot] [Sun, 13 Jun 2021 10:13:56 +0000 (10:13 +0000)]
Merge #9243
9243: internal: check that coverage marks are always paired r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sun, 13 Jun 2021 09:33:08 +0000 (12:33 +0300)]
internal: check that coverage marks are always paired
Aleksey Kladov [Sun, 13 Jun 2021 08:49:32 +0000 (11:49 +0300)]
minor: put a mark back
bors[bot] [Sun, 13 Jun 2021 07:18:49 +0000 (07:18 +0000)]
Merge #9242
9242: Clippy r=matklad a=Maan2003
Best viewed commit wise
Co-authored-by: Maan2003 <manmeetmann2003@gmail.com>
bors[bot] [Sun, 13 Jun 2021 06:58:37 +0000 (06:58 +0000)]
Merge #9240
9240: Fixed a small typo in comment r=matklad a=fee1-dead
Co-authored-by: fee1-dead <ent3rm4n@gmail.com>
Maan2003 [Sun, 13 Jun 2021 04:18:15 +0000 (09:48 +0530)]
cargo fmt
Maan2003 [Sun, 13 Jun 2021 04:10:22 +0000 (09:40 +0530)]
clippy::redundant_field_names
Maan2003 [Sun, 13 Jun 2021 04:07:28 +0000 (09:37 +0530)]
clippy::manual_str_repeat
Maan2003 [Sun, 13 Jun 2021 04:05:29 +0000 (09:35 +0530)]
clippy::useless_return
Maan2003 [Sun, 13 Jun 2021 03:59:36 +0000 (09:29 +0530)]
clippy::redundant_closure
Maan2003 [Sun, 13 Jun 2021 03:57:19 +0000 (09:27 +0530)]
clippy::clone_on_copy
Maan2003 [Sun, 13 Jun 2021 03:55:55 +0000 (09:25 +0530)]
clippy::useless_conversion
Maan2003 [Sun, 13 Jun 2021 03:54:16 +0000 (09:24 +0530)]
clippy::redudant_borrow
bors[bot] [Sat, 12 Jun 2021 21:05:12 +0000 (21:05 +0000)]
Merge #9239
9239: fix: Fix coercion in match with expected type r=flodiebold a=flodiebold
Plus add infrastructure to test type mismatches without expect.
CC #8961
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Florian Diebold [Thu, 3 Jun 2021 21:12:35 +0000 (23:12 +0200)]
Fix coercion in match with expected type
Plus add infrastructure to test type mismatches without expect.
bors[bot] [Sat, 12 Jun 2021 20:42:46 +0000 (20:42 +0000)]
Merge #9238
9238: internal: cross-crate cov-marks r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 12 Jun 2021 20:39:57 +0000 (23:39 +0300)]
internal: cross-crate cov-marks
bors[bot] [Sat, 12 Jun 2021 19:05:58 +0000 (19:05 +0000)]
Merge #9237
9237: internal: move diagnostics infra to hir r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 12 Jun 2021 19:05:23 +0000 (22:05 +0300)]
internal: move diagnostics infra to hir
bors[bot] [Sat, 12 Jun 2021 18:51:42 +0000 (18:51 +0000)]
Merge #9236
9236: Fix some typos in flyimport docs r=SomeoneToIgnore a=SomeoneToIgnore
bors r+
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
Kirill Bulatov [Sat, 12 Jun 2021 18:51:09 +0000 (21:51 +0300)]
Fix some typos in flyimport docs
bors[bot] [Sat, 12 Jun 2021 18:01:00 +0000 (18:01 +0000)]
Merge #9233
9233: Move some hir_ty diagnostics to hir r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 12 Jun 2021 16:28:19 +0000 (19:28 +0300)]
Move some hir_ty diagnostics to hir
bors[bot] [Sat, 12 Jun 2021 14:50:37 +0000 (14:50 +0000)]
Merge #9231
9231: minor: optimize r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 12 Jun 2021 14:49:41 +0000 (17:49 +0300)]
minor: optimize
We shouldn't be looking at the source map unless we actually have
diagnostics.
Aleksey Kladov [Sat, 12 Jun 2021 14:41:25 +0000 (17:41 +0300)]
minor: reduce visibility
bors[bot] [Sat, 12 Jun 2021 14:40:28 +0000 (14:40 +0000)]
Merge #9230
9230: internal: move inference diagnostics to hir r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 12 Jun 2021 14:39:46 +0000 (17:39 +0300)]
internal: move missing unsafe diagnostic to hir
Aleksey Kladov [Sat, 12 Jun 2021 14:17:23 +0000 (17:17 +0300)]
internal: move inference diagnostics to hir
bors[bot] [Sat, 12 Jun 2021 12:56:58 +0000 (12:56 +0000)]
Merge #9229
9229: minor: squelch "unused" warning r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 12 Jun 2021 12:10:07 +0000 (15:10 +0300)]
minor: squelch "unused" warning
bors[bot] [Fri, 11 Jun 2021 22:00:23 +0000 (22:00 +0000)]
Merge #9204
9204: feat: more accurate memory usage info on glibc Linux r=jonas-schievink a=jonas-schievink
This adds support for the new `mallinfo2` API added in glibc 2.33. It addresses a shortcoming in the `mallinfo` API where it was unable to handle memory usage of more than 2 GB, which we sometimes exceed.
Blocked on https://github.com/rust-lang/libc/pull/2228
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Jonas Schievink [Fri, 11 Jun 2021 21:55:27 +0000 (23:55 +0200)]
Update libc
bors[bot] [Fri, 11 Jun 2021 21:13:28 +0000 (21:13 +0000)]
Merge #9223
9223: Complete associated types in dyn and impl trait r=Veykril a=Veykril
Fixes #9222
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 11 Jun 2021 21:12:30 +0000 (23:12 +0200)]
Complete associated types in dyn and impl trait
bors[bot] [Fri, 11 Jun 2021 19:20:24 +0000 (19:20 +0000)]
Merge #9221
9221: fix: Highlight tuple field accesses correctly r=Veykril a=Veykril
Fixes #9220
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Fri, 11 Jun 2021 19:19:19 +0000 (21:19 +0200)]
Highlight tuple field accesses correctly
bors[bot] [Fri, 11 Jun 2021 17:56:00 +0000 (17:56 +0000)]
Merge #9219
9219: minor: Replace some AssocItem::containing_trait calls trait_or_trait_impl r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>