]>
git.lizzy.rs Git - rust.git/log
Cristian Kubis [Mon, 2 Sep 2019 12:15:52 +0000 (14:15 +0200)]
Add more UI tests for swap
These tests make sure that the swap warning will not be triggered
for expressions that will cause multiple mutable references of the
same owner
Cristian Kubis [Sat, 31 Aug 2019 16:50:22 +0000 (18:50 +0200)]
Fix incorrect swap suggestion
Clippy suggests using swap on fields belonging to the same owner
causing two mutable borrows of the owner
Fixes #981
Signed-off-by: Cristian Kubis <cristian.kubis@tsunix.de>
bors [Fri, 30 Aug 2019 20:30:53 +0000 (20:30 +0000)]
Auto merge of #4473 - phansch:fix_cast_lossless_fp, r=flip1995
Fix cast_lossless false positive in impl const fn
Fixes https://github.com/rust-lang/rust-clippy/issues/3656#issuecomment-
526387382
changelog: Fix false positive in `cast_lossless`
bors [Fri, 30 Aug 2019 08:12:11 +0000 (08:12 +0000)]
Auto merge of #4475 - flip1995:rustup, r=phansch
Rustup to rust-lang/rust#60966
changelog: none
flip1995 [Fri, 30 Aug 2019 07:33:03 +0000 (09:33 +0200)]
Rustup to rust-lang/rust#60966
bors [Fri, 30 Aug 2019 06:07:41 +0000 (06:07 +0000)]
Auto merge of #4446 - mikerite:fix-4437, r=phansch
Fix `match_as_ref` bad suggestion
Fixes #4437
changelog: Fix `match_as_ref` bad suggestion
Philipp Hansch [Fri, 30 Aug 2019 05:22:35 +0000 (07:22 +0200)]
Fix cast_lossless false positive in impl const fn
Fixes https://github.com/rust-lang/rust-clippy/issues/3656#issuecomment-
526387382
bors [Thu, 29 Aug 2019 17:24:21 +0000 (17:24 +0000)]
Auto merge of #4450 - phansch:fix_const_fn_fp, r=flip1995
Fix missing_const_for_fn false positive
We don't want to lint if the type of the method implements drop.
(constant functions cannot evaluate destructors)
changelog: Fix `missing_const_for_fn` false positive
Fixes #4449
Philipp Hansch [Thu, 29 Aug 2019 16:37:43 +0000 (18:37 +0200)]
Add missing UI test change
bors [Thu, 29 Aug 2019 10:48:14 +0000 (10:48 +0000)]
Auto merge of #4408 - phansch:more_rustfix_tests, r=flip1995
More rustfix tests
<!--
Thank you for making Clippy better!
We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.
If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `./util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `./util/dev fmt`
[lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Delete this line and everything above before opening your PR -->
cc #3630
This is probably easier reviewed per-commit.
changelog: none
bors [Thu, 29 Aug 2019 10:19:26 +0000 (10:19 +0000)]
Auto merge of #4469 - vityafx:master, r=flip1995
Improve the cognitive_complexity lint's warning.
Adds the value of complexity limit set for the lint
to the warning.
Fixes #4466
Signed-off-by: Victor Polevoy <fx@thefx.co>
changelog: improve the `cognitive_complexity` lint's warning message.
Victor Polevoy [Thu, 29 Aug 2019 08:56:13 +0000 (10:56 +0200)]
Improve cognitive_complexity lint's warning.
Adds the value of complexity limit set for the lint
to the warning.
Fixes #4466
Signed-off-by: Victor Polevoy <fx@thefx.co>
Michael Wright [Thu, 29 Aug 2019 06:17:36 +0000 (08:17 +0200)]
Merge branch 'master' into fix-4437
Philipp Hansch [Sun, 25 Aug 2019 13:44:22 +0000 (15:44 +0200)]
Fix missing_const_for_fn false positive
We don't want to lint if any of the input parameters implement drop.
(constant functions cannot evaluate destructors)
Philipp Hansch [Wed, 28 Aug 2019 19:17:12 +0000 (21:17 +0200)]
Make useless_attribute suggestion MaybeIncorrect
bors [Wed, 28 Aug 2019 16:09:08 +0000 (16:09 +0000)]
Auto merge of #4465 - JohnTitor:add-note-to-fix-toolstate, r=flip1995
Add note to fix toolstate
The idea from https://github.com/rust-lang/rust-clippy/pull/4462#issuecomment-
525725587
It's nice that we have the documentation to guide fix toolstate.
changelog: none
Yuki Okushi [Wed, 28 Aug 2019 12:46:04 +0000 (21:46 +0900)]
Add note to fix toolstate
bors [Wed, 28 Aug 2019 12:37:29 +0000 (12:37 +0000)]
Auto merge of #4464 - flip1995:fetch_prs_between, r=phansch
Also fetch rollup merges in fetch_prs_between.sh script
Otherwise rolled up PRs won't be included in the changelog, e.g.
236666138fa15fdd48b1c12180b2c9dc936441b4
changelog: none
flip1995 [Wed, 28 Aug 2019 11:53:56 +0000 (13:53 +0200)]
Also fetch rollup merges in fetch_prs_between.sh script
bors [Wed, 28 Aug 2019 11:11:43 +0000 (11:11 +0000)]
Auto merge of #4463 - flip1995:rollup-240kr2c, r=flip1995
Rollup of 2 pull requests
Successful merges:
- #4459 (Add note to avoid confusing)
- #4460 (Fix `inherent_to_string` false positive)
Failed merges:
r? @ghost
changelog: none
Philipp Krones [Wed, 28 Aug 2019 11:00:52 +0000 (13:00 +0200)]
Rollup merge of #4460 - JohnTitor:fix-inherent-to-string, r=flip1995
Fix `inherent_to_string` false positive
Fixes #4457
changelog: fixes `inherent_to_string` false positive
Philipp Krones [Wed, 28 Aug 2019 11:00:51 +0000 (13:00 +0200)]
Rollup merge of #4459 - JohnTitor:update-testing-notes, r=flip1995
Add note to avoid confusing
Fixes #4456
changelog: none
bors [Wed, 28 Aug 2019 10:28:30 +0000 (10:28 +0000)]
Auto merge of #4462 - JohnTitor:fix-build-arg, r=flip1995
Replace `Arg` with `Param`
Fix build issue.
Rustup to https://github.com/rust-lang/rust/pull/63127
changelog: none
Yuki Okushi [Wed, 28 Aug 2019 09:27:06 +0000 (18:27 +0900)]
Replace `Arg` with `Param`
Philipp Hansch [Wed, 28 Aug 2019 05:29:30 +0000 (07:29 +0200)]
Update int_plus_one suggestion text
This is now in line with the recommendations from here:
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/struct.Diagnostic.html#method.span_suggestion
Philipp Hansch [Mon, 19 Aug 2019 06:00:39 +0000 (08:00 +0200)]
Change float_cmp Applicability to `HasPlaceholders`
The suggestion includes an 'errors' placeholder currently, so it's not
`MachineApplicable`
Philipp Hansch [Sun, 18 Aug 2019 07:37:12 +0000 (09:37 +0200)]
Add run-rustfix for rename test
I removed the `Bar` static and `Foo` impl because they are not needed
for what's tested here as far as I can tell.
Philipp Hansch [Sun, 18 Aug 2019 07:32:38 +0000 (09:32 +0200)]
Add run-rustfix for outer_expn_data
Philipp Hansch [Sun, 18 Aug 2019 07:27:09 +0000 (09:27 +0200)]
Add run-rustfix for useless_attribute test
Philipp Hansch [Sun, 18 Aug 2019 07:24:30 +0000 (09:24 +0200)]
Add run-rustfix for int_plus_one test
Philipp Hansch [Sun, 18 Aug 2019 07:22:49 +0000 (09:22 +0200)]
Add run-rustfix for assign_ops test
Yuki Okushi [Tue, 27 Aug 2019 19:23:26 +0000 (04:23 +0900)]
Fix `inherent_to_string` false positive
Yuki Okushi [Tue, 27 Aug 2019 17:54:03 +0000 (02:54 +0900)]
Add note to avoid confusing
bors [Mon, 26 Aug 2019 14:32:12 +0000 (14:32 +0000)]
Auto merge of #4444 - phansch:split_up_cmp_owned2, r=flip1995
Split up cmp_owned tests, add run-rustfix
Some of the cmp_owned tests emitted non-machine-applicable suggestions,
so I moved them to `tests/ui/cmp_owned/without_suggestion.rs` and added
`// run-rustfix` to the other half.
changelog: none
cc #3630
bors [Mon, 26 Aug 2019 13:29:01 +0000 (13:29 +0000)]
Auto merge of #4445 - phansch:fix_unused_unit_sugg, r=flip1995
Fix unused_unit false positive
changelog: Fix `unused_unit` false positive
For some reason the `expr` of `stmt.node` didn't contain the expansion information, but the `stmt.span` does.
Fixes #4076
Philipp Hansch [Mon, 26 Aug 2019 13:28:35 +0000 (15:28 +0200)]
Use correct path in comment
Co-Authored-By: Philipp Krones <hello@philkrones.com>
bors [Mon, 26 Aug 2019 12:46:00 +0000 (12:46 +0000)]
Auto merge of #4430 - lzutao:defid_trait_alias, r=flip1995
Account for trait alias when looking for defid
I hit the crash on the `expect` call when running clippy on rustc libcore.
Hopefully this will fix it.
changelog: none
Lzu Tao [Mon, 26 Aug 2019 10:11:47 +0000 (17:11 +0700)]
Add regression test for looking for trait defid in nocore
bors [Mon, 26 Aug 2019 11:11:57 +0000 (11:11 +0000)]
Auto merge of #4436 - BO41:written_as, r=phansch
Add some "could be written as" examples
fixes #4405
changelog: none
bors [Mon, 26 Aug 2019 10:32:24 +0000 (10:32 +0000)]
Auto merge of #4421 - lzutao:unsep_literal, r=flip1995
Cleaner code for unsep literals
Continuing discussion in https://github.com/rust-lang/rust-clippy/pull/4401#issuecomment-
522498754
changelog: none
r? @flip1995
bors [Mon, 26 Aug 2019 09:53:34 +0000 (09:53 +0000)]
Auto merge of #4451 - hvenev:non-exec, r=flip1995
Mark rust source file as non-executable.
It would be nice if you can backport this to beta as well.
changelog: none
bors [Mon, 26 Aug 2019 09:15:20 +0000 (09:15 +0000)]
Auto merge of #4431 - phansch:more_rustfix, r=flip1995
Add 3 more run-rustfix headers
changelog: none
cc #3630
Lzu Tao [Mon, 26 Aug 2019 09:11:43 +0000 (16:11 +0700)]
Cleaner code for unsep literals
flip1995 [Mon, 26 Aug 2019 08:06:24 +0000 (10:06 +0200)]
Remove empty *.std{err,out} files
Hristo Venev [Sun, 25 Aug 2019 17:49:45 +0000 (17:49 +0000)]
Mark rust source file as non-executable.
Lzu Tao [Thu, 22 Aug 2019 03:03:26 +0000 (10:03 +0700)]
Account for trait alias when looking for defid
bors [Sun, 25 Aug 2019 06:25:35 +0000 (06:25 +0000)]
Auto merge of #4447 - phansch:fix_build, r=matthiaskrgr
Rustup to https://github.com/rust-lang/rust/pull/63854
changelog: none
Philipp Hansch [Sun, 25 Aug 2019 06:06:32 +0000 (08:06 +0200)]
Rustup to https://github.com/rust-lang/rust/pull/63854
Michael Wright [Sun, 25 Aug 2019 05:10:45 +0000 (07:10 +0200)]
Fix `match_as_ref` bad suggestion
Fixes #4437
Philipp Hansch [Sat, 24 Aug 2019 19:42:39 +0000 (21:42 +0200)]
Fix unused_unit false positive
Fixes #4076
BO41 [Sat, 24 Aug 2019 09:34:40 +0000 (11:34 +0200)]
Fix lint doc
Philipp Hansch [Sat, 24 Aug 2019 07:23:06 +0000 (09:23 +0200)]
Split up cmp_owned tests, add run-rustfix
Some of the cmp_owned tests emitted non-machine-applicable suggestions,
so I moved them to `tests/ui/cmp_owned/without_suggestion.rs` and added
`// run-rustfix` to the other half.
cc #3630
bors [Sat, 24 Aug 2019 07:45:29 +0000 (07:45 +0000)]
Auto merge of #4443 - jeremystucki:methods-refactoring, r=phansch
Small refactoring of methods/mod.rs
changelog: none
Jeremy Stucki [Fri, 23 Aug 2019 20:52:04 +0000 (22:52 +0200)]
Refactor some minor things
Jeremy Stucki [Fri, 23 Aug 2019 20:51:44 +0000 (22:51 +0200)]
Use more if-chains
Jeremy Stucki [Fri, 23 Aug 2019 20:31:22 +0000 (22:31 +0200)]
Refactor 'lint_or_fun_call'
Jeremy Stucki [Fri, 23 Aug 2019 12:36:00 +0000 (14:36 +0200)]
Refactor 'check_unwrap_or_default'
Jeremy Stucki [Fri, 23 Aug 2019 12:20:55 +0000 (14:20 +0200)]
Refactor 'check_impl_item'
bors [Fri, 23 Aug 2019 11:51:50 +0000 (11:51 +0000)]
Auto merge of #4409 - jeremystucki:export, r=phansch
[Doc] Ignore lines starting with #
Resolves #4353
changelog: none
bors [Fri, 23 Aug 2019 11:12:04 +0000 (11:12 +0000)]
Auto merge of #4438 - lzutao:author-litstr-missing, r=phansch
Add missing field to LitKind::Str
changelog: none
Lzu Tao [Fri, 23 Aug 2019 01:28:44 +0000 (08:28 +0700)]
Add missing field to LitKind::Str
bors [Fri, 23 Aug 2019 10:23:52 +0000 (10:23 +0000)]
Auto merge of #4439 - lzutao:fix-format, r=phansch
Re-factor format lint
cc #4432
changelog: none
Lzu Tao [Fri, 23 Aug 2019 09:49:49 +0000 (09:49 +0000)]
Run update_lints for Unicode lint
Lzu Tao [Fri, 23 Aug 2019 08:46:23 +0000 (15:46 +0700)]
Re-add false positive check
Lzu Tao [Fri, 23 Aug 2019 08:01:41 +0000 (08:01 +0000)]
Add raw string regression test for useless_format lint
Lzu Tao [Fri, 23 Aug 2019 05:26:24 +0000 (12:26 +0700)]
Re-factor useless_format lint
Philipp Hansch [Fri, 23 Aug 2019 07:39:11 +0000 (09:39 +0200)]
Merge pull request #4440 from lzutao/fix-unicode
Update Unicode lint tests
Lzu Tao [Fri, 23 Aug 2019 05:42:45 +0000 (05:42 +0000)]
Update Unicode lint tests
BO41 [Tue, 20 Aug 2019 14:55:17 +0000 (16:55 +0200)]
Add examples to some complexity lints
BO41 [Tue, 20 Aug 2019 14:23:53 +0000 (16:23 +0200)]
Add example to a perf lint
BO41 [Sun, 18 Aug 2019 19:37:47 +0000 (21:37 +0200)]
Add examples to some correctness lints
Philipp Hansch [Thu, 22 Aug 2019 05:47:30 +0000 (07:47 +0200)]
Add run-rustfix for range_plus_minus_one tests
Philipp Hansch [Thu, 22 Aug 2019 05:41:00 +0000 (07:41 +0200)]
Add run-rustfix for or_fun_call tests
Philipp Hansch [Thu, 22 Aug 2019 05:18:08 +0000 (07:18 +0200)]
Add run-rustfix for short_circuit_statement test
bors [Wed, 21 Aug 2019 08:46:10 +0000 (08:46 +0000)]
Auto merge of #4372 - phansch:changelog_update, r=flip1995
docs: Explain how to update the changelog
cc @Manishearth Is this more or less how you did it last time?
[Rendered](https://github.com/phansch/rust-clippy/blob/changelog_update/doc/changelog_update.md#changelog-update)
changelog: none
bors [Wed, 21 Aug 2019 08:15:36 +0000 (08:15 +0000)]
Auto merge of #4352 - phansch:fix_redundant_pattern_matching, r=flip1995
Fix some suggestions for redundant_pattern_matching
.. and change the Applicability to `MaybeIncorrect`.
Fixes the problem displayed in https://github.com/rust-lang/rust-clippy/issues/4344#issuecomment-
519206388 .
We now append `{}` to the suggestion so that the conditional has the
correct syntax again.
(If we were to _remove_ the `if` instead, it would trigger the
`unused_must_use` warning for `#[must_use]` types.)
changelog: Fix some suggestions for `redundant_pattern_matching`
bors [Wed, 21 Aug 2019 07:25:58 +0000 (07:25 +0000)]
Auto merge of #4425 - mikerite:4375, r=flip1995
Fix `temporary_cstring_as_ptr` false negative
Fixes #4375.
Changes the check to test when `.unwrap().as_ptr()` is called on any
`Result<CString, _>` as suggested by @flip1995
(https://github.com/rust-lang/rust-clippy/issues/4375#issuecomment-
520724123 ).
changelog: Fix `temporary_cstring_as_ptr` false negative
Philipp Hansch [Wed, 21 Aug 2019 05:43:42 +0000 (07:43 +0200)]
Add two more tests, allow 2 other lints.
Michael Wright [Wed, 21 Aug 2019 05:35:04 +0000 (07:35 +0200)]
Fix `temporary_cstring_as_ptr` false negative
Fixes #4375.
Changes the check to test when `.unwrap().as_ptr()` is called on any
`Result<CString, _>` as suggested by @flip1995
(https://github.com/rust-lang/rust-clippy/issues/4375#issuecomment-
520724123 ).
Philipp Hansch [Thu, 8 Aug 2019 19:27:50 +0000 (21:27 +0200)]
Add more testcases for redundant_pattern_matching
These should make sure that, when the suggestions are fixed, they are
fixed for all these cases.
Philipp Hansch [Wed, 7 Aug 2019 18:34:23 +0000 (20:34 +0200)]
Fix suggestions for redundant_pattern_matching
Fixes the problem displayed in https://github.com/rust-lang/rust-clippy/issues/4344#issuecomment-
519206388 .
We now append `{}` to the suggestion so that the conditional has the
correct syntax again.
(If we were to _remove_ the `if` instead, it would trigger the
`unused_must_use` warning for `#[must_use]` types.
Philipp Hansch [Wed, 21 Aug 2019 05:23:48 +0000 (07:23 +0200)]
Add note on how to find the latest beta commit
bors [Tue, 20 Aug 2019 23:26:12 +0000 (23:26 +0000)]
Auto merge of #4423 - lzutao:await-is-stable, r=Manishearth
Remove feature gate for async_await
async/await is stablized in https://github.com/rust-lang/rust/pull/63209 :tada:
changelog: none
Lzu Tao [Tue, 20 Aug 2019 23:21:39 +0000 (23:21 +0000)]
Remove feature gate for async_await
bors [Tue, 20 Aug 2019 08:22:23 +0000 (08:22 +0000)]
Auto merge of #4419 - lzutao:ifchain-link, r=phansch
Update if_chain doc link
changelog: none
bors [Tue, 20 Aug 2019 07:54:25 +0000 (07:54 +0000)]
Auto merge of #4401 - JJJollyjim:literal-separation-suggestion, r=flip1995
Add autofixable suggestion for unseparated integer literal suffixes
changelog: Add autofixable suggestion for unseparated integer literal suffixes
Somewhat WIP, since I haven't been able to get this working when adding `// run-rustfix` to `ui/literals.rs`. I think the issue is that there are multiple suggestions operating on one numerical literal, and I'm not sure what the best approach is to work around that.
Thanks
bors [Tue, 20 Aug 2019 05:33:23 +0000 (05:33 +0000)]
Auto merge of #4420 - phansch:disable_rls_integration_test, r=phansch
Disable RLS integration test
until RLS has been updated to the latest Clippy commit.
cc https://github.com/rust-lang/rust-clippy/pull/4416#issuecomment-
522859091
changelog: none
Philipp Hansch [Tue, 20 Aug 2019 05:28:59 +0000 (07:28 +0200)]
Merge pull request #4416 from SimonSapin/plugin
Import rustc_plugin from its new location
Philipp Hansch [Tue, 20 Aug 2019 05:27:14 +0000 (07:27 +0200)]
Disable RLS integration test
until RLS has been updated to the latest Clippy commit.
Lzu Tao [Tue, 20 Aug 2019 02:59:13 +0000 (09:59 +0700)]
Update if_chain doc link
bors [Mon, 19 Aug 2019 19:47:50 +0000 (19:47 +0000)]
Auto merge of #4417 - kraai:remove-in_macro_or_desugar, r=phansch
Remove in_macro_or_desugar
`in_macro_or_desugar` is just a wrapper around `Span::from_expansion`, so remove the former and call the latter instead.
changelog: Remove `in_macro_or_desugar`.
KRAAI, MATTHEW [VISUS] [Mon, 19 Aug 2019 19:38:33 +0000 (12:38 -0700)]
Restore en dashes
KRAAI, MATTHEW [VISUS] [Mon, 19 Aug 2019 16:30:32 +0000 (09:30 -0700)]
Remove in_macro_or_desugar
Simon Sapin [Mon, 19 Aug 2019 15:51:39 +0000 (17:51 +0200)]
Import rustc_plugin from its new location
Depends on https://github.com/rust-lang/rust/pull/62727
bors [Mon, 19 Aug 2019 10:29:11 +0000 (10:29 +0000)]
Auto merge of #4414 - chansuke:fix-contributing-doc, r=phansch
Fix the name of a channel of discord in CONTRIBUTING.md
Fixes #4400.
changelog: none
Update the naming of the Discord channel.
chansuke [Mon, 19 Aug 2019 09:27:47 +0000 (18:27 +0900)]
Fix the name of a channel of discord in CONTRIBUTING.md
Jamie McClymont [Mon, 19 Aug 2019 08:22:42 +0000 (20:22 +1200)]
Requested test cleanup
bors [Mon, 19 Aug 2019 08:04:12 +0000 (08:04 +0000)]
Auto merge of #4411 - mikerite:fix-4384, r=flip1995
Fix `clone_on_copy` false positives
Closes #4384
changelog: Fix `clone_on_copy` false positives
bors [Mon, 19 Aug 2019 07:35:53 +0000 (07:35 +0000)]
Auto merge of #4386 - lzutao:lint-option-and_then-some, r=flip1995
Add option_and_then_some lint
changelog: Add complexity lint to warn about `option.and_then(|o| Some(x))` and suggest replacing with `option.map(|o| x)`.
Closes #4299
bors [Mon, 19 Aug 2019 06:20:01 +0000 (06:20 +0000)]
Auto merge of #4410 - matthiaskrgr:url_serde_feat, r=phansch
deps: try to fix build in rustc repo: enable serde feature url dep in clippy-lints crate
This might fix the problem in https://github.com/rust-lang/rust/pull/63587
I didn't have time to test this yet.
r? @flip1995
changelog: enable serde feature of url dep in clippy-lints to depened on it in the same way cargo does