]>
git.lizzy.rs Git - rust.git/log
Oliver Schneider [Fri, 16 Mar 2018 08:44:20 +0000 (09:44 +0100)]
Rustup
Oliver Schneider [Thu, 15 Mar 2018 15:42:09 +0000 (16:42 +0100)]
Merge pull request #2531 from mati865/master
Rustup
Mateusz Mikuła [Thu, 15 Mar 2018 12:24:51 +0000 (13:24 +0100)]
Fix warning
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 09:58:52 +0000 (10:58 +0100)]
Update tests after merge
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 09:49:13 +0000 (10:49 +0100)]
Merge branch 'miri'
Mateusz Mikuła [Thu, 15 Mar 2018 09:25:57 +0000 (10:25 +0100)]
Update tests
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
Mateusz Mikuła [Thu, 15 Mar 2018 09:25:40 +0000 (10:25 +0100)]
Rustup
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
llogiq [Tue, 13 Mar 2018 16:12:52 +0000 (16:12 +0000)]
Merge pull request #2524 from rust-lang-nursery/update_dependencies
Update dependencies
Oliver Schneider [Tue, 13 Mar 2018 14:02:40 +0000 (15:02 +0100)]
Update dependencies
Oliver Schneider [Tue, 13 Mar 2018 10:38:11 +0000 (11:38 +0100)]
Update to rustc master
Oliver Schneider [Mon, 12 Mar 2018 07:19:52 +0000 (08:19 +0100)]
Merge pull request #2520 from ordovicia/remove-duct
Remove duct dependency
Oliver Schneider [Sun, 11 Mar 2018 13:04:28 +0000 (14:04 +0100)]
Merge pull request #2519 from ordovicia/issue-2516
Fix #2516
Hidehito Yabuuchi [Sun, 11 Mar 2018 05:07:16 +0000 (14:07 +0900)]
Remove duct dependency
Hidehito Yabuuchi [Sun, 11 Mar 2018 05:03:09 +0000 (14:03 +0900)]
Fix comment
Hidehito Yabuuchi [Sun, 11 Mar 2018 04:57:28 +0000 (13:57 +0900)]
Ignore all macros in redundant_field_names
Oliver Schneider [Thu, 8 Mar 2018 07:15:26 +0000 (08:15 +0100)]
Merge pull request #2515 from kimsnj/infinite_loop
lint: while immutable condition: do not lint constants
Karim Snj [Wed, 7 Mar 2018 17:24:36 +0000 (18:24 +0100)]
lint: while immutable condition: do not lint constants
Oliver Schneider [Wed, 7 Mar 2018 07:09:48 +0000 (08:09 +0100)]
Merge pull request #2483 from kimsnj/infinite_loop
immutable while condition
Karim Snj [Tue, 6 Mar 2018 17:27:11 +0000 (18:27 +0100)]
lint: immutable condition: add internally mutable test
Oliver Schneider [Tue, 6 Mar 2018 13:35:54 +0000 (14:35 +0100)]
Merge pull request #2511 from flip1995/sus_impl
UnNeg and UnNot count as additional operations now
Oliver Schneider [Tue, 6 Mar 2018 13:35:18 +0000 (14:35 +0100)]
Merge pull request #2513 from niklasf/increase-unreadable-literal
Increase unreadable_literal digits (fixes #1958)
Niklas Fiekas [Tue, 6 Mar 2018 13:06:27 +0000 (14:06 +0100)]
Increase unreadable_literal digits (fixes #1958)
flip1995 [Tue, 6 Mar 2018 12:58:03 +0000 (13:58 +0100)]
UnNeg and UnNot count as additional operations now
Karim Snj [Mon, 5 Mar 2018 21:20:28 +0000 (22:20 +0100)]
lint: while immutable condition: refactor to use ExprUseVisitor
Oliver Schneider [Mon, 5 Mar 2018 10:13:55 +0000 (11:13 +0100)]
Merge pull request #2509 from ordovicia/redundant_field_names_range
Remove unused variable and a minor refactoring
Hidehito Yabuuchi [Mon, 5 Mar 2018 09:20:27 +0000 (18:20 +0900)]
Move call of `is_range_expression()` outside of blocks
Oliver Schneider [Mon, 5 Mar 2018 08:41:00 +0000 (09:41 +0100)]
Merge pull request #2507 from ordovicia/redundant_field_names_range
Don't lint range syntax with var name `start` and/or `end`
Hidehito Yabuuchi [Mon, 5 Mar 2018 08:40:42 +0000 (17:40 +0900)]
Unused variable is left
Oliver Schneider [Mon, 5 Mar 2018 08:35:11 +0000 (09:35 +0100)]
Merge pull request #2493 from bootandy/fix_cow
Lint passing Cow by reference
Hidehito Yabuuchi [Mon, 5 Mar 2018 08:30:07 +0000 (17:30 +0900)]
Make `redundant_field_name` not care range expressions
Hand-written `Range` struct family are treated normally.
Oliver Schneider [Mon, 5 Mar 2018 07:43:17 +0000 (08:43 +0100)]
Merge pull request #2497 from waywardmonkeys/single-char-pattern
Fix single_char_pattern for \n, \t, etc.
Oliver Schneider [Mon, 5 Mar 2018 07:42:19 +0000 (08:42 +0100)]
Merge branch 'master' into fix_cow
Oliver Schneider [Mon, 5 Mar 2018 07:38:32 +0000 (08:38 +0100)]
Merge pull request #2504 from flip1995/lit_float_repr
Fix unreadable_literal lint for scientific float notation
Oliver Schneider [Mon, 5 Mar 2018 07:33:37 +0000 (08:33 +0100)]
Typo
Oliver Schneider [Mon, 5 Mar 2018 07:32:32 +0000 (08:32 +0100)]
Merge pull request #2506 from HMPerson1/fix_2496
Fix #2496
Hidehito Yabuuchi [Mon, 5 Mar 2018 05:31:37 +0000 (14:31 +0900)]
Don't lint range syntax with var name `start` and `end`
HMPerson1 [Mon, 5 Mar 2018 03:56:03 +0000 (22:56 -0500)]
Fix #2496
flip1995 [Sun, 4 Mar 2018 15:28:34 +0000 (16:28 +0100)]
Fix unreadable_literal lint for scientific float notation
Martin Carton [Sun, 4 Mar 2018 15:17:50 +0000 (16:17 +0100)]
Merge pull request #2502 from flip1995/compiletest_version
Use compiletest version v0.3.7
flip1995 [Sun, 4 Mar 2018 12:20:25 +0000 (13:20 +0100)]
Use compiletest version v0.3.7
bootandy [Sat, 3 Mar 2018 00:13:54 +0000 (19:13 -0500)]
Change recomendation to: &[type] from Cow<type>
Alex Butler [Thu, 1 Mar 2018 15:15:41 +0000 (15:15 +0000)]
Fix #2494 add suggestion for unreadable_literal
Add `rustc --explain E0308` line to relevant tests
Bruce Mitchener [Fri, 2 Mar 2018 15:00:01 +0000 (22:00 +0700)]
Fix single_char_pattern for \n, \t, etc.
Single characters that are escaped weren't being searched / replaced
correctly in the hint string, so it was saying to replace, say,
`"\n"` with `"\n"` rather than `'\n'`.
Karim Snj [Thu, 1 Mar 2018 22:23:41 +0000 (23:23 +0100)]
lint: while loop: detect if no var from the condition is mutated
Karim Snj [Thu, 1 Mar 2018 21:00:43 +0000 (22:00 +0100)]
lint: while immutable condition: refactor to use hir::Visitor
Martin Carton [Thu, 1 Mar 2018 18:26:28 +0000 (19:26 +0100)]
Merge pull request #2495 from alexheretic/fix-2494
Fix #2494 add suggestion for unreadable_literal
Alex Butler [Thu, 1 Mar 2018 15:15:41 +0000 (15:15 +0000)]
Fix #2494 add suggestion for unreadable_literal
Add `rustc --explain E0308` line to relevant tests
bootandy [Wed, 28 Feb 2018 15:24:10 +0000 (10:24 -0500)]
Lint passing Cow by reference
Add lint for reference to Cow to the same place in the code where
lint for reference to String lives.
https://github.com/rust-lang-nursery/rust-clippy/issues/2405
Manish Goregaokar [Mon, 26 Feb 2018 20:33:45 +0000 (12:33 -0800)]
Merge pull request #2486 from ordovicia/fix
Fix for rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Manish Goregaokar [Mon, 26 Feb 2018 20:32:18 +0000 (12:32 -0800)]
Bump to 0.0.187
Manish Goregaokar [Mon, 26 Feb 2018 20:31:29 +0000 (12:31 -0800)]
oops
Manish Goregaokar [Mon, 26 Feb 2018 20:26:35 +0000 (12:26 -0800)]
Merge pull request #2489 from rust-lang-nursery/rustup
Rustup to rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Manish Goregaokar [Mon, 26 Feb 2018 19:57:14 +0000 (11:57 -0800)]
Rustup to rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Hidehito Yabuuchi [Mon, 26 Feb 2018 09:01:10 +0000 (18:01 +0900)]
Fix for rustc 1.26.0-nightly (
322d7f7b9 2018-02-25)
Karim Snj [Sun, 25 Feb 2018 17:25:31 +0000 (18:25 +0100)]
lint: immutable only vars in while condition
Oliver Schneider [Sat, 24 Feb 2018 21:06:25 +0000 (22:06 +0100)]
Merge pull request #2479 from gnieto/fix/authorLint
Fix author lint
Guillem Nieto [Sat, 24 Feb 2018 18:34:51 +0000 (19:34 +0100)]
Remove explicit visit_qpath method
Instead of replacing the default behaviour of the visit_qpath method,
I've moved the printing code to private method of PrintVisitor
(print_qpath).
Guillem Nieto [Sat, 24 Feb 2018 01:02:48 +0000 (02:02 +0100)]
Fix author lint
The author lint was generating invalid code as shown on issue:
https://github.com/rust-lang-nursery/rust-clippy/issues/2442
I've changed the generated code to properly track cast
expressions.
Unfortunatelly, I've had to rewrite the `visit_decl` method, to
avoid that last if of the chain will be added. After looking at the code,
this last line was being added because of the `let x: char` part, but not
because of the `0x45df as char` expression.
It seems that let statements should not generate code on the author
lint, but I'm not sure that this is true or if I'm breaking
something on other code generation parts.
Finally, I've added a test for the author lint, but I'm not sure that
this needs to be added to the testsuite.
Manish Goregaokar [Fri, 23 Feb 2018 17:03:18 +0000 (09:03 -0800)]
Merge branch 'rustup'
Manish Goregaokar [Fri, 23 Feb 2018 16:59:42 +0000 (08:59 -0800)]
Update Rust to
063deba92e
Oliver Schneider [Fri, 23 Feb 2018 07:31:57 +0000 (08:31 +0100)]
Merge pull request #2471 from bootandy/fix_span2
Fix: point to correct problem part of code, update test
bootandy [Thu, 22 Feb 2018 15:11:20 +0000 (10:11 -0500)]
Do not pass Span by reference
Oliver Schneider [Wed, 21 Feb 2018 20:44:04 +0000 (21:44 +0100)]
Merge pull request #2473 from phansch/handle_multiline_attributes
Lint multiline attributes properly
Philipp Hansch [Wed, 21 Feb 2018 20:11:38 +0000 (21:11 +0100)]
Lint multiline attributes properly
This makes it so that the `empty_line_after_outer_attribute` lint only
checks for newlines between the end of the attribute and the beginning
of the following item.
We need to check for the empty line count being bigger than 2 because
now the snippet of valid code contains only `\n` and splitting it
produces `["", ""]`
Invalid code will contain more than 2 empty strings.
bootandy [Wed, 21 Feb 2018 16:25:18 +0000 (11:25 -0500)]
Stop unwanted newlines being applied on unwrap_or
bootandy [Tue, 20 Feb 2018 17:38:20 +0000 (12:38 -0500)]
Simplify creation of span_replace_word
Part of unwrap_or test
bootandy [Tue, 20 Feb 2018 17:37:30 +0000 (12:37 -0500)]
Add newlines in unwrap_or ui test
Oliver Schneider [Tue, 20 Feb 2018 07:33:47 +0000 (08:33 +0100)]
Merge pull request #2459 from phansch/mention_how_to_run_single_test
Explain how to execute a single UI test
Oliver Schneider [Tue, 20 Feb 2018 07:32:01 +0000 (08:32 +0100)]
Merge pull request #2458 from flip1995/suspicious_impl
Lint for suspicious implementations of arithmetic std::ops traits
Oliver Schneider [Tue, 20 Feb 2018 07:26:22 +0000 (08:26 +0100)]
Merge pull request #2470 from flip1995/doc_conf
Fix name of configuration parameters in documentation
bootandy [Thu, 15 Feb 2018 14:56:12 +0000 (09:56 -0500)]
Fix: point to correct problem part of code
Fix span so it no longer contains the whole train-wreck of code and only
points to the problem function (for the unwrap_or lint).
https://github.com/rust-lang-nursery/rust-clippy/issues/2422
Update ui test methods - it had several cases where the error message
span is now shorter
flip1995 [Mon, 19 Feb 2018 15:30:19 +0000 (16:30 +0100)]
Fix name of configuration parameters in documentation
Philipp Krones [Mon, 19 Feb 2018 12:04:14 +0000 (13:04 +0100)]
Merge branch 'master' into suspicious_impl
Oliver Schneider [Mon, 19 Feb 2018 08:56:55 +0000 (09:56 +0100)]
Merge pull request #2451 from TomasKralCZ/rdn-fields
Implement redundant field names lint #2244
Philipp Hansch [Tue, 13 Feb 2018 21:33:42 +0000 (22:33 +0100)]
Explain how to execute a single UI test
flip1995 [Tue, 13 Feb 2018 14:40:17 +0000 (15:40 +0100)]
Lint for suspicious implementations of arithmetic std::ops traits
TomasKralCZ [Sun, 11 Feb 2018 09:50:19 +0000 (10:50 +0100)]
Suggestion fixed, simplified lint logic.
TomasKralCZ [Sat, 10 Feb 2018 20:13:17 +0000 (21:13 +0100)]
Implement redundant field names lint #2244
Oliver Schneider [Fri, 9 Feb 2018 17:32:23 +0000 (18:32 +0100)]
Merge pull request #2448 from rust-lang-nursery/fixes
Fixes
Oliver Schneider [Fri, 9 Feb 2018 14:23:51 +0000 (15:23 +0100)]
Fixes #2426 (if_same_then_else false positive)
Oliver Schneider [Fri, 9 Feb 2018 13:22:50 +0000 (14:22 +0100)]
Fix #2427
Oliver Schneider [Fri, 9 Feb 2018 13:22:41 +0000 (14:22 +0100)]
Remove rarely used `type_size` helper function
Oliver Schneider [Fri, 9 Feb 2018 11:41:08 +0000 (12:41 +0100)]
Merge pull request #2446 from goodmanjonathan/fix-copies-test
Make several tests actually test the correct lints
Oliver Schneider [Fri, 9 Feb 2018 07:06:51 +0000 (08:06 +0100)]
Merge pull request #2445 from guido4000/patch-1
Simplify recommended command
Jonathan Goodman [Thu, 8 Feb 2018 19:26:50 +0000 (13:26 -0600)]
make the copies.rs test actually test the correct lints
Guido [Thu, 8 Feb 2018 11:37:56 +0000 (12:37 +0100)]
Change command to run clippy without installation
Guido [Wed, 7 Feb 2018 18:24:38 +0000 (19:24 +0100)]
Simplify recommended command
Oliver Schneider [Wed, 7 Feb 2018 08:07:46 +0000 (09:07 +0100)]
Merge pull request #2444 from phansch/fix_incorrect_useless_attribute_suggestion
Partly fix incorrect useless_attribute suggestion
Philipp Hansch [Tue, 6 Feb 2018 21:14:23 +0000 (22:14 +0100)]
Partly fix incorrect useless_attribute suggestion
This fixes an incorrect suggestion from the `useless_attribute` lint
when using `cfg_attr`.
Additionally, it will not show a suggestion anymore, if the attribute
begins on a previous line, because it is much harder to construct the
span of multi-line `cfg_attr` attributes as they don't appear in the AST.
To fix it completely, one would have to parse upwards into the file,
and find the beginning of the `cfg_attr` attribute.
Oliver Schneider [Tue, 6 Feb 2018 18:35:26 +0000 (19:35 +0100)]
Merge pull request #2443 from goodmanjonathan/fix-2438
Don't suggest eliding 'static on associated consts
Jonathan Goodman [Tue, 6 Feb 2018 18:22:34 +0000 (12:22 -0600)]
don't suggest eliding 'static on associated consts
Oliver Schneider [Tue, 6 Feb 2018 12:47:28 +0000 (13:47 +0100)]
Merge pull request #2441 from flip1995/literal_rep
Make decimal_literal_representation a restriction lint
flip1995 [Tue, 6 Feb 2018 12:05:20 +0000 (13:05 +0100)]
Make decimal_literal_representation a restriction lint
Oliver Schneider [Tue, 6 Feb 2018 08:19:51 +0000 (09:19 +0100)]
Merge pull request #2439 from gnieto/fix/cterror
Fix ICE comparing `ExprRange` equality
Guillem Nieto [Mon, 5 Feb 2018 23:31:06 +0000 (00:31 +0100)]
Fix ICE comparing `ExprRange`
`eq_expr` on hir::utils was throwing an ICE due to an invalid
LateContext being used. Due to this missusage, it was generating an ICE
with the code on the following issue:
https://github.com/rust-lang-nursery/rust-clippy/issues/2423
Oliver Schneider [Mon, 5 Feb 2018 10:28:09 +0000 (11:28 +0100)]
Cleanup calls to `layout_of`
Oliver Schneider [Mon, 5 Feb 2018 07:48:40 +0000 (08:48 +0100)]
Version Bump
Oliver Schneider [Mon, 5 Feb 2018 07:21:21 +0000 (08:21 +0100)]
Merge pull request #2433 from kimsnj/matches_sugg
Fix suggestions for ref matches
Oliver Schneider [Mon, 5 Feb 2018 07:19:11 +0000 (08:19 +0100)]
Merge pull request #2415 from HMPerson1/fix-2356
Fix `ImplItem`s being ignored
Oliver Schneider [Mon, 5 Feb 2018 07:18:20 +0000 (08:18 +0100)]
Merge pull request #2428 from phansch/fix_lint_list_issues
Allow empty lines in lint doc examples