]> git.lizzy.rs Git - rust.git/log
rust.git
8 years agoRustfmt config
Manish Goregaokar [Mon, 4 Jan 2016 04:25:29 +0000 (09:55 +0530)]
Rustfmt config

8 years agoMerge pull request #513 from mcarton/entries
Manish Goregaokar [Mon, 4 Jan 2016 04:06:42 +0000 (09:36 +0530)]
Merge pull request #513 from mcarton/entries

Implement  #433

8 years agoAdd better error messages for HashMapLint
mcarton [Sun, 3 Jan 2016 16:19:49 +0000 (17:19 +0100)]
Add better error messages for HashMapLint

8 years agoFinish the HashMapLint
mcarton [Sun, 3 Jan 2016 15:31:28 +0000 (16:31 +0100)]
Finish the HashMapLint

8 years agoMove eq_op::is_exp_equal to utils
mcarton [Sun, 3 Jan 2016 14:49:25 +0000 (15:49 +0100)]
Move eq_op::is_exp_equal to utils

8 years agoImplement a HashMapLint
mcarton [Mon, 21 Dec 2015 23:35:56 +0000 (00:35 +0100)]
Implement a HashMapLint

8 years agoMerge branch 'pr-538'
Manish Goregaokar [Sun, 3 Jan 2016 15:56:04 +0000 (21:26 +0530)]
Merge branch 'pr-538'

Conflicts:
README.md

8 years agofixups
Manish Goregaokar [Sun, 3 Jan 2016 15:55:09 +0000 (21:25 +0530)]
fixups

8 years agoMerge pull request #539 from mcarton/small-fix
Manish Goregaokar [Sun, 3 Jan 2016 14:54:16 +0000 (20:24 +0530)]
Merge pull request #539 from mcarton/small-fix

Small fix

8 years agoRemove x rights on a test file
mcarton [Sun, 3 Jan 2016 13:43:29 +0000 (14:43 +0100)]
Remove x rights on a test file

8 years agoUse same error message for OPTION_UNWRAP_USED and RESULT_UNWRAP_USED
mcarton [Sun, 3 Jan 2016 13:36:24 +0000 (14:36 +0100)]
Use same error message for OPTION_UNWRAP_USED and RESULT_UNWRAP_USED

IIRC, Result::expect wasn't stable until quite recently, which might be
why there was 2 different error messages.

8 years agoAdd new lint on function naming check (the '_')
Guillaume Gomez [Sun, 3 Jan 2016 13:00:42 +0000 (14:00 +0100)]
Add new lint on function naming check (the '_')

8 years agoAdd missing WRONG_PUB_SELF_CONVENTION in lint_array! and corresponding test
mcarton [Sun, 3 Jan 2016 13:22:27 +0000 (14:22 +0100)]
Add missing WRONG_PUB_SELF_CONVENTION in lint_array! and corresponding test

8 years agoMerge pull request #537 from GuillaumeGomez/fields_test
Manish Goregaokar [Sat, 2 Jan 2016 22:25:57 +0000 (03:55 +0530)]
Merge pull request #537 from GuillaumeGomez/fields_test

Add test for wild fields

8 years agoAdd test for wild fields
Guillaume Gomez [Sat, 2 Jan 2016 22:13:15 +0000 (23:13 +0100)]
Add test for wild fields

8 years agoMerge pull request #520 from mcarton/#471
llogiq [Sat, 2 Jan 2016 20:07:56 +0000 (21:07 +0100)]
Merge pull request #520 from mcarton/#471

Implement #471

8 years agoMerge pull request #535 from GuillaumeGomez/improve_field_help
llogiq [Sat, 2 Jan 2016 20:05:22 +0000 (21:05 +0100)]
Merge pull request #535 from GuillaumeGomez/improve_field_help

Add help on field binding

8 years agoMerge branch 'master' of https://github.com/Manishearth/rust-clippy into #471
mcarton [Sat, 2 Jan 2016 18:36:45 +0000 (19:36 +0100)]
Merge branch 'master' of https://github.com/Manishearth/rust-clippy into #471

8 years agoMerge pull request #534 from Manishearth/macros
llogiq [Sat, 2 Jan 2016 18:16:27 +0000 (19:16 +0100)]
Merge pull request #534 from Manishearth/macros

Add a smarter macro check, use it

8 years agoAdd macro check for box vec (fixes #529)
Manish Goregaokar [Sat, 2 Jan 2016 16:19:53 +0000 (21:49 +0530)]
Add macro check for box vec (fixes #529)

8 years agoAdd smarter macro check for block_in_if (fixes #528)
Manish Goregaokar [Sat, 2 Jan 2016 16:11:48 +0000 (21:41 +0530)]
Add smarter macro check for block_in_if (fixes #528)

8 years agoImprove documentation on match_ref_pats (fixes #532)
Manish Goregaokar [Sat, 2 Jan 2016 11:03:44 +0000 (16:33 +0530)]
Improve documentation on match_ref_pats (fixes #532)

8 years agoBump to 35
Manish Goregaokar [Sat, 2 Jan 2016 10:40:31 +0000 (16:10 +0530)]
Bump to 35

8 years agoRustup to syntax::errors changes
Manish Goregaokar [Thu, 31 Dec 2015 20:39:03 +0000 (02:09 +0530)]
Rustup to syntax::errors changes

8 years agoAdd help on field binding
Guillaume Gomez [Sat, 2 Jan 2016 04:52:13 +0000 (05:52 +0100)]
Add help on field binding

8 years agoMerge pull request #527 from karyon/master
llogiq [Fri, 1 Jan 2016 22:28:11 +0000 (23:28 +0100)]
Merge pull request #527 from karyon/master

Add "warn/allow by default" to lint descriptions

8 years agoMinor documentation cleanups
Johannes Linke [Fri, 1 Jan 2016 16:49:01 +0000 (17:49 +0100)]
Minor documentation cleanups

8 years agoRemove reference to a fixed issue
Johannes Linke [Fri, 1 Jan 2016 16:48:46 +0000 (17:48 +0100)]
Remove reference to a fixed issue

8 years agoAdd "warn/allow by default" to lint descriptions where it was missing.
Johannes Linke [Fri, 1 Jan 2016 16:48:19 +0000 (17:48 +0100)]
Add "warn/allow by default" to lint descriptions where it was missing.

8 years agoMerge pull request #524 from devonhollowood/iterator-suggestions
Manish Goregaokar [Thu, 31 Dec 2015 08:46:15 +0000 (14:16 +0530)]
Merge pull request #524 from devonhollowood/iterator-suggestions

Iterator suggestions

8 years agoMake MethodsPass lint notes clearer
Devon Hollowood [Wed, 30 Dec 2015 09:07:40 +0000 (01:07 -0800)]
Make MethodsPass lint notes clearer

8 years agoBug fix
Devon Hollowood [Wed, 30 Dec 2015 08:55:38 +0000 (00:55 -0800)]
Bug fix

8 years agoAdd SEARCH_IS_SOME lint
Devon Hollowood [Wed, 30 Dec 2015 08:38:03 +0000 (00:38 -0800)]
Add SEARCH_IS_SOME lint

8 years agoRemove * dep
Manish Goregaokar [Tue, 29 Dec 2015 04:55:53 +0000 (10:25 +0530)]
Remove * dep

8 years agoAdd FILTER_NEXT lint
Devon Hollowood [Tue, 29 Dec 2015 00:56:58 +0000 (16:56 -0800)]
Add FILTER_NEXT lint

8 years agoMerge pull request #522 from devonhollowood/methods_refactor
Manish Goregaokar [Mon, 28 Dec 2015 09:06:01 +0000 (14:36 +0530)]
Merge pull request #522 from devonhollowood/methods_refactor

Refactor `check_expr()` impl for `MethodsPass`

8 years agoReplace `match_method_chain()` with `method_chain_args()`
Devon Hollowood [Sun, 27 Dec 2015 22:15:09 +0000 (14:15 -0800)]
Replace `match_method_chain()` with `method_chain_args()`

8 years agoRefactor `check_expr()` impl for `MethodsPass`
Devon Hollowood [Sun, 27 Dec 2015 09:22:53 +0000 (01:22 -0800)]
Refactor `check_expr()` impl for `MethodsPass`

8 years agoFix panic lint
Manish Goregaokar [Thu, 24 Dec 2015 09:57:31 +0000 (15:27 +0530)]
Fix panic lint

8 years agoFix #518
mcarton [Wed, 23 Dec 2015 21:37:52 +0000 (22:37 +0100)]
Fix #518

8 years agoFix missing parameter in `panic!`
mcarton [Wed, 23 Dec 2015 21:36:37 +0000 (22:36 +0100)]
Fix missing parameter in `panic!`

8 years agoPut tests in tests folder
mcarton [Wed, 23 Dec 2015 16:48:30 +0000 (17:48 +0100)]
Put tests in tests folder

8 years agoInclude error message in tests
mcarton [Wed, 23 Dec 2015 10:26:35 +0000 (11:26 +0100)]
Include error message in tests

8 years agoOnly run MATCH_OVERLAPPING_ARM on integral matches
mcarton [Wed, 23 Dec 2015 10:25:44 +0000 (11:25 +0100)]
Only run MATCH_OVERLAPPING_ARM on integral matches

8 years agoFix typo
mcarton [Wed, 23 Dec 2015 10:25:32 +0000 (11:25 +0100)]
Fix typo

8 years agoMerge pull request #519 from fhartwig/block-in-if-expr-false-positive
Manish Goregaokar [Wed, 23 Dec 2015 02:26:40 +0000 (07:56 +0530)]
Merge pull request #519 from fhartwig/block-in-if-expr-false-positive

Don't trigger block_in_if_condition_expr lint if the block is unsafe

8 years agoBump cargo (fixes #517)
Manish Goregaokar [Wed, 23 Dec 2015 02:23:01 +0000 (07:53 +0530)]
Bump cargo (fixes #517)

8 years agoUpdate README
mcarton [Wed, 23 Dec 2015 01:41:20 +0000 (02:41 +0100)]
Update README

8 years agoSplit MatchPass::check_expr for dogfood
mcarton [Wed, 23 Dec 2015 01:19:32 +0000 (02:19 +0100)]
Split MatchPass::check_expr for dogfood

8 years agoConsider literal patterns in MATCH_OVERLAPPING_ARM
mcarton [Wed, 23 Dec 2015 01:06:18 +0000 (02:06 +0100)]
Consider literal patterns in MATCH_OVERLAPPING_ARM

8 years agoImplement #471
mcarton [Wed, 23 Dec 2015 00:14:10 +0000 (01:14 +0100)]
Implement #471

8 years agoDon't trigger block_in_if_condition_expr lint if the block is unsafe
Florian Hartwig [Wed, 23 Dec 2015 01:12:08 +0000 (02:12 +0100)]
Don't trigger block_in_if_condition_expr lint if the block is unsafe

8 years agoMerge pull request #509 from mcarton/array-indexing
Manish Goregaokar [Tue, 22 Dec 2015 04:52:06 +0000 (10:22 +0530)]
Merge pull request #509 from mcarton/array-indexing

Implement #364

8 years agoMerge pull request #514 from mcarton/remove-dup
Manish Goregaokar [Tue, 22 Dec 2015 04:48:12 +0000 (10:18 +0530)]
Merge pull request #514 from mcarton/remove-dup

Remove dup

8 years agoMerge pull request #512 from untitaker/curse-you-hirvec
Manish Goregaokar [Tue, 22 Dec 2015 04:30:41 +0000 (10:00 +0530)]
Merge pull request #512 from untitaker/curse-you-hirvec

Nightly fixes

8 years agoFix typo
mcarton [Mon, 21 Dec 2015 23:51:15 +0000 (00:51 +0100)]
Fix typo

8 years agoRemove duplicated if_let_chain! macro definition
mcarton [Mon, 21 Dec 2015 23:48:50 +0000 (00:48 +0100)]
Remove duplicated if_let_chain! macro definition

8 years agoNightly fixes
Markus Unterwaditzer [Mon, 21 Dec 2015 23:22:35 +0000 (00:22 +0100)]
Nightly fixes

As of
https://github.com/rust-lang/rust/commit/e3da2a90033d233bf6d77e3c725880c12cfc8728#diff-12e06f1e9ca371a11bdc4615f50a4071L59
HirVec is syntax::ptr::P instead of Vec.

8 years agoMerge pull request #511 from mcarton/format
Manish Goregaokar [Mon, 21 Dec 2015 20:51:18 +0000 (02:21 +0530)]
Merge pull request #511 from mcarton/format

Fix some typos

8 years agoFix some typos
mcarton [Mon, 21 Dec 2015 19:47:19 +0000 (20:47 +0100)]
Fix some typos

8 years agoImplement #364
mcarton [Mon, 21 Dec 2015 18:22:29 +0000 (19:22 +0100)]
Implement #364

8 years agoMerge pull request #508 from devonhollowood/underscore_macros
Manish Goregaokar [Mon, 21 Dec 2015 11:53:56 +0000 (17:23 +0530)]
Merge pull request #508 from devonhollowood/underscore_macros

Implement #507

8 years agoAdd RustcEncodable test
Devon Hollowood [Mon, 21 Dec 2015 09:40:19 +0000 (01:40 -0800)]
Add RustcEncodable test

8 years agoImplement #507
Devon Hollowood [Mon, 21 Dec 2015 09:03:12 +0000 (01:03 -0800)]
Implement #507

Make `used_underscore_binding` lint compatible with MacroAttributes
expansions. TODO: Add a good test for this.

8 years agoAdd macro check to used_underscore
Manish Goregaokar [Sat, 19 Dec 2015 23:15:31 +0000 (04:45 +0530)]
Add macro check to used_underscore

8 years agoRust upgrade to rustc 1.7.0-nightly (8ad12c3e2 2015-12-19)
Manish Goregaokar [Sat, 19 Dec 2015 13:38:22 +0000 (19:08 +0530)]
Rust upgrade to rustc 1.7.0-nightly (8ad12c3e2 2015-12-19)

8 years agoMerge pull request #499 from devonhollowood/underscore_binding
Manish Goregaokar [Sat, 19 Dec 2015 13:32:06 +0000 (19:02 +0530)]
Merge pull request #499 from devonhollowood/underscore_binding

Add used_underscore_binding lint

8 years agoAdd test for struct fields
Devon Hollowood [Sat, 19 Dec 2015 00:29:22 +0000 (16:29 -0800)]
Add test for struct fields

8 years agoMake compatible with `unused_variables` lint
Devon Hollowood [Sat, 19 Dec 2015 00:04:33 +0000 (16:04 -0800)]
Make compatible with `unused_variables` lint

8 years agoTest that we do not lint for multiple underscores
Devon Hollowood [Fri, 18 Dec 2015 21:47:12 +0000 (13:47 -0800)]
Test that we do not lint for multiple underscores

8 years agoRemove local variable check
Devon Hollowood [Fri, 18 Dec 2015 21:45:03 +0000 (13:45 -0800)]
Remove local variable check

8 years agoAdd more tests
Devon Hollowood [Thu, 17 Dec 2015 21:52:30 +0000 (13:52 -0800)]
Add more tests

8 years agoMerge pull request #494 from sanxiyn/suggestion-2
Manish Goregaokar [Thu, 17 Dec 2015 16:47:32 +0000 (22:17 +0530)]
Merge pull request #494 from sanxiyn/suggestion-2

Use suggestion for needless_return

8 years agoMake suggested changes
Devon Hollowood [Wed, 16 Dec 2015 23:28:06 +0000 (15:28 -0800)]
Make suggested changes

8 years agoMerge pull request #503 from sanxiyn/dogfood
Manish Goregaokar [Wed, 16 Dec 2015 14:53:29 +0000 (20:23 +0530)]
Merge pull request #503 from sanxiyn/dogfood

Don't dogfood twice

8 years agoDon't dogfood twice
Seo Sanghyeon [Wed, 16 Dec 2015 14:13:01 +0000 (23:13 +0900)]
Don't dogfood twice

8 years agoMerge pull request #502 from Manishearth/contrib
Manish Goregaokar [Tue, 15 Dec 2015 00:06:42 +0000 (05:36 +0530)]
Merge pull request #502 from Manishearth/contrib

Add short section on lint docs

8 years agoAdd short section on lint docs
llogiq [Mon, 14 Dec 2015 21:23:33 +0000 (22:23 +0100)]
Add short section on lint docs

8 years agoadding missing doc comments
llogiq [Mon, 14 Dec 2015 21:16:56 +0000 (22:16 +0100)]
adding missing doc comments

8 years agofix boxed_local example
llogiq [Mon, 14 Dec 2015 20:17:11 +0000 (21:17 +0100)]
fix boxed_local example

8 years agoMerge pull request #501 from oli-obk/fix/seme
Manish Goregaokar [Mon, 14 Dec 2015 16:53:42 +0000 (22:23 +0530)]
Merge pull request #501 from oli-obk/fix/seme

fix cyclomatic complexity lint (fixes #491, fixes #478)

8 years agofix fallout from CC improvements
Oliver Schneider [Mon, 14 Dec 2015 13:30:09 +0000 (14:30 +0100)]
fix fallout from CC improvements

8 years agofix cc computation in the presence of diverging calls
Oliver Schneider [Mon, 14 Dec 2015 13:29:20 +0000 (14:29 +0100)]
fix cc computation in the presence of diverging calls

CFG treats diverging calls as its completely own path out of the function.
While this makes sense, it should also mean that a panic should increase the cyclomatic
complexity. Instead it decreases it.

Minimal example:

```rust
if a {
    b
} else {
    panic!("cake");
}
d
```

creates the following graph

```dot
digraph G {
  "if a" -> "b"
  "if a" -> "panic!(\"cake\")"
  "b" -> c
}
```

which has a CC of 1 (3 - 4 + 2). A CC of 1 means there is one path through the program.
Obviously that is wrong. There are two paths. One returning normally, and one panicking.

8 years agomore doc comments
llogiq [Mon, 14 Dec 2015 12:31:28 +0000 (13:31 +0100)]
more doc comments

8 years agoMerge pull request #500 from oli-obk/patch-1
Manish Goregaokar [Mon, 14 Dec 2015 12:21:25 +0000 (17:51 +0530)]
Merge pull request #500 from oli-obk/patch-1

compiletest_rs needs to be at least 0.0.11

8 years agocompiletest_rs needs to be at least 0.0.11
Oliver Schneider [Mon, 14 Dec 2015 10:28:22 +0000 (11:28 +0100)]
compiletest_rs needs to be at least 0.0.11

otherwise tests using `SUGGESTION` will fail (see `compile-fail/eta.rs`)

8 years agomore docs
llogiq [Mon, 14 Dec 2015 07:03:01 +0000 (08:03 +0100)]
more docs

8 years agoMerge branch 'more_wiki'
Manish Goregaokar [Sun, 13 Dec 2015 16:28:18 +0000 (21:58 +0530)]
Merge branch 'more_wiki'

8 years agoMake ExprField follow single-underscore rules
Devon Hollowood [Sun, 13 Dec 2015 05:59:25 +0000 (21:59 -0800)]
Make ExprField follow single-underscore rules

8 years agoAdd wiki docs, in line with #492
Devon Hollowood [Sun, 13 Dec 2015 05:50:36 +0000 (21:50 -0800)]
Add wiki docs, in line with #492

8 years agoMake clippy tests compatible with new lint
Devon Hollowood [Sun, 13 Dec 2015 05:35:35 +0000 (21:35 -0800)]
Make clippy tests compatible with new lint

8 years agoReduce false positives
Devon Hollowood [Sun, 13 Dec 2015 01:51:58 +0000 (17:51 -0800)]
Reduce false positives

Add macro checking, and only lint for single leading underscores

8 years agoUpdate tests
Devon Hollowood [Sun, 13 Dec 2015 00:31:34 +0000 (16:31 -0800)]
Update tests

8 years agoRun update_lints.py
Devon Hollowood [Fri, 11 Dec 2015 23:08:59 +0000 (15:08 -0800)]
Run update_lints.py

8 years agoAdd used_underscore_binding lint
Devon Hollowood [Fri, 11 Dec 2015 22:02:02 +0000 (14:02 -0800)]
Add used_underscore_binding lint

8 years agoAdd tests
Devon Hollowood [Thu, 10 Dec 2015 20:54:43 +0000 (12:54 -0800)]
Add tests

8 years agoAdd wiki note for escape analysis
Manish Goregaokar [Sun, 13 Dec 2015 03:38:58 +0000 (09:08 +0530)]
Add wiki note for escape analysis

8 years agoMerge pull request #497 from cesarb/ringbuf
Manish Goregaokar [Sun, 13 Dec 2015 00:22:55 +0000 (19:22 -0500)]
Merge pull request #497 from cesarb/ringbuf

Mention VecDeque in linkedlist lint

8 years agoMention VecDeque in linkedlist lint
Cesar Eduardo Barros [Sat, 12 Dec 2015 22:05:06 +0000 (20:05 -0200)]
Mention VecDeque in linkedlist lint

I couldn't find anything named RingBuf in the standard library. Some
search revealed that it had been renamed to VecDeque before the first
stable Rust release.

8 years agoMerge pull request #492 from Manishearth/wiki
Manish Goregaokar [Fri, 11 Dec 2015 14:20:19 +0000 (09:20 -0500)]
Merge pull request #492 from Manishearth/wiki

added wiki comments + wiki-generating python script