]>
git.lizzy.rs Git - rust.git/log
Dale Wijnand [Mon, 9 Apr 2018 21:54:17 +0000 (22:54 +0100)]
specify nightly required to install from source
when using stable cargo install fails due to #![feature] usage:
error[E0554]: #![feature] may not be used on the stable release channel
--> /Users/dnw/.cargo/registry/src/github.com-
1ecc6299db9ec823 /rustc-ap-serialize-67.0.0/lib.rs:24:1
|
24 | #![feature(rustc_private, box_syntax)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error[E0554]: #![feature] may not be used on the stable release channel
--> /Users/dnw/.cargo/registry/src/github.com-
1ecc6299db9ec823 /rustc-ap-serialize-67.0.0/lib.rs:25:1
|
25 | #![feature(core_intrinsics)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error[E0554]: #![feature] may not be used on the stable release channel
--> /Users/dnw/.cargo/registry/src/github.com-
1ecc6299db9ec823 /rustc-ap-serialize-67.0.0/lib.rs:26:1
|
26 | #![feature(i128_type)]
| ^^^^^^^^^^^^^^^^^^^^^^
error[E0554]: #![feature] may not be used on the stable release channel
--> /Users/dnw/.cargo/registry/src/github.com-
1ecc6299db9ec823 /rustc-ap-serialize-67.0.0/lib.rs:27:1
|
27 | #![feature(specialization)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 4 previous errors
error: Could not compile `rustc-ap-serialize`.
warning: build failed, waiting for other jobs to finish...
error: failed to compile `rustfmt-nightly v0.4.1 (file:///d/rustfmt)`, intermediate artifacts can be found at `/d/rustfmt/target`
Nick Cameron [Mon, 9 Apr 2018 09:07:49 +0000 (21:07 +1200)]
Try to fix a build regression before it happens
Nick Cameron [Mon, 9 Apr 2018 04:47:55 +0000 (16:47 +1200)]
Make `error_on_line_overflow` false by default
And improve docs, the error message, etc.
I think false is the better default since such errors should only occur due to a bug in Rustfmt and therefore most users should not be notified of it happening (although to be clear, it might be a 'bug' which only occurs with pathological input and therefore we won't fix it). The error has proven to be confusing and annoying in the past.
Closes #1080
Nick Cameron [Mon, 9 Apr 2018 04:31:53 +0000 (16:31 +1200)]
Reorder config options
cc #1974
Nick Cameron [Sun, 8 Apr 2018 21:54:07 +0000 (09:54 +1200)]
Fix test
Nick Cameron [Sun, 8 Apr 2018 21:49:39 +0000 (09:49 +1200)]
Merge pull request #2609 from csmoe/update_rustc_syntax
update rustc_ap_syntax
csmoe [Sun, 8 Apr 2018 14:18:18 +0000 (22:18 +0800)]
update rustc syntax 91.0.0
Seiichi Uchida [Fri, 6 Apr 2018 14:09:45 +0000 (23:09 +0900)]
Cargo update (#2602)
Update `rustc-ap-syntax` to 89.0.0 and fix up breaking changes.
Nick Cameron [Fri, 6 Apr 2018 03:32:05 +0000 (15:32 +1200)]
Merge pull request #2601 from topecongiro/fix-merge-mess
Fix up merge mess
Seiichi Uchida [Fri, 6 Apr 2018 01:31:57 +0000 (10:31 +0900)]
Fix up merge mess
Nick Cameron [Fri, 6 Apr 2018 00:41:13 +0000 (12:41 +1200)]
Merge pull request #2600 from i1skn/error_on_unformatted
Fix error_on_unformatted and skip_children override
Nick Cameron [Thu, 5 Apr 2018 23:12:53 +0000 (11:12 +1200)]
Merge pull request #2599 from topecongiro/issue-2596
Use multiple lines for imports list which exceeds max width
Nick Cameron [Thu, 5 Apr 2018 23:12:11 +0000 (11:12 +1200)]
Merge pull request #2593 from topecongiro/issue-2455
Add reorder_impl_items config option
Ivan Sorokin [Sat, 31 Mar 2018 12:27:39 +0000 (14:27 +0200)]
Fix error_on_unformatted and skip_children override
Currently, error_on_unformatted and skip_children options
specified in the config file are discarded.
This happens because CLI options have a higher priority,
but we coerce an absence of a `bool` option to `false`.
In this scenario, an absence of a `bool` option is indistinguishable
from explicetely set as `false`. We should coerce it to `None` instead,
so it does not override the one in the config file.
Nick Cameron [Thu, 5 Apr 2018 05:39:22 +0000 (17:39 +1200)]
Merge pull request #2576 from topecongiro/merge-imports
Use normalized form to format use items
Nick Cameron [Thu, 5 Apr 2018 05:36:15 +0000 (17:36 +1200)]
Merge pull request #2589 from topecongiro/issue-2588
Do not indent or unindent inside string literal
Nick Cameron [Thu, 5 Apr 2018 05:35:52 +0000 (17:35 +1200)]
Merge pull request #2581 from sinkuu/build_script
Rerun build.rs only when .git/HEAD or CFG_RELEASE_CHANNEL is changed
Nick Cameron [Thu, 5 Apr 2018 05:34:53 +0000 (17:34 +1200)]
Merge pull request #2580 from remram44/improve-where_single_line-help
Improve `where_single_line` help
Seiichi Uchida [Thu, 5 Apr 2018 04:27:42 +0000 (13:27 +0900)]
Add trailing comma when using mixed layout with block indent
Seiichi Uchida [Thu, 5 Apr 2018 04:24:18 +0000 (13:24 +0900)]
Put imports list on the next line if it exceeds max width
Seiichi Uchida [Thu, 5 Apr 2018 04:23:48 +0000 (13:23 +0900)]
Add a test for #2569
Seiichi Uchida [Mon, 2 Apr 2018 14:10:37 +0000 (23:10 +0900)]
Do not indent or unindent inside string literal
Closes #2588.
Seiichi Uchida [Mon, 2 Apr 2018 13:53:16 +0000 (22:53 +0900)]
Implement LineClasses
Seiichi Uchida [Mon, 2 Apr 2018 13:52:39 +0000 (22:52 +0900)]
Add tests for #2588
Seiichi Uchida [Wed, 4 Apr 2018 05:57:55 +0000 (14:57 +0900)]
Reorder impl items based on its kind
The ordering is defined as follows:
type < cosnt < macro < method
Items that are same kind will not be reordered: that is, the item
that an user has put first comes first.
Seiichi Uchida [Wed, 4 Apr 2018 05:57:30 +0000 (14:57 +0900)]
Add reorder_impl_items config option
memoryleak47 [Thu, 5 Apr 2018 03:47:09 +0000 (05:47 +0200)]
typo (#2598)
* typo
* more typos
Ryan Leung [Wed, 4 Apr 2018 02:02:01 +0000 (10:02 +0800)]
add tests for macro!(/* comment */) (#2592)
* add tests
Russell Cohen [Tue, 3 Apr 2018 02:10:50 +0000 (19:10 -0700)]
Include instructions to install on nightly (#2590)
Marthog [Sun, 1 Apr 2018 14:15:25 +0000 (16:15 +0200)]
Let --dump-default-config default to stdout #2579 (#2586)
Seiichi Uchida [Sun, 1 Apr 2018 14:14:52 +0000 (23:14 +0900)]
Merge pull request #2584 from sinkuu/cleanup
Misc cleanups
Shotaro Yamada [Sun, 1 Apr 2018 14:09:53 +0000 (23:09 +0900)]
Do not turn spaces in the beginning of the file into a newline (#2583)
Shotaro Yamada [Sun, 1 Apr 2018 12:47:55 +0000 (21:47 +0900)]
Fix typo
Shotaro Yamada [Sun, 1 Apr 2018 12:43:01 +0000 (21:43 +0900)]
Use ListItem::has_comment
Shotaro Yamada [Sun, 1 Apr 2018 12:35:51 +0000 (21:35 +0900)]
Remove redudant parens
Shotaro Yamada [Sun, 1 Apr 2018 12:21:52 +0000 (21:21 +0900)]
Return String instead of always returing Cow::Owned
Shotaro Yamada [Sun, 1 Apr 2018 12:10:31 +0000 (21:10 +0900)]
Remove stray comment
Its pointee was removed in
04a6d16c7b68587f8e9fa8a1e6715f80408b023b
Shotaro Yamada [Sun, 1 Apr 2018 10:35:00 +0000 (19:35 +0900)]
Do not collect into a Vec by hand
Shotaro Yamada [Sun, 1 Apr 2018 09:12:50 +0000 (18:12 +0900)]
Remove unnecessary `[..]`s
Shotaro Yamada [Sun, 1 Apr 2018 09:43:52 +0000 (18:43 +0900)]
Use Iterator methods
Shotaro Yamada [Sun, 1 Apr 2018 07:20:46 +0000 (16:20 +0900)]
Use str::repeat
Shotaro Yamada [Sun, 1 Apr 2018 07:45:23 +0000 (16:45 +0900)]
Rerun build.rs only when .git/HEAD or CFG_RELEASE_CHANNEL is changed
Remi Rampin [Sat, 31 Mar 2018 22:51:41 +0000 (18:51 -0400)]
Improve where_single_line help
Ivan Sorokin [Sat, 31 Mar 2018 15:54:44 +0000 (17:54 +0200)]
Add test #2574 (#2577)
Seiichi Uchida [Sat, 31 Mar 2018 05:47:50 +0000 (14:47 +0900)]
Cargo fmt
Seiichi Uchida [Sat, 31 Mar 2018 05:23:20 +0000 (14:23 +0900)]
Cargo fmt
Seiichi Uchida [Sat, 31 Mar 2018 04:21:13 +0000 (13:21 +0900)]
Format normalized use item
This commit implements `Rewrite` trait on `UseTree`, which is a normalized
form of `ast::UseTree` for rustfmt.
Seiichi Uchida [Sat, 31 Mar 2018 04:19:55 +0000 (13:19 +0900)]
Do not include separator to post comment
This prevents the trailing `;` on use item to be treated as comment.
Seiichi Uchida [Sat, 31 Mar 2018 04:18:53 +0000 (13:18 +0900)]
Do not insert newline when item is empty
This change is necessary when we remove unused imports (`use std::{};`).
Seiichi Uchida [Sat, 31 Mar 2018 04:16:36 +0000 (13:16 +0900)]
Update tests
1. snake_case < CamelCase < UPPER_SNAKE_CASE
2. Use vertical layout for list with nested imports.
Seiichi Uchida [Fri, 30 Mar 2018 08:52:09 +0000 (17:52 +0900)]
Cargo update (#2575)
Update `rustc-ap-syntax` to 82.0.0.
Seiichi Uchida [Thu, 29 Mar 2018 00:16:38 +0000 (09:16 +0900)]
Merge pull request #2572 from codeworm96/remove_unreachable
Remove unreachable! from macros.rs
codeworm96 [Wed, 28 Mar 2018 15:50:21 +0000 (23:50 +0800)]
Add test for #2558
When run against invalid macro definitions, rustfmt should leave
them unchanged rather than panic.
codeworm96 [Wed, 28 Mar 2018 15:38:34 +0000 (23:38 +0800)]
Remove unreachable! from macros.rs
replaced unreachable! with error handling using Option.
Closes #2558
Nick Cameron [Wed, 28 Mar 2018 15:02:49 +0000 (17:02 +0200)]
Merge pull request #2571 from topecongiro/issue-2569
Avoid panicking on macro call with a single comma
Nick Cameron [Wed, 28 Mar 2018 15:01:16 +0000 (17:01 +0200)]
Merge pull request #2557 from topecongiro/vertical-layout-complex-attrs
Use vertical layout for complex attributes
Nick Cameron [Wed, 28 Mar 2018 14:49:25 +0000 (16:49 +0200)]
Merge pull request #2562 from topecongiro/issue-2196
Combine simple heuristics for function calls and array
Seiichi Uchida [Wed, 28 Mar 2018 09:14:51 +0000 (18:14 +0900)]
Avoid panicking on macro call with a single comma
`parse_item` from libsyntax may return `None`, so we need to discard
the result in that case.
Seiichi Uchida [Wed, 28 Mar 2018 08:41:58 +0000 (17:41 +0900)]
Update tests
Seiichi Uchida [Wed, 28 Mar 2018 07:56:39 +0000 (16:56 +0900)]
Follow indent style config when formatting attrs
Seiichi Uchida [Wed, 28 Mar 2018 03:41:51 +0000 (12:41 +0900)]
Merge pull request #2563 from rleungx/allow-underscore
allow underscore in macro_rules!
rleungx [Mon, 26 Mar 2018 12:45:39 +0000 (20:45 +0800)]
allow underscore
Seiichi Uchida [Tue, 27 Mar 2018 05:33:01 +0000 (14:33 +0900)]
Merge pull request #2568 from mtn/features_typo
/s/featuers/features
Michael Noronha [Tue, 27 Mar 2018 03:40:39 +0000 (22:40 -0500)]
/s/featuers/features
Nick Cameron [Mon, 26 Mar 2018 21:07:34 +0000 (23:07 +0200)]
Merge pull request #2567 from cramertj/master
Allow stabilization of match_default_bindings
Taylor Cramer [Mon, 26 Mar 2018 20:29:01 +0000 (22:29 +0200)]
Allow stabilization of match_default_bindings
Nick Cameron [Mon, 26 Mar 2018 05:01:24 +0000 (18:01 +1300)]
Merge pull request #2556 from topecongiro/issue-2554
Do not add the beginning vert to the match arm
Seiichi Uchida [Sun, 25 Mar 2018 22:38:39 +0000 (07:38 +0900)]
Update tests and cargo fmt
Seiichi Uchida [Sun, 25 Mar 2018 22:36:44 +0000 (07:36 +0900)]
Format array using overflow module
This commit applies heuristics used for function calls to array
and vice versa.
Seiichi Uchida [Sun, 25 Mar 2018 22:34:17 +0000 (07:34 +0900)]
Factor out default_tactic and fix indentation
rustfmt fails to handle binary expressions with comments in-between.
Seiichi Uchida [Sun, 25 Mar 2018 22:32:48 +0000 (07:32 +0900)]
Replace MacroStyle with ast::DelimToken
Seiichi Uchida [Sun, 25 Mar 2018 11:20:50 +0000 (20:20 +0900)]
Avoid cloning RewriteContext
topecongiro [Sun, 25 Mar 2018 06:17:41 +0000 (15:17 +0900)]
Use vertical layout for complex attributes
Seiichi Uchida [Fri, 23 Mar 2018 10:59:38 +0000 (19:59 +0900)]
Do not add the beginning vert to the match arm
Pass the span after the match's condition expression.
Closes #2554.
Nick Cameron [Thu, 22 Mar 2018 21:51:47 +0000 (10:51 +1300)]
Merge pull request #2549 from topecongiro/macro-def-spaces-around-colon
Add config option to control spaces around colon in macro def
Nick Cameron [Thu, 22 Mar 2018 21:50:41 +0000 (10:50 +1300)]
Merge pull request #2553 from topecongiro/rustc-ap-syntax
Update rustc-ap-syntax to 73.0.0
topecongiro [Thu, 22 Mar 2018 07:09:21 +0000 (16:09 +0900)]
Cargo fmt and update tests
topecongiro [Thu, 22 Mar 2018 07:08:57 +0000 (16:08 +0900)]
Remove a space after a colon of metavariable def in macro def
topecongiro [Thu, 22 Mar 2018 07:01:41 +0000 (16:01 +0900)]
Update a test
topecongiro [Thu, 22 Mar 2018 06:56:51 +0000 (15:56 +0900)]
Use `UseSegment::Slf` or `UseSegment::Super` when appropriate
Currently we `UseSegment::Ident` for all of the segments except the last.
E.g. `use super::foo::bar::self;` will be
`[Ident("super"), Ident("foo"), Ident("bar"), Self(None)]`.
in the current implementation. I think that this should be
`[Super(None), Ident("foo"), Ident("bar"), Self(None)]`.
instead.
I noticed this because some tests failed after updating
`rustc-ap-syntax` to 73.0.0.
topecongiro [Thu, 22 Mar 2018 06:55:14 +0000 (15:55 +0900)]
Fix libsyntax updates
`ast::UseTreeKind::Simple` now takes `Option<ast::Ident>`
instead of `ast::Ident`.
topecongiro [Thu, 22 Mar 2018 06:53:43 +0000 (15:53 +0900)]
Fix libsyntax update
Underscore is now one of keywords.
topecongiro [Thu, 22 Mar 2018 06:53:08 +0000 (15:53 +0900)]
Cargo update
Update rustc-ap-syntax to 73.0.0.
Nick Cameron [Thu, 22 Mar 2018 05:04:31 +0000 (18:04 +1300)]
Merge pull request #2552 from alanhdu/master
Close #2551
Alan Du [Thu, 22 Mar 2018 04:57:22 +0000 (00:57 -0400)]
Close #2551
Alan Du [Thu, 22 Mar 2018 04:01:09 +0000 (00:01 -0400)]
Fix build
Nick Cameron [Thu, 22 Mar 2018 03:26:48 +0000 (16:26 +1300)]
Merge pull request #2550 from sinkuu/chars_count_index
Don't index a string with chars().count()/position()
Nick Cameron [Thu, 22 Mar 2018 02:40:36 +0000 (15:40 +1300)]
Merge pull request #2548 from topecongiro/match-mod
Do not collapse block around expr with condition on match arm
Nick Cameron [Thu, 22 Mar 2018 02:08:01 +0000 (15:08 +1300)]
Merge pull request #2535 from nrc/import-ord
Import ordering
Shotaro Yamada [Wed, 21 Mar 2018 14:58:23 +0000 (23:58 +0900)]
Omit unnecessary UTF-8 decoding
Shotaro Yamada [Wed, 21 Mar 2018 23:34:36 +0000 (08:34 +0900)]
Use take_while
Shotaro Yamada [Wed, 21 Mar 2018 23:32:42 +0000 (08:32 +0900)]
Don't index a string with `chars().count()`
Seiichi Uchida [Wed, 21 Mar 2018 13:20:03 +0000 (22:20 +0900)]
Do not collapse block around expr with condition on match arm
Closes #2376.
Seiichi Uchida [Wed, 21 Mar 2018 13:02:18 +0000 (22:02 +0900)]
Add matches module
`matches` module contains `rewrite_match` and related stuffs.
Nick Cameron [Mon, 19 Mar 2018 20:54:00 +0000 (09:54 +1300)]
Return grouping `extern crate` to true by default
Nick Cameron [Fri, 16 Mar 2018 07:57:35 +0000 (20:57 +1300)]
reviewer comments and rebase fallout
Nick Cameron [Thu, 15 Mar 2018 19:18:56 +0000 (08:18 +1300)]
Better handle comments and newlines around erased imports
Nick Cameron [Thu, 15 Mar 2018 01:06:54 +0000 (14:06 +1300)]
fixup tests
Nick Cameron [Wed, 14 Mar 2018 07:43:01 +0000 (20:43 +1300)]
cargo fmt
Nick Cameron [Mon, 12 Mar 2018 07:56:02 +0000 (20:56 +1300)]
Reimplement import reordering.