]>
git.lizzy.rs Git - rust.git/log
Aleksey Kladov [Sun, 19 Sep 2021 08:34:25 +0000 (11:34 +0300)]
minor: improve readability
Aleksey Kladov [Sun, 19 Sep 2021 08:19:31 +0000 (11:19 +0300)]
minor: reduce duplication
bors[bot] [Sat, 18 Sep 2021 13:09:51 +0000 (13:09 +0000)]
Merge #10276
10276: internal: parser cleanup r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 18 Sep 2021 13:09:12 +0000 (16:09 +0300)]
fix: correctly handle jointness
Aleksey Kladov [Sat, 18 Sep 2021 12:56:26 +0000 (15:56 +0300)]
minor: improve readability
Aleksey Kladov [Sat, 18 Sep 2021 12:54:55 +0000 (15:54 +0300)]
internal: better naming
Aleksey Kladov [Sat, 18 Sep 2021 12:46:28 +0000 (15:46 +0300)]
internal: parser cleanup
Aleksey Kladov [Sat, 18 Sep 2021 12:22:49 +0000 (15:22 +0300)]
internal: minimize use_tree parser tests
The code here is intentionally dense and does exactly what is written.
Explaining semantic difference between Rust 2015 and 2018 doesn't help
with understanding syntax. Better to just add more targeted tests.
bors[bot] [Sat, 18 Sep 2021 12:20:55 +0000 (12:20 +0000)]
Merge #10275
10275: internal: parser cleanups r=Veykril a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Sat, 18 Sep 2021 11:53:46 +0000 (14:53 +0300)]
internal: parser cleanups
bors[bot] [Sat, 18 Sep 2021 11:43:10 +0000 (11:43 +0000)]
Merge #10274
10274: feat: Make inlay hints work in attributed items r=Veykril a=Veykril
Attempt at #10043(previous attempt #10231)
![image](https://user-images.githubusercontent.com/
3757771 /
133887500 -
091675db -f473-44f8-9bf5-
8313ecfbc9e7 .png)
Slight difference to the first approach, chaining hints now work but attribute inputs do not as they are basically the same as normal macros in that they take a token tree.
Fixes #10043
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Aleksey Kladov [Sat, 18 Sep 2021 11:34:29 +0000 (14:34 +0300)]
internal: more focused trait item parsing tests
Lukas Wirth [Sat, 18 Sep 2021 11:19:29 +0000 (13:19 +0200)]
Make inlay hints work in attributed items
bors[bot] [Sat, 18 Sep 2021 10:00:47 +0000 (10:00 +0000)]
Merge #10273
10273: minor: Add multi-token mapping test for goto_definition r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Sat, 18 Sep 2021 09:59:57 +0000 (11:59 +0200)]
Add multi-token mapping test for goto_definition
bors[bot] [Sat, 18 Sep 2021 01:21:43 +0000 (01:21 +0000)]
Merge #10252
10252: fix: make `goto_definition` multi-token mapping aware r=Veykril a=XFFXFF
Implement #10070 in [`goto_definition`](https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/goto_definition.rs)
Co-authored-by: zhoufan <1247714429@qq.com>
zhoufan [Sat, 18 Sep 2021 00:22:57 +0000 (08:22 +0800)]
do comment handling on the original token
bors[bot] [Fri, 17 Sep 2021 22:44:39 +0000 (22:44 +0000)]
Merge #10267
10267: Narrow "if-let to match" assist available range r=Veykril a=rainy-me
ref: https://github.com/rust-analyzer/rust-analyzer/issues/10220
Co-authored-by: rainy-me <github@rainy.me>
bors[bot] [Fri, 17 Sep 2021 22:05:16 +0000 (22:05 +0000)]
Merge #10270
10270: intenral: more item parsing cleanup r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 17 Sep 2021 22:02:43 +0000 (01:02 +0300)]
intenral: more local tests for statics
Aleksey Kladov [Fri, 17 Sep 2021 21:58:35 +0000 (00:58 +0300)]
minor: cleanup const parsing
Aleksey Kladov [Fri, 17 Sep 2021 21:54:03 +0000 (00:54 +0300)]
minor: better test placement
Aleksey Kladov [Fri, 17 Sep 2021 21:50:27 +0000 (00:50 +0300)]
internal: cleanup adt parsing
bors[bot] [Fri, 17 Sep 2021 21:39:06 +0000 (21:39 +0000)]
Merge #10269
10269: internal: cleanup item parsing r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 17 Sep 2021 21:33:42 +0000 (00:33 +0300)]
internal: cleanup item parsing
Aleksey Kladov [Fri, 17 Sep 2021 21:14:20 +0000 (00:14 +0300)]
minor: parser cleanup
bors[bot] [Fri, 17 Sep 2021 20:35:02 +0000 (20:35 +0000)]
Merge #10268
10268: intenral: simplify parser r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 17 Sep 2021 20:31:37 +0000 (23:31 +0300)]
minor: simplify
rainy-me [Fri, 17 Sep 2021 20:27:24 +0000 (05:27 +0900)]
Narrow "if-let to match" assist available range
Aleksey Kladov [Fri, 17 Sep 2021 20:27:26 +0000 (23:27 +0300)]
minor: cleanup
bors[bot] [Fri, 17 Sep 2021 19:27:32 +0000 (19:27 +0000)]
Merge #10265
10265: internal: parser cleanups r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Fri, 17 Sep 2021 19:26:39 +0000 (22:26 +0300)]
minor: simplify
Aleksey Kladov [Fri, 17 Sep 2021 19:21:07 +0000 (22:21 +0300)]
internal: more local parsing tests for macros
Aleksey Kladov [Fri, 17 Sep 2021 19:15:12 +0000 (22:15 +0300)]
internal: more focused parsing tests
Aleksey Kladov [Fri, 17 Sep 2021 18:53:24 +0000 (21:53 +0300)]
internal: more local test for mod item
Aleksey Kladov [Fri, 17 Sep 2021 18:49:01 +0000 (21:49 +0300)]
internal: more local parsing tests
Aleksey Kladov [Fri, 17 Sep 2021 18:40:28 +0000 (21:40 +0300)]
internal: parser cleanups
bors[bot] [Fri, 17 Sep 2021 18:35:36 +0000 (18:35 +0000)]
Merge #10260
10260: fix: fix names generation in `Generate function` r=Veykril a=iDawer
- Improve fn name computation (close #10176).
- Handle tuple indexing expressions in argument position (should close #10241)
Co-authored-by: Dawer <7803845+iDawer@users.noreply.github.com>
bors[bot] [Fri, 17 Sep 2021 18:28:55 +0000 (18:28 +0000)]
Merge #10264
10264: fix: Don't seek outside of character boundaries in completion handler r=Veykril a=iDawer
Fixes #10219 panic when entering `:` in `$0` places:
```rust
fn main() {
"⊞$0";
}
```
```rust
struct S {
д$0 u8
}
```
Co-authored-by: Dawer <7803845+iDawer@users.noreply.github.com>
Dawer [Fri, 17 Sep 2021 18:04:20 +0000 (23:04 +0500)]
fix completion handler trying to seek outside of character boundaries.
With this patch, in these examples
```rust
fn main() {
"⊞$0";
}
```
```rust
struct S {
д$0 u8
}
```
entering ':' character in `$0` places shouldn't cause panics.
bors[bot] [Thu, 16 Sep 2021 21:04:42 +0000 (21:04 +0000)]
Merge #10257
10257: assists: turn while into loop r=Veykril a=agluszak
Implements an assist to turn a `while` loop into a `loop` loop, as requested in #10214.
I'm not sure sure what the guidelines are regarding naming assists convert_x_to_y vs replace_x_with_y.
This is my first commit to rust-analyzer :D Thank you `@matklad` for your awesome Explaining rust-analyzer series <3
Closes #10214
Co-authored-by: Andrzej Głuszak <gluszak.andrzej@gmail.com>
Andrzej Głuszak [Thu, 16 Sep 2021 13:36:44 +0000 (15:36 +0200)]
assists: turn while into loop
Dawer [Thu, 16 Sep 2021 18:45:41 +0000 (23:45 +0500)]
Handle tuple indexing expression in argument position in `Generate function`
Dawer [Thu, 16 Sep 2021 16:03:37 +0000 (21:03 +0500)]
Imrove fn name computation in `Generate function`
bors[bot] [Thu, 16 Sep 2021 05:27:24 +0000 (05:27 +0000)]
Merge #10254
10254: Fix a comment typo in autoderef.rs r=lnicola a=teor2345
There's a minor typo in a comment in autoderef.rs, although the meaning is clear if your pronounce the words out loud
Co-authored-by: teor <teor@riseup.net>
bors[bot] [Thu, 16 Sep 2021 05:19:38 +0000 (05:19 +0000)]
Merge #10251
10251: Fix typescript syntax errors r=lnicola a=Wilfred
Remove unwanted `:` and fix the naming of the boolean type.
Co-authored-by: Wilfred Hughes <me@wilfred.me.uk>
teor [Thu, 16 Sep 2021 03:47:01 +0000 (13:47 +1000)]
Fix a comment typo in autoderef.rs
zhoufan [Thu, 16 Sep 2021 01:44:22 +0000 (09:44 +0800)]
fix: multi-token mapping aware goto definition
Wilfred Hughes [Thu, 16 Sep 2021 00:53:36 +0000 (17:53 -0700)]
Fix typescript syntax errors
Remove unwanted `:` and fix the naming of the boolean type.
bors[bot] [Thu, 16 Sep 2021 00:26:32 +0000 (00:26 +0000)]
Merge #10250
10250: internal: Improve call_hierarchy and incoming/outgoing_calls r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Thu, 16 Sep 2021 00:25:02 +0000 (02:25 +0200)]
Improve call_hierarchy and incoming/outgoing_calls
bors[bot] [Wed, 15 Sep 2021 18:23:46 +0000 (18:23 +0000)]
Merge #10248
10248: internal: remove dead code r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Wed, 15 Sep 2021 18:22:06 +0000 (21:22 +0300)]
internal: remove dead code
bors[bot] [Wed, 15 Sep 2021 18:13:09 +0000 (18:13 +0000)]
Merge #10048
10048: fix: correctly complete macro call if cursor at `!` r=Veykril a=unexge
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/9904
Co-authored-by: unexge <unexge@gmail.com>
bors[bot] [Wed, 15 Sep 2021 16:36:33 +0000 (16:36 +0000)]
Merge #10233
10233: fix: add multi-token mapping support to hovers r=Veykril a=spookyvision
implement #10070 in [`hover`](https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/ide/src/hover.rs)
Co-authored-by: Anatol Ulrich <anatol.ulrich@ferrous-systems.com>
Anatol Ulrich [Wed, 15 Sep 2021 16:05:48 +0000 (18:05 +0200)]
add multi-token mappings for hover
Anatol Ulrich [Tue, 14 Sep 2021 02:01:21 +0000 (04:01 +0200)]
# This is a combination of 3 commits.
# This is the 1st commit message:
add multi-token mappings for hover
# The commit message #2 will be skipped:
# make fallback an Option instead of vec
# The commit message #3 will be skipped:
# fix indentation
bors[bot] [Wed, 15 Sep 2021 14:29:55 +0000 (14:29 +0000)]
Merge #10247
10247: fix: Don't highlight unsafe traits as unsafe in safe impls r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Wed, 15 Sep 2021 13:46:45 +0000 (15:46 +0200)]
Don't highlight unsafe traits as unsafe in safe impls
bors[bot] [Tue, 14 Sep 2021 18:31:59 +0000 (18:31 +0000)]
Merge #10240
10240: internal: Revert attributed items inlay hints r=Veykril a=Veykril
Reverts #10231 as the implementation there is actually wrong
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 14 Sep 2021 18:30:28 +0000 (20:30 +0200)]
Revert attributed items inlay hints
bors[bot] [Tue, 14 Sep 2021 16:30:41 +0000 (16:30 +0000)]
Merge #10237
10237: fix: Do not wrap inlined local in parens when at block tail position r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 14 Sep 2021 16:29:34 +0000 (18:29 +0200)]
fix: Do not wrap inlined local in parens when at block tail position
bors[bot] [Tue, 14 Sep 2021 12:54:00 +0000 (12:54 +0000)]
Merge #10232
10232: internal: Add more tests for ide functionality in attributed items r=Veykril a=Veykril
cc https://github.com/rust-analyzer/rust-analyzer/issues/9868
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Tue, 14 Sep 2021 12:41:38 +0000 (14:41 +0200)]
fix source_to_def trying to use attribute macro calls as containers
Lukas Wirth [Tue, 14 Sep 2021 12:09:52 +0000 (14:09 +0200)]
Pick smaller node ancestors first when descending at offset
Lukas Wirth [Tue, 14 Sep 2021 01:00:53 +0000 (03:00 +0200)]
Add some more attribute ide tests
Lukas Wirth [Tue, 14 Sep 2021 00:49:06 +0000 (02:49 +0200)]
fix: Use original definition ranges for ide_db::search instead of the expanded ranges
bors[bot] [Tue, 14 Sep 2021 00:41:17 +0000 (00:41 +0000)]
Merge #10204
10204: feat: Show the type of what is being dereferenced in a deref expression. r=theo-lw a=theo-lw
Addresses issue #10106.
In-progress - I'm trying to figure out why `hover_deref_expr_with_coercion` is failing.
Co-authored-by: Teddy_Wang <wangtheo662@gmail.com>
Teddy_Wang [Tue, 14 Sep 2021 00:19:30 +0000 (20:19 -0400)]
Improve hover over derference message
bors[bot] [Tue, 14 Sep 2021 00:07:50 +0000 (00:07 +0000)]
Merge #10231
10231: feat: Make inlay hints work in attributed items r=Veykril a=Veykril
![image](https://user-images.githubusercontent.com/
3757771 /
133172697 -
8563329f -e77e-46e4-86ab-
99b50040dfd5 .png)
Note the lack of chaining hints, this is currently due to macro expansion lacking the input whitespace. We might be able to recover this from the input somehow in the future.
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10043
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 13 Sep 2021 23:59:45 +0000 (01:59 +0200)]
feat: Make inlay hints work in attributed items
Teddy_Wang [Mon, 13 Sep 2021 23:47:53 +0000 (19:47 -0400)]
Fix hover tests
bors[bot] [Mon, 13 Sep 2021 23:24:33 +0000 (23:24 +0000)]
Merge #10230
10230: fix: fix expansion order for fn-like macros and attributes in token descending r=Veykril a=Veykril
Second attempt(now with a test 🎉).
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10115
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 13 Sep 2021 23:23:08 +0000 (01:23 +0200)]
Enable attribte macros in ide fixtures
Lukas Wirth [Mon, 13 Sep 2021 23:20:43 +0000 (01:20 +0200)]
fix: fix expansion order for fn-like macros and attributes in token descending
Teddy_Wang [Mon, 13 Sep 2021 23:16:10 +0000 (19:16 -0400)]
Fix spelling
bors[bot] [Mon, 13 Sep 2021 22:31:39 +0000 (22:31 +0000)]
Merge #10229
10229: fix: do not complete builtin attributes for qualified paths r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 13 Sep 2021 22:31:14 +0000 (00:31 +0200)]
fix: do not complete builtin attributes for qualified paths
bors[bot] [Mon, 13 Sep 2021 22:22:08 +0000 (22:22 +0000)]
Merge #10126
10126: feat: Speculatively expand attributes in completions r=Veykril a=Veykril
![j1OjBt5Nca](https://user-images.githubusercontent.com/
3757771 /
133163858 -
91930072 -1441-4ce4-9979-
b0ad2727b47f .gif)
Fixes #9866
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 13 Sep 2021 22:21:16 +0000 (00:21 +0200)]
Exclude test file from rust tidy check
Lukas Wirth [Mon, 13 Sep 2021 22:04:04 +0000 (00:04 +0200)]
Downmap the token in attribute inputs when expanding speculatively
bors[bot] [Mon, 13 Sep 2021 18:14:20 +0000 (18:14 +0000)]
Merge #10199
10199: fix: Fix Cargo.toml change detection r=lnicola a=lnicola
Maybe fixes #9546
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 13 Sep 2021 17:58:09 +0000 (20:58 +0300)]
Shuffle code around to avoid an allocation
Lukas Wirth [Thu, 2 Sep 2021 16:54:09 +0000 (18:54 +0200)]
Speculatively expand attributes in completions
bors[bot] [Mon, 13 Sep 2021 17:07:23 +0000 (17:07 +0000)]
Merge #10225
10225: internal: Add proc-macro fixture directive r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
bors[bot] [Mon, 13 Sep 2021 16:51:37 +0000 (16:51 +0000)]
Merge #10226
10226: minor: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Lukas Wirth [Mon, 13 Sep 2021 16:50:19 +0000 (18:50 +0200)]
Simplify
Lukas Wirth [Mon, 13 Sep 2021 16:30:04 +0000 (18:30 +0200)]
Add proc-macro fixture directive
Laurențiu Nicola [Fri, 10 Sep 2021 16:34:47 +0000 (19:34 +0300)]
Fix Cargo.toml change detection
bors[bot] [Mon, 13 Sep 2021 11:52:29 +0000 (11:52 +0000)]
Merge #10222
10222: internal: Add workaround for rename error reporting r=lnicola a=lnicola
Fixes #9875
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 13 Sep 2021 11:46:29 +0000 (14:46 +0300)]
Add workaround for rename error reporting
bors[bot] [Mon, 13 Sep 2021 11:23:43 +0000 (11:23 +0000)]
Merge #10221
10221: internal: prevent possible bugs when adding magical comments r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Aleksey Kladov [Mon, 13 Sep 2021 11:19:10 +0000 (14:19 +0300)]
internal: document tribal knowledge of how to assist
Aleksey Kladov [Mon, 13 Sep 2021 10:43:13 +0000 (13:43 +0300)]
internal: prevent possible bugs when adding magical comments
Aleksey Kladov [Mon, 13 Sep 2021 10:35:31 +0000 (13:35 +0300)]
internal: simplify
Aleksey Kladov [Mon, 13 Sep 2021 10:28:00 +0000 (13:28 +0300)]
internal: fix bugs in tests by simplifying code
Aleksey Kladov [Mon, 13 Sep 2021 09:34:05 +0000 (12:34 +0300)]
minore: improve readability
Tuples are hard to understand
bors[bot] [Mon, 13 Sep 2021 07:58:28 +0000 (07:58 +0000)]
Merge #10218
10218: minor: Don't spam the manual with warnings r=lnicola a=lnicola
A single warning on the first line should™ be enough. Currently we put that warning on every section, while also breaking the table of contents in the process:
![image](https://user-images.githubusercontent.com/308347/
133045747 -
5232ce04 -7856-40fd-a82f-
adcefb7a6f5a .png)
Fixes #9657
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Laurențiu Nicola [Mon, 13 Sep 2021 07:56:14 +0000 (10:56 +0300)]
Don't spam the manual with warnings